swaroop: new slightly-hacky way to make background image appear on stop. v2.13.67
authorCarl Hetherington <cth@carlh.net>
Wed, 7 Nov 2018 00:42:45 +0000 (00:42 +0000)
committerCarl Hetherington <cth@carlh.net>
Wed, 7 Nov 2018 00:42:45 +0000 (00:42 +0000)
src/wx/controls.cc
src/wx/film_viewer.cc
src/wx/film_viewer.h

index f7573c2..cf805e8 100644 (file)
@@ -221,10 +221,6 @@ Controls::add_clicked ()
        if (!ok || !report_errors_from_last_job(this)) {
                return;
        }
-       if (_film->content().size() == 1) {
-               /* Put 1 frame of black at the start so when we seek to 0 we don't see anything */
-               sel->set_position (DCPTime::from_frames(1, _film->video_frame_rate()));
-       }
        add_content_to_list (sel, _current_spl_view);
        setup_sensitivity ();
 }
index 6d9592b..afa1940 100644 (file)
@@ -306,6 +306,22 @@ FilmViewer::timer ()
        }
 }
 
+bool
+FilmViewer::maybe_draw_background_image (wxPaintDC& dc)
+{
+#ifdef DCPOMATIC_VARIANT_SWAROOP
+       optional<boost::filesystem::path> bg = Config::instance()->player_background_image();
+       if (bg) {
+               wxImage image (std_to_wx(bg->string()));
+               wxBitmap bitmap (image);
+               dc.DrawBitmap (bitmap, max(0, (_panel_size.width - image.GetSize().GetWidth()) / 2), max(0, (_panel_size.height - image.GetSize().GetHeight()) / 2));
+               return true;
+       }
+#endif
+
+       return false;
+}
+
 void
 FilmViewer::paint_panel ()
 {
@@ -313,14 +329,11 @@ FilmViewer::paint_panel ()
 
        if (!_frame || !_film || !_out_size.width || !_out_size.height || _out_size != _frame->size()) {
                dc.Clear ();
-#ifdef DCPOMATIC_VARIANT_SWAROOP
-               optional<boost::filesystem::path> bg = Config::instance()->player_background_image();
-               if (bg) {
-                       wxImage image (std_to_wx(bg->string()));
-                       wxBitmap bitmap (image);
-                       dc.DrawBitmap (bitmap, max(0, (_panel_size.width - image.GetSize().GetWidth()) / 2), max(0, (_panel_size.height - image.GetSize().GetHeight()) / 2));
-               }
-#endif
+               maybe_draw_background_image (dc);
+               return;
+       }
+
+       if (_video_position == DCPTime() && maybe_draw_background_image (dc)) {
                return;
        }
 
index b0dbf56..6f5df7e 100644 (file)
@@ -108,6 +108,7 @@ private:
        void film_change (ChangeType, Film::Property);
        void recreate_butler ();
        void config_changed (Config::Property);
+       bool maybe_draw_background_image (wxPaintDC& dc);
 
        DCPTime time () const;
        DCPTime uncorrected_time () const;