Fix failure to skip through more than one empty reel when looking for a reel to put...
authorCarl Hetherington <cth@carlh.net>
Tue, 15 May 2018 21:37:26 +0000 (22:37 +0100)
committerCarl Hetherington <cth@carlh.net>
Tue, 15 May 2018 21:37:26 +0000 (22:37 +0100)
ChangeLog
src/lib/writer.cc

index dcb0ef1..98f6c7d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2018-05-15  Carl Hetherington  <cth@carlh.net>
 
+       * Fix incorrect subtitle positining in a VF when there are more than
+       two consecutive reels with no subtitles.
+
        * Fix missing burnt-in / previewed subtitles containing ampersands.
 
 2018-05-08  Carl Hetherington  <cth@carlh.net>
index d86a2cc..896d59c 100644 (file)
@@ -660,8 +660,9 @@ Writer::write (PlayerSubtitles subs, DCPTimePeriod period)
                return;
        }
 
-       if (_subtitle_reel->period().to <= period.from) {
+       while (_subtitle_reel->period().to <= period.from) {
                ++_subtitle_reel;
+               DCPOMATIC_ASSERT (_subtitle_reel != _reels.end());
        }
 
        DCPOMATIC_ASSERT (_subtitle_reel != _reels.end());