use new action map API instead of ActionManager::get_action
[ardour.git] / gtk2_ardour / ardour_ui_options.cc
index f211e429568f59e657133b86515732a229cac182..625605447ce846270983f518efaf84762402e0ea 100644 (file)
 
 #include "pbd/convert.h"
 #include "pbd/stacktrace.h"
-
-#include <gtkmm2ext/utils.h>
+#include "pbd/unwind.h"
 
 #include "ardour/rc_configuration.h"
 #include "ardour/session.h"
+#include "ardour/transport_master_manager.h"
+
+#include "gtkmm2ext/utils.h"
+#include "waveview/wave_view.h"
 
 #include "audio_clock.h"
 #include "ardour_ui.h"
 #include "public_editor.h"
 #include "main_clock.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace Gtk;
 using namespace Gtkmm2ext;
 using namespace ARDOUR;
 using namespace PBD;
-
-void
-ARDOUR_UI::toggle_keep_tearoffs ()
-{
-       ActionManager::toggle_config_state ("Common", "KeepTearoffs", &RCConfiguration::set_keep_tearoffs, &RCConfiguration::get_keep_tearoffs);
-
-       ARDOUR_UI::update_tearoff_visibility();
-}
+using namespace ArdourWidgets;
 
 void
 ARDOUR_UI::toggle_external_sync()
 {
        if (_session) {
-               if (_session->config.get_video_pullup() != 0.0f) {
-                       if (Config->get_sync_source() == Engine) {
-                               MessageDialog msg (
-                                       _("It is not possible to use JACK as the the sync source\n\
-when the pull up/down setting is non-zero."));
-                               msg.run ();
-                               return;
-                       }
+               if (_session->config.get_video_pullup() != 0.0f && (TransportMasterManager::instance().current()->type() == Engine)) {
+                       MessageDialog msg (_("It is not possible to use JACK as the the sync source\n when the pull up/down setting is non-zero."));
+                       msg.run ();
+                       return;
                }
 
                ActionManager::toggle_config_state_foo ("Transport", "ToggleExternalSync", sigc::mem_fun (_session->config, &SessionConfiguration::set_external_sync), sigc::mem_fun (_session->config, &SessionConfiguration::get_external_sync));
@@ -73,7 +65,7 @@ when the pull up/down setting is non-zero."));
                 * This is a UI limitation, imposed by audio-clock and
                 * status displays which combine RC-config & session-properties.
                 *
-                * Notficy RCOptionEditor by emitting a signal if the active
+                * Notify RCOptionEditor by emitting a signal if the active
                 * status changed:
                 */
                Config->ParameterChanged("sync-source");
@@ -89,31 +81,25 @@ ARDOUR_UI::toggle_time_master ()
 void
 ARDOUR_UI::toggle_send_mtc ()
 {
-       ActionManager::toggle_config_state ("options", "SendMTC", &RCConfiguration::set_send_mtc, &RCConfiguration::get_send_mtc);
+       ActionManager::toggle_config_state ("Options", "SendMTC", &RCConfiguration::set_send_mtc, &RCConfiguration::get_send_mtc);
 }
 
 void
 ARDOUR_UI::toggle_send_mmc ()
 {
-       ActionManager::toggle_config_state ("options", "SendMMC", &RCConfiguration::set_send_mmc, &RCConfiguration::get_send_mmc);
+       ActionManager::toggle_config_state ("Options", "SendMMC", &RCConfiguration::set_send_mmc, &RCConfiguration::get_send_mmc);
 }
 
 void
 ARDOUR_UI::toggle_send_midi_clock ()
 {
-       ActionManager::toggle_config_state ("options", "SendMidiClock", &RCConfiguration::set_send_midi_clock, &RCConfiguration::get_send_midi_clock);
+       ActionManager::toggle_config_state ("Options", "SendMidiClock", &RCConfiguration::set_send_midi_clock, &RCConfiguration::get_send_midi_clock);
 }
 
 void
 ARDOUR_UI::toggle_use_mmc ()
 {
-       ActionManager::toggle_config_state ("options", "UseMMC", &RCConfiguration::set_mmc_control, &RCConfiguration::get_mmc_control);
-}
-
-void
-ARDOUR_UI::toggle_send_midi_feedback ()
-{
-       ActionManager::toggle_config_state ("options", "SendMIDIfeedback", &RCConfiguration::set_midi_feedback, &RCConfiguration::get_midi_feedback);
+       ActionManager::toggle_config_state ("Options", "UseMMC", &RCConfiguration::set_mmc_control, &RCConfiguration::get_mmc_control);
 }
 
 void
@@ -140,10 +126,61 @@ ARDOUR_UI::toggle_click ()
        ActionManager::toggle_config_state ("Transport", "ToggleClick", &RCConfiguration::set_clicking, &RCConfiguration::get_clicking);
 }
 
+void
+ARDOUR_UI::toggle_session_monitoring_in ()
+{
+       Glib::RefPtr<Action> act = global_actions.find_action (X_("Transport"), X_("SessionMonitorIn"));
+       if (!act) {
+               return;
+       }
+       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
+       if (!tact) {
+               return;
+       }
+
+       if (tact->get_active() && _session->config.get_session_monitoring () == MonitorInput) {
+               return;
+       }
+       if (!tact->get_active() && _session->config.get_session_monitoring () != MonitorInput) {
+               return;
+       }
+
+       if (tact->get_active()) {
+               _session->config.set_session_monitoring (MonitorInput);
+       } else {
+               _session->config.set_session_monitoring (MonitorAuto);
+       }
+}
+
+void
+ARDOUR_UI::toggle_session_monitoring_disk ()
+{
+       Glib::RefPtr<Action> act = global_actions.find_action (X_("Transport"), X_("SessionMonitorDisk"));
+       if (!act) {
+               return;
+       }
+       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
+       if (!tact) {
+               return;
+       }
+       if (tact->get_active() && _session->config.get_session_monitoring () == MonitorDisk) {
+               return;
+       }
+       if (!tact->get_active() && _session->config.get_session_monitoring () != MonitorDisk) {
+               return;
+       }
+
+       if (tact->get_active()) {
+               _session->config.set_session_monitoring (MonitorDisk);
+       } else {
+               _session->config.set_session_monitoring (MonitorAuto);
+       }
+}
+
 void
 ARDOUR_UI::unset_dual_punch ()
 {
-       Glib::RefPtr<Action> action = ActionManager::get_action ("Transport", "TogglePunch");
+       Glib::RefPtr<Action> action = global_actions.find_action ("Transport", "TogglePunch");
 
        if (action) {
                Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(action);
@@ -162,7 +199,7 @@ ARDOUR_UI::toggle_punch ()
                return;
        }
 
-       Glib::RefPtr<Action> action = ActionManager::get_action ("Transport", "TogglePunch");
+       Glib::RefPtr<Action> action = global_actions.find_action ("Transport", "TogglePunch");
 
        if (action) {
 
@@ -174,8 +211,8 @@ ARDOUR_UI::toggle_punch ()
 
                /* drive the other two actions from this one */
 
-               Glib::RefPtr<Action> in_action = ActionManager::get_action ("Transport", "TogglePunchIn");
-               Glib::RefPtr<Action> out_action = ActionManager::get_action ("Transport", "TogglePunchOut");
+               Glib::RefPtr<Action> in_action = global_actions.find_action ("Transport", "TogglePunchIn");
+               Glib::RefPtr<Action> out_action = global_actions.find_action ("Transport", "TogglePunchOut");
 
                if (in_action && out_action) {
                        Glib::RefPtr<ToggleAction> tiact = Glib::RefPtr<ToggleAction>::cast_dynamic(in_action);
@@ -189,7 +226,7 @@ ARDOUR_UI::toggle_punch ()
 void
 ARDOUR_UI::toggle_punch_in ()
 {
-       Glib::RefPtr<Action> act = ActionManager::get_action (X_("Transport"), X_("TogglePunchIn"));
+       Glib::RefPtr<Action> act = global_actions.find_action (X_("Transport"), X_("TogglePunchIn"));
        if (!act) {
                return;
        }
@@ -215,7 +252,7 @@ ARDOUR_UI::toggle_punch_in ()
 void
 ARDOUR_UI::toggle_punch_out ()
 {
-       Glib::RefPtr<Action> act = ActionManager::get_action (X_("Transport"), X_("TogglePunchOut"));
+       Glib::RefPtr<Action> act = global_actions.find_action (X_("Transport"), X_("TogglePunchOut"));
        if (!act) {
                return;
        }
@@ -241,7 +278,7 @@ ARDOUR_UI::toggle_punch_out ()
 void
 ARDOUR_UI::show_loop_punch_ruler_and_disallow_hide ()
 {
-       Glib::RefPtr<Action> act = ActionManager::get_action (X_("Rulers"), "toggle-loop-punch-ruler");
+       Glib::RefPtr<Action> act = editor->find_action (X_("Rulers"), "toggle-loop-punch-ruler");
        if (!act) {
                return;
        }
@@ -264,7 +301,7 @@ ARDOUR_UI::reenable_hide_loop_punch_ruler_if_appropriate ()
 {
        if (!_session->config.get_punch_in() && !_session->config.get_punch_out()) {
                /* if punch in/out are now both off, reallow hiding of the loop/punch ruler */
-               Glib::RefPtr<Action> act = ActionManager::get_action (X_("Rulers"), "toggle-loop-punch-ruler");
+               Glib::RefPtr<Action> act = editor->find_action (X_("Rulers"), "toggle-loop-punch-ruler");
                if (act) {
                        act->set_sensitive (true);
                }
@@ -274,7 +311,7 @@ ARDOUR_UI::reenable_hide_loop_punch_ruler_if_appropriate ()
 void
 ARDOUR_UI::toggle_video_sync()
 {
-       Glib::RefPtr<Action> act = ActionManager::get_action ("Transport", "ToggleVideoSync");
+       Glib::RefPtr<Action> act = global_actions.find_action ("Transport", "ToggleVideoSync");
        if (act) {
                Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
                _session->config.set_use_video_sync (tact->get_active());
@@ -284,7 +321,7 @@ ARDOUR_UI::toggle_video_sync()
 void
 ARDOUR_UI::toggle_editing_space()
 {
-       Glib::RefPtr<Action> act = ActionManager::get_action ("Common", "ToggleMaximalEditor");
+       Glib::RefPtr<Action> act = global_actions.find_action ("Common", "ToggleMaximalEditor");
 
        if (act) {
                Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
@@ -307,49 +344,82 @@ ARDOUR_UI::setup_session_options ()
 void
 ARDOUR_UI::parameter_changed (std::string p)
 {
-       ENSURE_GUI_THREAD (*this, &ARDOUR_UI::parameter_changed, p)
-
        if (p == "external-sync") {
 
+               /* session parameter */
+
                ActionManager::map_some_state ("Transport", "ToggleExternalSync", sigc::mem_fun (_session->config, &SessionConfiguration::get_external_sync));
 
                if (!_session->config.get_external_sync()) {
-                       sync_button.set_text (_("Internal"));
-                       ActionManager::get_action ("Transport", "ToggleAutoPlay")->set_sensitive (true);
-                       ActionManager::get_action ("Transport", "ToggleAutoReturn")->set_sensitive (true);
-                       ActionManager::get_action ("Transport", "ToggleFollowEdits")->set_sensitive (true);
+                       sync_button.set_text (S_("SyncSource|Int."));
+                       global_actions.find_action ("Transport", "ToggleAutoPlay")->set_sensitive (true);
+                       global_actions.find_action ("Transport", "ToggleAutoReturn")->set_sensitive (true);
+                       global_actions.find_action ("Transport", "ToggleFollowEdits")->set_sensitive (true);
                } else {
-                       sync_button.set_text (sync_source_to_string (Config->get_sync_source(), true));
-                       /* XXX need to make auto-play is off as well as insensitive */
-                       ActionManager::get_action ("Transport", "ToggleAutoPlay")->set_sensitive (false);
-                       ActionManager::get_action ("Transport", "ToggleAutoReturn")->set_sensitive (false);
-                       ActionManager::get_action ("Transport", "ToggleFollowEdits")->set_sensitive (false);
+                       /* XXX we need to make sure that auto-play is off as well as insensitive */
+                       global_actions.find_action ("Transport", "ToggleAutoPlay")->set_sensitive (false);
+                       global_actions.find_action ("Transport", "ToggleAutoReturn")->set_sensitive (false);
+                       global_actions.find_action ("Transport", "ToggleFollowEdits")->set_sensitive (false);
                }
 
-       } else if (p == "always-play-range") {
+       } else if (p == "sync-source") {
+
+               /* app parameter (RC config) */
+
+               if (_session) {
+                       if (!_session->config.get_external_sync()) {
+                               sync_button.set_text (S_("SyncSource|Int."));
+                       } else {
+                               sync_button.set_text (TransportMasterManager::instance().current()->display_name());
+                       }
+               } else {
+                       /* changing sync source without a session is unlikely/impossible , except during startup */
+                       sync_button.set_text (TransportMasterManager::instance().current()->display_name());
+               }
+
+       } else if (p == "follow-edits") {
 
-               ActionManager::map_some_state ("Transport", "ToggleFollowEdits", &RCConfiguration::get_always_play_range);
+               ActionManager::map_some_state ("Transport", "ToggleFollowEdits", &UIConfiguration::get_follow_edits);
 
        } else if (p == "send-mtc") {
 
-               ActionManager::map_some_state ("options", "SendMTC", &RCConfiguration::get_send_mtc);
+               ActionManager::map_some_state ("Options", "SendMTC", &RCConfiguration::get_send_mtc);
 
        } else if (p == "send-mmc") {
 
-               ActionManager::map_some_state ("options", "SendMMC", &RCConfiguration::get_send_mmc);
+               ActionManager::map_some_state ("Options", "SendMMC", &RCConfiguration::get_send_mmc);
 
-       } else if (p == "keep-tearoffs") {
-               ActionManager::map_some_state ("Common", "KeepTearoffs", &RCConfiguration::get_keep_tearoffs);
        } else if (p == "mmc-control") {
-               ActionManager::map_some_state ("options", "UseMMC", &RCConfiguration::get_mmc_control);
-       } else if (p == "midi-feedback") {
-               ActionManager::map_some_state ("options", "SendMIDIfeedback", &RCConfiguration::get_midi_feedback);
+               ActionManager::map_some_state ("Options", "UseMMC", &RCConfiguration::get_mmc_control);
        } else if (p == "auto-play") {
                ActionManager::map_some_state ("Transport", "ToggleAutoPlay", sigc::mem_fun (_session->config, &SessionConfiguration::get_auto_play));
        } else if (p == "auto-return") {
                ActionManager::map_some_state ("Transport", "ToggleAutoReturn", sigc::mem_fun (_session->config, &SessionConfiguration::get_auto_return));
        } else if (p == "auto-input") {
                ActionManager::map_some_state ("Transport", "ToggleAutoInput", sigc::mem_fun (_session->config, &SessionConfiguration::get_auto_input));
+       } else if (p == "session-monitoring") {
+               Glib::RefPtr<Action> iact = global_actions.find_action (X_("Transport"), X_("SessionMonitorIn"));
+               Glib::RefPtr<Action> dact = global_actions.find_action (X_("Transport"), X_("SessionMonitorDisk"));
+               if (iact && dact) {
+                       Glib::RefPtr<ToggleAction> tdact = Glib::RefPtr<ToggleAction>::cast_dynamic(dact);
+                       Glib::RefPtr<ToggleAction> tiact = Glib::RefPtr<ToggleAction>::cast_dynamic(iact);
+                       if (tdact && tiact) {
+                               switch (_session->config.get_session_monitoring ()) {
+                                       case MonitorDisk:
+                                               tdact->set_active (true);
+                                               tiact->set_active (false);
+                                               break;
+                                       case MonitorInput:
+                                               tiact->set_active (true);
+                                               tdact->set_active (false);
+                                               break;
+                                       default:
+                                               tdact->set_active (false);
+                                               tiact->set_active (false);
+                                               break;
+                               }
+                       }
+               }
        } else if (p == "punch-out") {
                ActionManager::map_some_state ("Transport", "TogglePunchOut", sigc::mem_fun (_session->config, &SessionConfiguration::get_punch_out));
                if (!_session->config.get_punch_out()) {
@@ -364,20 +434,15 @@ ARDOUR_UI::parameter_changed (std::string p)
                ActionManager::map_some_state ("Transport", "ToggleClick", &RCConfiguration::get_clicking);
        } else if (p == "use-video-sync") {
                ActionManager::map_some_state ("Transport",  "ToggleVideoSync", sigc::mem_fun (_session->config, &SessionConfiguration::get_use_video_sync));
-       } else if (p == "video-pullup" || p == "timecode-format") {
-
-               synchronize_sync_source_and_video_pullup ();
-               reset_main_clocks ();
-               editor->queue_visual_videotimeline_update();
-
        } else if (p == "sync-source") {
 
                synchronize_sync_source_and_video_pullup ();
+               set_fps_timeout_connection ();
 
        } else if (p == "show-track-meters") {
-               editor->toggle_meter_updating();
-       } else if (p == "primary-clock-delta-edit-cursor") {
-               if (Config->get_primary_clock_delta_edit_cursor()) {
+               if (editor) editor->toggle_meter_updating();
+       } else if (p == "primary-clock-delta-mode") {
+               if (UIConfiguration::instance().get_primary_clock_delta_mode() != NoDelta) {
                        primary_clock->set_is_duration (true);
                        primary_clock->set_editable (false);
                        primary_clock->set_widget_name ("transport delta");
@@ -386,8 +451,8 @@ ARDOUR_UI::parameter_changed (std::string p)
                        primary_clock->set_editable (true);
                        primary_clock->set_widget_name ("transport");
                }
-       } else if (p == "secondary-clock-delta-edit-cursor") {
-               if (Config->get_secondary_clock_delta_edit_cursor()) {
+       } else if (p == "secondary-clock-delta-mode") {
+               if (UIConfiguration::instance().get_secondary_clock_delta_mode() != NoDelta) {
                        secondary_clock->set_is_duration (true);
                        secondary_clock->set_editable (false);
                        secondary_clock->set_widget_name ("secondary delta");
@@ -397,21 +462,79 @@ ARDOUR_UI::parameter_changed (std::string p)
                        secondary_clock->set_widget_name ("secondary");
                }
        } else if (p == "super-rapid-clock-update") {
-               stop_clocking ();
-               start_clocking ();
+               if (_session) {
+                       stop_clocking ();
+                       start_clocking ();
+               }
+       } else if (p == "use-tooltips") {
+               /* this doesn't really belong here but it has to go somewhere */
+               if (UIConfiguration::instance().get_use_tooltips()) {
+                       Gtkmm2ext::enable_tooltips ();
+               } else {
+                       Gtkmm2ext::disable_tooltips ();
+               }
+       } else if (p == "waveform-gradient-depth") {
+               ArdourWaveView::WaveView::set_global_gradient_depth (UIConfiguration::instance().get_waveform_gradient_depth());
+       } else if (p == "show-mini-timeline") {
+               repack_transport_hbox ();
+       } else if (p == "show-dsp-load-info") {
+               repack_transport_hbox ();
+       } else if (p == "show-disk-space-info") {
+               repack_transport_hbox ();
+       } else if (p == "show-toolbar-recpunch") {
+               repack_transport_hbox ();
+       } else if (p == "show-toolbar-monitoring") {
+               repack_transport_hbox ();
+       } else if (p == "show-toolbar-selclock") {
+               repack_transport_hbox ();
        } else if (p == "show-editor-meter") {
-               bool show = Config->get_show_editor_meter();
-
-               transport_tearoff_hbox.remove (meter_box);
-               transport_tearoff_hbox.remove (editor_meter_peak_display);
-
-               if (editor_meter && show) {
-                       transport_tearoff_hbox.pack_start (meter_box, false, false);
-                       transport_tearoff_hbox.pack_start (editor_meter_peak_display, false, false);
-                       meter_box.show();
-                       editor_meter_peak_display.show();
+               repack_transport_hbox ();
+       } else if (p == "show-secondary-clock") {
+               update_clock_visibility ();
+       } else if (p == "waveform-scale") {
+               ArdourWaveView::WaveView::set_global_logscaled (UIConfiguration::instance().get_waveform_scale() == Logarithmic);
+       } else if (p == "widget-prelight") {
+               CairoWidget::set_widget_prelight (UIConfiguration::instance().get_widget_prelight());
+       } else if (p == "waveform-shape") {
+               ArdourWaveView::WaveView::set_global_shape (UIConfiguration::instance().get_waveform_shape() == Rectified
+                               ? ArdourWaveView::WaveView::Rectified : ArdourWaveView::WaveView::Normal);
+       } else if (p == "show-waveform-clipping") {
+               ArdourWaveView::WaveView::set_global_show_waveform_clipping (UIConfiguration::instance().get_show_waveform_clipping());
+       } else if (p == "waveform-cache-size") {
+               /* GUI option has units of megabytes; image cache uses units of bytes */
+               ArdourWaveView::WaveView::set_image_cache_size (UIConfiguration::instance().get_waveform_cache_size() * 1048576);
+       } else if (p == "use-wm-visibility") {
+               VisibilityTracker::set_use_window_manager_visibility (UIConfiguration::instance().get_use_wm_visibility());
+       } else if (p == "action-table-columns") {
+               const uint32_t cols = UIConfiguration::instance().get_action_table_columns ();
+               for (int i = 0; i < MAX_LUA_ACTION_SCRIPTS; ++i) {
+                       const int col = i / 2;
+                       if (cols & (1<<col)) {
+                               action_script_call_btn[i].show();
+                       } else {
+                               action_script_call_btn[i].hide();
+                       }
                }
+       } else if (p == "layered-record-mode") {
+               layered_button.set_active (_session->config.get_layered_record_mode ());
+       } else if (p == "flat-buttons") {
+               bool flat = UIConfiguration::instance().get_flat_buttons();
+               if (ArdourButton::flat_buttons () != flat) {
+                       ArdourButton::set_flat_buttons (flat);
+                       /* force a redraw */
+                       gtk_rc_reset_styles (gtk_settings_get_default());
+               }
+       } else if (p == "boxy-buttons") {
+               bool boxy = UIConfiguration::instance().get_boxy_buttons();
+               if (ArdourButton::boxy_buttons () != boxy) {
+                       ArdourButton::set_boxy_buttons (boxy);
+                       /* force a redraw */
+                       gtk_rc_reset_styles (gtk_settings_get_default());
+               }
+       } else if ( (p == "snap-to-region-sync") || (p == "snap-to-region-start") || (p == "snap-to-region-end") ) {
+               if (editor) editor->mark_region_boundary_cache_dirty();
        }
+
 }
 
 void
@@ -419,6 +542,21 @@ ARDOUR_UI::session_parameter_changed (std::string p)
 {
        if (p == "native-file-data-format" || p == "native-file-header-format") {
                update_format ();
+       } else if (p == "timecode-format") {
+               set_fps_timeout_connection ();
+       } else if (p == "video-pullup" || p == "timecode-format") {
+               set_fps_timeout_connection ();
+
+               synchronize_sync_source_and_video_pullup ();
+               reset_main_clocks ();
+               editor->queue_visual_videotimeline_update();
+       } else if (p == "track-name-number") {
+               /* DisplaySuspender triggers _route->redisplay() when going out of scope
+                * which eventually calls reset_controls_layout_width() and re-sets the
+                * track-header width.
+                * see also RouteTimeAxisView::update_track_number_visibility()
+                */
+               DisplaySuspender ds;
        }
 }
 
@@ -428,8 +566,8 @@ ARDOUR_UI::reset_main_clocks ()
        ENSURE_GUI_THREAD (*this, &ARDOUR_UI::reset_main_clocks)
 
        if (_session) {
-               primary_clock->set (_session->audible_frame(), true);
-               secondary_clock->set (_session->audible_frame(), true);
+               primary_clock->set (_session->audible_sample(), true);
+               secondary_clock->set (_session->audible_sample(), true);
        } else {
                primary_clock->set (0, true);
                secondary_clock->set (0, true);
@@ -439,7 +577,7 @@ ARDOUR_UI::reset_main_clocks ()
 void
 ARDOUR_UI::synchronize_sync_source_and_video_pullup ()
 {
-       Glib::RefPtr<Action> act = ActionManager::get_action (X_("Transport"), X_("ToggleExternalSync"));
+       Glib::RefPtr<Action> act = global_actions.find_action (X_("Transport"), X_("ToggleExternalSync"));
 
        if (!act) {
                return;
@@ -454,7 +592,7 @@ ARDOUR_UI::synchronize_sync_source_and_video_pullup ()
                act->set_sensitive (true);
        } else {
                /* can't sync to JACK if video pullup != 0.0 */
-               if (Config->get_sync_source() == Engine) {
+               if (TransportMasterManager::instance().current()->type() == Engine) {
                        act->set_sensitive (false);
                } else {
                        act->set_sensitive (true);
@@ -474,4 +612,3 @@ ARDOUR_UI::synchronize_sync_source_and_video_pullup ()
        }
 
 }
-