Tidy up region gain line drawing slightly so that it doesn't overhang its region.
[ardour.git] / gtk2_ardour / audio_region_view.cc
index b6eb90eaf80baeab7eb254081ccb07ca4f07cf87..2a9722543424753544566c53ecbd349a48c3cece 100644 (file)
@@ -1,7 +1,7 @@
 /*
-    Copyright (C) 2001-2006 Paul Davis 
+    Copyright (C) 2001-2006 Paul Davis
 
-    This program is free software; you can redistribute it and/or modify
+    This program is free software; you can r>edistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
 #include <gtkmm2ext/gtk_ui.h>
 
-#include <ardour/playlist.h>
-#include <ardour/audioregion.h>
-#include <ardour/audiosource.h>
-#include <ardour/audio_diskstream.h>
+#include "ardour/playlist.h"
+#include "ardour/audioregion.h"
+#include "ardour/audiosource.h"
+#include "ardour/audio_diskstream.h"
+#include "ardour/profile.h"
+
+#include "pbd/memento_command.h"
+#include "pbd/stacktrace.h"
+
+#include "evoral/Curve.hpp"
 
 #include "streamview.h"
 #include "audio_region_view.h"
 #include "public_editor.h"
 #include "audio_region_editor.h"
 #include "region_gain_line.h"
+#include "control_point.h"
 #include "ghostregion.h"
 #include "audio_time_axis.h"
 #include "utils.h"
 #include "rgb_macros.h"
 #include "gui_thread.h"
+#include "ardour_ui.h"
 
 #include "i18n.h"
 
+#define MUTED_ALPHA 10
+
+using namespace std;
 using namespace sigc;
 using namespace ARDOUR;
 using namespace PBD;
@@ -54,8 +65,8 @@ using namespace ArdourCanvas;
 
 static const int32_t sync_mark_width = 9;
 
-AudioRegionView::AudioRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &tv, AudioRegion& r, double spu,
-                                 Gdk::Color& basic_color)
+AudioRegionView::AudioRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &tv, boost::shared_ptr<AudioRegion> r, double spu,
+                                 Gdk::Color const & basic_color)
        : RegionView (parent, tv, r, spu, basic_color)
        , sync_mark(0)
        , zero_line(0)
@@ -70,9 +81,10 @@ AudioRegionView::AudioRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView
 {
 }
 
-AudioRegionView::AudioRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &tv, AudioRegion& r, double spu, 
-                                 Gdk::Color& basic_color, TimeAxisViewItem::Visibility visibility)
-       : RegionView (parent, tv, r, spu, basic_color, visibility)
+
+AudioRegionView::AudioRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &tv, boost::shared_ptr<AudioRegion> r, double spu,
+                                 Gdk::Color const & basic_color, bool recording, TimeAxisViewItem::Visibility visibility)
+       : RegionView (parent, tv, r, spu, basic_color, recording, visibility)
        , sync_mark(0)
        , zero_line(0)
        , fade_in_shape(0)
@@ -86,13 +98,59 @@ AudioRegionView::AudioRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView
 {
 }
 
+
+AudioRegionView::AudioRegionView (const AudioRegionView& other)
+       : sigc::trackable(other)
+       , RegionView (other)
+       , zero_line(0)
+       , fade_in_shape(0)
+       , fade_out_shape(0)
+       , fade_in_handle(0)
+       , fade_out_handle(0)
+       , gain_line(0)
+       , _amplitude_above_axis(1.0)
+       , _flags(0)
+       , fade_color(0)
+
+{
+       Gdk::Color c;
+       int r,g,b,a;
+
+       UINT_TO_RGBA (other.fill_color, &r, &g, &b, &a);
+       c.set_rgb_p (r/255.0, g/255.0, b/255.0);
+
+       init (c, false);
+}
+
+AudioRegionView::AudioRegionView (const AudioRegionView& other, boost::shared_ptr<AudioRegion> other_region)
+       : RegionView (other, boost::shared_ptr<Region> (other_region))
+       , zero_line(0)
+       , fade_in_shape(0)
+       , fade_out_shape(0)
+       , fade_in_handle(0)
+       , fade_out_handle(0)
+       , gain_line(0)
+       , _amplitude_above_axis(1.0)
+       , _flags(0)
+       , fade_color(0)
+
+{
+       Gdk::Color c;
+       int r,g,b,a;
+
+       UINT_TO_RGBA (other.fill_color, &r, &g, &b, &a);
+       c.set_rgb_p (r/255.0, g/255.0, b/255.0);
+
+       init (c, true);
+}
+
 void
-AudioRegionView::init (Gdk::Color& basic_color, bool wfd)
+AudioRegionView::init (Gdk::Color const & basic_color, bool wfd)
 {
        // FIXME: Some redundancy here with RegionView::init.  Need to figure out
        // where order is important and where it isn't...
-       
-       RegionView::init(basic_color, wfd);
+
+       RegionView::init (basic_color, wfd);
 
        XMLNode *node;
 
@@ -100,14 +158,14 @@ AudioRegionView::init (Gdk::Color& basic_color, bool wfd)
        zero_line             = 0;
        _flags                = 0;
 
-       if ((node = _region.extra_xml ("GUI")) != 0) {
+       if ((node = _region->extra_xml ("GUI")) != 0) {
                set_flags (node);
        } else {
                _flags = WaveformVisible;
                store_flags ();
        }
 
-       if (trackview.editor.new_regionviews_display_gain()) {
+       if (trackview.editor().new_regionviews_display_gain()) {
                _flags |= EnvelopeVisible;
        }
 
@@ -118,39 +176,40 @@ AudioRegionView::init (Gdk::Color& basic_color, bool wfd)
        fade_in_shape = new ArdourCanvas::Polygon (*group);
        fade_in_shape->property_fill_color_rgba() = fade_color;
        fade_in_shape->set_data ("regionview", this);
-       
+
        fade_out_shape = new ArdourCanvas::Polygon (*group);
        fade_out_shape->property_fill_color_rgba() = fade_color;
        fade_out_shape->set_data ("regionview", this);
 
-
        {
                uint32_t r,g,b,a;
                UINT_TO_RGBA(fill_color,&r,&g,&b,&a);
-       
 
                fade_in_handle = new ArdourCanvas::SimpleRect (*group);
                fade_in_handle->property_fill_color_rgba() = RGBA_TO_UINT(r,g,b,0);
                fade_in_handle->property_outline_pixels() = 0;
-               fade_in_handle->property_y1() = 2.0;
-               fade_in_handle->property_y2() = 7.0;
-               
+
                fade_in_handle->set_data ("regionview", this);
-               
+
                fade_out_handle = new ArdourCanvas::SimpleRect (*group);
                fade_out_handle->property_fill_color_rgba() = RGBA_TO_UINT(r,g,b,0);
                fade_out_handle->property_outline_pixels() = 0;
-               fade_out_handle->property_y1() = 2.0;
-               fade_out_handle->property_y2() = 7.0;
-               
+
                fade_out_handle->set_data ("regionview", this);
        }
 
-       string foo = _region.name();
-       foo += ':';
-       foo += "gain";
+       setup_fade_handle_positions ();
+
+       if (!trackview.session().config.get_show_region_fades()) {
+               set_fade_visibility (false);
+       }
 
-       gain_line = new AudioRegionGainLine (foo, trackview.session(), *this, *group, audio_region().envelope());
+       const string line_name = _region->name() + ":gain";
+
+       if (!Profile->get_sae()) {
+               gain_line = new AudioRegionGainLine (line_name, trackview.session(), *this, *group,
+                               audio_region()->envelope());
+       }
 
        if (!(_flags & EnvelopeVisible)) {
                gain_line->hide ();
@@ -158,11 +217,9 @@ AudioRegionView::init (Gdk::Color& basic_color, bool wfd)
                gain_line->show ();
        }
 
-       reset_width_dependent_items ((double) _region.length() / samples_per_unit);
-
        gain_line->reset ();
 
-       set_height (trackview.height);
+       set_height (trackview.current_height());
 
        region_muted ();
        region_sync_changed ();
@@ -173,7 +230,7 @@ AudioRegionView::init (Gdk::Color& basic_color, bool wfd)
        fade_in_active_changed ();
        fade_out_active_changed ();
 
-       _region.StateChanged.connect (mem_fun(*this, &AudioRegionView::region_changed));
+       reset_width_dependent_items (_pixel_width);
 
        fade_in_shape->signal_event().connect (bind (mem_fun (PublicEditor::instance(), &PublicEditor::canvas_fade_in_event), fade_in_shape, this));
        fade_in_handle->signal_event().connect (bind (mem_fun (PublicEditor::instance(), &PublicEditor::canvas_fade_in_handle_event), fade_in_handle, this));
@@ -197,22 +254,21 @@ AudioRegionView::~AudioRegionView ()
 
        /* all waveviews etc will be destroyed when the group is destroyed */
 
-       if (gain_line) {
-               delete gain_line;
-       }
+       delete gain_line;
 }
 
-ARDOUR::AudioRegion&
+boost::shared_ptr<ARDOUR::AudioRegion>
 AudioRegionView::audio_region() const
 {
        // "Guaranteed" to succeed...
-       return dynamic_cast<AudioRegion&>(_region);
+       return boost::dynamic_pointer_cast<AudioRegion>(_region);
 }
 
 void
 AudioRegionView::region_changed (Change what_changed)
 {
        ENSURE_GUI_THREAD (bind (mem_fun(*this, &AudioRegionView::region_changed), what_changed));
+       //cerr << "AudioRegionView::region_changed() called" << endl;
 
        RegionView::region_changed(what_changed);
 
@@ -247,19 +303,6 @@ AudioRegionView::fade_out_changed ()
 {
        reset_fade_out_shape ();
 }
-
-void
-AudioRegionView::set_fade_in_active (bool yn)
-{
-       audio_region().set_fade_in_active (yn);
-}
-
-void
-AudioRegionView::set_fade_out_active (bool yn)
-{
-       audio_region().set_fade_out_active (yn);
-}
-
 void
 AudioRegionView::fade_in_active_changed ()
 {
@@ -267,12 +310,12 @@ AudioRegionView::fade_in_active_changed ()
        uint32_t col;
        UINT_TO_RGBA(fade_color,&r,&g,&b,&a);
 
-       if (audio_region().fade_in_active()) {
+       if (audio_region()->fade_in_active()) {
                col = RGBA_TO_UINT(r,g,b,120);
                fade_in_shape->property_fill_color_rgba() = col;
                fade_in_shape->property_width_pixels() = 0;
                fade_in_shape->property_outline_color_rgba() = RGBA_TO_UINT(r,g,b,0);
-       } else { 
+       } else {
                col = RGBA_TO_UINT(r,g,b,0);
                fade_in_shape->property_fill_color_rgba() = col;
                fade_in_shape->property_width_pixels() = 1;
@@ -287,12 +330,12 @@ AudioRegionView::fade_out_active_changed ()
        uint32_t col;
        UINT_TO_RGBA(fade_color,&r,&g,&b,&a);
 
-       if (audio_region().fade_out_active()) {
+       if (audio_region()->fade_out_active()) {
                col = RGBA_TO_UINT(r,g,b,120);
                fade_out_shape->property_fill_color_rgba() = col;
                fade_out_shape->property_width_pixels() = 0;
                fade_out_shape->property_outline_color_rgba() = RGBA_TO_UINT(r,g,b,0);
-       } else { 
+       } else {
                col = RGBA_TO_UINT(r,g,b,0);
                fade_out_shape->property_fill_color_rgba() = col;
                fade_out_shape->property_width_pixels() = 1;
@@ -308,26 +351,47 @@ AudioRegionView::region_scale_amplitude_changed ()
 
        for (uint32_t n = 0; n < waves.size(); ++n) {
                // force a reload of the cache
-               waves[n]->property_data_src() = &_region;
+               waves[n]->property_data_src() = _region.get();
+       }
+}
+
+void
+AudioRegionView::region_renamed ()
+{
+       Glib::ustring str = RegionView::make_name ();
+
+       if (audio_region()->speed_mismatch (trackview.session().frame_rate())) {
+               str = string ("*") + str;
+       }
+
+       if (_region->muted()) {
+               str = string ("!") + str;
        }
+
+       set_item_name (str, this);
+       set_name_text (str);
 }
 
 void
 AudioRegionView::region_resized (Change what_changed)
 {
+       AudioGhostRegion* agr;
+
        RegionView::region_resized(what_changed);
 
        if (what_changed & Change (StartChanged|LengthChanged)) {
 
                for (uint32_t n = 0; n < waves.size(); ++n) {
-                       waves[n]->property_region_start() = _region.start();
+                       waves[n]->property_region_start() = _region->start();
                }
-               
+
                for (vector<GhostRegion*>::iterator i = ghosts.begin(); i != ghosts.end(); ++i) {
+                       if((agr = dynamic_cast<AudioGhostRegion*>(*i)) != 0) {
 
-                       for (vector<WaveView*>::iterator w = (*i)->waves.begin(); w != (*i)->waves.end(); ++w) {
-                               (*w)->property_region_start() = _region.start();
-                       }
+                               for (vector<WaveView*>::iterator w = agr->waves.begin(); w != agr->waves.end(); ++w) {
+                                       (*w)->property_region_start() = _region->start();
+                               }
+                       }
                }
        }
 }
@@ -351,8 +415,10 @@ AudioRegionView::reset_width_dependent_items (double pixel_width)
                                fade_in_handle->hide();
                                fade_out_handle->hide();
                        } else {
-                               fade_in_handle->show();
-                               fade_out_handle->show();
+                               if (trackview.session().config.get_show_region_fades()) {
+                                       fade_in_handle->show();
+                                       fade_out_handle->show();
+                               }
                        }
                }
        }
@@ -366,57 +432,78 @@ AudioRegionView::region_muted ()
        RegionView::region_muted();
 
        for (uint32_t n=0; n < waves.size(); ++n) {
-               if (_region.muted()) {
-                       waves[n]->property_wave_color() = color_map[cMutedWaveForm];
+               if (_region->muted()) {
+                       waves[n]->property_wave_color() = UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_WaveForm.get(), MUTED_ALPHA);
                } else {
-                       waves[n]->property_wave_color() = color_map[cWaveForm];
+                       waves[n]->property_wave_color() = ARDOUR_UI::config()->canvasvar_WaveForm.get();
                }
        }
 }
 
+void
+AudioRegionView::setup_fade_handle_positions()
+{
+       /* position of fade handle offset from the top of the region view */
+       double const handle_pos = 2;
+       /* height of fade handles */
+       double const handle_height = 5;
+
+       if (fade_in_handle) {
+               fade_in_handle->property_y1() = handle_pos;
+               fade_in_handle->property_y2() = handle_pos + handle_height;
+       }
+
+       if (fade_out_handle) {
+               fade_out_handle->property_y1() = handle_pos;
+               fade_out_handle->property_y2() = handle_pos + handle_height;
+       }
+}
 
 void
 AudioRegionView::set_height (gdouble height)
 {
+       RegionView::set_height (height);
+
        uint32_t wcnt = waves.size();
 
        // FIXME: ick
-       TimeAxisViewItem::set_height (height - 2);
-       
+       height -= 2;
+
        _height = height;
 
        for (uint32_t n=0; n < wcnt; ++n) {
                gdouble ht;
 
-               if ((height) <= NAME_HIGHLIGHT_THRESH) {
+               if ((height) < NAME_HIGHLIGHT_THRESH) {
                        ht = ((height-2*wcnt) / (double) wcnt);
                } else {
                        ht = (((height-2*wcnt) - NAME_HIGHLIGHT_SIZE) / (double) wcnt);
                }
-               
+
                gdouble yoff = n * (ht+1);
-               
+
                waves[n]->property_height() = ht;
                waves[n]->property_y() = yoff + 2;
        }
 
        if (gain_line) {
-               if ((height/wcnt) < NAME_HIGHLIGHT_SIZE) {
+               if ((height/wcnt) < NAME_HIGHLIGHT_THRESH) {
                        gain_line->hide ();
                } else {
                        if (_flags & EnvelopeVisible) {
                                gain_line->show ();
                        }
                }
-               gain_line->set_height ((uint32_t) rint (height - NAME_HIGHLIGHT_SIZE));
+               gain_line->set_height ((uint32_t) rint (height - NAME_HIGHLIGHT_SIZE - 2));
        }
 
        manage_zero_line ();
        reset_fade_shapes ();
-       
-       if (name_text) {
-               name_text->raise_to_top();
+
+       if (name_pixbuf) {
+               name_pixbuf->raise_to_top();
        }
+
 }
 
 void
@@ -427,7 +514,7 @@ AudioRegionView::manage_zero_line ()
        }
 
        if (_height >= 100) {
-               gdouble wave_midpoint = (_height - NAME_HIGHLIGHT_SIZE) / 2.0;
+               double const wave_midpoint = (_height - NAME_HIGHLIGHT_SIZE) / 2.0;
                zero_line->property_y1() = wave_midpoint;
                zero_line->property_y2() = wave_midpoint;
                zero_line->show();
@@ -446,11 +533,11 @@ AudioRegionView::reset_fade_shapes ()
 void
 AudioRegionView::reset_fade_in_shape ()
 {
-       reset_fade_in_shape_width ((jack_nframes_t) audio_region().fade_in().back()->when);
+       reset_fade_in_shape_width ((nframes_t) audio_region()->fade_in()->back()->when);
 }
-       
+
 void
-AudioRegionView::reset_fade_in_shape_width (jack_nframes_t width)
+AudioRegionView::reset_fade_in_shape_width (nframes_t width)
 {
        if (fade_in_handle == 0) {
                return;
@@ -458,13 +545,13 @@ AudioRegionView::reset_fade_in_shape_width (jack_nframes_t width)
 
        /* smallest size for a fade is 64 frames */
 
-       width = std::max ((jack_nframes_t) 64, width);
+       width = std::max ((nframes_t) 64, width);
 
        Points* points;
        double pwidth = width / samples_per_unit;
        uint32_t npoints = std::min (gdk_screen_width(), (int) pwidth);
-       double h; 
-       
+       double h;
+
        if (_height < 5) {
                fade_in_shape->hide();
                fade_in_handle->hide();
@@ -473,29 +560,31 @@ AudioRegionView::reset_fade_in_shape_width (jack_nframes_t width)
 
        double handle_center;
        handle_center = pwidth;
-       
+
        if (handle_center > 7.0) {
                handle_center -= 3.0;
        } else {
                handle_center = 3.0;
        }
-       
+
        fade_in_handle->property_x1() =  handle_center - 3.0;
        fade_in_handle->property_x2() =  handle_center + 3.0;
-       
+
        if (pwidth < 5) {
                fade_in_shape->hide();
                return;
        }
 
-       fade_in_shape->show();
+       if (trackview.session().config.get_show_region_fades()) {
+               fade_in_shape->show();
+       }
 
        float curve[npoints];
-       audio_region().fade_in().get_vector (0, audio_region().fade_in().back()->when, curve, npoints);
+       audio_region()->fade_in()->curve().get_vector (0, audio_region()->fade_in()->back()->when, curve, npoints);
 
        points = get_canvas_points ("fade in shape", npoints+3);
 
-       if (_height > NAME_HIGHLIGHT_THRESH) {
+       if (_height >= NAME_HIGHLIGHT_THRESH) {
                h = _height - NAME_HIGHLIGHT_SIZE;
        } else {
                h = _height;
@@ -510,7 +599,7 @@ AudioRegionView::reset_fade_in_shape_width (jack_nframes_t width)
                (*points)[pi].set_x(1 + (pc * xdelta));
                (*points)[pi++].set_y(2 + (h - (curve[pc] * h)));
        }
-       
+
        /* fold back */
 
        (*points)[pi].set_x(pwidth);
@@ -522,27 +611,30 @@ AudioRegionView::reset_fade_in_shape_width (jack_nframes_t width)
        /* connect the dots ... */
 
        (*points)[pi] = (*points)[0];
-       
+
        fade_in_shape->property_points() = *points;
        delete points;
+
+       /* ensure trim handle stays on top */
+       frame_handle_start->raise_to_top();
 }
 
 void
 AudioRegionView::reset_fade_out_shape ()
 {
-       reset_fade_out_shape_width ((jack_nframes_t) audio_region().fade_out().back()->when);
+       reset_fade_out_shape_width ((nframes_t) audio_region()->fade_out()->back()->when);
 }
 
 void
-AudioRegionView::reset_fade_out_shape_width (jack_nframes_t width)
-{      
+AudioRegionView::reset_fade_out_shape_width (nframes_t width)
+{
        if (fade_out_handle == 0) {
                return;
        }
 
        /* smallest size for a fade is 64 frames */
 
-       width = std::max ((jack_nframes_t) 64, width);
+       width = std::max ((nframes_t) 64, width);
 
        Points* points;
        double pwidth = width / samples_per_unit;
@@ -556,30 +648,32 @@ AudioRegionView::reset_fade_out_shape_width (jack_nframes_t width)
        }
 
        double handle_center;
-       handle_center = (_region.length() - width) / samples_per_unit;
-       
+       handle_center = (_region->length() - width) / samples_per_unit;
+
        if (handle_center > 7.0) {
                handle_center -= 3.0;
        } else {
                handle_center = 3.0;
        }
-       
+
        fade_out_handle->property_x1() =  handle_center - 3.0;
        fade_out_handle->property_x2() =  handle_center + 3.0;
 
        /* don't show shape if its too small */
-       
+
        if (pwidth < 5) {
                fade_out_shape->hide();
                return;
-       } 
-       
-       fade_out_shape->show();
+       }
+
+       if (trackview.session().config.get_show_region_fades()) {
+               fade_out_shape->show();
+       }
 
        float curve[npoints];
-       audio_region().fade_out().get_vector (0, audio_region().fade_out().back()->when, curve, npoints);
+       audio_region()->fade_out()->curve().get_vector (0, audio_region()->fade_out()->back()->when, curve, npoints);
 
-       if (_height > NAME_HIGHLIGHT_THRESH) {
+       if (_height >= NAME_HIGHLIGHT_THRESH) {
                h = _height - NAME_HIGHLIGHT_SIZE;
        } else {
                h = _height;
@@ -596,7 +690,7 @@ AudioRegionView::reset_fade_out_shape_width (jack_nframes_t width)
                (*points)[pi].set_x(_pixel_width - 1 - pwidth + (pc*xdelta));
                (*points)[pi++].set_y(2 + (h - (curve[pc] * h)));
        }
-       
+
        /* fold back */
 
        (*points)[pi].set_x(_pixel_width);
@@ -611,6 +705,9 @@ AudioRegionView::reset_fade_out_shape_width (jack_nframes_t width)
 
        fade_out_shape->property_points() = *points;
        delete points;
+
+       /* ensure trim handle stays on top */
+       frame_handle_end->raise_to_top();
 }
 
 void
@@ -618,13 +715,16 @@ AudioRegionView::set_samples_per_unit (gdouble spu)
 {
        RegionView::set_samples_per_unit (spu);
 
-       for (uint32_t n=0; n < waves.size(); ++n) {
-               waves[n]->property_samples_per_unit() = spu;
+       if (_flags & WaveformVisible) {
+               for (uint32_t n=0; n < waves.size(); ++n) {
+                       waves[n]->property_samples_per_unit() = spu;
+               }
        }
 
        if (gain_line) {
                gain_line->reset ();
        }
+
        reset_fade_shapes ();
 }
 
@@ -637,10 +737,10 @@ AudioRegionView::set_amplitude_above_axis (gdouble spp)
 }
 
 void
-AudioRegionView::compute_colors (Gdk::Color& basic_color)
+AudioRegionView::compute_colors (Gdk::Color const & basic_color)
 {
-       RegionView::compute_colors(basic_color);
-       
+       RegionView::compute_colors (basic_color);
+
        uint32_t r, g, b, a;
 
        /* gain color computed in envelope_active_changed() */
@@ -653,17 +753,20 @@ void
 AudioRegionView::set_colors ()
 {
        RegionView::set_colors();
-       
+
        if (gain_line) {
-               gain_line->set_line_color (audio_region().envelope_active() ? color_map[cGainLine] : color_map[cGainLineInactive]);
+               gain_line->set_line_color (audio_region()->envelope_active() ? ARDOUR_UI::config()->canvasvar_GainLine.get() : ARDOUR_UI::config()->canvasvar_GainLineInactive.get());
        }
 
        for (uint32_t n=0; n < waves.size(); ++n) {
-               if (_region.muted()) {
-                       waves[n]->property_wave_color() = color_map[cMutedWaveForm];
+               if (_region->muted()) {
+                       waves[n]->property_wave_color() = UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_WaveForm.get(), MUTED_ALPHA);
                } else {
-                       waves[n]->property_wave_color() = color_map[cWaveForm];
+                       waves[n]->property_wave_color() = ARDOUR_UI::config()->canvasvar_WaveForm.get();
                }
+
+               waves[n]->property_clip_color() = ARDOUR_UI::config()->canvasvar_WaveFormClip.get();
+               waves[n]->property_zero_color() = ARDOUR_UI::config()->canvasvar_ZeroLine.get();
        }
 }
 
@@ -675,10 +778,10 @@ AudioRegionView::show_region_editor ()
                // GTK2FIX : how to ensure float without realizing
                // editor->realize ();
                // trackview.editor.ensure_float (*editor);
-       } 
+       }
 
-       editor->show_all ();
-       editor->get_window()->raise();
+       editor->present ();
+       editor->show_all();
 }
 
 void
@@ -687,6 +790,10 @@ AudioRegionView::set_waveform_visible (bool yn)
        if (((_flags & WaveformVisible) != yn)) {
                if (yn) {
                        for (uint32_t n=0; n < waves.size(); ++n) {
+                               /* make sure the zoom level is correct, since we don't update
+                                  this when waveforms are hidden.
+                               */
+                               waves[n]->property_samples_per_unit() = samples_per_unit;
                                waves[n]->show();
                        }
                        _flags |= WaveformVisible;
@@ -734,69 +841,72 @@ AudioRegionView::set_envelope_visible (bool yn)
 void
 AudioRegionView::create_waves ()
 {
-       bool create_zero_line = true;
-
+       // cerr << "AudioRegionView::create_waves() called on " << this << endl;//DEBUG
        RouteTimeAxisView& atv (*(dynamic_cast<RouteTimeAxisView*>(&trackview))); // ick
 
        if (!atv.get_diskstream()) {
                return;
        }
 
-       uint32_t nchans = atv.get_diskstream()->n_channels();
-       
+       ChanCount nchans = atv.get_diskstream()->n_channels();
+
+       // cerr << "creating waves for " << _region->name() << " with wfd = " << wait_for_data
+       //              << " and channels = " << nchans.n_audio() << endl;
+
        /* in tmp_waves, set up null pointers for each channel so the vector is allocated */
-       for (uint32_t n = 0; n < nchans; ++n) {
+       for (uint32_t n = 0; n < nchans.n_audio(); ++n) {
                tmp_waves.push_back (0);
        }
-       
-       for (uint32_t n = 0; n < nchans; ++n) {
-               
-               if (n >= audio_region().n_channels()) {
+
+       for (uint32_t n = 0; n < nchans.n_audio(); ++n) {
+
+               if (n >= audio_region()->n_channels()) {
                        break;
                }
-               
+
                wave_caches.push_back (WaveView::create_cache ());
 
+               // cerr << "\tchannel " << n << endl;
+
                if (wait_for_data) {
-                       if (audio_region().source(n).peaks_ready (bind (mem_fun(*this, &AudioRegionView::peaks_ready_handler), n), data_ready_connection)) {
+                       if (audio_region()->audio_source(n)->peaks_ready (bind (mem_fun(*this, &AudioRegionView::peaks_ready_handler), n), data_ready_connection)) {
+                               // cerr << "\tData is ready\n";
                                create_one_wave (n, true);
                        } else {
-                               create_zero_line = false;
+                               // cerr << "\tdata is not ready\n";
+                               // we'll get a PeaksReady signal from the source in the future
+                               // and will call create_one_wave(n) then.
                        }
+
                } else {
+                       // cerr << "\tdon't delay, display today!\n";
                        create_one_wave (n, true);
                }
-       }
 
-       if (create_zero_line) {
-               zero_line = new ArdourCanvas::SimpleLine (*group);
-               zero_line->property_x1() = (gdouble) 1.0;
-               zero_line->property_x2() = (gdouble) (_region.length() / samples_per_unit) - 1.0;
-               zero_line->property_color_rgba() = (guint) color_map[cZeroLine];
-               manage_zero_line ();
        }
 }
 
 void
-AudioRegionView::create_one_wave (uint32_t which, bool direct)
+AudioRegionView::create_one_wave (uint32_t which, bool /*direct*/)
 {
+       //cerr << "AudioRegionView::create_one_wave() called which: " << which << " this: " << this << endl;//DEBUG
        RouteTimeAxisView& atv (*(dynamic_cast<RouteTimeAxisView*>(&trackview))); // ick
-       uint32_t nchans = atv.get_diskstream()->n_channels();
+       uint32_t nchans = atv.get_diskstream()->n_channels().n_audio();
        uint32_t n;
-       uint32_t nwaves = std::min (nchans, audio_region().n_channels());
+       uint32_t nwaves = std::min (nchans, audio_region()->n_channels());
        gdouble ht;
 
-       if (trackview.height < NAME_HIGHLIGHT_SIZE) {
-               ht = ((trackview.height) / (double) nchans);
+       if (trackview.current_height() < NAME_HIGHLIGHT_THRESH) {
+               ht = ((trackview.current_height()) / (double) nchans);
        } else {
-               ht = ((trackview.height - NAME_HIGHLIGHT_SIZE) / (double) nchans);
+               ht = ((trackview.current_height() - NAME_HIGHLIGHT_SIZE) / (double) nchans);
        }
 
        gdouble yoff = which * ht;
 
        WaveView *wave = new WaveView(*group);
 
-       wave->property_data_src() = (gpointer) &_region;
+       wave->property_data_src() = (gpointer) _region.get();
        wave->property_cache() =  wave_caches[which];
        wave->property_cache_updater() = true;
        wave->property_channel() =  which;
@@ -808,8 +918,20 @@ AudioRegionView::create_one_wave (uint32_t which, bool direct)
        wave->property_height() =  (double) ht;
        wave->property_samples_per_unit() =  samples_per_unit;
        wave->property_amplitude_above_axis() =  _amplitude_above_axis;
-       wave->property_wave_color() = _region.muted() ? color_map[cMutedWaveForm] : color_map[cWaveForm];
-       wave->property_region_start() = _region.start();
+
+       if (_recregion) {
+               wave->property_wave_color() = _region->muted() ? UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_RecWaveForm.get(), MUTED_ALPHA) : ARDOUR_UI::config()->canvasvar_RecWaveForm.get();
+               wave->property_fill_color() = ARDOUR_UI::config()->canvasvar_RecWaveFormFill.get();
+       } else {
+               wave->property_wave_color() = _region->muted() ? UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_WaveForm.get(), MUTED_ALPHA) : ARDOUR_UI::config()->canvasvar_WaveForm.get();
+               wave->property_fill_color() = ARDOUR_UI::config()->canvasvar_WaveFormFill.get();
+       }
+
+       wave->property_clip_color() = ARDOUR_UI::config()->canvasvar_WaveFormClip.get();
+       wave->property_zero_color() = ARDOUR_UI::config()->canvasvar_ZeroLine.get();
+       wave->property_region_start() = _region->start();
+       wave->property_rectified() = (bool) (_flags & WaveformRectified);
+       wave->property_logscaled() = (bool) (_flags & WaveformLogScaled);
 
        if (!(_flags & WaveformVisible)) {
                wave->hide();
@@ -826,15 +948,15 @@ AudioRegionView::create_one_wave (uint32_t which, bool direct)
        } else {
                /* n-channel track, >n-channel source */
        }
-       
+
        /* see if we're all ready */
-       
+
        for (n = 0; n < nchans; ++n) {
                if (tmp_waves[n] == 0) {
                        break;
                }
        }
-       
+
        if (n == nwaves && waves.empty()) {
                /* all waves are ready */
                tmp_waves.resize(nwaves);
@@ -842,13 +964,18 @@ AudioRegionView::create_one_wave (uint32_t which, bool direct)
                waves = tmp_waves;
                tmp_waves.clear ();
 
+               /* all waves created, don't hook into peaks ready anymore */
+               data_ready_connection.disconnect ();
+
+#if 0
                if (!zero_line) {
                        zero_line = new ArdourCanvas::SimpleLine (*group);
                        zero_line->property_x1() = (gdouble) 1.0;
-                       zero_line->property_x2() = (gdouble) (_region.length() / samples_per_unit) - 1.0;
-                       zero_line->property_color_rgba() = (guint) color_map[cZeroLine];
+                       zero_line->property_x2() = (gdouble) (_region->length() / samples_per_unit) - 1.0;
+                       zero_line->property_color_rgba() = (guint) ARDOUR_UI::config()->canvasvar_ZeroLine.get();
                        manage_zero_line ();
                }
+#endif
        }
 }
 
@@ -856,11 +983,7 @@ void
 AudioRegionView::peaks_ready_handler (uint32_t which)
 {
        Gtkmm2ext::UI::instance()->call_slot (bind (mem_fun(*this, &AudioRegionView::create_one_wave), which, false));
-
-       if (!waves.empty()) {
-               /* all waves created, don't hook into peaks ready anymore */
-               data_ready_connection.disconnect ();            
-       }
+       // cerr << "AudioRegionView::peaks_ready_handler() called on " << which << " this: " << this << endl;
 }
 
 void
@@ -875,47 +998,48 @@ AudioRegionView::add_gain_point_event (ArdourCanvas::Item *item, GdkEvent *ev)
        /* don't create points that can't be seen */
 
        set_envelope_visible (true);
-       
+
        x = ev->button.x;
        y = ev->button.y;
 
        item->w2i (x, y);
 
-       jack_nframes_t fx = trackview.editor.pixel_to_frame (x);
+       nframes_t fx = trackview.editor().pixel_to_frame (x);
 
-       if (fx > _region.length()) {
+       if (fx > _region->length()) {
                return;
        }
 
        /* compute vertical fractional position */
 
-       y = 1.0 - (y / (trackview.height - NAME_HIGHLIGHT_SIZE));
-       
+       y = 1.0 - (y / (_height - NAME_HIGHLIGHT_SIZE));
+
        /* map using gain line */
 
-       gain_line->view_to_model_y (y);
+       gain_line->view_to_model_coord (x, y);
 
        trackview.session().begin_reversible_command (_("add gain control point"));
-       trackview.session().add_undo (audio_region().envelope().get_memento());
-
+       XMLNode &before = audio_region()->envelope()->get_state();
 
-       if (!audio_region().envelope_active()) {
-               trackview.session().add_undo( bind( mem_fun(audio_region(), &AudioRegion::set_envelope_active), false) );
-               audio_region().set_envelope_active(true);
-               trackview.session().add_redo( bind( mem_fun(audio_region(), &AudioRegion::set_envelope_active), true) );
+       if (!audio_region()->envelope_active()) {
+               XMLNode &region_before = audio_region()->get_state();
+               audio_region()->set_envelope_active(true);
+               XMLNode &region_after = audio_region()->get_state();
+               trackview.session().add_command (new MementoCommand<AudioRegion>(*(audio_region().get()), &region_before, &region_after));
        }
 
-       audio_region().envelope().add (fx, y);
-       
-       trackview.session().add_redo_no_execute (audio_region().envelope().get_memento());
+       audio_region()->envelope()->add (fx, y);
+
+       XMLNode &after = audio_region()->envelope()->get_state();
+       trackview.session().add_command (new MementoCommand<AutomationList>(*audio_region()->envelope().get(), &before, &after));
        trackview.session().commit_reversible_command ();
 }
 
 void
-AudioRegionView::remove_gain_point_event (ArdourCanvas::Item *item, GdkEvent *ev)
+AudioRegionView::remove_gain_point_event (ArdourCanvas::Item *item, GdkEvent */*ev*/)
 {
-        ControlPoint *cp = reinterpret_cast<ControlPoint *> (item->get_data ("control_point"));
-       audio_region().envelope().erase (cp->model);
+       ControlPoint *cp = reinterpret_cast<ControlPoint *> (item->get_data ("control_point"));
+       audio_region()->envelope()->erase (cp->model());
 }
 
 void
@@ -925,8 +1049,10 @@ AudioRegionView::store_flags()
 
        node->add_property ("waveform-visible", (_flags & WaveformVisible) ? "yes" : "no");
        node->add_property ("envelope-visible", (_flags & EnvelopeVisible) ? "yes" : "no");
+       node->add_property ("waveform-rectified", (_flags & WaveformRectified) ? "yes" : "no");
+       node->add_property ("waveform-logscaled", (_flags & WaveformLogScaled) ? "yes" : "no");
 
-       _region.add_extra_xml (*node);
+       _region->add_extra_xml (*node);
 }
 
 void
@@ -935,24 +1061,36 @@ AudioRegionView::set_flags (XMLNode* node)
        XMLProperty *prop;
 
        if ((prop = node->property ("waveform-visible")) != 0) {
-               if (prop->value() == "yes") {
+               if (string_is_affirmative (prop->value())) {
                        _flags |= WaveformVisible;
                }
        }
 
        if ((prop = node->property ("envelope-visible")) != 0) {
-               if (prop->value() == "yes") {
+               if (string_is_affirmative (prop->value())) {
                        _flags |= EnvelopeVisible;
                }
        }
+
+       if ((prop = node->property ("waveform-rectified")) != 0) {
+               if (string_is_affirmative (prop->value())) {
+                       _flags |= WaveformRectified;
+               }
+       }
+
+       if ((prop = node->property ("waveform-logscaled")) != 0) {
+               if (string_is_affirmative (prop->value())) {
+                       _flags |= WaveformLogScaled;
+               }
+       }
 }
-       
+
 void
 AudioRegionView::set_waveform_shape (WaveformShape shape)
 {
        bool yn;
 
-       /* this slightly odd approach is to leave the door open to 
+       /* this slightly odd approach is to leave the door open to
           other "shapes" such as spectral displays, etc.
        */
 
@@ -984,28 +1122,51 @@ AudioRegionView::set_waveform_shape (WaveformShape shape)
                } else {
                        _flags &= ~WaveformRectified;
                }
+               store_flags ();
        }
 }
 
+void
+AudioRegionView::set_waveform_scale (WaveformScale scale)
+{
+       bool yn = (scale == Logarithmic);
+
+       if (yn != (bool) (_flags & WaveformLogScaled)) {
+               for (vector<WaveView *>::iterator wave = waves.begin(); wave != waves.end() ; ++wave) {
+                       (*wave)->property_logscaled() = yn;
+               }
+
+               if (yn) {
+                       _flags |= WaveformLogScaled;
+               } else {
+                       _flags &= ~WaveformLogScaled;
+               }
+               store_flags ();
+       }
+}
+
+
 GhostRegion*
-AudioRegionView::add_ghost (AutomationTimeAxisView& atv)
+AudioRegionView::add_ghost (TimeAxisView& tv)
 {
-       RouteTimeAxisView& myatv (*(dynamic_cast<RouteTimeAxisView*>(&trackview))); // ick
-       double unit_position = _region.position () / samples_per_unit;
-       GhostRegion* ghost = new GhostRegion (atv, unit_position);
+       RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*>(&trackview);
+       assert(rtv);
+
+       double unit_position = _region->position () / samples_per_unit;
+       AudioGhostRegion* ghost = new AudioGhostRegion (tv, trackview, unit_position);
        uint32_t nchans;
-       
-       nchans = myatv.get_diskstream()->n_channels();
+
+       nchans = rtv->get_diskstream()->n_channels().n_audio();
 
        for (uint32_t n = 0; n < nchans; ++n) {
-               
-               if (n >= audio_region().n_channels()) {
+
+               if (n >= audio_region()->n_channels()) {
                        break;
                }
-               
+
                WaveView *wave = new WaveView(*ghost->group);
 
-               wave->property_data_src() =  &_region;
+               wave->property_data_src() = _region.get();
                wave->property_cache() =  wave_caches[n];
                wave->property_cache_updater() = false;
                wave->property_channel() = n;
@@ -1015,14 +1176,15 @@ AudioRegionView::add_ghost (AutomationTimeAxisView& atv)
                wave->property_x() =  0.0;
                wave->property_samples_per_unit() =  samples_per_unit;
                wave->property_amplitude_above_axis() =  _amplitude_above_axis;
-               wave->property_wave_color() = color_map[cGhostTrackWave];
-               wave->property_region_start() = _region.start();
+
+               wave->property_region_start() = _region->start();
 
                ghost->waves.push_back(wave);
        }
 
        ghost->set_height ();
-       ghost->set_duration (_region.length() / samples_per_unit);
+       ghost->set_duration (_region->length() / samples_per_unit);
+       ghost->set_colors();
        ghosts.push_back (ghost);
 
        ghost->GoingAway.connect (mem_fun(*this, &AudioRegionView::remove_ghost));
@@ -1040,7 +1202,7 @@ AudioRegionView::entered ()
        uint32_t r,g,b,a;
        UINT_TO_RGBA(fade_color,&r,&g,&b,&a);
        a=255;
-       
+
        if (fade_in_handle) {
                fade_in_handle->property_fill_color_rgba() = RGBA_TO_UINT(r,g,b,a);
                fade_out_handle->property_fill_color_rgba() = RGBA_TO_UINT(r,g,b,a);
@@ -1053,11 +1215,11 @@ AudioRegionView::exited ()
        if (gain_line) {
                gain_line->hide_all_but_selected_control_points ();
        }
-       
+
        uint32_t r,g,b,a;
        UINT_TO_RGBA(fade_color,&r,&g,&b,&a);
        a=0;
-       
+
        if (fade_in_handle) {
                fade_in_handle->property_fill_color_rgba() = RGBA_TO_UINT(r,g,b,a);
                fade_out_handle->property_fill_color_rgba() = RGBA_TO_UINT(r,g,b,a);
@@ -1068,56 +1230,142 @@ void
 AudioRegionView::envelope_active_changed ()
 {
        if (gain_line) {
-               gain_line->set_line_color (audio_region().envelope_active() ? color_map[cGainLine] : color_map[cGainLineInactive]);
+               gain_line->set_line_color (audio_region()->envelope_active() ? ARDOUR_UI::config()->canvasvar_GainLine.get() : ARDOUR_UI::config()->canvasvar_GainLineInactive.get());
        }
 }
 
 void
 AudioRegionView::set_waveview_data_src()
 {
-
-       double unit_length= _region.length() / samples_per_unit;
+       AudioGhostRegion* agr;
+       double unit_length= _region->length() / samples_per_unit;
 
        for (uint32_t n = 0; n < waves.size(); ++n) {
                // TODO: something else to let it know the channel
-               waves[n]->property_data_src() = &_region;
+               waves[n]->property_data_src() = _region.get();
        }
-       
+
        for (vector<GhostRegion*>::iterator i = ghosts.begin(); i != ghosts.end(); ++i) {
-               
+
                (*i)->set_duration (unit_length);
-               
-               for (vector<WaveView*>::iterator w = (*i)->waves.begin(); w != (*i)->waves.end(); ++w) {
-                       (*w)->property_data_src() = &_region;
+
+               if((agr = dynamic_cast<AudioGhostRegion*>(*i)) != 0) {
+                       for (vector<WaveView*>::iterator w = agr->waves.begin(); w != agr->waves.end(); ++w) {
+                               (*w)->property_data_src() = _region.get();
+                       }
                }
        }
 
 }
 
 void
-AudioRegionView::color_handler (ColorID id, uint32_t val)
+AudioRegionView::color_handler ()
 {
-       switch (id) {
-       case cMutedWaveForm:
-       case cWaveForm:
-               set_colors ();
-               break;
+       //case cMutedWaveForm:
+       //case cWaveForm:
+       //case cWaveFormClip:
+       //case cZeroLine:
+       set_colors ();
 
-       case cGainLineInactive:
-       case cGainLine:
-               envelope_active_changed();
-               break;
-               
-       case cZeroLine:
-               if (zero_line) {
-                       zero_line->property_color_rgba() = (guint) color_map[cZeroLine];
-               }
-               break;
+       //case cGainLineInactive:
+       //case cGainLine:
+       envelope_active_changed();
 
-       case cGhostTrackWave:
-               break;
+}
 
-       default:
-               break;
+void
+AudioRegionView::set_frame_color ()
+{
+       if (!frame) {
+               return;
+       }
+
+       if (_region->opaque()) {
+               fill_opacity = 130;
+       } else {
+               fill_opacity = 0;
        }
+
+       uint32_t r,g,b,a;
+
+       if (_selected && should_show_selection) {
+               UINT_TO_RGBA(ARDOUR_UI::config()->canvasvar_SelectedFrameBase.get(), &r, &g, &b, &a);
+               frame->property_fill_color_rgba() = RGBA_TO_UINT(r, g, b, fill_opacity ? fill_opacity : a);
+
+               for (vector<ArdourCanvas::WaveView*>::iterator w = waves.begin(); w != waves.end(); ++w) {
+                       if (_region->muted()) {
+                               (*w)->property_wave_color() = UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_SelectedWaveForm.get(), MUTED_ALPHA);
+                       } else {
+                               (*w)->property_wave_color() = ARDOUR_UI::config()->canvasvar_SelectedWaveForm.get();
+                               (*w)->property_fill_color() = ARDOUR_UI::config()->canvasvar_SelectedWaveFormFill.get();
+                       }
+               }
+       } else {
+               if (_recregion) {
+                       UINT_TO_RGBA(ARDOUR_UI::config()->canvasvar_RecordingRect.get(), &r, &g, &b, &a);
+                       frame->property_fill_color_rgba() = RGBA_TO_UINT(r, g, b, a);
+
+                       for (vector<ArdourCanvas::WaveView*>::iterator w = waves.begin(); w != waves.end(); ++w) {
+                               if (_region->muted()) {
+                                       (*w)->property_wave_color() = UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_RecWaveForm.get(), MUTED_ALPHA);
+                               } else {
+                                       (*w)->property_wave_color() = ARDOUR_UI::config()->canvasvar_RecWaveForm.get();
+                                       (*w)->property_fill_color() = ARDOUR_UI::config()->canvasvar_RecWaveFormFill.get();
+                               }
+                       }
+               } else {
+                       UINT_TO_RGBA(ARDOUR_UI::config()->canvasvar_FrameBase.get(), &r, &g, &b, &a);
+                       frame->property_fill_color_rgba() = RGBA_TO_UINT(r, g, b, fill_opacity ? fill_opacity : a);
+
+                       for (vector<ArdourCanvas::WaveView*>::iterator w = waves.begin(); w != waves.end(); ++w) {
+                               if (_region->muted()) {
+                                       (*w)->property_wave_color() = UINT_RGBA_CHANGE_A(ARDOUR_UI::config()->canvasvar_WaveForm.get(), MUTED_ALPHA);
+                               } else {
+                                       (*w)->property_wave_color() = ARDOUR_UI::config()->canvasvar_WaveForm.get();
+                                       (*w)->property_fill_color() = ARDOUR_UI::config()->canvasvar_WaveFormFill.get();
+                               }
+                       }
+               }
+       }
+}
+
+void
+AudioRegionView::set_fade_visibility (bool yn)
+{
+       if (yn) {
+               if (fade_in_shape) {
+                       fade_in_shape->show();
+               }
+               if (fade_out_shape) {
+                       fade_out_shape->show ();
+               }
+               if (fade_in_handle) {
+                       fade_in_handle->show ();
+               }
+               if (fade_out_handle) {
+                       fade_out_handle->show ();
+               }
+       } else {
+               if (fade_in_shape) {
+                       fade_in_shape->hide();
+               }
+               if (fade_out_shape) {
+                       fade_out_shape->hide ();
+               }
+               if (fade_in_handle) {
+                       fade_in_handle->hide ();
+               }
+               if (fade_out_handle) {
+                       fade_out_handle->hide ();
+               }
+       }
+}
+
+void
+AudioRegionView::update_coverage_frames (LayerDisplay d)
+{
+       RegionView::update_coverage_frames (d);
+
+       fade_in_handle->raise_to_top ();
+       fade_out_handle->raise_to_top ();
 }