#include <cmath>
#include <cassert>
#include <algorithm>
+#include <vector>
#include <boost/scoped_array.hpp>
create_waves ();
- fade_in_shape = new ArdourCanvas::Curve (group);
+ fade_in_shape = new ArdourCanvas::PolyLine (group);
CANVAS_DEBUG_NAME (fade_in_shape, string_compose ("fade in shape for %1", region()->name()));
fade_in_shape->set_outline_color (fade_color);
fade_in_shape->set_data ("regionview", this);
- fade_out_shape = new ArdourCanvas::Curve (group);
+ fade_out_shape = new ArdourCanvas::PolyLine (group);
CANVAS_DEBUG_NAME (fade_out_shape, string_compose ("fade out shape for %1", region()->name()));
fade_out_shape->set_outline_color (fade_color);
fade_out_shape->set_data ("regionview", this);
AudioRegionView::setup_fade_handle_positions()
{
/* position of fade handle offset from the top of the region view */
- double const handle_pos = 2;
+ double const handle_pos = 1.0;
if (fade_in_handle) {
fade_in_handle->set_y0 (handle_pos);
float pos_x = trackview.editor().sample_to_pixel((*l).first);
- (*l).second->set (ArdourCanvas::Duple (pos_x, 2.0),
- ArdourCanvas::Duple (pos_x, _height - TimeAxisViewItem::NAME_HIGHLIGHT_SIZE - 1));
+ if (height >= NAME_HIGHLIGHT_THRESH) {
+ (*l).second->set (ArdourCanvas::Duple (pos_x, 2.0),
+ ArdourCanvas::Duple (pos_x, _height - TimeAxisViewItem::NAME_HIGHLIGHT_SIZE - 1));
+ } else {
+ (*l).second->set (ArdourCanvas::Duple (pos_x, 2.0),
+ ArdourCanvas::Duple (pos_x, _height - 1));
+ }
}
if (name_text) {
uint32_t npoints = std::min (gdk_screen_width(), (int) pwidth);
double effective_height;
- float curve[npoints];
+ std::vector<float> curve(npoints);
- audio_region()->fade_in()->curve().get_vector (0, audio_region()->fade_in()->back()->when, curve, npoints);
+ audio_region()->fade_in()->curve().get_vector (0, audio_region()->fade_in()->back()->when, &curve[0], npoints);
if (_height >= NAME_HIGHLIGHT_THRESH) {
- effective_height = _height - NAME_HIGHLIGHT_SIZE - 2;
+ effective_height = _height - NAME_HIGHLIGHT_SIZE - 1;
} else {
effective_height = _height - 2;
}
double xdelta = pwidth/npoints;
for (pi = 0, pc = 0; pc < npoints; ++pc) {
- points[pi].x = 1 + (pc * xdelta);
- points[pi++].y = 2 + (effective_height - (curve[pc] * effective_height));
+ points[pi].x = 1.0 + (pc * xdelta);
+ points[pi++].y = effective_height - (curve[pc] * effective_height);
}
/* draw the line */
- redraw_start_xfade_to (ar, width, points, effective_height);
+ redraw_start_xfade_to (ar, width, points, effective_height, handle_left);
- fade_in_shape->set (points);
+ // fade_in_shape->set (points);
/* ensure trim handle stays on top */
if (frame_handle_start) {
uint32_t npoints = std::min (gdk_screen_width(), (int) pwidth);
double effective_height;
- float curve[npoints];
+ std::vector<float> curve(npoints);
- audio_region()->fade_out()->curve().get_vector (0, audio_region()->fade_out()->back()->when, curve, npoints);
+ audio_region()->fade_out()->curve().get_vector (0, audio_region()->fade_out()->back()->when, &curve[0], npoints);
if (_height >= NAME_HIGHLIGHT_THRESH) {
- effective_height = _height - NAME_HIGHLIGHT_SIZE - 2;
+ effective_height = _height - (NAME_HIGHLIGHT_SIZE + 1); /* skip the top pixel that shows the frame of this regionview */
} else {
- effective_height = _height - 2;
+ effective_height = _height - 2; /* skip the top and bottom pixel that are the frame of this regionview */
}
/* points *MUST* be in anti-clockwise order */
-
+
Points points;
-
+
uint32_t pi, pc;
double xdelta = pwidth/npoints;
-
+
points.assign (npoints, Duple ());
-
+
for (pi = 0, pc = 0; pc < npoints; ++pc, ++pi) {
- points[pi].x = _pixel_width - pwidth + (pc * xdelta);
- points[pi].y = 2 + (effective_height - (curve[pc] * effective_height));
+ points[pi].x = 1.0 + _pixel_width - pwidth + (pc * xdelta);
+ points[pi].y = effective_height - (curve[pc] * effective_height);
}
/* draw the line */
- redraw_end_xfade_to (ar, width, points, effective_height);
+ redraw_end_xfade_to (ar, width, points, effective_height, handle_right, pwidth-2);
- fade_out_shape->set (points);
+ // fade_out_shape->set (points);
/* ensure trim handle stays on top */
if (frame_handle_end) {
}
void
-AudioRegionView::redraw_start_xfade_to (boost::shared_ptr<AudioRegion> ar, framecnt_t /*width*/, Points& points, double effective_height)
+AudioRegionView::redraw_start_xfade_to (boost::shared_ptr<AudioRegion> ar, framecnt_t /*width*/, Points& points, double effective_height,
+ double rect_width)
{
if (points.size() < 3) {
return;
}
if (!start_xfade_in) {
- start_xfade_in = new ArdourCanvas::Curve (group);
+ start_xfade_in = new ArdourCanvas::PolyLine (group);
CANVAS_DEBUG_NAME (start_xfade_in, string_compose ("xfade start in line for %1", region()->name()));
start_xfade_in->set_outline_color (ARDOUR_UI::config()->get_canvasvar_CrossfadeLine());
start_xfade_in->set_outline_width (1.5);
}
if (!start_xfade_out) {
- start_xfade_out = new ArdourCanvas::Curve (group);
+ start_xfade_out = new ArdourCanvas::PolyLine (group);
CANVAS_DEBUG_NAME (start_xfade_out, string_compose ("xfade start out line for %1", region()->name()));
uint32_t col = UINT_RGBA_CHANGE_A (ARDOUR_UI::config()->get_canvasvar_CrossfadeLine(), 128);
start_xfade_out->set_outline_color (col);
start_xfade_rect->set_data ("regionview", this);
}
- start_xfade_rect->set (ArdourCanvas::Rect (points.front().x, 1.0, points.back().x, effective_height));
+ start_xfade_rect->set (ArdourCanvas::Rect (1.0, 0.0, rect_width, effective_height));
start_xfade_rect->show ();
start_xfade_in->set (points);
if (!inverse) {
+ /* no inverse curve defined, show the inverse of the normal one */
+
for (Points::size_type i = 0, pci = 0; i < npoints; ++i, ++pci) {
ArdourCanvas::Duple &p (ipoints[pci]);
- p.x = i;
+ p.x = 1.0 + i;
+ /* invert with respect to y-axis */
p.y = effective_height - points[pci].y;
}
} else {
- float vec[npoints];
- inverse->curve().get_vector (0, inverse->back()->when, vec, npoints);
+ std::vector<float> vec(npoints);
+ inverse->curve().get_vector (0, inverse->back()->when, &vec[0], npoints);
for (Points::size_type i = 0, pci = 0; i < npoints; ++i, ++pci) {
ArdourCanvas::Duple &p (ipoints[pci]);
- p.x = i;
- p.y = 1.0 + effective_height - (effective_height * vec[i]);
+ p.x = 1.0 + i;
+ p.y = effective_height - (effective_height * vec[i]);
}
}
}
void
-AudioRegionView::redraw_end_xfade_to (boost::shared_ptr<AudioRegion> ar, framecnt_t width, Points& points, double effective_height)
+AudioRegionView::redraw_end_xfade_to (boost::shared_ptr<AudioRegion> ar, framecnt_t width, Points& points, double effective_height,
+ double rect_edge, double rect_width)
{
if (points.size() < 3) {
return;
}
if (!end_xfade_in) {
- end_xfade_in = new ArdourCanvas::Curve (group);
+ end_xfade_in = new ArdourCanvas::PolyLine (group);
CANVAS_DEBUG_NAME (end_xfade_in, string_compose ("xfade end in line for %1", region()->name()));
uint32_t col UINT_RGBA_CHANGE_A (ARDOUR_UI::config()->get_canvasvar_CrossfadeLine(), 128);
end_xfade_in->set_outline_color (col);
}
if (!end_xfade_out) {
- end_xfade_out = new ArdourCanvas::Curve (group);
+ end_xfade_out = new ArdourCanvas::PolyLine (group);
CANVAS_DEBUG_NAME (end_xfade_out, string_compose ("xfade end out line for %1", region()->name()));
end_xfade_out->set_outline_color (ARDOUR_UI::config()->get_canvasvar_CrossfadeLine());
end_xfade_out->set_outline_width (2.0);
end_xfade_rect->set_data ("regionview", this);
}
- end_xfade_rect->set (ArdourCanvas::Rect (points.front().x, 1.0, points.back().x, effective_height));
+ end_xfade_rect->set (ArdourCanvas::Rect (rect_edge, 1.0, rect_edge + rect_width, effective_height));
end_xfade_rect->show ();
end_xfade_in->set (points);
for (Points::size_type i = 0, pci = 0; i < npoints; ++i, ++pci) {
ArdourCanvas::Duple &p (ipoints[pci]);
- p.x = rend + i;
+ p.x = 1.0 + rend + i;
p.y = effective_height - points[pci].y;
}
for (Points::size_type i = 0, pci = 0; i < npoints; ++i) {
ArdourCanvas::Duple& p (ipoints[pci++]);
- p.x = rend + i;
- p.y = 1.0 + effective_height - (effective_height * vp[i]);
+ p.x = 1.0 + rend + i;
+ p.y = effective_height - (effective_height * vp[i]);
}
}
wave->set_y_position (yoff);
wave->set_height (ht);
wave->set_samples_per_pixel (samples_per_pixel);
- wave->set_show_zero_line (true);
+ wave->set_show_zero_line (false);
switch (Config->get_waveform_shape()) {
case Rectified:
}
void
-AudioRegionView::remove_gain_point_event (ArdourCanvas::Item *item, GdkEvent */*ev*/)
+AudioRegionView::remove_gain_point_event (ArdourCanvas::Item *item, GdkEvent* /*ev*/)
{
ControlPoint *cp = reinterpret_cast<ControlPoint *> (item->get_data ("control_point"));
audio_region()->envelope()->erase (cp->model());
trackview.editor().set_current_trimmable (_region);
trackview.editor().set_current_movable (_region);
- if (gain_line && trackview.editor().current_mouse_mode() == Editing::MouseGain) {
+ if (gain_line) {
+ /* these may or may not be visible depending on mouse mode */
gain_line->add_visibility (AutomationLine::ControlPoints);
}
trackview.editor().set_current_trimmable (boost::shared_ptr<Trimmable>());
trackview.editor().set_current_movable (boost::shared_ptr<Movable>());
- if (gain_line && trackview.editor().current_mouse_mode() == Editing::MouseGain) {
+ if (gain_line) {
gain_line->remove_visibility (AutomationLine::ControlPoints);
}
canvas_item->set (ArdourCanvas::Duple (-1.0, 2.0),
ArdourCanvas::Duple (1.0, _height - TimeAxisViewItem::NAME_HIGHLIGHT_SIZE - 1));
- canvas_item->property_first_arrowhead() = TRUE;
- canvas_item->property_last_arrowhead() = TRUE;
- canvas_item->property_arrow_shape_a() = 11.0;
- canvas_item->property_arrow_shape_b() = 0.0;
- canvas_item->property_arrow_shape_c() = 4.0;
-
canvas_item->raise_to_top ();
canvas_item->show ();