Move ARDOUR::Change into PBD so that Stateful can be aware of

[ardour.git] / gtk2_ardour / automation_region_view.cc

diff --git a/gtk2_ardour/automation_region_view.cc b/gtk2_ardour/automation_region_view.cc
index 98d402e348d41aab6424316aa779117fc851710a..f1000d7159b7ca488f085a46fd91d52c8a10a0b0 100644 (file)
--- a/gtk2_ardour/automation_region_view.cc
+++ b/gtk2_ardour/automation_region_view.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2007 Paul Davis 
+    Copyright (C) 2007 Paul Davis
     Author: Dave Robillard
 
     This program is free software; you can redistribute it and/or modify
@@ -17,12 +17,14 @@
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
-#include <pbd/memento_command.h>
-#include <ardour/automation_control.h>
-#include <ardour/event_type_map.h>
-#include <ardour/session.h>
-#include <ardour/source.h>
+#include "pbd/memento_command.h"
+#include "ardour/automation_control.h"
+#include "ardour/event_type_map.h"
+#include "ardour/session.h"
+#include "ardour/source.h"
+
 #include "automation_region_view.h"
+#include "gui_thread.h"
 #include "public_editor.h"
 
 #include "i18n.h"
@@ -33,23 +35,24 @@ AutomationRegionView::AutomationRegionView(ArdourCanvas::Group*
                                            const Evoral::Parameter&                  param,
                                            boost::shared_ptr<ARDOUR::AutomationList> list,
                                            double                                    spu,
-                                           Gdk::Color&                               basic_color)
+                                           Gdk::Color const &                        basic_color)
        : RegionView(parent, time_axis, region, spu, basic_color)
        , _parameter(param)
-{ 
+{
        if (list) {
                assert(list->parameter() == param);
                create_line(list);
        }
-       
-       group->signal_event().connect (mem_fun (this, &AutomationRegionView::canvas_event), false);
+
+       group->signal_event().connect (sigc::mem_fun (this, &AutomationRegionView::canvas_event), false);
+       group->raise_to_top();
 }
 
 void
-AutomationRegionView::init (Gdk::Color& basic_color, bool wfd)
+AutomationRegionView::init (Gdk::Color const & basic_color, bool /*wfd*/)
 {
        _enable_display = false;
-       
+
        RegionView::init(basic_color, false);
 
        compute_colors (basic_color);
@@ -58,7 +61,7 @@ AutomationRegionView::init (Gdk::Color& basic_color, bool wfd)
 
        set_height (trackview.current_height());
 
-       _region->StateChanged.connect (mem_fun(*this, &AutomationRegionView::region_changed));
+       _region->StateChanged.connect (*this, ui_bind (&RegionView::region_changed, this, _1), gui_context());
 
        set_colors ();
 
@@ -70,20 +73,18 @@ AutomationRegionView::create_line (boost::shared_ptr<ARDOUR::AutomationList> lis
 {
        _line = boost::shared_ptr<AutomationLine>(new AutomationLine(
                                ARDOUR::EventTypeMap::instance().to_symbol(list->parameter()),
-                               trackview, *get_canvas_group(), list,
-                               &_region->source(0)->time_converter()));
+                               trackview, *get_canvas_group(), list, &_time_converter));
        _line->set_colors();
        _line->set_interpolation(list->interpolation());
+       _line->set_height ((uint32_t)rint(trackview.current_height() - NAME_HIGHLIGHT_SIZE));
        _line->show();
        _line->show_all_control_points();
-       _line->set_height ((uint32_t)rint(trackview.current_height() - NAME_HIGHLIGHT_SIZE));
 }
 
 bool
 AutomationRegionView::canvas_event(GdkEvent* ev)
 {
        if (ev->type == GDK_BUTTON_RELEASE) {
-
                const nframes_t when = trackview.editor().pixel_to_frame((nframes_t)ev->button.x)
                        - _region->position();
                add_automation_event(ev, when, ev->button.y);
@@ -93,7 +94,7 @@ AutomationRegionView::canvas_event(GdkEvent* ev)
 }
 
 void
-AutomationRegionView::add_automation_event (GdkEvent* event, nframes_t when, double y)
+AutomationRegionView::add_automation_event (GdkEvent* /*event*/, nframes_t when, double y)
 {
        if (!_line) {
                boost::shared_ptr<Evoral::Control> c = _region->control(_parameter, true);
@@ -104,7 +105,7 @@ AutomationRegionView::add_automation_event (GdkEvent* event, nframes_t when, dou
        }
        assert(_line);
 
-       double x = 0;
+       double x = when;
        AutomationTimeAxisView* const view = automation_view();
 
        view->canvas_display()->w2i (x, y);
@@ -118,16 +119,16 @@ AutomationRegionView::add_automation_event (GdkEvent* event, nframes_t when, dou
 
        _line->view_to_model_coord (x, y);
 
-       view->session().begin_reversible_command (_("add automation event"));
+       view->session()->begin_reversible_command (_("add automation event"));
        XMLNode& before = _line->the_list()->get_state();
 
-       _line->the_list()->add (when, y);
+       _line->the_list()->add (x, y);
 
        XMLNode& after = _line->the_list()->get_state();
-       view->session().commit_reversible_command (new MementoCommand<ARDOUR::AutomationList>(
+       view->session()->commit_reversible_command (new MementoCommand<ARDOUR::AutomationList>(
                        *_line->the_list(), &before, &after));
 
-       view->session().set_dirty ();
+       view->session()->set_dirty ();
 }
 
 void
@@ -140,7 +141,7 @@ AutomationRegionView::set_height (double h)
 }
 
 bool
-AutomationRegionView::set_position (nframes_t pos, void* src, double* ignored)
+AutomationRegionView::set_position (nframes64_t pos, void* src, double* ignored)
 {
        return RegionView::set_position(pos, src, ignored);
 }
@@ -150,14 +151,14 @@ void
 AutomationRegionView::reset_width_dependent_items (double pixel_width)
 {
        RegionView::reset_width_dependent_items(pixel_width);
-       
+
        if (_line)
                _line->reset();
 }
 
 
 void
-AutomationRegionView::region_resized (ARDOUR::Change what_changed)
+AutomationRegionView::region_resized (PBD::Change what_changed)
 {
        RegionView::region_resized(what_changed);