replace unicode dash with (monospace) minus.
[ardour.git] / gtk2_ardour / editor.cc
index 0ba5f4054c46375a69c5160b6fadc1b486e5af51..1c9c613e4b72ffdafef6660ff62bd3cbf2a6cfb5 100644 (file)
@@ -44,6 +44,7 @@
 #include "pbd/memento_command.h"
 #include "pbd/unknown_type.h"
 #include "pbd/unwind.h"
+#include "pbd/stacktrace.h"
 
 #include <glibmm/miscutils.h>
 #include <gtkmm/image.h>
 #include "gtkmm2ext/cell_renderer_pixbuf_toggle.h"
 
 #include "ardour/audio_track.h"
-#include "ardour/audioplaylist.h"
+#include "ardour/audioengine.h"
 #include "ardour/audioregion.h"
 #include "ardour/location.h"
-#include "ardour/midi_region.h"
-#include "ardour/plugin_manager.h"
 #include "ardour/profile.h"
 #include "ardour/route_group.h"
-#include "ardour/session_directory.h"
-#include "ardour/session_route.h"
-#include "ardour/session_state_utils.h"
+#include "ardour/session_playlists.h"
 #include "ardour/tempo.h"
 #include "ardour/utils.h"
-#include "ardour/session_playlists.h"
-#include "ardour/audioengine.h"
 
 #include "control_protocol/control_protocol.h"
 
@@ -86,7 +81,6 @@
 #include "audio_time_axis.h"
 #include "automation_time_axis.h"
 #include "bundle_manager.h"
-#include "button_joiner.h"
 #include "canvas-noevent-text.h"
 #include "canvas_impl.h"
 #include "crossfade_edit.h"
@@ -214,24 +208,22 @@ static const gchar *_rb_opt_strings[] = {
 };
 #endif
 
-void
-show_me_the_size (Requisition* r, const char* what)
-{
-       cerr << "size of " << what << " = " << r->width << " x " << r->height << endl;
-}
-
-#ifdef GTKOSX
 static void
 pane_size_watcher (Paned* pane)
 {
        /* if the handle of a pane vanishes into (at least) the tabs of a notebook,
-          it is no longer accessible. so stop that. this doesn't happen on X11,
-          just the quartz backend.
+          it is:
+
+             X: hard to access
+             Quartz: impossible to access
+             
+          so stop that by preventing it from ever getting too narrow. 35
+          pixels is basically a rough guess at the tab width.
 
           ugh.
        */
 
-       int max_width_of_lhs = GTK_WIDGET(pane->gobj())->allocation.width - 25;
+       int max_width_of_lhs = GTK_WIDGET(pane->gobj())->allocation.width - 35;
 
        gint pos = pane->get_position ();
 
@@ -239,7 +231,6 @@ pane_size_watcher (Paned* pane)
                pane->set_position (max_width_of_lhs);
        }
 }
-#endif
 
 Editor::Editor ()
        : _join_object_range_state (JOIN_OBJECT_RANGE_NONE)
@@ -287,6 +278,8 @@ Editor::Editor ()
 
        , _region_selection_change_updates_region_list (true)
        , _following_mixer_selection (false)
+       , _control_point_toggled_on_press (false)
+       , _stepping_axis_view (0)
 {
        constructed = false;
 
@@ -391,67 +384,67 @@ Editor::Editor ()
        set_zoom_focus (ZoomFocusLeft);
        zoom_range_clock->ValueChanged.connect (sigc::mem_fun(*this, &Editor::zoom_adjustment_changed));
 
-       bbt_label.set_name ("EditorTimeButton");
+       bbt_label.set_name ("EditorRulerLabel");
        bbt_label.set_size_request (-1, (int)timebar_height);
        bbt_label.set_alignment (1.0, 0.5);
        bbt_label.set_padding (5,0);
        bbt_label.hide ();
        bbt_label.set_no_show_all();
-       minsec_label.set_name ("EditorTimeButton");
+       minsec_label.set_name ("EditorRulerLabel");
        minsec_label.set_size_request (-1, (int)timebar_height);
        minsec_label.set_alignment (1.0, 0.5);
        minsec_label.set_padding (5,0);
        minsec_label.hide ();
        minsec_label.set_no_show_all();
-       timecode_label.set_name ("EditorTimeButton");
+       timecode_label.set_name ("EditorRulerLabel");
        timecode_label.set_size_request (-1, (int)timebar_height);
        timecode_label.set_alignment (1.0, 0.5);
        timecode_label.set_padding (5,0);
        timecode_label.hide ();
        timecode_label.set_no_show_all();
-       samples_label.set_name ("EditorTimeButton");
+       samples_label.set_name ("EditorRulerLabel");
        samples_label.set_size_request (-1, (int)timebar_height);
        samples_label.set_alignment (1.0, 0.5);
        samples_label.set_padding (5,0);
        samples_label.hide ();
        samples_label.set_no_show_all();
 
-       tempo_label.set_name ("EditorTimeButton");
+       tempo_label.set_name ("EditorRulerLabel");
        tempo_label.set_size_request (-1, (int)timebar_height);
        tempo_label.set_alignment (1.0, 0.5);
        tempo_label.set_padding (5,0);
        tempo_label.hide();
        tempo_label.set_no_show_all();
 
-       meter_label.set_name ("EditorTimeButton");
+       meter_label.set_name ("EditorRulerLabel");
        meter_label.set_size_request (-1, (int)timebar_height);
        meter_label.set_alignment (1.0, 0.5);
        meter_label.set_padding (5,0);
        meter_label.hide();
        meter_label.set_no_show_all();
 
-       mark_label.set_name ("EditorTimeButton");
+       mark_label.set_name ("EditorRulerLabel");
        mark_label.set_size_request (-1, (int)timebar_height);
        mark_label.set_alignment (1.0, 0.5);
        mark_label.set_padding (5,0);
        mark_label.hide();
        mark_label.set_no_show_all();
 
-       cd_mark_label.set_name ("EditorTimeButton");
+       cd_mark_label.set_name ("EditorRulerLabel");
        cd_mark_label.set_size_request (-1, (int)timebar_height);
        cd_mark_label.set_alignment (1.0, 0.5);
        cd_mark_label.set_padding (5,0);
        cd_mark_label.hide();
        cd_mark_label.set_no_show_all();
 
-       range_mark_label.set_name ("EditorTimeButton");
+       range_mark_label.set_name ("EditorRulerLabel");
        range_mark_label.set_size_request (-1, (int)timebar_height);
        range_mark_label.set_alignment (1.0, 0.5);
        range_mark_label.set_padding (5,0);
        range_mark_label.hide();
        range_mark_label.set_no_show_all();
 
-       transport_mark_label.set_name ("EditorTimeButton");
+       transport_mark_label.set_name ("EditorRulerLabel");
        transport_mark_label.set_size_request (-1, (int)timebar_height);
        transport_mark_label.set_alignment (1.0, 0.5);
        transport_mark_label.set_padding (5,0);
@@ -606,13 +599,13 @@ Editor::Editor ()
 
        editor_summary_pane.signal_size_allocate().connect (sigc::bind (sigc::mem_fun (*this, &Editor::pane_allocation_handler), static_cast<Paned*> (&editor_summary_pane)));
 
-       /* XXX: editor_summary_pane might need similar special OS X treatment to the edit_pane */
+       /* XXX: editor_summary_pane might need similar to the edit_pane */
 
        edit_pane.signal_size_allocate().connect (sigc::bind (sigc::mem_fun(*this, &Editor::pane_allocation_handler), static_cast<Paned*> (&edit_pane)));
-#ifdef GTKOSX
+
        Glib::PropertyProxy<int> proxy = edit_pane.property_position();
        proxy.signal_changed().connect (bind (sigc::ptr_fun (pane_size_watcher), static_cast<Paned*> (&edit_pane)));
-#endif
+
        top_hbox.pack_start (toolbar_frame);
 
        HBox *hbox = manage (new HBox);
@@ -660,11 +653,13 @@ Editor::Editor ()
 
        /* nudge stuff */
 
-       nudge_forward_button.add (*(manage (new Image (::get_icon("nudge_right")))));
-       nudge_backward_button.add (*(manage (new Image (::get_icon("nudge_left")))));
+       nudge_forward_button.set_name ("zoom button");
+       nudge_forward_button.add_elements (ArdourButton::FlatFace);
+       nudge_forward_button.set_image(::get_icon("nudge_right"));
 
-       nudge_forward_button.set_name ("TransportButton");
-       nudge_backward_button.set_name ("TransportButton");
+       nudge_backward_button.set_name ("zoom button");
+       nudge_backward_button.add_elements (ArdourButton::FlatFace);
+       nudge_backward_button.set_image(::get_icon("nudge_left"));
 
        fade_context_menu.set_name ("ArdourContextMenu");
 
@@ -701,6 +696,8 @@ Editor::Editor ()
        signal_configure_event().connect (sigc::mem_fun (*ARDOUR_UI::instance(), &ARDOUR_UI::configure_handler));
        signal_delete_event().connect (sigc::mem_fun (*ARDOUR_UI::instance(), &ARDOUR_UI::exit_on_main_window_close));
 
+       Gtkmm2ext::Keyboard::the_keyboard().ShiftReleased.connect (sigc::mem_fun (*this, &Editor::shift_key_released));
+       
        /* allow external control surfaces/protocols to do various things */
 
        ControlProtocol::ZoomToSession.connect (*this, invalidator (*this), boost::bind (&Editor::temporal_zoom_session, this), gui_context());
@@ -799,6 +796,12 @@ Editor::add_toplevel_controls (Container& cont)
        cont.show_all ();
 }
 
+bool
+Editor::get_smart_mode () const
+{
+       return ( (current_mouse_mode() == Editing::MouseObject) && smart_mode_action->get_active() );
+}
+
 void
 Editor::catch_vanishing_regionview (RegionView *rv)
 {
@@ -919,12 +922,9 @@ Editor::zoom_adjustment_changed ()
        }
 
        double fpu = zoom_range_clock->current_duration() / _canvas_width;
-
-       if (fpu < 1.0) {
-               fpu = 1.0;
-               zoom_range_clock->set ((framepos_t) floor (fpu * _canvas_width));
-       } else if (fpu > _session->current_end_frame() / _canvas_width) {
-               fpu = _session->current_end_frame() / _canvas_width;
+       bool clamped = clamp_frames_per_unit (fpu);
+       
+       if (clamped) {
                zoom_range_clock->set ((framepos_t) floor (fpu * _canvas_width));
        }
 
@@ -1180,6 +1180,8 @@ Editor::update_title ()
                WindowTitle title(session_name);
                title += Glib::get_application_name();
                set_title (title.get_string());
+       } else {
+               /* ::session_going_away() will have taken care of it */
        }
 }
 
@@ -1273,7 +1275,7 @@ Editor::set_session (Session *t)
        _session->StepEditStatusChange.connect (_session_connections, invalidator (*this), boost::bind (&Editor::step_edit_status_change, this, _1), gui_context());
        _session->TransportStateChange.connect (_session_connections, invalidator (*this), boost::bind (&Editor::map_transport_state, this), gui_context());
        _session->PositionChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::map_position_change, this, _1), gui_context());
-       _session->RouteAdded.connect (_session_connections, invalidator (*this), boost::bind (&Editor::handle_new_route, this, _1), gui_context());
+       _session->RouteAdded.connect (_session_connections, invalidator (*this), boost::bind (&Editor::add_routes, this, _1), gui_context());
        _session->DirtyChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::update_title, this), gui_context());
        _session->tempo_map().PropertyChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::tempo_map_changed, this, _1), gui_context());
        _session->Located.connect (_session_connections, invalidator (*this), boost::bind (&Editor::located, this), gui_context());
@@ -1368,7 +1370,7 @@ Editor::fill_xfade_menu (Menu_Helpers::MenuList& items, bool start)
        
        items.push_back (
                ImageMenuElem (
-                       _("ConstantPower"),
+                       _("Constant power"),
                        *(*images)[FadeConstantPower],
                        sigc::bind (sigc::mem_fun (*this, emf), FadeConstantPower)
                        ));
@@ -1406,7 +1408,7 @@ Editor::fill_xfade_menu (Menu_Helpers::MenuList& items, bool start)
 
 /** Pop up a context menu for when the user clicks on a start crossfade */
 void
-Editor::popup_xfade_in_context_menu (int button, int32_t time, ArdourCanvas::Item* item, ItemType item_type)
+Editor::popup_xfade_in_context_menu (int button, int32_t time, ArdourCanvas::Item* /*item*/, ItemType /*item_type*/)
 {
        using namespace Menu_Helpers;
 
@@ -1421,7 +1423,7 @@ Editor::popup_xfade_in_context_menu (int button, int32_t time, ArdourCanvas::Ite
 
 /** Pop up a context menu for when the user clicks on an end crossfade */
 void
-Editor::popup_xfade_out_context_menu (int button, int32_t time, ArdourCanvas::Item* item, ItemType item_type)
+Editor::popup_xfade_out_context_menu (int button, int32_t time, ArdourCanvas::Item* /*item*/, ItemType /*item_type*/)
 {
        using namespace Menu_Helpers;
 
@@ -1505,7 +1507,7 @@ Editor::popup_fade_context_menu (int button, int32_t time, ArdourCanvas::Item* i
                                
                        items.push_back (
                                ImageMenuElem (
-                                       _("Constant Power"),
+                                       _("Constant power"),
                                        *_fade_in_images[FadeConstantPower],
                                        sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeConstantPower)
                                        ));
@@ -1567,7 +1569,7 @@ Editor::popup_fade_context_menu (int button, int32_t time, ArdourCanvas::Item* i
 
                        items.push_back (
                                ImageMenuElem (
-                                       _("Constant Power"),
+                                       _("Constant power"),
                                        *_fade_out_images[FadeConstantPower],
                                        sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeConstantPower)
                                        ));
@@ -1911,7 +1913,7 @@ Editor::add_selection_context_items (Menu_Helpers::MenuList& edit_items)
        edit_items.push_back (SeparatorElem());
        edit_items.push_back (MenuElem (_("Crop Region to Range"), sigc::mem_fun(*this, &Editor::crop_region_to_selection)));
        edit_items.push_back (MenuElem (_("Fill Range with Region"), sigc::mem_fun(*this, &Editor::region_fill_selection)));
-       edit_items.push_back (MenuElem (_("Duplicate Range"), sigc::bind (sigc::mem_fun(*this, &Editor::duplicate_dialog), false)));
+       edit_items.push_back (MenuElem (_("Duplicate Range"), sigc::bind (sigc::mem_fun(*this, &Editor::duplicate_range), false)));
 
        edit_items.push_back (SeparatorElem());
        edit_items.push_back (MenuElem (_("Consolidate Range"), sigc::bind (sigc::mem_fun(*this, &Editor::bounce_range_selection), true, false)));
@@ -2108,10 +2110,17 @@ Editor::set_snap_to (SnapType st)
        case SnapToBeatDiv5:
        case SnapToBeatDiv4:
        case SnapToBeatDiv3:
-       case SnapToBeatDiv2:
-               compute_bbt_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames());
-               update_tempo_based_rulers ();
+       case SnapToBeatDiv2: {
+               ARDOUR::TempoMap::BBTPointList::const_iterator current_bbt_points_begin;
+               ARDOUR::TempoMap::BBTPointList::const_iterator current_bbt_points_end;
+               
+               compute_current_bbt_points (leftmost_frame, leftmost_frame + current_page_frames(),
+                                           current_bbt_points_begin, current_bbt_points_end);
+               compute_bbt_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames(),
+                                        current_bbt_points_begin, current_bbt_points_end);
+               update_tempo_based_rulers (current_bbt_points_begin, current_bbt_points_end);
                break;
+       }
 
        case SnapToRegionStart:
        case SnapToRegionEnd:
@@ -2131,9 +2140,16 @@ Editor::set_snap_to (SnapType st)
 void
 Editor::set_snap_mode (SnapMode mode)
 {
-       _snap_mode = mode;
        string str = snap_mode_strings[(int)mode];
 
+       if (_internal_editing) {
+               internal_snap_mode = mode;
+       } else {
+               pre_internal_snap_mode = mode;
+       }
+
+       _snap_mode = mode;
+
        if (str != snap_mode_selector.get_active_text ()) {
                snap_mode_selector.set_active_text (str);
        }
@@ -2281,6 +2297,7 @@ Editor::set_state (const XMLNode& node, int /*version*/)
                pre_internal_snap_type = (SnapType) string_2_enum (prop->value(), pre_internal_snap_type);
        }
 
+
        if ((prop = node.property ("pre-internal-snap-mode"))) {
                pre_internal_snap_mode = (SnapMode) string_2_enum (prop->value(), pre_internal_snap_mode);
        }
@@ -2317,7 +2334,14 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        }
 
        if ((prop = node.property ("join-object-range"))) {
-               ActionManager::set_toggle_action ("MouseMode", "set-mouse-mode-object-range", string_is_affirmative (prop->value ()));
+               RefPtr<Action> act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-object-range"));
+               bool yn = string_is_affirmative (prop->value());
+               if (act) {
+                       RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
+                       tact->set_active (!yn);
+                       tact->set_active (yn);
+               }
+               set_mouse_mode(mouse_mode, true);
        }
 
        if ((prop = node.property ("edit-point"))) {
@@ -2745,7 +2769,10 @@ Editor::snap_to_internal (framepos_t& start, int32_t direction, bool for_mark)
 
                _session->locations()->marks_either_side (start, before, after);
 
-               if (before == max_framepos) {
+               if (before == max_framepos && after == max_framepos) {
+                       /* No marks to snap to, so just don't snap */
+                       return;
+               } else if (before == max_framepos) {
                        start = after;
                } else if (after == max_framepos) {
                        start = before;
@@ -2825,14 +2852,12 @@ Editor::setup_toolbar ()
        mode_box->set_spacing(4);
 
        HBox* mouse_mode_box = manage (new HBox);
-       HBox* mouse_mode_hbox1 = manage (new HBox);
-       HBox* mouse_mode_hbox2 = manage (new HBox);
-       VBox* mouse_mode_vbox1 = manage (new VBox);
-       VBox* mouse_mode_vbox2 = manage (new VBox);
-       Alignment* mouse_mode_align1 = manage (new Alignment);
-       Alignment* mouse_mode_align2 = manage (new Alignment);
+       HBox* mouse_mode_hbox = manage (new HBox);
+       VBox* mouse_mode_vbox = manage (new VBox);
+       Alignment* mouse_mode_align = manage (new Alignment);
 
        Glib::RefPtr<SizeGroup> mouse_mode_size_group = SizeGroup::create (SIZE_GROUP_BOTH);
+//     mouse_mode_size_group->add_widget (smart_mode_button);
        mouse_mode_size_group->add_widget (mouse_move_button);
        mouse_mode_size_group->add_widget (mouse_select_button);
        mouse_mode_size_group->add_widget (mouse_zoom_button);
@@ -2843,32 +2868,26 @@ Editor::setup_toolbar ()
        mouse_mode_size_group->add_widget (internal_edit_button);
 
        /* make them just a bit bigger */
-       mouse_move_button.set_size_request (-1, 25);
-
-       smart_mode_joiner = manage (new ButtonJoiner ("mouse mode button", mouse_move_button, mouse_select_button, true));
-       smart_mode_joiner->set_related_action (smart_mode_action);
+       mouse_move_button.set_size_request (-1, 30);
 
-       mouse_mode_hbox2->set_spacing (2);
-       mouse_mode_box->set_spacing (2);
+       mouse_mode_hbox->set_spacing (2);
 
-       mouse_mode_hbox1->pack_start (*smart_mode_joiner, false, false);
-       mouse_mode_hbox2->pack_start (mouse_zoom_button, false, false);
-       mouse_mode_hbox2->pack_start (mouse_gain_button, false, false);
-       mouse_mode_hbox2->pack_start (mouse_timefx_button, false, false);
-       mouse_mode_hbox2->pack_start (mouse_audition_button, false, false);
-       mouse_mode_hbox2->pack_start (mouse_draw_button, false, false);
-       mouse_mode_hbox2->pack_start (internal_edit_button, false, false);
+       mouse_mode_hbox->pack_start (smart_mode_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_move_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_select_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_zoom_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_gain_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_timefx_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_audition_button, false, false);
+       mouse_mode_hbox->pack_start (mouse_draw_button, false, false);
+       mouse_mode_hbox->pack_start (internal_edit_button, false, false, 8);
 
-       mouse_mode_vbox1->pack_start (*mouse_mode_hbox1, false, false);
-       mouse_mode_vbox2->pack_start (*mouse_mode_hbox2, false, false);
+       mouse_mode_vbox->pack_start (*mouse_mode_hbox);
 
-       mouse_mode_align1->add (*mouse_mode_vbox1);
-       mouse_mode_align1->set (0.5, 1.0, 0.0, 0.0);
-       mouse_mode_align2->add (*mouse_mode_vbox2);
-       mouse_mode_align2->set (0.5, 1.0, 0.0, 0.0);
+       mouse_mode_align->add (*mouse_mode_vbox);
+       mouse_mode_align->set (0.5, 1.0, 0.0, 0.0);
 
-       mouse_mode_box->pack_start (*mouse_mode_align1, false, false);
-       mouse_mode_box->pack_start (*mouse_mode_align2, false, false);
+       mouse_mode_box->pack_start (*mouse_mode_align, false, false);
 
        edit_mode_strings.push_back (edit_mode_to_string (Slide));
        if (!Profile->get_sae()) {
@@ -2908,20 +2927,23 @@ Editor::setup_toolbar ()
        RefPtr<Action> act;
 
        zoom_in_button.set_name ("zoom button");
-       zoom_in_button.set_image (::get_icon ("zoom_in"));
-       zoom_in_button.set_tweaks (ArdourButton::ShowClick);
+       zoom_in_button.add_elements ( ArdourButton::FlatFace );
+       zoom_in_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
+       zoom_in_button.set_image(::get_icon ("zoom_in"));
        act = ActionManager::get_action (X_("Editor"), X_("temporal-zoom-in"));
        zoom_in_button.set_related_action (act);
 
        zoom_out_button.set_name ("zoom button");
-       zoom_out_button.set_image (::get_icon ("zoom_out"));
-       zoom_out_button.set_tweaks (ArdourButton::ShowClick);
+       zoom_out_button.add_elements ( ArdourButton::FlatFace );
+       zoom_out_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
+       zoom_out_button.set_image(::get_icon ("zoom_out"));
        act = ActionManager::get_action (X_("Editor"), X_("temporal-zoom-out"));
        zoom_out_button.set_related_action (act);
 
        zoom_out_full_button.set_name ("zoom button");
-       zoom_out_full_button.set_image (::get_icon ("zoom_full"));
-       zoom_out_full_button.set_tweaks (ArdourButton::ShowClick);
+       zoom_out_full_button.add_elements ( ArdourButton::FlatFace );
+       zoom_out_full_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
+       zoom_out_full_button.set_image(::get_icon ("zoom_full"));
        act = ActionManager::get_action (X_("Editor"), X_("zoom-to-session"));
        zoom_out_full_button.set_related_action (act);
 
@@ -2936,17 +2958,21 @@ Editor::setup_toolbar ()
        _zoom_box.pack_start (zoom_focus_selector, false, false);
 
        /* Track zoom buttons */
-       tav_expand_button.set_name ("TrackHeightButton");
+       tav_expand_button.set_name ("zoom button");
+       tav_expand_button.add_elements ( ArdourButton::FlatFace );
+       tav_expand_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
        tav_expand_button.set_size_request (-1, 20);
-       tav_expand_button.add (*(manage (new Image (::get_icon ("tav_exp")))));
+       tav_expand_button.set_image(::get_icon ("tav_exp"));
        act = ActionManager::get_action (X_("Editor"), X_("expand-tracks"));
-       act->connect_proxy (tav_expand_button);
+       tav_expand_button.set_related_action (act);
 
-       tav_shrink_button.set_name ("TrackHeightButton");
+       tav_shrink_button.set_name ("zoom button");
+       tav_shrink_button.add_elements ( ArdourButton::FlatFace );
+       tav_shrink_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
        tav_shrink_button.set_size_request (-1, 20);
-       tav_shrink_button.add (*(manage (new Image (::get_icon ("tav_shrink")))));
+       tav_shrink_button.set_image(::get_icon ("tav_shrink"));
        act = ActionManager::get_action (X_("Editor"), X_("shrink-tracks"));
-       act->connect_proxy (tav_shrink_button);
+       tav_shrink_button.set_related_action (act);
 
        _zoom_box.pack_start (tav_shrink_button);
        _zoom_box.pack_start (tav_expand_button);
@@ -2962,7 +2988,7 @@ Editor::setup_toolbar ()
        _zoom_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
                                                    &_zoom_tearoff->tearoff_window(), 0));
 
-       snap_box.set_spacing (1);
+       snap_box.set_spacing (2);
        snap_box.set_border_width (2);
 
        snap_type_selector.set_name ("SnapTypeSelector");
@@ -2990,6 +3016,9 @@ Editor::setup_toolbar ()
        nudge_forward_button.signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::nudge_forward_release), false);
        nudge_backward_button.signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::nudge_backward_release), false);
 
+       nudge_forward_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
+       nudge_backward_button.set_tweaks ((ArdourButton::Tweaks) (ArdourButton::ShowClick) );
+
        nudge_box->pack_start (nudge_backward_button, false, false);
        nudge_box->pack_start (nudge_forward_button, false, false);
        nudge_box->pack_start (*nudge_clock, false, false);
@@ -3049,15 +3078,15 @@ Editor::setup_toolbar ()
 void
 Editor::setup_tooltips ()
 {
-       ARDOUR_UI::instance()->set_tip (mouse_move_button, _("Select/Move Objects"));
-       ARDOUR_UI::instance()->set_tip (mouse_select_button, _("Select/Move Ranges"));
+       ARDOUR_UI::instance()->set_tip (smart_mode_button, _("Smart Mode (add Range functions to Object mode)"));
+       ARDOUR_UI::instance()->set_tip (mouse_move_button, _("Object Mode (select/move Objects)"));
+       ARDOUR_UI::instance()->set_tip (mouse_select_button, _("Range Mode (select/move Ranges)"));
        ARDOUR_UI::instance()->set_tip (mouse_draw_button, _("Draw/Edit MIDI Notes"));
        ARDOUR_UI::instance()->set_tip (mouse_gain_button, _("Draw Region Gain"));
        ARDOUR_UI::instance()->set_tip (mouse_zoom_button, _("Select Zoom Range"));
        ARDOUR_UI::instance()->set_tip (mouse_timefx_button, _("Stretch/Shrink Regions and MIDI Notes"));
        ARDOUR_UI::instance()->set_tip (mouse_audition_button, _("Listen to Specific Regions"));
-       ARDOUR_UI::instance()->set_tip (smart_mode_joiner, _("Smart Mode (Select/Move Objects + Ranges)"));
-       ARDOUR_UI::instance()->set_tip (internal_edit_button, _("Edit Region Contents (e.g. notes)"));
+       ARDOUR_UI::instance()->set_tip (internal_edit_button, _("Note Level Editing"));
        ARDOUR_UI::instance()->set_tip (*_group_tabs, _("Groups: click to (de)activate\nContext-click for other operations"));
        ARDOUR_UI::instance()->set_tip (nudge_forward_button, _("Nudge Region/Selection Later"));
        ARDOUR_UI::instance()->set_tip (nudge_backward_button, _("Nudge Region/Selection Earlier"));
@@ -3111,8 +3140,8 @@ Editor::convert_drop_to_paths (
                const char* q;
 
                p = (const char *) malloc (txt.length() + 1);
-               txt.copy ((char *) p, txt.length(), 0);
-               ((char*)p)[txt.length()] = '\0';
+               txt.copy (const_cast<char *> (p), txt.length(), 0);
+               const_cast<char*>(p)[txt.length()] = '\0';
 
                while (p)
                {
@@ -3193,7 +3222,7 @@ Editor::new_tempo_section ()
 void
 Editor::map_transport_state ()
 {
-       ENSURE_GUI_THREAD (*this, &Editor::map_transport_state)
+       ENSURE_GUI_THREAD (*this, &Editor::map_transport_state);
 
        if (_session && _session->transport_stopped()) {
                have_pending_keyboard_selection = false;
@@ -3253,19 +3282,13 @@ Editor::history_changed ()
 }
 
 void
-Editor::duplicate_dialog (bool with_dialog)
+Editor::duplicate_range (bool with_dialog)
 {
        float times = 1.0f;
 
-       if (mouse_mode == MouseRange) {
-               if (selection->time.length() == 0) {
-                       return;
-               }
-       }
-
        RegionSelection rs = get_regions_from_selection_and_entered ();
 
-       if (mouse_mode != MouseRange && rs.empty()) {
+       if ( selection->time.length() == 0 && rs.empty()) {
                return;
        }
 
@@ -3312,8 +3335,15 @@ Editor::duplicate_dialog (bool with_dialog)
                times = adjustment.get_value();
        }
 
-       if (mouse_mode == MouseRange) {
-               duplicate_selection (times);
+       if ((current_mouse_mode() == Editing::MouseRange)) {
+               if (selection->time.length()) {
+                       duplicate_selection (times);
+               }
+       } else if (get_smart_mode()) {
+               if (selection->time.length()) {
+                       duplicate_selection (times);
+               } else 
+                       duplicate_some_regions (rs, times);
        } else {
                duplicate_some_regions (rs, times);
        }
@@ -3557,6 +3587,31 @@ Editor::set_zoom_focus (ZoomFocus f)
        }
 }
 
+void
+Editor::cycle_zoom_focus ()
+{
+       switch (zoom_focus) {
+       case ZoomFocusLeft:
+               set_zoom_focus (ZoomFocusRight);
+               break;
+       case ZoomFocusRight:
+               set_zoom_focus (ZoomFocusCenter);
+               break;
+       case ZoomFocusCenter:
+               set_zoom_focus (ZoomFocusPlayhead);
+               break;
+       case ZoomFocusPlayhead:
+               set_zoom_focus (ZoomFocusMouse);
+               break;
+       case ZoomFocusMouse:
+               set_zoom_focus (ZoomFocusEdit);
+               break;
+       case ZoomFocusEdit:
+               set_zoom_focus (ZoomFocusLeft);
+               break;
+       }
+}
+
 void
 Editor::ensure_float (Window& win)
 {
@@ -3656,9 +3711,10 @@ Editor::set_show_measures (bool yn)
                hide_measures ();
 
                if ((_show_measures = yn) == true) {
-                       if (tempo_lines)
+                       if (tempo_lines) {
                                tempo_lines->show();
-                       draw_measures ();
+                       }
+                       (void) redraw_measures ();
                }
                instant_save ();
        }
@@ -3933,6 +3989,15 @@ Editor::session_state_saved (string)
        _snapshots->redisplay ();
 }
 
+void
+Editor::update_tearoff_visibility()
+{
+       bool visible = Config->get_keep_tearoffs();
+       _mouse_mode_tearoff->set_visible (visible);
+       _tools_tearoff->set_visible (visible);
+       _zoom_tearoff->set_visible (visible);
+}
+
 void
 Editor::maximise_editing_space ()
 {
@@ -3942,15 +4007,6 @@ Editor::maximise_editing_space ()
 
        fullscreen ();
 
-       if (!Config->get_keep_tearoffs()) {
-               /* these calls will leave each tearoff visible *if* it is torn off, 
-                  but invisible otherwise.
-               */
-               _mouse_mode_tearoff->set_visible (false);
-               _tools_tearoff->set_visible (false);
-               _zoom_tearoff->set_visible (false);
-       }
-
        _maximised = true;
 }
 
@@ -3963,12 +4019,6 @@ Editor::restore_editing_space ()
 
        unfullscreen();
 
-       if (!Config->get_keep_tearoffs()) {
-               _mouse_mode_tearoff->set_visible (true);
-               _tools_tearoff->set_visible (true);
-               _zoom_tearoff->set_visible (true);
-       }
-
        _maximised = false;
 }
 
@@ -3984,7 +4034,7 @@ Editor::new_playlists (TimeAxisView* v)
        begin_reversible_command (_("new playlists"));
        vector<boost::shared_ptr<ARDOUR::Playlist> > playlists;
        _session->playlists->get (playlists);
-       mapover_tracks (sigc::bind (sigc::mem_fun (*this, &Editor::mapped_use_new_playlist), playlists), v, ARDOUR::Properties::edit.property_id);
+       mapover_tracks (sigc::bind (sigc::mem_fun (*this, &Editor::mapped_use_new_playlist), playlists), v, ARDOUR::Properties::select.property_id);
        commit_reversible_command ();
 }
 
@@ -4000,7 +4050,7 @@ Editor::copy_playlists (TimeAxisView* v)
        begin_reversible_command (_("copy playlists"));
        vector<boost::shared_ptr<ARDOUR::Playlist> > playlists;
        _session->playlists->get (playlists);
-       mapover_tracks (sigc::bind (sigc::mem_fun (*this, &Editor::mapped_use_copy_playlist), playlists), v, ARDOUR::Properties::edit.property_id);
+       mapover_tracks (sigc::bind (sigc::mem_fun (*this, &Editor::mapped_use_copy_playlist), playlists), v, ARDOUR::Properties::select.property_id);
        commit_reversible_command ();
 }
 
@@ -4015,7 +4065,7 @@ Editor::clear_playlists (TimeAxisView* v)
        begin_reversible_command (_("clear playlists"));
        vector<boost::shared_ptr<ARDOUR::Playlist> > playlists;
        _session->playlists->get (playlists);
-       mapover_tracks (sigc::mem_fun (*this, &Editor::mapped_clear_playlist), v, ARDOUR::Properties::edit.property_id);
+       mapover_tracks (sigc::mem_fun (*this, &Editor::mapped_clear_playlist), v, ARDOUR::Properties::select.property_id);
        commit_reversible_command ();
 }
 
@@ -4056,19 +4106,31 @@ Editor::on_key_release_event (GdkEventKey* ev)
 void
 Editor::reset_x_origin (framepos_t frame)
 {
-       queue_visual_change (frame);
+       pending_visual_change.add (VisualChange::TimeOrigin);
+       pending_visual_change.time_origin = frame;
+       ensure_visual_change_idle_handler ();
 }
 
 void
 Editor::reset_y_origin (double y)
 {
-       queue_visual_change_y (y);
+       pending_visual_change.add (VisualChange::YOrigin);
+       pending_visual_change.y_origin = y;
+       ensure_visual_change_idle_handler ();
 }
 
 void
 Editor::reset_zoom (double fpu)
 {
-       queue_visual_change (fpu);
+       clamp_frames_per_unit (fpu);
+
+       if (fpu == frames_per_unit) {
+               return;
+       }
+
+       pending_visual_change.add (VisualChange::ZoomLevel);
+       pending_visual_change.frames_per_unit = fpu;
+       ensure_visual_change_idle_handler ();
 }
 
 void
@@ -4173,41 +4235,20 @@ Editor::use_visual_state (VisualState& vs)
        _routes->resume_redisplay ();
 }
 
+/** This is the core function that controls the zoom level of the canvas. It is called
+ *  whenever one or more calls are made to reset_zoom().  It executes in an idle handler.
+ *  @param fpu New frames per unit; should already have been clamped so that it is sensible.
+ */
 void
 Editor::set_frames_per_unit (double fpu)
 {
-       /* this is the core function that controls the zoom level of the canvas. it is called
-          whenever one or more calls are made to reset_zoom(). it executes in an idle handler.
-       */
-
-       if (fpu == frames_per_unit) {
-               return;
-       }
-
-       if (fpu < 2.0) {
-               fpu = 2.0;
-       }
-
-
-       /* don't allow zooms that fit more than the maximum number
-          of frames into an 800 pixel wide space.
-       */
-
-       if (max_framepos / fpu < 800.0) {
-               return;
-       }
-
-       if (tempo_lines)
+       if (tempo_lines) {
                tempo_lines->tempo_map_changed();
+       }
 
        frames_per_unit = fpu;
-       post_zoom ();
-}
 
-void
-Editor::post_zoom ()
-{
-       // convert fpu to frame count
+       /* convert fpu to frame count */
 
        framepos_t frames = (framepos_t) floor (frames_per_unit * _canvas_width);
 
@@ -4215,9 +4256,7 @@ Editor::post_zoom ()
                zoom_range_clock->set (frames);
        }
 
-       bool const showing_time_selection =
-               mouse_mode == MouseRange ||
-               (mouse_mode == MouseObject && _join_object_range_state != JOIN_OBJECT_RANGE_NONE);
+       bool const showing_time_selection = selection->time.length() > 0;
 
        if (showing_time_selection && selection->time.start () != selection->time.end_frame ()) {
                for (TrackViewList::iterator i = selection->tracks.begin(); i != selection->tracks.end(); ++i) {
@@ -4241,32 +4280,6 @@ Editor::post_zoom ()
        instant_save ();
 }
 
-void
-Editor::queue_visual_change (framepos_t where)
-{
-       pending_visual_change.add (VisualChange::TimeOrigin);
-       pending_visual_change.time_origin = where;
-       ensure_visual_change_idle_handler ();
-}
-
-void
-Editor::queue_visual_change (double fpu)
-{
-       pending_visual_change.add (VisualChange::ZoomLevel);
-       pending_visual_change.frames_per_unit = fpu;
-
-       ensure_visual_change_idle_handler ();
-}
-
-void
-Editor::queue_visual_change_y (double y)
-{
-       pending_visual_change.add (VisualChange::YOrigin);
-       pending_visual_change.y_origin = y;
-
-       ensure_visual_change_idle_handler ();
-}
-
 void
 Editor::ensure_visual_change_idle_handler ()
 {
@@ -4284,6 +4297,19 @@ Editor::_idle_visual_changer (void* arg)
 int
 Editor::idle_visual_changer ()
 {
+       /* set_horizontal_position() below (and maybe other calls) call
+          gtk_main_iteration(), so it's possible that a signal will be handled
+          half-way through this method.  If this signal wants an
+          idle_visual_changer we must schedule another one after this one, so
+          mark the idle_handler_id as -1 here to allow that.  Also make a note
+          that we are doing the visual change, so that changes in response to
+          super-rapid-screen-update can be dropped if we are still processing
+          the last one.
+       */
+
+       pending_visual_change.idle_handler_id = -1;
+       pending_visual_change.being_handled = true;
+       
        VisualChange::Type p = pending_visual_change.pending;
        pending_visual_change.pending = (VisualChange::Type) 0;
 
@@ -4293,9 +4319,15 @@ Editor::idle_visual_changer ()
                set_frames_per_unit (pending_visual_change.frames_per_unit);
 
                compute_fixed_ruler_scale ();
-               compute_current_bbt_points(pending_visual_change.time_origin, pending_visual_change.time_origin + current_page_frames());
-               compute_bbt_ruler_scale (pending_visual_change.time_origin, pending_visual_change.time_origin + current_page_frames());
-               update_tempo_based_rulers ();
+
+               ARDOUR::TempoMap::BBTPointList::const_iterator current_bbt_points_begin;
+               ARDOUR::TempoMap::BBTPointList::const_iterator current_bbt_points_end;
+               
+               compute_current_bbt_points (pending_visual_change.time_origin, pending_visual_change.time_origin + current_page_frames(),
+                                           current_bbt_points_begin, current_bbt_points_end);
+               compute_bbt_ruler_scale (pending_visual_change.time_origin, pending_visual_change.time_origin + current_page_frames(),
+                                        current_bbt_points_begin, current_bbt_points_end);
+               update_tempo_based_rulers (current_bbt_points_begin, current_bbt_points_end);
        }
        if (p & VisualChange::TimeOrigin) {
                set_horizontal_position (pending_visual_change.time_origin / frames_per_unit);
@@ -4312,7 +4344,7 @@ Editor::idle_visual_changer ()
 
        _summary->set_overlays_dirty ();
 
-       pending_visual_change.idle_handler_id = -1;
+       pending_visual_change.being_handled = false;
        return 0; /* this is always a one-shot call */
 }
 
@@ -4422,7 +4454,7 @@ Editor::set_punch_range (framepos_t start, framepos_t end, string cmd)
        Location* tpl;
 
        if ((tpl = transport_punch_location()) == 0) {
-               Location* loc = new Location (*_session, start, end, _("Loop"),  Location::IsAutoPunch);
+               Location* loc = new Location (*_session, start, end, _("Punch"),  Location::IsAutoPunch);
                XMLNode &before = _session->locations()->get_state();
                _session->locations()->add (loc, true);
                _session->set_auto_loop_location (loc);
@@ -4523,7 +4555,7 @@ Editor::get_regions_after (RegionSelection& rs, framepos_t where, const TrackVie
 RegionSelection
 Editor::get_regions_from_selection ()
 {
-       return get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
+       return get_equivalent_regions (selection->regions, ARDOUR::Properties::select.property_id);
 }
 
 /** Get regions using the following method:
@@ -4532,16 +4564,15 @@ Editor::get_regions_from_selection ()
  *  the edit point is `mouse' and the mouse is over an unselected
  *  region.  In this case, start with just that region.
  *
- *  Then, make an initial track list of the tracks that these
- *  regions are on, and if the edit point is not `mouse', add the
- *  selected tracks.
+ *  Then, add equivalent regions in active edit groups to the region list.
  *
- *  Look at this track list and add any other tracks that are on the
- *  same active edit-enabled route group as one of the initial tracks.
+ *  Then, search the list of selected tracks to find any selected tracks which
+ *  do not contain regions already in the region list. If there are no selected
+ *  tracks and 'No Selection = All Tracks' is active, search all tracks rather
+ *  than just the selected.
  *
- *  Finally take the initial region list and add any regions that are
- *  under the edit point on one of the tracks on the track list to get
- *  the returned region list.
+ *  Add any regions that are under the edit point on these tracks to get the
+ *  returned region list.
  *
  *  The rationale here is that the mouse edit point is special in that
  *  its position describes both a time and a track; the other edit
@@ -4569,22 +4600,40 @@ Editor::get_regions_from_selection_and_edit_point ()
                tracks = selection->tracks;
        }
 
-       /* Add any other tracks that have regions that are in the same
+       /* Add any other regions that are in the same
           edit-activated route group as one of our regions.
         */
-       for (RegionSelection::iterator i = regions.begin (); i != regions.end(); ++i) {
+       regions = get_equivalent_regions (regions, ARDOUR::Properties::select.property_id);
+       framepos_t const where = get_preferred_edit_position ();
 
-               RouteGroup* g = (*i)->get_time_axis_view().route_group ();
-
-               if (g && g->is_active() && g->is_edit()) {
-                       tracks.add (axis_views_from_routes (g->route_list()));
-               }
+       if (_route_groups->all_group_active_button().get_active() && tracks.empty()) {
+               /* tracks is empty (no track selected), and 'No Selection = All Tracks'
+                * is enabled, so consider all tracks
+                */
+               tracks = track_views; 
        }
 
        if (!tracks.empty()) {
-               /* now find regions that are at the edit position on those tracks */
-               framepos_t const where = get_preferred_edit_position ();
-               get_regions_at (regions, where, tracks);
+               /* now search the selected tracks for tracks which don't
+                  already contain regions to be acted upon, and get regions at
+                  the edit point on those tracks too.
+                */
+               TrackViewList tracks_without_relevant_regions;
+
+               for (TrackViewList::iterator t = tracks.begin (); t != tracks.end (); ++t) {
+                       if (!regions.involves (**t)) {
+                               /* there are no equivalent regions on this track */
+                               tracks_without_relevant_regions.push_back (*t);
+                       }
+               }
+
+               if (!tracks_without_relevant_regions.empty()) {
+                       /* there are some selected tracks with neither selected
+                        * regions or their equivalents: act upon all regions in
+                        * those tracks
+                        */
+                       get_regions_at (regions, where, tracks_without_relevant_regions);
+               }
        }
 
        return regions;
@@ -4604,11 +4653,11 @@ Editor::get_regions_from_selection_and_entered ()
                regions.add (entered_regionview);
        }
 
-       return get_equivalent_regions (regions, ARDOUR::Properties::edit.property_id);
+       return get_equivalent_regions (regions, ARDOUR::Properties::select.property_id);
 }
 
 void
-Editor::get_regions_corresponding_to (boost::shared_ptr<Region> region, vector<RegionView*>& regions)
+Editor::get_regions_corresponding_to (boost::shared_ptr<Region> region, vector<RegionView*>& regions, bool src_comparison)
 {
        for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
 
@@ -4627,7 +4676,11 @@ Editor::get_regions_corresponding_to (boost::shared_ptr<Region> region, vector<R
                        }
 
                        if ((pl = (tr->playlist())) != 0) {
-                               pl->get_region_list_equivalent_regions (region, results);
+                               if (src_comparison) {
+                                       pl->get_source_equivalent_regions (region, results);
+                               } else {
+                                       pl->get_region_list_equivalent_regions (region, results);
+                               }
                        }
 
                        for (vector<boost::shared_ptr<Region> >::iterator ir = results.begin(); ir != results.end(); ++ir) {
@@ -4747,9 +4800,11 @@ Editor::located ()
 {
        ENSURE_GUI_THREAD (*this, &Editor::located);
 
-       playhead_cursor->set_position (_session->audible_frame ());
-       if (_follow_playhead && !_pending_initial_locate) {
-               reset_x_origin_to_follow_playhead ();
+       if (_session) {
+               playhead_cursor->set_position (_session->audible_frame ());
+               if (_follow_playhead && !_pending_initial_locate) {
+                       reset_x_origin_to_follow_playhead ();
+               }
        }
 
        _pending_locate_request = false;
@@ -4799,9 +4854,8 @@ Editor::axis_views_from_routes (boost::shared_ptr<RouteList> r) const
        return t;
 }
 
-
 void
-Editor::handle_new_route (RouteList& routes)
+Editor::add_routes (RouteList& routes)
 {
        ENSURE_GUI_THREAD (*this, &Editor::handle_new_route, routes)
 
@@ -5217,7 +5271,14 @@ Editor::super_rapid_screen_update ()
 
                if (!_stationary_playhead) {
 
-                       if (!_dragging_playhead && _follow_playhead && _session->requested_return_frame() < 0) {
+                       if (!_dragging_playhead && _follow_playhead && _session->requested_return_frame() < 0 && !pending_visual_change.being_handled) {
+                               /* We only do this if we aren't already
+                                  handling a visual change (ie if
+                                  pending_visual_change.being_handled is
+                                  false) so that these requests don't stack
+                                  up there are too many of them to handle in
+                                  time.
+                               */
                                reset_x_origin_to_follow_playhead ();
                        }
 
@@ -5305,8 +5366,8 @@ Editor::session_going_away ()
        hide_measures ();
        clear_marker_display ();
 
-       current_bbt_points_begin = current_bbt_points_end;
-
+       stop_step_editing ();
+       
        /* get rid of any existing editor mixer strip */
 
        WindowTitle title(Glib::get_application_name());
@@ -5467,3 +5528,8 @@ Editor::popup_control_point_context_menu (ArdourCanvas::Item* item, GdkEvent* ev
        _control_point_context_menu.popup (event->button.button, event->button.time);
 }
 
+void
+Editor::shift_key_released ()
+{
+       _stepping_axis_view = 0;
+}