Fix double-display of VST preset names (#3576)
[ardour.git] / gtk2_ardour / editor.cc
index a044f2ad91c9c8bfb70798e8b6c2f2f325cd4462..84cd70ee67b38dc6d037ebe6f272bc5663cce6e0 100644 (file)
@@ -19,7 +19,6 @@
 
 /* Note: public Editor methods are documented in public_editor.h */
 
-#define __STDC_LIMIT_MACROS 1
 #include <stdint.h>
 #include <unistd.h>
 #include <cstdlib>
 #include "editor_snapshots.h"
 #include "editor_summary.h"
 #include "region_layering_order_editor.h"
+#include "mouse_cursors.h"
+#include "editor_cursors.h"
 
 #include "i18n.h"
 
@@ -137,8 +138,6 @@ using Gtkmm2ext::Keyboard;
 
 const double Editor::timebar_height = 15.0;
 
-#include "editor_xpms"
-
 static const gchar *_snap_type_strings[] = {
        N_("CD Frames"),
        N_("Timecode Frames"),
@@ -208,31 +207,6 @@ static const gchar *_rb_opt_strings[] = {
 };
 #endif
 
-/* Soundfile  drag-n-drop */
-
-Gdk::Cursor* Editor::cross_hair_cursor = 0;
-Gdk::Cursor* Editor::selector_cursor = 0;
-Gdk::Cursor* Editor::trimmer_cursor = 0;
-Gdk::Cursor* Editor::left_side_trim_cursor = 0;
-Gdk::Cursor* Editor::right_side_trim_cursor = 0;
-Gdk::Cursor* Editor::fade_in_cursor = 0;
-Gdk::Cursor* Editor::fade_out_cursor = 0;
-Gdk::Cursor* Editor::grabber_cursor = 0;
-Gdk::Cursor* Editor::grabber_note_cursor = 0;
-Gdk::Cursor* Editor::grabber_edit_point_cursor = 0;
-Gdk::Cursor* Editor::zoom_cursor = 0;
-Gdk::Cursor* Editor::time_fx_cursor = 0;
-Gdk::Cursor* Editor::fader_cursor = 0;
-Gdk::Cursor* Editor::speaker_cursor = 0;
-Gdk::Cursor* Editor::midi_pencil_cursor = 0;
-Gdk::Cursor* Editor::midi_select_cursor = 0;
-Gdk::Cursor* Editor::midi_resize_cursor = 0;
-Gdk::Cursor* Editor::midi_erase_cursor = 0;
-Gdk::Cursor* Editor::wait_cursor = 0;
-Gdk::Cursor* Editor::timebar_cursor = 0;
-Gdk::Cursor* Editor::transparent_cursor = 0;
-Gdk::Cursor* Editor::up_down_cursor = 0;
-
 void
 show_me_the_size (Requisition* r, const char* what)
 {
@@ -243,20 +217,20 @@ show_me_the_size (Requisition* r, const char* what)
 static void
 pane_size_watcher (Paned* pane)
 {
-       /* if the handle of a pane vanishes into (at least) the tabs of a notebook,
-          it is no longer accessible. so stop that. this doesn't happen on X11,
-          just the quartz backend.
+       /* if the handle of a pane vanishes into (at least) the tabs of a notebook,
+          it is no longer accessible. so stop that. this doesn't happen on X11,
+          just the quartz backend.
 
-          ugh.
-       */
+          ugh.
+       */
 
-       int max_width_of_lhs = GTK_WIDGET(pane->gobj())->allocation.width - 25;
+       int max_width_of_lhs = GTK_WIDGET(pane->gobj())->allocation.width - 25;
 
-       gint pos = pane->get_position ();
+       gint pos = pane->get_position ();
 
-       if (pos > max_width_of_lhs) {
-               pane->set_position (max_width_of_lhs);
-       }
+       if (pos > max_width_of_lhs) {
+               pane->set_position (max_width_of_lhs);
+       }
 }
 #endif
 
@@ -304,6 +278,8 @@ Editor::Editor ()
        , _pending_locate_request (false)
        , _pending_initial_locate (false)
        , _last_cut_copy_source_track (0)
+
+       , _region_selection_change_updates_region_list (true)
 {
        constructed = false;
 
@@ -322,6 +298,7 @@ Editor::Editor ()
        clicked_crossfadeview = 0;
        clicked_control_point = 0;
        last_update_frame = 0;
+        pre_press_cursor = 0;
        _drags = new DragManager (this);
        current_mixer_strip = 0;
        current_bbt_points = 0;
@@ -385,7 +362,7 @@ Editor::Editor ()
        _dragging_edit_point = false;
        select_new_marker = false;
        rhythm_ferret = 0;
-        layering_order_editor = 0;
+       layering_order_editor = 0;
        _bundle_manager = 0;
        no_save_visual = false;
        resize_idle_id = -1;
@@ -502,7 +479,7 @@ Editor::Editor ()
        controls_layout.signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::edit_controls_button_release));
        controls_layout_size_request_connection = controls_layout.signal_size_request().connect (sigc::mem_fun (*this, &Editor::controls_layout_size_request));
 
-       build_cursors ();
+       _cursors = new MouseCursors;
 
        ArdourCanvas::Canvas* time_pad = manage(new ArdourCanvas::Canvas());
        ArdourCanvas::SimpleLine* pad_line_1 = manage(new ArdourCanvas::SimpleLine(*time_pad->root(),
@@ -632,8 +609,8 @@ Editor::Editor ()
 
        edit_pane.signal_size_allocate().connect (sigc::bind (sigc::mem_fun(*this, &Editor::pane_allocation_handler), static_cast<Paned*> (&edit_pane)));
 #ifdef GTKOSX
-        Glib::PropertyProxy<int> proxy = edit_pane.property_position();
-        proxy.signal_changed().connect (bind (sigc::ptr_fun (pane_size_watcher), static_cast<Paned*> (&edit_pane)));
+       Glib::PropertyProxy<int> proxy = edit_pane.property_position();
+       proxy.signal_changed().connect (bind (sigc::ptr_fun (pane_size_watcher), static_cast<Paned*> (&edit_pane)));
 #endif
        top_hbox.pack_start (toolbar_frame, false, true);
 
@@ -731,10 +708,17 @@ Editor::Editor ()
 
        TimeAxisView::CatchDeletion.connect (*this, invalidator (*this), ui_bind (&Editor::timeaxisview_deleted, this, _1), gui_context());
 
-       _last_normalization_value = 0;
+       _ignore_region_action = false;
+       _last_region_menu_was_main = false;
+       _popup_region_menu_item = 0;
+
+       _show_marker_lines = false;
+       _over_region_trim_target = false;
 
        constructed = true;
        instant_save ();
+
+       setup_fade_images ();
 }
 
 Editor::~Editor()
@@ -782,6 +766,10 @@ Editor::catch_vanishing_regionview (RegionView *rv)
        if (entered_regionview == rv) {
                set_entered_regionview (0);
        }
+
+       if (!_all_region_actions_sensitized) {
+               sensitize_all_region_actions (true);
+       }
 }
 
 void
@@ -798,6 +786,13 @@ Editor::set_entered_regionview (RegionView* rv)
        if ((entered_regionview = rv) != 0) {
                entered_regionview->entered (internal_editing ());
        }
+
+       if (!_all_region_actions_sensitized && _last_region_menu_was_main) {
+               /* This RegionView entry might have changed what region actions
+                  are allowed, so sensitize them all in case a key is pressed.
+               */
+               sensitize_all_region_actions (true);
+       }
 }
 
 void
@@ -1075,9 +1070,6 @@ Editor::set_session (Session *t)
 
        compute_fixed_ruler_scale ();
 
-       /* there are never any selected regions at startup */
-       sensitize_the_right_region_actions (false);
-
        XMLNode* node = ARDOUR_UI::instance()->editor_settings();
        set_state (*node, Stateful::loading_state_version);
 
@@ -1093,12 +1085,11 @@ Editor::set_session (Session *t)
           but use Gtkmm2ext::UI::instance()->call_slot();
        */
 
-        _session->StepEditStatusChange.connect (_session_connections, invalidator (*this), ui_bind(&Editor::step_edit_status_change, this, _1), gui_context());
+       _session->StepEditStatusChange.connect (_session_connections, invalidator (*this), ui_bind(&Editor::step_edit_status_change, this, _1), gui_context());
        _session->TransportStateChange.connect (_session_connections, invalidator (*this), boost::bind (&Editor::map_transport_state, this), gui_context());
        _session->PositionChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::map_position_change, this, _1), gui_context());
        _session->RouteAdded.connect (_session_connections, invalidator (*this), ui_bind (&Editor::handle_new_route, this, _1), gui_context());
        _session->DirtyChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::update_title, this), gui_context());
-       _session->TimecodeOffsetChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::update_just_timecode, this), gui_context());
        _session->tempo_map().PropertyChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::tempo_map_changed, this, _1), gui_context());
        _session->Located.connect (_session_connections, invalidator (*this), boost::bind (&Editor::located, this), gui_context());
        _session->config.ParameterChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::parameter_changed, this, _1), gui_context());
@@ -1114,7 +1105,7 @@ Editor::set_session (Session *t)
                bbt.bars = 0;
                bbt.beats = 0;
                bbt.ticks = 120;
-               nframes_t pos = _session->tempo_map().bbt_duration_at (0, bbt, 1);
+               framepos_t pos = _session->tempo_map().bbt_duration_at (0, bbt, 1);
                nudge_clock.set_mode(AudioClock::BBT);
                nudge_clock.set (pos, true, 0, AudioClock::BBT);
 
@@ -1183,103 +1174,26 @@ Editor::set_session (Session *t)
        /* register for undo history */
        _session->register_with_memento_command_factory(_id, this);
 
+       ActionManager::ui_manager->signal_pre_activate().connect (sigc::mem_fun (*this, &Editor::action_pre_activated));
+
        start_updating_meters ();
 }
 
 void
-Editor::build_cursors ()
+Editor::action_pre_activated (Glib::RefPtr<Action> const & a)
 {
-       using namespace Gdk;
-
-       Gdk::Color mbg ("#000000" ); /* Black */
-       Gdk::Color mfg ("#0000ff" ); /* Blue. */
-
-       {
-               RefPtr<Bitmap> source, mask;
-               source = Bitmap::create (mag_bits, mag_width, mag_height);
-               mask = Bitmap::create (magmask_bits, mag_width, mag_height);
-               zoom_cursor = new Gdk::Cursor (source, mask, mfg, mbg, mag_x_hot, mag_y_hot);
-       }
-
-       Gdk::Color fbg ("#ffffff" );
-       Gdk::Color ffg  ("#000000" );
-
-       {
-               RefPtr<Bitmap> source, mask;
-
-               source = Bitmap::create (fader_cursor_bits, fader_cursor_width, fader_cursor_height);
-               mask = Bitmap::create (fader_cursor_mask_bits, fader_cursor_width, fader_cursor_height);
-               fader_cursor = new Gdk::Cursor (source, mask, ffg, fbg, fader_cursor_x_hot, fader_cursor_y_hot);
-       }
-
-       {
-               RefPtr<Bitmap> source, mask;
-               source = Bitmap::create (speaker_cursor_bits, speaker_cursor_width, speaker_cursor_height);
-               mask = Bitmap::create (speaker_cursor_mask_bits, speaker_cursor_width, speaker_cursor_height);
-               speaker_cursor = new Gdk::Cursor (source, mask, ffg, fbg, speaker_cursor_x_hot, speaker_cursor_y_hot);
-       }
-
-       {
-               RefPtr<Bitmap> bits;
-               char pix[4] = { 0, 0, 0, 0 };
-               bits = Bitmap::create (pix, 2, 2);
-               Gdk::Color c;
-               transparent_cursor = new Gdk::Cursor (bits, bits, c, c, 0, 0);
-       }
-
-       {
-               RefPtr<Bitmap> bits;
-               char pix[4] = { 0, 0, 0, 0 };
-               bits = Bitmap::create (pix, 2, 2);
-               Gdk::Color c;
-               transparent_cursor = new Gdk::Cursor (bits, bits, c, c, 0, 0);
-       }
-
-
-       grabber_cursor = new Gdk::Cursor (HAND2);
-
-       {
-               Glib::RefPtr<Gdk::Pixbuf> grabber_note_pixbuf (::get_icon ("grabber_note"));
-               grabber_note_cursor = new Gdk::Cursor (Gdk::Display::get_default(), grabber_note_pixbuf, 5, 10);
-       }
-
-       {
-               Glib::RefPtr<Gdk::Pixbuf> grabber_edit_point_pixbuf (::get_icon ("grabber_edit_point"));
-               grabber_edit_point_cursor = new Gdk::Cursor (Gdk::Display::get_default(), grabber_edit_point_pixbuf, 5, 17);
-       }
-
-       cross_hair_cursor = new Gdk::Cursor (CROSSHAIR);
-       trimmer_cursor =  new Gdk::Cursor (SB_H_DOUBLE_ARROW);
-
-       {
-               Glib::RefPtr<Gdk::Pixbuf> apixbuf (::get_icon ("trim_left_cursor"));
-               left_side_trim_cursor = new Gdk::Cursor (Gdk::Display::get_default(), apixbuf, 5, 11);
-       }
+       if (a->get_name() == "RegionMenu") {
+               /* When the main menu's region menu is opened, we setup the actions so that they look right
+                  in the menu.  I can't find a way of getting a signal when this menu is subsequently closed,
+                  so we resensitize all region actions when the entered regionview or the region selection
+                  changes.  HOWEVER we can't always resensitize on entered_regionview change because that
+                  happens after the region context menu is opened.  So we set a flag here, too.
 
-       {
-               Glib::RefPtr<Gdk::Pixbuf> apixbuf (::get_icon ("trim_right_cursor"));
-               right_side_trim_cursor = new Gdk::Cursor (Gdk::Display::get_default(), apixbuf, 23, 11);
-       }
-
-       {
-               Glib::RefPtr<Gdk::Pixbuf> apixbuf (::get_icon ("fade_in_cursor"));
-               fade_in_cursor = new Gdk::Cursor (Gdk::Display::get_default(), apixbuf, 0, 40);
-       }
-
-       {
-               Glib::RefPtr<Gdk::Pixbuf> apixbuf (::get_icon ("fade_out_cursor"));
-               fade_out_cursor = new Gdk::Cursor (Gdk::Display::get_default(), apixbuf, 27, 40);
+                  What a carry on :(
+               */
+               sensitize_the_right_region_actions ();
+               _last_region_menu_was_main = true;
        }
-
-       selector_cursor = new Gdk::Cursor (XTERM);
-       time_fx_cursor = new Gdk::Cursor (SIZING);
-       wait_cursor = new Gdk::Cursor  (WATCH);
-       timebar_cursor = new Gdk::Cursor(LEFT_PTR);
-       midi_pencil_cursor = new Gdk::Cursor (PENCIL);
-       midi_select_cursor = new Gdk::Cursor (CENTER_PTR);
-       midi_resize_cursor = new Gdk::Cursor (SIZING);
-       midi_erase_cursor = new Gdk::Cursor (DRAPED_BOX);
-       up_down_cursor = new Gdk::Cursor (Gdk::SB_V_DOUBLE_ARROW);
 }
 
 /** Pop up a context menu for when the user clicks on a fade in or fade out */
@@ -1310,14 +1224,57 @@ Editor::popup_fade_context_menu (int button, int32_t time, ArdourCanvas::Item* i
                items.push_back (SeparatorElem());
 
                if (Profile->get_sae()) {
-                       items.push_back (MenuElem (_("Linear"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::Linear)));
-                       items.push_back (MenuElem (_("Slowest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::Fast)));
+                       
+                       items.push_back (MenuElem (_("Linear"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeLinear)));
+                       items.push_back (MenuElem (_("Slowest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeFast)));
+                       
                } else {
-                       items.push_back (MenuElem (_("Linear"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::Linear)));
-                       items.push_back (MenuElem (_("Slowest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::Fast)));
-                       items.push_back (MenuElem (_("Slow"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::LogB)));
-                       items.push_back (MenuElem (_("Fast"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::LogA)));
-                       items.push_back (MenuElem (_("Fastest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), AudioRegion::Slow)));
+
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Linear"),
+                                       *_fade_in_images[FadeLinear],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeLinear)
+                                       )
+                               );
+
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Slowest"),
+                                       *_fade_in_images[FadeFast],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeFast)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+                       
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Slow"),
+                                       *_fade_in_images[FadeLogB],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeLogB)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+                       
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Fast"),
+                                       *_fade_in_images[FadeLogA],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeLogA)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+                       
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Fastest"),
+                                       *_fade_in_images[FadeSlow],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_in_shape), FadeSlow)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
                }
 
                break;
@@ -1333,14 +1290,55 @@ Editor::popup_fade_context_menu (int button, int32_t time, ArdourCanvas::Item* i
                items.push_back (SeparatorElem());
 
                if (Profile->get_sae()) {
-                       items.push_back (MenuElem (_("Linear"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::Linear)));
-                       items.push_back (MenuElem (_("Slowest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::Slow)));
+                       items.push_back (MenuElem (_("Linear"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeLinear)));
+                       items.push_back (MenuElem (_("Slowest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeSlow)));
                } else {
-                       items.push_back (MenuElem (_("Linear"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::Linear)));
-                       items.push_back (MenuElem (_("Slowest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::Slow)));
-                       items.push_back (MenuElem (_("Slow"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::LogA)));
-                       items.push_back (MenuElem (_("Fast"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::LogB)));
-                       items.push_back (MenuElem (_("Fastest"), sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), AudioRegion::Fast)));
+
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Linear"),
+                                       *_fade_out_images[FadeLinear],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeLinear)
+                                       )
+                               );
+
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Slowest"),
+                                       *_fade_out_images[FadeFast],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeSlow)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+                       
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Slow"),
+                                       *_fade_out_images[FadeLogB],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeLogA)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+                       
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Fast"),
+                                       *_fade_out_images[FadeLogA],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeLogB)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
+                       
+                       items.push_back (
+                               ImageMenuElem (
+                                       _("Fastest"),
+                                       *_fade_out_images[FadeSlow],
+                                       sigc::bind (sigc::mem_fun (*this, &Editor::set_fade_out_shape), FadeFast)
+                                       ));
+                       
+                       dynamic_cast<ImageMenuItem*>(&items.back())->set_always_show_image ();
                }
 
                break;
@@ -1356,10 +1354,10 @@ Editor::popup_fade_context_menu (int button, int32_t time, ArdourCanvas::Item* i
 }
 
 void
-Editor::popup_track_context_menu (int button, int32_t time, ItemType item_type, bool with_selection, framepos_t frame)
+Editor::popup_track_context_menu (int button, int32_t time, ItemType item_type, bool with_selection)
 {
        using namespace Menu_Helpers;
-       Menu* (Editor::*build_menu_function)(framepos_t);
+       Menu* (Editor::*build_menu_function)();
        Menu *menu;
 
        switch (item_type) {
@@ -1400,7 +1398,7 @@ Editor::popup_track_context_menu (int button, int32_t time, ItemType item_type,
                return;
        }
 
-       menu = (this->*build_menu_function)(frame);
+       menu = (this->*build_menu_function)();
        menu->set_name ("ArdourContextMenu");
 
        /* now handle specific situations */
@@ -1409,8 +1407,8 @@ Editor::popup_track_context_menu (int button, int32_t time, ItemType item_type,
        case RegionItem:
        case RegionViewName:
        case RegionViewNameHighlight:
-        case LeftFrameHandle:
-        case RightFrameHandle:
+       case LeftFrameHandle:
+       case RightFrameHandle:
                if (!with_selection) {
                        if (region_edit_menu_split_item) {
                                if (clicked_regionview && clicked_regionview->region()->covers (get_preferred_edit_position())) {
@@ -1472,11 +1470,18 @@ Editor::popup_track_context_menu (int button, int32_t time, ItemType item_type,
                clicked_routeview->build_underlay_menu(menu);
        }
 
+       /* When the region menu is opened, we setup the actions so that they look right
+          in the menu.
+       */
+       sensitize_the_right_region_actions ();
+       _last_region_menu_was_main = false;
+
+       menu->signal_hide().connect (sigc::bind (sigc::mem_fun (*this, &Editor::sensitize_all_region_actions), true));
        menu->popup (button, time);
 }
 
 Menu*
-Editor::build_track_context_menu (framepos_t)
+Editor::build_track_context_menu ()
 {
        using namespace Menu_Helpers;
 
@@ -1488,7 +1493,7 @@ Editor::build_track_context_menu (framepos_t)
 }
 
 Menu*
-Editor::build_track_bus_context_menu (framepos_t)
+Editor::build_track_bus_context_menu ()
 {
        using namespace Menu_Helpers;
 
@@ -1500,7 +1505,7 @@ Editor::build_track_bus_context_menu (framepos_t)
 }
 
 Menu*
-Editor::build_track_region_context_menu (framepos_t frame)
+Editor::build_track_region_context_menu ()
 {
        using namespace Menu_Helpers;
        MenuList& edit_items  = track_region_context_menu.items();
@@ -1522,26 +1527,9 @@ Editor::build_track_region_context_menu (framepos_t frame)
                   mode and so offering region context is somewhat confusing.
                */
                if ((tr = rtv->track()) && ((pl = tr->playlist())) && !internal_editing()) {
-                        framepos_t framepos = (framepos_t) floor ((double)frame * tr->speed());
-                        uint32_t regions_at = pl->count_regions_at (framepos);
-                        list<boost::shared_ptr<Region> > regions_for_menu;
-
-                       if (selection->regions.size() > 1) {
-                               // there's already a multiple selection: just add a
-                               // single region context menu that will act on all
-                               // selected regions
-
-                               for (RegionSelection::iterator i = selection->regions.begin(); i != selection->regions.end(); ++i) {
-                                       regions_for_menu.push_back ((*i)->region ());
-                               }
-                        } else {
-                                boost::shared_ptr<Region> top_region = pl->top_region_at (framepos);
-                                if (top_region) {
-                                        regions_for_menu.push_back (top_region);
-                                }
-                        }
-
-                        add_region_context_items (rtv->view(), regions_for_menu, edit_items, framepos, regions_at > 1);
+                       framepos_t const framepos = (framepos_t) floor ((double) get_preferred_edit_position() * tr->speed());
+                       uint32_t regions_at = pl->count_regions_at (framepos);
+                       add_region_context_items (edit_items, regions_at > 1);
                }
        }
 
@@ -1551,7 +1539,7 @@ Editor::build_track_region_context_menu (framepos_t frame)
 }
 
 Menu*
-Editor::build_track_crossfade_context_menu (framepos_t frame)
+Editor::build_track_crossfade_context_menu ()
 {
        using namespace Menu_Helpers;
        MenuList& edit_items  = track_crossfade_context_menu.items();
@@ -1568,7 +1556,7 @@ Editor::build_track_crossfade_context_menu (framepos_t frame)
 
                        AudioPlaylist::Crossfades xfades;
 
-                       apl->crossfades_at (frame, xfades);
+                       apl->crossfades_at (get_preferred_edit_position (), xfades);
 
                        bool many = xfades.size() > 1;
 
@@ -1576,26 +1564,9 @@ Editor::build_track_crossfade_context_menu (framepos_t frame)
                                add_crossfade_context_items (atv->audio_view(), (*i), edit_items, many);
                        }
 
-                       framepos_t framepos = (framepos_t) floor ((double)frame * tr->speed());
+                       framepos_t framepos = (framepos_t) floor ((double) get_preferred_edit_position() * tr->speed());
                        uint32_t regions_at = pl->count_regions_at (framepos);
-                        list<boost::shared_ptr<Region> > regions_for_menu;
-
-                       if (selection->regions.size() > 1) {
-                               // there's already a multiple selection: just add a
-                               // single region context menu that will act on all
-                               // selected regions
-
-                               for (RegionSelection::iterator i = selection->regions.begin(); i != selection->regions.end(); ++i) {
-                                       regions_for_menu.push_back ((*i)->region ());
-                               }
-                        } else {
-                                boost::shared_ptr<Region> top_region = pl->top_region_at (framepos);
-                                if (top_region) {
-                                        regions_for_menu.push_back (top_region);
-                                }
-                        }
-                        
-                        add_region_context_items (atv->audio_view(), regions_for_menu, edit_items, framepos, regions_at > 1);
+                       add_region_context_items (edit_items, regions_at > 1);
                }
        }
 
@@ -1605,7 +1576,7 @@ Editor::build_track_crossfade_context_menu (framepos_t frame)
 }
 
 void
-Editor::analyze_region_selection()
+Editor::analyze_region_selection ()
 {
        if (analysis_window == 0) {
                analysis_window = new AnalysisWindow();
@@ -1641,7 +1612,7 @@ Editor::analyze_range_selection()
 }
 
 Menu*
-Editor::build_track_selection_context_menu (framepos_t)
+Editor::build_track_selection_context_menu ()
 {
        using namespace Menu_Helpers;
        MenuList& edit_items  = track_selection_context_menu.items();
@@ -1715,294 +1686,10 @@ Editor::xfade_edit_right_region ()
 }
 
 void
-Editor::add_region_context_items (StreamView* sv, list<boost::shared_ptr<Region> > regions, Menu_Helpers::MenuList& edit_items,
-                                  framepos_t position, bool multiple_regions_at_position)
+Editor::add_region_context_items (Menu_Helpers::MenuList& edit_items, bool multiple_regions_at_position)
 {
        using namespace Menu_Helpers;
-       Gtk::MenuItem* foo_item;
-       Menu     *region_menu = manage (new Menu);
-       MenuList& items       = region_menu->items();
-       region_menu->set_name ("ArdourContextMenu");
-
-       /* Look through the regions that we are handling and make notes about what we have got */
        
-       bool have_audio = false;
-       bool have_midi = false;
-       bool have_locked = false;
-       bool have_unlocked = false;
-       bool have_position_lock_style_audio = false;
-       bool have_position_lock_style_music = false;
-       bool have_muted = false;
-       bool have_unmuted = false;
-       bool have_opaque = false;
-       bool have_non_opaque = false;
-       bool have_not_at_natural_position = false;
-       bool have_envelope_visible = false;
-       bool have_envelope_invisible = false;
-       bool have_envelope_active = false;
-       bool have_envelope_inactive = false;
-       bool have_non_unity_scale_amplitude = false;
-
-       for (list<boost::shared_ptr<Region> >::const_iterator i = regions.begin(); i != regions.end(); ++i) {
-               boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion> (*i);
-               if (ar) {
-                       have_audio = true;
-               }
-               if (boost::dynamic_pointer_cast<MidiRegion> (*i)) {
-                       have_midi = true;
-               }
-
-               if ((*i)->locked()) {
-                       have_locked = true;
-               } else {
-                       have_unlocked = true;
-               }
-
-               if ((*i)->position_lock_style() == MusicTime) {
-                       have_position_lock_style_music = true;
-               } else {
-                       have_position_lock_style_audio = true;
-               }
-
-               if ((*i)->muted()) {
-                       have_muted = true;
-               } else {
-                       have_unmuted = true;
-               }
-
-               if ((*i)->opaque()) {
-                       have_opaque = true;
-               } else {
-                       have_non_opaque = true;
-               }
-
-               if (!(*i)->at_natural_position()) {
-                       have_not_at_natural_position = true;
-               }
-
-               if (ar) {
-                        /* its a bit unfortunate that "envelope visible" is a view-only
-                           property. we have to find the regionview to able to check
-                           its current setting.
-                        */
-
-                       RegionView* rv = sv->find_view (ar);
-                        have_envelope_invisible = true;
-
-                        if (rv) {
-                                AudioRegionView* arv = dynamic_cast<AudioRegionView*> (rv);
-                                if (arv && arv->envelope_visible()) {
-                                        have_envelope_visible = true;
-                                }
-                       }
-
-                       if (ar->envelope_active()) {
-                               have_envelope_active = true;
-                       } else {
-                               have_envelope_inactive = true;
-                       }
-
-                       if (ar->scale_amplitude() != 1) {
-                               have_non_unity_scale_amplitude = true;
-                       }
-               }
-       }
-
-       if (regions.size() == 1) {
-
-               /* when this particular menu pops up, make the relevant region
-                  become selected.
-               */
-
-               region_menu->signal_map_event().connect (
-                       sigc::bind (sigc::mem_fun(*this, &Editor::set_selected_regionview_from_map_event), sv, boost::weak_ptr<Region> (regions.front()))
-                       );
-
-               items.push_back (MenuElem (_("Rename..."), sigc::mem_fun(*this, &Editor::rename_region)));
-               
-               if (have_midi) {
-                       items.push_back (MenuElem (_("List Editor..."), sigc::mem_fun(*this, &Editor::show_midi_list_editor)));
-               }
-               
-               items.push_back (MenuElem (_("Region Properties..."), sigc::mem_fun(*this, &Editor::edit_region)));
-       }
-
-       items.push_back (MenuElem (_("Raise to Top Layer"), sigc::mem_fun(*this, &Editor::raise_region_to_top)));
-       items.push_back (MenuElem (_("Lower to Bottom Layer"), sigc::mem_fun  (*this, &Editor::lower_region_to_bottom)));
-       items.push_back (SeparatorElem());
-       items.push_back (MenuElem (_("Define Sync Point"), sigc::mem_fun(*this, &Editor::set_region_sync_from_edit_point)));
-       if (_edit_point == EditAtMouse) {
-               items.back ().set_sensitive (false);
-       }
-       items.push_back (MenuElem (_("Remove Sync Point"), sigc::mem_fun(*this, &Editor::remove_region_sync)));
-       items.push_back (SeparatorElem());
-
-       items.push_back (MenuElem (_("Audition"), sigc::mem_fun(*this, &Editor::play_selected_region)));
-       items.push_back (MenuElem (_("Export..."), sigc::mem_fun(*this, &Editor::export_region)));
-       items.push_back (MenuElem (_("Bounce"), sigc::mem_fun(*this, &Editor::bounce_region_selection)));
-
-       if (have_audio) {
-               items.push_back (MenuElem (_("Spectral Analysis..."), sigc::mem_fun(*this, &Editor::analyze_region_selection)));
-       }
-
-       items.push_back (SeparatorElem());
-
-       items.push_back (CheckMenuElem (_("Lock")));
-       CheckMenuItem* region_lock_item = static_cast<CheckMenuItem*>(&items.back());
-       if (have_locked && !have_unlocked) {
-               region_lock_item->set_active();
-       } else if (have_locked && have_unlocked) {
-               region_lock_item->set_inconsistent ();
-       }
-       region_lock_item->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_region_lock));
-
-       items.push_back (CheckMenuElem (_("Glue to Bars and Beats")));
-       CheckMenuItem* bbt_glue_item = static_cast<CheckMenuItem*>(&items.back());
-
-       if (have_position_lock_style_music && !have_position_lock_style_audio) {
-               bbt_glue_item->set_active ();
-       } else if (have_position_lock_style_music && have_position_lock_style_audio) {
-               bbt_glue_item->set_inconsistent ();
-       }
-
-       bbt_glue_item->signal_activate().connect (sigc::mem_fun (*this, &Editor::toggle_region_lock_style));
-
-       items.push_back (CheckMenuElem (_("Mute")));
-       CheckMenuItem* region_mute_item = static_cast<CheckMenuItem*>(&items.back());
-
-       if (have_muted && !have_unmuted) {
-               region_mute_item->set_active();
-       } else if (have_muted && have_unmuted) {
-               region_mute_item->set_inconsistent ();
-       }
-        
-       region_mute_item->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_region_mute));
-       
-        items.push_back (MenuElem (_("Transpose..."), mem_fun(*this, &Editor::pitch_shift_regions)));
-
-       if (!Profile->get_sae()) {
-               items.push_back (CheckMenuElem (_("Opaque")));
-               CheckMenuItem* region_opaque_item = static_cast<CheckMenuItem*>(&items.back());
-               if (have_opaque && !have_non_opaque) {
-                       region_opaque_item->set_active();
-               } else if (have_opaque && have_non_opaque) {
-                       region_opaque_item->set_inconsistent ();
-               }
-               region_opaque_item->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_region_opaque));
-       }
-
-       items.push_back (CheckMenuElem (_("Original Position"), sigc::mem_fun(*this, &Editor::naturalize)));
-       if (!have_not_at_natural_position) {
-               items.back().set_sensitive (false);
-       }
-
-       items.push_back (SeparatorElem());
-
-       if (have_audio) {
-
-               if (!Profile->get_sae()) {
-                       items.push_back (MenuElem (_("Reset Envelope"), sigc::mem_fun(*this, &Editor::reset_region_gain_envelopes)));
-
-                       items.push_back (CheckMenuElem (_("Envelope Visible")));
-                       CheckMenuItem* region_envelope_visible_item = static_cast<CheckMenuItem*> (&items.back());
-                       if (have_envelope_visible && !have_envelope_invisible) {
-                               region_envelope_visible_item->set_active ();
-                       } else if (have_envelope_visible && have_envelope_invisible) {
-                               region_envelope_visible_item->set_inconsistent ();
-                       }
-                       region_envelope_visible_item->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_gain_envelope_visibility));
-
-                       items.push_back (CheckMenuElem (_("Envelope Active")));
-                       CheckMenuItem* region_envelope_active_item = static_cast<CheckMenuItem*> (&items.back());
-
-                       if (have_envelope_active && !have_envelope_inactive) {
-                               region_envelope_active_item->set_active ();
-                       } else if (have_envelope_active && have_envelope_inactive) {
-                               region_envelope_active_item->set_inconsistent ();
-                       }
-
-                       region_envelope_active_item->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_gain_envelope_active));
-                       items.push_back (SeparatorElem());
-               }
-
-               items.push_back (MenuElem (_("Normalize..."), sigc::mem_fun(*this, &Editor::normalize_region)));
-               if (have_non_unity_scale_amplitude) {
-                       items.push_back (MenuElem (_("Reset Gain"), sigc::mem_fun(*this, &Editor::reset_region_scale_amplitude)));
-               }
-
-       } else if (have_midi) {
-               items.push_back (MenuElem (_("Quantize"), sigc::mem_fun(*this, &Editor::quantize_region)));
-               items.push_back (MenuElem (_("Fork"), sigc::mem_fun(*this, &Editor::fork_region)));
-               items.push_back (SeparatorElem());
-       }
-
-       items.push_back (MenuElem (_("Strip Silence..."), sigc::mem_fun (*this, &Editor::strip_region_silence)));
-       items.push_back (MenuElem (_("Reverse"), sigc::mem_fun(*this, &Editor::reverse_region)));
-       items.push_back (SeparatorElem());
-
-       /* range related stuff */
-
-       items.push_back (MenuElem (_("Add Single Range"), sigc::mem_fun (*this, &Editor::add_location_from_audio_region)));
-       items.push_back (MenuElem (_("Add Range Markers"), sigc::mem_fun (*this, &Editor::add_locations_from_audio_region)));
-       if (selection->regions.size() < 2) {
-               items.back().set_sensitive (false);
-       }
-
-       items.push_back (MenuElem (_("Set Range Selection"), sigc::mem_fun (*this, &Editor::set_selection_from_region)));
-       items.push_back (SeparatorElem());
-
-       /* Nudge region */
-
-       Menu *nudge_menu = manage (new Menu());
-       MenuList& nudge_items = nudge_menu->items();
-       nudge_menu->set_name ("ArdourContextMenu");
-
-       nudge_items.push_back (MenuElem (_("Nudge Forward"), (sigc::bind (sigc::mem_fun(*this, &Editor::nudge_forward), false, false))));
-       nudge_items.push_back (MenuElem (_("Nudge Backward"), (sigc::bind (sigc::mem_fun(*this, &Editor::nudge_backward), false, false))));
-       nudge_items.push_back (MenuElem (_("Nudge Forward by Capture Offset"), (sigc::mem_fun(*this, &Editor::nudge_forward_capture_offset))));
-       nudge_items.push_back (MenuElem (_("Nudge Backward by Capture Offset"), (sigc::mem_fun(*this, &Editor::nudge_backward_capture_offset))));
-
-       items.push_back (MenuElem (_("Nudge"), *nudge_menu));
-       items.push_back (SeparatorElem());
-
-       Menu *trim_menu = manage (new Menu);
-       MenuList& trim_items = trim_menu->items();
-       trim_menu->set_name ("ArdourContextMenu");
-
-       trim_items.push_back (MenuElem (_("Start to Edit Point"), sigc::mem_fun(*this, &Editor::trim_region_from_edit_point)));
-       foo_item = &trim_items.back();
-       if (_edit_point == EditAtMouse) {
-               foo_item->set_sensitive (false);
-       }
-       trim_items.push_back (MenuElem (_("Edit Point to End"), sigc::mem_fun(*this, &Editor::trim_region_to_edit_point)));
-       foo_item = &trim_items.back();
-       if (_edit_point == EditAtMouse) {
-               foo_item->set_sensitive (false);
-       }
-       trim_items.push_back (MenuElem (_("Trim to Loop"), sigc::mem_fun(*this, &Editor::trim_region_to_loop)));
-       trim_items.push_back (MenuElem (_("Trim to Punch"), sigc::mem_fun(*this, &Editor::trim_region_to_punch)));
-
-       items.push_back (MenuElem (_("Trim"), *trim_menu));
-       items.push_back (SeparatorElem());
-
-       items.push_back (MenuElem (_("Split"), (sigc::mem_fun(*this, &Editor::split))));
-       region_edit_menu_split_item = &items.back();
-
-       if (_edit_point == EditAtMouse) {
-               region_edit_menu_split_item->set_sensitive (false);
-       }
-
-       if (have_audio) {
-               items.push_back (MenuElem (_("Make Mono Regions"), (sigc::mem_fun(*this, &Editor::split_multichannel_region))));
-               region_edit_menu_split_multichannel_item = &items.back();
-       }
-
-       items.push_back (MenuElem (_("Duplicate"), (sigc::bind (sigc::mem_fun(*this, &Editor::duplicate_dialog), false))));
-       items.push_back (MenuElem (_("Multi-Duplicate..."), (sigc::bind (sigc::mem_fun(*this, &Editor::duplicate_dialog), true))));
-       items.push_back (MenuElem (_("Fill Track"), (sigc::mem_fun(*this, &Editor::region_fill_track))));
-       items.push_back (SeparatorElem());
-       items.push_back (MenuElem (_("Remove"), sigc::mem_fun(*this, &Editor::remove_selected_regions)));
-
        /* OK, stick the region submenu at the top of the list, and then add
           the standard items.
        */
@@ -2011,17 +1698,27 @@ Editor::add_region_context_items (StreamView* sv, list<boost::shared_ptr<Region>
           meaning for menu titles.
        */
 
+       RegionSelection rs = get_regions_from_selection_and_entered ();
+       
        string::size_type pos = 0;
-       string menu_item_name = (regions.size() == 1) ? regions.front()->name() : _("Selected Regions");
+       string menu_item_name = (rs.size() == 1) ? rs.front()->region()->name() : _("Selected Regions");
 
        while ((pos = menu_item_name.find ("_", pos)) != string::npos) {
                menu_item_name.replace (pos, 1, "__");
                pos += 2;
        }
 
-       edit_items.push_back (MenuElem (menu_item_name, *region_menu));
+       if (_popup_region_menu_item == 0) {
+               _popup_region_menu_item = new MenuItem (menu_item_name);
+               _popup_region_menu_item->set_submenu (*dynamic_cast<Menu*> (ActionManager::get_widget (X_("/PopupRegionMenu"))));
+               _popup_region_menu_item->show ();
+       } else {
+               _popup_region_menu_item->set_label (menu_item_name);
+       }
+
+       edit_items.push_back (*_popup_region_menu_item);
        if (multiple_regions_at_position && (layering_order_editor == 0 || !layering_order_editor->is_visible ())) {
-               edit_items.push_back (MenuElem (_("Choose Top Region..."), (bind (mem_fun(*this, &Editor::change_region_layering_order), position))));
+               edit_items.push_back (*manage (_region_actions->get_action ("choose-top-region")->create_menu_item ()));
        }
        edit_items.push_back (SeparatorElem());
 }
@@ -2047,7 +1744,7 @@ Editor::add_selection_context_items (Menu_Helpers::MenuList& edit_items)
        }
 
        edit_items.push_back (SeparatorElem());
-       edit_items.push_back (MenuElem (_("Convert to region in-place"), mem_fun(*this, &Editor::separate_region_from_selection)));
+       edit_items.push_back (MenuElem (_("Convert to Region In-Place"), mem_fun(*this, &Editor::separate_region_from_selection)));
        edit_items.push_back (MenuElem (_("Convert to Region in Region List"), sigc::mem_fun(*this, &Editor::new_region_from_selection)));
 
        edit_items.push_back (SeparatorElem());
@@ -2089,7 +1786,7 @@ Editor::add_dstream_context_items (Menu_Helpers::MenuList& edit_items)
        play_items.push_back (MenuElem (_("Play From Start"), sigc::mem_fun(*this, &Editor::play_from_start)));
        play_items.push_back (MenuElem (_("Play Region"), sigc::mem_fun(*this, &Editor::play_selected_region)));
        play_items.push_back (SeparatorElem());
-       play_items.push_back (MenuElem (_("Loop Region"), sigc::mem_fun(*this, &Editor::loop_selected_region)));
+       play_items.push_back (MenuElem (_("Loop Region"), sigc::bind (sigc::mem_fun (*this, &Editor::set_loop_from_region), true)));
 
        edit_items.push_back (MenuElem (_("Play"), *play_menu));
 
@@ -2129,8 +1826,8 @@ Editor::add_dstream_context_items (Menu_Helpers::MenuList& edit_items)
 
        cutnpaste_items.push_back (SeparatorElem());
 
-       cutnpaste_items.push_back (MenuElem (_("Align"), sigc::bind (sigc::mem_fun(*this, &Editor::align), ARDOUR::SyncPoint)));
-       cutnpaste_items.push_back (MenuElem (_("Align Relative"), sigc::bind (sigc::mem_fun(*this, &Editor::align_relative), ARDOUR::SyncPoint)));
+       cutnpaste_items.push_back (MenuElem (_("Align"), sigc::bind (sigc::mem_fun (*this, &Editor::align_regions), ARDOUR::SyncPoint)));
+       cutnpaste_items.push_back (MenuElem (_("Align Relative"), sigc::bind (sigc::mem_fun (*this, &Editor::align_regions_relative), ARDOUR::SyncPoint)));
 
        edit_items.push_back (MenuElem (_("Edit"), *cutnpaste_menu));
 
@@ -2408,7 +2105,7 @@ Editor::set_state (const XMLNode& node, int /*version*/)
 
        if (_session && (prop = node.property ("playhead"))) {
                framepos_t pos;
-                sscanf (prop->value().c_str(), "%" PRIi64, &pos);
+               sscanf (prop->value().c_str(), "%" PRIi64, &pos);
                playhead_cursor->set_position (pos);
        } else {
                playhead_cursor->set_position (0);
@@ -2496,17 +2193,17 @@ Editor::set_state (const XMLNode& node, int /*version*/)
                }
        }
 
-        if ((prop = node.property ("stationary-playhead"))) {
-                bool yn = (prop->value() == "yes");
-                set_stationary_playhead (yn);
-                RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
-                if (act) {
-                        RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
-                        if (tact->get_active() != yn) {
-                                tact->set_active (yn);
-                        }
-                }
-        }
+       if ((prop = node.property ("stationary-playhead"))) {
+               bool yn = (prop->value() == "yes");
+               set_stationary_playhead (yn);
+               RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
+               if (act) {
+                       RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
+                       if (tact->get_active() != yn) {
+                               tact->set_active (yn);
+                       }
+               }
+       }
         
        if ((prop = node.property ("region-list-sort-type"))) {
                RegionListSortType st;
@@ -2522,41 +2219,49 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        if ((prop = node.property ("show-editor-mixer"))) {
 
                Glib::RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("show-editor-mixer"));
-               if (act) {
-
-                       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
-                       bool yn = string_is_affirmative (prop->value());
+               assert (act);
 
-                       /* do it twice to force the change */
-
-                       tact->set_active (!yn);
-                       tact->set_active (yn);
-               }
+               Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
+               bool yn = string_is_affirmative (prop->value());
+               
+               /* do it twice to force the change */
+               
+               tact->set_active (!yn);
+               tact->set_active (yn);
        }
 
        if ((prop = node.property ("show-editor-list"))) {
 
                Glib::RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("show-editor-list"));
-               assert(act);
-               if (act) {
-
-                       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
-                       bool yn = string_is_affirmative (prop->value());
+               assert (act);
 
-                       /* do it twice to force the change */
-
-                       tact->set_active (!yn);
-                       tact->set_active (yn);
-               }
+               Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
+               bool yn = string_is_affirmative (prop->value());
+               
+               /* do it twice to force the change */
+               
+               tact->set_active (!yn);
+               tact->set_active (yn);
        }
 
        if ((prop = node.property (X_("editor-list-page")))) {
                the_notebook.set_current_page (atoi (prop->value ()));
        }
 
+       if ((prop = node.property (X_("show-marker-lines")))) {
+               Glib::RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("show-marker-lines"));
+               assert (act);
+               Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
+               bool yn = string_is_affirmative (prop->value ());
+
+               tact->set_active (!yn);
+               tact->set_active (yn);
+       }
+
        XMLNodeList children = node.children ();
        for (XMLNodeList::const_iterator i = children.begin(); i != children.end(); ++i) {
                selection->set_state (**i, Stateful::current_state_version);
+               _regions->set_state (**i);
        }
 
        return 0;
@@ -2623,7 +2328,7 @@ Editor::get_state ()
 
        node->add_property ("show-measures", _show_measures ? "yes" : "no");
        node->add_property ("follow-playhead", _follow_playhead ? "yes" : "no");
-        node->add_property ("stationary-playhead", _stationary_playhead ? "yes" : "no");
+       node->add_property ("stationary-playhead", _stationary_playhead ? "yes" : "no");
        node->add_property ("xfades-visible", _xfade_visibility ? "yes" : "no");
        node->add_property ("region-list-sort-type", enum_2_string (_regions->sort_type ()));
        node->add_property ("mouse-mode", enum2str(mouse_mode));
@@ -2645,7 +2350,10 @@ Editor::get_state ()
        snprintf (buf, sizeof (buf), "%d", the_notebook.get_current_page ());
        node->add_property (X_("editor-list-page"), buf);
 
+       node->add_property (X_("show-marker-lines"), _show_marker_lines ? "yes" : "no");
+
        node->add_child_nocopy (selection->get_state ());
+       node->add_child_nocopy (_regions->get_state ());
        
        return *node;
 }
@@ -2720,11 +2428,10 @@ Editor::timecode_snap_to_internal (framepos_t& start, int32_t direction, bool /*
                break;
 
        case SnapToTimecodeSeconds:
-               if (_session->timecode_offset_negative())
-               {
-                       start += _session->timecode_offset ();
+               if (_session->config.get_timecode_offset_negative()) {
+                       start += _session->config.get_timecode_offset ();
                } else {
-                       start -= _session->timecode_offset ();
+                       start -= _session->config.get_timecode_offset ();
                }
                if (((direction == 0) && (start % one_timecode_second > one_timecode_second / 2)) || direction > 0) {
                        start = (framepos_t) ceil ((double) start / one_timecode_second) * one_timecode_second;
@@ -2732,31 +2439,28 @@ Editor::timecode_snap_to_internal (framepos_t& start, int32_t direction, bool /*
                        start = (framepos_t) floor ((double) start / one_timecode_second) * one_timecode_second;
                }
 
-               if (_session->timecode_offset_negative())
-               {
-                       start -= _session->timecode_offset ();
+               if (_session->config.get_timecode_offset_negative()) {
+                       start -= _session->config.get_timecode_offset ();
                } else {
-                       start += _session->timecode_offset ();
+                       start += _session->config.get_timecode_offset ();
                }
                break;
 
        case SnapToTimecodeMinutes:
-               if (_session->timecode_offset_negative())
-               {
-                       start += _session->timecode_offset ();
+               if (_session->config.get_timecode_offset_negative()) {
+                       start += _session->config.get_timecode_offset ();
                } else {
-                       start -= _session->timecode_offset ();
+                       start -= _session->config.get_timecode_offset ();
                }
                if (((direction == 0) && (start % one_timecode_minute > one_timecode_minute / 2)) || direction > 0) {
                        start = (framepos_t) ceil ((double) start / one_timecode_minute) * one_timecode_minute;
                } else {
                        start = (framepos_t) floor ((double) start / one_timecode_minute) * one_timecode_minute;
                }
-               if (_session->timecode_offset_negative())
-               {
-                       start -= _session->timecode_offset ();
+               if (_session->config.get_timecode_offset_negative()) {
+                       start -= _session->config.get_timecode_offset ();
                } else {
-                       start += _session->timecode_offset ();
+                       start += _session->config.get_timecode_offset ();
                }
                break;
        default:
@@ -3002,13 +2706,13 @@ Editor::setup_toolbar ()
        }
 
        _mouse_mode_tearoff->Detach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                                         &_mouse_mode_tearoff->tearoff_window()));
+                                                        &_mouse_mode_tearoff->tearoff_window()));
        _mouse_mode_tearoff->Attach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                                         &_mouse_mode_tearoff->tearoff_window(), 1));
+                                                        &_mouse_mode_tearoff->tearoff_window(), 1));
        _mouse_mode_tearoff->Hidden.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                                         &_mouse_mode_tearoff->tearoff_window()));
+                                                        &_mouse_mode_tearoff->tearoff_window()));
        _mouse_mode_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                                          &_mouse_mode_tearoff->tearoff_window(), 1));
+                                                         &_mouse_mode_tearoff->tearoff_window(), 1));
 
        mouse_move_button.set_mode (false);
        mouse_select_button.set_mode (false);
@@ -3135,13 +2839,13 @@ Editor::setup_toolbar ()
        }
 
        _tools_tearoff->Detach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                                    &_tools_tearoff->tearoff_window()));
+                                                   &_tools_tearoff->tearoff_window()));
        _tools_tearoff->Attach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                                    &_tools_tearoff->tearoff_window(), 0));
+                                                   &_tools_tearoff->tearoff_window(), 0));
        _tools_tearoff->Hidden.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                                    &_tools_tearoff->tearoff_window()));
+                                                   &_tools_tearoff->tearoff_window()));
        _tools_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                                     &_tools_tearoff->tearoff_window(), 0));
+                                                    &_tools_tearoff->tearoff_window(), 0));
 
        toolbar_hbox.set_spacing (10);
        toolbar_hbox.set_border_width (1);
@@ -3174,7 +2878,7 @@ Editor::setup_tooltips ()
        ARDOUR_UI::instance()->set_tip (mouse_audition_button, _("Listen to Specific Regions"));
        ARDOUR_UI::instance()->set_tip (join_object_range_button, _("Select/Move Objects or Ranges"));
        ARDOUR_UI::instance()->set_tip (internal_edit_button, _("Edit Region Contents (e.g. notes)"));
-       ARDOUR_UI::instance()->set_tip (*_group_tabs, _("Groups: context-click for possible operations"));
+       ARDOUR_UI::instance()->set_tip (*_group_tabs, _("Groups: click to (de)activate\nContext-click for other operations"));
        ARDOUR_UI::instance()->set_tip (nudge_forward_button, _("Nudge Region/Selection Forwards"));
        ARDOUR_UI::instance()->set_tip (nudge_backward_button, _("Nudge Region/Selection Backwards"));
        ARDOUR_UI::instance()->set_tip (zoom_in_button, _("Zoom In"));
@@ -3437,14 +3141,10 @@ Editor::duplicate_dialog (bool with_dialog)
                }
        }
 
-       RegionSelection rs;
-       get_regions_for_action (rs);
-
-       if (mouse_mode != MouseRange) {
+       RegionSelection rs = get_regions_from_selection_and_entered ();
 
-               if (rs.empty()) {
-                       return;
-               }
+       if (mouse_mode != MouseRange && rs.empty()) {
+               return;
        }
 
        if (with_dialog) {
@@ -3535,7 +3235,7 @@ Editor::clamp_verbose_cursor_y (double y)
 }
 
 void
-Editor::show_verbose_canvas_cursor_with (const string & txt)
+Editor::show_verbose_canvas_cursor_with (const string & txt, int32_t xoffset, int32_t yoffset)
 {
        verbose_canvas_cursor->property_text() = txt.c_str();
 
@@ -3545,6 +3245,9 @@ Editor::show_verbose_canvas_cursor_with (const string & txt)
        track_canvas->get_pointer (x, y);
        track_canvas->window_to_world (x, y, wx, wy);
 
+       wx += xoffset;
+       wy += yoffset;
+
        /* don't get too close to the edge */
        verbose_canvas_cursor->property_x() = clamp_verbose_cursor_x (wx);
        verbose_canvas_cursor->property_y() = clamp_verbose_cursor_y (wy);
@@ -3940,24 +3643,24 @@ Editor::set_follow_playhead (bool yn)
 void
 Editor::toggle_stationary_playhead ()
 {
-       RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
-       if (act) {
-               RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
-               set_stationary_playhead (tact->get_active());
-       }
+       RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
+       if (act) {
+               RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
+               set_stationary_playhead (tact->get_active());
+       }
 }
 
 void
 Editor::set_stationary_playhead (bool yn)
 {
-       if (_stationary_playhead != yn) {
-               if ((_stationary_playhead = yn) == true) {
-                       /* catch up */
-                       // FIXME need a 3.0 equivalent of this 2.X call
-                       // update_current_screen ();
-               }
-               instant_save ();
-       }
+       if (_stationary_playhead != yn) {
+               if ((_stationary_playhead = yn) == true) {
+                       /* catch up */
+                       // FIXME need a 3.0 equivalent of this 2.X call
+                       // update_current_screen ();
+               }
+               instant_save ();
+       }
 }
 
 void
@@ -4261,6 +3964,7 @@ Editor::maximise_editing_space ()
                _tools_tearoff->set_visible (true);
                _zoom_tearoff->set_visible (true);
        }
+
 }
 
 void
@@ -4545,6 +4249,8 @@ Editor::post_zoom ()
        refresh_location_display();
        _summary->set_overlays_dirty ();
 
+       update_marker_labels ();
+
        instant_save ();
 }
 
@@ -4594,7 +4300,19 @@ Editor::idle_visual_changer ()
        VisualChange::Type p = pending_visual_change.pending;
        pending_visual_change.pending = (VisualChange::Type) 0;
 
-       double last_time_origin = horizontal_position ();
+       double const last_time_origin = horizontal_position ();
+
+       if (p & VisualChange::TimeOrigin) {
+               /* This is a bit of a hack, but set_frames_per_unit
+                  below will (if called) end up with the
+                  CrossfadeViews looking at Editor::leftmost_frame,
+                  and if we're changing origin and zoom in the same
+                  operation it will be the wrong value unless we
+                  update it here.
+               */
+
+               leftmost_frame = pending_visual_change.time_origin;
+       }
 
        if (p & VisualChange::ZoomLevel) {
                set_frames_per_unit (pending_visual_change.frames_per_unit);
@@ -4804,7 +4522,7 @@ Editor::get_regions_after (RegionSelection& rs, framepos_t where, const TrackVie
                        if ((tr = rtv->track()) && ((pl = tr->playlist()))) {
 
                                Playlist::RegionList* regions = pl->regions_touched (
-                                        (framepos_t) floor ( (double)where * tr->speed()), max_framepos);
+                                       (framepos_t) floor ( (double)where * tr->speed()), max_framepos);
 
                                for (Playlist::RegionList::iterator i = regions->begin(); i != regions->end(); ++i) {
 
@@ -4821,47 +4539,74 @@ Editor::get_regions_after (RegionSelection& rs, framepos_t where, const TrackVie
        }
 }
 
-/** Find all regions which are either:
- *      - selected or
- *      - the entered_regionview (if allow_entered == true) or
- *      - under the preferred edit position AND on a selected track, or on a track
- *        which is in the same active edit-enable route group as a selected region (if allow_edit_position == true)
+/** Get regions using the following conditions:
+ *    1.  If the edit point is `mouse':
+ *          if the mouse is over a selected region, or no region, return all selected regions.
+ *          if the mouse is over an unselected region, return just that region.
+ *    2.  For all other edit points:
+ *          return the selected regions AND those that are both under the edit position
+ *          AND on a selected track, or on a track which is in the same active edit-enabled route group
+ *          as a selected region.
+ *
+ *  The rationale here is that the mouse edit point is special in that its position describes
+ *  both a time and a track; the other edit modes only describe a time.
+ *
  *  @param rs Returned region list.
- *  @param allow_entered true to include the entered_regionview in the list.
  */
-void
-Editor::get_regions_for_action (RegionSelection& rs, bool allow_entered, bool allow_edit_position)
-{
-       /* Start with selected regions */
-       rs = selection->regions;
 
-       /* Add the entered_regionview, if requested */
-       if (allow_entered && entered_regionview) {
-               rs.add (entered_regionview);
+RegionSelection
+Editor::get_regions_from_selection_and_edit_point ()
+{
+       if (_edit_point == EditAtMouse) {
+               if (entered_regionview == 0 || selection->regions.contains (entered_regionview)) {
+                       return selection->regions;
+               } else {
+                       RegionSelection rs;
+                       rs.add (entered_regionview);
+                       return rs;
+               }
        }
 
-       if (allow_edit_position) {
+       /* We're using the edit point, but its not EditAtMouse */
 
-               TrackViewList tracks = selection->tracks;
+       /* Start with selected regions */
+       RegionSelection rs = selection->regions;
 
-               /* tracks is currently the set of selected tracks; add any other tracks that
-                * have regions that are in the same edit-activated route group as one of
-                * our regions */
-               for (RegionSelection::iterator i = rs.begin (); i != rs.end(); ++i) {
+       TrackViewList tracks = selection->tracks;
 
-                       RouteGroup* g = (*i)->get_time_axis_view().route_group ();
-                       if (g && g->is_active() && g->is_edit()) {
-                               tracks.add (axis_views_from_routes (g->route_list()));
-                       }
-                       
+       /* Tracks is currently the set of selected tracks; add any other tracks that
+          have regions that are in the same edit-activated route group as one of
+          our regions.
+        */
+       for (RegionSelection::iterator i = rs.begin (); i != rs.end(); ++i) {
+               
+               RouteGroup* g = (*i)->get_time_axis_view().route_group ();
+               if (g && g->is_active() && g->is_edit()) {
+                       tracks.add (axis_views_from_routes (g->route_list()));
                }
+               
+       }
+       
+       if (!tracks.empty()) {
+               /* now find regions that are at the edit position on those tracks */
+               framepos_t const where = get_preferred_edit_position ();
+               get_regions_at (rs, where, tracks);
+       }
 
-               if (!tracks.empty()) {
-                       /* now find regions that are at the edit position on those tracks */
-                       framepos_t const where = get_preferred_edit_position ();
-                       get_regions_at (rs, where, tracks);
-               }
+       return rs;
+}
+
+
+RegionSelection
+Editor::get_regions_from_selection_and_entered ()
+{
+       RegionSelection rs = selection->regions;
+       
+       if (rs.empty() && entered_regionview) {
+               rs.add (entered_regionview);
        }
+
+       return rs;
 }
 
 void
@@ -4992,7 +4737,7 @@ Editor::idle_resize ()
                }
        }
 
-        _pending_resize_amount = 0;
+       _pending_resize_amount = 0;
        flush_canvas ();
        _group_tabs->set_dirty ();
        resize_idle_id = -1;
@@ -5273,11 +5018,11 @@ Editor::show_region_in_region_list ()
 void
 Editor::step_edit_status_change (bool yn)
 {
-        if (yn) {
-                start_step_editing ();
-        } else {
-                stop_step_editing ();
-        }
+       if (yn) {
+               start_step_editing ();
+       } else {
+               stop_step_editing ();
+       }
 }
 
 void
@@ -5458,33 +5203,33 @@ Editor::super_rapid_screen_update ()
                        playhead_cursor->set_position (frame);
                }
 
-                if (!_stationary_playhead) {
+               if (!_stationary_playhead) {
 
-                        if (!_dragging_playhead && _follow_playhead && _session->requested_return_frame() < 0) {
-                                reset_x_origin_to_follow_playhead ();
-                        }
+                       if (!_dragging_playhead && _follow_playhead && _session->requested_return_frame() < 0) {
+                               reset_x_origin_to_follow_playhead ();
+                       }
 
-                } else {
+               } else {
                        
-                        /* don't do continuous scroll till the new position is in the rightmost quarter of the
-                           editor canvas
-                        */
+                       /* don't do continuous scroll till the new position is in the rightmost quarter of the
+                          editor canvas
+                       */
 #if 0                        
-                        // FIXME DO SOMETHING THAT WORKS HERE - this is 2.X code                         
-                        double target = ((double)frame - (double)current_page_frames()/2.0) / frames_per_unit;
-                        if (target <= 0.0) {
-                                target = 0.0;
-                        }
-                        if (fabs(target - current) < current_page_frames() / frames_per_unit) {
-                                target = (target * 0.15) + (current * 0.85);
-                        } else {
-                                /* relax */
-                        }
+                       // FIXME DO SOMETHING THAT WORKS HERE - this is 2.X code                         
+                       double target = ((double)frame - (double)current_page_frames()/2.0) / frames_per_unit;
+                       if (target <= 0.0) {
+                               target = 0.0;
+                       }
+                       if (fabs(target - current) < current_page_frames() / frames_per_unit) {
+                               target = (target * 0.15) + (current * 0.85);
+                       } else {
+                               /* relax */
+                       }
                         
-                        current = target;
-                        set_horizontal_position (current);
+                       current = target;
+                       set_horizontal_position (current);
 #endif
-                }
+               }
                
        }
 }
@@ -5574,39 +5319,69 @@ Editor::show_editor_list (bool yn)
 }
 
 void
-Editor::change_region_layering_order (framepos_t position)
+Editor::change_region_layering_order ()
 {
-        if (!clicked_routeview) {
-                if (layering_order_editor) {
-                        layering_order_editor->hide ();
-                }
+       framepos_t const position = get_preferred_edit_position ();
+       
+       if (!clicked_routeview) {
+               if (layering_order_editor) {
+                       layering_order_editor->hide ();
+               }
                return;
        }
 
-        boost::shared_ptr<Track> track = boost::dynamic_pointer_cast<Track> (clicked_routeview->route());
+       boost::shared_ptr<Track> track = boost::dynamic_pointer_cast<Track> (clicked_routeview->route());
 
-        if (!track) {
-                return;
-        }
+       if (!track) {
+               return;
+       }
 
        boost::shared_ptr<Playlist> pl = track->playlist();
 
        if (!pl) {
-                return;
-        }
+               return;
+       }
                 
-        if (layering_order_editor == 0) {
-                layering_order_editor = new RegionLayeringOrderEditor(*this);
-        }
+       if (layering_order_editor == 0) {
+               layering_order_editor = new RegionLayeringOrderEditor(*this);
+       }
 
-        layering_order_editor->set_context (clicked_routeview->name(), _session, pl, position);
-        layering_order_editor->maybe_present ();
+       layering_order_editor->set_context (clicked_routeview->name(), _session, pl, position);
+       layering_order_editor->maybe_present ();
 }
 
 void
-Editor::update_region_layering_order_editor (framepos_t frame)
+Editor::update_region_layering_order_editor ()
 {
        if (layering_order_editor && layering_order_editor->is_visible ()) {
-               change_region_layering_order (frame);
+               change_region_layering_order ();
        }
 }
+
+void
+Editor::setup_fade_images ()
+{
+       _fade_in_images[FadeLinear] = new Gtk::Image (get_icon_path (X_("crossfade-in-linear")));
+       _fade_in_images[FadeFast] = new Gtk::Image (get_icon_path (X_("crossfade-in-short-cut")));
+       _fade_in_images[FadeLogB] = new Gtk::Image (get_icon_path (X_("crossfade-in-slow-cut")));
+       _fade_in_images[FadeLogA] = new Gtk::Image (get_icon_path (X_("crossfade-in-fast-cut")));
+       _fade_in_images[FadeSlow] = new Gtk::Image (get_icon_path (X_("crossfade-in-long-cut")));
+
+       _fade_out_images[FadeLinear] = new Gtk::Image (get_icon_path (X_("crossfade-out-linear")));
+       _fade_out_images[FadeFast] = new Gtk::Image (get_icon_path (X_("crossfade-out-short-cut")));
+       _fade_out_images[FadeLogB] = new Gtk::Image (get_icon_path (X_("crossfade-out-slow-cut")));
+       _fade_out_images[FadeLogA] = new Gtk::Image (get_icon_path (X_("crossfade-out-fast-cut")));
+       _fade_out_images[FadeSlow] = new Gtk::Image (get_icon_path (X_("crossfade-out-long-cut")));
+}
+
+
+/** @return Gtk::manage()d menu item for a given action from `editor_actions' */
+Gtk::MenuItem&
+Editor::action_menu_item (std::string const & name)
+{
+       Glib::RefPtr<Action> a = editor_actions->get_action (name);
+       assert (a);
+       
+       return *manage (a->create_menu_item ());
+}
+