son't try to select non-existent notes after editing (and thus crash).

[ardour.git] / gtk2_ardour / editor_markers.cc

diff --git a/gtk2_ardour/editor_markers.cc b/gtk2_ardour/editor_markers.cc
index a1fef51d67207f1eb62d856dd19b823eb32c85dc..6751f6424f70a9799c5a337fcb14db4599119bca 100644 (file)
--- a/gtk2_ardour/editor_markers.cc
+++ b/gtk2_ardour/editor_markers.cc
@@ -40,7 +40,7 @@
 #include "prompter.h"
 #include "editor_drag.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace ARDOUR;
@@ -1391,23 +1391,30 @@ Editor::toggle_marker_lock_style ()
                begin_reversible_command (_("change meter lock style"));
                XMLNode &before = _session->tempo_map().get_state();
                MeterSection* msp = &mm->meter();
-               if (mm->meter().position_lock_style() == AudioTime) {
-                       _session->tempo_map().replace_meter_bbt (*msp, Meter (msp->divisions_per_bar(), msp->note_divisor()), msp->bbt());
-               } else {
-                       _session->tempo_map().replace_meter_frame (*msp, Meter (msp->divisions_per_bar(), msp->note_divisor()), msp->frame());
-               }
+
+               const Meter meter (msp->divisions_per_bar(), msp->note_divisor());
+               const Timecode::BBT_Time bbt (msp->bbt());
+               const PositionLockStyle pls = (msp->position_lock_style() == AudioTime) ? MusicTime : AudioTime;
+
+               _session->tempo_map().replace_meter (*msp, meter, bbt, pls);
+
                XMLNode &after = _session->tempo_map().get_state();
                _session->add_command(new MementoCommand<TempoMap>(_session->tempo_map(), &before, &after));
                commit_reversible_command ();
        } else if (tm) {
+               TempoSection* tsp = &tm->tempo();
+
+               const Tempo tempo (tsp->note_types_per_minute(), tsp->note_type());
+               const double pulse = tsp->pulse();
+               const framepos_t frame = tsp->frame();
+               const TempoSection::Type type = tsp->type();
+               const PositionLockStyle pls = (tsp->position_lock_style() == AudioTime) ? MusicTime : AudioTime;
+
                begin_reversible_command (_("change tempo lock style"));
                XMLNode &before = _session->tempo_map().get_state();
-               TempoSection* tsp = &tm->tempo();
-               if (tsp->position_lock_style() == AudioTime) {
-                       _session->tempo_map().replace_tempo_pulse (*tsp, Tempo (tsp->beats_per_minute(), tsp->note_type()), tsp->pulse(), tsp->type());
-               } else {
-                       _session->tempo_map().replace_tempo_frame (*tsp, Tempo (tsp->beats_per_minute(), tsp->note_type()), tsp->frame(), tsp->type());
-               }
+
+               _session->tempo_map().replace_tempo (*tsp, tempo, pulse, frame, type, pls);
+
                XMLNode &after = _session->tempo_map().get_state();
                _session->add_command(new MementoCommand<TempoMap>(_session->tempo_map(), &before, &after));
                commit_reversible_command ();
@@ -1422,16 +1429,18 @@ Editor::toggle_tempo_type ()
        dynamic_cast_marker_object (marker_menu_item->get_data ("marker"), &mm, &tm);
 
        if (tm) {
+               TempoSection* tsp = &tm->tempo();
+
+               const Tempo tempo (tsp->note_types_per_minute(), tsp->note_type());
+               const double pulse = tsp->pulse();
+               const framepos_t frame = tsp->frame();
+               const TempoSection::Type type = (tsp->type() == TempoSection::Ramp) ? TempoSection::Constant : TempoSection::Ramp;
+               const PositionLockStyle pls = tsp->position_lock_style();
+
                begin_reversible_command (_("change tempo type"));
                XMLNode &before = _session->tempo_map().get_state();
-               TempoSection* tsp = &tm->tempo();
-               if (tsp->position_lock_style() == AudioTime) {
-                       _session->tempo_map().replace_tempo_frame (*tsp, Tempo (tsp->beats_per_minute(), tsp->note_type())
-                                                                  , tsp->frame(), (tsp->type() == TempoSection::Ramp) ? TempoSection::Constant : TempoSection::Ramp);
-               } else {
-                       _session->tempo_map().replace_tempo_pulse (*tsp, Tempo (tsp->beats_per_minute(), tsp->note_type())
-                                                                  , tsp->pulse(), (tsp->type() == TempoSection::Ramp) ? TempoSection::Constant : TempoSection::Ramp);
-               }
+
+               _session->tempo_map().replace_tempo (*tsp, tempo, pulse, frame, type, pls);
 
                XMLNode &after = _session->tempo_map().get_state();
                _session->add_command(new MementoCommand<TempoMap>(_session->tempo_map(), &before, &after));