Fix update of range marker names. Fixes #3533.
[ardour.git] / gtk2_ardour / editor_markers.cc
index 7989b83e2d7f918d7f0400471b56fd92edee415e..7b0f56776cb6cf84a37059c1bf5d8c88f2e2fa25 100644 (file)
 #include "simplerect.h"
 #include "actions.h"
 #include "prompter.h"
+#include "editor_drag.h"
 
 #include "i18n.h"
 
 using namespace std;
-using namespace sigc;
 using namespace ARDOUR;
 using namespace PBD;
 using namespace Gtk;
@@ -60,7 +60,7 @@ Editor::clear_marker_display ()
 void
 Editor::add_new_location (Location *location)
 {
-       ENSURE_GUI_THREAD (bind (mem_fun(*this, &Editor::add_new_location), location));
+       ENSURE_GUI_THREAD (*this, &Editor::add_new_location, location)
 
        LocationMarkers *lam = new LocationMarkers;
        uint32_t color;
@@ -80,41 +80,45 @@ Editor::add_new_location (Location *location)
        if (location->is_mark()) {
 
                if (location->is_cd_marker() && ruler_cd_marker_action->get_active()) {
-                       lam->start = new Marker (*this, *cd_marker_group, color, location->name(), Marker::Mark, location->start());
+                       lam->start = new Marker (*this, *cd_marker_group, *cursor_group, color, location->name(), Marker::Mark, location->start());
                }
                else {
-                       lam->start = new Marker (*this, *marker_group, color, location->name(), Marker::Mark, location->start());
+                       lam->start = new Marker (*this, *marker_group, *cursor_group, color, location->name(), Marker::Mark, location->start());
                }
                lam->end   = 0;
 
        } else if (location->is_auto_loop()) {
                // transport marker
-               lam->start = new Marker (*this, *transport_marker_group, color,
+               lam->start = new Marker (*this, *transport_marker_group, *cursor_group, color,
                                         location->name(), Marker::LoopStart, location->start());
-               lam->end   = new Marker (*this, *transport_marker_group, color,
+               lam->end   = new Marker (*this, *transport_marker_group, *cursor_group, color,
                                         location->name(), Marker::LoopEnd, location->end());
 
        } else if (location->is_auto_punch()) {
                // transport marker
-               lam->start = new Marker (*this, *transport_marker_group, color,
+               lam->start = new Marker (*this, *transport_marker_group, *cursor_group, color,
                                         location->name(), Marker::PunchIn, location->start());
-               lam->end   = new Marker (*this, *transport_marker_group, color,
+               lam->end   = new Marker (*this, *transport_marker_group, *cursor_group, color,
                                         location->name(), Marker::PunchOut, location->end());
 
+       } else if (location->is_session_range()) {
+               // session range
+               lam->start = new Marker (*this, *marker_group, *cursor_group, color, _("start"), Marker::SessionStart, location->start());
+               lam->end = new Marker (*this, *marker_group, *cursor_group, color, _("end"), Marker::SessionEnd, location->end());
+               
        } else {
                // range marker
                if (location->is_cd_marker() && ruler_cd_marker_action->get_active()) {
-                       lam->start = new Marker (*this, *cd_marker_group, color,
-                                                location->name(), Marker::Start, location->start());
-                       lam->end   = new Marker (*this, *cd_marker_group, color,
-                                                location->name(), Marker::End, location->end());
+                       lam->start = new Marker (*this, *cd_marker_group, *cursor_group, color,
+                                                location->name(), Marker::RangeStart, location->start());
+                       lam->end   = new Marker (*this, *cd_marker_group, *cursor_group, color,
+                                                location->name(), Marker::RangeEnd, location->end());
                }
                else {
-
-                       lam->start = new Marker (*this, *range_marker_group, color,
-                                                location->name(), Marker::Start, location->start());
-                       lam->end   = new Marker (*this, *range_marker_group, color,
-                                                location->name(), Marker::End, location->end());
+                       lam->start = new Marker (*this, *range_marker_group, *cursor_group, color,
+                                                location->name(), Marker::RangeStart, location->start());
+                       lam->end   = new Marker (*this, *range_marker_group, *cursor_group, color,
+                                                location->name(), Marker::RangeEnd, location->end());
                }
        }
 
@@ -124,11 +128,11 @@ Editor::add_new_location (Location *location)
                lam->show ();
        }
 
-       location->start_changed.connect (mem_fun(*this, &Editor::location_changed));
-       location->end_changed.connect (mem_fun(*this, &Editor::location_changed));
-       location->changed.connect (mem_fun(*this, &Editor::location_changed));
-       location->name_changed.connect (mem_fun(*this, &Editor::location_changed));
-       location->FlagsChanged.connect (mem_fun(*this, &Editor::location_flags_changed));
+       location->start_changed.connect (*this, invalidator (*this), ui_bind (&Editor::location_changed, this, _1), gui_context());
+       location->end_changed.connect (*this, invalidator (*this), ui_bind (&Editor::location_changed, this, _1), gui_context());
+       location->changed.connect (*this, invalidator (*this), ui_bind (&Editor::location_changed, this, _1), gui_context());
+       location->name_changed.connect (*this, invalidator (*this), ui_bind (&Editor::location_changed, this, _1), gui_context());
+       location->FlagsChanged.connect (*this, invalidator (*this), ui_bind (&Editor::location_flags_changed, this, _1, _2), gui_context());
 
        pair<Location*,LocationMarkers*> newpair;
 
@@ -141,12 +145,15 @@ Editor::add_new_location (Location *location)
                selection->set (lam->start);
                select_new_marker = false;
        }
+
+       lam->canvas_height_set (_canvas_height);
+       lam->set_show_lines (_show_marker_lines);
 }
 
 void
 Editor::location_changed (Location *location)
 {
-       ENSURE_GUI_THREAD (bind (mem_fun(*this, &Editor::location_changed), location));
+       ENSURE_GUI_THREAD (*this, &Editor::location_changed, location)
 
        LocationMarkers *lam = find_location_markers (location);
 
@@ -155,7 +162,7 @@ Editor::location_changed (Location *location)
                return;
        }
 
-       lam->set_name (location->name());
+       lam->set_name (location->name ());
        lam->set_position (location->start(), location->end());
 
        if (location->is_auto_loop()) {
@@ -166,9 +173,9 @@ Editor::location_changed (Location *location)
 }
 
 void
-Editor::location_flags_changed (Location *location, void *src)
+Editor::location_flags_changed (Location *location, void*)
 {
-       ENSURE_GUI_THREAD(bind (mem_fun(*this, &Editor::location_flags_changed), location, src));
+       ENSURE_GUI_THREAD (*this, &Editor::location_flags_changed, location, src)
 
        LocationMarkers *lam = find_location_markers (location);
 
@@ -331,20 +338,20 @@ Editor::refresh_location_display_internal (Locations::LocationList& locations)
 void
 Editor::refresh_location_display ()
 {
-       ENSURE_GUI_THREAD(mem_fun(*this, &Editor::refresh_location_display));
+       ENSURE_GUI_THREAD (*this, &Editor::refresh_location_display)
 
-       if (session) {
-               session->locations()->apply (*this, &Editor::refresh_location_display_internal);
+       if (_session) {
+               _session->locations()->apply (*this, &Editor::refresh_location_display_internal);
        }
 }
 
 void
-Editor::refresh_location_display_s (Change ignored)
+Editor::refresh_location_display_s (const PropertyChange&)
 {
-       ENSURE_GUI_THREAD(bind (mem_fun(*this, &Editor::refresh_location_display_s), ignored));
+       ENSURE_GUI_THREAD (*this, &Editor::refresh_location_display_s, ignored)
 
-       if (session) {
-               session->locations()->apply (*this, &Editor::refresh_location_display_internal);
+       if (_session) {
+               _session->locations()->apply (*this, &Editor::refresh_location_display_internal);
        }
 }
 
@@ -352,40 +359,91 @@ void
 Editor::LocationMarkers::hide()
 {
        start->hide ();
-       if (end) { end->hide(); }
+       if (end) {
+               end->hide ();
+       }
 }
 
 void
 Editor::LocationMarkers::show()
 {
        start->show ();
-       if (end) { end->show(); }
+       if (end) {
+               end->show ();
+       }
+}
+
+void
+Editor::LocationMarkers::canvas_height_set (double h)
+{
+       start->canvas_height_set (h);
+       if (end) {
+               end->canvas_height_set (h);
+       }
 }
 
 void
 Editor::LocationMarkers::set_name (const string& str)
 {
-       start->set_name (str);
-       if (end) { end->set_name (str); }
+       /* XXX: hack: don't change names of session start/end markers */
+
+       if (start->type() != Marker::SessionStart) {
+               start->set_name (str);
+       }
+       
+       if (end && end->type() != Marker::SessionEnd) {
+               end->set_name (str);
+       }
 }
 
 void
-Editor::LocationMarkers::set_position (nframes64_t startf,
-                                      nframes64_t endf)
+Editor::LocationMarkers::set_position (framepos_t startf,
+                                      framepos_t endf)
 {
        start->set_position (startf);
-       if (end) { end->set_position (endf); }
+       if (end) {
+               end->set_position (endf);
+       }
 }
 
 void
 Editor::LocationMarkers::set_color_rgba (uint32_t rgba)
 {
        start->set_color_rgba (rgba);
-       if (end) { end->set_color_rgba (rgba); }
+       if (end) {
+               end->set_color_rgba (rgba);
+       }
+}
+
+void
+Editor::LocationMarkers::set_show_lines (bool s)
+{
+       start->set_show_line (s);
+       if (end) {
+               end->set_show_line (s);
+       }
 }
 
 void
-Editor::mouse_add_new_marker (nframes64_t where, bool is_cd, bool is_xrun)
+Editor::LocationMarkers::set_selected (bool s)
+{
+       start->set_selected (s);
+       if (end) {
+               end->set_selected (s);
+       }
+}
+
+void
+Editor::LocationMarkers::setup_lines ()
+{
+       start->setup_line ();
+       if (end) {
+               end->setup_line ();
+       }
+}
+
+void
+Editor::mouse_add_new_marker (framepos_t where, bool is_cd, bool is_xrun)
 {
        string markername, markerprefix;
        int flags = (is_cd ? Location::IsCDMarker|Location::IsMark : Location::IsMark);
@@ -397,18 +455,18 @@ Editor::mouse_add_new_marker (nframes64_t where, bool is_cd, bool is_xrun)
                markerprefix = "mark";
        }
 
-       if (session) {
-               session->locations()->next_available_name(markername, markerprefix);
+       if (_session) {
+               _session->locations()->next_available_name(markername, markerprefix);
                if (!is_xrun && !choose_new_marker_name(markername)) {
                        return;
                }
-               Location *location = new Location (where, where, markername, (Location::Flags) flags);
-               session->begin_reversible_command (_("add marker"));
-               XMLNode &before = session->locations()->get_state();
-               session->locations()->add (location, true);
-               XMLNode &after = session->locations()->get_state();
-               session->add_command (new MementoCommand<Locations>(*(session->locations()), &before, &after));
-               session->commit_reversible_command ();
+               Location *location = new Location (*_session, where, where, markername, (Location::Flags) flags);
+               _session->begin_reversible_command (_("add marker"));
+               XMLNode &before = _session->locations()->get_state();
+               _session->locations()->add (location, true);
+               XMLNode &after = _session->locations()->get_state();
+               _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
+               _session->commit_reversible_command ();
 
                /* find the marker we just added */
 
@@ -437,27 +495,27 @@ Editor::remove_marker (ArdourCanvas::Item& item, GdkEvent*)
 
        Location* loc = find_location_from_marker (marker, is_start);
 
-       if (session && loc) {
-               Glib::signal_idle().connect (bind (mem_fun(*this, &Editor::really_remove_marker), loc));
+       if (_session && loc) {
+               Glib::signal_idle().connect (sigc::bind (sigc::mem_fun(*this, &Editor::really_remove_marker), loc));
        }
 }
 
 gint
 Editor::really_remove_marker (Location* loc)
 {
-       session->begin_reversible_command (_("remove marker"));
-       XMLNode &before = session->locations()->get_state();
-       session->locations()->remove (loc);
-       XMLNode &after = session->locations()->get_state();
-       session->add_command (new MementoCommand<Locations>(*(session->locations()), &before, &after));
-       session->commit_reversible_command ();
+       _session->begin_reversible_command (_("remove marker"));
+       XMLNode &before = _session->locations()->get_state();
+       _session->locations()->remove (loc);
+       XMLNode &after = _session->locations()->get_state();
+       _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
+       _session->commit_reversible_command ();
        return FALSE;
 }
 
 void
 Editor::location_gone (Location *location)
 {
-       ENSURE_GUI_THREAD(bind (mem_fun(*this, &Editor::location_gone), location));
+       ENSURE_GUI_THREAD (*this, &Editor::location_gone, location)
 
        LocationMarkerMap::iterator i;
 
@@ -479,15 +537,27 @@ Editor::location_gone (Location *location)
 }
 
 void
-Editor::tm_marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item)
+Editor::tempo_or_meter_marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item)
 {
-       if (tm_marker_menu == 0) {
-               build_tm_marker_menu ();
-       }
-
        marker_menu_item = item;
-       tm_marker_menu->popup (1, ev->time);
+       
+       MeterMarker* mm;
+       TempoMarker* tm;
+       dynamic_cast_marker_object (marker_menu_item->get_data ("marker"), &mm, &tm);
+
+       bool can_remove = false;
 
+       if (mm) {
+               can_remove = mm->meter().movable ();
+       } else if (tm) {
+               can_remove = tm->tempo().movable ();
+       } else {
+               return;
+       }
+       
+       delete tempo_or_meter_marker_menu;
+       build_tempo_or_meter_marker_menu (can_remove);
+       tempo_or_meter_marker_menu->popup (1, ev->time);
 }
 
 void
@@ -510,15 +580,14 @@ Editor::marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item)
        } else {
 
                if (loc->is_mark()) {
-                       bool start_or_end = loc->is_start() || loc->is_end();
                        Menu *markerMenu;
-                       if (start_or_end) {
-                               if (start_end_marker_menu == 0)
-                                       build_marker_menu (true);
-                               markerMenu = start_end_marker_menu;
+                       if (loc->is_session_range ()) {
+                               delete session_range_marker_menu;
+                               build_marker_menu (true, loc);
+                               markerMenu = session_range_marker_menu;
                        } else {
-                               if (marker_menu == 0)
-                                       build_marker_menu (false);
+                               delete marker_menu;
+                               build_marker_menu (false, loc);
                                markerMenu = marker_menu;
                        }
 
@@ -573,36 +642,50 @@ Editor::transport_marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item*)
 }
 
 void
-Editor::build_marker_menu (bool start_or_end)
+Editor::build_marker_menu (bool session_range, Location* loc)
 {
        using namespace Menu_Helpers;
 
        Menu *markerMenu = new Menu;
-       if (start_or_end) {
-               start_end_marker_menu = markerMenu;
+       if (session_range) {
+               session_range_marker_menu = markerMenu;
        } else {
                marker_menu = markerMenu;
        }
        MenuList& items = markerMenu->items();
        markerMenu->set_name ("ArdourContextMenu");
 
-       items.push_back (MenuElem (_("Locate to here"), mem_fun(*this, &Editor::marker_menu_set_playhead)));
-       items.push_back (MenuElem (_("Play from here"), mem_fun(*this, &Editor::marker_menu_play_from)));
-       items.push_back (MenuElem (_("Move Mark to Playhead"), mem_fun(*this, &Editor::marker_menu_set_from_playhead)));
+       items.push_back (MenuElem (_("Locate to Here"), sigc::mem_fun(*this, &Editor::marker_menu_set_playhead)));
+       items.push_back (MenuElem (_("Play from Here"), sigc::mem_fun(*this, &Editor::marker_menu_play_from)));
+       items.push_back (MenuElem (_("Move Mark to Playhead"), sigc::mem_fun(*this, &Editor::marker_menu_set_from_playhead)));
 
        items.push_back (SeparatorElem());
 
-       items.push_back (MenuElem (_("Create range to next marker"), mem_fun(*this, &Editor::marker_menu_range_to_next)));
+       items.push_back (MenuElem (_("Create Range to Next Marker"), sigc::mem_fun(*this, &Editor::marker_menu_range_to_next)));
 
-       items.push_back (MenuElem (_("Hide"), mem_fun(*this, &Editor::marker_menu_hide)));
-       if (start_or_end) return;
-       items.push_back (MenuElem (_("Rename"), mem_fun(*this, &Editor::marker_menu_rename)));
-       items.push_back (MenuElem (_("Lock"), bind (mem_fun(*this, &Editor::marker_menu_lock), true)));
-       items.push_back (MenuElem (_("Unlock"), bind (mem_fun(*this, &Editor::marker_menu_lock), false)));
+       items.push_back (MenuElem (_("Hide"), sigc::mem_fun(*this, &Editor::marker_menu_hide)));
+       if (session_range) {
+               return;
+       }
+       items.push_back (MenuElem (_("Rename"), sigc::mem_fun(*this, &Editor::marker_menu_rename)));
+
+       items.push_back (CheckMenuElem (_("Lock")));
+       CheckMenuItem* lock_item = static_cast<CheckMenuItem*> (&items.back());
+       if (loc->locked ()) {
+               lock_item->set_active ();
+       }
+       lock_item->signal_activate().connect (sigc::mem_fun (*this, &Editor::toggle_marker_menu_lock));
 
+       items.push_back (CheckMenuElem (_("Glue to Bars and Beats")));
+       CheckMenuItem* glue_item = static_cast<CheckMenuItem*> (&items.back());
+       if (loc->position_lock_style() == MusicTime) {
+               glue_item->set_active ();
+       }
+       glue_item->signal_activate().connect (sigc::mem_fun (*this, &Editor::toggle_marker_menu_glue));
+       
        items.push_back (SeparatorElem());
 
-       items.push_back (MenuElem (_("Remove"), mem_fun(*this, &Editor::marker_menu_remove)));
+       items.push_back (MenuElem (_("Remove"), sigc::mem_fun(*this, &Editor::marker_menu_remove)));
 }
 
 void
@@ -619,46 +702,48 @@ Editor::build_range_marker_menu (bool loop_or_punch)
        MenuList& items = markerMenu->items();
        markerMenu->set_name ("ArdourContextMenu");
 
-       items.push_back (MenuElem (_("Play Range"), mem_fun(*this, &Editor::marker_menu_play_range)));
-       items.push_back (MenuElem (_("Locate to Range Mark"), mem_fun(*this, &Editor::marker_menu_set_playhead)));
-       items.push_back (MenuElem (_("Play from Range Mark"), mem_fun(*this, &Editor::marker_menu_play_from)));
+       items.push_back (MenuElem (_("Play Range"), sigc::mem_fun(*this, &Editor::marker_menu_play_range)));
+       items.push_back (MenuElem (_("Locate to Range Mark"), sigc::mem_fun(*this, &Editor::marker_menu_set_playhead)));
+       items.push_back (MenuElem (_("Play from Range Mark"), sigc::mem_fun(*this, &Editor::marker_menu_play_from)));
        if (! loop_or_punch) {
-               items.push_back (MenuElem (_("Loop Range"), mem_fun(*this, &Editor::marker_menu_loop_range)));
+               items.push_back (MenuElem (_("Loop Range"), sigc::mem_fun(*this, &Editor::marker_menu_loop_range)));
        }
-       items.push_back (MenuElem (_("Set Range Mark from Playhead"), mem_fun(*this, &Editor::marker_menu_set_from_playhead)));
+       items.push_back (MenuElem (_("Set Range Mark from Playhead"), sigc::mem_fun(*this, &Editor::marker_menu_set_from_playhead)));
        if (!Profile->get_sae()) {
-               items.push_back (MenuElem (_("Set Range from Range Selection"), mem_fun(*this, &Editor::marker_menu_set_from_selection)));
+               items.push_back (MenuElem (_("Set Range from Range Selection"), sigc::mem_fun(*this, &Editor::marker_menu_set_from_selection)));
        }
 
        items.push_back (SeparatorElem());
-       items.push_back (MenuElem (_("Export Range"), mem_fun(*this, &Editor::export_range)));
+       items.push_back (MenuElem (_("Export Range"), sigc::mem_fun(*this, &Editor::export_range)));
        items.push_back (SeparatorElem());
 
        if (!loop_or_punch) {
-               items.push_back (MenuElem (_("Hide Range"), mem_fun(*this, &Editor::marker_menu_hide)));
-               items.push_back (MenuElem (_("Rename Range"), mem_fun(*this, &Editor::marker_menu_rename)));
-               items.push_back (MenuElem (_("Remove Range"), mem_fun(*this, &Editor::marker_menu_remove)));
+               items.push_back (MenuElem (_("Hide Range"), sigc::mem_fun(*this, &Editor::marker_menu_hide)));
+               items.push_back (MenuElem (_("Rename Range"), sigc::mem_fun(*this, &Editor::marker_menu_rename)));
+               items.push_back (MenuElem (_("Remove Range"), sigc::mem_fun(*this, &Editor::marker_menu_remove)));
                items.push_back (SeparatorElem());
        }
 
-       items.push_back (MenuElem (_("Separate Regions in Range"), mem_fun(*this, &Editor::marker_menu_separate_regions_using_location)));
-       items.push_back (MenuElem (_("Select All in Range"), mem_fun(*this, &Editor::marker_menu_select_all_selectables_using_range)));
+       items.push_back (MenuElem (_("Separate Regions in Range"), sigc::mem_fun(*this, &Editor::marker_menu_separate_regions_using_location)));
+       items.push_back (MenuElem (_("Select All in Range"), sigc::mem_fun(*this, &Editor::marker_menu_select_all_selectables_using_range)));
        if (!Profile->get_sae()) {
-               items.push_back (MenuElem (_("Select Range"), mem_fun(*this, &Editor::marker_menu_select_using_range)));
+               items.push_back (MenuElem (_("Select Range"), sigc::mem_fun(*this, &Editor::marker_menu_select_using_range)));
        }
 }
 
 void
-Editor::build_tm_marker_menu ()
+Editor::build_tempo_or_meter_marker_menu (bool can_remove)
 {
        using namespace Menu_Helpers;
 
-       tm_marker_menu = new Menu;
-       MenuList& items = tm_marker_menu->items();
-       tm_marker_menu->set_name ("ArdourContextMenu");
+       tempo_or_meter_marker_menu = new Menu;
+       MenuList& items = tempo_or_meter_marker_menu->items();
+       tempo_or_meter_marker_menu->set_name ("ArdourContextMenu");
 
-       items.push_back (MenuElem (_("Edit"), mem_fun(*this, &Editor::marker_menu_edit)));
-       items.push_back (MenuElem (_("Remove"), mem_fun(*this, &Editor::marker_menu_remove)));
+       items.push_back (MenuElem (_("Edit"), sigc::mem_fun(*this, &Editor::marker_menu_edit)));
+       items.push_back (MenuElem (_("Remove"), sigc::mem_fun(*this, &Editor::marker_menu_remove)));
+
+       items.back().set_sensitive (can_remove);
 }
 
 void
@@ -670,10 +755,10 @@ Editor::build_new_transport_marker_menu ()
        MenuList& items = new_transport_marker_menu->items();
        new_transport_marker_menu->set_name ("ArdourContextMenu");
 
-       items.push_back (MenuElem (_("Set Loop Range"), mem_fun(*this, &Editor::new_transport_marker_menu_set_loop)));
-       items.push_back (MenuElem (_("Set Punch Range"), mem_fun(*this, &Editor::new_transport_marker_menu_set_punch)));
+       items.push_back (MenuElem (_("Set Loop Range"), sigc::mem_fun(*this, &Editor::new_transport_marker_menu_set_loop)));
+       items.push_back (MenuElem (_("Set Punch Range"), sigc::mem_fun(*this, &Editor::new_transport_marker_menu_set_punch)));
 
-       new_transport_marker_menu->signal_unmap().connect ( mem_fun(*this, &Editor::new_transport_marker_menu_popdown));
+       new_transport_marker_menu->signal_unmap().connect ( sigc::mem_fun(*this, &Editor::new_transport_marker_menu_popdown));
 }
 
 void
@@ -726,7 +811,7 @@ Editor::marker_menu_select_all_selectables_using_range ()
        bool is_start;
 
        if (((l = find_location_from_marker (marker, is_start)) != 0) && (l->end() > l->start())) {
-               select_all_within (l->start(), l->end() - 1, 0,  DBL_MAX, track_views, Selection::Set);
+               select_all_within (l->start(), l->end() - 1, 0,  DBL_MAX, track_views, Selection::Set, false);
        }
 
 }
@@ -766,15 +851,15 @@ Editor::marker_menu_play_from ()
        if ((l = find_location_from_marker (marker, is_start)) != 0) {
 
                if (l->is_mark()) {
-                       session->request_locate (l->start(), true);
+                       _session->request_locate (l->start(), true);
                }
                else {
-                       //session->request_bounded_roll (l->start(), l->end());
+                       //_session->request_bounded_roll (l->start(), l->end());
 
                        if (is_start) {
-                               session->request_locate (l->start(), true);
+                               _session->request_locate (l->start(), true);
                        } else {
-                               session->request_locate (l->end(), true);
+                               _session->request_locate (l->end(), true);
                        }
                }
        }
@@ -796,13 +881,13 @@ Editor::marker_menu_set_playhead ()
        if ((l = find_location_from_marker (marker, is_start)) != 0) {
 
                if (l->is_mark()) {
-                       session->request_locate (l->start(), false);
+                       _session->request_locate (l->start(), false);
                }
                else {
                        if (is_start) {
-                               session->request_locate (l->start(), false);
+                               _session->request_locate (l->start(), false);
                        } else {
-                               session->request_locate (l->end(), false);
+                               _session->request_locate (l->end(), false);
                        }
                }
        }
@@ -812,7 +897,7 @@ void
 Editor::marker_menu_range_to_next ()
 {
        Marker* marker;
-       if (!session) {
+       if (!_session) {
                return;
        }
 
@@ -828,16 +913,16 @@ Editor::marker_menu_range_to_next ()
                return;
        }
 
-       nframes64_t start;
-       nframes64_t end;
-       session->locations()->marks_either_side (marker->position(), start, end);
+       framepos_t start;
+       framepos_t end;
+       _session->locations()->marks_either_side (marker->position(), start, end);
 
-       if (end != max_frames) {
+       if (end != max_framepos) {
                string range_name = l->name();
                range_name += "-range";
 
-               Location* newrange = new Location (marker->position(), end, range_name, Location::IsRangeMarker);
-               session->locations()->add (newrange);
+               Location* newrange = new Location (*_session, marker->position(), end, range_name, Location::IsRangeMarker);
+               _session->locations()->add (newrange);
        }
 }
 
@@ -857,13 +942,13 @@ Editor::marker_menu_set_from_playhead ()
        if ((l = find_location_from_marker (marker, is_start)) != 0) {
 
                if (l->is_mark()) {
-                       l->set_start (session->audible_frame ());
+                       l->set_start (_session->audible_frame ());
                }
                else {
                        if (is_start) {
-                               l->set_start (session->audible_frame ());
+                               l->set_start (_session->audible_frame ());
                        } else {
-                               l->set_end (session->audible_frame ());
+                               l->set_end (_session->audible_frame ());
                        }
                }
        }
@@ -924,10 +1009,10 @@ Editor::marker_menu_play_range ()
        if ((l = find_location_from_marker (marker, is_start)) != 0) {
 
                if (l->is_mark()) {
-                       session->request_locate (l->start(), true);
+                       _session->request_locate (l->start(), true);
                }
                else {
-                       session->request_bounded_roll (l->start(), l->end());
+                       _session->request_bounded_roll (l->start(), l->end());
 
                }
        }
@@ -952,32 +1037,36 @@ Editor::marker_menu_loop_range ()
                        l2->set (l->start(), l->end());
 
                        // enable looping, reposition and start rolling
-                       session->request_play_loop(true);
-                       session->request_locate (l2->start(), true);
+                       _session->request_play_loop(true);
+                       _session->request_locate (l2->start(), true);
                }
        }
 }
 
 void
-Editor::marker_menu_edit ()
+Editor::dynamic_cast_marker_object (void* p, MeterMarker** m, TempoMarker** t) const
 {
-       MeterMarker* mm;
-       TempoMarker* tm;
-       Marker* marker;
-
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       Marker* marker = reinterpret_cast<Marker*> (p);
+       if (!marker) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
                /*NOTREACHED*/
        }
 
-       if ((mm = dynamic_cast<MeterMarker*> (marker)) != 0) {
+       *m = dynamic_cast<MeterMarker*> (marker);
+       *t = dynamic_cast<TempoMarker*> (marker);
+}
+
+void
+Editor::marker_menu_edit ()
+{
+       MeterMarker* mm;
+       TempoMarker* tm;
+       dynamic_cast_marker_object (marker_menu_item->get_data ("marker"), &mm, &tm);
+
+       if (mm) {
                edit_meter_section (&mm->meter());
-       } else if ((tm = dynamic_cast<TempoMarker*> (marker)) != 0) {
+       } else if (tm) {
                edit_tempo_section (&tm->tempo());
-       } else {
-               fatal << X_("programming erorr: unhandled marker type in Editor::marker_menu_edit")
-                     << endmsg;
-               /*NOTREACHED*/
        }
 }
 
@@ -986,16 +1075,11 @@ Editor::marker_menu_remove ()
 {
        MeterMarker* mm;
        TempoMarker* tm;
-       Marker* marker;
-
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
-               fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
-       }
+       dynamic_cast_marker_object (marker_menu_item->get_data ("marker"), &mm, &tm);
 
-       if ((mm = dynamic_cast<MeterMarker*> (marker)) != 0) {
+       if (mm) {
                remove_meter_marker (marker_menu_item);
-       } else if ((tm = dynamic_cast<TempoMarker*> (marker)) != 0) {
+       } else if (tm) {
                remove_tempo_marker (marker_menu_item);
        } else {
                remove_marker (*marker_menu_item, (GdkEvent*) 0);
@@ -1003,9 +1087,8 @@ Editor::marker_menu_remove ()
 }
 
 void
-Editor::marker_menu_lock (bool yn)
+Editor::toggle_marker_menu_lock ()
 {
-
        Marker* marker;
 
        if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
@@ -1018,12 +1101,14 @@ Editor::marker_menu_lock (bool yn)
 
        loc = find_location_from_marker (marker, ignored);
 
-       if (!loc) return;
+       if (!loc) {
+               return;
+       }
 
-       if (yn) {
-               loc->lock();
-       } else {
+       if (loc->locked()) {
                loc->unlock ();
+       } else {
+               loc->lock ();
        }
 }
 
@@ -1073,13 +1158,13 @@ Editor::marker_menu_rename ()
        }
 
        begin_reversible_command ( _("rename marker") );
-       XMLNode &before = session->locations()->get_state();
+       XMLNode &before = _session->locations()->get_state();
 
        dialog.get_result(txt);
        loc->set_name (txt);
 
-       XMLNode &after = session->locations()->get_state();
-       session->add_command (new MementoCommand<Locations>(*(session->locations()), &before, &after));
+       XMLNode &after = _session->locations()->get_state();
+       _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
        commit_reversible_command ();
 }
 
@@ -1089,7 +1174,7 @@ Editor::new_transport_marker_menu_popdown ()
        // hide rects
        transport_bar_drag_rect->hide();
 
-       break_drag ();
+       _drags->abort ();
 }
 
 void
@@ -1107,13 +1192,13 @@ Editor::new_transport_marker_menu_set_punch ()
 void
 Editor::update_loop_range_view (bool visibility)
 {
-       if (session == 0) {
+       if (_session == 0) {
                return;
        }
 
        Location* tll;
 
-       if (session->get_play_loop() && ((tll = transport_loop_location()) != 0)) {
+       if (_session->get_play_loop() && ((tll = transport_loop_location()) != 0)) {
 
                double x1 = frame_to_pixel (tll->start());
                double x2 = frame_to_pixel (tll->end());
@@ -1133,21 +1218,21 @@ Editor::update_loop_range_view (bool visibility)
 void
 Editor::update_punch_range_view (bool visibility)
 {
-       if (session == 0) {
+       if (_session == 0) {
                return;
        }
 
        Location* tpl;
 
-       if ((session->config.get_punch_in() || session->config.get_punch_out()) && ((tpl = transport_punch_location()) != 0)) {
+       if ((_session->config.get_punch_in() || _session->config.get_punch_out()) && ((tpl = transport_punch_location()) != 0)) {
                guint track_canvas_width,track_canvas_height;
                track_canvas->get_size(track_canvas_width,track_canvas_height);
-               if (session->config.get_punch_in()) {
+               if (_session->config.get_punch_in()) {
                        transport_punch_range_rect->property_x1() = frame_to_pixel (tpl->start());
-                       transport_punch_range_rect->property_x2() = (session->config.get_punch_out() ? frame_to_pixel (tpl->end()) : frame_to_pixel (JACK_MAX_FRAMES));
+                       transport_punch_range_rect->property_x2() = (_session->config.get_punch_out() ? frame_to_pixel (tpl->end()) : frame_to_pixel (JACK_MAX_FRAMES));
                } else {
                        transport_punch_range_rect->property_x1() = 0;
-                       transport_punch_range_rect->property_x2() = (session->config.get_punch_out() ? frame_to_pixel (tpl->end()) : track_canvas_width);
+                       transport_punch_range_rect->property_x2() = (_session->config.get_punch_out() ? frame_to_pixel (tpl->end()) : track_canvas_width);
                }
 
                if (visibility) {
@@ -1161,52 +1246,19 @@ Editor::update_punch_range_view (bool visibility)
 void
 Editor::marker_selection_changed ()
 {
-       if (session && session->deletion_in_progress()) {
+       if (_session && _session->deletion_in_progress()) {
                return;
        }
 
        for (LocationMarkerMap::iterator i = location_markers.begin(); i != location_markers.end(); ++i) {
-               LocationMarkers* lam = i->second;
-
-               if (lam->start) {
-                       lam->start->hide_line();
-               }
-
-               if (lam->end) {
-                       lam->end->hide_line();
-               }
-       }
-
-       edit_point_clock_connection_a.disconnect();
-       edit_point_clock_connection_b.disconnect();
-
-       if (selection->markers.empty()) {
-               edit_point_clock.set (0);
-               return;
+               i->second->set_selected (false);
        }
 
        for (MarkerSelection::iterator x = selection->markers.begin(); x != selection->markers.end(); ++x) {
-               (*x)->add_line (cursor_group, 0, _canvas_height);
-               (*x)->show_line ();
-       }
-
-       edit_point_clock.set (selection->markers.front()->position());
-
-       bool ignored;
-       Location* loc = find_location_from_marker (selection->markers.front(), ignored);
-
-       if (loc) {
-               edit_point_clock_connection_a = loc->changed.connect (mem_fun (*this, &Editor::selected_marker_moved));
-               edit_point_clock_connection_b = loc->start_changed.connect (mem_fun (*this, &Editor::selected_marker_moved));
+               (*x)->set_selected (true);
        }
 }
 
-void
-Editor::selected_marker_moved (Location* loc)
-{
-       edit_point_clock.set (loc->start());
-}
-
 struct SortLocationsByPosition {
     bool operator() (Location* a, Location* b) {
            return a->start() < b->start();
@@ -1216,10 +1268,10 @@ struct SortLocationsByPosition {
 void
 Editor::goto_nth_marker (int n)
 {
-       if (!session) {
+       if (!_session) {
                return;
        }
-       const Locations::LocationList& l (session->locations()->list());
+       const Locations::LocationList& l (_session->locations()->list());
        Locations::LocationList ordered;
        ordered = l;
 
@@ -1227,12 +1279,49 @@ Editor::goto_nth_marker (int n)
        ordered.sort (cmp);
 
        for (Locations::LocationList::iterator i = ordered.begin(); n >= 0 && i != ordered.end(); ++i) {
-               if ((*i)->is_mark() && !(*i)->is_hidden() && !(*i)->is_start()) {
+               if ((*i)->is_mark() && !(*i)->is_hidden() && !(*i)->is_session_range()) {
                        if (n == 0) {
-                               session->request_locate ((*i)->start(), session->transport_rolling());
+                               _session->request_locate ((*i)->start(), _session->transport_rolling());
                                break;
                        }
                        --n;
                }
        }
 }
+
+void
+Editor::toggle_marker_menu_glue ()
+{
+       Marker* marker;
+
+       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+               fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
+               /*NOTREACHED*/
+       }
+
+       Location* loc;
+       bool ignored;
+
+       loc = find_location_from_marker (marker, ignored);
+
+       if (!loc) {
+               return;
+       }
+
+       if (loc->position_lock_style() == MusicTime) {
+               loc->set_position_lock_style (AudioTime);
+       } else {
+               loc->set_position_lock_style (MusicTime);
+       }
+
+}
+
+void
+Editor::toggle_marker_lines ()
+{
+       _show_marker_lines = !_show_marker_lines;
+       
+       for (LocationMarkerMap::iterator i = location_markers.begin(); i != location_markers.end(); ++i) {
+               i->second->set_show_lines (_show_marker_lines);
+       }
+}