add new action and loop marker menu item for setting up loop record
[ardour.git] / gtk2_ardour / editor_markers.cc
index f21f4b21bcb41e8f09f17016c08a9d6bb3b66836..8eac1ddcc3dc01f18c37fc37d8bdaaea50cea876 100644 (file)
@@ -64,24 +64,32 @@ Editor::add_new_location (Location *location)
 {
        ENSURE_GUI_THREAD (*this, &Editor::add_new_location, location);
 
-       ArdourCanvas::Group* group = add_new_location_internal (location);
+       ArdourCanvas::Container* group = add_new_location_internal (location);
 
        /* Do a full update of the markers in this group */
        update_marker_labels (group);
+       
+       if (location->is_auto_punch()) {
+               update_punch_range_view ();
+       }
+
+       if (location->is_auto_loop()) {
+               update_loop_range_view ();
+       }
 }
 
 /** Add a new location, without a time-consuming update of all marker labels;
  *  the caller must call update_marker_labels () after calling this.
  *  @return canvas group that the location's marker was added to.
  */
-ArdourCanvas::Group*
+ArdourCanvas::Container*
 Editor::add_new_location_internal (Location* location)
 {
        LocationMarkers *lam = new LocationMarkers;
        uint32_t color;
 
        /* make a note here of which group this marker ends up in */
-       ArdourCanvas::Group* group = 0;
+       ArdourCanvas::Container* group = 0;
 
        if (location->is_cd_marker()) {
                color = location_cd_marker_color;
@@ -98,10 +106,10 @@ Editor::add_new_location_internal (Location* location)
        if (location->is_mark()) {
 
                if (location->is_cd_marker() && ruler_cd_marker_action->get_active()) {
-                       lam->start = new Marker (*this, *cd_marker_group, color, location->name(), Marker::Mark, location->start());
+                       lam->start = new ArdourMarker (*this, *cd_marker_group, color, location->name(), ArdourMarker::Mark, location->start());
                        group = cd_marker_group;
                } else {
-                       lam->start = new Marker (*this, *marker_group, color, location->name(), Marker::Mark, location->start());
+                       lam->start = new ArdourMarker (*this, *marker_group, color, location->name(), ArdourMarker::Mark, location->start());
                        group = marker_group;
                }
 
@@ -110,41 +118,41 @@ Editor::add_new_location_internal (Location* location)
        } else if (location->is_auto_loop()) {
 
                // transport marker
-               lam->start = new Marker (*this, *transport_marker_group, color,
-                                        location->name(), Marker::LoopStart, location->start());
-               lam->end   = new Marker (*this, *transport_marker_group, color,
-                                        location->name(), Marker::LoopEnd, location->end());
+               lam->start = new ArdourMarker (*this, *transport_marker_group, color,
+                                        location->name(), ArdourMarker::LoopStart, location->start());
+               lam->end   = new ArdourMarker (*this, *transport_marker_group, color,
+                                        location->name(), ArdourMarker::LoopEnd, location->end());
                group = transport_marker_group;
 
        } else if (location->is_auto_punch()) {
 
                // transport marker
-               lam->start = new Marker (*this, *transport_marker_group, color,
-                                        location->name(), Marker::PunchIn, location->start());
-               lam->end   = new Marker (*this, *transport_marker_group, color,
-                                        location->name(), Marker::PunchOut, location->end());
+               lam->start = new ArdourMarker (*this, *transport_marker_group, color,
+                                        location->name(), ArdourMarker::PunchIn, location->start());
+               lam->end   = new ArdourMarker (*this, *transport_marker_group, color,
+                                        location->name(), ArdourMarker::PunchOut, location->end());
                group = transport_marker_group;
 
        } else if (location->is_session_range()) {
 
                // session range
-               lam->start = new Marker (*this, *marker_group, color, _("start"), Marker::SessionStart, location->start());
-               lam->end = new Marker (*this, *marker_group, color, _("end"), Marker::SessionEnd, location->end());
+               lam->start = new ArdourMarker (*this, *marker_group, color, _("start"), ArdourMarker::SessionStart, location->start());
+               lam->end = new ArdourMarker (*this, *marker_group, color, _("end"), ArdourMarker::SessionEnd, location->end());
                group = marker_group;
 
        } else {
                // range marker
                if (location->is_cd_marker() && ruler_cd_marker_action->get_active()) {
-                       lam->start = new Marker (*this, *cd_marker_group, color,
-                                                location->name(), Marker::RangeStart, location->start());
-                       lam->end   = new Marker (*this, *cd_marker_group, color,
-                                                location->name(), Marker::RangeEnd, location->end());
+                       lam->start = new ArdourMarker (*this, *cd_marker_group, color,
+                                                location->name(), ArdourMarker::RangeStart, location->start());
+                       lam->end   = new ArdourMarker (*this, *cd_marker_group, color,
+                                                location->name(), ArdourMarker::RangeEnd, location->end());
                        group = cd_marker_group;
                } else {
-                       lam->start = new Marker (*this, *range_marker_group, color,
-                                                location->name(), Marker::RangeStart, location->start());
-                       lam->end   = new Marker (*this, *range_marker_group, color,
-                                                location->name(), Marker::RangeEnd, location->end());
+                       lam->start = new ArdourMarker (*this, *range_marker_group, color,
+                                                location->name(), ArdourMarker::RangeStart, location->start());
+                       lam->end   = new ArdourMarker (*this, *range_marker_group, color,
+                                                location->name(), ArdourMarker::RangeEnd, location->end());
                        group = range_marker_group;
                }
        }
@@ -155,11 +163,8 @@ Editor::add_new_location_internal (Location* location)
                lam->show ();
        }
 
-       location->start_changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context());
-       location->end_changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context());
-       location->changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context());
        location->name_changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context());
-       location->FlagsChanged.connect (*this, invalidator (*this), boost::bind (&Editor::location_flags_changed, this, _1, _2), gui_context());
+       location->FlagsChanged.connect (*this, invalidator (*this), boost::bind (&Editor::location_flags_changed, this, location), gui_context());
 
        pair<Location*,LocationMarkers*> newpair;
 
@@ -219,15 +224,15 @@ Editor::location_changed (Location *location)
  *  lengthened)
  */
 void
-Editor::check_marker_label (Marker* m)
+Editor::check_marker_label (ArdourMarker* m)
 {
        /* Get a time-ordered list of markers from the last time anything changed */
-       std::list<Marker*>& sorted = _sorted_marker_lists[m->get_parent()];
+       std::list<ArdourMarker*>& sorted = _sorted_marker_lists[m->get_parent()];
 
-       list<Marker*>::iterator i = find (sorted.begin(), sorted.end(), m);
+       list<ArdourMarker*>::iterator i = find (sorted.begin(), sorted.end(), m);
 
-       list<Marker*>::iterator prev = sorted.end ();
-       list<Marker*>::iterator next = i;
+       list<ArdourMarker*>::iterator prev = sorted.end ();
+       list<ArdourMarker*>::iterator next = i;
        ++next;
 
        /* Look to see if the previous marker is still behind `m' in time */
@@ -294,7 +299,7 @@ Editor::check_marker_label (Marker* m)
 }
 
 struct MarkerComparator {
-       bool operator() (Marker const * a, Marker const * b) {
+       bool operator() (ArdourMarker const * a, ArdourMarker const * b) {
                return a->position() < b->position();
        }
 };
@@ -303,16 +308,16 @@ struct MarkerComparator {
 void
 Editor::update_marker_labels ()
 {
-       for (std::map<ArdourCanvas::Group *, std::list<Marker *> >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) {
+       for (std::map<ArdourCanvas::Container *, std::list<ArdourMarker *> >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) {
                update_marker_labels (i->first);
        }
 }
 
 /** Look at all markers in a group and update label widths */
 void
-Editor::update_marker_labels (ArdourCanvas::Group* group)
+Editor::update_marker_labels (ArdourCanvas::Container* group)
 {
-       list<Marker*>& sorted = _sorted_marker_lists[group];
+       list<ArdourMarker*>& sorted = _sorted_marker_lists[group];
 
        if (sorted.empty()) {
                return;
@@ -322,11 +327,14 @@ Editor::update_marker_labels (ArdourCanvas::Group* group)
 
        sorted.sort (MarkerComparator ());
 
-       list<Marker*>::iterator i = sorted.begin ();
+       list<ArdourMarker*>::iterator i = sorted.begin ();
 
-       list<Marker*>::iterator prev = sorted.end ();
-       list<Marker*>::iterator next = i;
-       ++next;
+       list<ArdourMarker*>::iterator prev = sorted.end ();
+       list<ArdourMarker*>::iterator next = i;
+
+       if (next != sorted.end()) {
+               ++next;
+       }
 
        while (i != sorted.end()) {
 
@@ -349,16 +357,17 @@ Editor::update_marker_labels (ArdourCanvas::Group* group)
                        } else {
                                (*i)->set_right_label_limit (p);
                        }
+
+                       ++next;
                }
 
                prev = i;
                ++i;
-               ++next;
        }
 }
 
 void
-Editor::location_flags_changed (Location *location, void*)
+Editor::location_flags_changed (Location *location)
 {
        ENSURE_GUI_THREAD (*this, &Editor::location_flags_changed, location, src)
 
@@ -458,7 +467,7 @@ Editor::find_location_markers (Location *location) const
 }
 
 Location *
-Editor::find_location_from_marker (Marker *marker, bool& is_start) const
+Editor::find_location_from_marker (ArdourMarker *marker, bool& is_start) const
 {
        LocationMarkerMap::const_iterator i;
 
@@ -477,7 +486,7 @@ Editor::find_location_from_marker (Marker *marker, bool& is_start) const
 }
 
 void
-Editor::refresh_location_display_internal (Locations::LocationList& locations)
+Editor::refresh_location_display_internal (const Locations::LocationList& locations)
 {
        /* invalidate all */
 
@@ -487,7 +496,7 @@ Editor::refresh_location_display_internal (Locations::LocationList& locations)
 
        /* add new ones */
 
-       for (Locations::LocationList::iterator i = locations.begin(); i != locations.end(); ++i) {
+       for (Locations::LocationList::const_iterator i = locations.begin(); i != locations.end(); ++i) {
 
                LocationMarkerMap::iterator x;
 
@@ -523,8 +532,8 @@ Editor::refresh_location_display_internal (Locations::LocationList& locations)
                i = tmp;
        }
 
-       update_punch_range_view (false);
-       update_loop_range_view (false);
+       update_punch_range_view ();
+       update_loop_range_view ();
 }
 
 void
@@ -571,11 +580,11 @@ Editor::LocationMarkers::set_name (const string& str)
 {
        /* XXX: hack: don't change names of session start/end markers */
 
-       if (start->type() != Marker::SessionStart) {
+       if (start->type() != ArdourMarker::SessionStart) {
                start->set_name (str);
        }
 
-       if (end && end->type() != Marker::SessionEnd) {
+       if (end && end->type() != ArdourMarker::SessionEnd) {
                end->set_name (str);
        }
 }
@@ -627,30 +636,23 @@ Editor::LocationMarkers::setup_lines ()
 }
 
 void
-Editor::mouse_add_new_marker (framepos_t where, bool is_cd, bool is_xrun)
+Editor::mouse_add_new_marker (framepos_t where, bool is_cd)
 {
-       string markername, markerprefix;
+       string markername;
        int flags = (is_cd ? Location::IsCDMarker|Location::IsMark : Location::IsMark);
 
-       if (is_xrun) {
-               markerprefix = "xrun";
-               flags = Location::IsMark;
-       } else {
-               markerprefix = "mark";
-       }
-
        if (_session) {
-               _session->locations()->next_available_name(markername, markerprefix);
-               if (!is_xrun && !choose_new_marker_name(markername)) {
+               _session->locations()->next_available_name(markername, _("mark"));
+               if (!choose_new_marker_name(markername)) {
                        return;
                }
                Location *location = new Location (*_session, where, where, markername, (Location::Flags) flags);
-               _session->begin_reversible_command (_("add marker"));
+               begin_reversible_command (_("add marker"));
+
                XMLNode &before = _session->locations()->get_state();
                _session->locations()->add (location, true);
                XMLNode &after = _session->locations()->get_state();
                _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
-               _session->commit_reversible_command ();
 
                /* find the marker we just added */
 
@@ -659,9 +661,43 @@ Editor::mouse_add_new_marker (framepos_t where, bool is_cd, bool is_xrun)
                        /* make it the selected marker */
                        selection->set (lam->start);
                }
+
+               commit_reversible_command ();
        }
 }
 
+void
+Editor::mouse_add_new_loop (framepos_t where)
+{
+       if (!_session) {
+               return;
+       }
+
+       /* Make this marker 1/8th of the visible area of the session so that
+          it's reasonably easy to manipulate after creation.
+       */
+
+       framepos_t const end = where + current_page_samples() / 8;
+
+       set_loop_range (where, end,  _("set loop range"));
+}
+
+void
+Editor::mouse_add_new_punch (framepos_t where)
+{
+       if (!_session) {
+               return;
+       }
+
+       /* Make this marker 1/8th of the visible area of the session so that
+          it's reasonably easy to manipulate after creation.
+       */
+
+       framepos_t const end = where + current_page_samples() / 8;
+
+       set_punch_range (where, end,  _("set punch range"));
+}
+
 void
 Editor::mouse_add_new_range (framepos_t where)
 {
@@ -690,12 +726,12 @@ Editor::mouse_add_new_range (framepos_t where)
 void
 Editor::remove_marker (ArdourCanvas::Item& item, GdkEvent*)
 {
-       Marker* marker;
+       ArdourMarker* marker;
        bool is_start;
 
-       if ((marker = static_cast<Marker*> (item.get_data ("marker"))) == 0) {
+       if ((marker = static_cast<ArdourMarker*> (item.get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        if (entered_marker == marker) {
@@ -712,12 +748,12 @@ Editor::remove_marker (ArdourCanvas::Item& item, GdkEvent*)
 gint
 Editor::really_remove_marker (Location* loc)
 {
-       _session->begin_reversible_command (_("remove marker"));
+       begin_reversible_command (_("remove marker"));
        XMLNode &before = _session->locations()->get_state();
        _session->locations()->remove (loc);
        XMLNode &after = _session->locations()->get_state();
        _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
-       _session->commit_reversible_command ();
+       commit_reversible_command ();
        return FALSE;
 }
 
@@ -729,11 +765,11 @@ Editor::location_gone (Location *location)
        LocationMarkerMap::iterator i;
 
        if (location == transport_loop_location()) {
-               update_loop_range_view (true);
+               update_loop_range_view ();
        }
 
        if (location == transport_punch_location()) {
-               update_punch_range_view (true);
+               update_punch_range_view ();
        }
 
        for (i = location_markers.begin(); i != location_markers.end(); ++i) {
@@ -747,6 +783,13 @@ Editor::location_gone (Location *location)
                        LocationMarkers* m = i->second;
                        location_markers.erase (i);
                        delete m;
+
+                       /* Markers that visually overlap with this (removed) marker
+                        * need to be re-displayed.
+                        * But finding such cases is similarly expensive as simply
+                        * re-displaying all..  so:
+                        */
+                       refresh_location_display ();
                        break;
                }
        }
@@ -779,10 +822,10 @@ Editor::tempo_or_meter_marker_context_menu (GdkEventButton* ev, ArdourCanvas::It
 void
 Editor::marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item)
 {
-       Marker * marker;
-       if ((marker = reinterpret_cast<Marker *> (item->get_data("marker"))) == 0) {
+       ArdourMarker * marker;
+       if ((marker = reinterpret_cast<ArdourMarker *> (item->get_data("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        bool is_start;
@@ -791,7 +834,7 @@ Editor::marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item)
        if (loc == transport_loop_location() || loc == transport_punch_location() || loc->is_session_range ()) {
 
                if (transport_marker_menu == 0) {
-                       build_range_marker_menu (loc == transport_loop_location() || loc == transport_punch_location(), loc->is_session_range());
+                       build_range_marker_menu (loc == transport_loop_location(), loc == transport_punch_location(), loc->is_session_range());
                }
 
                marker_menu_item = item;
@@ -821,7 +864,7 @@ Editor::marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item)
 
        } else if (loc->is_range_marker()) {
                if (range_marker_menu == 0) {
-                       build_range_marker_menu (false, false);
+                       build_range_marker_menu (false, false, false);
                }
                marker_menu_item = item;
                range_marker_menu->popup (1, ev->time);
@@ -879,11 +922,11 @@ Editor::build_marker_menu (Location* loc)
 }
 
 void
-Editor::build_range_marker_menu (bool loop_or_punch, bool session)
+Editor::build_range_marker_menu (bool loop, bool punch, bool session)
 {
        using namespace Menu_Helpers;
 
-       bool const loop_or_punch_or_session = loop_or_punch | session;
+       bool const loop_or_punch_or_session = loop | punch | session;
 
        Menu *markerMenu = new Menu;
        if (loop_or_punch_or_session) {
@@ -897,7 +940,12 @@ Editor::build_range_marker_menu (bool loop_or_punch, bool session)
        items.push_back (MenuElem (_("Play Range"), sigc::mem_fun(*this, &Editor::marker_menu_play_range)));
        items.push_back (MenuElem (_("Locate to Marker"), sigc::mem_fun(*this, &Editor::marker_menu_set_playhead)));
        items.push_back (MenuElem (_("Play from Marker"), sigc::mem_fun(*this, &Editor::marker_menu_play_from)));
-       items.push_back (MenuElem (_("Loop Range"), sigc::mem_fun(*this, &Editor::marker_menu_loop_range)));
+
+       if (!loop) {
+               items.push_back (MenuElem (_("Loop Range"), sigc::mem_fun(*this, &Editor::marker_menu_loop_range)));
+       } else {
+               items.push_back (MenuElem (_("Setup Loop Record"), sigc::mem_fun(*this, &Editor::setup_loop_record)));
+       }
 
        items.push_back (MenuElem (_("Set Marker from Playhead"), sigc::mem_fun(*this, &Editor::marker_menu_set_from_playhead)));
        if (!Profile->get_sae()) {
@@ -963,11 +1011,11 @@ Editor::build_new_transport_marker_menu ()
 void
 Editor::marker_menu_hide ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -981,11 +1029,11 @@ Editor::marker_menu_hide ()
 void
 Editor::marker_menu_select_using_range ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -999,11 +1047,11 @@ Editor::marker_menu_select_using_range ()
 void
 Editor::marker_menu_select_all_selectables_using_range ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1018,11 +1066,11 @@ Editor::marker_menu_select_all_selectables_using_range ()
 void
 Editor::marker_menu_separate_regions_using_location ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1037,11 +1085,11 @@ Editor::marker_menu_separate_regions_using_location ()
 void
 Editor::marker_menu_play_from ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1067,11 +1115,11 @@ Editor::marker_menu_play_from ()
 void
 Editor::marker_menu_set_playhead ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1095,14 +1143,14 @@ Editor::marker_menu_set_playhead ()
 void
 Editor::marker_menu_range_to_next ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
        if (!_session) {
                return;
        }
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1128,11 +1176,11 @@ Editor::marker_menu_range_to_next ()
 void
 Editor::marker_menu_set_from_playhead ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1156,11 +1204,11 @@ Editor::marker_menu_set_from_playhead ()
 void
 Editor::marker_menu_set_from_selection (bool /*force_regions*/)
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1187,11 +1235,11 @@ Editor::marker_menu_set_from_selection (bool /*force_regions*/)
 void
 Editor::marker_menu_play_range ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1212,11 +1260,11 @@ Editor::marker_menu_play_range ()
 void
 Editor::marker_menu_loop_range ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* l;
@@ -1228,8 +1276,8 @@ Editor::marker_menu_loop_range ()
                        l2->set (l->start(), l->end());
 
                        // enable looping, reposition and start rolling
-                       _session->request_play_loop(true);
                        _session->request_locate (l2->start(), true);
+                       _session->request_play_loop(true);
                }
        }
 }
@@ -1238,7 +1286,7 @@ Editor::marker_menu_loop_range ()
 void
 Editor::marker_menu_zoom_to_range ()
 {
-       Marker* marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"));
+       ArdourMarker* marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"));
        assert (marker);
 
        bool is_start;
@@ -1264,10 +1312,10 @@ Editor::marker_menu_zoom_to_range ()
 void
 Editor::dynamic_cast_marker_object (void* p, MeterMarker** m, TempoMarker** t) const
 {
-       Marker* marker = reinterpret_cast<Marker*> (p);
+       ArdourMarker* marker = reinterpret_cast<ArdourMarker*> (p);
        if (!marker) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        *m = dynamic_cast<MeterMarker*> (marker);
@@ -1307,11 +1355,11 @@ Editor::marker_menu_remove ()
 void
 Editor::toggle_marker_menu_lock ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* loc;
@@ -1333,19 +1381,30 @@ Editor::toggle_marker_menu_lock ()
 void
 Editor::marker_menu_rename ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
+
+       rename_marker (marker);
+}
+
+void
+Editor::rename_marker(ArdourMarker *marker)
+{
        Location* loc;
        bool is_start;
 
        loc = find_location_from_marker (marker, is_start);
 
-       if (!loc) return;
+       if (!loc)
+              return;
+
+       if (loc == transport_loop_location() || loc == transport_punch_location() || loc->is_session_range())
+               return;
 
        ArdourPrompter dialog (true);
        string txt;
@@ -1380,6 +1439,7 @@ Editor::marker_menu_rename ()
 
        dialog.get_result(txt);
        loc->set_name (txt);
+       _session->set_dirty ();
 
        XMLNode &after = _session->locations()->get_state();
        _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
@@ -1408,7 +1468,7 @@ Editor::new_transport_marker_menu_set_punch ()
 }
 
 void
-Editor::update_loop_range_view (bool visibility)
+Editor::update_loop_range_view ()
 {
        if (_session == 0) {
                return;
@@ -1424,17 +1484,15 @@ Editor::update_loop_range_view (bool visibility)
                transport_loop_range_rect->set_x0 (x1);
                transport_loop_range_rect->set_x1 (x2);
 
-               if (visibility) {
-                       transport_loop_range_rect->show();
-               }
-
-       } else if (visibility) {
+               transport_loop_range_rect->show();
+               
+       } else {
                transport_loop_range_rect->hide();
        }
 }
 
 void
-Editor::update_punch_range_view (bool visibility)
+Editor::update_punch_range_view ()
 {
        if (_session == 0) {
                return;
@@ -1443,19 +1501,27 @@ Editor::update_punch_range_view (bool visibility)
        Location* tpl;
 
        if ((_session->config.get_punch_in() || _session->config.get_punch_out()) && ((tpl = transport_punch_location()) != 0)) {
-               ArdourCanvas::Rect const v = _track_canvas->visible_area ();
+
+               double pixel_start;
+               double pixel_end;
+               
                if (_session->config.get_punch_in()) {
-                       transport_punch_range_rect->set_x0 (sample_to_pixel (tpl->start()));
-                       transport_punch_range_rect->set_x1 (_session->config.get_punch_out() ? sample_to_pixel (tpl->end()) : sample_to_pixel (JACK_MAX_FRAMES));
+                       pixel_start = sample_to_pixel (tpl->start());
                } else {
-                       transport_punch_range_rect->set_x0 (0);
-                       transport_punch_range_rect->set_x1 (_session->config.get_punch_out() ? sample_to_pixel (tpl->end()) : v.width ());
+                       pixel_start = 0;
                }
-
-               if (visibility) {
-                       transport_punch_range_rect->show();
+               if (_session->config.get_punch_out()) {
+                       pixel_end = sample_to_pixel (tpl->end());
+               } else {
+                       pixel_end = sample_to_pixel (max_framepos);
                }
-       } else if (visibility) {
+               
+               transport_punch_range_rect->set_x0 (pixel_start);
+               transport_punch_range_rect->set_x1 (pixel_end);                 
+               transport_punch_range_rect->show();
+
+       } else {
+
                transport_punch_range_rect->hide();
        }
 }
@@ -1509,11 +1575,11 @@ Editor::goto_nth_marker (int n)
 void
 Editor::toggle_marker_menu_glue ()
 {
-       Marker* marker;
+       ArdourMarker* marker;
 
-       if ((marker = reinterpret_cast<Marker *> (marker_menu_item->get_data ("marker"))) == 0) {
+       if ((marker = reinterpret_cast<ArdourMarker *> (marker_menu_item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        Location* loc;
@@ -1544,14 +1610,14 @@ Editor::toggle_marker_lines ()
 }
 
 void
-Editor::remove_sorted_marker (Marker* m)
+Editor::remove_sorted_marker (ArdourMarker* m)
 {
-       for (std::map<ArdourCanvas::Group *, std::list<Marker *> >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) {
+       for (std::map<ArdourCanvas::Container *, std::list<ArdourMarker *> >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) {
                i->second.remove (m);
        }
 }
 
-Marker *
+ArdourMarker *
 Editor::find_marker_from_location_id (PBD::ID const & id, bool is_start) const
 {
        for (LocationMarkerMap::const_iterator i = location_markers.begin(); i != location_markers.end(); ++i) {