reinstate (de)selection operations that should happen on mouse button release
[ardour.git] / gtk2_ardour / editor_mouse.cc
index 13bdf7af5ca54560c8c649b07098ef8bf005daaa..034619c9321441c4e4fbde9f37db8660571e30bd 100644 (file)
 
 #include "pbd/error.h"
 #include "pbd/enumwriter.h"
-#include <gtkmm2ext/utils.h>
-#include <gtkmm2ext/tearoff.h>
 #include "pbd/memento_command.h"
 #include "pbd/basename.h"
+#include "pbd/stateful_diff_command.h"
+
+#include "gtkmm2ext/bindings.h"
+#include "gtkmm2ext/utils.h"
+#include "gtkmm2ext/tearoff.h"
 
 #include "ardour_ui.h"
 #include "actions.h"
+#include "canvas-note.h"
 #include "editor.h"
 #include "time_axis_view.h"
 #include "audio_time_axis.h"
 #include "rgb_macros.h"
 #include "control_point_dialog.h"
 #include "editor_drag.h"
+#include "automation_region_view.h"
+#include "edit_note_dialog.h"
+#include "mouse_cursors.h"
+#include "editor_cursors.h"
 
 #include "ardour/types.h"
 #include "ardour/profile.h"
@@ -68,6 +76,7 @@
 #include "ardour/region_factory.h"
 #include "ardour/source_factory.h"
 #include "ardour/session.h"
+#include "ardour/operations.h"
 
 #include <bitset>
 
@@ -81,7 +90,7 @@ using namespace Editing;
 using Gtkmm2ext::Keyboard;
 
 bool
-Editor::mouse_frame (nframes64_t& where, bool& in_track_canvas) const
+Editor::mouse_frame (framepos_t& where, bool& in_track_canvas) const
 {
        int x, y;
        double wx, wy;
@@ -114,7 +123,7 @@ Editor::mouse_frame (nframes64_t& where, bool& in_track_canvas) const
        return true;
 }
 
-nframes64_t
+framepos_t
 Editor::event_frame (GdkEvent const * event, double* pcx, double* pcy) const
 {
        double cx, cy;
@@ -167,20 +176,20 @@ Editor::event_frame (GdkEvent const * event, double* pcx, double* pcy) const
 Gdk::Cursor*
 Editor::which_grabber_cursor ()
 {
-       Gdk::Cursor* c = grabber_cursor;
+       Gdk::Cursor* c = _cursors->grabber;
 
        if (_internal_editing) {
                switch (mouse_mode) {
                case MouseRange:
-                       c = midi_pencil_cursor;
+                       c = _cursors->midi_pencil;
                        break;
 
                case MouseObject:
-                       c = grabber_cursor;
+                       c = _cursors->grabber_note;
                        break;
 
                case MouseTimeFX:
-                       c = midi_resize_cursor;
+                       c = _cursors->midi_resize;
                        break;
 
                default:
@@ -191,9 +200,13 @@ Editor::which_grabber_cursor ()
 
                switch (_edit_point) {
                case EditAtMouse:
-                       c = grabber_edit_point_cursor;
+                       c = _cursors->grabber_edit_point;
                        break;
                default:
+                       boost::shared_ptr<Movable> m = _movable.lock();
+                       if (m && m->locked()) {
+                               c = _cursors->speaker;
+                       } 
                        break;
                }
        }
@@ -201,6 +214,28 @@ Editor::which_grabber_cursor ()
        return c;
 }
 
+void
+Editor::set_current_trimmable (boost::shared_ptr<Trimmable> t)
+{
+       boost::shared_ptr<Trimmable> st = _trimmable.lock();
+
+       if (!st || st == t) {
+               _trimmable = t;
+               set_canvas_cursor ();
+       }
+}
+
+void
+Editor::set_current_movable (boost::shared_ptr<Movable> m)
+{
+       boost::shared_ptr<Movable> sm = _movable.lock();
+
+       if (!sm || sm != m) {
+               _movable = m;
+               set_canvas_cursor ();
+       }
+}
+
 void
 Editor::set_canvas_cursor ()
 {
@@ -208,7 +243,7 @@ Editor::set_canvas_cursor ()
 
                switch (mouse_mode) {
                case MouseRange:
-                       current_canvas_cursor = midi_pencil_cursor;
+                       current_canvas_cursor = _cursors->midi_pencil;
                        break;
 
                case MouseObject:
@@ -216,7 +251,7 @@ Editor::set_canvas_cursor ()
                        break;
 
                case MouseTimeFX:
-                       current_canvas_cursor = midi_resize_cursor;
+                       current_canvas_cursor = _cursors->midi_resize;
                        break;
 
                default:
@@ -227,7 +262,7 @@ Editor::set_canvas_cursor ()
 
                switch (mouse_mode) {
                case MouseRange:
-                       current_canvas_cursor = selector_cursor;
+                       current_canvas_cursor = _cursors->selector;
                        break;
 
                case MouseObject:
@@ -235,19 +270,23 @@ Editor::set_canvas_cursor ()
                        break;
 
                case MouseGain:
-                       current_canvas_cursor = cross_hair_cursor;
+                       current_canvas_cursor = _cursors->cross_hair;
                        break;
 
                case MouseZoom:
-                       current_canvas_cursor = zoom_cursor;
+                       if (Keyboard::the_keyboard().key_is_down (GDK_Control_L)) {
+                               current_canvas_cursor = _cursors->zoom_out;
+                       } else {
+                               current_canvas_cursor = _cursors->zoom_in;
+                       }
                        break;
 
                case MouseTimeFX:
-                       current_canvas_cursor = time_fx_cursor; // just use playhead
+                       current_canvas_cursor = _cursors->time_fx; // just use playhead
                        break;
 
                case MouseAudition:
-                       current_canvas_cursor = speaker_cursor;
+                       current_canvas_cursor = _cursors->speaker;
                        break;
                }
        }
@@ -259,13 +298,21 @@ Editor::set_canvas_cursor ()
                current_canvas_cursor = which_grabber_cursor ();
                break;
        case JOIN_OBJECT_RANGE_RANGE:
-               current_canvas_cursor = selector_cursor;
+               current_canvas_cursor = _cursors->selector;
                break;
        }
 
-       if (is_drawable()) {
-               track_canvas->get_window()->set_cursor(*current_canvas_cursor);
+       /* up-down cursor as a cue that automation can be dragged up and down when in join object/range mode */
+       if (join_object_range_button.get_active() && last_item_entered) {
+               if (last_item_entered->property_parent() && (*last_item_entered->property_parent()).get_data (X_("timeselection"))) {
+                       pair<TimeAxisView*, int> tvp = trackview_by_y_position (_last_motion_y + vertical_adjustment.get_value() - canvas_timebars_vsize);
+                       if (dynamic_cast<AutomationTimeAxisView*> (tvp.first)) {
+                               current_canvas_cursor = _cursors->up_down;
+                       }
+               }
        }
+
+       set_canvas_cursor (current_canvas_cursor, true);
 }
 
 void
@@ -315,6 +362,8 @@ Editor::set_mouse_mode (MouseMode m, bool force)
        /* go there and back to ensure that the toggled handler is called to set up mouse_mode */
        tact->set_active (false);
        tact->set_active (true);
+
+       MouseModeChanged (); /* EMIT SIGNAL */
 }
 
 void
@@ -323,32 +372,33 @@ Editor::mouse_mode_toggled (MouseMode m)
        mouse_mode = m;
 
        instant_save ();
-
-       if (mouse_mode != MouseRange && _join_object_range_state == JOIN_OBJECT_RANGE_NONE) {
-
-               /* in all modes except range and joined object/range, hide the range selection,
-                  show the object (region) selection.
-               */
-
-               for (RegionSelection::iterator i = selection->regions.begin(); i != selection->regions.end(); ++i) {
-                       (*i)->set_should_show_selection (true);
-               }
-               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                       (*i)->hide_selection ();
-               }
-
-       } else {
-
-               /*
-                  in range or object/range mode, show the range selection.
-               */
-
-               for (TrackSelection::iterator i = selection->tracks.begin(); i != selection->tracks.end(); ++i) {
-                       (*i)->show_selection (selection->time);
+        
+       if (!internal_editing()) {
+               if (mouse_mode != MouseRange && _join_object_range_state == JOIN_OBJECT_RANGE_NONE) {
+                        
+                       /* in all modes except range and joined object/range, hide the range selection,
+                          show the object (region) selection.
+                       */
+                        
+                       for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
+                               (*i)->hide_selection ();
+                       }
+                        
+               } else {
+                        
+                       /*
+                         in range or object/range mode, show the range selection.
+                       */
+                        
+                       for (TrackSelection::iterator i = selection->tracks.begin(); i != selection->tracks.end(); ++i) {
+                               (*i)->show_selection (selection->time);
+                       }
                }
        }
 
        set_canvas_cursor ();
+
+       MouseModeChanged (); /* EMIT SIGNAL */
 }
 
 void
@@ -422,6 +472,10 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
           region alignment.
 
           note: not dbl-click or triple-click
+
+          Also note that there is no region selection in internal edit mode, otherwise
+          for operations operating on the selection (e.g. cut) it is not obvious whether
+          to cut notes or regions.
        */
 
        if (((mouse_mode != MouseObject) &&
@@ -430,8 +484,8 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
             (mouse_mode != MouseTimeFX || item_type != RegionItem) &&
             (mouse_mode != MouseGain) &&
             (mouse_mode != MouseRange)) ||
-
-           ((event->type != GDK_BUTTON_PRESS && event->type != GDK_BUTTON_RELEASE) || event->button.button > 3)) {
+           ((event->type != GDK_BUTTON_PRESS && event->type != GDK_BUTTON_RELEASE) || event->button.button > 3) ||
+           internal_editing()) {
 
                return;
        }
@@ -451,28 +505,27 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        Selection::Operation op = ArdourKeyboard::selection_type (event->button.state);
        bool press = (event->type == GDK_BUTTON_PRESS);
 
-       // begin_reversible_command (_("select on click"));
-
        switch (item_type) {
        case RegionItem:
                if (mouse_mode != MouseRange || _join_object_range_state == JOIN_OBJECT_RANGE_OBJECT) {
                        set_selected_regionview_from_click (press, op, true);
                } else if (event->type == GDK_BUTTON_PRESS) {
                        selection->clear_tracks ();
-                       set_selected_track_as_side_effect (true);
+                       set_selected_track_as_side_effect (op, true);
                }
                if (_join_object_range_state == JOIN_OBJECT_RANGE_OBJECT && !selection->regions.empty()) {
                        clicked_selection = select_range_around_region (selection->regions.front());
                }
-                       
                break;
 
        case RegionViewNameHighlight:
        case RegionViewName:
+       case LeftFrameHandle:
+       case RightFrameHandle:
                if (mouse_mode != MouseRange || _join_object_range_state == JOIN_OBJECT_RANGE_OBJECT) {
                        set_selected_regionview_from_click (press, op, true);
                } else if (event->type == GDK_BUTTON_PRESS) {
-                       set_selected_track_as_side_effect ();
+                       set_selected_track_as_side_effect (op);
                }
                break;
 
@@ -484,12 +537,12 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
                if (mouse_mode != MouseRange || _join_object_range_state == JOIN_OBJECT_RANGE_OBJECT) {
                        set_selected_regionview_from_click (press, op, true);
                } else if (event->type == GDK_BUTTON_PRESS) {
-                       set_selected_track_as_side_effect ();
+                       set_selected_track_as_side_effect (op);
                }
                break;
 
        case ControlPointItem:
-               set_selected_track_as_side_effect ();
+               set_selected_track_as_side_effect (op, true);
                if (mouse_mode != MouseRange || _join_object_range_state == JOIN_OBJECT_RANGE_OBJECT) {
                        set_selected_control_point_from_click (op, false);
                }
@@ -498,12 +551,13 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        case StreamItem:
                /* for context click, select track */
                if (event->button.button == 3) {
-                       set_selected_track_as_side_effect ();
+                       selection->clear_tracks ();
+                       set_selected_track_as_side_effect (op, true);
                }
                break;
 
        case AutomationTrackItem:
-               set_selected_track_as_side_effect (true);
+               set_selected_track_as_side_effect (op, true);
                break;
 
        default:
@@ -514,10 +568,6 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
 bool
 Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
-       if (_drags->active ()) {
-               _drags->abort ();
-       }
-
        /* single mouse clicks on any of these item types operate
           independent of mouse mode, mostly because they are
           not on the main track canvas or because we want
@@ -634,10 +684,10 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                case SelectionItem:
                        if (Keyboard::modifier_state_contains
-                           (event->button.state, Keyboard::ModifierMask(Keyboard::SecondaryModifier))) {
+                           (event->button.state, Keyboard::ModifierMask(Keyboard::PrimaryModifier))) {
                                // contains and not equals because I can't use alt as a modifier alone.
                                start_selection_grab (item, event);
-                       } else if (Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)) {
+                       } else if (Keyboard::modifier_state_equals (event->button.state, Keyboard::SecondaryModifier)) {
                                /* grab selection for moving */
                                _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionMove), event);
                        } else {
@@ -647,7 +697,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                        AutomationTimeAxisView* atv = dynamic_cast<AutomationTimeAxisView*> (tvp.first);
                                        if (join_object_range_button.get_active() && atv) {
                                                /* smart "join" mode: drag automation */
-                                               _drags->set (new AutomationRangeDrag (this, atv->base_item(), selection->time), event);
+                                               _drags->set (new AutomationRangeDrag (this, atv->base_item(), selection->time), event, _cursors->up_down);
                                        } else {
                                                /* this was debated, but decided the more common action was to
                                                   make a new selection */
@@ -657,8 +707,51 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        }
                        break;
 
+               case NoteItem:
+                       if (internal_editing()) {
+                               /* trim notes if we're in internal edit mode and near the ends of the note */
+                               ArdourCanvas::CanvasNote* cn = dynamic_cast<ArdourCanvas::CanvasNote*> (item);
+                               if (cn->big_enough_to_trim() && cn->mouse_near_ends()) {
+                                       _drags->set (new NoteResizeDrag (this, item), event, current_canvas_cursor);
+                               } else {
+                                       _drags->set (new NoteDrag (this, item), event);
+                               }
+                       }
+                       return true;
+
+               case StreamItem:
+                       if (internal_editing()) {
+                               if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
+                                       _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
+                                       return true;
+                               }
+                       } else {
+                               _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                               return true;
+                       }
+                       break;
+
+               case RegionViewNameHighlight:
+                       if (!clicked_regionview->region()->locked()) {
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
+                               return true;
+                       }
+                       break;
+
+               case LeftFrameHandle:
+               case RightFrameHandle:
+                       if (!internal_editing() && !clicked_regionview->region()->locked()) {
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
+                               return true;
+                       }
+                       break;
+
                default:
-                       _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                       if (!internal_editing()) {
+                               _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                       }
                }
                return true;
                break;
@@ -667,8 +760,12 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                switch (item_type) {
                case NoteItem:
                        if (internal_editing()) {
-                               /* Note: we don't get here if not in internal_editing() mode */
-                               _drags->set (new NoteDrag (this, item), event);
+                               ArdourCanvas::CanvasNoteEvent* cn = dynamic_cast<ArdourCanvas::CanvasNoteEvent*> (item);
+                               if (cn->mouse_near_ends()) {
+                                       _drags->set (new NoteResizeDrag (this, item), event, current_canvas_cursor);
+                               } else {
+                                       _drags->set (new NoteDrag (this, item), event);
+                               }
                                return true;
                        }
                        break;
@@ -687,19 +784,44 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        switch (item_type) {
                        case FadeInHandleItem:
                        {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.id);
-                               _drags->set (new FadeInDrag (this, item, reinterpret_cast<RegionView*> (item->get_data("regionview")), s), event);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               _drags->set (new FadeInDrag (this, item, reinterpret_cast<RegionView*> (item->get_data("regionview")), s), event, _cursors->fade_in);
                                return true;
                        }
 
                        case FadeOutHandleItem:
                        {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.id);
-                               _drags->set (new FadeOutDrag (this, item, reinterpret_cast<RegionView*> (item->get_data("regionview")), s), event);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               _drags->set (new FadeOutDrag (this, item, reinterpret_cast<RegionView*> (item->get_data("regionview")), s), event, _cursors->fade_out);
+                               return true;
+                       }
+
+                       case FeatureLineItem:
+                       {                       
+                               if (Keyboard::modifier_state_contains (event->button.state, Keyboard::TertiaryModifier)) {
+                                       remove_transient(item);
+                                       return true;
+                               }
+                               
+                               _drags->set (new FeatureLineDrag (this, item), event);
                                return true;
+                               break;
                        }
 
                        case RegionItem:
+                               if (dynamic_cast<AutomationRegionView*> (clicked_regionview)) {
+                                       /* click on an automation region view; do nothing here and let the ARV's signal handler
+                                          sort it out.
+                                       */
+                                       break;
+                               }
+
+                               if (internal_editing ()) {
+                                       /* no region drags in internal edit mode */
+                                       break;
+                               }
+                               
+                               /* click on a normal region view */
                                if (Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)) {
                                        add_region_copy_drag (item, event, clicked_regionview);
                                } else if (Keyboard::the_keyboard().key_is_down (GDK_b)) {
@@ -707,7 +829,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                } else {
                                        add_region_drag (item, event, clicked_regionview);
                                }
-
+                               
                                if (_join_object_range_state == JOIN_OBJECT_RANGE_OBJECT && !selection->regions.empty()) {
                                        _drags->add (new SelectionDrag (this, clicked_axisview->get_selection_rect (clicked_selection)->rect, SelectionDrag::SelectionMove));
                                }
@@ -716,17 +838,19 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                break;
 
                        case RegionViewNameHighlight:
-                       {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.id);
-                               _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
-                               return true;
+                       case LeftFrameHandle:
+                        case RightFrameHandle:
+                               if (!clicked_regionview->region()->locked()) {
+                                       RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                                       _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
+                                       return true;
+                               }
                                break;
-                       }
 
                        case RegionViewName:
                        {
                                /* rename happens on edit clicks */
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.id);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
                                _drags->set (new TrimDrag (this, clicked_regionview->get_name_highlight(), clicked_regionview, s.by_layer()), event);
                                return true;
                                break;
@@ -744,7 +868,9 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                        case StreamItem:
                                if (internal_editing()) {
-                                       _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
+                                       if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
+                                               _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
+                                       }
                                        return true;
                                } else {
                                        _drags->set (new RubberbandSelectDrag (this, item), event);
@@ -766,7 +892,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                                /* if we're over an automation track, start a drag of its data */
                                                AutomationTimeAxisView* atv = dynamic_cast<AutomationTimeAxisView*> (tvp.first);
                                                if (atv) {
-                                                       _drags->set (new AutomationRangeDrag (this, atv->base_item(), selection->time), event);
+                                                       _drags->set (new AutomationRangeDrag (this, atv->base_item(), selection->time), event, _cursors->up_down);
                                                }
 
                                                /* if we're over a track and a region, and in the `object' part of a region,
@@ -776,7 +902,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                                if (rtv && _join_object_range_state == JOIN_OBJECT_RANGE_OBJECT) {
                                                        boost::shared_ptr<Track> t = boost::dynamic_pointer_cast<Track> (rtv->route ());
                                                        if (t) {
-                                                               boost::shared_ptr<Playlist> pl = t->diskstream()->playlist ();
+                                                               boost::shared_ptr<Playlist> pl = t->playlist ();
                                                                if (pl) {
                                                                        
                                                                        boost::shared_ptr<Region> r = pl->top_region_at (event_frame (event));
@@ -888,9 +1014,11 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case MouseTimeFX:
                if (internal_editing() && item_type == NoteItem) {
-                       _drags->set (new NoteResizeDrag (this, item), event);
+                       /* drag notes if we're in internal edit mode */
+                       _drags->set (new NoteResizeDrag (this, item), event, current_canvas_cursor);
                        return true;
-               } else if (!internal_editing() && item_type == RegionItem) {
+               } else if ((!internal_editing() || dynamic_cast<AudioRegionView*> (clicked_regionview)) && clicked_regionview) {
+                       /* do time-FX if we're not in internal edit mode, or we are but we clicked on an audio region */
                        _drags->set (new TimeFXDrag (this, item, clicked_regionview, selection->regions.by_layer()), event);
                        return true;
                }
@@ -902,7 +1030,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                scrub_reverse_distance = 0;
                last_scrub_x = event->button.x;
                scrubbing_direction = 0;
-               track_canvas->get_window()->set_cursor (*transparent_cursor);
+               set_canvas_cursor (_cursors->transparent);
                return true;
                break;
 
@@ -940,7 +1068,15 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                switch (item_type) {
                case RegionViewNameHighlight:
-                       _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer()), event);
+                        _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer()), event);
+                        return true;
+                        break;
+
+                case LeftFrameHandle:
+                case RightFrameHandle:
+                       if (!internal_editing ()) {
+                               _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer()), event);
+                       }
                        return true;
                        break;
 
@@ -963,7 +1099,7 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case MouseZoom:
                if (Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)) {
-                       temporal_zoom_session();
+                       temporal_zoom_to_frame (false, event_frame (event));
                } else {
                        temporal_zoom_to_frame (true, event_frame(event));
                }
@@ -996,12 +1132,11 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
 
                if (pointer_window == track_canvas->get_bin_window()) {
                        track_canvas->window_to_world (x, y, wx, wy);
-                       allow_vertical_scroll = true;
-               } else {
-                       allow_vertical_scroll = false;
                }
        }
 
+        pre_press_cursor = current_canvas_cursor;
+
        track_canvas->grab_focus();
 
        if (_session && _session->actively_recording()) {
@@ -1032,6 +1167,7 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                break;
 
        default:
+                return button_press_dispatch (&event->button);
                break;
 
        }
@@ -1039,19 +1175,44 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
        return false;
 }
 
+bool
+Editor::button_press_dispatch (GdkEventButton* ev)
+{
+        /* this function is intended only for buttons 4 and above.
+         */
+
+        Gtkmm2ext::MouseButton b (ev->state, ev->button);
+        return button_bindings->activate (b, Gtkmm2ext::Bindings::Press);
+}
+
+bool
+Editor::button_release_dispatch (GdkEventButton* ev)
+{
+        /* this function is intended only for buttons 4 and above.
+         */
+
+        Gtkmm2ext::MouseButton b (ev->state, ev->button);
+        return button_bindings->activate (b, Gtkmm2ext::Bindings::Release);
+}
+
 bool
 Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
-       nframes64_t where = event_frame (event, 0, 0);
+       framepos_t where = event_frame (event, 0, 0);
        AutomationTimeAxisView* atv = 0;
 
+        if (pre_press_cursor) {
+                set_canvas_cursor (pre_press_cursor);
+                pre_press_cursor = 0;
+        }
+
        /* no action if we're recording */
 
        if (_session && _session->actively_recording()) {
                return true;
        }
 
-       /* first, see if we're finishing a drag ... */
+       /* see if we're finishing a drag */
 
        bool were_dragging = false;
        if (_drags->active ()) {
@@ -1064,14 +1225,14 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                were_dragging = true;
        }
 
-       button_selection (item, event, item_type);
+        update_region_layering_order_editor ();
 
        /* edit events get handled here */
 
        if (!_drags->active () && Keyboard::is_edit_event (&event->button)) {
                switch (item_type) {
                case RegionItem:
-                       edit_region ();
+                       show_region_properties ();
                        break;
 
                case TempoMarkerItem:
@@ -1092,6 +1253,10 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        edit_control_point (item);
                        break;
 
+               case NoteItem:
+                       edit_note (item);
+                       break;
+
                default:
                        break;
                }
@@ -1117,21 +1282,23 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                break;
 
                        case StreamItem:
-                               popup_track_context_menu (1, event->button.time, item_type, false, where);
+                               popup_track_context_menu (1, event->button.time, item_type, false);
                                break;
 
                        case RegionItem:
                        case RegionViewNameHighlight:
+                       case LeftFrameHandle:
+                       case RightFrameHandle:
                        case RegionViewName:
-                               popup_track_context_menu (1, event->button.time, item_type, false, where);
+                               popup_track_context_menu (1, event->button.time, item_type, false);
                                break;
 
                        case SelectionItem:
-                               popup_track_context_menu (1, event->button.time, item_type, true, where);
+                               popup_track_context_menu (1, event->button.time, item_type, true);
                                break;
 
                        case AutomationTrackItem:
-                               popup_track_context_menu (1, event->button.time, item_type, false, where);
+                               popup_track_context_menu (1, event->button.time, item_type, false);
                                break;
 
                        case MarkerBarItem:
@@ -1148,15 +1315,15 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                break;
 
                        case TempoMarkerItem:
-                               tm_marker_context_menu (&event->button, item);
+                               tempo_or_meter_marker_context_menu (&event->button, item);
                                break;
 
                        case MeterMarkerItem:
-                               tm_marker_context_menu (&event->button, item);
+                               tempo_or_meter_marker_context_menu (&event->button, item);
                                break;
 
                        case CrossfadeViewItem:
-                               popup_track_context_menu (1, event->button.time, item_type, false, where);
+                               popup_track_context_menu (1, event->button.time, item_type, false);
                                break;
 
 #ifdef WITH_CMT
@@ -1215,6 +1382,10 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        }
                        break;
 
+               case NoteItem:
+                       remove_midi_note (item, event);
+                       break;
+
                default:
                        break;
                }
@@ -1284,23 +1455,20 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case MouseGain:
-                       // Gain only makes sense for audio regions
-
-                       if (!dynamic_cast<AudioRegionView*>(clicked_regionview)) {
-                               break;
-                       }
-
                        switch (item_type) {
                        case RegionItem:
+                       {
                                /* check that we didn't drag before releasing, since
                                   its really annoying to create new control
                                   points when doing this.
                                */
-                               if (were_dragging) {
-                                       dynamic_cast<AudioRegionView*>(clicked_regionview)->add_gain_point_event (item, event);
+                               AudioRegionView* arv = dynamic_cast<AudioRegionView*> (clicked_regionview);
+                               if (were_dragging && arv) {
+                                       arv->add_gain_point_event (item, event);
                                }
                                return true;
                                break;
+                       }
 
                        case AutomationTrackItem:
                                dynamic_cast<AutomationTimeAxisView*>(clicked_axisview)->
@@ -1313,7 +1481,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case MouseAudition:
-                       track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                       set_canvas_cursor (current_canvas_cursor);
                        if (scrubbing_direction == 0) {
                                /* no drag, just a click */
                                switch (item_type) {
@@ -1331,9 +1499,11 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                default:
                        break;
-
+                        
                }
 
+                /* do any (de)selection operations that should occur on button release */
+                button_selection (item, event, item_type);
                return true;
                break;
 
@@ -1378,6 +1548,9 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        default:
                break;
        }
+
+        cerr << "button release hits bottom\n";
+
        return false;
 }
 
@@ -1387,11 +1560,9 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        ControlPoint* cp;
        Marker * marker;
        double fraction;
+        bool ret = true;
 
-       if (last_item_entered != item) {
-               last_item_entered = item;
-               last_item_entered_n = 0;
-       }
+       last_item_entered = item;
 
        switch (item_type) {
        case ControlPointItem:
@@ -1409,14 +1580,11 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                        fraction = 1.0 - (cp->get_y() / cp->line().height());
 
                        if (is_drawable() && !_drags->active ()) {
-                               track_canvas->get_window()->set_cursor (*fader_cursor);
+                               set_canvas_cursor (_cursors->fader);
                        }
 
-                       last_item_entered_n++;
                        set_verbose_canvas_cursor (cp->line().get_verbose_cursor_string (fraction), at_x, at_y);
-                       if (last_item_entered_n < 10) {
-                               show_verbose_canvas_cursor ();
-                       }
+                       show_verbose_canvas_cursor ();
                }
                break;
 
@@ -1426,7 +1594,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                        if (line)
                                line->property_fill_color_rgba() = ARDOUR_UI::config()->canvasvar_EnteredGainLine.get();
                        if (is_drawable()) {
-                               track_canvas->get_window()->set_cursor (*fader_cursor);
+                               set_canvas_cursor (_cursors->fader);
                        }
                }
                break;
@@ -1439,17 +1607,25 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                                        line->property_fill_color_rgba() = ARDOUR_UI::config()->canvasvar_EnteredAutomationLine.get();
                        }
                        if (is_drawable()) {
-                               track_canvas->get_window()->set_cursor (*fader_cursor);
+                               set_canvas_cursor (_cursors->fader);
                        }
                }
                break;
 
        case RegionViewNameHighlight:
-               if (is_drawable() && mouse_mode == MouseObject) {
-                       track_canvas->get_window()->set_cursor (*trimmer_cursor);
+               if (is_drawable() && mouse_mode == MouseObject && entered_regionview) {
+                       set_canvas_cursor_for_region_view (event->crossing.x, entered_regionview);
+                       _over_region_trim_target = true;
                }
                break;
 
+       case LeftFrameHandle:
+       case RightFrameHandle:
+               if (is_drawable() && mouse_mode == MouseObject && !internal_editing() && entered_regionview) {
+                       set_canvas_cursor_for_region_view (event->crossing.x, entered_regionview);
+               }
+                break;
+
        case StartSelectionTrimItem:
        case EndSelectionTrimItem:
 
@@ -1461,7 +1637,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 #endif
 
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*trimmer_cursor);
+                       set_canvas_cursor (_cursors->trimmer);
                }
                break;
 
@@ -1469,10 +1645,10 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                if (is_drawable()) {
                        switch (_edit_point) {
                        case EditAtMouse:
-                               track_canvas->get_window()->set_cursor (*grabber_edit_point_cursor);
+                               set_canvas_cursor (_cursors->grabber_edit_point);
                                break;
                        default:
-                               track_canvas->get_window()->set_cursor (*grabber_cursor);
+                               set_canvas_cursor (_cursors->grabber);
                                break;
                        }
                }
@@ -1484,7 +1660,8 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 
                if (!reinterpret_cast<RegionView *> (item->get_data ("regionview"))->name_active()) {
                        if (mouse_mode == MouseObject && is_drawable()) {
-                               track_canvas->get_window()->set_cursor (*trimmer_cursor);
+                               set_canvas_cursor_for_region_view (event->crossing.x, entered_regionview);
+                               _over_region_trim_target = true;
                        }
                }
                break;
@@ -1495,17 +1672,17 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                        Gdk::Cursor *cursor;
                        switch (mouse_mode) {
                        case MouseRange:
-                               cursor = selector_cursor;
+                               cursor = _cursors->selector;
                                break;
                        case MouseZoom:
-                               cursor = zoom_cursor;
+                               cursor = _cursors->zoom_in;
                                break;
                        default:
-                               cursor = cross_hair_cursor;
+                               cursor = _cursors->cross_hair;
                                break;
                        }
 
-                       track_canvas->get_window()->set_cursor (*cursor);
+                       set_canvas_cursor (cursor);
 
                        AutomationTimeAxisView* atv;
                        if ((atv = static_cast<AutomationTimeAxisView*>(item->get_data ("trackview"))) != 0) {
@@ -1522,7 +1699,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        case MeterBarItem:
        case TempoBarItem:
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*timebar_cursor);
+                       set_canvas_cursor (_cursors->timebar);
                }
                break;
 
@@ -1536,21 +1713,41 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        case MeterMarkerItem:
        case TempoMarkerItem:
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*timebar_cursor);
+                       set_canvas_cursor (_cursors->timebar);
                }
                break;
+
        case FadeInHandleItem:
-       case FadeOutHandleItem:
-               if (mouse_mode == MouseObject) {
+               if (mouse_mode == MouseObject && !internal_editing()) {
                        ArdourCanvas::SimpleRect *rect = dynamic_cast<ArdourCanvas::SimpleRect *> (item);
                        if (rect) {
-                               rect->property_fill_color_rgba() = 0;
-                               rect->property_outline_pixels() = 1;
+                               rect->property_fill_color_rgba() = 0xBBBBBBAA;
                        }
-                       track_canvas->get_window()->set_cursor (*grabber_cursor);
+                       set_canvas_cursor (_cursors->fade_in);
                }
                break;
 
+       case FadeOutHandleItem:
+               if (mouse_mode == MouseObject && !internal_editing()) {
+                       ArdourCanvas::SimpleRect *rect = dynamic_cast<ArdourCanvas::SimpleRect *> (item);
+                       if (rect) {
+                               rect->property_fill_color_rgba() = 0xBBBBBBAA;
+                       }
+                       set_canvas_cursor (_cursors->fade_out);
+               }
+               break;
+       case FeatureLineItem:
+               {
+                       ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
+                       line->property_fill_color_rgba() = 0xFF0000FF;
+               }
+               break;
+       case SelectionItem:
+               if (join_object_range_button.get_active()) {
+                       set_canvas_cursor ();
+               }
+               break;
+               
        default:
                break;
        }
@@ -1575,7 +1772,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                break;
        }
 
-       return false;
+       return ret;
 }
 
 bool
@@ -1587,24 +1784,27 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        Location *loc;
        RegionView* rv;
        bool is_start;
+       bool ret = true;
 
        switch (item_type) {
        case ControlPointItem:
                cp = reinterpret_cast<ControlPoint*>(item->get_data ("control_point"));
                if (cp->line().the_list()->interpolation() != AutomationList::Discrete) {
-                       if (cp->line().npoints() > 1 && !cp->selected()) {
+                       if (cp->line().npoints() > 1 && !cp->get_selected()) {
                                cp->set_visible (false);
                        }
                }
 
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                       set_canvas_cursor (current_canvas_cursor);
                }
 
                hide_verbose_canvas_cursor ();
                break;
 
        case RegionViewNameHighlight:
+       case LeftFrameHandle:
+       case RightFrameHandle:
        case StartSelectionTrimItem:
        case EndSelectionTrimItem:
        case PlayheadCursorItem:
@@ -1616,8 +1816,10 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        case MarkerViewHandleEndItem:
 #endif
 
+               _over_region_trim_target = false;
+               
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                       set_canvas_cursor (current_canvas_cursor);
                }
                break;
 
@@ -1630,15 +1832,17 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                                line->property_fill_color_rgba() = al->get_line_color();
                }
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                       set_canvas_cursor (current_canvas_cursor);
                }
                break;
 
        case RegionViewName:
                /* see enter_handler() for notes */
+               _over_region_trim_target = false;
+               
                if (!reinterpret_cast<RegionView *> (item->get_data ("regionview"))->name_active()) {
                        if (is_drawable() && mouse_mode == MouseObject) {
-                               track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                               set_canvas_cursor (current_canvas_cursor);
                        }
                }
                break;
@@ -1650,7 +1854,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        case TempoBarItem:
        case MarkerBarItem:
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                       set_canvas_cursor (current_canvas_cursor);
                }
                break;
 
@@ -1667,7 +1871,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        case TempoMarkerItem:
 
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*timebar_cursor);
+                       set_canvas_cursor (_cursors->timebar);
                }
 
                break;
@@ -1682,22 +1886,28 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                                rect->property_outline_pixels() = 0;
                        }
                }
-               track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+               set_canvas_cursor (current_canvas_cursor);
                break;
 
        case AutomationTrackItem:
                if (is_drawable()) {
-                       track_canvas->get_window()->set_cursor (*current_canvas_cursor);
+                       set_canvas_cursor (current_canvas_cursor);
                        clear_entered_track = true;
                        Glib::signal_idle().connect (sigc::mem_fun(*this, &Editor::left_automation_track));
                }
                break;
+       case FeatureLineItem:
+               {
+                       ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
+                       line->property_fill_color_rgba() = (guint) ARDOUR_UI::config()->canvasvar_ZeroLine.get();;
+               }
+               break;
 
        default:
                break;
        }
 
-       return false;
+       return ret;
 }
 
 gint
@@ -1711,7 +1921,7 @@ Editor::left_automation_track ()
 }
 
 void
-Editor::scrub (nframes64_t frame, double current_x)
+Editor::scrub (framepos_t frame, double current_x)
 {
        double delta;
 
@@ -1742,7 +1952,7 @@ Editor::scrub (nframes64_t frame, double current_x)
                                scrub_reverse_distance = 0;
 
                                delta = 0.01 * (last_scrub_x - current_x);
-                               _session->request_transport_speed (_session->transport_speed() - delta);
+                               _session->request_transport_speed_nonzero (_session->transport_speed() - delta);
                        }
 
                } else {
@@ -1761,7 +1971,7 @@ Editor::scrub (nframes64_t frame, double current_x)
                                scrub_reverse_distance = 0;
 
                                delta = 0.01 * (current_x - last_scrub_x);
-                               _session->request_transport_speed (_session->transport_speed() + delta);
+                               _session->request_transport_speed_nonzero (_session->transport_speed() + delta);
                        }
                }
 
@@ -1792,6 +2002,8 @@ Editor::scrub (nframes64_t frame, double current_x)
 bool
 Editor::motion_handler (ArdourCanvas::Item* /*item*/, GdkEvent* event, bool from_autoscroll)
 {
+       _last_motion_y = event->motion.y;
+       
        if (event->motion.is_hint) {
                gint x, y;
 
@@ -1824,11 +2036,15 @@ Editor::motion_handler (ArdourCanvas::Item* /*item*/, GdkEvent* event, bool from
                set_canvas_cursor ();
        }
 
+       if (_over_region_trim_target) {
+               set_canvas_cursor_for_region_view (event->motion.x, entered_regionview);
+       }
+
        bool handled = false;
        if (_drags->active ()) {
                handled = _drags->motion_handler (event, from_autoscroll);
        }
-
+       
        if (!handled) {
                return false;
        }
@@ -1890,6 +2106,19 @@ Editor::edit_control_point (ArdourCanvas::Item* item)
        p->line().modify_point_y (*p, d.get_y_fraction ());
 }
 
+void
+Editor::edit_note (ArdourCanvas::Item* item)
+{
+       ArdourCanvas::CanvasNoteEvent* e = dynamic_cast<ArdourCanvas::CanvasNoteEvent*> (item);
+       assert (e);
+
+       EditNoteDialog d (&e->region_view(), e);
+       d.set_position (Gtk::WIN_POS_MOUSE);
+       ensure_float (d);
+
+       d.run ();
+}
+       
 
 void
 Editor::visible_order_range (int* low, int* high) const
@@ -1926,37 +2155,37 @@ Editor::region_view_item_click (AudioRegionView& rv, GdkEventButton* event)
                RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*>(tv);
                double speed = 1.0;
                if (rtv && rtv->is_track()) {
-                       speed = rtv->get_diskstream()->speed();
+                       speed = rtv->track()->speed();
                }
 
-               nframes64_t where = get_preferred_edit_position();
+               framepos_t where = get_preferred_edit_position();
 
                if (where >= 0) {
 
                        if (Keyboard::modifier_state_equals (event->state, Keyboard::ModifierMask (Keyboard::PrimaryModifier|Keyboard::SecondaryModifier))) {
 
-                               align_region (rv.region(), SyncPoint, (nframes64_t) (where * speed));
+                               align_region (rv.region(), SyncPoint, (framepos_t) (where * speed));
 
                        } else if (Keyboard::modifier_state_equals (event->state, Keyboard::ModifierMask (Keyboard::PrimaryModifier|Keyboard::TertiaryModifier))) {
 
-                               align_region (rv.region(), End, (nframes64_t) (where * speed));
+                               align_region (rv.region(), End, (framepos_t) (where * speed));
 
                        } else {
 
-                               align_region (rv.region(), Start, (nframes64_t) (where * speed));
+                               align_region (rv.region(), Start, (framepos_t) (where * speed));
                        }
                }
        }
 }
 
 void
-Editor::show_verbose_time_cursor (nframes64_t frame, double offset, double xpos, double ypos)
+Editor::show_verbose_time_cursor (framepos_t frame, double offset, double xpos, double ypos)
 {
        char buf[128];
        Timecode::Time timecode;
-       BBT_Time bbt;
+       Timecode::BBT_Time bbt;
        int hours, mins;
-       nframes64_t frame_rate;
+       framepos_t frame_rate;
        float secs;
 
        if (_session == 0) {
@@ -1990,7 +2219,7 @@ Editor::show_verbose_time_cursor (nframes64_t frame, double offset, double xpos,
                mins = frame / (frame_rate * 60);
                frame = frame % (frame_rate * 60);
                secs = (float) frame / (float) frame_rate;
-               snprintf (buf, sizeof (buf), "%02" PRId32 ":%02" PRId32 ":%.4f", hours, mins, secs);
+               snprintf (buf, sizeof (buf), "%02" PRId32 ":%02" PRId32 ":%07.4f", hours, mins, secs);
                break;
 
        default:
@@ -2001,20 +2230,20 @@ Editor::show_verbose_time_cursor (nframes64_t frame, double offset, double xpos,
        if (xpos >= 0 && ypos >=0) {
                set_verbose_canvas_cursor (buf, xpos + offset, ypos + offset);
        } else {
-               set_verbose_canvas_cursor (buf, _drags->current_pointer_x() + offset - horizontal_adjustment.get_value(), _drags->current_pointer_y() + offset - vertical_adjustment.get_value() + canvas_timebars_vsize);
+               set_verbose_canvas_cursor (buf, _drags->current_pointer_x() + offset - horizontal_position(), _drags->current_pointer_y() + offset - vertical_adjustment.get_value() + canvas_timebars_vsize);
        }
        show_verbose_canvas_cursor ();
 }
 
 void
-Editor::show_verbose_duration_cursor (nframes64_t start, nframes64_t end, double offset, double xpos, double ypos)
+Editor::show_verbose_duration_cursor (framepos_t start, framepos_t end, double offset, double xpos, double ypos)
 {
        char buf[128];
        Timecode::Time timecode;
-       BBT_Time sbbt;
-       BBT_Time ebbt;
+       Timecode::BBT_Time sbbt;
+       Timecode::BBT_Time ebbt;
        int hours, mins;
-       nframes64_t distance, frame_rate;
+       framepos_t distance, frame_rate;
        float secs;
        Meter meter_at_start(_session->tempo_map().meter_at(start));
 
@@ -2051,7 +2280,7 @@ Editor::show_verbose_duration_cursor (nframes64_t start, nframes64_t end, double
                        ebbt.ticks -= sbbt.ticks;
                } else {
                        ebbt.beats--;
-                       ebbt.ticks = int(Meter::ticks_per_beat) + ebbt.ticks - sbbt.ticks;
+                       ebbt.ticks = int(Timecode::BBT_Time::ticks_per_beat) + ebbt.ticks - sbbt.ticks;
                }
 
                snprintf (buf, sizeof (buf), "%02" PRIu32 "|%02" PRIu32 "|%02" PRIu32, ebbt.bars, ebbt.beats, ebbt.ticks);
@@ -2071,7 +2300,7 @@ Editor::show_verbose_duration_cursor (nframes64_t start, nframes64_t end, double
                mins = distance / (frame_rate * 60);
                distance = distance % (frame_rate * 60);
                secs = (float) distance / (float) frame_rate;
-               snprintf (buf, sizeof (buf), "%02" PRId32 ":%02" PRId32 ":%.4f", hours, mins, secs);
+               snprintf (buf, sizeof (buf), "%02" PRId32 ":%02" PRId32 ":%07.4f", hours, mins, secs);
                break;
 
        default:
@@ -2115,168 +2344,14 @@ Editor::cancel_selection ()
 
 
 void
-Editor::single_contents_trim (RegionView& rv, nframes64_t frame_delta, bool left_direction, bool swap_direction, bool obey_snap)
-{
-       boost::shared_ptr<Region> region (rv.region());
-
-       if (region->locked()) {
-               return;
-       }
-
-       nframes64_t new_bound;
-
-       double speed = 1.0;
-       TimeAxisView* tvp = clicked_axisview;
-       RouteTimeAxisView* tv = dynamic_cast<RouteTimeAxisView*>(tvp);
-
-       if (tv && tv->is_track()) {
-               speed = tv->get_diskstream()->speed();
-       }
-
-       if (left_direction) {
-               if (swap_direction) {
-                       new_bound = (nframes64_t) (region->position()/speed) + frame_delta;
-               } else {
-                       new_bound = (nframes64_t) (region->position()/speed) - frame_delta;
-               }
-       } else {
-               if (swap_direction) {
-                       new_bound = (nframes64_t) (region->position()/speed) - frame_delta;
-               } else {
-                       new_bound = (nframes64_t) (region->position()/speed) + frame_delta;
-               }
-       }
-
-       if (obey_snap) {
-               snap_to (new_bound);
-       }
-       region->trim_start ((nframes64_t) (new_bound * speed), this);
-       rv.region_changed (PropertyChange (ARDOUR::Properties::start));
-}
-
-void
-Editor::single_start_trim (RegionView& rv, nframes64_t frame_delta, bool left_direction, bool obey_snap, bool no_overlap)
-{
-       boost::shared_ptr<Region> region (rv.region());
-
-       if (region->locked()) {
-               return;
-       }
-
-       nframes64_t new_bound;
-
-       double speed = 1.0;
-       TimeAxisView* tvp = clicked_axisview;
-       RouteTimeAxisView* tv = dynamic_cast<RouteTimeAxisView*>(tvp);
-
-       if (tv && tv->is_track()) {
-               speed = tv->get_diskstream()->speed();
-       }
-
-       if (left_direction) {
-               new_bound = (nframes64_t) (region->position()/speed) - frame_delta;
-       } else {
-               new_bound = (nframes64_t) (region->position()/speed) + frame_delta;
-       }
-
-       if (obey_snap) {
-               snap_to (new_bound, (left_direction ? 0 : 1));
-       }
-
-       nframes64_t pre_trim_first_frame = region->first_frame();
-
-       region->trim_front ((nframes64_t) (new_bound * speed), this);
-
-       if (no_overlap) {
-               //Get the next region on the left of this region and shrink/expand it.
-               boost::shared_ptr<Playlist> playlist (region->playlist());
-               boost::shared_ptr<Region> region_left = playlist->find_next_region (pre_trim_first_frame, End, 0);
-
-               bool regions_touching = false;
-
-               if (region_left != 0 && (pre_trim_first_frame == region_left->last_frame() + 1)){
-                   regions_touching = true;
-               }
-
-               //Only trim region on the left if the first frame has gone beyond the left region's last frame.
-               if (region_left != 0 &&
-                       (region_left->last_frame() > region->first_frame() || regions_touching))
-               {
-                       region_left->trim_end(region->first_frame() - 1, this);
-               }
-       }
-
-       rv.region_changed (ARDOUR::bounds_change);
-}
-
-void
-Editor::single_end_trim (RegionView& rv, nframes64_t frame_delta, bool left_direction, bool obey_snap, bool no_overlap)
-{
-       boost::shared_ptr<Region> region (rv.region());
-
-       if (region->locked()) {
-               return;
-       }
-
-       nframes64_t new_bound;
-
-       double speed = 1.0;
-       TimeAxisView* tvp = clicked_axisview;
-       RouteTimeAxisView* tv = dynamic_cast<RouteTimeAxisView*>(tvp);
-
-       if (tv && tv->is_track()) {
-               speed = tv->get_diskstream()->speed();
-       }
-
-       if (left_direction) {
-               new_bound = (nframes64_t) ((region->last_frame() + 1)/speed) - frame_delta;
-       } else {
-               new_bound = (nframes64_t) ((region->last_frame() + 1)/speed) + frame_delta;
-       }
-
-       if (obey_snap) {
-               snap_to (new_bound);
-       }
-
-       nframes64_t pre_trim_last_frame = region->last_frame();
-
-       region->trim_end ((nframes64_t) (new_bound * speed), this);
-
-       if (no_overlap) {
-               //Get the next region on the right of this region and shrink/expand it.
-               boost::shared_ptr<Playlist> playlist (region->playlist());
-               boost::shared_ptr<Region> region_right = playlist->find_next_region (pre_trim_last_frame, Start, 1);
-
-               bool regions_touching = false;
-
-               if (region_right != 0 && (pre_trim_last_frame == region_right->first_frame() - 1)){
-                   regions_touching = true;
-               }
-
-               //Only trim region on the right if the last frame has gone beyond the right region's first frame.
-               if (region_right != 0 &&
-                       (region_right->first_frame() < region->last_frame() || regions_touching))
-               {
-                       region_right->trim_front(region->last_frame() + 1, this);
-               }
-
-               rv.region_changed (ARDOUR::bounds_change);
-                       
-       } else {
-               rv.region_changed (PropertyChange (ARDOUR::Properties::length));
-       }
-}
-
-
-void
-Editor::point_trim (GdkEvent* event, nframes64_t new_bound)
+Editor::point_trim (GdkEvent* event, framepos_t new_bound)
 {
        RegionView* rv = clicked_regionview;
 
        /* Choose action dependant on which button was pressed */
        switch (event->button.button) {
        case 1:
-               begin_reversible_command (_("Start point trim"));
+               begin_reversible_command (_("start point trim"));
 
                if (selection->selected (rv)) {
                        for (list<RegionView*>::const_iterator i = selection->regions.by_layer().begin();
@@ -2287,23 +2362,17 @@ Editor::point_trim (GdkEvent* event, nframes64_t new_bound)
                                }
 
                                if (!(*i)->region()->locked()) {
-                                       boost::shared_ptr<Playlist> pl = (*i)->region()->playlist();
-                                       XMLNode &before = pl->get_state();
-
+                                       (*i)->region()->clear_changes ();
                                        (*i)->region()->trim_front (new_bound, this);
-
-                                       XMLNode &after = pl->get_state();
-                                       _session->add_command(new MementoCommand<Playlist>(*pl.get(), &before, &after));
+                                       _session->add_command(new StatefulDiffCommand ((*i)->region()));
                                }
                        }
 
                } else {
                        if (!rv->region()->locked()) {
-                               boost::shared_ptr<Playlist> pl = rv->region()->playlist();
-                               XMLNode &before = pl->get_state();
+                               rv->region()->clear_changes ();
                                rv->region()->trim_front (new_bound, this);
-                               XMLNode &after = pl->get_state();
-                               _session->add_command(new MementoCommand<Playlist>(*pl.get(), &before, &after));
+                               _session->add_command(new StatefulDiffCommand (rv->region()));
                        }
                }
 
@@ -2318,22 +2387,18 @@ Editor::point_trim (GdkEvent* event, nframes64_t new_bound)
                        for (list<RegionView*>::const_iterator i = selection->regions.by_layer().begin(); i != selection->regions.by_layer().end(); ++i)
                        {
                                if (!(*i)->region()->locked()) {
-                                       boost::shared_ptr<Playlist> pl = (*i)->region()->playlist();
-                                       XMLNode &before = pl->get_state();
+                                       (*i)->region()->clear_changes();
                                        (*i)->region()->trim_end (new_bound, this);
-                                       XMLNode &after = pl->get_state();
-                                       _session->add_command(new MementoCommand<Playlist>(*pl.get(), &before, &after));
+                                       _session->add_command(new StatefulDiffCommand ((*i)->region()));
                                }
                        }
 
                } else {
 
                        if (!rv->region()->locked()) {
-                               boost::shared_ptr<Playlist> pl = rv->region()->playlist();
-                               XMLNode &before = pl->get_state();
+                               rv->region()->clear_changes ();
                                rv->region()->trim_end (new_bound, this);
-                               XMLNode &after = pl->get_state();
-                               _session->add_command (new MementoCommand<Playlist>(*pl.get(), &before, &after));
+                               _session->add_command (new StatefulDiffCommand (rv->region()));
                        }
                }
 
@@ -2345,24 +2410,6 @@ Editor::point_trim (GdkEvent* event, nframes64_t new_bound)
        }
 }
 
-void
-Editor::thaw_region_after_trim (RegionView& rv)
-{
-       boost::shared_ptr<Region> region (rv.region());
-
-       if (region->locked()) {
-               return;
-       }
-
-       region->thaw ();
-
-       AudioRegionView* arv = dynamic_cast<AudioRegionView*>(&rv);
-
-       if (arv) {
-               arv->unhide_envelope ();
-       }
-}
-
 void
 Editor::hide_marker (ArdourCanvas::Item* item, GdkEvent* /*event*/)
 {
@@ -2380,7 +2427,7 @@ Editor::hide_marker (ArdourCanvas::Item* item, GdkEvent* /*event*/)
 
 
 void
-Editor::reposition_zoom_rect (nframes64_t start, nframes64_t end)
+Editor::reposition_zoom_rect (framepos_t start, framepos_t end)
 {
        double x1 = frame_to_pixel (start);
        double x2 = frame_to_pixel (end);
@@ -2419,7 +2466,7 @@ Editor::mouse_rename_region (ArdourCanvas::Item* /*item*/, GdkEvent* /*event*/)
 
 
 void
-Editor::mouse_brush_insert_region (RegionView* rv, nframes64_t pos)
+Editor::mouse_brush_insert_region (RegionView* rv, framepos_t pos)
 {
        /* no brushing without a useful snap setting */
 
@@ -2451,13 +2498,12 @@ Editor::mouse_brush_insert_region (RegionView* rv, nframes64_t pos)
        }
 
        boost::shared_ptr<Playlist> playlist = rtv->playlist();
-       double speed = rtv->get_diskstream()->speed();
+       double speed = rtv->track()->speed();
 
-       XMLNode &before = playlist->get_state();
-       boost::shared_ptr<Region> new_region (RegionFactory::create (rv->region()));
-       playlist->add_region (new_region, (nframes64_t) (pos * speed));
-       XMLNode &after = playlist->get_state();
-       _session->add_command(new MementoCommand<Playlist>(*playlist.get(), &before, &after));
+       playlist->clear_changes ();
+       boost::shared_ptr<Region> new_region (RegionFactory::create (rv->region(), true));
+       playlist->add_region (new_region, (framepos_t) (pos * speed));
+       _session->add_command (new StatefulDiffCommand (playlist));
 
        // playlist is frozen, so we have to update manually XXX this is disgusting
 
@@ -2479,12 +2525,16 @@ Editor::add_region_drag (ArdourCanvas::Item* item, GdkEvent* event, RegionView*
 {
        assert (region_view);
 
+       if (!region_view->region()->playlist()) {
+               return;
+       }
+
        _region_motion_group->raise_to_top ();
 
        if (Config->get_edit_mode() == Splice) {
                _drags->add (new RegionSpliceDrag (this, item, region_view, selection->regions.by_layer()));
        } else {
-               RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.id);
+               RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
                _drags->add (new RegionMoveDrag (this, item, region_view, s.by_layer(), false, false));
        }
 
@@ -2497,9 +2547,13 @@ Editor::add_region_copy_drag (ArdourCanvas::Item* item, GdkEvent* event, RegionV
 {
        assert (region_view);
 
+       if (!region_view->region()->playlist()) {
+               return;
+       }
+
        _region_motion_group->raise_to_top ();
 
-       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.id);
+       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
        _drags->add (new RegionMoveDrag (this, item, region_view, s.by_layer(), false, true));
 }
 
@@ -2508,14 +2562,18 @@ Editor::add_region_brush_drag (ArdourCanvas::Item* item, GdkEvent* event, Region
 {
        assert (region_view);
 
+       if (!region_view->region()->playlist()) {
+               return;
+       }
+        
        if (Config->get_edit_mode() == Splice) {
                return;
        }
 
-       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.id);
+       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
        _drags->add (new RegionMoveDrag (this, item, region_view, s.by_layer(), true, false));
 
-       begin_reversible_command (_("Drag region brush"));
+       begin_reversible_command (Operations::drag_region_brush);
 }
 
 /** Start a grab where a time range is selected, track(s) are selected, and the
@@ -2556,14 +2614,13 @@ Editor::start_selection_grab (ArdourCanvas::Item* /*item*/, GdkEvent* event)
           creating the new region and another for moving it.
        */
 
-       begin_reversible_command (_("selection grab"));
+       begin_reversible_command (Operations::selection_grab);
 
        boost::shared_ptr<Playlist> playlist = clicked_axisview->playlist();
 
-       XMLNode *before = &(playlist->get_state());
+       playlist->clear_changes ();
        clicked_routeview->playlist()->add_region (region, selection->time[clicked_selection].start);
-       XMLNode *after = &(playlist->get_state());
-       _session->add_command(new MementoCommand<Playlist>(*playlist, before, after));
+       _session->add_command(new StatefulDiffCommand (playlist));
 
        commit_reversible_command ();
 
@@ -2586,7 +2643,7 @@ void
 Editor::escape ()
 {
        if (_drags->active ()) {
-               _drags->break_drag ();
+               _drags->abort ();
        } else {
                selection->clear ();
        }
@@ -2600,32 +2657,31 @@ Editor::set_internal_edit (bool yn)
        if (yn) {
                mouse_select_button.set_image (*(manage (new Image (::get_icon("midi_tool_pencil")))));
                mouse_select_button.get_image ()->show ();
+               ARDOUR_UI::instance()->set_tip (mouse_select_button, _("Draw/Edit MIDI Notes"));
+               mouse_mode_toggled (mouse_mode);
 
-               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                       MidiTimeAxisView* mtv = dynamic_cast<MidiTimeAxisView*> (*i);
-                       if (mtv) {
-                               mtv->start_step_editing ();
-                       }
-               }
-               start_step_editing ();
+                pre_internal_mouse_mode = mouse_mode;
+
+                for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
+                        (*i)->enter_internal_edit_mode ();
+                }
 
        } else {
 
                mouse_select_button.set_image (*(manage (new Image (::get_icon("tool_range")))));
                mouse_select_button.get_image ()->show ();
-               stop_step_editing ();
-
-               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                       MidiTimeAxisView* mtv = dynamic_cast<MidiTimeAxisView*> (*i);
-                       if (mtv) {
-                               mtv->stop_step_editing ();
-                       }
-               }
-       }
-
-       set_canvas_cursor ();
+               ARDOUR_UI::instance()->set_tip (mouse_select_button, _("Select/Move Ranges"));
+               mouse_mode_toggled (mouse_mode); // sets cursor
 
+                for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
+                        (*i)->leave_internal_edit_mode ();
+                }
 
+                if (mouse_mode == MouseRange && pre_internal_mouse_mode != MouseRange) {
+                        /* we were drawing .. flip back to something sensible */
+                        set_mouse_mode (pre_internal_mouse_mode);
+                }
+       }
 }
 
 /** Update _join_object_range_state which indicate whether we are over the top or bottom half of a region view,
@@ -2662,9 +2718,11 @@ Editor::update_join_object_range_location (double x, double y)
                        double cy = y;
                        rtv->canvas_display()->w2i (cx, cy);
 
-                       bool const top_half = cy < rtv->current_height () / 2;
-                       
-                       _join_object_range_state = top_half ? JOIN_OBJECT_RANGE_RANGE : JOIN_OBJECT_RANGE_OBJECT;
+                       double const c = cy / rtv->view()->child_height();
+                       double d;
+                       double const f = modf (c, &d);
+
+                       _join_object_range_state = f < 0.5 ? JOIN_OBJECT_RANGE_RANGE : JOIN_OBJECT_RANGE_OBJECT;
                }
        }
 }
@@ -2680,3 +2738,44 @@ Editor::effective_mouse_mode () const
 
        return mouse_mode;
 }
+
+void
+Editor::remove_midi_note (ArdourCanvas::Item* item, GdkEvent *)
+{
+       ArdourCanvas::CanvasNoteEvent* e = dynamic_cast<ArdourCanvas::CanvasNoteEvent*> (item);
+       assert (e);
+
+       e->region_view().delete_note (e->note ());
+}
+
+void
+Editor::set_canvas_cursor_for_region_view (double x, RegionView* rv)
+{
+       ArdourCanvas::Group* g = rv->get_canvas_group ();
+       ArdourCanvas::Group* p = g->get_parent_group ();
+
+       /* Compute x in region view parent coordinates */
+       double dy = 0;
+       p->w2i (x, dy);
+
+       double x1, x2, y1, y2;
+       g->get_bounds (x1, y1, x2, y2);
+
+       /* Halfway across the region */
+       double const h = (x1 + x2) / 2;
+
+       Trimmable::CanTrim ct = rv->region()->can_trim ();
+       if (x <= h) {
+               if (ct & Trimmable::FrontTrimEarlier) {
+                       set_canvas_cursor (_cursors->left_side_trim);
+               } else {
+                       set_canvas_cursor (_cursors->left_side_trim_right_only);
+               }
+       } else {
+               if (ct & Trimmable::EndTrimLater) {
+                       set_canvas_cursor (_cursors->right_side_trim);
+               } else {
+                       set_canvas_cursor (_cursors->right_side_trim_left_only);
+               }
+       }
+}