add back-pointer to TempoMap from points, and push dirty=true into map
[ardour.git] / gtk2_ardour / editor_mouse.cc
index 0d9ad69181ba968c7018a0aa2ab9273b906c53a0..21ace734c2fe71d46fe2a3cd4aee9d724d7d80a5 100644 (file)
@@ -34,7 +34,6 @@
 
 #include "gtkmm2ext/bindings.h"
 #include "gtkmm2ext/utils.h"
-#include "gtkmm2ext/tearoff.h"
 
 #include "canvas/canvas.h"
 
 #include "ardour/session.h"
 #include "ardour/types.h"
 
-#include "ardour_ui.h"
+#include "widgets/prompter.h"
+
 #include "actions.h"
+#include "ardour_ui.h"
 #include "editor.h"
 #include "time_axis_view.h"
 #include "audio_time_axis.h"
@@ -59,7 +60,6 @@
 #include "region_gain_line.h"
 #include "automation_time_axis.h"
 #include "control_point.h"
-#include "prompter.h"
 #include "selection.h"
 #include "keyboard.h"
 #include "editing.h"
@@ -73,7 +73,7 @@
 #include "verbose_cursor.h"
 #include "note.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace ARDOUR;
@@ -86,18 +86,18 @@ bool
 Editor::mouse_frame (framepos_t& where, bool& in_track_canvas) const
 {
         /* gdk_window_get_pointer() has X11's XQueryPointer semantics in that it only
-           pays attentions to subwindows. this means that menu windows are ignored, and 
-           if the pointer is in a menu, the return window from the call will be the
-           the regular subwindow *under* the menu.
-
-           this matters quite a lot if the pointer is moving around in a menu that overlaps
-           the track canvas because we will believe that we are within the track canvas
-           when we are not. therefore, we track enter/leave events for the track canvas
-           and allow that to override the result of gdk_window_get_pointer().
+          pays attentions to subwindows. this means that menu windows are ignored, and
+          if the pointer is in a menu, the return window from the call will be the
+          the regular subwindow *under* the menu.
+
+          this matters quite a lot if the pointer is moving around in a menu that overlaps
+          the track canvas because we will believe that we are within the track canvas
+          when we are not. therefore, we track enter/leave events for the track canvas
+          and allow that to override the result of gdk_window_get_pointer().
         */
 
         if (!within_track_canvas) {
-                return false;
+               return false;
         }
 
        int x, y;
@@ -208,7 +208,7 @@ void
 Editor::mouse_mode_object_range_toggled()
 {
        MouseMode m = mouse_mode;
-       
+
        Glib::RefPtr<Action> act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-range"));
        assert (act);
        Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
@@ -314,7 +314,7 @@ Editor::mouse_mode_toggled (MouseMode m)
        }
 
        set_gain_envelope_visibility ();
-       
+
        update_time_selection_display ();
 
        update_all_enter_cursors ();
@@ -334,12 +334,11 @@ Editor::update_time_selection_display ()
        switch (mouse_mode) {
        case MouseRange:
                selection->clear_objects ();
-               selection->ClearMidiNoteSelection ();  /* EMIT SIGNAL */
+               selection->clear_midi_notes ();
                break;
        case MouseObject:
                selection->clear_time ();
-               selection->clear_tracks ();
-               selection->ClearMidiNoteSelection ();  /* EMIT SIGNAL */
+               selection->clear_midi_notes ();
                break;
        case MouseDraw:
                /* Clear regions, but not time or tracks, since that
@@ -350,7 +349,7 @@ Editor::update_time_selection_display ()
                break;
        case MouseContent:
                /* This handles internal edit.
-                  Clear everything except points and notes. 
+                  Clear everything except points and notes.
                */
                selection->clear_regions();
                selection->clear_lines();
@@ -400,8 +399,9 @@ Editor::step_mouse_mode (bool next)
 }
 
 void
-Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemType item_type)
+Editor::button_selection (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
+
        /* in object/audition/timefx/gain-automation mode,
           any button press sets the selection if the object
           can be selected. this is a bit of hack, because
@@ -458,7 +458,9 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
 
                        /* almost no selection action on modified button-2 or button-3 events */
 
-                       if (item_type != RegionItem && event->button.button != 2) {
+                       if ((item_type != RegionItem && event->button.button != 2)
+                           /* for selection of control points prior to delete (shift-right click) */
+                           && !(item_type == ControlPointItem && event->button.button == 3 && event->type == GDK_BUTTON_PRESS)) {
                                return;
                        }
                }
@@ -473,6 +475,9 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
 
        switch (item_type) {
        case RegionItem:
+               if (eff_mouse_mode == MouseDraw) {
+                       break;
+               }
                if (press) {
                        if (eff_mouse_mode != MouseRange) {
                                _mouse_changed_selection = set_selected_regionview_from_click (press, op);
@@ -516,7 +521,99 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
                /* for object/track exclusivity, we don't call set_selected_track_as_side_effect (op); */
 
                if (eff_mouse_mode != MouseRange) {
-                       _mouse_changed_selection |= set_selected_control_point_from_click (press, op);
+                       if (event->button.button != 3) {
+                               _mouse_changed_selection |= set_selected_control_point_from_click (press, op);
+                       } else {
+                               _mouse_changed_selection |= set_selected_control_point_from_click (press, Selection::Set);
+                       }
+               }
+               break;
+
+       case GainLineItem:
+               if (eff_mouse_mode != MouseRange) {
+                       AutomationLine* argl = reinterpret_cast<AutomationLine*> (item->get_data ("line"));
+
+                       std::list<Selectable*> selectables;
+                       uint32_t before, after;
+                       framecnt_t const  where = (framecnt_t) floor (event->button.x * samples_per_pixel) - clicked_regionview->region ()->position ();
+
+                       if (!argl || !argl->control_points_adjacent (where, before, after)) {
+                               break;
+                       }
+
+                       selectables.push_back (argl->nth (before));
+                       selectables.push_back (argl->nth (after));
+
+                       switch (op) {
+                       case Selection::Set:
+                               if (press) {
+                                       selection->set (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Add:
+                               if (press) {
+                                       selection->add (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Toggle:
+                               if (press) {
+                                       selection->toggle (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+
+                       case Selection::Extend:
+                               /* XXX */
+                               break;
+                       }
+               }
+               break;
+
+       case AutomationLineItem:
+               if (eff_mouse_mode != MouseRange) {
+                       AutomationLine* al = reinterpret_cast<AutomationLine*> (item->get_data ("line"));
+                       std::list<Selectable*> selectables;
+                       double mx = event->button.x;
+                       double my = event->button.y;
+
+                       al->grab_item().canvas_to_item (mx, my);
+
+                       uint32_t before, after;
+                       framecnt_t const  where = (framecnt_t) floor (mx * samples_per_pixel);
+
+                       if (!al || !al->control_points_adjacent (where, before, after)) {
+                               break;
+                       }
+
+                       selectables.push_back (al->nth (before));
+                       selectables.push_back (al->nth (after));
+
+                       switch (op) {
+                       case Selection::Set:
+                               if (press) {
+                                       selection->set (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Add:
+                               if (press) {
+                                       selection->add (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Toggle:
+                               if (press) {
+                                       selection->toggle (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+
+                       case Selection::Extend:
+                               /* XXX */
+                               break;
+                       }
                }
                break;
 
@@ -533,7 +630,23 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
                break;
 
        case AutomationTrackItem:
-               set_selected_track_as_side_effect (op);
+               if (eff_mouse_mode != MouseDraw && op == Selection::Set) {
+                       set_selected_track_as_side_effect (op);
+               }
+               break;
+
+       case NoteItem:
+               if (press && event->button.button == 3) {
+                       NoteBase* cnote = reinterpret_cast<NoteBase*> (item->get_data ("notebase"));
+                       assert (cnote);
+                       if (cnote->region_view().selection_size() == 0 || !cnote->selected()) {
+                               selection->clear_points();
+                               cnote->region_view().unique_select (cnote);
+                               /* we won't get the release, so store the selection change now */
+                               begin_reversible_selection_op (X_("Button 3 Note Selection"));
+                               commit_reversible_selection_op ();
+                       }
+               }
                break;
 
        default:
@@ -573,14 +686,25 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case TempoMarkerItem:
        {
-               _drags->set (
-                       new TempoMarkerDrag (
-                               this,
-                               item,
-                               Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)
-                               ),
-                       event
-                       );
+               if (ArdourKeyboard::indicates_constraint (event->button.state)) {
+                       _drags->set (
+                               new TempoEndDrag (
+                                       this,
+                                       item
+                                       ),
+                               event
+                               );
+               } else {
+                       _drags->set (
+                               new TempoMarkerDrag (
+                                       this,
+                                       item,
+                                       ArdourKeyboard::indicates_copy (event->button.state)
+                                       ),
+                               event
+                               );
+               }
+
                return true;
        }
 
@@ -590,7 +714,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        new MeterMarkerDrag (
                                this,
                                item,
-                               Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)
+                               ArdourKeyboard::indicates_copy (event->button.state)
                                ),
                        event
                        );
@@ -604,13 +728,20 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case MarkerBarItem:
        case TempoBarItem:
+       case TempoCurveItem:
        case MeterBarItem:
        case TimecodeRulerItem:
        case SamplesRulerItem:
        case MinsecRulerItem:
        case BBTRulerItem:
-               if (!Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)) {
+               if (!Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)
+                       && !ArdourKeyboard::indicates_constraint (event->button.state)) {
                        _drags->set (new CursorDrag (this, *playhead_cursor, false), event);
+               } else if (ArdourKeyboard::indicates_constraint (event->button.state)
+                          && Keyboard::modifier_state_contains (event->button.state, Keyboard::PrimaryModifier)) {
+                       _drags->set (new TempoTwistDrag (this, item), event);
+               } else if (ArdourKeyboard::indicates_constraint (event->button.state)) {
+                       _drags->set (new BBTRulerDrag (this, item), event);
                }
                return true;
                break;
@@ -666,7 +797,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        Editing::MouseMode eff = effective_mouse_mode ();
 
        /* special case: allow drag of region fade in/out in object mode with join object/range enabled */
-       if (get_smart_mode()) { 
+       if (get_smart_mode()) {
                switch (item_type) {
                  case FadeInHandleItem:
                  case FadeInTrimHandleItem:
@@ -824,7 +955,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                        case StartCrossFadeItem:
                        case EndCrossFadeItem:
-                               /* we might allow user to grab inside the fade to trim a region with preserve_fade_anchor.  for not this is not fully implemented */ 
+                               /* we might allow user to grab inside the fade to trim a region with preserve_fade_anchor.  for not this is not fully implemented */
 //                             if (!clicked_regionview->region()->locked()) {
 //                                     _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer(), true), event);
 //                                     return true;
@@ -852,7 +983,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                }
 
                                /* click on a normal region view */
-                               if (Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)) {
+                               if (ArdourKeyboard::indicates_copy (event->button.state)) {
                                        add_region_copy_drag (item, event, clicked_regionview);
                                } else if (Keyboard::the_keyboard().key_is_down (GDK_b)) {
                                        add_region_brush_drag (item, event, clicked_regionview);
@@ -926,7 +1057,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                                if (!prev) {
                                                        _drags->set (new RegionCreateDrag (this, item, parent), event);
                                                } else {
-                                                       prev->set_length (t - prev->position ());
+                                                       prev->set_length (t - prev->position (), get_grid_music_divisions (event->button.state));
                                                }
                                        }
                                } else {
@@ -1053,7 +1184,7 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        case MouseObject:
                switch (item_type) {
                case RegionItem:
-                       if (Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)) {
+                       if (ArdourKeyboard::indicates_copy (event->button.state)) {
                                add_region_copy_drag (item, event, clicked_regionview);
                        } else {
                                add_region_drag (item, event, clicked_regionview);
@@ -1107,7 +1238,7 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        return false;
 }
-   
+
 bool
 Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
@@ -1138,11 +1269,23 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                return true;
        }
 
-       //not rolling, range mode click + join_play_range :  locate the PH here
-       if ( !_drags->active () && !_session->transport_rolling() && ( effective_mouse_mode() == MouseRange ) && ARDOUR_UI::config()->get_follow_edits() ) {
-               framepos_t where = canvas_event_sample (event);
-               snap_to(where);
-               _session->request_locate (where, false);
+       /* not rolling, effectively in range mode, follow edits enabled (likely
+        * to start range drag), not in a fade handle (since that means we are
+        * not starting a range drag): locate the PH here
+        */
+
+       if ((item_type != FadeInHandleItem) &&
+           (item_type != FadeOutHandleItem) &&
+           !_drags->active () && 
+           _session && 
+           !_session->transport_rolling() && 
+           (effective_mouse_mode() == MouseRange) && 
+           UIConfiguration::instance().get_follow_edits() && 
+           !_session->config.get_external_sync()) {
+
+               MusicFrame where (canvas_event_sample (event), 0);
+               snap_to (where);
+               _session->request_locate (where.frame, false);
        }
 
        switch (event->button.button) {
@@ -1158,7 +1301,7 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                break;
 
        default:
-                return button_press_dispatch (&event->button);
+               return button_press_dispatch (&event->button);
                break;
 
        }
@@ -1189,7 +1332,7 @@ Editor::button_release_dispatch (GdkEventButton* ev)
 bool
 Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
-       framepos_t where = canvas_event_sample (event);
+       MusicFrame where (canvas_event_sample (event), 0);
        AutomationTimeAxisView* atv = 0;
 
        _press_cursor_ctx.reset();
@@ -1200,24 +1343,24 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                return true;
        }
 
-        bool were_dragging = false;
+       bool were_dragging = false;
 
        if (!Keyboard::is_context_menu_event (&event->button)) {
 
-                /* see if we're finishing a drag */
-                
-                if (_drags->active ()) {
-                        bool const r = _drags->end_grab (event);
-                        if (r) {
-                                /* grab dragged, so do nothing else */
-                                return true;
-                        }
-                        
-                        were_dragging = true;
-                }
-
-                update_region_layering_order_editor ();
-        }
+               /* see if we're finishing a drag */
+
+               if (_drags->active ()) {
+                       bool const r = _drags->end_grab (event);
+                       if (r) {
+                               /* grab dragged, so do nothing else */
+                               return true;
+                       }
+
+                       were_dragging = true;
+               }
+
+               update_region_layering_order_editor ();
+       }
 
        /* edit events get handled here */
 
@@ -1226,21 +1369,20 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                case RegionItem:
                        show_region_properties ();
                        break;
-
                case TempoMarkerItem: {
                        ArdourMarker* marker;
                        TempoMarker* tempo_marker;
-                       
+
                        if ((marker = reinterpret_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                                fatal << _("programming error: tempo marker canvas item has no marker object pointer!") << endmsg;
                                abort(); /*NOTREACHED*/
                        }
-                       
+
                        if ((tempo_marker = dynamic_cast<TempoMarker*> (marker)) == 0) {
                                fatal << _("programming error: marker for tempo is not a tempo marker!") << endmsg;
                                abort(); /*NOTREACHED*/
                        }
-                       
+
                        edit_tempo_marker (*tempo_marker);
                        break;
                }
@@ -1248,12 +1390,12 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                case MeterMarkerItem: {
                        ArdourMarker* marker;
                        MeterMarker* meter_marker;
-                       
+
                        if ((marker = reinterpret_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                                fatal << _("programming error: tempo marker canvas item has no marker object pointer!") << endmsg;
                                abort(); /*NOTREACHED*/
                        }
-                       
+
                        if ((meter_marker = dynamic_cast<MeterMarker*> (marker)) == 0) {
                                fatal << _("programming error: marker for meter is not a meter marker!") << endmsg;
                                abort(); /*NOTREACHED*/
@@ -1321,7 +1463,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        case SelectionItem:
                                popup_track_context_menu (1, event->button.time, item_type, true);
                                break;
-                               
+
                        case AutomationTrackItem:
                                popup_track_context_menu (1, event->button.time, item_type, false);
                                break;
@@ -1331,13 +1473,14 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        case TransportMarkerBarItem:
                        case CdMarkerBarItem:
                        case TempoBarItem:
+                       case TempoCurveItem:
                        case MeterBarItem:
                        case VideoBarItem:
                        case TimecodeRulerItem:
                        case SamplesRulerItem:
                        case MinsecRulerItem:
                        case BBTRulerItem:
-                               popup_ruler_menu (where, item_type);
+                               popup_ruler_menu (where.frame, item_type);
                                break;
 
                        case MarkerItem:
@@ -1429,7 +1572,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                case MarkerBarItem:
                        if (!_dragging_playhead) {
                                snap_to_with_modifier (where, event, RoundNearest, true);
-                               mouse_add_new_marker (where);
+                               mouse_add_new_marker (where.frame);
                        }
                        return true;
 
@@ -1437,19 +1580,19 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        if (!_dragging_playhead) {
                                // if we get here then a dragged range wasn't done
                                snap_to_with_modifier (where, event, RoundNearest, true);
-                               mouse_add_new_marker (where, true);
+                               mouse_add_new_marker (where.frame, true);
                        }
                        return true;
-
                case TempoBarItem:
-                       if (!_dragging_playhead) {
+               case TempoCurveItem:
+                       if (!_dragging_playhead && Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)) {
                                snap_to_with_modifier (where, event);
-                               mouse_add_new_tempo_event (where);
+                               mouse_add_new_tempo_event (where.frame);
                        }
                        return true;
 
                case MeterBarItem:
-                       if (!_dragging_playhead) {
+                       if (!_dragging_playhead && Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)) {
                                mouse_add_new_meter_event (pixel_to_sample (event->button.x));
                        }
                        return true;
@@ -1488,7 +1631,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                bool with_guard_points = Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier);
                                atv = dynamic_cast<AutomationTimeAxisView*>(clicked_axisview);
                                if (atv) {
-                                       atv->add_automation_event (event, where, event->button.y, with_guard_points);
+                                       atv->add_automation_event (event, where.frame, event->button.y, with_guard_points);
                                }
                                return true;
                                break;
@@ -1519,7 +1662,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                }
 
-                /* do any (de)selection operations that should occur on button release */
+               /* do any (de)selection operations that should occur on button release */
                button_selection (item, event, item_type);
 
                return true;
@@ -1550,7 +1693,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                case MouseDraw:
                        return true;
-                       
+
                case MouseRange:
                        // x_style_paste (where, 1.0);
                        return true;
@@ -1577,11 +1720,13 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 {
        ControlPoint* cp;
        ArdourMarker * marker;
+       MeterMarker* m_marker = 0;
+       TempoMarker* t_marker = 0;
        double fraction;
-        bool ret = true;
+       bool ret = true;
 
        /* by the time we reach here, entered_regionview and entered trackview
-        * will have already been set as appropriate. Things are done this 
+        * will have already been set as appropriate. Things are done this
         * way because this method isn't passed a pointer to a variable type of
         * thing that is entered (which may or may not be canvas item).
         * (e.g. the actual entered regionview)
@@ -1591,7 +1736,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 
        switch (item_type) {
        case ControlPointItem:
-               if (mouse_mode == MouseDraw || mouse_mode == MouseObject) {
+               if (mouse_mode == MouseDraw || mouse_mode == MouseObject || mouse_mode == MouseContent) {
                        cp = static_cast<ControlPoint*>(item->get_data ("control_point"));
                        cp->show ();
 
@@ -1606,7 +1751,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                if (mouse_mode == MouseDraw) {
                        ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
                        if (line) {
-                               line->set_outline_color (ARDOUR_UI::config()->color ("entered gain line"));
+                               line->set_outline_color (UIConfiguration::instance().color ("entered gain line"));
                        }
                }
                break;
@@ -1615,7 +1760,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                if (mouse_mode == MouseDraw || mouse_mode == MouseObject) {
                        ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
                        if (line) {
-                               line->set_outline_color (ARDOUR_UI::config()->color ("entered automation line"));
+                               line->set_outline_color (UIConfiguration::instance().color ("entered automation line"));
                        }
                }
                break;
@@ -1633,10 +1778,31 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                        break;
                }
                entered_marker = marker;
-               marker->set_color_rgba (ARDOUR_UI::config()->color ("entered marker"));
-               // fall through
+               marker->set_color_rgba (UIConfiguration::instance().color ("entered marker"));
+               break;
+
        case MeterMarkerItem:
+               if ((m_marker = static_cast<MeterMarker *> (item->get_data ("marker"))) == 0) {
+                       break;
+               }
+               entered_marker = m_marker;
+               if (m_marker->meter().position_lock_style() == MusicTime) {
+                       m_marker->set_color_rgba (UIConfiguration::instance().color ("meter marker"));
+               } else {
+                       m_marker->set_color_rgba (UIConfiguration::instance().color ("meter marker music"));
+               }
+               break;
+
        case TempoMarkerItem:
+               if ((t_marker = static_cast<TempoMarker *> (item->get_data ("marker"))) == 0) {
+                       break;
+               }
+               entered_marker = t_marker;
+               if (t_marker->tempo().position_lock_style() == MusicTime) {
+                       t_marker->set_color_rgba (UIConfiguration::instance().color ("tempo marker"));
+               } else {
+                       t_marker->set_color_rgba (UIConfiguration::instance().color ("tempo marker music"));
+               }
                break;
 
        case FadeInHandleItem:
@@ -1711,6 +1877,8 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
 {
        AutomationLine* al;
        ArdourMarker *marker;
+       TempoMarker *t_marker;
+       MeterMarker *m_marker;
        Location *loc;
        bool is_start;
        bool ret = true;
@@ -1721,7 +1889,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
 
        switch (item_type) {
        case ControlPointItem:
-               _verbose_cursor->hide (); 
+               _verbose_cursor->hide ();
                break;
 
        case GainLineItem:
@@ -1743,9 +1911,30 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
                if ((loc = find_location_from_marker (marker, is_start)) != 0) {
                        location_flags_changed (loc);
                }
-               // fall through
+               break;
+
        case MeterMarkerItem:
+               if ((m_marker = static_cast<MeterMarker *> (item->get_data ("marker"))) == 0) {
+                       break;
+               }
+               entered_marker = 0;
+               if (m_marker->meter().position_lock_style() == MusicTime) {
+                       m_marker->set_color_rgba (UIConfiguration::instance().color ("meter marker music"));
+               } else {
+                       m_marker->set_color_rgba (UIConfiguration::instance().color ("meter marker"));
+               }
+               break;
+
        case TempoMarkerItem:
+               if ((t_marker = static_cast<TempoMarker *> (item->get_data ("marker"))) == 0) {
+                       break;
+               }
+               entered_marker = 0;
+               if (t_marker->tempo().position_lock_style() == MusicTime) {
+                       t_marker->set_color_rgba (UIConfiguration::instance().color ("tempo marker music"));
+               } else {
+                       t_marker->set_color_rgba (UIConfiguration::instance().color ("tempo marker"));
+               }
                break;
 
        case FadeInTrimHandleItem:
@@ -1755,7 +1944,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
        {
                ArdourCanvas::Rectangle *rect = dynamic_cast<ArdourCanvas::Rectangle *> (item);
                if (rect) {
-                       rect->set_fill_color (ARDOUR_UI::config()->color ("inactive fade handle"));
+                       rect->set_fill_color (UIConfiguration::instance().color ("inactive fade handle"));
                }
        }
        break;
@@ -1766,7 +1955,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
        case FeatureLineItem:
        {
                ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
-               line->set_outline_color (ARDOUR_UI::config()->color ("zero line"));
+               line->set_outline_color (UIConfiguration::instance().color ("zero line"));
        }
        break;
 
@@ -1881,14 +2070,14 @@ Editor::motion_handler (ArdourCanvas::Item* /*item*/, GdkEvent* event, bool from
                current_stepping_trackview = 0;
                step_timeout.disconnect ();
        }
-       
+
        if (_session && _session->actively_recording()) {
                /* Sorry. no dragging stuff around while we record */
                return true;
        }
-       
+
        update_join_object_range_location (event->motion.y);
-       
+
        if (_drags->active ()) {
                return _drags->motion_handler (event, from_autoscroll);
        }
@@ -1975,6 +2164,16 @@ Editor::note_edit_done (int r, EditNoteDialog* d)
        delete d;
 }
 
+void
+Editor::edit_region (RegionView* rv)
+{
+       if (UIConfiguration::instance().get_use_double_click_to_zoom_to_selection()) {
+               temporal_zoom_selection (Both);
+       } else {
+               rv->show_region_editor ();
+       }
+}
+
 void
 Editor::visible_order_range (int* low, int* high) const
 {
@@ -1985,7 +2184,7 @@ Editor::visible_order_range (int* low, int* high) const
 
                RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (*i);
 
-               if (!rtv->hidden()) {
+               if (rtv && !rtv->hidden()) {
 
                        if (*high < rtv->order()) {
                                *high = rtv->order ();
@@ -2008,10 +2207,6 @@ Editor::region_view_item_click (AudioRegionView& rv, GdkEventButton* event)
        if (Keyboard::modifier_state_contains (event->state, Keyboard::PrimaryModifier)) {
                TimeAxisView* tv = &rv.get_time_axis_view();
                RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*>(tv);
-               double speed = 1.0;
-               if (rtv && rtv->is_track()) {
-                       speed = rtv->track()->speed();
-               }
 
                framepos_t where = get_preferred_edit_position();
 
@@ -2019,15 +2214,15 @@ Editor::region_view_item_click (AudioRegionView& rv, GdkEventButton* event)
 
                        if (Keyboard::modifier_state_equals (event->state, Keyboard::ModifierMask (Keyboard::PrimaryModifier|Keyboard::SecondaryModifier))) {
 
-                               align_region (rv.region(), SyncPoint, (framepos_t) (where * speed));
+                               align_region (rv.region(), SyncPoint, where);
 
                        } else if (Keyboard::modifier_state_equals (event->state, Keyboard::ModifierMask (Keyboard::PrimaryModifier|Keyboard::TertiaryModifier))) {
 
-                               align_region (rv.region(), End, (framepos_t) (where * speed));
+                               align_region (rv.region(), End, where);
 
                        } else {
 
-                               align_region (rv.region(), Start, (framepos_t) (where * speed));
+                               align_region (rv.region(), Start, where);
                        }
                }
        }
@@ -2065,7 +2260,7 @@ Editor::cancel_time_selection ()
        }
        selection->time.clear ();
        clicked_selection = 0;
-}      
+}
 
 void
 Editor::point_trim (GdkEvent* event, framepos_t new_bound)
@@ -2100,7 +2295,7 @@ Editor::point_trim (GdkEvent* event, framepos_t new_bound)
 
                break;
        case 2:
-               begin_reversible_command (_("End point trim"));
+               begin_reversible_command (_("end point trim"));
 
                if (selection->selected (rv)) {
 
@@ -2150,7 +2345,7 @@ Editor::mouse_rename_region (ArdourCanvas::Item* /*item*/, GdkEvent* /*event*/)
 {
        using namespace Gtkmm2ext;
 
-       ArdourPrompter prompter (false);
+       ArdourWidgets::Prompter prompter (false);
 
        prompter.set_prompt (_("Name for region:"));
        prompter.set_initial_text (clicked_regionview->region()->name());
@@ -2198,16 +2393,15 @@ Editor::mouse_brush_insert_region (RegionView* rv, framepos_t pos)
 
        RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*>(&rv->get_time_axis_view());
 
-       if (rtv == 0 || !rtv->is_track()) {
+       if (!rtv || !rtv->is_track()) {
                return;
        }
 
        boost::shared_ptr<Playlist> playlist = rtv->playlist();
-       double speed = rtv->track()->speed();
 
        playlist->clear_changes ();
        boost::shared_ptr<Region> new_region (RegionFactory::create (rv->region(), true));
-       playlist->add_region (new_region, (framepos_t) (pos * speed));
+       playlist->add_region (new_region, pos);
        _session->add_command (new StatefulDiffCommand (playlist));
 
        // playlist is frozen, so we have to update manually XXX this is disgusting
@@ -2349,7 +2543,7 @@ Editor::escape ()
                selection->clear ();
        }
 
-       reset_focus ();
+       ARDOUR_UI::instance()->reset_focus (&contents());
 }
 
 /** Update _join_object_range_state which indicate whether we are over the top
@@ -2374,6 +2568,10 @@ Editor::update_join_object_range_location (double y)
 
        if (entered_regionview) {
 
+               //ToDo:  there is currently a bug here(?)
+               //when we are inside a region fade handle, it acts as though we are in range mode because it is in the top half of the region
+               //can it be fixed here?
+
                ArdourCanvas::Duple const item_space = entered_regionview->get_canvas_group()->canvas_to_item (ArdourCanvas::Duple (0, y));
                double const c = item_space.y / entered_regionview->height();
 
@@ -2387,7 +2585,7 @@ Editor::update_join_object_range_location (double y)
        } else if (entered_track) {
 
                RouteTimeAxisView* entered_route_view = dynamic_cast<RouteTimeAxisView*> (entered_track);
-               
+
                if (entered_route_view) {
 
                        double cx = 0;
@@ -2396,7 +2594,7 @@ Editor::update_join_object_range_location (double y)
                        entered_route_view->canvas_display()->canvas_to_item (cx, cy);
 
                        double track_height = entered_route_view->view()->child_height();
-                       if (ARDOUR_UI::config()->get_show_name_highlight()) {
+                       if (UIConfiguration::instance().get_show_name_highlight()) {
                                track_height -= TimeAxisViewItem::NAME_HIGHLIGHT_SIZE;
                        }
                        double const c = cy / track_height;