Check that a route has a track before trying to insert time on it.
[ardour.git] / gtk2_ardour / editor_ops.cc
index 8d73e5e56cbe7612aa5472c1440b65ad541a4594..2501b651fe42927d02f250b29482e2c33cee9114 100644 (file)
@@ -76,7 +76,7 @@
 #include "editor_regions.h"
 #include "editor_routes.h"
 #include "gui_thread.h"
-#include "insert_time_dialog.h"
+#include "insert_remove_time_dialog.h"
 #include "interthread_progress_window.h"
 #include "item_counts.h"
 #include "keyboard.h"
@@ -336,9 +336,9 @@ Editor::move_range_selection_start_or_end_to_region_boundary (bool move_end, boo
                return;
        }
 
-       begin_reversible_command (_("alter selection"));
+       begin_reversible_selection_op (_("alter selection"));
        selection->set_preserving_all_ranges (start, end);
-       commit_reversible_command ();
+       commit_reversible_selection_op ();
 }
 
 bool
@@ -400,8 +400,7 @@ Editor::nudge_forward (bool next, bool force_playhead)
        } else if (!force_playhead && !selection->markers.empty()) {
 
                bool is_start;
-
-               begin_reversible_command (_("nudge location forward"));
+               bool in_command = false;
 
                for (MarkerSelection::iterator i = selection->markers.begin(); i != selection->markers.end(); ++i) {
 
@@ -432,13 +431,18 @@ Editor::nudge_forward (bool next, bool force_playhead)
                                                loc->set_end (max_framepos);
                                        }
                                }
+                               if (!in_command) {
+                                       begin_reversible_command (_("nudge location forward"));
+                                       in_command = true;
+                               }
                                XMLNode& after (loc->get_state());
                                _session->add_command (new MementoCommand<Location>(*loc, &before, &after));
                        }
                }
 
-               commit_reversible_command ();
-
+               if (in_command) {
+                       commit_reversible_command ();
+               }
        } else {
                distance = get_nudge_distance (playhead_cursor->current_frame (), next_distance);
                _session->request_locate (playhead_cursor->current_frame () + distance);
@@ -485,8 +489,7 @@ Editor::nudge_backward (bool next, bool force_playhead)
        } else if (!force_playhead && !selection->markers.empty()) {
 
                bool is_start;
-
-               begin_reversible_command (_("nudge location forward"));
+               bool in_command = false;
 
                for (MarkerSelection::iterator i = selection->markers.begin(); i != selection->markers.end(); ++i) {
 
@@ -519,13 +522,17 @@ Editor::nudge_backward (bool next, bool force_playhead)
                                                loc->set_end (loc->length());
                                        }
                                }
-
+                               if (!in_command) {
+                                       begin_reversible_command (_("nudge location forward"));
+                                       in_command = true;
+                               }
                                XMLNode& after (loc->get_state());
                                _session->add_command (new MementoCommand<Location>(*loc, &before, &after));
                        }
                }
-
-               commit_reversible_command ();
+               if (in_command) {
+                       commit_reversible_command ();
+               }
 
        } else {
 
@@ -615,7 +622,8 @@ Editor::sequence_regions ()
 
        if (!rs.empty()) {
 
-               begin_reversible_command (_("sequence regions"));
+               bool in_command = false;
+
                for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
                        boost::shared_ptr<Region> r ((*i)->region());
 
@@ -635,13 +643,20 @@ Editor::sequence_regions ()
                                r->set_position(r_end_prev);
                        }
 
+                       if (!in_command) {
+                               begin_reversible_command (_("sequence regions"));
+                               in_command = true;
+                       }
                        _session->add_command (new StatefulDiffCommand (r));
 
                        r_end=r->position() + r->length();
 
                        iCount++;
                }
-               commit_reversible_command ();
+
+               if (in_command) {
+                       commit_reversible_command ();
+               }
        } 
 } 
 
@@ -2114,6 +2129,54 @@ Editor::add_location_mark (framepos_t where)
        commit_reversible_command ();
 }
 
+void
+Editor::set_session_start_from_playhead ()
+{
+       if (!_session)
+               return;
+       
+       Location* loc;
+       if ((loc = _session->locations()->session_range_location()) == 0) {  //should never happen
+               _session->set_session_extents ( _session->audible_frame(), _session->audible_frame() );
+       } else {
+               XMLNode &before = loc->get_state();
+
+               _session->set_session_extents ( _session->audible_frame(), loc->end() );
+
+               XMLNode &after = loc->get_state();
+
+               begin_reversible_command (_("Set session start"));
+               
+               _session->add_command (new MementoCommand<Location>(*loc, &before, &after));
+
+               commit_reversible_command ();
+       }
+}
+
+void
+Editor::set_session_end_from_playhead ()
+{
+       if (!_session)
+               return;
+       
+       Location* loc;
+       if ((loc = _session->locations()->session_range_location()) == 0) {  //should never happen
+               _session->set_session_extents ( _session->audible_frame(), _session->audible_frame() );
+       } else {
+               XMLNode &before = loc->get_state();
+
+               _session->set_session_extents ( loc->start(), _session->audible_frame() );
+
+               XMLNode &after = loc->get_state();
+
+               begin_reversible_command (_("Set session start"));
+
+               _session->add_command (new MementoCommand<Location>(*loc, &before, &after));
+
+               commit_reversible_command ();
+       }
+}
+
 void
 Editor::add_location_from_playhead_cursor ()
 {
@@ -2124,10 +2187,7 @@ void
 Editor::remove_location_at_playhead_cursor ()
 {
        if (_session) {
-
                //set up for undo
-               begin_reversible_command (_("remove marker"));
-               
                XMLNode &before = _session->locations()->get_state();
                bool removed = false;
 
@@ -2143,9 +2203,9 @@ Editor::remove_location_at_playhead_cursor ()
                
                //store undo
                if (removed) {
+                       begin_reversible_command (_("remove marker"));
                        XMLNode &after = _session->locations()->get_state();
                        _session->add_command(new MementoCommand<Locations>(*(_session->locations()), &before, &after));
-                       
                        commit_reversible_command ();
                }
        }
@@ -2160,8 +2220,7 @@ Editor::add_locations_from_region ()
        if (rs.empty()) {
                return;
        }
-
-       begin_reversible_command (selection->regions.size () > 1 ? _("add markers") : _("add marker"));
+       bool commit = false;
        
        XMLNode &before = _session->locations()->get_state();
 
@@ -2172,12 +2231,15 @@ Editor::add_locations_from_region ()
                Location *location = new Location (*_session, region->position(), region->last_frame(), region->name(), Location::IsRangeMarker);
 
                _session->locations()->add (location, true);
+               commit = true;
        }
 
-       XMLNode &after = _session->locations()->get_state();
-       _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
-       
-       commit_reversible_command ();
+       if (commit) {
+               begin_reversible_command (selection->regions.size () > 1 ? _("add markers") : _("add marker"));
+               XMLNode &after = _session->locations()->get_state();
+               _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
+               commit_reversible_command ();
+       }
 }
 
 /** Add a single range marker around all selected regions */
@@ -2190,8 +2252,6 @@ Editor::add_location_from_region ()
                return;
        }
 
-       begin_reversible_command (_("add marker"));
-       
        XMLNode &before = _session->locations()->get_state();
 
        string markername;
@@ -2212,9 +2272,9 @@ Editor::add_location_from_region ()
        Location *location = new Location (*_session, selection->regions.start(), selection->regions.end_frame(), markername, Location::IsRangeMarker);
        _session->locations()->add (location, true);
 
+       begin_reversible_command (_("add marker"));
        XMLNode &after = _session->locations()->get_state();
        _session->add_command (new MementoCommand<Locations>(*(_session->locations()), &before, &after));
-       
        commit_reversible_command ();
 }
 
@@ -2435,7 +2495,7 @@ Editor::play_from_edit_point_and_return ()
        framepos_t start_frame;
        framepos_t return_frame;
 
-       start_frame = get_preferred_edit_position (true);
+       start_frame = get_preferred_edit_position ( EDIT_IGNORE_PHEAD );
 
        if (_session->transport_rolling()) {
                _session->request_locate (start_frame, false);
@@ -3216,8 +3276,7 @@ Editor::crop_region_to (framepos_t start, framepos_t end)
        framepos_t the_start;
        framepos_t the_end;
        framepos_t cnt;
-
-       begin_reversible_command (_("trim to selection"));
+       bool in_command = false;
 
        for (vector<boost::shared_ptr<Playlist> >::iterator i = playlists.begin(); i != playlists.end(); ++i) {
 
@@ -3242,12 +3301,18 @@ Editor::crop_region_to (framepos_t start, framepos_t end)
                the_end = min (end, the_end);
                cnt = the_end - the_start + 1;
 
+               if(!in_command) {
+                       begin_reversible_command (_("trim to selection"));
+                       in_command = true;
+               }
                region->clear_changes ();
                region->trim_to (the_start, cnt);
                _session->add_command (new StatefulDiffCommand (region));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -3260,8 +3325,8 @@ Editor::region_fill_track ()
        }
 
        framepos_t const end = _session->current_end_frame ();
-
-       begin_reversible_command (Operations::region_fill);
+       RegionSelection foo;
+       bool in_command = false;
 
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
 
@@ -3270,21 +3335,39 @@ Editor::region_fill_track ()
                boost::shared_ptr<Playlist> pl = region->playlist();
 
                if (end <= region->last_frame()) {
-                       return;
+                       continue;
                }
 
                double times = (double) (end - region->last_frame()) / (double) region->length();
 
                if (times == 0) {
-                       return;
+                       continue;
                }
 
+               if (!in_command) {
+                       begin_reversible_command (Operations::region_fill);
+                       in_command = true;
+               }
+               TimeAxisView& tv = (*i)->get_time_axis_view();
+               RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (&tv);
+               latest_regionviews.clear ();
+               sigc::connection c = rtv->view()->RegionViewAdded.connect (sigc::mem_fun(*this, &Editor::collect_new_region_view));
+
                pl->clear_changes ();
                pl->add_region (RegionFactory::create (region, true), region->last_frame(), times);
                _session->add_command (new StatefulDiffCommand (pl));
+
+               c.disconnect ();
+
+               foo.insert (foo.end(), latest_regionviews.begin(), latest_regionviews.end());
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               if (!foo.empty()) {
+                       selection->set (foo);
+               }
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -3314,10 +3397,10 @@ Editor::region_fill_selection ()
 
        framepos_t selection_length = end - start;
        float times = (float)selection_length / region->length();
-
-       begin_reversible_command (Operations::fill_selection);
+       bool in_command = false;
 
        TrackViewList ts = selection->tracks.filter_to_unique_playlists ();
+       RegionSelection foo;
 
        for (TrackViewList::iterator i = ts.begin(); i != ts.end(); ++i) {
 
@@ -3325,12 +3408,27 @@ Editor::region_fill_selection ()
                        continue;
                }
 
+               if (!in_command) {
+                       begin_reversible_command (Operations::fill_selection);
+                       in_command = true;
+               }
+               RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (*i);
+               latest_regionviews.clear ();
+               sigc::connection c = rtv->view()->RegionViewAdded.connect (sigc::mem_fun(*this, &Editor::collect_new_region_view));
+
                playlist->clear_changes ();
                playlist->add_region (RegionFactory::create (region, true), start, times);
                _session->add_command (new StatefulDiffCommand (playlist));
+               c.disconnect ();
+               foo.insert (foo.end(), latest_regionviews.begin(), latest_regionviews.end());
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               if (!foo.empty()) {
+                       selection->set (foo);
+               }
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -3628,8 +3726,7 @@ void
 Editor::trim_region_to_location (const Location& loc, const char* str)
 {
        RegionSelection rs = get_regions_from_selection_and_entered ();
-
-       begin_reversible_command (str);
+       bool in_command = false;
 
        for (RegionSelection::iterator x = rs.begin(); x != rs.end(); ++x) {
                RegionView* rv = (*x);
@@ -3660,10 +3757,17 @@ Editor::trim_region_to_location (const Location& loc, const char* str)
 
                rv->region()->clear_changes ();
                rv->region()->trim_to (start, (end - start));
+
+               if (!in_command) {
+                       begin_reversible_command (str);
+                       in_command = true;
+               }
                _session->add_command(new StatefulDiffCommand (rv->region()));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -3682,8 +3786,7 @@ void
 Editor::trim_to_region(bool forward)
 {
        RegionSelection rs = get_regions_from_selection_and_entered ();
-
-       begin_reversible_command (_("trim to region"));
+       bool in_command = false;
 
        boost::shared_ptr<Region> next_region;
 
@@ -3698,7 +3801,7 @@ Editor::trim_to_region(bool forward)
                AudioTimeAxisView* atav = dynamic_cast<AudioTimeAxisView*> (&arv->get_time_axis_view());
 
                if (!atav) {
-                       return;
+                       continue;
                }
 
                float speed = 1.0;
@@ -3737,10 +3840,16 @@ Editor::trim_to_region(bool forward)
                    arv->region_changed (ARDOUR::bounds_change);
                }
 
+               if (!in_command) {
+                       begin_reversible_command (_("trim to region"));
+                       in_command = true;
+               }
                _session->add_command(new StatefulDiffCommand (region));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -3865,8 +3974,7 @@ Editor::bounce_range_selection (bool replace, bool enable_processing)
        framepos_t start = selection->time[clicked_selection].start;
        framepos_t end = selection->time[clicked_selection].end;
        framepos_t cnt = end - start + 1;
-
-       begin_reversible_command (_("bounce range"));
+       bool in_command = false;
 
        for (TrackViewList::iterator i = views.begin(); i != views.end(); ++i) {
 
@@ -3879,7 +3987,7 @@ Editor::bounce_range_selection (bool replace, bool enable_processing)
                boost::shared_ptr<Playlist> playlist;
 
                if ((playlist = rtv->playlist()) == 0) {
-                       return;
+                       continue;
                }
 
                InterThreadInfo itt;
@@ -3906,6 +4014,10 @@ Editor::bounce_range_selection (bool replace, bool enable_processing)
                        playlist->add_region (r, start);
                }
 
+               if (!in_command) {
+                       begin_reversible_command (_("bounce range"));
+                       in_command = true;
+               }
                vector<Command*> cmds;
                playlist->rdiff (cmds);
                _session->add_commands (cmds);
@@ -3913,7 +4025,9 @@ Editor::bounce_range_selection (bool replace, bool enable_processing)
                _session->add_command (new StatefulDiffCommand (playlist));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 /** Delete selected regions, automation points or a time range */
@@ -4267,8 +4381,6 @@ Editor::remove_selected_regions ()
                return;
        }
 
-       begin_reversible_command (_("remove region"));
-
        list<boost::shared_ptr<Region> > regions_to_remove;
 
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
@@ -4312,6 +4424,7 @@ Editor::remove_selected_regions ()
        }
 
        vector<boost::shared_ptr<Playlist> >::iterator pl;
+       bool in_command = false;
 
        for (pl = playlists.begin(); pl != playlists.end(); ++pl) {
                (*pl)->thaw ();
@@ -4319,6 +4432,11 @@ Editor::remove_selected_regions ()
                /* We might have removed regions, which alters other regions' layering_index,
                   so we need to do a recursive diff here.
                */
+
+               if (!in_command) {
+                       begin_reversible_command (_("remove region"));
+                       in_command = true;
+               }
                vector<Command*> cmds;
                (*pl)->rdiff (cmds);
                _session->add_commands (cmds);
@@ -4326,7 +4444,9 @@ Editor::remove_selected_regions ()
                _session->add_command(new StatefulDiffCommand (*pl));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 /** Cut, copy or clear selected regions.
@@ -4533,7 +4653,7 @@ Editor::paste (float times, bool from_context)
 {
         DEBUG_TRACE (DEBUG::CutNPaste, "paste to preferred edit pos\n");
 
-       paste_internal (get_preferred_edit_position (false, from_context), times);
+       paste_internal (get_preferred_edit_position (EDIT_IGNORE_NONE, from_context), times);
 }
 
 void
@@ -4662,6 +4782,10 @@ Editor::paste_internal (framepos_t position, float times)
 void
 Editor::duplicate_some_regions (RegionSelection& regions, float times)
 {
+       if (regions.empty ()) {
+               return;
+       }
+
        boost::shared_ptr<Playlist> playlist;
        RegionSelection sel = regions; // clear (below) may  clear the argument list if its the current region selection
        RegionSelection foo;
@@ -4716,11 +4840,10 @@ Editor::duplicate_selection (float times)
                return;
        }
 
-       begin_reversible_command (_("duplicate selection"));
-
        ri = new_regions.begin();
 
        TrackViewList ts = selection->tracks.filter_to_unique_playlists ();
+       bool in_command = false;
 
        for (TrackViewList::iterator i = ts.begin(); i != ts.end(); ++i) {
                if ((playlist = (*i)->playlist()) == 0) {
@@ -4734,6 +4857,11 @@ Editor::duplicate_selection (float times)
                        end = selection->time.end_frame();
                }
                playlist->duplicate (*ri, end, times);
+
+               if (!in_command) {
+                       begin_reversible_command (_("duplicate selection"));
+                       in_command = true;
+               }
                _session->add_command (new StatefulDiffCommand (playlist));
 
                ++ri;
@@ -4742,7 +4870,9 @@ Editor::duplicate_selection (float times)
                }
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 /** Reset all selected points to the relevant default value */
@@ -4800,9 +4930,8 @@ Editor::nudge_track (bool use_edit, bool forwards)
                return;
        }
 
-       begin_reversible_command (_("nudge track"));
-
        TrackViewList ts = selection->tracks.filter_to_unique_playlists ();
+       bool in_command = false;
 
        for (TrackViewList::iterator i = ts.begin(); i != ts.end(); ++i) {
 
@@ -4815,6 +4944,10 @@ Editor::nudge_track (bool use_edit, bool forwards)
 
                playlist->nudge_after (start, distance, forwards);
 
+               if (!in_command) {
+                       begin_reversible_command (_("nudge track"));
+                       in_command = true;
+               }
                vector<Command*> cmds;
 
                playlist->rdiff (cmds);
@@ -4823,7 +4956,9 @@ Editor::nudge_track (bool use_edit, bool forwards)
                _session->add_command (new StatefulDiffCommand (playlist));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -4903,9 +5038,8 @@ Editor::normalize_region ()
                }
        }
 
-       begin_reversible_command (_("normalize"));
-
        list<double>::const_iterator a = max_amps.begin ();
+       bool in_command = false;
 
        for (RegionSelection::iterator r = rs.begin(); r != rs.end(); ++r) {
                AudioRegionView* const arv = dynamic_cast<AudioRegionView*> (*r);
@@ -4918,12 +5052,19 @@ Editor::normalize_region ()
                double const amp = dialog.normalize_individually() ? *a : max_amp;
 
                arv->audio_region()->normalize (amp, dialog.target ());
+
+               if (!in_command) {
+                       begin_reversible_command (_("normalize"));
+                       in_command = true;
+               }
                _session->add_command (new StatefulDiffCommand (arv->region()));
 
                ++a;
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 
@@ -4940,7 +5081,7 @@ Editor::reset_region_scale_amplitude ()
                return;
        }
 
-       begin_reversible_command ("reset gain");
+       bool in_command = false;
 
        for (RegionSelection::iterator r = rs.begin(); r != rs.end(); ++r) {
                AudioRegionView* const arv = dynamic_cast<AudioRegionView*>(*r);
@@ -4948,10 +5089,17 @@ Editor::reset_region_scale_amplitude ()
                        continue;
                arv->region()->clear_changes ();
                arv->audio_region()->set_scale_amplitude (1.0f);
+
+               if(!in_command) {
+                               begin_reversible_command ("reset gain");
+                               in_command = true;
+               }
                _session->add_command (new StatefulDiffCommand (arv->region()));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -4963,7 +5111,7 @@ Editor::adjust_region_gain (bool up)
                return;
        }
 
-       begin_reversible_command ("adjust region gain");
+       bool in_command = false;
 
        for (RegionSelection::iterator r = rs.begin(); r != rs.end(); ++r) {
                AudioRegionView* const arv = dynamic_cast<AudioRegionView*>(*r);
@@ -4982,10 +5130,17 @@ Editor::adjust_region_gain (bool up)
                }
 
                arv->audio_region()->set_scale_amplitude (dB_to_coefficient (dB));
+
+               if (!in_command) {
+                               begin_reversible_command ("adjust region gain");
+                               in_command = true;
+               }
                _session->add_command (new StatefulDiffCommand (arv->region()));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 
@@ -5057,7 +5212,7 @@ Editor::apply_midi_note_edit_op (MidiOperator& op, const RegionSelection& rs)
                return;
        }
 
-       begin_reversible_command (op.name ());
+       bool in_command = false;
 
        for (RegionSelection::const_iterator r = rs.begin(); r != rs.end(); ) {
                RegionSelection::const_iterator tmp = r;
@@ -5068,6 +5223,10 @@ Editor::apply_midi_note_edit_op (MidiOperator& op, const RegionSelection& rs)
                if (mrv) {
                        Command* cmd = apply_midi_note_edit_op_to_region (op, *mrv);
                        if (cmd) {
+                               if (!in_command) {
+                                       begin_reversible_command (op.name ());
+                                       in_command = true;
+                               }
                                (*cmd)();
                                _session->add_command (cmd);
                        }
@@ -5076,7 +5235,9 @@ Editor::apply_midi_note_edit_op (MidiOperator& op, const RegionSelection& rs)
                r = tmp;
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5088,9 +5249,9 @@ Editor::fork_region ()
                return;
        }
 
-       begin_reversible_command (_("Fork Region(s)"));
-
        CursorContext::Handle cursor_ctx = CursorContext::create(*this, _cursors->wait);
+       bool in_command = false;
+
        gdk_flush ();
 
        for (RegionSelection::iterator r = rs.begin(); r != rs.end(); ) {
@@ -5104,7 +5265,11 @@ Editor::fork_region ()
                                boost::shared_ptr<Playlist> playlist = mrv->region()->playlist();
                                boost::shared_ptr<MidiSource> new_source = _session->create_midi_source_by_stealing_name (mrv->midi_view()->track());
                                boost::shared_ptr<MidiRegion> newregion = mrv->midi_region()->clone (new_source);
-                               
+
+                               if (!in_command) {
+                                       begin_reversible_command (_("Fork Region(s)"));
+                                       in_command = true;
+                               }
                                playlist->clear_changes ();
                                playlist->replace_region (mrv->region(), newregion, mrv->region()->position());
                                _session->add_command(new StatefulDiffCommand (playlist));
@@ -5116,7 +5281,9 @@ Editor::fork_region ()
                r = tmp;
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5134,16 +5301,22 @@ Editor::quantize_regions (const RegionSelection& rs)
                return;
        }
 
-       QuantizeDialog* qd = new QuantizeDialog (*this);
+       if (!quantize_dialog) {
+               quantize_dialog = new QuantizeDialog (*this);
+       }
 
-       qd->present ();
-       const int r = qd->run ();
-       qd->hide ();
+       quantize_dialog->present ();
+       const int r = quantize_dialog->run ();
+       quantize_dialog->hide ();
 
        if (r == Gtk::RESPONSE_OK) {
-               Quantize quant (qd->snap_start(), qd->snap_end(),
-                               qd->start_grid_size(), qd->end_grid_size(),
-                               qd->strength(), qd->swing(), qd->threshold());
+               Quantize quant (quantize_dialog->snap_start(),
+                               quantize_dialog->snap_end(),
+                               quantize_dialog->start_grid_size(),
+                               quantize_dialog->end_grid_size(),
+                               quantize_dialog->strength(),
+                               quantize_dialog->swing(),
+                               quantize_dialog->threshold());
 
                apply_midi_note_edit_op (quant, rs);
        }
@@ -5204,7 +5377,7 @@ Editor::insert_patch_change (bool from_context)
                return;
        }
 
-       const framepos_t p = get_preferred_edit_position (false, from_context);
+       const framepos_t p = get_preferred_edit_position (EDIT_IGNORE_NONE, from_context);
 
        /* XXX: bit of a hack; use the MIDNAM from the first selected region;
           there may be more than one, but the PatchChangeDialog can only offer
@@ -5238,9 +5411,9 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
                return;
        }
 
-       begin_reversible_command (command);
-
        CursorContext::Handle cursor_ctx = CursorContext::create(*this, _cursors->wait);
+       bool in_command = false;
+
        gdk_flush ();
 
        int n = 0;
@@ -5283,17 +5456,22 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
                                        }
 
                                }
-
                                /* We might have removed regions, which alters other regions' layering_index,
                                   so we need to do a recursive diff here.
                                */
+
+                               if (!in_command) {
+                                       begin_reversible_command (command);
+                                       in_command = true;
+                               }
                                vector<Command*> cmds;
                                playlist->rdiff (cmds);
                                _session->add_commands (cmds);
                                
                                _session->add_command(new StatefulDiffCommand (playlist));
+
                        } else {
-                               return;
+                               continue;
                        }
 
                        if (progress) {
@@ -5305,7 +5483,9 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
                ++n;
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5323,7 +5503,7 @@ Editor::reset_region_gain_envelopes ()
                return;
        }
 
-       begin_reversible_command (_("reset region gain"));
+       bool in_command = false;
        
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
                AudioRegionView* const arv = dynamic_cast<AudioRegionView*>(*i);
@@ -5332,11 +5512,18 @@ Editor::reset_region_gain_envelopes ()
                        XMLNode& before (alist->get_state());
 
                        arv->audio_region()->set_default_envelope ();
+
+                       if (!in_command) {
+                               begin_reversible_command (_("reset region gain"));
+                               in_command = true;
+                       }
                        _session->add_command (new MementoCommand<AutomationList>(*arv->audio_region()->envelope().get(), &before, &alist->get_state()));
                }
        }
-       
-       commit_reversible_command ();
+
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5376,18 +5563,25 @@ Editor::toggle_gain_envelope_active ()
                return;
        }
 
-       begin_reversible_command (_("region gain envelope active"));
-       
+       bool in_command = false;
+
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
                AudioRegionView* const arv = dynamic_cast<AudioRegionView*>(*i);
                if (arv) {
                        arv->region()->clear_changes ();
                        arv->audio_region()->set_envelope_active (!arv->audio_region()->envelope_active());
+
+                       if (!in_command) {
+                               begin_reversible_command (_("region gain envelope active"));
+                               in_command = true;
+                       }
                        _session->add_command (new StatefulDiffCommand (arv->region()));
                }
        }
-       
-       commit_reversible_command ();
+
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5617,13 +5811,13 @@ Editor::set_fade_length (bool in)
                cmd = _("set fade out length");
        }
 
-       begin_reversible_command (cmd);
+       bool in_command = false;
 
        for (RegionSelection::iterator x = rs.begin(); x != rs.end(); ++x) {
                AudioRegionView* tmp = dynamic_cast<AudioRegionView*> (*x);
 
                if (!tmp) {
-                       return;
+                       continue;
                }
 
                boost::shared_ptr<AutomationList> alist;
@@ -5643,11 +5837,17 @@ Editor::set_fade_length (bool in)
                        tmp->audio_region()->set_fade_out_active (true);
                }
 
+               if (!in_command) {
+                       begin_reversible_command (cmd);
+                       in_command = true;
+               }
                XMLNode &after = alist->get_state();
                _session->add_command(new MementoCommand<AutomationList>(*alist, &before, &after));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5658,14 +5858,13 @@ Editor::set_fade_in_shape (FadeShape shape)
        if (rs.empty()) {
                return;
        }
-
-       begin_reversible_command (_("set fade in shape"));
+       bool in_command = false;
 
        for (RegionSelection::iterator x = rs.begin(); x != rs.end(); ++x) {
                AudioRegionView* tmp = dynamic_cast<AudioRegionView*> (*x);
 
                if (!tmp) {
-                       return;
+                       continue;
                }
 
                boost::shared_ptr<AutomationList> alist = tmp->audio_region()->fade_in();
@@ -5673,12 +5872,17 @@ Editor::set_fade_in_shape (FadeShape shape)
 
                tmp->audio_region()->set_fade_in_shape (shape);
 
+               if (!in_command) {
+                       begin_reversible_command (_("set fade in shape"));
+                       in_command = true;
+               }
                XMLNode &after = alist->get_state();
                _session->add_command(new MementoCommand<AutomationList>(*alist.get(), &before, &after));
        }
 
-       commit_reversible_command ();
-
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5689,14 +5893,13 @@ Editor::set_fade_out_shape (FadeShape shape)
        if (rs.empty()) {
                return;
        }
-
-       begin_reversible_command (_("set fade out shape"));
+       bool in_command = false;
 
        for (RegionSelection::iterator x = rs.begin(); x != rs.end(); ++x) {
                AudioRegionView* tmp = dynamic_cast<AudioRegionView*> (*x);
 
                if (!tmp) {
-                       return;
+                       continue;
                }
 
                boost::shared_ptr<AutomationList> alist = tmp->audio_region()->fade_out();
@@ -5704,11 +5907,17 @@ Editor::set_fade_out_shape (FadeShape shape)
 
                tmp->audio_region()->set_fade_out_shape (shape);
 
+               if(!in_command) {
+                       begin_reversible_command (_("set fade out shape"));
+                       in_command = true;
+               }
                XMLNode &after = alist->get_state();
                _session->add_command(new MementoCommand<AutomationList>(*alist.get(), &before, &after));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5719,14 +5928,13 @@ Editor::set_fade_in_active (bool yn)
        if (rs.empty()) {
                return;
        }
-
-       begin_reversible_command (_("set fade in active"));
+       bool in_command = false;
 
        for (RegionSelection::iterator x = rs.begin(); x != rs.end(); ++x) {
                AudioRegionView* tmp = dynamic_cast<AudioRegionView*> (*x);
 
                if (!tmp) {
-                       return;
+                       continue;
                }
 
 
@@ -5734,10 +5942,17 @@ Editor::set_fade_in_active (bool yn)
 
                ar->clear_changes ();
                ar->set_fade_in_active (yn);
+
+               if (!in_command) {
+                       begin_reversible_command (_("set fade in active"));
+                       in_command = true;
+               }
                _session->add_command (new StatefulDiffCommand (ar));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5748,24 +5963,30 @@ Editor::set_fade_out_active (bool yn)
        if (rs.empty()) {
                return;
        }
-
-       begin_reversible_command (_("set fade out active"));
+       bool in_command = false;
 
        for (RegionSelection::iterator x = rs.begin(); x != rs.end(); ++x) {
                AudioRegionView* tmp = dynamic_cast<AudioRegionView*> (*x);
 
                if (!tmp) {
-                       return;
+                       continue;
                }
 
                boost::shared_ptr<AudioRegion> ar (tmp->audio_region());
 
                ar->clear_changes ();
                ar->set_fade_out_active (yn);
+
+               if (!in_command) {
+                       begin_reversible_command (_("set fade out active"));
+                       in_command = true;
+               }
                _session->add_command(new StatefulDiffCommand (ar));
        }
 
-       commit_reversible_command ();
+       if (in_command) {
+               commit_reversible_command ();
+       }
 }
 
 void
@@ -5801,11 +6022,14 @@ Editor::toggle_region_fades (int dir)
        }
 
        /* XXX should this undo-able? */
+       bool in_command = false;
 
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
                if ((ar = boost::dynamic_pointer_cast<AudioRegion>((*i)->region())) == 0) {
                        continue;
                }
+               ar->clear_changes ();
+
                if (dir == 1 || dir == 0) {
                        ar->set_fade_in_active (!yn);
                }
@@ -5813,6 +6037,15 @@ Editor::toggle_region_fades (int dir)
                if (dir == -1 || dir == 0) {
                        ar->set_fade_out_active (!yn);
                }
+               if (!in_command) {
+                       begin_reversible_command (_("toggle fade active"));
+                       in_command = true;
+               }
+               _session->add_command(new StatefulDiffCommand (ar));
+       }
+
+       if (in_command) {
+               commit_reversible_command ();
        }
 }
 
@@ -6038,8 +6271,6 @@ Editor::set_session_extents_from_selection ()
        if (!get_selection_extents ( start, end))
                return;
 
-       begin_reversible_command (_("set session start/stop from selection"));
-
        Location* loc;
        if ((loc = _session->locations()->session_range_location()) == 0) {
                _session->set_session_extents ( start, end );  // this will create a new session range;  no need for UNDO
@@ -6050,12 +6281,135 @@ Editor::set_session_extents_from_selection ()
 
                XMLNode &after = loc->get_state();
 
+               begin_reversible_command (_("set session start/end from selection"));
+
                _session->add_command (new MementoCommand<Location>(*loc, &before, &after));
 
                commit_reversible_command ();
        }
 }
 
+void
+Editor::set_punch_start_from_edit_point ()
+{
+       if (_session) {
+
+               framepos_t start = 0;
+               framepos_t end = max_framepos;
+               
+               //use the existing punch end, if any
+               Location* tpl = transport_punch_location();
+               if (tpl) {
+                       end = tpl->end();
+               }
+               
+               if ((_edit_point == EditAtPlayhead) && _session->transport_rolling()) {
+                       start = _session->audible_frame();
+               } else {
+                       start = get_preferred_edit_position();
+               }
+               
+               //snap the selection start/end
+               snap_to(start);
+               
+               //if there's not already a sensible selection endpoint, go "forever"
+               if ( start > end ) {
+                       end = max_framepos;
+               }
+                               
+               set_punch_range (start, end, _("set punch start from EP"));
+       }
+
+}
+
+void
+Editor::set_punch_end_from_edit_point ()
+{
+       if (_session) {
+
+               framepos_t start = 0;
+               framepos_t end = max_framepos;
+               
+               //use the existing punch start, if any
+               Location* tpl = transport_punch_location();
+               if (tpl) {
+                       start = tpl->start();
+               }
+               
+               if ((_edit_point == EditAtPlayhead) && _session->transport_rolling()) {
+                       end = _session->audible_frame();
+               } else {
+                       end = get_preferred_edit_position();
+               }
+
+               //snap the selection start/end
+               snap_to(end);
+               
+               set_punch_range (start, end, _("set punch end from EP"));
+
+       }
+}
+
+void
+Editor::set_loop_start_from_edit_point ()
+{
+       if (_session) {
+
+               framepos_t start = 0;
+               framepos_t end = max_framepos;
+               
+               //use the existing loop end, if any
+               Location* tpl = transport_loop_location();
+               if (tpl) {
+                       end = tpl->end();
+               }
+               
+               if ((_edit_point == EditAtPlayhead) && _session->transport_rolling()) {
+                       start = _session->audible_frame();
+               } else {
+                       start = get_preferred_edit_position();
+               }
+               
+               //snap the selection start/end
+               snap_to(start);
+               
+               //if there's not already a sensible selection endpoint, go "forever"
+               if ( start > end ) {
+                       end = max_framepos;
+               }
+
+               set_loop_range (start, end, _("set loop start from EP"));
+       }
+
+}
+
+void
+Editor::set_loop_end_from_edit_point ()
+{
+       if (_session) {
+
+               framepos_t start = 0;
+               framepos_t end = max_framepos;
+               
+               //use the existing loop start, if any
+               Location* tpl = transport_loop_location();
+               if (tpl) {
+                       start = tpl->start();
+               }
+               
+               if ((_edit_point == EditAtPlayhead) && _session->transport_rolling()) {
+                       end = _session->audible_frame();
+               } else {
+                       end = get_preferred_edit_position();
+               }
+
+               //snap the selection start/end
+               snap_to(end);
+               
+               set_loop_range (start, end, _("set loop end from EP"));
+       }
+}
+
 void
 Editor::set_punch_from_region ()
 {
@@ -6749,6 +7103,23 @@ Editor::toggle_tracks_active ()
 
 void
 Editor::remove_tracks ()
+{
+       /* this will delete GUI objects that may be the subject of an event
+          handler in which this method is called. Defer actual deletion to the
+          next idle callback, when all event handling is finished.
+       */
+       Glib::signal_idle().connect (sigc::mem_fun (*this, &Editor::idle_remove_tracks));
+}
+
+bool
+Editor::idle_remove_tracks ()
+{
+       _remove_tracks ();
+       return false; /* do not call again */
+}
+
+void
+Editor::_remove_tracks ()
 {
        TrackSelection& ts (selection->tracks);
 
@@ -6804,19 +7175,9 @@ edit your ardour.rc file to set the\n\
                return;
        }
 
-       // XXX should be using gettext plural forms, maybe?
-       if (ntracks > 1) {
-               trackstr = _("tracks");
-       } else {
-               trackstr = _("track");
-       }
-
-       if (nbusses > 1) {
-               busstr = _("busses");
-       } else {
-               busstr = _("bus");
-       }
-
+       trackstr = P_("track", "tracks", ntracks);
+       busstr = P_("bus", "busses", nbusses);
+       
        if (ntracks) {
                if (nbusses) {
                        prompt  = string_compose (_("Do you really want to remove %1 %2 and %3 %4?\n"
@@ -6871,7 +7232,7 @@ Editor::do_insert_time ()
                return;
        }
 
-       InsertTimeDialog d (*this);
+       InsertRemoveTimeDialog d (*this);
        int response = d.run ();
 
        if (response != RESPONSE_OK) {
@@ -6903,13 +7264,11 @@ Editor::insert_time (
        bool all_playlists, bool ignore_music_glue, bool markers_too, bool glued_markers_too, bool locked_markers_too, bool tempo_too
        )
 {
-       bool commit = false;
 
        if (Config->get_edit_mode() == Lock) {
                return;
        }
-
-       begin_reversible_command (_("insert time"));
+       bool in_command = false;
 
        TrackViewList ts = selection->tracks.filter_to_unique_playlists ();
 
@@ -6926,7 +7285,7 @@ Editor::insert_time (
 
                if (all_playlists) {
                        RouteTimeAxisView* rtav = dynamic_cast<RouteTimeAxisView*> (*x);
-                       if (rtav) {
+                       if (rtav && rtav->track ()) {
                                vector<boost::shared_ptr<Playlist> > all = _session->playlists->playlists_for_track (rtav->track ());
                                for (vector<boost::shared_ptr<Playlist> >::iterator p = all.begin(); p != all.end(); ++p) {
                                        pl.insert (*p);
@@ -6949,19 +7308,25 @@ Editor::insert_time (
 
                        (*i)->shift (pos, frames, (opt == MoveIntersected), ignore_music_glue);
 
+                       if (!in_command) {
+                               begin_reversible_command (_("insert time"));
+                               in_command = true;
+                       }
                        vector<Command*> cmds;
                        (*i)->rdiff (cmds);
                        _session->add_commands (cmds);
 
                        _session->add_command (new StatefulDiffCommand (*i));
-                       commit = true;
                }
 
                /* automation */
                RouteTimeAxisView* rtav = dynamic_cast<RouteTimeAxisView*> (*x);
                if (rtav) {
+                       if (!in_command) {
+                               begin_reversible_command (_("insert time"));
+                               in_command = true;
+                       }
                        rtav->route ()->shift (pos, frames);
-                       commit = true;
                }
        }
 
@@ -6975,39 +7340,219 @@ Editor::insert_time (
 
                        Locations::LocationList::const_iterator tmp;
 
-                       bool const was_locked = (*i)->locked ();
-                       if (locked_markers_too) {
-                               (*i)->unlock ();
-                       }
-
                        if ((*i)->position_lock_style() == AudioTime || glued_markers_too) {
+                               bool const was_locked = (*i)->locked ();
+                               if (locked_markers_too) {
+                                       (*i)->unlock ();
+                               }
 
                                if ((*i)->start() >= pos) {
-                                       (*i)->set_start ((*i)->start() + frames);
+                                       // move end first, in case we're moving by more than the length of the range
                                        if (!(*i)->is_mark()) {
                                                (*i)->set_end ((*i)->end() + frames);
                                        }
+                                       (*i)->set_start ((*i)->start() + frames);
                                        moved = true;
                                }
 
-                       }
-
-                       if (was_locked) {
-                               (*i)->lock ();
+                               if (was_locked) {
+                                       (*i)->lock ();
+                               }
                        }
                }
 
                if (moved) {
+                       if (!in_command) {
+                               begin_reversible_command (_("insert time"));
+                               in_command = true;
+                       }
                        XMLNode& after (_session->locations()->get_state());
                        _session->add_command (new MementoCommand<Locations>(*_session->locations(), &before, &after));
                }
        }
 
        if (tempo_too) {
+               if (!in_command) {
+                       begin_reversible_command (_("insert time"));
+                       in_command = true;
+               }
+               XMLNode& before (_session->tempo_map().get_state());
                _session->tempo_map().insert_time (pos, frames);
+               XMLNode& after (_session->tempo_map().get_state());
+               _session->add_command (new MementoCommand<TempoMap>(_session->tempo_map(), &before, &after));
        }
 
-       if (commit) {
+       if (in_command) {
+               commit_reversible_command ();
+       }
+}
+
+void
+Editor::do_remove_time ()
+{
+       if (selection->tracks.empty()) {
+               return;
+       }
+
+       framepos_t pos = get_preferred_edit_position (EDIT_IGNORE_MOUSE);
+       InsertRemoveTimeDialog d (*this, true);
+
+       int response = d.run ();
+
+       if (response != RESPONSE_OK) {
+               return;
+       }
+       
+       framecnt_t distance = d.distance();
+
+       if (distance == 0) {
+               return;
+       }
+
+       remove_time (
+               pos,
+               distance,
+               SplitIntersected,
+               d.move_glued(),
+               d.move_markers(),
+               d.move_glued_markers(),
+               d.move_locked_markers(),
+               d.move_tempos()
+       );
+}
+
+void
+Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt, 
+                    bool ignore_music_glue, bool markers_too, bool glued_markers_too, bool locked_markers_too, bool tempo_too)
+{
+       if (Config->get_edit_mode() == Lock) {
+               error << (_("Cannot insert or delete time when in Lock edit.")) << endmsg;
+               return;
+       }
+       bool in_command = false;
+
+       for (TrackSelection::iterator x = selection->tracks.begin(); x != selection->tracks.end(); ++x) {
+               /* regions */
+               boost::shared_ptr<Playlist> pl = (*x)->playlist();
+               
+               if (pl) {
+
+                       XMLNode &before = pl->get_state();
+                       
+                       std::list<AudioRange> rl;
+                       AudioRange ar(pos, pos+frames, 0);
+                       rl.push_back(ar);
+                       pl->cut (rl);
+                       pl->shift (pos, -frames, true, ignore_music_glue);
+                       
+                       if (!in_command) {
+                               begin_reversible_command (_("cut time"));
+                               in_command = true;
+                       }
+                       XMLNode &after = pl->get_state();
+                       
+                       _session->add_command (new MementoCommand<Playlist> (*pl, &before, &after));
+               }
+                       
+               /* automation */
+               RouteTimeAxisView* rtav = dynamic_cast<RouteTimeAxisView*> (*x);
+               if (rtav) {
+                       if (!in_command) {
+                               begin_reversible_command (_("cut time"));
+                               in_command = true;
+                       }
+                       rtav->route ()->shift (pos, -frames);
+               }
+       }
+
+       std::list<Location*> loc_kill_list;
+       
+       /* markers */
+       if (markers_too) {
+               bool moved = false;
+               XMLNode& before (_session->locations()->get_state());
+               Locations::LocationList copy (_session->locations()->list());
+
+               for (Locations::LocationList::iterator i = copy.begin(); i != copy.end(); ++i) {
+                       if ((*i)->position_lock_style() == AudioTime || glued_markers_too) {
+
+                               bool const was_locked = (*i)->locked ();
+                               if (locked_markers_too) {
+                                       (*i)->unlock ();
+                               }
+
+                               if (!(*i)->is_mark()) {  // it's a range;  have to handle both start and end
+                                       if ((*i)->end() >= pos
+                                       && (*i)->end() < pos+frames
+                                       && (*i)->start() >= pos
+                                       && (*i)->end() < pos+frames) {  // range is completely enclosed;  kill it
+                                               moved = true;
+                                               loc_kill_list.push_back(*i);
+                                       } else {  // only start or end is included, try to do the right thing
+                                               // move start before moving end, to avoid trying to move the end to before the start
+                                               // if we're removing more time than the length of the range
+                                               if ((*i)->start() >= pos && (*i)->start() < pos+frames) {
+                                                       // start is within cut
+                                                       (*i)->set_start (pos);  // bring the start marker to the beginning of the cut
+                                                       moved = true;
+                                               } else if ((*i)->start() >= pos+frames) {
+                                                       // start (and thus entire range) lies beyond end of cut
+                                                       (*i)->set_start ((*i)->start() - frames); // slip the start marker back
+                                                       moved = true;
+                                               }
+                                               if ((*i)->end() >= pos && (*i)->end() < pos+frames) {
+                                                       // end is inside cut
+                                                       (*i)->set_end (pos);  // bring the end to the cut
+                                                       moved = true;
+                                               } else if ((*i)->end() >= pos+frames) {
+                                                       // end is beyond end of cut
+                                                       (*i)->set_end ((*i)->end() - frames); // slip the end marker back
+                                                       moved = true;
+                                               }
+
+                                       }
+                               } else if ((*i)->start() >= pos && (*i)->start() < pos+frames ) {
+                                       loc_kill_list.push_back(*i);
+                                       moved = true;
+                               } else if ((*i)->start() >= pos) {
+                                       (*i)->set_start ((*i)->start() -frames);
+                                       moved = true;
+                               }
+
+                               if (was_locked) {
+                                       (*i)->lock ();
+                               }
+                       }
+               }
+
+               for (list<Location*>::iterator i = loc_kill_list.begin(); i != loc_kill_list.end(); ++i) {
+                       _session->locations()->remove( *i );
+               }
+       
+               if (moved) {
+                       if (!in_command) {
+                               begin_reversible_command (_("cut time"));
+                               in_command = true;
+                       }
+                       XMLNode& after (_session->locations()->get_state());
+                       _session->add_command (new MementoCommand<Locations>(*_session->locations(), &before, &after));
+               }
+       }
+       
+       if (tempo_too) {
+               XMLNode& before (_session->tempo_map().get_state());
+
+               if (_session->tempo_map().remove_time (pos, frames) ) {
+                       if (!in_command) {
+                               begin_reversible_command (_("remove time"));
+                               in_command = true;
+                       }
+                       XMLNode& after (_session->tempo_map().get_state());
+                       _session->add_command (new MementoCommand<TempoMap>(_session->tempo_map(), &before, &after));
+               }
+       }
+       
+       if (in_command) {
                commit_reversible_command ();
        }
 }
@@ -7079,7 +7624,7 @@ Editor::fit_tracks (TrackViewList & tracks)
        }
 
        undo_visual_stack.push_back (current_visual_state (true));
-       no_save_visual = true;
+       PBD::Unwinder<bool> nsv (no_save_visual, true);
 
        /* build a list of all tracks, including children */
 
@@ -7326,15 +7871,10 @@ Editor::lock ()
                lock_dialog->get_vbox()->show_all ();
                lock_dialog->set_size_request (200, 200);
        }
+
+       delete _main_menu_disabler;
+       _main_menu_disabler = new MainMenuDisabler;
        
-#ifdef __APPLE__
-       /* The global menu bar continues to be accessible to applications
-          with modal dialogs, which means that we need to desensitize
-          all items in the menu bar. Since those items are really just
-          proxies for actions, that means disabling all actions.
-       */
-       ActionManager::disable_all_actions ();
-#endif
        lock_dialog->present ();
 }
 
@@ -7343,9 +7883,7 @@ Editor::unlock ()
 {
        lock_dialog->hide ();
        
-#ifdef __APPLE__
-       ActionManager::pop_action_state ();
-#endif 
+       delete _main_menu_disabler;
 
        if (ARDOUR_UI::config()->get_lock_gui_after_seconds()) {
                start_lock_event_timing ();