move VCA assignment up to Route level
[ardour.git] / gtk2_ardour / editor_routes.cc
index e00748c2fb90183131b4de879d5f63043b24bacb..0d2695a30e42ea45cdf93ae3389b5329a47c868b 100644 (file)
 
 */
 
+#include <cstdlib>
+#include <cassert>
+#include <cmath>
 #include <list>
 #include <vector>
 #include <algorithm>
-#include <cstdlib>
-#include <cmath>
-#include <cassert>
 
 #include "pbd/unknown_type.h"
 #include "pbd/unwind.h"
 
 #include "ardour/debug.h"
-#include "ardour/route.h"
 #include "ardour/midi_track.h"
+#include "ardour/route.h"
 #include "ardour/session.h"
 
 #include "gtkmm2ext/cell_renderer_pixbuf_multi.h"
 #include "gtkmm2ext/cell_renderer_pixbuf_toggle.h"
 #include "gtkmm2ext/treeutils.h"
 
-#include "editor.h"
-#include "keyboard.h"
+#include "actions.h"
 #include "ardour_ui.h"
 #include "audio_time_axis.h"
+#include "editor.h"
+#include "editor_group_tabs.h"
+#include "editor_routes.h"
+#include "gui_thread.h"
+#include "keyboard.h"
 #include "midi_time_axis.h"
 #include "mixer_strip.h"
-#include "gui_thread.h"
-#include "actions.h"
-#include "utils.h"
+#include "plugin_setup_dialog.h"
 #include "route_sorter.h"
-#include "editor_group_tabs.h"
-#include "editor_routes.h"
+#include "tooltips.h"
+#include "utils.h"
 
 #include "i18n.h"
 
@@ -61,21 +63,24 @@ using namespace Glib;
 using Gtkmm2ext::Keyboard;
 
 struct ColumnInfo {
-    int         index;
-    const char* label;
-    const char* tooltip;
+       int         index;
+       const char* label;
+       const char* tooltip;
 };
 
 EditorRoutes::EditorRoutes (Editor* e)
        : EditorComponent (e)
-        , _ignore_reorder (false)
-        , _no_redisplay (false)
-        , _adding_routes (false)
-        , _route_deletion_in_progress (false)
-        , _menu (0)
-        , old_focus (0)
-        , selection_countdown (0)
-        , name_editable (0)
+       , _ignore_reorder (false)
+       , _no_redisplay (false)
+       , _adding_routes (false)
+       , _route_deletion_in_progress (false)
+       , _redisplay_on_resume (false)
+       , _redisplay_active (0)
+       , _queue_tv_update (0)
+       , _menu (0)
+       , old_focus (0)
+       , selection_countdown (0)
+       , name_editable (0)
 {
        static const int column_width = 22;
 
@@ -104,6 +109,23 @@ EditorRoutes::EditorRoutes (Editor* e)
        rec_state_column->set_expand(false);
        rec_state_column->set_fixed_width(column_width);
 
+
+       // Record safe toggle
+       CellRendererPixbufMulti* rec_safe_renderer = manage (new CellRendererPixbufMulti ());
+
+       rec_safe_renderer->set_pixbuf (0, ::get_icon("rec-safe-disabled"));
+       rec_safe_renderer->set_pixbuf (1, ::get_icon("rec-safe-enabled"));
+       rec_safe_renderer->signal_changed().connect (sigc::mem_fun (*this, &EditorRoutes::on_tv_rec_safe_toggled));
+
+       TreeViewColumn* rec_safe_column = manage (new TreeViewColumn(_("RS"), *rec_safe_renderer));
+       rec_safe_column->add_attribute(rec_safe_renderer->property_state(), _columns.rec_safe);
+       rec_safe_column->add_attribute(rec_safe_renderer->property_visible(), _columns.is_track);
+       rec_safe_column->set_sizing(TREE_VIEW_COLUMN_FIXED);
+       rec_safe_column->set_alignment(ALIGN_CENTER);
+       rec_safe_column->set_expand(false);
+       rec_safe_column->set_fixed_width(column_width);
+
+
        // MIDI Input Active
 
        CellRendererPixbufMulti* input_active_col_renderer = manage (new CellRendererPixbufMulti());
@@ -185,12 +207,13 @@ EditorRoutes::EditorRoutes (Editor* e)
        solo_safe_state_column->set_expand(false);
        solo_safe_state_column->set_fixed_width(column_width);
 
-        _name_column = _display.append_column ("", _columns.text) - 1;
+       _name_column = _display.append_column ("", _columns.text) - 1;
        _visible_column = _display.append_column ("", _columns.visible) - 1;
        _active_column = _display.append_column ("", _columns.active) - 1;
 
        _display.append_column (*input_active_column);
        _display.append_column (*rec_state_column);
+       _display.append_column (*rec_safe_column);
        _display.append_column (*mute_state_column);
        _display.append_column (*solo_state_column);
        _display.append_column (*solo_isolate_state_column);
@@ -201,22 +224,23 @@ EditorRoutes::EditorRoutes (Editor* e)
        Gtk::Label* l;
 
        ColumnInfo ci[] = {
-               { 0, _("Name"), _("Track/Bus Name") },
-               { 1, _("V"), _("Track/Bus visible ?") },
-               { 2, _("A"), _("Track/Bus active ?") },
-               { 3, _("I"), _("MIDI input enabled") },
-               { 4, _("R"), _("Record enabled") },
-               { 5, _("M"), _("Muted") },
-               { 6, _("S"), _("Soloed") },
-               { 7, _("SI"), _("Solo Isolated") },
-               { 8, _("SS"), _("Solo Safe (Locked)") },
+               { 0,  _("Name"),        _("Track/Bus Name") },
+               { 1, S_("Visible|V"),   _("Track/Bus visible ?") },
+               { 2, S_("Active|A"),    _("Track/Bus active ?") },
+               { 3, S_("MidiInput|I"), _("MIDI input enabled") },
+               { 4, S_("Rec|R"),       _("Record enabled") },
+               { 5, S_("Rec|RS"),      _("Record Safe") },
+               { 6, S_("Mute|M"),      _("Muted") },
+               { 7, S_("Solo|S"),      _("Soloed") },
+               { 8, S_("SoloIso|SI"),  _("Solo Isolated") },
+               { 9, S_("SoloLock|SS"), _("Solo Safe (Locked)") },
                { -1, 0, 0 }
        };
 
        for (int i = 0; ci[i].index >= 0; ++i) {
                col = _display.get_column (ci[i].index);
                l = manage (new Label (ci[i].label));
-               ARDOUR_UI::instance()->set_tip (*l, ci[i].tooltip);
+               set_tooltip (*l, ci[i].tooltip);
                col->set_widget (*l);
                l->show ();
        }
@@ -234,7 +258,7 @@ EditorRoutes::EditorRoutes (Editor* e)
        CellRendererText* name_cell = dynamic_cast<CellRendererText*> (_display.get_column_cell_renderer (_name_column));
 
        assert (name_cell);
-        name_cell->signal_editing_started().connect (sigc::mem_fun (*this, &EditorRoutes::name_edit_started));
+       name_cell->signal_editing_started().connect (sigc::mem_fun (*this, &EditorRoutes::name_edit_started));
 
        TreeViewColumn* name_column = _display.get_column (_name_column);
 
@@ -272,50 +296,52 @@ EditorRoutes::EditorRoutes (Editor* e)
        active_col->set_sizing (TREE_VIEW_COLUMN_FIXED);
        active_col->set_fixed_width (30);
        active_col->set_alignment (ALIGN_CENTER);
-       
+
        _model->signal_row_deleted().connect (sigc::mem_fun (*this, &EditorRoutes::row_deleted));
        _model->signal_rows_reordered().connect (sigc::mem_fun (*this, &EditorRoutes::reordered));
 
        _display.signal_button_press_event().connect (sigc::mem_fun (*this, &EditorRoutes::button_press), false);
        _scroller.signal_key_press_event().connect (sigc::mem_fun(*this, &EditorRoutes::key_press), false);
 
-        _scroller.signal_focus_in_event().connect (sigc::mem_fun (*this, &EditorRoutes::focus_in), false);
-        _scroller.signal_focus_out_event().connect (sigc::mem_fun (*this, &EditorRoutes::focus_out));
+       _scroller.signal_focus_in_event().connect (sigc::mem_fun (*this, &EditorRoutes::focus_in), false);
+       _scroller.signal_focus_out_event().connect (sigc::mem_fun (*this, &EditorRoutes::focus_out));
 
-        _display.signal_enter_notify_event().connect (sigc::mem_fun (*this, &EditorRoutes::enter_notify), false);
-        _display.signal_leave_notify_event().connect (sigc::mem_fun (*this, &EditorRoutes::leave_notify), false);
+       _display.signal_enter_notify_event().connect (sigc::mem_fun (*this, &EditorRoutes::enter_notify), false);
+       _display.signal_leave_notify_event().connect (sigc::mem_fun (*this, &EditorRoutes::leave_notify), false);
 
-        _display.set_enable_search (false);
+       _display.set_enable_search (false);
 
        Route::SyncOrderKeys.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::sync_treeview_from_order_keys, this), gui_context());
+       Route::PluginSetup.connect_same_thread (*this, boost::bind (&EditorRoutes::plugin_setup, this, _1, _2, _3));
+
 }
 
 bool
 EditorRoutes::focus_in (GdkEventFocus*)
 {
-        Window* win = dynamic_cast<Window*> (_scroller.get_toplevel ());
+       Window* win = dynamic_cast<Window*> (_scroller.get_toplevel ());
 
-        if (win) {
-                old_focus = win->get_focus ();
-        } else {
-                old_focus = 0;
-        }
+       if (win) {
+               old_focus = win->get_focus ();
+       } else {
+               old_focus = 0;
+       }
 
-        name_editable = 0;
+       name_editable = 0;
 
-        /* try to do nothing on focus in (doesn't work, hence selection_count nonsense) */
-        return true;
+       /* try to do nothing on focus in (doesn't work, hence selection_count nonsense) */
+       return true;
 }
 
 bool
 EditorRoutes::focus_out (GdkEventFocus*)
 {
-        if (old_focus) {
-                old_focus->grab_focus ();
-                old_focus = 0;
-        }
+       if (old_focus) {
+               old_focus->grab_focus ();
+               old_focus = 0;
+       }
 
-        return false;
+       return false;
 }
 
 bool
@@ -325,27 +351,27 @@ EditorRoutes::enter_notify (GdkEventCrossing*)
                return true;
        }
 
-        /* arm counter so that ::selection_filter() will deny selecting anything for the
-           next two attempts to change selection status.
-        */
-        selection_countdown = 2;
-        _scroller.grab_focus ();
-        Keyboard::magic_widget_grab_focus ();
-        return false;
+       /* arm counter so that ::selection_filter() will deny selecting anything for the
+        * next two attempts to change selection status.
+        */
+       selection_countdown = 2;
+       _scroller.grab_focus ();
+       Keyboard::magic_widget_grab_focus ();
+       return false;
 }
 
 bool
 EditorRoutes::leave_notify (GdkEventCrossing*)
 {
-        selection_countdown = 0;
+       selection_countdown = 0;
 
-        if (old_focus) {
-                old_focus->grab_focus ();
-                old_focus = 0;
-        }
+       if (old_focus) {
+               old_focus->grab_focus ();
+               old_focus = 0;
+       }
 
-        Keyboard::magic_widget_drop_focus ();
-        return false;
+       Keyboard::magic_widget_drop_focus ();
+       return false;
 }
 
 void
@@ -358,6 +384,13 @@ EditorRoutes::set_session (Session* s)
        if (_session) {
                _session->SoloChanged.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::solo_changed_so_update_mute, this), gui_context());
                _session->RecordStateChanged.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_rec_display, this), gui_context());
+
+               /* TODO: check if these needs to be tied in with DisplaySuspender
+                * Given that the UI is single-threaded and DisplaySuspender is only used
+                * in loops in the UI thread all should be fine.
+                */
+               _session->BatchUpdateStart.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::suspend_redisplay, this), gui_context());
+               _session->BatchUpdateEnd.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::resume_redisplay, this), gui_context());
        }
 }
 
@@ -389,12 +422,29 @@ EditorRoutes::on_tv_rec_enable_changed (std::string const & path_string)
        RouteTimeAxisView *rtv = dynamic_cast<RouteTimeAxisView*> (tv);
 
        if (rtv && rtv->track()) {
+               DisplaySuspender ds;
                boost::shared_ptr<RouteList> rl (new RouteList);
+               // TODO check rec-safe and ...
                rl->push_back (rtv->route());
                _session->set_record_enabled (rl, !rtv->track()->record_enabled(), Session::rt_cleanup);
        }
 }
 
+void
+EditorRoutes::on_tv_rec_safe_toggled (std::string const & path_string)
+{
+       Gtk::TreeModel::Row row = *_model->get_iter (Gtk::TreeModel::Path (path_string));
+       TimeAxisView* tv = row[_columns.tv];
+       RouteTimeAxisView *rtv = dynamic_cast<RouteTimeAxisView*> (tv);
+
+       if (rtv && rtv->track() && !rtv->track()->record_enabled()) {
+               DisplaySuspender ds;
+               boost::shared_ptr<RouteList> rl (new RouteList);
+               rl->push_back (rtv->route());
+               _session->set_record_safe (rl, !rtv->track()->record_safe(), Session::rt_cleanup);
+       }
+}
+
 void
 EditorRoutes::on_tv_mute_enable_toggled (std::string const & path_string)
 {
@@ -441,7 +491,7 @@ EditorRoutes::on_tv_solo_isolate_toggled (std::string const & path_string)
        RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (tv);
 
        if (rtv) {
-               rtv->route()->set_solo_isolated (!rtv->route()->solo_isolated(), this);
+               rtv->route()->set_solo_isolated (!rtv->route()->solo_isolated(), Controllable::UseGroup);
        }
 }
 
@@ -455,7 +505,7 @@ EditorRoutes::on_tv_solo_safe_toggled (std::string const & path_string)
        RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (tv);
 
        if (rtv) {
-               rtv->route()->set_solo_safe (!rtv->route()->solo_safe(), this);
+               rtv->route()->set_solo_safe (!rtv->route()->solo_safe(), Controllable::UseGroup);
        }
 }
 
@@ -478,7 +528,7 @@ EditorRoutes::build_menu ()
        items.push_back (MenuElem (_("Hide All Audio Busses"), sigc::mem_fun (*this, &EditorRoutes::hide_all_audiobus)));
        items.push_back (MenuElem (_("Show All Midi Tracks"), sigc::mem_fun (*this, &EditorRoutes::show_all_miditracks)));
        items.push_back (MenuElem (_("Hide All Midi Tracks"), sigc::mem_fun (*this, &EditorRoutes::hide_all_miditracks)));
-       items.push_back (MenuElem (_("Show Tracks With Regions Under Playhead"), sigc::mem_fun (*this, &EditorRoutes::show_tracks_with_regions_at_playhead)));
+       items.push_back (MenuElem (_("Only Show Tracks with Regions Under Playhead"), sigc::mem_fun (*this, &EditorRoutes::show_tracks_with_regions_at_playhead)));
 }
 
 void
@@ -492,20 +542,15 @@ EditorRoutes::show_menu ()
 }
 
 void
-EditorRoutes::redisplay ()
+EditorRoutes::redisplay_real ()
 {
-       if (_no_redisplay || !_session || _session->deletion_in_progress() || _redisplaying) {
-               return;
-       }
-       _redisplaying = true; // tv->show_at() below causes recursive redisplay via handle_gui_changes()
-
        TreeModel::Children rows = _model->children();
        TreeModel::Children::iterator i;
        uint32_t position;
 
        /* n will be the count of tracks plus children (updated by TimeAxisView::show_at),
-          so we will use that to know where to put things.
-       */
+        * so we will use that to know where to put things.
+        */
        int n;
 
        for (n = 0, position = 0, i = rows.begin(); i != rows.end(); ++i) {
@@ -530,37 +575,68 @@ EditorRoutes::redisplay ()
        }
 
        /* whenever we go idle, update the track view list to reflect the new order.
-          we can't do this here, because we could mess up something that is traversing
-          the track order and has caused a redisplay of the list.
-       */
+        * we can't do this here, because we could mess up something that is traversing
+        * the track order and has caused a redisplay of the list.
+        */
        Glib::signal_idle().connect (sigc::mem_fun (*_editor, &Editor::sync_track_view_list_and_routes));
 
-        _editor->reset_controls_layout_height (position);
-        _editor->reset_controls_layout_width ();
+       _editor->reset_controls_layout_height (position);
+       _editor->reset_controls_layout_width ();
        _editor->_full_canvas_height = position;
 
        if ((_editor->vertical_adjustment.get_value() + _editor->_visible_canvas_height) > _editor->vertical_adjustment.get_upper()) {
                /*
-                  We're increasing the size of the canvas while the bottom is visible.
-                  We scroll down to keep in step with the controls layout.
-               */
+                * We're increasing the size of the canvas while the bottom is visible.
+                * We scroll down to keep in step with the controls layout.
+                */
                _editor->vertical_adjustment.set_value (_editor->_full_canvas_height - _editor->_visible_canvas_height);
        }
-       _redisplaying = false;
+}
+
+void
+EditorRoutes::redisplay ()
+{
+       if (!_session || _session->deletion_in_progress()) {
+               return;
+       }
+
+       if (_no_redisplay) {
+               _redisplay_on_resume = true;
+               return;
+       }
+
+       // model deprecated g_atomic_int_exchange_and_add(, 1)
+       g_atomic_int_inc(const_cast<gint*>(&_redisplay_active));
+       if (!g_atomic_int_compare_and_exchange (const_cast<gint*>(&_redisplay_active), 1, 1)) {
+               /* recursive re-display can happen if redisplay shows/hides a TrackView
+                * which has children and their display status changes as result.
+                */
+               return;
+       }
+
+       redisplay_real ();
+
+       while (!g_atomic_int_compare_and_exchange (const_cast<gint*>(&_redisplay_active), 1, 0)) {
+               g_atomic_int_set(const_cast<gint*>(&_redisplay_active), 1);
+               redisplay_real ();
+       }
 }
 
 void
 EditorRoutes::row_deleted (Gtk::TreeModel::Path const &)
 {
+       if (!_session || _session->deletion_in_progress()) {
+               return;
+       }
        /* this happens as the second step of a DnD within the treeview, and
-          when a route is actually removed. we don't differentiate between
-          the two cases.
-          
-          note that the sync_orders_keys() step may not actually change any
-          RID's (e.g. the last track may be removed, so all other tracks keep
-          the same RID), which means that no redisplay would happen. so we 
-           have to force a redisplay.
-       */
+        * when a route is actually removed. we don't differentiate between
+        * the two cases.
+        *
+        * note that the sync_orders_keys() step may not actually change any
+        * RID's (e.g. the last track may be removed, so all other tracks keep
+        * the same RID), which means that no redisplay would happen. so we
+        * have to force a redisplay.
+        */
 
        DEBUG_TRACE (DEBUG::OrderKeys, "editor routes treeview row deleted\n");
 
@@ -618,7 +694,6 @@ void
 EditorRoutes::routes_added (list<RouteTimeAxisView*> routes)
 {
        PBD::Unwinder<bool> at (_adding_routes, true);
-
        bool from_scratch = (_model->children().size() == 0);
        Gtk::TreeModel::Children::iterator insert_iter = _model->children().end();
 
@@ -631,10 +706,6 @@ EditorRoutes::routes_added (list<RouteTimeAxisView*> routes)
                }
        }
 
-       if(!from_scratch) {
-               _editor->selection->tracks.clear();
-       } 
-
        DisplaySuspender ds;
 
        _display.set_model (Glib::RefPtr<ListStore>());
@@ -667,10 +738,6 @@ EditorRoutes::routes_added (list<RouteTimeAxisView*> routes)
                row[_columns.solo_safe_state] = (*x)->route()->solo_safe();
                row[_columns.name_editable] = true;
 
-               if (!from_scratch) {
-                       _editor->selection->add(*x);
-               }
-
                boost::weak_ptr<Route> wr ((*x)->route());
 
                (*x)->route()->gui_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::handle_gui_changes, this, _1, _2), gui_context());
@@ -679,17 +746,18 @@ EditorRoutes::routes_added (list<RouteTimeAxisView*> routes)
                if ((*x)->is_track()) {
                        boost::shared_ptr<Track> t = boost::dynamic_pointer_cast<Track> ((*x)->route());
                        t->RecordEnableChanged.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_rec_display, this), gui_context());
+                       t->RecordSafeChanged.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_rec_display, this), gui_context());
                }
 
-               if ((*x)->is_midi_track()) {
-                       boost::shared_ptr<MidiTrack> t = boost::dynamic_pointer_cast<MidiTrack> ((*x)->route());
+               if ((*x)->is_midi_track()) {
+                       boost::shared_ptr<MidiTrack> t = boost::dynamic_pointer_cast<MidiTrack> ((*x)->route());
                        t->StepEditStatusChange.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_rec_display, this), gui_context());
-                       t->InputActiveChanged.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_input_active_display, this), gui_context());
-               }
+                       t->InputActiveChanged.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_input_active_display, this), gui_context());
+               }
+
                (*x)->route()->mute_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_mute_display, this), gui_context());
-               (*x)->route()->solo_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_solo_display, this, _1), gui_context());
-               (*x)->route()->listen_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_solo_display, this, _1), gui_context());
+               (*x)->route()->solo_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_solo_display, this), gui_context());
+               (*x)->route()->listen_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_solo_display, this), gui_context());
                (*x)->route()->solo_isolated_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_solo_isolate_display, this), gui_context());
                (*x)->route()->solo_safe_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_solo_safe_display, this), gui_context());
                (*x)->route()->active_changed.connect (*this, MISSING_INVALIDATOR, boost::bind (&EditorRoutes::update_active_display, this), gui_context ());
@@ -698,7 +766,7 @@ EditorRoutes::routes_added (list<RouteTimeAxisView*> routes)
 
        update_rec_display ();
        update_mute_display ();
-       update_solo_display (true);
+       update_solo_display ();
        update_solo_isolate_display ();
        update_solo_safe_display ();
        update_input_active_display ();
@@ -707,8 +775,9 @@ EditorRoutes::routes_added (list<RouteTimeAxisView*> routes)
        _display.set_model (_model);
 
        /* now update route order keys from the treeview/track display order */
-
-       sync_order_keys_from_treeview ();
+       if (!from_scratch) {
+               sync_order_keys_from_treeview ();
+       }
 }
 
 void
@@ -740,13 +809,13 @@ EditorRoutes::route_removed (TimeAxisView *tv)
 
        for (ri = rows.begin(); ri != rows.end(); ++ri) {
                if ((*ri)[_columns.tv] == tv) {
-                        PBD::Unwinder<bool> uw (_route_deletion_in_progress, true);
+                       PBD::Unwinder<bool> uw (_route_deletion_in_progress, true);
                        _model->erase (ri);
                        break;
                }
        }
 
-       /* the deleted signal for the treeview/model will take 
+       /* the deleted signal for the treeview/model will take
           care of any updates.
        */
 }
@@ -781,12 +850,8 @@ EditorRoutes::route_property_changed (const PropertyChange& what_changed, boost:
 void
 EditorRoutes::update_active_display ()
 {
-       TreeModel::Children rows = _model->children();
-       TreeModel::Children::iterator i;
-
-       for (i = rows.begin(); i != rows.end(); ++i) {
-               boost::shared_ptr<Route> route = (*i)[_columns.route];
-               (*i)[_columns.active] = route->active ();
+       if (g_atomic_int_compare_and_exchange (const_cast<gint*>(&_queue_tv_update), 0, 1)) {
+               Glib::signal_idle().connect (sigc::mem_fun (*this, &EditorRoutes::idle_update_mute_rec_solo_etc));
        }
 }
 
@@ -796,7 +861,7 @@ EditorRoutes::update_visibility ()
        TreeModel::Children rows = _model->children();
        TreeModel::Children::iterator i;
 
-       DisplaySuspender ds ();
+       DisplaySuspender ds;
 
        for (i = rows.begin(); i != rows.end(); ++i) {
                TimeAxisView *tv = (*i)[_columns.tv];
@@ -850,12 +915,12 @@ EditorRoutes::reset_remote_control_ids ()
        }
 
        TreeModel::Children rows = _model->children();
-       
+
        if (rows.empty()) {
                return;
        }
 
-       
+
        DEBUG_TRACE (DEBUG::OrderKeys, "editor reset remote control ids\n");
 
        TreeModel::Children::iterator ri;
@@ -865,19 +930,28 @@ EditorRoutes::reset_remote_control_ids ()
 
        for (ri = rows.begin(); ri != rows.end(); ++ri) {
 
+               /* skip two special values */
+
+               if (rid == Route::MasterBusRemoteControlID) {
+                       rid++;
+               }
+
+               if (rid == Route::MonitorBusRemoteControlID) {
+                       rid++;
+               }
+
                boost::shared_ptr<Route> route = (*ri)[_columns.route];
                bool visible = (*ri)[_columns.visible];
 
-
                if (!route->is_master() && !route->is_monitor()) {
 
                        uint32_t new_rid = (visible ? rid : invisible_key--);
 
                        if (new_rid != route->remote_control_id()) {
-                               route->set_remote_control_id_explicit (new_rid);        
+                               route->set_remote_control_id_explicit (new_rid);
                                rid_change = true;
                        }
-                       
+
                        if (visible) {
                                rid++;
                        }
@@ -900,12 +974,12 @@ EditorRoutes::sync_order_keys_from_treeview ()
        }
 
        TreeModel::Children rows = _model->children();
-       
+
        if (rows.empty()) {
                return;
        }
 
-       
+
        DEBUG_TRACE (DEBUG::OrderKeys, "editor sync order keys from treeview\n");
 
        TreeModel::Children::iterator ri;
@@ -933,10 +1007,10 @@ EditorRoutes::sync_order_keys_from_treeview ()
                        uint32_t new_rid = (visible ? rid : invisible_key--);
 
                        if (new_rid != route->remote_control_id()) {
-                               route->set_remote_control_id_explicit (new_rid);        
+                               route->set_remote_control_id_explicit (new_rid);
                                rid_change = true;
                        }
-                       
+
                        if (visible) {
                                rid++;
                        }
@@ -945,7 +1019,7 @@ EditorRoutes::sync_order_keys_from_treeview ()
 
                ++order;
        }
-       
+
        if (changed) {
                /* tell the world that we changed the editor sort keys */
                _session->sync_order_keys ();
@@ -960,7 +1034,7 @@ EditorRoutes::sync_order_keys_from_treeview ()
 void
 EditorRoutes::sync_treeview_from_order_keys ()
 {
-       /* Some route order key(s) have been changed, make sure that 
+       /* Some route order key(s) have been changed, make sure that
           we update out tree/list model and GUI to reflect the change.
        */
 
@@ -984,21 +1058,21 @@ EditorRoutes::sync_treeview_from_order_keys ()
                return;
        }
 
-       OrderKeySortedRoutes sorted_routes;
+       OrderingKeys sorted;
 
        for (TreeModel::Children::iterator ri = rows.begin(); ri != rows.end(); ++ri, ++old_order) {
                boost::shared_ptr<Route> route = (*ri)[_columns.route];
-               sorted_routes.push_back (RoutePlusOrderKey (route, old_order, route->order_key ()));
+               sorted.push_back (OrderKeys (old_order, route->order_key ()));
        }
 
        SortByNewDisplayOrder cmp;
 
-       sort (sorted_routes.begin(), sorted_routes.end(), cmp);
-       neworder.assign (sorted_routes.size(), 0);
+       sort (sorted.begin(), sorted.end(), cmp);
+       neworder.assign (sorted.size(), 0);
 
        uint32_t n = 0;
-       
-       for (OrderKeySortedRoutes::iterator sr = sorted_routes.begin(); sr != sorted_routes.end(); ++sr, ++n) {
+
+       for (OrderingKeys::iterator sr = sorted.begin(); sr != sorted.end(); ++sr, ++n) {
 
                neworder[n] = sr->old_display_order;
 
@@ -1006,8 +1080,8 @@ EditorRoutes::sync_treeview_from_order_keys ()
                        changed = true;
                }
 
-               DEBUG_TRACE (DEBUG::OrderKeys, string_compose ("EDITOR change order for %1 from %2 to %3\n",
-                                                              sr->route->name(), sr->old_display_order, n));
+               DEBUG_TRACE (DEBUG::OrderKeys, string_compose ("EDITOR change order from %1 to %2\n",
+                                                              sr->old_display_order, n));
        }
 
        if (changed) {
@@ -1089,17 +1163,20 @@ EditorRoutes::set_all_audio_midi_visibility (int tracks, bool yn)
                if ((atv = dynamic_cast<AudioTimeAxisView*>(tv)) != 0) {
                        switch (tracks) {
                        case 0:
+                               atv->set_marked_for_display (yn);
                                (*i)[_columns.visible] = yn;
                                break;
 
                        case 1:
                                if (atv->is_audio_track()) {
+                                       atv->set_marked_for_display (yn);
                                        (*i)[_columns.visible] = yn;
                                }
                                break;
 
                        case 2:
                                if (!atv->is_audio_track()) {
+                                       atv->set_marked_for_display (yn);
                                        (*i)[_columns.visible] = yn;
                                }
                                break;
@@ -1108,11 +1185,13 @@ EditorRoutes::set_all_audio_midi_visibility (int tracks, bool yn)
                else if ((mtv = dynamic_cast<MidiTimeAxisView*>(tv)) != 0) {
                        switch (tracks) {
                        case 0:
+                               mtv->set_marked_for_display (yn);
                                (*i)[_columns.visible] = yn;
                                break;
 
                        case 3:
                                if (mtv->is_midi_track()) {
+                                       mtv->set_marked_for_display (yn);
                                        (*i)[_columns.visible] = yn;
                                }
                                break;
@@ -1174,59 +1253,58 @@ EditorRoutes::hide_all_miditracks ()
 bool
 EditorRoutes::key_press (GdkEventKey* ev)
 {
-        TreeViewColumn *col;
-        boost::shared_ptr<RouteList> rl (new RouteList);
-        TreePath path;
-
-        switch (ev->keyval) {
-        case GDK_Tab:
-        case GDK_ISO_Left_Tab:
-
-                /* If we appear to be editing something, leave that cleanly and appropriately.
-                */
-                if (name_editable) {
-                        name_editable->editing_done ();
-                        name_editable = 0;
-                }
-
-                col = _display.get_column (_name_column); // select&focus on name column
-
-                if (Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
-                        treeview_select_previous (_display, _model, col);
-                } else {
-                        treeview_select_next (_display, _model, col);
-                }
-
-                return true;
-                break;
-
-        case 'm':
-                if (get_relevant_routes (rl)) {
-                        _session->set_mute (rl, !rl->front()->muted(), Session::rt_cleanup);
-                }
-                return true;
-                break;
-
-        case 's':
-                if (get_relevant_routes (rl)) {
-                       if (Config->get_solo_control_is_listen_control()) {
-                               _session->set_listen (rl, !rl->front()->listening_via_monitor(), Session::rt_cleanup);
+       TreeViewColumn *col;
+       boost::shared_ptr<RouteList> rl (new RouteList);
+       TreePath path;
+
+       switch (ev->keyval) {
+               case GDK_Tab:
+               case GDK_ISO_Left_Tab:
+
+                       /* If we appear to be editing something, leave that cleanly and appropriately. */
+                       if (name_editable) {
+                               name_editable->editing_done ();
+                               name_editable = 0;
+                       }
+
+                       col = _display.get_column (_name_column); // select&focus on name column
+
+                       if (Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
+                               treeview_select_previous (_display, _model, col);
                        } else {
-                               _session->set_solo (rl, !rl->front()->self_soloed(), Session::rt_cleanup);
+                               treeview_select_next (_display, _model, col);
                        }
-               }
-                return true;
-                break;
 
-        case 'r':
-                if (get_relevant_routes (rl)) {
-                        _session->set_record_enabled (rl, !rl->front()->record_enabled(), Session::rt_cleanup);
-                }
-                break;
+                       return true;
+                       break;
 
-        default:
-                break;
-        }
+               case 'm':
+                       if (get_relevant_routes (rl)) {
+                               _session->set_mute (rl, !rl->front()->muted(), Session::rt_cleanup);
+                       }
+                       return true;
+                       break;
+
+               case 's':
+                       if (get_relevant_routes (rl)) {
+                               if (Config->get_solo_control_is_listen_control()) {
+                                       _session->set_listen (rl, !rl->front()->listening_via_monitor(), Session::rt_cleanup);
+                               } else {
+                                       _session->set_solo (rl, !rl->front()->self_soloed(), Session::rt_cleanup);
+                               }
+                       }
+                       return true;
+                       break;
+
+               case 'r':
+                       if (get_relevant_routes (rl)) {
+                               _session->set_record_enabled (rl, !rl->front()->record_enabled(), Session::rt_cleanup);
+                       }
+                       break;
+
+               default:
+                       break;
+       }
 
        return false;
 }
@@ -1234,44 +1312,44 @@ EditorRoutes::key_press (GdkEventKey* ev)
 bool
 EditorRoutes::get_relevant_routes (boost::shared_ptr<RouteList> rl)
 {
-        TimeAxisView* tv;
-        RouteTimeAxisView* rtv;
+       TimeAxisView* tv;
+       RouteTimeAxisView* rtv;
        RefPtr<TreeSelection> selection = _display.get_selection();
-        TreePath path;
-        TreeIter iter;
+       TreePath path;
+       TreeIter iter;
 
-        if (selection->count_selected_rows() != 0) {
+       if (selection->count_selected_rows() != 0) {
 
-                /* use selection */
+               /* use selection */
 
-                RefPtr<TreeModel> tm = RefPtr<TreeModel>::cast_dynamic (_model);
-                iter = selection->get_selected (tm);
+               RefPtr<TreeModel> tm = RefPtr<TreeModel>::cast_dynamic (_model);
+               iter = selection->get_selected (tm);
 
-        } else {
-                /* use mouse pointer */
+       } else {
+               /* use mouse pointer */
 
-                int x, y;
-                int bx, by;
+               int x, y;
+               int bx, by;
 
-                _display.get_pointer (x, y);
-                _display.convert_widget_to_bin_window_coords (x, y, bx, by);
+               _display.get_pointer (x, y);
+               _display.convert_widget_to_bin_window_coords (x, y, bx, by);
 
-                if (_display.get_path_at_pos (bx, by, path)) {
-                        iter = _model->get_iter (path);
-                }
-        }
+               if (_display.get_path_at_pos (bx, by, path)) {
+                       iter = _model->get_iter (path);
+               }
+       }
 
-        if (iter) {
-                tv = (*iter)[_columns.tv];
-                if (tv) {
-                        rtv = dynamic_cast<RouteTimeAxisView*>(tv);
-                        if (rtv) {
-                                rl->push_back (rtv->route());
-                        }
-                }
-        }
+       if (iter) {
+               tv = (*iter)[_columns.tv];
+               if (tv) {
+                       rtv = dynamic_cast<RouteTimeAxisView*>(tv);
+                       if (rtv) {
+                               rl->push_back (rtv->route());
+                       }
+               }
+       }
 
-        return !rl->empty();
+       return !rl->empty();
 }
 
 bool
@@ -1312,6 +1390,8 @@ EditorRoutes::button_press (GdkEventButton* ev)
 void
 EditorRoutes::selection_changed ()
 {
+       _editor->begin_reversible_selection_op (X_("Select Track from Route List"));
+
        if (_display.get_selection()->count_selected_rows() > 0) {
 
                TreeIter iter;
@@ -1327,7 +1407,7 @@ EditorRoutes::selection_changed ()
                                TimeAxisView* tv = (*iter)[_columns.tv];
                                selected.push_back (tv);
                        }
-                       
+
                }
 
                _editor->get_selection().set (selected);
@@ -1336,33 +1416,36 @@ EditorRoutes::selection_changed ()
        } else {
                _editor->get_selection().clear_tracks ();
        }
+
+       _editor->commit_reversible_selection_op ();
 }
 
 bool
 EditorRoutes::selection_filter (Glib::RefPtr<TreeModel> const &, TreeModel::Path const&, bool /*selected*/)
 {
-        if (selection_countdown) {
-                if (--selection_countdown == 0) {
-                        return true;
-                } else {
-                        /* no selection yet ... */
-                        return false;
-                }
-        }
+       if (selection_countdown) {
+               if (--selection_countdown == 0) {
+                       return true;
+               } else {
+                       /* no selection yet ... */
+                       return false;
+               }
+       }
        return true;
 }
 
-struct EditorOrderRouteSorter {
-    bool operator() (boost::shared_ptr<Route> a, boost::shared_ptr<Route> b) {
-           if (a->is_master()) {
-                   /* master before everything else */
-                   return true;
-           } else if (b->is_master()) {
-                   /* everything else before master */
-                   return false;
-           }
-           return a->order_key () < b->order_key ();
-    }
+struct EditorOrderRouteSorter
+{
+       bool operator() (boost::shared_ptr<Route> a, boost::shared_ptr<Route> b) {
+               if (a->is_master()) {
+                       /* master before everything else */
+                       return true;
+               } else if (b->is_master()) {
+                       /* everything else before master */
+                       return false;
+               }
+               return a->order_key () < b->order_key ();
+       }
 };
 
 void
@@ -1375,29 +1458,10 @@ EditorRoutes::initial_display ()
                return;
        }
 
-       boost::shared_ptr<RouteList> routes = _session->get_routes();
+       RouteList r (*_session->get_routes());
 
-       if (ARDOUR_UI::instance()->session_is_new ()) {
-
-               /* new session: stamp all routes with the right editor order
-                * key
-                */
-
-               _editor->add_routes (*(routes.get()));
-               
-       } else {
-
-               /* existing session: sort a copy of the route list by
-                * editor-order and add its contents to the display.
-                */
-
-               RouteList r (*routes);
-               EditorOrderRouteSorter sorter;
-               
-               r.sort (sorter);
-               _editor->add_routes (r);
-               
-       }
+       r.sort (EditorOrderRouteSorter ());
+       _editor->add_routes (r);
 }
 
 void
@@ -1535,7 +1599,7 @@ EditorRoutes::move_selected_tracks (bool up)
                }
                assert (*i < (int) neworder.size ());
        }
-#endif 
+#endif
 
        _model->reorder (neworder);
 }
@@ -1551,7 +1615,7 @@ EditorRoutes::update_input_active_display ()
 
                if (boost::dynamic_pointer_cast<Track> (route)) {
                        boost::shared_ptr<MidiTrack> mt = boost::dynamic_pointer_cast<MidiTrack> (route);
-                       
+
                        if (mt) {
                                (*i)[_columns.is_input_active] = mt->input_active();
                        }
@@ -1562,12 +1626,25 @@ EditorRoutes::update_input_active_display ()
 void
 EditorRoutes::update_rec_display ()
 {
+       if (g_atomic_int_compare_and_exchange (const_cast<gint*>(&_queue_tv_update), 0, 1)) {
+               Glib::signal_idle().connect (sigc::mem_fun (*this, &EditorRoutes::idle_update_mute_rec_solo_etc));
+       }
+}
+
+bool
+EditorRoutes::idle_update_mute_rec_solo_etc()
+{
+       g_atomic_int_set (const_cast<gint*>(&_queue_tv_update), 0);
        TreeModel::Children rows = _model->children();
        TreeModel::Children::iterator i;
 
        for (i = rows.begin(); i != rows.end(); ++i) {
                boost::shared_ptr<Route> route = (*i)[_columns.route];
-
+               (*i)[_columns.mute_state] = RouteUI::mute_active_state (_session, route);
+               (*i)[_columns.solo_state] = RouteUI::solo_active_state (route);
+               (*i)[_columns.solo_isolate_state] = RouteUI::solo_isolate_active_state (route) ? 1 : 0;
+               (*i)[_columns.solo_safe_state] = RouteUI::solo_safe_active_state (route) ? 1 : 0;
+               (*i)[_columns.active] = route->active ();
                if (boost::dynamic_pointer_cast<Track> (route)) {
                        boost::shared_ptr<MidiTrack> mt = boost::dynamic_pointer_cast<MidiTrack> (route);
 
@@ -1583,56 +1660,44 @@ EditorRoutes::update_rec_display ()
                                (*i)[_columns.rec_state] = 0;
                        }
 
+                       (*i)[_columns.rec_safe] = route->record_safe () ? 1 : 0;
                        (*i)[_columns.name_editable] = !route->record_enabled ();
                }
        }
+
+       return false; // do not call again (until needed)
 }
 
+
 void
 EditorRoutes::update_mute_display ()
 {
-       TreeModel::Children rows = _model->children();
-       TreeModel::Children::iterator i;
-
-       for (i = rows.begin(); i != rows.end(); ++i) {
-               boost::shared_ptr<Route> route = (*i)[_columns.route];
-               (*i)[_columns.mute_state] = RouteUI::mute_active_state (_session, route);
+       if (g_atomic_int_compare_and_exchange (const_cast<gint*>(&_queue_tv_update), 0, 1)) {
+               Glib::signal_idle().connect (sigc::mem_fun (*this, &EditorRoutes::idle_update_mute_rec_solo_etc));
        }
 }
 
 void
-EditorRoutes::update_solo_display (bool /* selfsoloed */)
+EditorRoutes::update_solo_display ()
 {
-       TreeModel::Children rows = _model->children();
-       TreeModel::Children::iterator i;
-
-       for (i = rows.begin(); i != rows.end(); ++i) {
-               boost::shared_ptr<Route> route = (*i)[_columns.route];
-               (*i)[_columns.solo_state] = RouteUI::solo_active_state (route);
+       if (g_atomic_int_compare_and_exchange (const_cast<gint*>(&_queue_tv_update), 0, 1)) {
+               Glib::signal_idle().connect (sigc::mem_fun (*this, &EditorRoutes::idle_update_mute_rec_solo_etc));
        }
 }
 
 void
 EditorRoutes::update_solo_isolate_display ()
 {
-       TreeModel::Children rows = _model->children();
-       TreeModel::Children::iterator i;
-
-       for (i = rows.begin(); i != rows.end(); ++i) {
-               boost::shared_ptr<Route> route = (*i)[_columns.route];
-               (*i)[_columns.solo_isolate_state] = RouteUI::solo_isolate_active_state (route) ? 1 : 0;
+       if (g_atomic_int_compare_and_exchange (const_cast<gint*>(&_queue_tv_update), 0, 1)) {
+               Glib::signal_idle().connect (sigc::mem_fun (*this, &EditorRoutes::idle_update_mute_rec_solo_etc));
        }
 }
 
 void
 EditorRoutes::update_solo_safe_display ()
 {
-       TreeModel::Children rows = _model->children();
-       TreeModel::Children::iterator i;
-
-       for (i = rows.begin(); i != rows.end(); ++i) {
-               boost::shared_ptr<Route> route = (*i)[_columns.route];
-               (*i)[_columns.solo_safe_state] = RouteUI::solo_safe_active_state (route) ? 1 : 0;
+       if (g_atomic_int_compare_and_exchange (const_cast<gint*>(&_queue_tv_update), 0, 1)) {
+               Glib::signal_idle().connect (sigc::mem_fun (*this, &EditorRoutes::idle_update_mute_rec_solo_etc));
        }
 }
 
@@ -1658,21 +1723,21 @@ EditorRoutes::clear ()
 void
 EditorRoutes::name_edit_started (CellEditable* ce, const Glib::ustring&)
 {
-        name_editable = ce;
+       name_editable = ce;
 
-        /* give it a special name */
+       /* give it a special name */
 
-        Gtk::Entry *e = dynamic_cast<Gtk::Entry*> (ce);
+       Gtk::Entry *e = dynamic_cast<Gtk::Entry*> (ce);
 
-        if (e) {
-                e->set_name (X_("RouteNameEditorEntry"));
-        }
+       if (e) {
+               e->set_name (X_("RouteNameEditorEntry"));
+       }
 }
 
 void
 EditorRoutes::name_edit (std::string const & path, std::string const & new_text)
 {
-        name_editable = 0;
+       name_editable = 0;
 
        TreeIter iter = _model->get_iter (path);
 
@@ -1711,6 +1776,21 @@ EditorRoutes::show_tracks_with_regions_at_playhead ()
        TreeModel::Children rows = _model->children ();
        for (TreeModel::Children::iterator i = rows.begin(); i != rows.end(); ++i) {
                TimeAxisView* tv = (*i)[_columns.tv];
-               (*i)[_columns.visible] = (show.find (tv) != show.end());
+               bool to_show = (show.find (tv) != show.end());
+
+               tv->set_marked_for_display (to_show);
+               (*i)[_columns.visible] = to_show;
        }
+
+       /* force route order keys catch up with visibility changes
+        */
+
+       sync_order_keys_from_treeview ();
+}
+
+int
+EditorRoutes::plugin_setup (boost::shared_ptr<Route> r, boost::shared_ptr<PluginInsert> pi, ARDOUR::Route::PluginSetupOptions flags)
+{
+       PluginSetupDialog psd (r, pi, flags);
+       return psd.run ();
 }