a-fluidsynth: implement LV2_BANKPATCH__notify
[ardour.git] / gtk2_ardour / editor_rulers.cc
index bda3f25b3ddb5b523d60bfc4ee0a1befdbb5611b..997d79efa9f9505b08e7cb5e138674e89f1819b9 100644 (file)
@@ -53,7 +53,7 @@
 #include "editor_cursors.h"
 #include "ui_config.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace ARDOUR;
 using namespace PBD;
@@ -149,7 +149,7 @@ Editor::initialize_rulers ()
        minsec_nmarks = 0;
 
        bbt_ruler = new ArdourCanvas::Ruler (_time_markers_group, *_bbt_metric,
-                                            ArdourCanvas::Rect (0, 0, ArdourCanvas::COORD_MAX, timebar_height));
+                                            ArdourCanvas::Rect (0, 0, ArdourCanvas::COORD_MAX, timebar_height));
        bbt_ruler->set_font_description (font);
        CANVAS_DEBUG_NAME (bbt_ruler, "bbt ruler");
        timecode_nmarks = 0;
@@ -294,17 +294,17 @@ Editor::store_ruler_visibility ()
 {
        XMLNode* node = new XMLNode(X_("RulerVisibility"));
 
-       node->add_property (X_("timecode"), ruler_timecode_action->get_active() ? "yes": "no");
-       node->add_property (X_("bbt"), ruler_bbt_action->get_active() ? "yes": "no");
-       node->add_property (X_("samples"), ruler_samples_action->get_active() ? "yes": "no");
-       node->add_property (X_("minsec"), ruler_minsec_action->get_active() ? "yes": "no");
-       node->add_property (X_("tempo"), ruler_tempo_action->get_active() ? "yes": "no");
-       node->add_property (X_("meter"), ruler_meter_action->get_active() ? "yes": "no");
-       node->add_property (X_("marker"), ruler_marker_action->get_active() ? "yes": "no");
-       node->add_property (X_("rangemarker"), ruler_range_action->get_active() ? "yes": "no");
-       node->add_property (X_("transportmarker"), ruler_loop_punch_action->get_active() ? "yes": "no");
-       node->add_property (X_("cdmarker"), ruler_cd_marker_action->get_active() ? "yes": "no");
-       node->add_property (X_("videotl"), ruler_video_action->get_active() ? "yes": "no");
+       node->set_property (X_("timecode"), ruler_timecode_action->get_active());
+       node->set_property (X_("bbt"), ruler_bbt_action->get_active());
+       node->set_property (X_("samples"), ruler_samples_action->get_active());
+       node->set_property (X_("minsec"), ruler_minsec_action->get_active());
+       node->set_property (X_("tempo"), ruler_tempo_action->get_active());
+       node->set_property (X_("meter"), ruler_meter_action->get_active());
+       node->set_property (X_("marker"), ruler_marker_action->get_active());
+       node->set_property (X_("rangemarker"), ruler_range_action->get_active());
+       node->set_property (X_("transportmarker"), ruler_loop_punch_action->get_active());
+       node->set_property (X_("cdmarker"), ruler_cd_marker_action->get_active());
+       node->set_property (X_("videotl"), ruler_video_action->get_active());
 
        _session->add_extra_xml (*node);
        _session->set_dirty ();
@@ -313,84 +313,42 @@ Editor::store_ruler_visibility ()
 void
 Editor::restore_ruler_visibility ()
 {
-       XMLProperty const * prop;
        XMLNode * node = _session->extra_xml (X_("RulerVisibility"));
 
        no_ruler_shown_update = true;
 
+       bool yn;
        if (node) {
-               if ((prop = node->property ("timecode")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_timecode_action->set_active (true);
-                       } else {
-                               ruler_timecode_action->set_active (false);
-                       }
+               if (node->get_property ("timecode", yn)) {
+                       ruler_timecode_action->set_active (yn);
                }
-               if ((prop = node->property ("bbt")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_bbt_action->set_active (true);
-                       } else {
-                               ruler_bbt_action->set_active (false);
-                       }
+               if (node->get_property ("bbt", yn)) {
+                       ruler_bbt_action->set_active (yn);
                }
-               if ((prop = node->property ("samples")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_samples_action->set_active (true);
-                       } else {
-                               ruler_samples_action->set_active (false);
-                       }
+               if (node->get_property ("samples", yn)) {
+                       ruler_samples_action->set_active (yn);
                }
-               if ((prop = node->property ("minsec")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_minsec_action->set_active (true);
-                       } else {
-                               ruler_minsec_action->set_active (false);
-                       }
+               if (node->get_property ("minsec", yn)) {
+                       ruler_minsec_action->set_active (yn);
                }
-               if ((prop = node->property ("tempo")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_tempo_action->set_active (true);
-                       } else {
-                               ruler_tempo_action->set_active (false);
-                       }
+               if (node->get_property ("tempo", yn)) {
+                       ruler_tempo_action->set_active (yn);
                }
-               if ((prop = node->property ("meter")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_meter_action->set_active (true);
-                       } else {
-                               ruler_meter_action->set_active (false);
-                       }
+               if (node->get_property ("meter", yn)) {
+                       ruler_meter_action->set_active (yn);
                }
-               if ((prop = node->property ("marker")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_marker_action->set_active (true);
-                       } else {
-                               ruler_marker_action->set_active (false);
-                       }
+               if (node->get_property ("marker", yn)) {
+                       ruler_marker_action->set_active (yn);
                }
-               if ((prop = node->property ("rangemarker")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_range_action->set_active (true);
-                       } else {
-                               ruler_range_action->set_active (false);
-                       }
+               if (node->get_property ("rangemarker", yn)) {
+                       ruler_range_action->set_active (yn);
                }
-
-               if ((prop = node->property ("transportmarker")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_loop_punch_action->set_active (true);
-                       } else {
-                               ruler_loop_punch_action->set_active (false);
-                       }
+               if (node->get_property ("transportmarker", yn)) {
+                       ruler_loop_punch_action->set_active (yn);
                }
 
-               if ((prop = node->property ("cdmarker")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_cd_marker_action->set_active (true);
-                       } else {
-                               ruler_cd_marker_action->set_active (false);
-                       }
-
+               if (node->get_property ("cdmarker", yn)) {
+                               ruler_cd_marker_action->set_active (yn);
                } else {
                        // this _session doesn't yet know about the cdmarker ruler
                        // as a benefit to the user who doesn't know the feature exists, show the ruler if
@@ -405,12 +363,8 @@ Editor::restore_ruler_visibility ()
                        }
                }
 
-               if ((prop = node->property ("videotl")) != 0) {
-                       if (string_is_affirmative (prop->value())) {
-                               ruler_video_action->set_active (true);
-                       } else {
-                               ruler_video_action->set_active (false);
-                       }
+               if (node->get_property ("videotl", yn)) {
+                       ruler_video_action->set_active (yn);
                }
 
        }
@@ -710,14 +664,12 @@ Editor::update_fixed_rulers ()
 }
 
 void
-Editor::update_tempo_based_rulers (std::vector<TempoMap::BBTPoint>& grid)
+Editor::update_tempo_based_rulers ()
 {
        if (_session == 0) {
                return;
        }
 
-       compute_bbt_ruler_scale (grid, leftmost_frame, leftmost_frame+current_page_samples());
-
        _bbt_metric->units_per_pixel = samples_per_pixel;
 
        if (ruler_bbt_action->get_active()) {
@@ -729,7 +681,7 @@ Editor::update_tempo_based_rulers (std::vector<TempoMap::BBTPoint>& grid)
 void
 Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
 {
-        using namespace std;
+       using namespace std;
 
        framepos_t spacer;
        framepos_t fr;
@@ -749,26 +701,26 @@ Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
        upper = upper + spacer;
        framecnt_t const range = upper - lower;
 
-       if (range < (2 * _session->frames_per_timecode_frame())) { /* 0 - 2 frames */
+       if (range < (2 * _session->samples_per_timecode_frame())) { /* 0 - 2 frames */
                timecode_ruler_scale = timecode_show_bits;
                timecode_mark_modulo = 20;
                timecode_nmarks = 2 + (2 * _session->config.get_subframes_per_frame());
        } else if (range <= (fr / 4)) { /* 2 frames - 0.250 second */
                timecode_ruler_scale = timecode_show_frames;
                timecode_mark_modulo = 1;
-               timecode_nmarks = 2 + (range / (framepos_t)_session->frames_per_timecode_frame());
+               timecode_nmarks = 2 + (range / (framepos_t)_session->samples_per_timecode_frame());
        } else if (range <= (fr / 2)) { /* 0.25-0.5 second */
                timecode_ruler_scale = timecode_show_frames;
                timecode_mark_modulo = 2;
-               timecode_nmarks = 2 + (range / (framepos_t)_session->frames_per_timecode_frame());
+               timecode_nmarks = 2 + (range / (framepos_t)_session->samples_per_timecode_frame());
        } else if (range <= fr) { /* 0.5-1 second */
                timecode_ruler_scale = timecode_show_frames;
                timecode_mark_modulo = 5;
-               timecode_nmarks = 2 + (range / (framepos_t)_session->frames_per_timecode_frame());
+               timecode_nmarks = 2 + (range / (framepos_t)_session->samples_per_timecode_frame());
        } else if (range <= 2 * fr) { /* 1-2 seconds */
                timecode_ruler_scale = timecode_show_frames;
                timecode_mark_modulo = 10;
-               timecode_nmarks = 2 + (range / (framepos_t)_session->frames_per_timecode_frame());
+               timecode_nmarks = 2 + (range / (framepos_t)_session->samples_per_timecode_frame());
        } else if (range <= 8 * fr) { /* 2-8 seconds */
                timecode_ruler_scale = timecode_show_seconds;
                timecode_mark_modulo = 1;
@@ -819,22 +771,22 @@ Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
                timecode_nmarks = 2 + 24;
        } else {
 
-                const framecnt_t hours_in_range = range / (60 * 60 * fr);
-                const int text_width_rough_guess = 120; /* pixels, very very approximate guess at how wide the tick mark text is */
+               const framecnt_t hours_in_range = range / (60 * 60 * fr);
+               const int text_width_rough_guess = 120; /* pixels, very very approximate guess at how wide the tick mark text is */
 
-                /* Normally we do not need to know anything about the width of the canvas
-                   to set the ruler scale, because the caller has already determined
-                   the width and set lower + upper arguments to this function to match that.
+               /* Normally we do not need to know anything about the width of the canvas
+                  to set the ruler scale, because the caller has already determined
+                  the width and set lower + upper arguments to this function to match that.
 
-                   But in this case, where the range defined by lower and uppper can vary
-                   substantially (basically anything from 24hrs+ to several billion years)
-                   trying to decide which tick marks to show does require us to know
-                   about the available width.
-                */
+                  But in this case, where the range defined by lower and uppper can vary
+                  substantially (basically anything from 24hrs+ to several billion years)
+                  trying to decide which tick marks to show does require us to know
+                  about the available width.
+               */
 
                timecode_nmarks = _track_canvas->width() / text_width_rough_guess;
-                timecode_ruler_scale = timecode_show_many_hours;
-                timecode_mark_modulo = max ((framecnt_t) 1, 1 + (hours_in_range / timecode_nmarks));
+               timecode_ruler_scale = timecode_show_many_hours;
+               timecode_mark_modulo = max ((framecnt_t) 1, 1 + (hours_in_range / timecode_nmarks));
        }
 }
 
@@ -994,22 +946,22 @@ Editor::metric_get_timecode (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdou
                        if ((timecode.hours % timecode_mark_modulo) == 0) {
                                mark.style = ArdourCanvas::Ruler::Mark::Major;
                                snprintf (buf, sizeof(buf), "%s%02u:%02u:%02u:%02u", timecode.negative ? "-" : "", timecode.hours, timecode.minutes, timecode.seconds, timecode.frames);
-                                mark.label = buf;
-                                mark.position = pos;
-                                marks.push_back (mark);
-                                ++n;
-                        }
-                        /* can't use Timecode::increment_hours() here because we may be traversing thousands of hours
-                           and doing it 1 hour at a time is just stupid (and slow).
-                        */
-                        timecode.hours += timecode_mark_modulo;
+                               mark.label = buf;
+                               mark.position = pos;
+                               marks.push_back (mark);
+                               ++n;
+                       }
+                       /* can't use Timecode::increment_hours() here because we may be traversing thousands of hours
+                        * and doing it 1 hour at a time is just stupid (and slow).
+                        */
+                       timecode.hours += timecode_mark_modulo - (timecode.hours % timecode_mark_modulo);
                }
                break;
        }
 }
 
 void
-Editor::compute_bbt_ruler_scale (std::vector<ARDOUR::TempoMap::BBTPoint>& grid, framepos_t lower, framepos_t upper)
+Editor::compute_bbt_ruler_scale (framepos_t lower, framepos_t upper)
 {
        if (_session == 0) {
                return;
@@ -1017,8 +969,14 @@ Editor::compute_bbt_ruler_scale (std::vector<ARDOUR::TempoMap::BBTPoint>& grid,
 
        std::vector<TempoMap::BBTPoint>::const_iterator i;
        Timecode::BBT_Time lower_beat, upper_beat; // the beats at each end of the ruler
-       framecnt_t beat_before_lower_pos = _session->tempo_map().frame_at_beat (floor(_session->tempo_map().beat_at_frame (lower)));
-       framecnt_t beat_after_upper_pos = _session->tempo_map().frame_at_beat (floor (_session->tempo_map().beat_at_frame (upper)) + 1.0);
+       double floor_lower_beat = floor(max (0.0, _session->tempo_map().beat_at_frame (lower)));
+
+       if (floor_lower_beat < 0.0) {
+               floor_lower_beat = 0.0;
+       }
+
+       const framecnt_t beat_before_lower_pos = _session->tempo_map().frame_at_beat (floor_lower_beat);
+       const framecnt_t beat_after_upper_pos = _session->tempo_map().frame_at_beat (floor (max (0.0, _session->tempo_map().beat_at_frame (upper))) + 1.0);
 
        _session->bbt_time (beat_before_lower_pos, lower_beat);
        _session->bbt_time (beat_after_upper_pos, upper_beat);
@@ -1036,101 +994,96 @@ Editor::compute_bbt_ruler_scale (std::vector<ARDOUR::TempoMap::BBTPoint>& grid,
                bbt_beat_subdivision = 2;
                break;
        case SnapToBeatDiv3:
-                bbt_beat_subdivision = 3;
+               bbt_beat_subdivision = 3;
                break;
        case SnapToBeatDiv4:
-                bbt_beat_subdivision = 4;
+               bbt_beat_subdivision = 4;
                break;
        case SnapToBeatDiv5:
-                bbt_beat_subdivision = 5;
+               bbt_beat_subdivision = 5;
                bbt_accent_modulo = 2; // XXX YIKES
                break;
        case SnapToBeatDiv6:
-                bbt_beat_subdivision = 6;
+               bbt_beat_subdivision = 6;
                bbt_accent_modulo = 2; // XXX YIKES
                break;
        case SnapToBeatDiv7:
-                bbt_beat_subdivision = 7;
+               bbt_beat_subdivision = 7;
                bbt_accent_modulo = 2; // XXX YIKES
                break;
        case SnapToBeatDiv8:
-                bbt_beat_subdivision = 8;
+               bbt_beat_subdivision = 8;
                bbt_accent_modulo = 2;
                break;
        case SnapToBeatDiv10:
-                bbt_beat_subdivision = 10;
+               bbt_beat_subdivision = 10;
                bbt_accent_modulo = 2; // XXX YIKES
                break;
        case SnapToBeatDiv12:
-                bbt_beat_subdivision = 12;
+               bbt_beat_subdivision = 12;
                bbt_accent_modulo = 3;
                break;
        case SnapToBeatDiv14:
-                bbt_beat_subdivision = 14;
+               bbt_beat_subdivision = 14;
                bbt_accent_modulo = 3; // XXX YIKES!
                break;
        case SnapToBeatDiv16:
-                bbt_beat_subdivision = 16;
+               bbt_beat_subdivision = 16;
                bbt_accent_modulo = 4;
                break;
        case SnapToBeatDiv20:
-                bbt_beat_subdivision = 20;
+               bbt_beat_subdivision = 20;
                bbt_accent_modulo = 5;
                break;
        case SnapToBeatDiv24:
-                bbt_beat_subdivision = 24;
+               bbt_beat_subdivision = 24;
                bbt_accent_modulo = 6;
                break;
        case SnapToBeatDiv28:
-                bbt_beat_subdivision = 28;
+               bbt_beat_subdivision = 28;
                bbt_accent_modulo = 7;
                break;
        case SnapToBeatDiv32:
-                bbt_beat_subdivision = 32;
+               bbt_beat_subdivision = 32;
                bbt_accent_modulo = 8;
                break;
        case SnapToBeatDiv64:
-                bbt_beat_subdivision = 64;
+               bbt_beat_subdivision = 64;
                bbt_accent_modulo = 8;
                break;
        case SnapToBeatDiv128:
-                bbt_beat_subdivision = 128;
+               bbt_beat_subdivision = 128;
                bbt_accent_modulo = 8;
                break;
        default:
-                bbt_beat_subdivision = 4;
+               bbt_beat_subdivision = 4;
                break;
        }
-       if (distance (grid.begin(), grid.end()) == 0) {
+
+       const double ceil_upper_beat = floor (max (0.0, _session->tempo_map().beat_at_frame (upper))) + 1.0;
+       if (ceil_upper_beat == floor_lower_beat) {
                return;
        }
 
-       i = grid.end();
-       i--;
+       bbt_bars = _session->tempo_map().bbt_at_beat (ceil_upper_beat).bars - _session->tempo_map().bbt_at_beat (floor_lower_beat).bars;
 
-       /* XX ?? */
-       if ((*i).beat >= (*grid.begin()).beat) {
-               bbt_bars = (*i).bar - (*grid.begin()).bar;
-       } else {
-               bbt_bars = (*i).bar - (*grid.begin()).bar;
-       }
+       beats = (ceil_upper_beat - floor_lower_beat);// - bbt_bars;  possible thinko; this fixes the problem (for me) where measure lines alternately appear&disappear while playing at certain zoom scales
+       double beat_density = ((beats + 1) * ((double) (upper - lower) / (double) (1 + beat_after_upper_pos - beat_before_lower_pos))) / 5.0;
 
-       beats = distance (grid.begin(), grid.end()) - bbt_bars;
-       double beat_density = ((distance (grid.begin(), grid.end()) + 1) * ((double) (upper - lower) / (double) (1 + grid.back().frame - grid.front().frame))) / 5.0;
        /* Only show the bar helper if there aren't many bars on the screen */
        if ((bbt_bars < 2) || (beats < 5)) {
-               bbt_bar_helper_on = true;
+               bbt_bar_helper_on = true;
        }
 
        if (beat_density > 8192) {
                bbt_ruler_scale = bbt_show_many;
        } else if (beat_density > 1024) {
                bbt_ruler_scale = bbt_show_64;
-       } else if (beat_density > 500) {
+       } else if (beat_density > 512) {
                bbt_ruler_scale = bbt_show_16;
-       } else if (beat_density > 100) {
+       } else if (beat_density > 128) {
                bbt_ruler_scale = bbt_show_4;
-       } else if (beat_density > 10) {
+       } else if (beat_density > 16) {
                bbt_ruler_scale =  bbt_show_1;
        } else if (beat_density > 2) {
                bbt_ruler_scale =  bbt_show_beats;
@@ -1201,7 +1154,6 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                        if ((*i).frame < lower && (bbt_bar_helper_on)) {
                                snprintf (buf, sizeof(buf), "<%" PRIu32 "|%" PRIu32, (*i).bar, (*i).beat);
                                edit_last_mark_label (marks, buf);
-                               helper_active = true;
                        } else {
 
                                if ((*i).is_bar()) {
@@ -1244,7 +1196,7 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                                helper_active = true;
                        } else {
 
-                               if ((*i).is_bar()) {
+                               if ((*i).is_bar()) {
                                        mark.style = ArdourCanvas::Ruler::Mark::Major;
                                        snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
                                } else {
@@ -1269,7 +1221,7 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                                next_beat.beats = (*i).beat;
                                next_beat.bars = (*i).bar;
                                next_beat.ticks = tick;
-                               pos = _session->tempo_map().frame_time (next_beat);
+                               pos = _session->tempo_map().frame_at_bbt (next_beat);
 
                                if (t % bbt_accent_modulo == (bbt_accent_modulo - 1)) {
                                        i_am_accented = true;
@@ -1305,10 +1257,10 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                mark.style = ArdourCanvas::Ruler::Mark::Micro;
                marks.push_back (mark);
 
-               for (n = 1,   i = grid.begin(); n < bbt_nmarks && i != grid.end(); ++i) {
+               for (n = 1, i = grid.begin(); n < bbt_nmarks && i != grid.end(); ++i) {
 
                        if ((*i).frame < lower && (bbt_bar_helper_on)) {
-                               snprintf (buf, sizeof(buf), "<%" PRIu32 "|%" PRIu32, (*i).bar, (*i).beat);
+                               snprintf (buf, sizeof(buf), "<%" PRIu32 "|%" PRIu32, (*i).bar, (*i).beat);
                                edit_last_mark_label (marks, buf);
                                helper_active = true;
                        } else {
@@ -1339,13 +1291,13 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                                next_beat.beats = (*i).beat;
                                next_beat.bars = (*i).bar;
                                next_beat.ticks = tick;
-                               pos = _session->tempo_map().frame_time (next_beat);
+                               pos = _session->tempo_map().frame_at_bbt (next_beat);
 
                                if (t % bbt_accent_modulo == (bbt_accent_modulo - 1)) {
                                        i_am_accented = true;
                                }
                                if (i_am_accented && (pos > bbt_position_of_helper)){
-                                       snprintf (buf, sizeof(buf), "%" PRIu32, tick);
+                                       snprintf (buf, sizeof(buf), "%" PRIu32, tick);
                                } else {
                                        buf[0] = '\0';
                                }
@@ -1381,7 +1333,7 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                mark.style = ArdourCanvas::Ruler::Mark::Micro;
                marks.push_back (mark);
 
-               for (n = 1,   i = grid.begin(); n < bbt_nmarks && i != grid.end(); ++i) {
+               for (n = 1, i = grid.begin(); n < bbt_nmarks && i != grid.end(); ++i) {
 
                        if ((*i).frame < lower && (bbt_bar_helper_on)) {
                                  snprintf (buf, sizeof(buf), "<%" PRIu32 "|%" PRIu32, (*i).bar, (*i).beat);
@@ -1415,7 +1367,7 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                        while (tick < Timecode::BBT_Time::ticks_per_beat && (n < bbt_nmarks)) {
 
                                next_beat.ticks = tick;
-                               pos = _session->tempo_map().frame_time (next_beat);
+                               pos = _session->tempo_map().frame_at_bbt (next_beat);
                                if (t % bbt_accent_modulo == (bbt_accent_modulo - 1)) {
                                        i_am_accented = true;
                                }
@@ -1445,18 +1397,18 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
 
          break;
 
-        case bbt_show_many:
-                bbt_nmarks = 1;
-                snprintf (buf, sizeof(buf), "cannot handle %" PRIu32 " bars", bbt_bars );
-                mark.style = ArdourCanvas::Ruler::Mark::Major;
-                mark.label = buf;
-                mark.position = lower;
-                marks.push_back (mark);
-                break;
+       case bbt_show_many:
+               bbt_nmarks = 1;
+               snprintf (buf, sizeof(buf), "cannot handle %" PRIu32 " bars", bbt_bars );
+               mark.style = ArdourCanvas::Ruler::Mark::Major;
+               mark.label = buf;
+               mark.position = lower;
+               marks.push_back (mark);
+               break;
 
        case bbt_show_64:
-                       bbt_nmarks = (gint) (bbt_bars / 64) + 1;
-                       for (n = 0,   i = grid.begin(); i != grid.end() && n < bbt_nmarks; i++) {
+                       bbt_nmarks = (gint) (bbt_bars / 64) + 1;
+                       for (n = 0, i = grid.begin(); i != grid.end() && n < bbt_nmarks; i++) {
                                if ((*i).is_bar()) {
                                        if ((*i).bar % 64 == 1) {
                                                if ((*i).bar % 256 == 1) {
@@ -1480,19 +1432,19 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
                        break;
 
        case bbt_show_16:
-                       bbt_nmarks = (bbt_bars / 16) + 1;
+               bbt_nmarks = (bbt_bars / 16) + 1;
                for (n = 0,  i = grid.begin(); i != grid.end() && n < bbt_nmarks; i++) {
-                       if ((*i).is_bar()) {
+                       if ((*i).is_bar()) {
                          if ((*i).bar % 16 == 1) {
-                               if ((*i).bar % 64 == 1) {
-                                       snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
+                               if ((*i).bar % 64 == 1) {
+                                       snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
                                        mark.style = ArdourCanvas::Ruler::Mark::Major;
                                } else {
                                        buf[0] = '\0';
                                        if ((*i).bar % 64 == 33)  {
-                                               mark.style = ArdourCanvas::Ruler::Mark::Minor;
+                                               mark.style = ArdourCanvas::Ruler::Mark::Minor;
                                        } else {
-                                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
                                        }
                                }
                                mark.label = buf;
@@ -1506,36 +1458,36 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
 
        case bbt_show_4:
                bbt_nmarks = (bbt_bars / 4) + 1;
-               for (n = 0,   i = grid.begin(); i != grid.end() && n < bbt_nmarks; ++i) {
-                       if ((*i).is_bar()) {
-                         if ((*i).bar % 4 == 1) {
-                               if ((*i).bar % 16 == 1) {
-                                       snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
-                                       mark.style = ArdourCanvas::Ruler::Mark::Major;
-                               } else {
-                                       buf[0] = '\0';
-                                       if ((*i).bar % 16 == 9)  {
-                                               mark.style = ArdourCanvas::Ruler::Mark::Minor;
+               for (n = 0, i = grid.begin(); i != grid.end() && n < bbt_nmarks; ++i) {
+                       if ((*i).is_bar()) {
+                               if ((*i).bar % 4 == 1) {
+                                       if ((*i).bar % 16 == 1) {
+                                               snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
+                                               mark.style = ArdourCanvas::Ruler::Mark::Major;
                                        } else {
-                                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                                               buf[0] = '\0';
+                                               if ((*i).bar % 16 == 9)  {
+                                                       mark.style = ArdourCanvas::Ruler::Mark::Minor;
+                                               } else {
+                                                       mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                                               }
                                        }
+                                       mark.label = buf;
+                                       mark.position = (*i).frame;
+                                       marks.push_back (mark);
+                                       ++n;
                                }
-                               mark.label = buf;
-                               mark.position = (*i).frame;
-                               marks.push_back (mark);
-                               ++n;
-                         }
                        }
                }
          break;
 
        case bbt_show_1:
 //     default:
-               bbt_nmarks = bbt_bars + 2;
+               bbt_nmarks = bbt_bars + 2;
                for (n = 0,  i = grid.begin(); i != grid.end() && n < bbt_nmarks; ++i) {
-                       if ((*i).is_bar()) {
+                       if ((*i).is_bar()) {
                          if ((*i).bar % 4 == 1) {
-                                       snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
+                                       snprintf (buf, sizeof(buf), "%" PRIu32, (*i).bar);
                                        mark.style = ArdourCanvas::Ruler::Mark::Major;
                          } else {
                                  buf[0] = '\0';
@@ -1638,106 +1590,106 @@ Editor::set_minsec_ruler_scale (framepos_t lower, framepos_t upper)
        upper += spacer;
        framecnt_t const range = (upper - lower) * 1000;
 
-        if (range <= (fr / 10)) { /* 0-0.1 second */
+       if (range <= (fr / 10)) { /* 0-0.1 second */
                minsec_mark_interval = fr / 1000; /* show 1/1000 seconds */
                minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 10;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= (fr / 2)) { /* 0-0.5 second */
                minsec_mark_interval = fr / 100;  /* show 1/100 seconds */
                minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 100;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= fr) { /* 0-1 second */
                minsec_mark_interval = fr / 10;  /* show 1/10 seconds */
                minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 200;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 2 * fr) { /* 1-2 seconds */
                minsec_mark_interval = fr / 10; /* show 1/10 seconds */
                minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 500;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 8 * fr) { /* 2-5 seconds */
                minsec_mark_interval =  fr / 5; /* show 2 seconds */
                minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 1000;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 16 * fr) { /* 8-16 seconds */
                minsec_mark_interval =  fr; /* show 1 seconds */
                minsec_ruler_scale = minsec_show_seconds;
                minsec_mark_modulo = 2;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 30 * fr) { /* 10-30 seconds */
                minsec_mark_interval =  fr; /* show 1 seconds */
                minsec_ruler_scale = minsec_show_seconds;
-                minsec_mark_modulo = 5;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
+               minsec_mark_modulo = 5;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 60 * fr) { /* 30-60 seconds */
-                minsec_mark_interval = fr; /* show 1 seconds */
-                minsec_ruler_scale = minsec_show_seconds;
-                minsec_mark_modulo = 5;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 2 * 60 * fr) { /* 1-2 minutes */
-                minsec_mark_interval = 5 * fr; /* show 5 seconds */
-                minsec_ruler_scale = minsec_show_seconds;
-                minsec_mark_modulo = 3;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 4 * 60 * fr) { /* 4 minutes */
-                minsec_mark_interval = 5 * fr; /* show 10 seconds */
-                minsec_ruler_scale = minsec_show_seconds;
-                minsec_mark_modulo = 30;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 10 * 60 * fr) { /* 10 minutes */
-                minsec_mark_interval = 30 * fr; /* show 30 seconds */
-                minsec_ruler_scale = minsec_show_seconds;
-                minsec_mark_modulo = 120;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 30 * 60 * fr) { /* 10-30 minutes */
-                minsec_mark_interval =  60 * fr; /* show 1 minute */
-                minsec_ruler_scale = minsec_show_minutes;
+               minsec_mark_interval = fr; /* show 1 seconds */
+               minsec_ruler_scale = minsec_show_seconds;
                minsec_mark_modulo = 5;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 60 * 60 * fr) { /* 30 minutes - 1hr */
-                minsec_mark_interval = 2 * 60 * fr; /* show 2 minutes */
-                minsec_ruler_scale = minsec_show_minutes;
-                minsec_mark_modulo = 10;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 4 * 60 * 60 * fr) { /* 1 - 4 hrs*/
-                minsec_mark_interval = 5 * 60 * fr; /* show 10 minutes */
-                minsec_ruler_scale = minsec_show_minutes;
-                minsec_mark_modulo = 30;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 8 * 60 * 60 * fr) { /* 4 - 8 hrs*/
-                minsec_mark_interval = 20 * 60 * fr; /* show 20 minutes */
-                minsec_ruler_scale = minsec_show_minutes;
-                minsec_mark_modulo = 60;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else if (range <= 16 * 60 * 60 * fr) { /* 16-24 hrs*/
-                minsec_mark_interval =  60 * 60 * fr; /* show 60 minutes */
-                minsec_ruler_scale = minsec_show_hours;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 2 * 60 * fr) { /* 1-2 minutes */
+               minsec_mark_interval = 5 * fr; /* show 5 seconds */
+               minsec_ruler_scale = minsec_show_seconds;
+               minsec_mark_modulo = 3;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 4 * 60 * fr) { /* 4 minutes */
+               minsec_mark_interval = 5 * fr; /* show 10 seconds */
+               minsec_ruler_scale = minsec_show_seconds;
+               minsec_mark_modulo = 30;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 10 * 60 * fr) { /* 10 minutes */
+               minsec_mark_interval = 30 * fr; /* show 30 seconds */
+               minsec_ruler_scale = minsec_show_seconds;
+               minsec_mark_modulo = 120;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 30 * 60 * fr) { /* 10-30 minutes */
+               minsec_mark_interval =  60 * fr; /* show 1 minute */
+               minsec_ruler_scale = minsec_show_minutes;
+               minsec_mark_modulo = 5;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 60 * 60 * fr) { /* 30 minutes - 1hr */
+               minsec_mark_interval = 2 * 60 * fr; /* show 2 minutes */
+               minsec_ruler_scale = minsec_show_minutes;
+               minsec_mark_modulo = 10;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 4 * 60 * 60 * fr) { /* 1 - 4 hrs*/
+               minsec_mark_interval = 5 * 60 * fr; /* show 10 minutes */
+               minsec_ruler_scale = minsec_show_minutes;
+               minsec_mark_modulo = 30;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 8 * 60 * 60 * fr) { /* 4 - 8 hrs*/
+               minsec_mark_interval = 20 * 60 * fr; /* show 20 minutes */
+               minsec_ruler_scale = minsec_show_minutes;
+               minsec_mark_modulo = 60;
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else if (range <= 16 * 60 * 60 * fr) { /* 16-24 hrs*/
+               minsec_mark_interval =  60 * 60 * fr; /* show 60 minutes */
+               minsec_ruler_scale = minsec_show_hours;
                minsec_mark_modulo = 2;
-                minsec_nmarks = 2 + (range / minsec_mark_interval);
-        } else {
-
-                const framecnt_t hours_in_range = range / (60 * 60 * fr);
-                const int text_width_rough_guess = 70; /* pixels, very very approximate guess at how wide the tick mark text is */
-
-                /* Normally we do not need to know anything about the width of the canvas
-                   to set the ruler scale, because the caller has already determined
-                   the width and set lower + upper arguments to this function to match that.
-
-                   But in this case, where the range defined by lower and uppper can vary
-                   substantially (anything from 24hrs+ to several billion years)
-                   trying to decide which tick marks to show does require us to know
-                   about the available width.
-                */
-
-                minsec_nmarks = _track_canvas->width() / text_width_rough_guess;
-                minsec_mark_modulo = max ((framecnt_t) 1, 1 + (hours_in_range / minsec_nmarks));
-                minsec_mark_interval = minsec_mark_modulo * (60 * 60 * fr);
-                minsec_ruler_scale = minsec_show_many_hours;
-        }
+               minsec_nmarks = 2 + (range / minsec_mark_interval);
+       } else {
+
+               const framecnt_t hours_in_range = range / (60 * 60 * fr);
+               const int text_width_rough_guess = 70; /* pixels, very very approximate guess at how wide the tick mark text is */
+
+               /* Normally we do not need to know anything about the width of the canvas
+                  to set the ruler scale, because the caller has already determined
+                  the width and set lower + upper arguments to this function to match that.
+
+                  But in this case, where the range defined by lower and uppper can vary
+                  substantially (anything from 24hrs+ to several billion years)
+                  trying to decide which tick marks to show does require us to know
+                  about the available width.
+               */
+
+               minsec_nmarks = _track_canvas->width() / text_width_rough_guess;
+               minsec_mark_modulo = max ((framecnt_t) 1, 1 + (hours_in_range / minsec_nmarks));
+               minsec_mark_interval = minsec_mark_modulo * (60 * 60 * fr);
+               minsec_ruler_scale = minsec_show_many_hours;
+       }
 }
 
 void
@@ -1783,77 +1735,77 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
                        mark.position = pos/1000.0;
                        marks.push_back (mark);
                }
-                break;
+               break;
 
        case minsec_show_seconds:
                for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
-                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
-                       if (secs % minsec_mark_modulo == 0) {
+                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
+                       if (secs % minsec_mark_modulo == 0) {
                                if (secs == 0) {
                                        mark.style = ArdourCanvas::Ruler::Mark::Major;
                                } else {
                                        mark.style = ArdourCanvas::Ruler::Mark::Minor;
                                }
                                snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld", hrs, mins, secs);
-                       } else {
+                       } else {
                                buf[0] = '\0';
-                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
-                       }
-                       mark.label = buf;
+                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                       }
+                       mark.label = buf;
                        mark.position = pos/1000.0;
                        marks.push_back (mark);
                }
-                break;
+               break;
 
        case minsec_show_minutes:
                for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
-                        sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
-                        if (mins % minsec_mark_modulo == 0) {
-                                if (mins == 0) {
-                                        mark.style = ArdourCanvas::Ruler::Mark::Major;
-                                } else {
-                                        mark.style = ArdourCanvas::Ruler::Mark::Minor;
-                                }
-                                snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld", hrs, mins, secs);
-                        } else {
+                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
+                       if (mins % minsec_mark_modulo == 0) {
+                               if (mins == 0) {
+                                       mark.style = ArdourCanvas::Ruler::Mark::Major;
+                               } else {
+                                       mark.style = ArdourCanvas::Ruler::Mark::Minor;
+                               }
+                               snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld", hrs, mins, secs);
+                       } else {
                                buf[0] = '\0';
-                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
-                        }
-                        mark.label = buf;
-                        mark.position = pos/1000.0;
+                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                       }
+                       mark.label = buf;
+                       mark.position = pos/1000.0;
                        marks.push_back (mark);
-                }
-                break;
+               }
+               break;
 
        case minsec_show_hours:
                 for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
-                        sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
-                        if (hrs % minsec_mark_modulo == 0) {
-                                mark.style = ArdourCanvas::Ruler::Mark::Major;
-                                snprintf (buf, sizeof(buf), "%02ld:%02ld", hrs, mins);
-                        } else {
+                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
+                       if (hrs % minsec_mark_modulo == 0) {
+                               mark.style = ArdourCanvas::Ruler::Mark::Major;
+                               snprintf (buf, sizeof(buf), "%02ld:%02ld", hrs, mins);
+                       } else {
                                buf[0] = '\0';
-                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
-                        }
-                        mark.label = buf;
-                        mark.position = pos/1000.0;
+                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                       }
+                       mark.label = buf;
+                       mark.position = pos/1000.0;
                        marks.push_back (mark);
-                 }
-                 break;
-
-        case minsec_show_many_hours:
-                for (n = 0; n < minsec_nmarks; ) {
-                        sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
-                        if (hrs % minsec_mark_modulo == 0) {
-                                mark.style = ArdourCanvas::Ruler::Mark::Major;
-                                snprintf (buf, sizeof(buf), "%02ld:00", hrs);
-                                mark.label = buf;
-                                mark.position = pos/1000.0;
-                                marks.push_back (mark);
-                                ++n;
-                        }
-                        pos += minsec_mark_interval;
-                }
-                break;
-        }
+                }
+                break;
+
+       case minsec_show_many_hours:
+               for (n = 0; n < minsec_nmarks; ) {
+                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
+                       if (hrs % minsec_mark_modulo == 0) {
+                               mark.style = ArdourCanvas::Ruler::Mark::Major;
+                               snprintf (buf, sizeof(buf), "%02ld:00", hrs);
+                               mark.label = buf;
+                               mark.position = pos/1000.0;
+                               marks.push_back (mark);
+                               ++n;
+                       }
+                       pos += minsec_mark_interval;
+               }
+               break;
+       }
 }