canvas items must be able to use fractional positions when rendering.
[ardour.git] / gtk2_ardour / editor_rulers.cc
index 12cd09d0ceb24096e2caca493983f92c625ddd13..9ef589facba6c43e44246028151c59c3f17e2544 100644 (file)
 
 #include <gtk/gtkaction.h>
 
-#include "canvas/group.h"
+#include "canvas/container.h"
 #include "canvas/canvas.h"
 #include "canvas/ruler.h"
 #include "canvas/debug.h"
+#include "canvas/scroll_group.h"
 
 #include "ardour/session.h"
 #include "ardour/tempo.h"
 #include "editing.h"
 #include "actions.h"
 #include "gui_thread.h"
+#include "ruler_dialog.h"
 #include "time_axis_view.h"
 #include "editor_drag.h"
 #include "editor_cursors.h"
-#include "utils.h"
 
 #include "i18n.h"
 
@@ -121,7 +122,8 @@ void
 Editor::initialize_rulers ()
 {
        ruler_grabbed_widget = 0;
-       Pango::FontDescription font (ARDOUR_UI::config()->get_canvasvar_RulerFont());
+
+       Pango::FontDescription font (ARDOUR_UI::config()->get_SmallerFont());
 
        _timecode_metric = new TimecodeMetric (this);
        _bbt_metric = new BBTMetric (this);
@@ -180,10 +182,10 @@ bool
 Editor::ruler_label_button_release (GdkEventButton* ev)
 {
        if (Gtkmm2ext::Keyboard::is_context_menu_event (ev)) {
-               Gtk::Menu* m = dynamic_cast<Gtk::Menu*> (ActionManager::get_widget (X_("/RulerMenuPopup")));
-               if (m) {
-                       m->popup (1, ev->time);
+               if (!ruler_dialog) {
+                       ruler_dialog = new RulerDialog ();
                }
+               ruler_dialog->present ();
        }
 
        return true;
@@ -230,12 +232,10 @@ Editor::popup_ruler_menu (framepos_t where, ItemType t)
 
        case TempoBarItem:
                ruler_items.push_back (MenuElem (_("New Tempo"), sigc::bind ( sigc::mem_fun(*this, &Editor::mouse_add_new_tempo_event), where)));
-               ruler_items.push_back (SeparatorElem ());
                break;
 
        case MeterBarItem:
                ruler_items.push_back (MenuElem (_("New Meter"), sigc::bind ( sigc::mem_fun(*this, &Editor::mouse_add_new_meter_event), where)));
-               ruler_items.push_back (SeparatorElem ());
                break;
 
        case VideoBarItem:
@@ -254,71 +254,20 @@ Editor::popup_ruler_menu (framepos_t where, ItemType t)
 
                ruler_items.push_back (CheckMenuElem (_("Lock")));
                {
-               Gtk::CheckMenuItem* vtl_lock = static_cast<Gtk::CheckMenuItem*>(&ruler_items.back());
-               vtl_lock->set_active(is_video_timeline_locked());
-               vtl_lock->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_video_timeline_locked));
+                       Gtk::CheckMenuItem* vtl_lock = static_cast<Gtk::CheckMenuItem*>(&ruler_items.back());
+                       vtl_lock->set_active(is_video_timeline_locked());
+                       vtl_lock->signal_activate().connect (sigc::mem_fun(*this, &Editor::toggle_video_timeline_locked));
                }
-
-               ruler_items.push_back (SeparatorElem ());
                break;
 
        default:
                break;
        }
 
-       Glib::RefPtr<Action> action;
-
-       action = ActionManager::get_action ("Rulers", "toggle-minsec-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       if (!Profile->get_sae()) {
-               action = ActionManager::get_action ("Rulers", "toggle-timecode-ruler");
-               if (action) {
-                       ruler_items.push_back (MenuElem (*action->create_menu_item()));
-               }
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-samples-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-bbt-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-meter-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-tempo-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       if (!Profile->get_sae()) {
-               action = ActionManager::get_action ("Rulers", "toggle-range-ruler");
-               if (action) {
-                       ruler_items.push_back (MenuElem (*action->create_menu_item()));
-               }
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-loop-punch-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-cd-marker-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-marker-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
-       }
-       action = ActionManager::get_action ("Rulers", "toggle-video-ruler");
-       if (action) {
-               ruler_items.push_back (MenuElem (*action->create_menu_item()));
+       if (!ruler_items.empty()) {
+               editor_ruler_menu->popup (1, gtk_get_current_event_time());
        }
 
-       editor_ruler_menu->popup (1, gtk_get_current_event_time());
-
        no_ruler_shown_update = false;
 }
 
@@ -760,9 +709,12 @@ Editor::update_tempo_based_rulers (ARDOUR::TempoMap::BBTPointList::const_iterato
        }
 }
 
+
 void
 Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
 {
+        using namespace std;
+
        framepos_t spacer;
        framepos_t fr;
 
@@ -770,13 +722,14 @@ Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
                return;
        }
 
-       fr = _session->frame_rate();
+       fr = _session->frame_rate();        
 
        if (lower > (spacer = (framepos_t) (128 * Editor::get_current_zoom ()))) {
                lower = lower - spacer;
        } else {
                lower = 0;
        }
+
        upper = upper + spacer;
        framecnt_t const range = upper - lower;
 
@@ -843,20 +796,30 @@ Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
        } else if (range <= 8 * 60 * 60 * fr) { /* 4 - 8 hrs*/
                timecode_ruler_scale = timecode_show_hours;
                timecode_mark_modulo = 1;
-               timecode_nmarks = 2 + 8;
+               timecode_nmarks = 2 + 8; 
        } else if (range <= 16 * 60 * 60 * fr) { /* 16-24 hrs*/
                timecode_ruler_scale = timecode_show_hours;
                timecode_mark_modulo = 1;
                timecode_nmarks = 2 + 24;
        } else {
 
-               /* not possible if framepos_t is a 32 bit quantity */
+                const framecnt_t hours_in_range = range / (60 * 60 * fr);
+                const int text_width_rough_guess = 120; /* pixels, very very approximate guess at how wide the tick mark text is */
 
-               timecode_ruler_scale = timecode_show_hours;
-               timecode_mark_modulo = 4;
-               timecode_nmarks = 2 + 24;
-       }
+                /* Normally we do not need to know anything about the width of the canvas
+                   to set the ruler scale, because the caller has already determined
+                   the width and set lower + upper arguments to this function to match that.
 
+                   But in this case, where the range defined by lower and uppper can vary
+                   substantially (basically anything from 24hrs+ to several billion years)
+                   trying to decide which tick marks to show does require us to know 
+                   about the available width.
+                */
+
+               timecode_nmarks = _track_canvas->width() / text_width_rough_guess;
+                timecode_ruler_scale = timecode_show_many_hours;
+                timecode_mark_modulo = max ((framecnt_t) 1, 1 + (hours_in_range / timecode_nmarks));
+       }
 }
 
 void
@@ -883,10 +846,8 @@ Editor::metric_get_timecode (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdou
 
        switch (timecode_ruler_scale) {
        case timecode_show_bits:
-
                // Find timecode time of this sample (pos) with subframe accuracy
                _session->sample_to_timecode(pos, timecode, true /* use_offset */, true /* use_subframes */ );
-
                for (n = 0; n < timecode_nmarks; n++) {
                        _session->timecode_to_sample(timecode, pos, true /* use_offset */, true /* use_subframes */ );
                        if ((timecode.subframes % timecode_mark_modulo) == 0) {
@@ -900,23 +861,46 @@ Editor::metric_get_timecode (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdou
                        } else {
                                snprintf (buf, sizeof(buf)," ");
                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
-                               
                        }
                        mark.label = buf;
                        mark.position = pos;
-
                        marks.push_back (mark);
-
                        // Increment subframes by one
                        Timecode::increment_subframes( timecode, _session->config.get_subframes_per_frame() );
                }
-         break;
+               break;
+
+       case timecode_show_frames:
+               // Find timecode time of this sample (pos)
+               _session->sample_to_timecode(pos, timecode, true /* use_offset */, false /* use_subframes */ );
+               // Go to next whole frame down
+               Timecode::frames_floor( timecode );
+               for (n = 0; n < timecode_nmarks; n++) {
+                       _session->timecode_to_sample(timecode, pos, true /* use_offset */, false /* use_subframes */ );
+                       if ((timecode.frames % timecode_mark_modulo) == 0) {
+                               if (timecode.frames == 0) {
+                                       mark.style = ArdourCanvas::Ruler::Mark::Major;
+                               } else {
+                                       mark.style = ArdourCanvas::Ruler::Mark::Minor;
+                               }
+                               mark.position = pos;
+                               snprintf (buf, sizeof(buf), "%s%02u:%02u:%02u:%02u", timecode.negative ? "-" : "", timecode.hours, timecode.minutes, timecode.seconds, timecode.frames);
+                       } else {
+                               snprintf (buf, sizeof(buf)," ");
+                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                               mark.position = pos;
+                       }
+                       mark.label = buf;
+                       marks.push_back (mark);
+                       Timecode::increment( timecode, _session->config.get_subframes_per_frame() );
+               }
+               break;
+
        case timecode_show_seconds:
                // Find timecode time of this sample (pos)
                _session->sample_to_timecode(pos, timecode, true /* use_offset */, false /* use_subframes */ );
                // Go to next whole second down
                Timecode::seconds_floor( timecode );
-
                for (n = 0; n < timecode_nmarks; n++) {
                        _session->timecode_to_sample(timecode, pos, true /* use_offset */, false /* use_subframes */ );
                        if ((timecode.seconds % timecode_mark_modulo) == 0) {
@@ -932,20 +916,18 @@ Editor::metric_get_timecode (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdou
                                snprintf (buf, sizeof(buf)," ");
                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
                                mark.position = pos;
-
                        }
                        mark.label = buf;
                        marks.push_back (mark);
-
                        Timecode::increment_seconds( timecode, _session->config.get_subframes_per_frame() );
                }
-         break;
+               break;
+
        case timecode_show_minutes:
-               // Find timecode time of this sample (pos)
+               //Find timecode time of this sample (pos)
                _session->sample_to_timecode(pos, timecode, true /* use_offset */, false /* use_subframes */ );
                // Go to next whole minute down
                Timecode::minutes_floor( timecode );
-
                for (n = 0; n < timecode_nmarks; n++) {
                        _session->timecode_to_sample(timecode, pos, true /* use_offset */, false /* use_subframes */ );
                        if ((timecode.minutes % timecode_mark_modulo) == 0) {
@@ -958,21 +940,18 @@ Editor::metric_get_timecode (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdou
                        } else {
                                snprintf (buf, sizeof(buf)," ");
                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
-
                        }
                        mark.label = buf;
                        mark.position = pos;
                        marks.push_back (mark);
                        Timecode::increment_minutes( timecode, _session->config.get_subframes_per_frame() );
                }
-
-         break;
+               break;
        case timecode_show_hours:
                // Find timecode time of this sample (pos)
                _session->sample_to_timecode(pos, timecode, true /* use_offset */, false /* use_subframes */ );
                // Go to next whole hour down
                Timecode::hours_floor( timecode );
-
                for (n = 0; n < timecode_nmarks; n++) {
                        _session->timecode_to_sample(timecode, pos, true /* use_offset */, false /* use_subframes */ );
                        if ((timecode.hours % timecode_mark_modulo) == 0) {
@@ -981,47 +960,38 @@ Editor::metric_get_timecode (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdou
                        } else {
                                snprintf (buf, sizeof(buf)," ");
                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
-
                        }
                        mark.label = buf;
                        mark.position = pos;
                        marks.push_back (mark);
                        Timecode::increment_hours( timecode, _session->config.get_subframes_per_frame() );
                }
-         break;
-       case timecode_show_frames:
+               break;
+       case timecode_show_many_hours:
                // Find timecode time of this sample (pos)
                _session->sample_to_timecode(pos, timecode, true /* use_offset */, false /* use_subframes */ );
-               // Go to next whole frame down
-               Timecode::frames_floor( timecode );
+               // Go to next whole hour down
+               Timecode::hours_floor (timecode);
 
-               for (n = 0; n < timecode_nmarks; n++) {
+               for (n = 0; n < timecode_nmarks; ) {
                        _session->timecode_to_sample(timecode, pos, true /* use_offset */, false /* use_subframes */ );
-                       if ((timecode.frames % timecode_mark_modulo) == 0)  {
-                               if (timecode.frames == 0) {
-                                       mark.style = ArdourCanvas::Ruler::Mark::Major;
-                               } else {
-                                       mark.style = ArdourCanvas::Ruler::Mark::Minor;
-                               }
-                               mark.position = pos;
+                       if ((timecode.hours % timecode_mark_modulo) == 0) {
+                               mark.style = ArdourCanvas::Ruler::Mark::Major;
                                snprintf (buf, sizeof(buf), "%s%02u:%02u:%02u:%02u", timecode.negative ? "-" : "", timecode.hours, timecode.minutes, timecode.seconds, timecode.frames);
-                       } else {
-                               snprintf (buf, sizeof(buf)," ");
-                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
-                               mark.position = pos;
-
-                       }
-                       mark.label = buf;
-                       marks.push_back (mark);
-                       Timecode::increment( timecode, _session->config.get_subframes_per_frame() );
+                                mark.label = buf;
+                                mark.position = pos;
+                                marks.push_back (mark);
+                                ++n;
+                        } 
+                        /* can't use Timecode::increment_hours() here because we may be traversing thousands of hours
+                           and doing it 1 hour at a time is just stupid (and slow).
+                        */
+                        timecode.hours += timecode_mark_modulo;
                }
-
-         break;
+               break;
        }
 }
 
-
-
 void
 Editor::compute_bbt_ruler_scale (framepos_t lower, framepos_t upper,
                                 ARDOUR::TempoMap::BBTPointList::const_iterator begin,
@@ -1043,7 +1013,7 @@ Editor::compute_bbt_ruler_scale (framepos_t lower, framepos_t upper,
        bbt_bars = 0;
        bbt_nmarks = 1;
 
-       bbt_ruler_scale =  bbt_over;
+       bbt_ruler_scale =  bbt_show_many;
 
        switch (_snap_type) {
        case SnapToBeatDiv2:
@@ -1135,7 +1105,7 @@ Editor::compute_bbt_ruler_scale (framepos_t lower, framepos_t upper,
        }
 
        if (bbt_bars > 8192) {
-               bbt_ruler_scale =  bbt_over;
+               bbt_ruler_scale =  bbt_show_many;
        } else if (bbt_bars > 1024) {
                bbt_ruler_scale = bbt_show_64;
        } else if (bbt_bars > 256) {
@@ -1524,15 +1494,14 @@ Editor::metric_get_bbt (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble l
 
          break;
 
-       case bbt_over:
-                       bbt_nmarks = 1;
-                       snprintf (buf, sizeof(buf), "cannot handle %" PRIu32 " bars", bbt_bars );
-                       mark.style = ArdourCanvas::Ruler::Mark::Major;
-                       mark.label = buf;
-                       mark.position = lower;
-                       marks.push_back (mark);
-
-         break;
+        case bbt_show_many:
+                bbt_nmarks = 1;
+                snprintf (buf, sizeof(buf), "cannot handle %" PRIu32 " bars", bbt_bars );
+                mark.style = ArdourCanvas::Ruler::Mark::Major;
+                mark.label = buf;
+                mark.position = lower;
+                marks.push_back (mark);
+                break;
 
        case bbt_show_64:
                        bbt_nmarks = (gint) (bbt_bars / 64) + 1;
@@ -1701,14 +1670,13 @@ sample_to_clock_parts ( framepos_t sample,
 void
 Editor::set_minsec_ruler_scale (framepos_t lower, framepos_t upper)
 {
-       framepos_t fr;
+       framepos_t fr = _session->frame_rate() * 1000;
        framepos_t spacer;
 
        if (_session == 0) {
                return;
        }
 
-       fr = _session->frame_rate() * 1000;
 
        /* to prevent 'flashing' */
        if (lower > (spacer = (framepos_t)(128 * Editor::get_current_zoom ()))) {
@@ -1719,85 +1687,110 @@ Editor::set_minsec_ruler_scale (framepos_t lower, framepos_t upper)
        upper += spacer;
        framecnt_t const range = (upper - lower) * 1000;
 
-       if (range <  (fr / 50)) {
-               minsec_mark_interval =  fr / 1000; /* show 1/1000 seconds */
-               minsec_ruler_scale = minsec_show_frames;
-               minsec_mark_modulo = 10;
-       } else if (range <= (fr / 10)) { /* 0-0.1 second */
+        if (range <= (fr / 10)) { /* 0-0.1 second */
                minsec_mark_interval = fr / 1000; /* show 1/1000 seconds */
-               minsec_ruler_scale = minsec_show_frames;
+               minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 10;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= (fr / 2)) { /* 0-0.5 second */
                minsec_mark_interval = fr / 100;  /* show 1/100 seconds */
-               minsec_ruler_scale = minsec_show_frames;
+               minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 100;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= fr) { /* 0-1 second */
                minsec_mark_interval = fr / 10;  /* show 1/10 seconds */
-               minsec_ruler_scale = minsec_show_frames;
+               minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 200;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 2 * fr) { /* 1-2 seconds */
                minsec_mark_interval = fr / 10; /* show 1/10 seconds */
-               minsec_ruler_scale = minsec_show_frames;
+               minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 500;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 8 * fr) { /* 2-5 seconds */
                minsec_mark_interval =  fr / 5; /* show 2 seconds */
-               minsec_ruler_scale = minsec_show_frames;
+               minsec_ruler_scale = minsec_show_msecs;
                minsec_mark_modulo = 1000;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 16 * fr) { /* 8-16 seconds */
                minsec_mark_interval =  fr; /* show 1 seconds */
                minsec_ruler_scale = minsec_show_seconds;
                minsec_mark_modulo = 2;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 30 * fr) { /* 10-30 seconds */
                minsec_mark_interval =  fr; /* show 1 seconds */
                minsec_ruler_scale = minsec_show_seconds;
                 minsec_mark_modulo = 5;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
        } else if (range <= 60 * fr) { /* 30-60 seconds */
                 minsec_mark_interval = fr; /* show 1 seconds */
                 minsec_ruler_scale = minsec_show_seconds;
                 minsec_mark_modulo = 5;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 2 * 60 * fr) { /* 1-2 minutes */
                 minsec_mark_interval = 5 * fr; /* show 5 seconds */
                 minsec_ruler_scale = minsec_show_seconds;
                 minsec_mark_modulo = 3;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 4 * 60 * fr) { /* 4 minutes */
                 minsec_mark_interval = 5 * fr; /* show 10 seconds */
                 minsec_ruler_scale = minsec_show_seconds;
                 minsec_mark_modulo = 30;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 10 * 60 * fr) { /* 10 minutes */
                 minsec_mark_interval = 30 * fr; /* show 30 seconds */
                 minsec_ruler_scale = minsec_show_seconds;
                 minsec_mark_modulo = 120;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 30 * 60 * fr) { /* 10-30 minutes */
                 minsec_mark_interval =  60 * fr; /* show 1 minute */
                 minsec_ruler_scale = minsec_show_minutes;
                minsec_mark_modulo = 5;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 60 * 60 * fr) { /* 30 minutes - 1hr */
                 minsec_mark_interval = 2 * 60 * fr; /* show 2 minutes */
                 minsec_ruler_scale = minsec_show_minutes;
                 minsec_mark_modulo = 10;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 4 * 60 * 60 * fr) { /* 1 - 4 hrs*/
                 minsec_mark_interval = 5 * 60 * fr; /* show 10 minutes */
                 minsec_ruler_scale = minsec_show_minutes;
                 minsec_mark_modulo = 30;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 8 * 60 * 60 * fr) { /* 4 - 8 hrs*/
                 minsec_mark_interval = 20 * 60 * fr; /* show 20 minutes */
                 minsec_ruler_scale = minsec_show_minutes;
                 minsec_mark_modulo = 60;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else if (range <= 16 * 60 * 60 * fr) { /* 16-24 hrs*/
                 minsec_mark_interval =  60 * 60 * fr; /* show 60 minutes */
                 minsec_ruler_scale = minsec_show_hours;
                minsec_mark_modulo = 2;
+                minsec_nmarks = 2 + (range / minsec_mark_interval);
         } else {
 
-                /* not possible if framepos_t is a 32 bit quantity */
+                const framecnt_t hours_in_range = range / (60 * 60 * fr);
+                const int text_width_rough_guess = 70; /* pixels, very very approximate guess at how wide the tick mark text is */
+
+                /* Normally we do not need to know anything about the width of the canvas
+                   to set the ruler scale, because the caller has already determined
+                   the width and set lower + upper arguments to this function to match that.
+
+                   But in this case, where the range defined by lower and uppper can vary
+                   substantially (anything from 24hrs+ to several billion years)
+                   trying to decide which tick marks to show does require us to know 
+                   about the available width.
+                */
 
-                minsec_mark_interval = 4 * 60 * 60 * fr; /* show 4 hrs */
+                minsec_nmarks = _track_canvas->width() / text_width_rough_guess;
+                minsec_mark_modulo = max ((framecnt_t) 1, 1 + (hours_in_range / minsec_nmarks));
+                minsec_mark_interval = minsec_mark_modulo * (60 * 60 * fr);
+                minsec_ruler_scale = minsec_show_many_hours;
         }
-       minsec_nmarks = 2 + (range / minsec_mark_interval);
 }
 
 void
-Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble lower, gdouble /*upper*/, gint /*maxchars*/)
+Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdouble lower, gdouble upper, gint /*maxchars*/)
 {
        framepos_t pos;
        framepos_t spacer;
@@ -1818,7 +1811,29 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
        }
 
        pos = (((1000 * (framepos_t) floor(lower)) + (minsec_mark_interval/2))/minsec_mark_interval) * minsec_mark_interval;
+
        switch (minsec_ruler_scale) {
+
+       case minsec_show_msecs:
+               for (n = 0; n < minsec_nmarks && n < upper; pos += minsec_mark_interval, ++n) {
+                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
+                       if (millisecs % minsec_mark_modulo == 0) {
+                               if (millisecs == 0) {
+                                       mark.style = ArdourCanvas::Ruler::Mark::Major;
+                               } else {
+                                       mark.style = ArdourCanvas::Ruler::Mark::Minor;
+                               }
+                               snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld.%03ld", hrs, mins, secs, millisecs);
+                       } else {
+                               buf[0] = '\0';
+                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
+                       }
+                       mark.label = buf;
+                       mark.position = pos/1000.0;
+                       marks.push_back (mark);
+               }
+                break;
+                
        case minsec_show_seconds:
                for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
                        sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
@@ -1828,7 +1843,7 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
                                } else {
                                        mark.style = ArdourCanvas::Ruler::Mark::Minor;
                                }
-                               snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld.%03ld", hrs, mins, secs, millisecs);
+                               snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld", hrs, mins, secs);
                        } else {
                                buf[0] = '\0';
                                mark.style = ArdourCanvas::Ruler::Mark::Micro;
@@ -1837,7 +1852,8 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
                        mark.position = pos/1000.0;
                        marks.push_back (mark);
                }
-         break;
+                break;
+
        case minsec_show_minutes:
                for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
                         sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
@@ -1847,7 +1863,7 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
                                 } else {
                                         mark.style = ArdourCanvas::Ruler::Mark::Minor;
                                 }
-                               snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld.%03ld", hrs, mins, secs, millisecs);
+                                snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld", hrs, mins, secs);
                         } else {
                                buf[0] = '\0';
                                 mark.style = ArdourCanvas::Ruler::Mark::Micro;
@@ -1856,13 +1872,14 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
                         mark.position = pos/1000.0;
                        marks.push_back (mark);
                 }
-         break;
+                break;
+
        case minsec_show_hours:
                 for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
                         sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
                         if (hrs % minsec_mark_modulo == 0) {
                                 mark.style = ArdourCanvas::Ruler::Mark::Major;
-                                snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld.%03ld", hrs, mins, secs, millisecs);
+                                snprintf (buf, sizeof(buf), "%02ld:%02ld", hrs, mins);
                         } else {
                                buf[0] = '\0';
                                 mark.style = ArdourCanvas::Ruler::Mark::Micro;
@@ -1870,26 +1887,22 @@ Editor::metric_get_minsec (std::vector<ArdourCanvas::Ruler::Mark>& marks, gdoubl
                         mark.label = buf;
                         mark.position = pos/1000.0;
                        marks.push_back (mark);
+                 }
+                 break;
+                 
+        case minsec_show_many_hours:
+                for (n = 0; n < minsec_nmarks; ) {
+                        sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
+                        if (hrs % minsec_mark_modulo == 0) {
+                                mark.style = ArdourCanvas::Ruler::Mark::Major;
+                                snprintf (buf, sizeof(buf), "%02ld:00", hrs);
+                                mark.label = buf;
+                                mark.position = pos/1000.0;
+                                marks.push_back (mark);
+                                ++n;
+                        }
+                        pos += minsec_mark_interval;
                 }
-             break;
-       case minsec_show_frames:
-               for (n = 0; n < minsec_nmarks; pos += minsec_mark_interval, ++n) {
-                       sample_to_clock_parts (pos, _session->frame_rate(), &hrs, &mins, &secs, &millisecs);
-                       if (millisecs % minsec_mark_modulo == 0) {
-                               if (millisecs == 0) {
-                                       mark.style = ArdourCanvas::Ruler::Mark::Major;
-                               } else {
-                                       mark.style = ArdourCanvas::Ruler::Mark::Minor;
-                               }
-                               snprintf (buf, sizeof(buf), "%02ld:%02ld:%02ld.%03ld", hrs, mins, secs, millisecs);
-                       } else {
-                               buf[0] = '\0';
-                               mark.style = ArdourCanvas::Ruler::Mark::Micro;
-                       }
-                       mark.label = buf;
-                       mark.position = pos/1000.0;
-                       marks.push_back (mark);
-               }
-         break;
-       }
+                break;
+        }
 }