fixes for 98% of all the warnings/errors reported by OS X gcc on tiger
[ardour.git] / gtk2_ardour / editor_rulers.cc
index e6ba876c1199d81d24f824f89319af087be2b117..b7a3f2ba5faa74ad10a484225edacac8392bf228 100644 (file)
@@ -57,7 +57,7 @@ Editor *Editor::ruler_editor;
 GtkCustomMetric Editor::ruler_metrics[4] = {
        {1, Editor::_metric_get_timecode },
        {1, Editor::_metric_get_bbt },
-       {1, Editor::_metric_get_frames },
+       {1, Editor::_metric_get_samples },
        {1, Editor::_metric_get_minsec }
 };
 
@@ -98,13 +98,13 @@ Editor::initialize_rulers ()
        bbt_ruler->set_no_show_all();
        bbt_nmarks = 0;
 
-       _frames_ruler = gtk_custom_hruler_new ();
-       frames_ruler = Glib::wrap (_frames_ruler);
-       frames_ruler->set_name ("FramesRuler");
-       frames_ruler->set_size_request (-1, (int)timebar_height);
-       gtk_custom_ruler_set_metric (GTK_CUSTOM_RULER(_frames_ruler), &ruler_metrics[ruler_metric_frames]);
-       frames_ruler->hide ();
-       frames_ruler->set_no_show_all();
+       _samples_ruler = gtk_custom_hruler_new ();
+       samples_ruler = Glib::wrap (_samples_ruler);
+       samples_ruler->set_name ("SamplesRuler");
+       samples_ruler->set_size_request (-1, (int) timebar_height);
+       gtk_custom_ruler_set_metric (GTK_CUSTOM_RULER (_samples_ruler), &ruler_metrics[ruler_metric_samples]);
+       samples_ruler->hide ();
+       samples_ruler->set_no_show_all ();
 
        _bbt_ruler = gtk_custom_hruler_new ();
        bbt_ruler = Glib::wrap (_bbt_ruler);
@@ -135,34 +135,34 @@ Editor::initialize_rulers ()
        ruler_children.insert (canvaspos, Element(*minsec_ruler, PACK_SHRINK, PACK_START));
        ruler_lab_children.push_back (Element(timecode_label, PACK_SHRINK, PACK_START));
        ruler_children.insert (canvaspos, Element(*timecode_ruler, PACK_SHRINK, PACK_START));
-       ruler_lab_children.push_back (Element(frame_label, PACK_SHRINK, PACK_START));
-       ruler_children.insert (canvaspos, Element(*frames_ruler, PACK_SHRINK, PACK_START));
+       ruler_lab_children.push_back (Element(samples_label, PACK_SHRINK, PACK_START));
+       ruler_children.insert (canvaspos, Element (*samples_ruler, PACK_SHRINK, PACK_START));
        ruler_lab_children.push_back (Element(bbt_label, PACK_SHRINK, PACK_START));
        ruler_children.insert (canvaspos, Element(*bbt_ruler, PACK_SHRINK, PACK_START));
 
        timecode_ruler->add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK|Gdk::SCROLL_MASK);
        bbt_ruler->add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK|Gdk::SCROLL_MASK);
-       frames_ruler->add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK|Gdk::SCROLL_MASK);
+       samples_ruler->add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK|Gdk::SCROLL_MASK);
        minsec_ruler->add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK|Gdk::SCROLL_MASK);
 
        timecode_ruler->signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_release));
        bbt_ruler->signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_release));
-       frames_ruler->signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_release));
+       samples_ruler->signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_release));
        minsec_ruler->signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_release));
 
        timecode_ruler->signal_button_press_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_press));
        bbt_ruler->signal_button_press_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_press));
-       frames_ruler->signal_button_press_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_press));
+       samples_ruler->signal_button_press_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_press));
        minsec_ruler->signal_button_press_event().connect (sigc::mem_fun(*this, &Editor::ruler_button_press));
 
        timecode_ruler->signal_motion_notify_event().connect (sigc::mem_fun(*this, &Editor::ruler_mouse_motion));
        bbt_ruler->signal_motion_notify_event().connect (sigc::mem_fun(*this, &Editor::ruler_mouse_motion));
-       frames_ruler->signal_motion_notify_event().connect (sigc::mem_fun(*this, &Editor::ruler_mouse_motion));
+       samples_ruler->signal_motion_notify_event().connect (sigc::mem_fun(*this, &Editor::ruler_mouse_motion));
        minsec_ruler->signal_motion_notify_event().connect (sigc::mem_fun(*this, &Editor::ruler_mouse_motion));
 
        timecode_ruler->signal_scroll_event().connect (sigc::mem_fun(*this, &Editor::ruler_scroll));
        bbt_ruler->signal_scroll_event().connect (sigc::mem_fun(*this, &Editor::ruler_scroll));
-       frames_ruler->signal_scroll_event().connect (sigc::mem_fun(*this, &Editor::ruler_scroll));
+       samples_ruler->signal_scroll_event().connect (sigc::mem_fun(*this, &Editor::ruler_scroll));
        minsec_ruler->signal_scroll_event().connect (sigc::mem_fun(*this, &Editor::ruler_scroll));
 
        visible_timebars = 0; /*this will be changed below */
@@ -216,11 +216,11 @@ Editor::ruler_scroll (GdkEventScroll* event)
 }
 
 
-gint
+bool
 Editor::ruler_button_press (GdkEventButton* ev)
 {
        if (_session == 0) {
-               return FALSE;
+               return false;
        }
 
        // jlc: grab ev->window ?
@@ -231,8 +231,8 @@ Editor::ruler_button_press (GdkEventButton* ev)
                grab_widget = timecode_ruler;
        } else if (bbt_ruler->is_realized() && ev->window == bbt_ruler->get_window()->gobj()) {
                grab_widget = bbt_ruler;
-       } else if (frames_ruler->is_realized() && ev->window == frames_ruler->get_window()->gobj()) {
-               grab_widget = frames_ruler;
+       } else if (samples_ruler->is_realized() && ev->window == samples_ruler->get_window()->gobj()) {
+               grab_widget = samples_ruler;
        } else if (minsec_ruler->is_realized() && ev->window == minsec_ruler->get_window()->gobj()) {
                grab_widget = minsec_ruler;
        }
@@ -254,14 +254,14 @@ Editor::ruler_button_press (GdkEventButton* ev)
                _dragging_playhead = true;
        }
 
-       return TRUE;
+       return true;
 }
 
-gint
+bool
 Editor::ruler_button_release (GdkEventButton* ev)
 {
        if (_session == 0) {
-               return FALSE;
+               return false;
        }
 
        gint x,y;
@@ -288,35 +288,35 @@ Editor::ruler_button_release (GdkEventButton* ev)
                ruler_grabbed_widget = 0;
        }
 
-       return TRUE;
+       return true;
 }
 
-gint
+bool
 Editor::ruler_label_button_release (GdkEventButton* ev)
 {
        if (ev->button == 3) {
-               Gtk::Menu* m= dynamic_cast<Gtk::Menu*> (ActionManager::get_widget (X_("/RulerMenuPopup")));
+               Gtk::Menu* m = dynamic_cast<Gtk::Menu*> (ActionManager::get_widget (X_("/RulerMenuPopup")));
                if (m) {
                        m->popup (1, ev->time);
                }
        }
 
-       return TRUE;
+       return true;
 }
 
 
-gint
+bool
 Editor::ruler_mouse_motion (GdkEventMotion* ev)
 {
        if (_session == 0) {
-               return FALSE;
+               return false;
        }
 
        if (_drags->active ()) {
                _drags->motion_handler (reinterpret_cast<GdkEvent*> (ev), false);
        }
 
-       return TRUE;
+       return true;
 }
 
 
@@ -361,13 +361,11 @@ Editor::popup_ruler_menu (framepos_t where, ItemType t)
 
        case TempoBarItem:
                ruler_items.push_back (MenuElem (_("New Tempo"), sigc::bind ( sigc::mem_fun(*this, &Editor::mouse_add_new_tempo_event), where)));
-               ruler_items.push_back (MenuElem (_("Clear tempo")));
                ruler_items.push_back (SeparatorElem ());
                break;
 
        case MeterBarItem:
                ruler_items.push_back (MenuElem (_("New Meter"), sigc::bind ( sigc::mem_fun(*this, &Editor::mouse_add_new_meter_event), where)));
-               ruler_items.push_back (MenuElem (_("Clear meter")));
                ruler_items.push_back (SeparatorElem ());
                break;
 
@@ -434,7 +432,7 @@ Editor::store_ruler_visibility ()
 
        node->add_property (X_("timecode"), ruler_timecode_action->get_active() ? "yes": "no");
        node->add_property (X_("bbt"), ruler_bbt_action->get_active() ? "yes": "no");
-       node->add_property (X_("frames"), ruler_samples_action->get_active() ? "yes": "no");
+       node->add_property (X_("samples"), ruler_samples_action->get_active() ? "yes": "no");
        node->add_property (X_("minsec"), ruler_minsec_action->get_active() ? "yes": "no");
        node->add_property (X_("tempo"), ruler_tempo_action->get_active() ? "yes": "no");
        node->add_property (X_("meter"), ruler_meter_action->get_active() ? "yes": "no");
@@ -470,7 +468,7 @@ Editor::restore_ruler_visibility ()
                                ruler_bbt_action->set_active (false);
                        }
                }
-               if ((prop = node->property ("frames")) != 0) {
+               if ((prop = node->property ("samples")) != 0) {
                        if (string_is_affirmative (prop->value())) {
                                ruler_samples_action->set_active (true);
                        } else {
@@ -579,11 +577,11 @@ Editor::update_ruler_visibility ()
 
        if (ruler_samples_action->get_active()) {
                visible_rulers++;
-               frame_label.show ();
-               frames_ruler->show ();
+               samples_label.show ();
+               samples_ruler->show ();
        } else {
-               frame_label.hide ();
-               frames_ruler->hide ();
+               samples_label.hide ();
+               samples_ruler->hide ();
        }
 
        if (ruler_bbt_action->get_active()) {
@@ -765,6 +763,7 @@ Editor::update_ruler_visibility ()
        ruler_label_vbox.set_size_request (-1, (int)(timebar_height * visible_rulers));
        time_canvas_vbox.set_size_request (-1,-1);
 
+       compute_fixed_ruler_scale ();
        update_fixed_rulers();
        redisplay_tempo (false);
 
@@ -799,11 +798,15 @@ Editor::compute_fixed_ruler_scale ()
        }
 
        if (ruler_timecode_action->get_active()) {
-               set_timecode_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames() );
+               set_timecode_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames());
        }
 
        if (ruler_minsec_action->get_active()) {
-               set_minsec_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames() );
+               set_minsec_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames());
+       }
+
+       if (ruler_samples_action->get_active()) {
+               set_samples_ruler_scale (leftmost_frame, leftmost_frame + current_page_frames());
        }
 }
 
@@ -817,7 +820,7 @@ Editor::update_fixed_rulers ()
        }
 
        ruler_metrics[ruler_metric_timecode].units_per_pixel = frames_per_unit;
-       ruler_metrics[ruler_metric_frames].units_per_pixel = frames_per_unit;
+       ruler_metrics[ruler_metric_samples].units_per_pixel = frames_per_unit;
        ruler_metrics[ruler_metric_minsec].units_per_pixel = frames_per_unit;
 
        rightmost_frame = leftmost_frame + current_page_frames();
@@ -832,7 +835,7 @@ Editor::update_fixed_rulers ()
        }
 
        if (ruler_samples_action->get_active()) {
-               gtk_custom_ruler_set_range (GTK_CUSTOM_RULER(_frames_ruler), leftmost_frame, rightmost_frame,
+               gtk_custom_ruler_set_range (GTK_CUSTOM_RULER (_samples_ruler), leftmost_frame, rightmost_frame,
                                            leftmost_frame, _session->current_end_frame());
        }
 
@@ -872,9 +875,9 @@ Editor::_metric_get_bbt (GtkCustomRulerMark **marks, gdouble lower, gdouble uppe
 }
 
 gint
-Editor::_metric_get_frames (GtkCustomRulerMark **marks, gdouble lower, gdouble upper, gint maxchars)
+Editor::_metric_get_samples (GtkCustomRulerMark **marks, gdouble lower, gdouble upper, gint maxchars)
 {
-       return ruler_editor->metric_get_frames (marks, lower, upper, maxchars);
+       return ruler_editor->metric_get_samples (marks, lower, upper, maxchars);
 }
 
 gint
@@ -884,9 +887,8 @@ Editor::_metric_get_minsec (GtkCustomRulerMark **marks, gdouble lower, gdouble u
 }
 
 void
-Editor::set_timecode_ruler_scale (gdouble lower, gdouble upper)
+Editor::set_timecode_ruler_scale (framepos_t lower, framepos_t upper)
 {
-       framepos_t range;
        framepos_t spacer;
        framepos_t fr;
 
@@ -896,13 +898,13 @@ Editor::set_timecode_ruler_scale (gdouble lower, gdouble upper)
 
        fr = _session->frame_rate();
 
-       if (lower > (spacer = (framepos_t)(128 * Editor::get_current_zoom ()))) {
+       if (lower > (spacer = (framepos_t) (128 * Editor::get_current_zoom ()))) {
                lower = lower - spacer;
        } else {
                lower = 0;
        }
        upper = upper + spacer;
-       range = (framepos_t) floor (upper - lower);
+       framecnt_t const range = upper - lower;
 
        if (range < (2 * _session->frames_per_timecode_frame())) { /* 0 - 2 frames */
                timecode_ruler_scale = timecode_show_bits;
@@ -1231,33 +1233,33 @@ Editor::compute_bbt_ruler_scale (framepos_t lower, framepos_t upper)
        i = current_bbt_points->end();
        i--;
        if ((*i).beat >= (*current_bbt_points->begin()).beat) {
-         bbt_bars = (*i).bar - (*current_bbt_points->begin()).bar;
+               bbt_bars = (*i).bar - (*current_bbt_points->begin()).bar;
        } else {
-         bbt_bars = (*i).bar - (*current_bbt_points->begin()).bar - 1;
+               bbt_bars = (*i).bar - (*current_bbt_points->begin()).bar - 1;
        }
        beats = current_bbt_points->size() - bbt_bars;
 
-       /*Only show the bar helper if there aren't many bars on the screen */
+       /* Only show the bar helper if there aren't many bars on the screen */
        if ((bbt_bars < 2) || (beats < 5)) {
                bbt_bar_helper_on = true;
        }
 
        if (bbt_bars > 8192) {
-         bbt_ruler_scale =  bbt_over;
+               bbt_ruler_scale =  bbt_over;
        } else if (bbt_bars > 1024) {
-         bbt_ruler_scale = bbt_show_64;
+               bbt_ruler_scale = bbt_show_64;
        } else if (bbt_bars > 256) {
-         bbt_ruler_scale = bbt_show_16;
+               bbt_ruler_scale = bbt_show_16;
        } else if (bbt_bars > 64) {
-         bbt_ruler_scale = bbt_show_4;
+               bbt_ruler_scale = bbt_show_4;
        } else if (bbt_bars > 10) {
-         bbt_ruler_scale =  bbt_show_1;
+               bbt_ruler_scale =  bbt_show_1;
        } else if (bbt_bars > 2) {
-         bbt_ruler_scale =  bbt_show_beats;
+               bbt_ruler_scale =  bbt_show_beats;
        } else  if (bbt_bars > 0) {
-         bbt_ruler_scale =  bbt_show_ticks;
+               bbt_ruler_scale =  bbt_show_ticks;
        } else {
-         bbt_ruler_scale =  bbt_show_ticks_detail;
+               bbt_ruler_scale =  bbt_show_ticks_detail;
        }
 
        if ((bbt_ruler_scale == bbt_show_ticks_detail) && (lower_beat.beats == upper_beat.beats) && (upper_beat.ticks - lower_beat.ticks <= Timecode::BBT_Time::ticks_per_beat / 4)) {
@@ -1737,13 +1739,17 @@ Editor::metric_get_bbt (GtkCustomRulerMark **marks, gdouble lower, gdouble /*upp
 
 }
 
+void
+Editor::set_samples_ruler_scale (framepos_t lower, framepos_t upper)
+{
+       _samples_ruler_interval = (upper - lower) / 5;
+}
+
 gint
-Editor::metric_get_frames (GtkCustomRulerMark **marks, gdouble lower, gdouble upper, gint /*maxchars*/)
+Editor::metric_get_samples (GtkCustomRulerMark **marks, gdouble lower, gdouble /*upper*/, gint /*maxchars*/)
 {
-       framepos_t mark_interval;
        framepos_t pos;
-       framepos_t ilower = (framepos_t) floor (lower);
-       framepos_t iupper = (framepos_t) floor (upper);
+       framepos_t const ilower = (framepos_t) floor (lower);
        gchar buf[16];
        gint nmarks;
        gint n;
@@ -1752,15 +1758,9 @@ Editor::metric_get_frames (GtkCustomRulerMark **marks, gdouble lower, gdouble up
                return 0;
        }
 
-       mark_interval = (iupper - ilower) / 5;
-       if (mark_interval > _session->frame_rate()) {
-               mark_interval -= mark_interval % _session->frame_rate();
-       } else {
-               mark_interval = _session->frame_rate() / (_session->frame_rate() / mark_interval ) ;
-       }
        nmarks = 5;
        *marks = (GtkCustomRulerMark *) g_malloc (sizeof(GtkCustomRulerMark) * nmarks);
-       for (n = 0, pos = ilower; n < nmarks; pos += mark_interval, ++n) {
+       for (n = 0, pos = ilower; n < nmarks; pos += _samples_ruler_interval, ++n) {
                snprintf (buf, sizeof(buf), "%" PRIi64, pos);
                (*marks)[n].label = g_strdup (buf);
                (*marks)[n].position = pos;
@@ -1803,9 +1803,8 @@ sample_to_clock_parts ( framepos_t sample,
 }
 
 void
-Editor::set_minsec_ruler_scale (gdouble lower, gdouble upper)
+Editor::set_minsec_ruler_scale (framepos_t lower, framepos_t upper)
 {
-       framepos_t range;
        framepos_t fr;
        framepos_t spacer;
 
@@ -1822,7 +1821,7 @@ Editor::set_minsec_ruler_scale (gdouble lower, gdouble upper)
                lower = 0;
        }
        upper += spacer;
-       range = (framepos_t) (upper - lower);
+       framecnt_t const range = upper - lower;
 
        if (range <  (fr / 50)) {
                minsec_mark_interval =  fr / 1000; /* show 1/1000 seconds */
@@ -1915,7 +1914,7 @@ Editor::metric_get_minsec (GtkCustomRulerMark **marks, gdouble lower, gdouble /*
        }
 
        /* to prevent 'flashing' */
-       if (lower > (spacer = (framepos_t)(128 * Editor::get_current_zoom ()))) {
+       if (lower > (spacer = (framepos_t) (128 * Editor::get_current_zoom ()))) {
                lower = lower - spacer;
        } else {
                lower = 0;