run_new_group_dialog (&routes, false);
} else {
boost::shared_ptr<RouteList> r = _session->get_routes ();
- for (RouteList::iterator i = r->begin(); i != r->end(); ++i) {
+ /* First add new ones, then remove old ones.
+ * We cannot allow the group to become temporarily empty, because
+ * Session::route_removed_from_route_group() will delete empty groups.
+ */
+ for (RouteList::const_iterator i = routes.begin(); i != routes.end(); ++i) {
+ /* RouteGroup::add () ignores routes already present in the set */
+ _dragging->group->add (*i);
+ }
+ for (RouteList::const_iterator i = r->begin(); i != r->end(); ++i) {
bool const was_in_tab = find (
_initial_dragging_routes.begin(), _initial_dragging_routes.end(), *i
if (was_in_tab && !now_in_tab) {
_dragging->group->remove (*i);
- } else if (!was_in_tab && now_in_tab) {
- _dragging->group->add (*i);
}
}
+
}
}
boost::shared_ptr<VCA> master;
if (which == 0) {
- if (_session->vca_manager().create_vca (1)) {
+ if (_session->vca_manager().create_vca (1).empty ()) {
/* error */
return;
}
}
void
-GroupTabs::assign_some_to_master (uint32_t which, RouteList rl)
+GroupTabs::assign_some_to_master (uint32_t which, RouteList rl, std::string vcaname)
{
if (!_session) {
return;
}
boost::shared_ptr<VCA> master;
+ bool set_name = false;
if (which == 0) {
- if (_session->vca_manager().create_vca (1)) {
+ if (_session->vca_manager().create_vca (1).empty ()) {
/* error */
return;
}
+ set_name = true;
/* Get most recently created VCA... */
which = _session->vca_manager().vcas().back()->number();
}
for (RouteList::iterator r = rl.begin(); r != rl.end(); ++r) {
- (*r)->assign (master, false);
+ (*r)->assign (master);
+ }
+ if (set_name && !vcaname.empty()) {
+ master->set_name (vcaname);
}
}
RouteList
GroupTabs::get_soloed ()
{
- boost::shared_ptr<RouteList> rl = _session->get_routes ();
-
+ RouteList rl = _session->get_routelist ();
RouteList soloed;
- for (RouteList::iterator i = rl->begin(); i != rl->end(); ++i) {
+ for (RouteList::iterator i = rl.begin(); i != rl.end(); ++i) {
if (!(*i)->is_master() && (*i)->soloed()) {
soloed.push_back (*i);
}
void
GroupTabs::assign_selection_to_master (uint32_t which)
{
- assign_some_to_master (which, selected_routes ());
+ assign_some_to_master (which, selected_routes (), _("Selection"));
}
void
GroupTabs::collect (RouteGroup* g)
{
boost::shared_ptr<RouteList> group_routes = g->route_list ();
- group_routes->sort (Stripable::PresentationOrderSorter());
+ group_routes->sort (Stripable::Sorter());
int const N = group_routes->size ();
RouteList::iterator i = group_routes->begin ();
- boost::shared_ptr<RouteList> routes = _session->get_routes ();
- routes->sort (Stripable::PresentationOrderSorter());
- RouteList::const_iterator j = routes->begin ();
+ RouteList routes = _session->get_routelist ();
+ routes.sort (Stripable::Sorter());
+ RouteList::const_iterator j = routes.begin ();
int diff = 0;
int coll = -1;
PresentationInfo::ChangeSuspender cs;
- while (i != group_routes->end() && j != routes->end()) {
+ while (i != group_routes->end() && j != routes.end()) {
PresentationInfo::order_t const k = (*j)->presentation_info ().order();