Restore Use PH button in locations UI (#3667).
[ardour.git] / gtk2_ardour / location_ui.cc
index 833eb73ae6d6b1980634b30b40d0c454fff4b091..c24da57685573d11690c28c04f84803ce3dabc56 100644 (file)
 #include "pbd/memento_command.h"
 
 #include "ardour_ui.h"
-#include "prompter.h"
-#include "location_ui.h"
+#include "clock_group.h"
+#include "gui_thread.h"
 #include "keyboard.h"
+#include "location_ui.h"
+#include "prompter.h"
 #include "utils.h"
-#include "gui_thread.h"
 
 #include "i18n.h"
 
@@ -43,120 +44,152 @@ using namespace Gtk;
 using namespace Gtkmm2ext;
 
 LocationEditRow::LocationEditRow(Session * sess, Location * loc, int32_t num)
-       : SessionHandlePtr (0), /* explicitly set below */
-         location(0), 
-         item_table (1, 6, false),
-         start_clock (X_("locationstart"), true, X_("LocationEditRowClock"), true, false),
-         end_clock (X_("locationend"), true, X_("LocationEditRowClock"), true, false),
-         length_clock (X_("locationlength"), true, X_("LocationEditRowClock"), true, false, true),
-         cd_check_button (_("CD")),
-         hide_check_button (_("Hide")),
-         lock_check_button (_("Lock")),
-         glue_check_button (_("Glue")),
-         scms_check_button (_("SCMS")),
-         preemph_check_button (_("Pre-Emphasis"))
-
-{
-       i_am_the_modifier = 0;
-
-       start_go_button.set_image (*manage (new Image (Stock::JUMP_TO, Gtk::ICON_SIZE_SMALL_TOOLBAR)));
-       end_go_button.set_image (*manage (new Image (Stock::JUMP_TO, Gtk::ICON_SIZE_SMALL_TOOLBAR)));
-       remove_button.set_image (*manage (new Image (Stock::REMOVE, Gtk::ICON_SIZE_SMALL_TOOLBAR)));
-
-       number_label.set_name ("LocationEditNumberLabel");
-       name_label.set_name ("LocationEditNameLabel");
-       name_entry.set_name ("LocationEditNameEntry");
-       start_go_button.set_name ("LocationEditGoButton");
-       end_go_button.set_name ("LocationEditGoButton");
-       cd_check_button.set_name ("LocationEditCdButton");
-       hide_check_button.set_name ("LocationEditHideButton");
-       lock_check_button.set_name ("LocationEditLockButton");
-       glue_check_button.set_name ("LocationEditGlueButton");
-       remove_button.set_name ("LocationEditRemoveButton");
-       isrc_label.set_name ("LocationEditNumberLabel");
-       isrc_entry.set_name ("LocationEditNameEntry");
-       scms_check_button.set_name ("LocationEditCdButton");
-       preemph_check_button.set_name ("LocationEditCdButton");
-       performer_label.set_name ("LocationEditNumberLabel");
-       performer_entry.set_name ("LocationEditNameEntry");
-       composer_label.set_name ("LocationEditNumberLabel");
-       composer_entry.set_name ("LocationEditNameEntry");
-
-       isrc_label.set_text ("ISRC: ");
-       isrc_label.set_size_request (30, -1);
-       performer_label.set_text ("Performer: ");
-       performer_label.set_size_request (60, -1);
-       composer_label.set_text ("Composer: ");
-       composer_label.set_size_request (60, -1);
-
-       isrc_entry.set_size_request (112, -1);
-       isrc_entry.set_max_length(12);
-       isrc_entry.set_editable (true);
-
-       performer_entry.set_size_request (100, -1);
-       performer_entry.set_editable (true);
-
-       composer_entry.set_size_request (100, -1);
-       composer_entry.set_editable (true);
-
-       name_label.set_alignment (0, 0.5);
-
-       cd_track_details_hbox.pack_start (isrc_label, false, false);
-       cd_track_details_hbox.pack_start (isrc_entry, false, false);
-       cd_track_details_hbox.pack_start (scms_check_button, false, false);
-       cd_track_details_hbox.pack_start (preemph_check_button, false, false);
-       cd_track_details_hbox.pack_start (performer_label, false, false);
-       cd_track_details_hbox.pack_start (performer_entry, true, true);
-       cd_track_details_hbox.pack_start (composer_label, false, false);
-       cd_track_details_hbox.pack_start (composer_entry, true, true);
-
-       isrc_entry.signal_changed().connect (sigc::mem_fun(*this, &LocationEditRow::isrc_entry_changed));
-       performer_entry.signal_changed().connect (sigc::mem_fun(*this, &LocationEditRow::performer_entry_changed));
-       composer_entry.signal_changed().connect (sigc::mem_fun(*this, &LocationEditRow::composer_entry_changed));
-       scms_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::scms_toggled));
-       preemph_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::preemph_toggled));
-
-       set_session (sess);
-
-       start_hbox.pack_start (start_go_button, false, false);
-       start_hbox.pack_start (start_clock, false, false);
-
-       /* this is always in this location, no matter what the location is */
-
-       item_table.attach (start_hbox, 1, 2, 0, 1, FILL, FILL, 4, 0);
-
-       start_go_button.signal_clicked().connect(sigc::bind (sigc::mem_fun (*this, &LocationEditRow::go_button_pressed), LocStart));
-       start_clock.ValueChanged.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::clock_changed), LocStart));
-       start_clock.ChangeAborted.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::change_aborted), LocStart));
-
-       end_hbox.pack_start (end_go_button, false, false);
-       end_hbox.pack_start (end_clock, false, false);
-
-       end_go_button.signal_clicked().connect(sigc::bind (sigc::mem_fun (*this, &LocationEditRow::go_button_pressed), LocEnd));
-       end_clock.ValueChanged.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::clock_changed), LocEnd));
-       end_clock.ChangeAborted.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::change_aborted), LocEnd));
-
-       length_clock.ValueChanged.connect (sigc::bind ( sigc::mem_fun(*this, &LocationEditRow::clock_changed), LocLength));
-       length_clock.ChangeAborted.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::change_aborted), LocLength));
-
-       cd_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::cd_toggled));
-       hide_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::hide_toggled));
-       lock_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::lock_toggled));
-       glue_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::glue_toggled));
-
-       remove_button.signal_clicked().connect(sigc::mem_fun(*this, &LocationEditRow::remove_button_pressed));
-
-       pack_start(item_table, true, true);
-
-       set_location (loc);
-       set_number (num);
-}
-
-LocationEditRow::~LocationEditRow()
-{
-       if (location) {
-               connections.drop_connections ();
-       }
+       : SessionHandlePtr (0) /* explicitly set below */
+        , location(0) 
+        , item_table (1, 6, false)
+        , start_clock (X_("locationstart"), true, X_("LocationEditRowClock"), true, false)
+        , end_clock (X_("locationend"), true, X_("LocationEditRowClock"), true, false)
+        , length_clock (X_("locationlength"), true, X_("LocationEditRowClock"), true, false, true)
+        , cd_check_button (_("CD"))
+        , hide_check_button (_("Hide"))
+        , lock_check_button (_("Lock"))
+        , glue_check_button (_("Glue"))
+        , scms_check_button (_("SCMS"))
+        , preemph_check_button (_("Pre-Emphasis"))
+        , _clock_group (0)
+ {
+         i_am_the_modifier = 0;
+
+         start_go_button.set_image (*manage (new Image (Stock::JUMP_TO, Gtk::ICON_SIZE_SMALL_TOOLBAR)));
+         end_go_button.set_image (*manage (new Image (Stock::JUMP_TO, Gtk::ICON_SIZE_SMALL_TOOLBAR)));
+         remove_button.set_image (*manage (new Image (Stock::REMOVE, Gtk::ICON_SIZE_SMALL_TOOLBAR)));
+
+         number_label.set_name ("LocationEditNumberLabel");
+         name_label.set_name ("LocationEditNameLabel");
+         name_entry.set_name ("LocationEditNameEntry");
+         start_go_button.set_name ("LocationEditGoButton");
+         end_go_button.set_name ("LocationEditGoButton");
+         cd_check_button.set_name ("LocationEditCdButton");
+         hide_check_button.set_name ("LocationEditHideButton");
+         lock_check_button.set_name ("LocationEditLockButton");
+         glue_check_button.set_name ("LocationEditGlueButton");
+         remove_button.set_name ("LocationEditRemoveButton");
+         isrc_label.set_name ("LocationEditNumberLabel");
+         isrc_entry.set_name ("LocationEditNameEntry");
+         scms_check_button.set_name ("LocationEditCdButton");
+         preemph_check_button.set_name ("LocationEditCdButton");
+         performer_label.set_name ("LocationEditNumberLabel");
+         performer_entry.set_name ("LocationEditNameEntry");
+         composer_label.set_name ("LocationEditNumberLabel");
+         composer_entry.set_name ("LocationEditNameEntry");
+
+        Gtk::Button* start_to_playhead_button = manage (new Button (_("Use PH")));
+        Gtk::Button* end_to_playhead_button = manage (new Button (_("Use PH")));
+
+        ARDOUR_UI::instance()->tooltips().set_tip (*start_to_playhead_button, _("Set value to playhead"));
+        ARDOUR_UI::instance()->tooltips().set_tip (*end_to_playhead_button, _("Set value to playhead"));
+        
+         isrc_label.set_text ("ISRC: ");
+         isrc_label.set_size_request (30, -1);
+         performer_label.set_text ("Performer: ");
+         performer_label.set_size_request (60, -1);
+         composer_label.set_text ("Composer: ");
+         composer_label.set_size_request (60, -1);
+
+         isrc_entry.set_size_request (112, -1);
+         isrc_entry.set_max_length(12);
+         isrc_entry.set_editable (true);
+
+         performer_entry.set_size_request (100, -1);
+         performer_entry.set_editable (true);
+
+         composer_entry.set_size_request (100, -1);
+         composer_entry.set_editable (true);
+
+         name_label.set_alignment (0, 0.5);
+
+         cd_track_details_hbox.pack_start (isrc_label, false, false);
+         cd_track_details_hbox.pack_start (isrc_entry, false, false);
+         cd_track_details_hbox.pack_start (scms_check_button, false, false);
+         cd_track_details_hbox.pack_start (preemph_check_button, false, false);
+         cd_track_details_hbox.pack_start (performer_label, false, false);
+         cd_track_details_hbox.pack_start (performer_entry, true, true);
+         cd_track_details_hbox.pack_start (composer_label, false, false);
+         cd_track_details_hbox.pack_start (composer_entry, true, true);
+
+         isrc_entry.signal_changed().connect (sigc::mem_fun(*this, &LocationEditRow::isrc_entry_changed));
+         performer_entry.signal_changed().connect (sigc::mem_fun(*this, &LocationEditRow::performer_entry_changed));
+         composer_entry.signal_changed().connect (sigc::mem_fun(*this, &LocationEditRow::composer_entry_changed));
+         scms_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::scms_toggled));
+         preemph_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::preemph_toggled));
+
+         set_session (sess);
+
+         start_hbox.pack_start (start_go_button, false, false);
+         start_hbox.pack_start (start_clock, false, false);
+        start_hbox.pack_start (*start_to_playhead_button, false, false);
+
+         /* this is always in this location, no matter what the location is */
+
+         item_table.attach (start_hbox, 1, 2, 0, 1, FILL, FILL, 4, 0);
+
+         start_go_button.signal_clicked().connect(sigc::bind (sigc::mem_fun (*this, &LocationEditRow::go_button_pressed), LocStart));
+        start_to_playhead_button->signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::to_playhead_button_pressed), LocStart));
+         start_clock.ValueChanged.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::clock_changed), LocStart));
+         start_clock.ChangeAborted.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::change_aborted), LocStart));
+
+         end_hbox.pack_start (end_go_button, false, false);
+         end_hbox.pack_start (end_clock, false, false);
+        end_hbox.pack_start (*end_to_playhead_button, false, false);
+
+         end_go_button.signal_clicked().connect(sigc::bind (sigc::mem_fun (*this, &LocationEditRow::go_button_pressed), LocEnd));
+        end_to_playhead_button->signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::to_playhead_button_pressed), LocEnd));
+         end_clock.ValueChanged.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::clock_changed), LocEnd));
+         end_clock.ChangeAborted.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::change_aborted), LocEnd));
+
+         length_clock.ValueChanged.connect (sigc::bind ( sigc::mem_fun(*this, &LocationEditRow::clock_changed), LocLength));
+         length_clock.ChangeAborted.connect (sigc::bind (sigc::mem_fun (*this, &LocationEditRow::change_aborted), LocLength));
+
+         cd_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::cd_toggled));
+         hide_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::hide_toggled));
+         lock_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::lock_toggled));
+         glue_check_button.signal_toggled().connect(sigc::mem_fun(*this, &LocationEditRow::glue_toggled));
+
+         remove_button.signal_clicked().connect(sigc::mem_fun(*this, &LocationEditRow::remove_button_pressed));
+
+         pack_start(item_table, true, true);
+
+         set_location (loc);
+         set_number (num);
+ }
+
+ LocationEditRow::~LocationEditRow()
+ {
+         if (location) {
+                 connections.drop_connections ();
+         }
+
+         if (_clock_group) {
+                 _clock_group->remove (start_clock);
+                 _clock_group->remove (end_clock);
+                 _clock_group->remove (length_clock);
+         }
+ }
+
+ void
+ LocationEditRow::set_clock_group (ClockGroup& cg)
+ {
+         if (_clock_group) {
+                 _clock_group->remove (start_clock);
+                 _clock_group->remove (end_clock);
+                 _clock_group->remove (length_clock);
+         }
+
+         _clock_group = &cg;
+
+         _clock_group->add (start_clock);
+         _clock_group->add (end_clock);
+         _clock_group->add (length_clock);
 }
 
 void
@@ -310,7 +343,10 @@ void
 LocationEditRow::name_entry_changed ()
 {
        ENSURE_GUI_THREAD (*this, &LocationEditRow::name_entry_changed)
-       if (i_am_the_modifier || !location) return;
+       
+       if (i_am_the_modifier || !location) {
+               return;
+       }
 
        location->set_name (name_entry.get_text());
 }
@@ -380,6 +416,25 @@ LocationEditRow::go_button_pressed (LocationPart part)
        }
 }
 
+void
+LocationEditRow::to_playhead_button_pressed (LocationPart part)
+{
+       if (!location) {
+               return;
+       }
+
+       switch (part) {
+       case LocStart:
+               location->set_start (_session->transport_frame ());
+               break;
+       case LocEnd:
+               location->set_end (_session->transport_frame ());
+               break;
+       default:
+               break;
+       }
+}
+
 void
 LocationEditRow::clock_changed (LocationPart part)
 {
@@ -554,10 +609,8 @@ LocationEditRow::end_changed (ARDOUR::Location *loc)
 }
 
 void
-LocationEditRow::start_changed (ARDOUR::Location *loc)
+LocationEditRow::start_changed (ARDOUR::Location*)
 {
-       ENSURE_GUI_THREAD (*this, &LocationEditRow::start_changed, loc)
-
        if (!location) return;
 
        // update end and length
@@ -575,10 +628,8 @@ LocationEditRow::start_changed (ARDOUR::Location *loc)
 }
 
 void
-LocationEditRow::name_changed (ARDOUR::Location *loc)
+LocationEditRow::name_changed (ARDOUR::Location *)
 {
-       ENSURE_GUI_THREAD (*this, &LocationEditRow::name_changed, loc)
-
        if (!location) return;
 
        // update end and length
@@ -592,9 +643,8 @@ LocationEditRow::name_changed (ARDOUR::Location *loc)
 }
 
 void
-LocationEditRow::location_changed (ARDOUR::Location *loc)
+LocationEditRow::location_changed (ARDOUR::Location*)
 {
-       ENSURE_GUI_THREAD (*this, &LocationEditRow::location_changed, loc)
 
        if (!location) return;
 
@@ -611,7 +661,7 @@ LocationEditRow::location_changed (ARDOUR::Location *loc)
 }
 
 void
-LocationEditRow::flags_changed (ARDOUR::Location *loc, void *src)
+LocationEditRow::flags_changed (ARDOUR::Location*, void *)
 {
        if (!location) {
                return;
@@ -627,7 +677,7 @@ LocationEditRow::flags_changed (ARDOUR::Location *loc, void *src)
 }
 
 void
-LocationEditRow::lock_changed (ARDOUR::Location *loc)
+LocationEditRow::lock_changed (ARDOUR::Location*)
 {
        if (!location) {
                return;
@@ -643,7 +693,7 @@ LocationEditRow::lock_changed (ARDOUR::Location *loc)
 }
 
 void
-LocationEditRow::position_lock_style_changed (ARDOUR::Location* loc)
+LocationEditRow::position_lock_style_changed (ARDOUR::Location*)
 {
        if (!location) {
                return;
@@ -661,6 +711,15 @@ LocationEditRow::focus_name() {
        name_entry.grab_focus();
 }
 
+void
+LocationEditRow::set_clock_sensitivity ()
+{
+       start_clock.set_sensitive (!location->locked());
+       end_clock.set_sensitive (!location->locked());
+       length_clock.set_sensitive (!location->locked());
+}
+
+/*------------------------------------------------------------------------*/
 
 LocationUI::LocationUI ()
        : add_location_button (_("New Marker"))
@@ -668,6 +727,9 @@ LocationUI::LocationUI ()
 {
        i_am_the_modifier = 0;
 
+        _clock_group = new ClockGroup;
+        _clock_group->set_clock_mode (AudioClock::Frames);
+
        VBox* vbox = manage (new VBox);
 
        Table* table = manage (new Table (2, 2));
@@ -681,26 +743,29 @@ LocationUI::LocationUI ()
        table->attach (*l, 0, 2, table_row, table_row + 1);
        ++table_row;
 
+        loop_edit_row.set_clock_group (*_clock_group);
+        punch_edit_row.set_clock_group (*_clock_group);
+
        loop_punch_box.pack_start (loop_edit_row, false, false);
        loop_punch_box.pack_start (punch_edit_row, false, false);
        
        table->attach (loop_punch_box, 1, 2, table_row, table_row + 1);
        ++table_row;
 
-       vbox->pack_start (*table, true, true);
+       vbox->pack_start (*table, false, false);
        
        table = manage (new Table (3, 2));
        table->set_spacings (4);
        table->set_col_spacing (0, 32);
        table_row = 0;
 
-       table->attach (*manage (new Label ("")), 0, 2, table_row, table_row + 1);
+       table->attach (*manage (new Label ("")), 0, 2, table_row, table_row + 1, Gtk::SHRINK, Gtk::SHRINK);
        ++table_row;
        
        l = manage (new Label (_("<b>Markers (Including CD Index)</b>")));
        l->set_alignment (0, 0.5);
        l->set_use_markup (true);
-       table->attach (*l, 0, 2, table_row, table_row + 1);
+       table->attach (*l, 0, 2, table_row, table_row + 1, Gtk::FILL | Gtk::EXPAND, Gtk::SHRINK);
        ++table_row;
 
        location_rows.set_name("LocationLocRows");
@@ -729,13 +794,13 @@ LocationUI::LocationUI ()
        table->set_col_spacing (0, 32);
        table_row = 0;
 
-       table->attach (*manage (new Label ("")), 0, 2, table_row, table_row + 1);
+       table->attach (*manage (new Label ("")), 0, 2, table_row, table_row + 1, Gtk::SHRINK, Gtk::SHRINK);
        ++table_row;
        
        l = manage (new Label (_("<b>Ranges (Including CD Track Ranges)</b>")));
        l->set_alignment (0, 0.5);
        l->set_use_markup (true);
-       table->attach (*l, 0, 2, table_row, table_row + 1);
+       table->attach (*l, 0, 2, table_row, table_row + 1, Gtk::FILL | Gtk::EXPAND, Gtk::SHRINK);
        ++table_row;
 
        range_rows.set_name("LocationRangeRows");
@@ -760,7 +825,7 @@ LocationUI::LocationUI ()
        add_button_box->pack_start (add_location_button, true, true);
        add_button_box->pack_start (add_range_button, true, true);
 
-       vbox->pack_start (loc_range_panes);
+       vbox->pack_start (loc_range_panes, true, true);
        vbox->pack_start (*add_button_box, false, false);
 
        pack_start (*vbox);
@@ -773,6 +838,7 @@ LocationUI::LocationUI ()
 
 LocationUI::~LocationUI()
 {
+        delete _clock_group;
 }
 
 gint 
@@ -823,8 +889,6 @@ struct LocationSortByStart {
 void
 LocationUI::location_added (Location* location)
 {
-       ENSURE_GUI_THREAD (*this, &LocationUI::location_added, location)
-
        if (location->is_auto_punch()) {
                punch_edit_row.set_location(location);
        } else if (location->is_auto_loop()) {
@@ -834,7 +898,10 @@ LocationUI::location_added (Location* location)
                loc.sort (LocationSortByStart ());
 
                LocationEditRow* erow = manage (new LocationEditRow (_session, location));
+
+                erow->set_clock_group (*_clock_group);
                erow->remove_requested.connect (sigc::mem_fun (*this, &LocationUI::location_remove_requested));
+
                Box_Helpers::BoxList & children = location->is_range_marker() ? range_rows.children () : location_rows.children ();
 
                /* Step through the location list and the GUI list to find the place to insert */
@@ -904,9 +971,12 @@ LocationUI::map_locations (Locations::LocationList& locations)
 
                if (location->is_mark()) {
                        LocationEditRow* erow = manage (new LocationEditRow (_session, location, mark_n));
+
+                        erow->set_clock_group (*_clock_group);
                        erow->remove_requested.connect (sigc::mem_fun(*this, &LocationUI::location_remove_requested));
                        erow->redraw_ranges.connect (sigc::mem_fun(*this, &LocationUI::location_redraw_ranges));
-                       Box_Helpers::BoxList & loc_children = location_rows.children();
+
+                        Box_Helpers::BoxList & loc_children = location_rows.children();
                        loc_children.push_back(Box_Helpers::Element(*erow, PACK_SHRINK, 1, PACK_START));
                        if (location == newest_location) {
                                newest_location = 0;
@@ -922,7 +992,10 @@ LocationUI::map_locations (Locations::LocationList& locations)
                        loop_edit_row.show_all();
                } else {
                        LocationEditRow* erow = manage (new LocationEditRow(_session, location));
+
+                        erow->set_clock_group (*_clock_group);
                        erow->remove_requested.connect (sigc::mem_fun(*this, &LocationUI::location_remove_requested));
+
                        Box_Helpers::BoxList & range_children = range_rows.children();
                        range_children.push_back(Box_Helpers::Element(*erow,  PACK_SHRINK, 1, PACK_START));
                }
@@ -938,7 +1011,7 @@ LocationUI::add_new_location()
        string markername;
 
        if (_session) {
-               nframes_t where = _session->audible_frame();
+               framepos_t where = _session->audible_frame();
                _session->locations()->next_available_name(markername,"mark");
                Location *location = new Location (*_session, where, where, markername, Location::IsMark);
                if (Config->get_name_new_markers()) {
@@ -960,7 +1033,7 @@ LocationUI::add_new_range()
        string rangename;
 
        if (_session) {
-               nframes_t where = _session->audible_frame();
+               framepos_t where = _session->audible_frame();
                _session->locations()->next_available_name(rangename,"unnamed");
                Location *location = new Location (*_session, where, where, rangename, Location::IsRangeMarker);
                _session->begin_reversible_command (_("add range marker"));
@@ -1043,13 +1116,6 @@ LocationUI::session_going_away()
        SessionHandlePtr::session_going_away ();
 }
 
-void
-LocationEditRow::set_clock_sensitivity ()
-{
-       start_clock.set_sensitive (!location->locked());
-       end_clock.set_sensitive (!location->locked());
-       length_clock.set_sensitive (!location->locked());
-}
 
 /*------------------------*/