OSC: Changed gainVCA to gainfader as VCA is already used.
[ardour.git] / gtk2_ardour / marker.cc
index 79ae58a98d02cccd9daedd4939b20c40ca9e237b..2d9da96b0fc3afd9a97d703bae64b37d87245c49 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2001 Paul Davis 
+    Copyright (C) 2001 Paul Davis
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id$
 */
 
-#include <ardour/tempo.h>
+#include <sigc++/bind.h>
+#include "ardour/tempo.h"
+
+#include "canvas/rectangle.h"
+#include "canvas/container.h"
+#include "canvas/line.h"
+#include "canvas/polygon.h"
+#include "canvas/text.h"
+#include "canvas/canvas.h"
+#include "canvas/scroll_group.h"
+#include "canvas/debug.h"
+
+#include "ui_config.h"
+/*
+ * ardour_ui.h include was moved to the top of the list
+ * due to a conflicting definition of 'Rect' between
+ * Apple's MacTypes.h and GTK.
+ *
+ * Now that we are including ui_config.h and not ardour_ui.h
+ * the above comment may no longer apply and this comment
+ * can be removed and ui_config.h inclusion moved.
+ */
 
 #include "marker.h"
 #include "public_editor.h"
-#include "canvas-simpleline.h"
 #include "utils.h"
+#include "rgb_macros.h"
+
+#include <gtkmm2ext/utils.h>
 
 #include "i18n.h"
 
-Marker::Marker (PublicEditor& ed, ArdourCanvas::Group& parent, guint32 rgba, const string& annotation, 
-               Type type, gint (*callback)(ArdourCanvas::Item *, GdkEvent *, gpointer), jack_nframes_t frame)
+using namespace std;
+using namespace ARDOUR;
+using namespace ARDOUR_UI_UTILS;
+using namespace Gtkmm2ext;
+
+PBD::Signal1<void,ArdourMarker*> ArdourMarker::CatchDeletion;
+
+static double marker_height = 13.0;
 
-       : editor (ed), _type(type)
+void ArdourMarker::setup_sizes(const double timebar_height)
 {
-       double label_offset = 0;
+       marker_height = floor (timebar_height) - 2;
+}
 
-       /* Shapes we use:
+ArdourMarker::ArdourMarker (PublicEditor& ed, ArdourCanvas::Container& parent, guint32 rgba, const string& annotation,
+               Type type, framepos_t frame, bool handle_events)
+
+       : editor (ed)
+       , _parent (&parent)
+       , _track_canvas_line (0)
+       , _type (type)
+       , _selected (false)
+       , _shown (false)
+       , _line_shown (false)
+       , _color (rgba)
+       , _left_label_limit (DBL_MAX)
+       , _right_label_limit (DBL_MAX)
+       , _label_offset (0)
+
+{
+
+       const double MH = marker_height - 1;
+       const double M3 = std::max(1.f, rintf(3.f * UIConfiguration::instance().get_ui_scale()));
+       const double M6 = std::max(2.f, rintf(6.f * UIConfiguration::instance().get_ui_scale()));
 
-         Mark:
-
-          (0,0) -> (6,0)
-            ^        |
-            |        V
-           (0,5)    (6,5)
-              \    / 
-               (3,10)
-
-
-          TempoMark:
-          MeterMark:
-
-               (3,0)
-              /      \
-          (0,5) -> (6,5)
-            ^        |
-            |        V
-           (0,10)<-(6,10)
-
-
-           Start:
-
-          0,0  -> 5,0 
-                   |          \
-            |          10,5
-           |          /
-           0,10 -> 5,10
-
-          End:
-
-            5,0 -> 10,0
-             /       |
-          0,5       |
-             \       |
-            5,10 <-10,10
-
-            
-          TransportStart:
-
-            0,0->3,0
-             |    |
-             |    |
-             |    |
-             |   3,8 -> 7,8
-             |           |
-            0,11 ------ 7,11
-
-          TransportEnd:
-
-                     4,0->7,0
-                      |    |
-                      |    |
-                      |    |
-            0,8 ---- 4,8   |
-             |             |
-            0,11 -------- 7,11
-            
-
-            PunchIn:
-
-            0,0 ------> 8,0
-             |       /
-             |      /
-             |    4,5
-             |     |
-             |     |
-             |     |
-            0,11->4,11
-
-            PunchOut
-
-          0,0 -->-8,0
-           \       | 
-            \      |
-            4,5    |
-             |     |
-             |     |
-             |     |
-            4,11->8,11
-            
-          
-       */
+       /* Shapes we use:
+        *
+        * Mark:
+        *
+        *  (0,0)   ->  (6,0)
+        *    ^           |
+        *    |           V
+        * (0,MH*.4)  (6,MH*.4)
+        *     \         /
+        *        (3,MH)
+        *
+        *
+        * TempoMark:
+        * MeterMark:
+        *
+        *        (3,0)
+        *     /         \
+        * (0,MH*.6)  (6,MH.*.6)
+        *    ^           |
+        *    |           V
+        * (0,MH)   <-  (6,MH)
+        *
+        *
+        * SessionStart:
+        * RangeStart:
+        *
+        *       0,0\
+        *        |  \
+        *        |   \ 6,MH/2
+        *        |   /
+        *        |  /
+        *       0,MH
+        *
+        *
+        * SessionEnd:
+        * RangeEnd:
+        *
+        *         /12,0
+        *        /   |
+        * 6,MH/2/    |
+        *       \    |
+        *        \   |
+        *         \12,MH
+        *
+        *
+        * PunchIn:
+        *
+        *   0,0 ------> marker_height,0
+        *    |       /
+        *    |      /
+        *    |     /
+        *    |    /
+        *    |   /
+        *    |  /
+        *   0,marker_height
+        *
+        *
+        *   PunchOut
+        *
+        *   0,0 ------> marker_height,0
+        *    \        |
+        *     \       |
+        *      \      |
+        *       \     |
+        *        \    |
+        *         \   |
+        *          \  |
+        *   marker_height,marker_height
+        *
+        */
 
        switch (type) {
        case Mark:
                points = new ArdourCanvas::Points ();
 
-               points->push_back (Gnome::Art::Point (0.0, 0.0));
-               points->push_back (Gnome::Art::Point (6.0, 0.0));
-               points->push_back (Gnome::Art::Point (6.0, 5.0));
-               points->push_back (Gnome::Art::Point (3.0, 10.0));              
-               points->push_back (Gnome::Art::Point (0.0, 5.0));               
-               points->push_back (Gnome::Art::Point (0.0, 0.0));               
-               
-               shift = 3;
-               label_offset = 8.0;
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+               points->push_back (ArdourCanvas::Duple ( M6, 0.0));
+               points->push_back (ArdourCanvas::Duple ( M6, MH * .4));
+               points->push_back (ArdourCanvas::Duple ( M3, MH));
+               points->push_back (ArdourCanvas::Duple (0.0, MH * .4));
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+
+               _shift = 3;
+               _label_offset = 10.0;
                break;
 
        case Tempo:
        case Meter:
-
                points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (3.0, 0.0));
-               points->push_back (Gnome::Art::Point (6.0, 5.0));               
-               points->push_back (Gnome::Art::Point (6.0, 10.0));              
-               points->push_back (Gnome::Art::Point (0.0, 10.0));              
-               points->push_back (Gnome::Art::Point (0.0, 5.0));               
-               points->push_back (Gnome::Art::Point (3.0, 0.0));               
-
-               shift = 3;
-               label_offset = 8.0;
+               points->push_back (ArdourCanvas::Duple ( M3, 0.0));
+               points->push_back (ArdourCanvas::Duple ( M6, MH * .6));
+               points->push_back (ArdourCanvas::Duple ( M6, MH));
+               points->push_back (ArdourCanvas::Duple (0.0, MH));
+               points->push_back (ArdourCanvas::Duple (0.0, MH * .6));
+               points->push_back (ArdourCanvas::Duple ( M3, 0.0));
+
+               _shift = 3;
+               _label_offset = 8.0;
                break;
 
-       case Start:
-               points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (0.0, 0.0)); 
-               points->push_back (Gnome::Art::Point (5.0, 0.0));               
-               points->push_back (Gnome::Art::Point (10.0, 5.0));              
-               points->push_back (Gnome::Art::Point (5.0, 10.0));              
-               points->push_back (Gnome::Art::Point (0.0, 10.0));              
-               points->push_back (Gnome::Art::Point (0.0, 0.0));       
-
-               shift = 10;
-               label_offset = 12.0;
+       case SessionStart:
+       case RangeStart:
+               points = new ArdourCanvas::Points ();
+               points->push_back (ArdourCanvas::Duple (    0.0, 0.0));
+               points->push_back (ArdourCanvas::Duple (M6 + .5, MH * .5));
+               points->push_back (ArdourCanvas::Duple (    0.0, MH));
+               points->push_back (ArdourCanvas::Duple (    0.0, 0.0));
+
+               _shift = 0;
+               _label_offset = 8.0;
                break;
 
-       case End:
+       case SessionEnd:
+       case RangeEnd:
                points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (5.0, 0.0));
-               points->push_back (Gnome::Art::Point (10.0, 0.0));              
-               points->push_back (Gnome::Art::Point (10.0, 10.0));             
-               points->push_back (Gnome::Art::Point (5.0, 10.0));              
-               points->push_back (Gnome::Art::Point (0.0, 5.0));               
-               points->push_back (Gnome::Art::Point (5.0, 0.0));               
-               
-               shift = 0;
-               label_offset = 12.0;
+               points->push_back (ArdourCanvas::Duple ( M6, 0.0));
+               points->push_back (ArdourCanvas::Duple ( M6, MH));
+               points->push_back (ArdourCanvas::Duple (0.0, MH * .5));
+               points->push_back (ArdourCanvas::Duple ( M6, 0.0));
+
+               _shift = M6;
+               _label_offset = 0.0;
                break;
 
        case LoopStart:
                points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (0.0, 0.0));
-               points->push_back (Gnome::Art::Point (4.0, 0.0));               
-               points->push_back (Gnome::Art::Point (4.0, 8.0));               
-               points->push_back (Gnome::Art::Point (8.0, 8.0));               
-               points->push_back (Gnome::Art::Point (8.0, 11.0));              
-               points->push_back (Gnome::Art::Point (0.0, 11.0));              
-               points->push_back (Gnome::Art::Point (0.0, 0.0));               
-               
-               shift = 0;
-               label_offset = 11.0;
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+               points->push_back (ArdourCanvas::Duple (marker_height, marker_height));
+               points->push_back (ArdourCanvas::Duple (0.0, marker_height));
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+
+               _shift = 0;
+               _label_offset = marker_height;
                break;
 
        case LoopEnd:
                points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (8.0,  0.0));
-               points->push_back (Gnome::Art::Point (8.0, 11.0));      
-               points->push_back (Gnome::Art::Point (0.0, 11.0));              
-               points->push_back (Gnome::Art::Point (0.0, 8.0));
-               points->push_back (Gnome::Art::Point (4.0, 8.0));
-               points->push_back (Gnome::Art::Point (4.0, 0.0));       
-               points->push_back (Gnome::Art::Point (8.0, 0.0));
-               
-               shift = 8;
-               label_offset = 11.0;
+               points->push_back (ArdourCanvas::Duple (marker_height,  0.0));
+               points->push_back (ArdourCanvas::Duple (marker_height, marker_height));
+               points->push_back (ArdourCanvas::Duple (0.0, marker_height));
+               points->push_back (ArdourCanvas::Duple (marker_height, 0.0));
+
+               _shift = marker_height;
+               _label_offset = 0.0;
                break;
 
-       case  PunchIn:
+       case PunchIn:
                points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (0.0, 0.0));
-               points->push_back (Gnome::Art::Point (8.0, 0.0));               
-               points->push_back (Gnome::Art::Point (4.0, 4.0));       
-               points->push_back (Gnome::Art::Point (4.0, 11.0));      
-               points->push_back (Gnome::Art::Point (0.0, 11.0));      
-               points->push_back (Gnome::Art::Point (0.0, 0.0));       
-
-               shift = 0;
-               label_offset = 10.0;
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+               points->push_back (ArdourCanvas::Duple (marker_height, 0.0));
+               points->push_back (ArdourCanvas::Duple (0.0, marker_height));
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+
+               _shift = 0;
+               _label_offset = marker_height;
                break;
-               
-       case  PunchOut:
+
+       case PunchOut:
                points = new ArdourCanvas::Points ();
-               points->push_back (Gnome::Art::Point (0.0, 0.0));
-               points->push_back (Gnome::Art::Point (8.0, 0.0));               
-               points->push_back (Gnome::Art::Point (8.0, 11.0));              
-               points->push_back (Gnome::Art::Point (4.0, 11.0));              
-               points->push_back (Gnome::Art::Point (4.0, 4.0));               
-               points->push_back (Gnome::Art::Point (0.0, 0.0));               
-
-               shift = 8;
-               label_offset = 11.0;
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+               points->push_back (ArdourCanvas::Duple (marker_height, 0.0));
+               points->push_back (ArdourCanvas::Duple (marker_height, marker_height));
+               points->push_back (ArdourCanvas::Duple (0.0, 0.0));
+
+               _shift = marker_height;
+               _label_offset = 0.0;
                break;
-               
+
        }
 
        frame_position = frame;
-       unit_position = editor.frame_to_unit (frame);
+       unit_position = editor.sample_to_pixel (frame);
+       unit_position -= _shift;
+
+       group = new ArdourCanvas::Container (&parent, ArdourCanvas::Duple (unit_position, 0));
+#ifdef CANVAS_DEBUG
+       group->name = string_compose ("Marker::group for %1", annotation);
+#endif
+
+       _name_background = new ArdourCanvas::Rectangle (group);
+#ifdef CANVAS_DEBUG
+       _name_background->name = string_compose ("Marker::_name_background for %1", annotation);
+#endif
 
        /* adjust to properly locate the tip */
 
-       unit_position -= shift;
+       mark = new ArdourCanvas::Polygon (group);
+       CANVAS_DEBUG_NAME (mark, string_compose ("Marker::mark for %1", annotation));
+
+       mark->set (*points);
+       set_color_rgba (rgba);
+
+       /* setup name pixbuf sizes */
+       name_font = get_font_for_style (N_("MarkerText"));
+
+       Gtk::Label foo;
+
+       Glib::RefPtr<Pango::Layout> layout = foo.create_pango_layout (X_("Hg")); /* ascender + descender */
+       int width;
 
-       group = &parent;
-       group->set_property ("x", unit_position);
-       group->set_property ("y", 1.0);
-       // cerr << "set mark al points, nc = " << points->num_points << endl;
-       mark = new ArdourCanvas::Polygon (*group);
-       mark->set_property ("points", points);
-       mark->set_property ("fill_color_rgba", rgba);
-       mark->set_property ("outline_color", Gdk::Color ("black"));
+       layout->set_font_description (name_font);
+       Gtkmm2ext::get_ink_pixel_size (layout, width, name_height);
 
-       Pango::FontDescription font = get_font_for_style (N_("MarkerText"));
+       _name_item = new ArdourCanvas::Text (group);
+       CANVAS_DEBUG_NAME (_name_item, string_compose ("ArdourMarker::_name_item for %1", annotation));
+       _name_item->set_font_description (name_font);
+       _name_item->set_color (RGBA_TO_UINT (0,0,0,255));
+       _name_item->set_position (ArdourCanvas::Duple (_label_offset, (marker_height - name_height - 1) * .5 ));
 
-       text = new ArdourCanvas::Text (*group);
-       text->set_property ("text", annotation.c_str());
-       text->set_property ("x", label_offset);
-       text->set_property ("y", 0.0);
-       text->set_property ("fontdesc", font);
-       text->set_property ("anchor", Gtk::ANCHOR_NW);
-       text->set_property ("fill_color", Gdk::Color ("black"));
+       set_name (annotation.c_str());
 
-       group->signal_event().connect() (bind (mem_fun (editor, &PublicEditor::reposition), group, this));
+       editor.ZoomChanged.connect (sigc::mem_fun (*this, &ArdourMarker::reposition));
+
+       /* events will be handled by both the group and the mark itself, so
+        * make sure they can both be used to lookup this object.
+        */
+
+       group->set_data ("marker", this);
+       mark->set_data ("marker", this);
+
+       if (handle_events) {
+               group->Event.connect (sigc::bind (sigc::mem_fun (editor, &PublicEditor::canvas_marker_event), group, this));
+       }
 }
 
-Marker::~Marker ()
+ArdourMarker::~ArdourMarker ()
 {
-       /* destroying the group destroys its contents */
-       delete text;
-       delete mark;
-       delete points;
+       CatchDeletion (this); /* EMIT SIGNAL */
+
+       /* destroying the parent group destroys its contents, namely any polygons etc. that we added */
+       delete group;
+       delete _track_canvas_line;
+}
+
+void ArdourMarker::reparent(ArdourCanvas::Container & parent)
+{
+       group->reparent (&parent);
+       _parent = &parent;
+}
+
+void
+ArdourMarker::set_selected (bool s)
+{
+       _selected = s;
+       setup_line ();
 }
 
 void
-Marker::set_name (const string& name)
+ArdourMarker::set_show_line (bool s)
 {
-       text->set_property ("text", name.c_str());
+       _line_shown = s;
+       setup_line ();
+}
+
+void
+ArdourMarker::setup_line ()
+{
+       if (_shown && (_selected || _line_shown)) {
+
+               if (_track_canvas_line == 0) {
+
+                       _track_canvas_line = new ArdourCanvas::Line (editor.get_hscroll_group());
+                       _track_canvas_line->set_outline_color (UIConfiguration::instance().color ("edit point"));
+                       _track_canvas_line->Event.connect (sigc::bind (sigc::mem_fun (editor, &PublicEditor::canvas_marker_event), group, this));
+               }
+
+               ArdourCanvas::Duple g = group->canvas_origin();
+               ArdourCanvas::Duple d = _track_canvas_line->canvas_to_item (ArdourCanvas::Duple (g.x + _shift, 0));
+
+               _track_canvas_line->set_x0 (d.x);
+               _track_canvas_line->set_x1 (d.x);
+               _track_canvas_line->set_y0 (d.y);
+               _track_canvas_line->set_y1 (ArdourCanvas::COORD_MAX);
+               _track_canvas_line->set_outline_color (_selected ? UIConfiguration::instance().color ("edit point") : _color);
+               _track_canvas_line->raise_to_top ();
+               _track_canvas_line->show ();
+
+       } else {
+               if (_track_canvas_line) {
+                       _track_canvas_line->hide ();
+               }
+       }
 }
 
 void
-Marker::set_position (jack_nframes_t frame)
+ArdourMarker::canvas_height_set (double h)
 {
-       double new_unit_position = editor.frame_to_unit (frame);
-       new_unit_position -= shift;
-       group->move (new_unit_position - unit_position, 0.0);
+       _canvas_height = h;
+       setup_line ();
+}
+
+ArdourCanvas::Item&
+ArdourMarker::the_item() const
+{
+       return *group;
+}
+
+void
+ArdourMarker::set_name (const string& new_name)
+{
+       _name = new_name;
+
+       setup_name_display ();
+}
+
+/** @return true if our label is on the left of the mark, otherwise false */
+bool
+ArdourMarker::label_on_left () const
+{
+       return (_type == SessionEnd || _type == RangeEnd || _type == LoopEnd || _type == PunchOut);
+}
+
+void
+ArdourMarker::setup_name_display ()
+{
+       double limit = DBL_MAX;
+
+       if (label_on_left ()) {
+               limit = _left_label_limit;
+       } else {
+               limit = _right_label_limit;
+       }
+
+       const float padding =  std::max(2.f, rintf(2.f * UIConfiguration::instance().get_ui_scale()));
+
+       /* Work out how wide the name can be */
+       int name_width = min ((double) pixel_width (_name, name_font) + padding, limit);
+
+       if (name_width == 0) {
+               _name_item->hide ();
+       } else {
+               _name_item->show ();
+
+               if (label_on_left ()) {
+                       _name_item->set_x_position (-name_width);
+               }
+
+               _name_item->clamp_width (name_width);
+               _name_item->set (_name);
+
+               if (label_on_left ()) {
+                       /* adjust right edge of background to fit text */
+                       _name_background->set_x0 (_name_item->position().x - padding);
+                       _name_background->set_x1 (_name_item->position().x + name_width + _shift);
+               } else {
+                       /* right edge remains at zero (group-relative). Add
+                        * arbitrary 2 pixels of extra padding at the end
+                        */
+                       _name_background->set_x1 (_name_item->position().x + name_width + padding);
+               }
+       }
+
+       _name_background->set_y0 (0);
+       /* unfortunate hard coding - this has to * match the marker bars height */
+       _name_background->set_y1 (marker_height + 1.0);
+}
+
+void
+ArdourMarker::set_position (framepos_t frame)
+{
+       unit_position = editor.sample_to_pixel (frame) - _shift;
+       group->set_x_position (unit_position);
+       setup_line ();
        frame_position = frame;
-       unit_position = new_unit_position;
 }
 
 void
-Marker::reposition ()
+ArdourMarker::reposition ()
 {
        set_position (frame_position);
-}      
+}
+
+void
+ArdourMarker::show ()
+{
+       _shown = true;
+
+        group->show ();
+       setup_line ();
+}
+
+void
+ArdourMarker::hide ()
+{
+       _shown = false;
+
+       group->hide ();
+       setup_line ();
+}
 
 void
-Marker::show ()
+ArdourMarker::set_color_rgba (uint32_t c)
 {
-        group->show();
+       _color = c;
+       mark->set_fill_color (_color);
+       mark->set_outline_color (_color);
+
+       if (_track_canvas_line && !_selected) {
+               _track_canvas_line->set_outline_color (_color);
+       }
+
+       _name_background->set_fill (true);
+       _name_background->set_fill_color (UINT_RGBA_CHANGE_A (_color, 0x70));
+       _name_background->set_outline_color (_color);
 }
 
+/** Set the number of pixels that are available for a label to the left of the centre of this marker */
 void
-Marker::hide ()
+ArdourMarker::set_left_label_limit (double p)
 {
-       group->hide();
+       /* Account for the size of the marker */
+       _left_label_limit = p - marker_height;
+       if (_left_label_limit < 0) {
+               _left_label_limit = 0;
+       }
+
+       if (label_on_left ()) {
+               setup_name_display ();
+       }
 }
 
+/** Set the number of pixels that are available for a label to the right of the centre of this marker */
 void
-Marker::set_color_rgba (uint32_t color)
+ArdourMarker::set_right_label_limit (double p)
 {
-       mark->set_property ("fill_color_rgba", color);
+       /* Account for the size of the marker */
+       _right_label_limit = p - marker_height;
+       if (_right_label_limit < 0) {
+               _right_label_limit = 0;
+       }
+
+       if (!label_on_left ()) {
+               setup_name_display ();
+       }
 }
 
 /***********************************************************************/
 
-TempoMarker::TempoMarker (PublicEditor& editor, ArdourCanvas::Group& parent, guint32 rgba, const string& text, 
-                         ARDOUR::TempoSection& temp, 
-                         gint (*callback)(ArdourCanvas::Item *, GdkEvent *, gpointer))
-       : Marker (editor, parent, rgba, text, Tempo, callback, 0),
+TempoMarker::TempoMarker (PublicEditor& editor, ArdourCanvas::Container& parent, guint32 rgba, const string& text,
+                         ARDOUR::TempoSection& temp)
+       : ArdourMarker (editor, parent, rgba, text, Tempo, 0, false),
          _tempo (temp)
 {
        set_position (_tempo.frame());
-       group->set_data ("tempo_marker", this);
+       group->Event.connect (sigc::bind (sigc::mem_fun (editor, &PublicEditor::canvas_tempo_marker_event), group, this));
 }
 
 TempoMarker::~TempoMarker ()
@@ -327,16 +537,16 @@ TempoMarker::~TempoMarker ()
 
 /***********************************************************************/
 
-MeterMarker::MeterMarker (PublicEditor& editor, ArdourCanvas::Group& parent, guint32 rgba, const string& text, 
-                         ARDOUR::MeterSection& m, 
-                         gint (*callback)(ArdourCanvas::Item *, GdkEvent *, gpointer))
-       : Marker (editor, parent, rgba, text, Meter, callback, 0),
+MeterMarker::MeterMarker (PublicEditor& editor, ArdourCanvas::Container& parent, guint32 rgba, const string& text,
+                         ARDOUR::MeterSection& m)
+       : ArdourMarker (editor, parent, rgba, text, Meter, 0, false),
          _meter (m)
 {
        set_position (_meter.frame());
-       gtk_object_set_data (GTK_OBJECT(group), "meter_marker", this);
+       group->Event.connect (sigc::bind (sigc::mem_fun (editor, &PublicEditor::canvas_meter_marker_event), group, this));
 }
 
 MeterMarker::~MeterMarker ()
 {
 }
+