fix incorrect item name for color
[ardour.git] / gtk2_ardour / midi_region_view.cc
index 94a07e4fdd34fd7c1a5477fe056a83de7d6cb36f..0d44a83e5e92d905ea885c4dd97b2ff64ac7eb38 100644 (file)
@@ -18,7 +18,6 @@
 */
 
 #include <cmath>
-#include <cassert>
 #include <algorithm>
 #include <ostream>
 
 
 #include <sigc++/signal.h>
 
+#include "midi++/midnam_patch.h"
+
 #include "pbd/memento_command.h"
 #include "pbd/stateful_diff_command.h"
 
+#include "ardour/midi_model.h"
 #include "ardour/midi_region.h"
 #include "ardour/midi_source.h"
-#include "ardour/midi_model.h"
-#include "ardour/midi_patch_manager.h"
+#include "ardour/midi_track.h"
+#include "ardour/operations.h"
 #include "ardour/session.h"
 
 #include "evoral/Parameter.hpp"
-#include "evoral/MIDIParameters.hpp"
 #include "evoral/MIDIEvent.hpp"
 #include "evoral/Control.hpp"
 #include "evoral/midi_util.h"
 
+#include "canvas/debug.h"
+#include "canvas/text.h"
+
 #include "automation_region_view.h"
 #include "automation_time_axis.h"
-#include "canvas-hit.h"
-#include "canvas-note.h"
-#include "canvas_patch_change.h"
+#include "control_point.h"
 #include "debug.h"
 #include "editor.h"
 #include "editor_drag.h"
 #include "ghostregion.h"
 #include "gui_thread.h"
+#include "item_counts.h"
 #include "keyboard.h"
 #include "midi_channel_dialog.h"
 #include "midi_cut_buffer.h"
 #include "midi_velocity_dialog.h"
 #include "mouse_cursors.h"
 #include "note_player.h"
+#include "paste_context.h"
 #include "public_editor.h"
+#include "route_time_axis.h"
 #include "rgb_macros.h"
 #include "selection.h"
-#include "simpleline.h"
 #include "streamview.h"
-#include "utils.h"
 #include "patch_change_dialog.h"
 #include "verbose_cursor.h"
+#include "ardour_ui.h"
+#include "note.h"
+#include "hit.h"
+#include "patch_change.h"
+#include "sys_ex.h"
 
 #include "i18n.h"
 
 using namespace ARDOUR;
 using namespace PBD;
 using namespace Editing;
-using namespace ArdourCanvas;
+using namespace std;
 using Gtkmm2ext::Keyboard;
 
 PBD::Signal1<void, MidiRegionView *> MidiRegionView::SelectionCleared;
 
 #define MIDI_BP_ZERO ((Config->get_first_midi_bank_is_zero())?0:1)
 
-MidiRegionView::MidiRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &tv,
-                                boost::shared_ptr<MidiRegion> r, double spu, Gdk::Color const & basic_color)
+MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
+                                RouteTimeAxisView&            tv,
+                                boost::shared_ptr<MidiRegion> r,
+                                double                        spu,
+                                uint32_t                      basic_color)
        : RegionView (parent, tv, r, spu, basic_color)
-       , _last_channel_selection(0xFFFF)
        , _current_range_min(0)
        , _current_range_max(0)
+       , _region_relative_time_converter(r->session().tempo_map(), r->position())
+       , _source_relative_time_converter(r->session().tempo_map(), r->position() - r->start())
        , _active_notes(0)
-       , _note_group(new ArdourCanvas::Group(*group))
+       , _note_group (new ArdourCanvas::Container (group))
        , _note_diff_command (0)
        , _ghost_note(0)
        , _step_edit_cursor (0)
@@ -108,10 +120,14 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
+       , pre_note_enter_cursor (0)
        , _note_player (0)
 {
+       CANVAS_DEBUG_NAME (_note_group, string_compose ("note group for %1", get_item_name()));
        _note_group->raise_to_top();
        PublicEditor::DropDownKeys.connect (sigc::mem_fun (*this, &MidiRegionView::drop_down_keys));
 
@@ -121,15 +137,19 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &
        SelectionCleared.connect (_selection_cleared_connection, invalidator (*this), boost::bind (&MidiRegionView::selection_cleared, this, _1), gui_context ());
 }
 
-MidiRegionView::MidiRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &tv,
-                                boost::shared_ptr<MidiRegion> r, double spu, Gdk::Color& basic_color,
-                                TimeAxisViewItem::Visibility visibility)
+MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
+                                RouteTimeAxisView&            tv,
+                                boost::shared_ptr<MidiRegion> r,
+                                double                        spu,
+                                uint32_t                      basic_color,
+                                TimeAxisViewItem::Visibility  visibility)
        : RegionView (parent, tv, r, spu, basic_color, false, visibility)
-       , _last_channel_selection(0xFFFF)
        , _current_range_min(0)
        , _current_range_max(0)
+       , _region_relative_time_converter(r->session().tempo_map(), r->position())
+       , _source_relative_time_converter(r->session().tempo_map(), r->position() - r->start())
        , _active_notes(0)
-       , _note_group(new ArdourCanvas::Group(*parent))
+       , _note_group (new ArdourCanvas::Container (parent))
        , _note_diff_command (0)
        , _ghost_note(0)
        , _step_edit_cursor (0)
@@ -145,11 +165,16 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
+       , pre_note_enter_cursor (0)
        , _note_player (0)
 {
+       CANVAS_DEBUG_NAME (_note_group, string_compose ("note group for %1", get_item_name()));
        _note_group->raise_to_top();
+
        PublicEditor::DropDownKeys.connect (sigc::mem_fun (*this, &MidiRegionView::drop_down_keys));
 
        connect_to_diskstream ();
@@ -160,7 +185,7 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Group *parent, RouteTimeAxisView &
 void
 MidiRegionView::parameter_changed (std::string const & p)
 {
-       if (p == "diplay-first-midi-bank-as-zero") {
+       if (p == "display-first-midi-bank-as-zero") {
                if (_enable_display) {
                        redisplay_model();
                }
@@ -170,11 +195,12 @@ MidiRegionView::parameter_changed (std::string const & p)
 MidiRegionView::MidiRegionView (const MidiRegionView& other)
        : sigc::trackable(other)
        , RegionView (other)
-       , _last_channel_selection(0xFFFF)
        , _current_range_min(0)
        , _current_range_max(0)
+       , _region_relative_time_converter(other.region_relative_time_converter())
+       , _source_relative_time_converter(other.source_relative_time_converter())
        , _active_notes(0)
-       , _note_group(new ArdourCanvas::Group(*get_canvas_group()))
+       , _note_group (new ArdourCanvas::Container (get_canvas_group()))
        , _note_diff_command (0)
        , _ghost_note(0)
        , _step_edit_cursor (0)
@@ -190,26 +216,24 @@ MidiRegionView::MidiRegionView (const MidiRegionView& other)
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
+       , pre_note_enter_cursor (0)
        , _note_player (0)
 {
-       Gdk::Color c;
-       int r,g,b,a;
-
-       UINT_TO_RGBA (other.fill_color, &r, &g, &b, &a);
-       c.set_rgb_p (r/255.0, g/255.0, b/255.0);
-
-       init (c, false);
+       init (false);
 }
 
 MidiRegionView::MidiRegionView (const MidiRegionView& other, boost::shared_ptr<MidiRegion> region)
        : RegionView (other, boost::shared_ptr<Region> (region))
-       , _last_channel_selection(0xFFFF)
        , _current_range_min(0)
        , _current_range_max(0)
+       , _region_relative_time_converter(other.region_relative_time_converter())
+       , _source_relative_time_converter(other.source_relative_time_converter())
        , _active_notes(0)
-       , _note_group(new ArdourCanvas::Group(*get_canvas_group()))
+       , _note_group (new ArdourCanvas::Container (get_canvas_group()))
        , _note_diff_command (0)
        , _ghost_note(0)
        , _step_edit_cursor (0)
@@ -225,28 +249,25 @@ MidiRegionView::MidiRegionView (const MidiRegionView& other, boost::shared_ptr<M
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
+       , pre_note_enter_cursor (0)
        , _note_player (0)
 {
-       Gdk::Color c;
-       int r,g,b,a;
-
-       UINT_TO_RGBA (other.fill_color, &r, &g, &b, &a);
-       c.set_rgb_p (r/255.0, g/255.0, b/255.0);
-
-       init (c, true);
+       init (true);
 }
 
 void
-MidiRegionView::init (Gdk::Color const & basic_color, bool wfd)
+MidiRegionView::init (bool wfd)
 {
        PublicEditor::DropDownKeys.connect (sigc::mem_fun (*this, &MidiRegionView::drop_down_keys));
 
-       CanvasNoteEvent::CanvasNoteEventDeleted.connect (note_delete_connection, MISSING_INVALIDATOR,
-                                                        boost::bind (&MidiRegionView::maybe_remove_deleted_note_from_selection, this, _1),
-                                                        gui_context());
-
+       NoteBase::NoteBaseDeleted.connect (note_delete_connection, MISSING_INVALIDATOR,
+                                          boost::bind (&MidiRegionView::maybe_remove_deleted_note_from_selection, this, _1),
+                                          gui_context());
+       
        if (wfd) {
                midi_region()->midi_source(0)->load_model();
        }
@@ -254,9 +275,7 @@ MidiRegionView::init (Gdk::Color const & basic_color, bool wfd)
        _model = midi_region()->midi_source(0)->model();
        _enable_display = false;
 
-       RegionView::init (basic_color, false);
-
-       compute_colors (basic_color);
+       RegionView::init (false);
 
        set_height (trackview.current_height());
 
@@ -265,8 +284,6 @@ MidiRegionView::init (Gdk::Color const & basic_color, bool wfd)
        region_resized (ARDOUR::bounds_change);
        region_locked ();
 
-       reset_width_dependent_items (_pixel_width);
-
        set_colors ();
 
        _enable_display = true;
@@ -276,12 +293,13 @@ MidiRegionView::init (Gdk::Color const & basic_color, bool wfd)
                }
        }
 
+       reset_width_dependent_items (_pixel_width);
+
        group->raise_to_top();
-       group->signal_event().connect(
-               sigc::mem_fun(this, &MidiRegionView::canvas_event), false);
 
-       midi_view()->signal_channel_mode_changed().connect(
-               sigc::mem_fun(this, &MidiRegionView::midi_channel_mode_changed));
+       midi_view()->midi_track()->PlaybackChannelModeChanged.connect (_channel_mode_changed_connection, invalidator (*this),
+                                                                      boost::bind (&MidiRegionView::midi_channel_mode_changed, this),
+                                                                      gui_context ());
 
        instrument_info().Changed.connect (_instrument_changed_connection, invalidator (*this),
                                           boost::bind (&MidiRegionView::instrument_settings_changed, this), gui_context());
@@ -319,38 +337,49 @@ MidiRegionView::connect_to_diskstream ()
 }
 
 bool
-MidiRegionView::canvas_event(GdkEvent* ev)
+MidiRegionView::canvas_group_event(GdkEvent* ev)
 {
+       if (in_destructor) {
+               return false;
+       }
+
+       if (!trackview.editor().internal_editing()) {
+               // not in internal edit mode, so just act like a normal region
+               return RegionView::canvas_group_event (ev);
+       }
+
+       const MouseMode m = trackview.editor().current_mouse_mode();
        bool r;
-       
+
        switch (ev->type) {
        case GDK_ENTER_NOTIFY:
-       case GDK_LEAVE_NOTIFY:
                _last_event_x = ev->crossing.x;
                _last_event_y = ev->crossing.y;
-               break;
-       case GDK_MOTION_NOTIFY:
-               _last_event_x = ev->motion.x;
-               _last_event_y = ev->motion.y;
-               break;
-       default:
-               break;
-       }
+               enter_notify(&ev->crossing);
+               // set entered_regionview (among other things)
+               return RegionView::canvas_group_event (ev);
 
-       if (ev->type == GDK_2BUTTON_PRESS) {
-               return trackview.editor().toggle_internal_editing_from_double_click (ev);
-       }
+       case GDK_LEAVE_NOTIFY:
+               _last_event_x = ev->crossing.x;
+               _last_event_y = ev->crossing.y;
+               leave_notify(&ev->crossing);
+               // reset entered_regionview (among other things)
+               return RegionView::canvas_group_event (ev);
 
-       if ((!trackview.editor().internal_editing() && trackview.editor().current_mouse_mode() != MouseGain) ||
-               (trackview.editor().current_mouse_mode() == MouseTimeFX) ||
-               (trackview.editor().current_mouse_mode() == MouseZoom)) {
-               // handle non-draw modes elsewhere
-               return false;
-       }
+       case GDK_2BUTTON_PRESS:
+               // cannot use double-click to exit internal mode if single-click is being used
+               if ((m != MouseDraw) &&
+                   (m != MouseObject ||
+                    !Keyboard::modifier_state_contains (ev->button.state, Keyboard::insert_note_modifier()))) {
+                       return trackview.editor().toggle_internal_editing_from_double_click (ev);
+               }
+               break;
 
-       switch (ev->type) {
        case GDK_SCROLL:
-               return scroll (&ev->scroll);
+               if (scroll (&ev->scroll)) {
+                       return true;
+               }
+               break;
 
        case GDK_KEY_PRESS:
                return key_press (&ev->key);
@@ -367,27 +396,16 @@ MidiRegionView::canvas_event(GdkEvent* ev)
                _note_player = 0;
                return r;
 
-       case GDK_ENTER_NOTIFY:
-               return enter_notify (&ev->crossing);
-
-       case GDK_LEAVE_NOTIFY:
-               return leave_notify (&ev->crossing);
-
        case GDK_MOTION_NOTIFY:
+               _last_event_x = ev->motion.x;
+               _last_event_y = ev->motion.y;
                return motion (&ev->motion);
 
        default:
                break;
        }
 
-       return false;
-}
-
-void
-MidiRegionView::remove_ghost_note ()
-{
-       delete _ghost_note;
-       _ghost_note = 0;
+       return RegionView::canvas_group_event (ev);
 }
 
 bool
@@ -397,24 +415,9 @@ MidiRegionView::enter_notify (GdkEventCrossing* ev)
                _mouse_mode_connection, invalidator (*this), boost::bind (&MidiRegionView::mouse_mode_changed, this), gui_context ()
                );
 
-       if (trackview.editor().current_mouse_mode() == MouseDraw && _mouse_state != AddDragging) {
-               create_ghost_note (ev->x, ev->y);
-       }
-
-       if (!trackview.editor().internal_editing()) {
-               Keyboard::magic_widget_drop_focus();
-       } else {
-               Keyboard::magic_widget_grab_focus();
-               group->grab_focus();
-       }
-
-       // if current operation is non-operational in a midi region, change the cursor to so indicate
-       if (trackview.editor().current_mouse_mode() == MouseGain) {
-               Editor* editor = dynamic_cast<Editor *> (&trackview.editor());
-               pre_enter_cursor = editor->get_canvas_cursor();
-               editor->set_canvas_cursor(editor->cursors()->timebar);
-       }
+       enter_internal();
 
+       _entered = true;
        return false;
 }
 
@@ -423,32 +426,48 @@ MidiRegionView::leave_notify (GdkEventCrossing*)
 {
        _mouse_mode_connection.disconnect ();
 
-       trackview.editor().verbose_cursor()->hide ();
-       remove_ghost_note ();
-
-       if (pre_enter_cursor) {
-               Editor* editor = dynamic_cast<Editor *> (&trackview.editor());
-               editor->set_canvas_cursor(pre_enter_cursor);
-       }
+       leave_internal();
 
+       _entered = false;
        return false;
 }
 
 void
 MidiRegionView::mouse_mode_changed ()
 {
-       if (trackview.editor().current_mouse_mode() == MouseDraw && trackview.editor().internal_editing()) {
-               create_ghost_note (_last_event_x, _last_event_y);
+       if (trackview.editor().internal_editing()) {
+               // Switched in to internal editing mode while entered
+               enter_internal();
        } else {
-               remove_ghost_note ();
-               trackview.editor().verbose_cursor()->hide ();
+               // Switched out of internal editing mode while entered
+               leave_internal();
        }
+}
 
-       if (!trackview.editor().internal_editing()) {
-               Keyboard::magic_widget_drop_focus();
-       } else {
+void
+MidiRegionView::enter_internal()
+{
+       if (trackview.editor().current_mouse_mode() == MouseDraw && _mouse_state != AddDragging) {
+               // Show ghost note under pencil
+               create_ghost_note(_last_event_x, _last_event_y);
+       }
+
+       if (!_selection.empty()) {
+               // Grab keyboard for moving selected notes with arrow keys
                Keyboard::magic_widget_grab_focus();
-               group->grab_focus();
+               _grabbed_keyboard = true;
+       }
+}
+
+void
+MidiRegionView::leave_internal()
+{
+       trackview.editor().verbose_cursor()->hide ();
+       remove_ghost_note ();
+
+       if (_grabbed_keyboard) {
+               Keyboard::magic_widget_drop_focus();
+               _grabbed_keyboard = false;
        }
 }
 
@@ -465,7 +484,7 @@ MidiRegionView::button_press (GdkEventButton* ev)
        if (m == MouseObject && Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier())) {
                pre_press_cursor = editor->get_canvas_cursor ();
                editor->set_canvas_cursor (editor->cursors()->midi_pencil);
-       } 
+       }
 
        if (_mouse_state != SelectTouchDragging) {
                
@@ -492,8 +511,8 @@ MidiRegionView::button_release (GdkEventButton* ev)
        event_x = ev->x;
        event_y = ev->y;
 
-       group->w2i(event_x, event_y);
-       group->ungrab(ev->time);
+       group->canvas_to_item (event_x, event_y);
+       group->ungrab ();
 
        PublicEditor& editor = trackview.editor ();
 
@@ -522,40 +541,30 @@ MidiRegionView::button_release (GdkEventButton* ev)
 
                                        event_x = ev->x;
                                        event_y = ev->y;
-                                       group->w2i(event_x, event_y);
+                                       group->canvas_to_item (event_x, event_y);
 
-                                       bool success;
-                                       Evoral::MusicalTime beats = editor.get_grid_type_as_beats (success, editor.pixel_to_frame (event_x));
-
-                                       if (!success) {
-                                               beats = 1;
-                                       }
+                                       Evoral::MusicalTime beats = get_grid_beats(editor.pixel_to_sample(event_x));
 
                                        /* Shorten the length by 1 tick so that we can add a new note at the next
                                           grid snap without it overlapping this one.
                                        */
-                                       beats -= 1.0 / Timecode::BBT_Time::ticks_per_beat;
+                                       beats -= Evoral::MusicalTime::tick();
 
-                                       create_note_at (editor.pixel_to_frame (event_x), event_y, beats, true);
+                                       create_note_at (editor.pixel_to_sample (event_x), event_y, beats, true);
                                }
 
                                break;
                        }
                case MouseDraw:
                        {
-                               bool success;
-                               Evoral::MusicalTime beats = editor.get_grid_type_as_beats (success, editor.pixel_to_frame (event_x));
-
-                               if (!success) {
-                                       beats = 1;
-                               }
+                               Evoral::MusicalTime beats = get_grid_beats(editor.pixel_to_sample(event_x));
 
                                /* Shorten the length by 1 tick so that we can add a new note at the next
                                   grid snap without it overlapping this one.
                                */
-                               beats -= 1.0 / Timecode::BBT_Time::ticks_per_beat;
+                               beats -= Evoral::MusicalTime::tick();
                                
-                               create_note_at (editor.pixel_to_frame (event_x), event_y, beats, true);
+                               create_note_at (editor.pixel_to_sample (event_x), event_y, beats, true);
 
                                break;
                        }
@@ -621,7 +630,6 @@ MidiRegionView::motion (GdkEventMotion* ev)
                        MouseMode m = editor.current_mouse_mode();
                        
                        if (m == MouseDraw || (m == MouseObject && Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier()))) {
-                       
                                editor.drags()->set (new NoteCreateDrag (dynamic_cast<Editor *> (&editor), group, this), (GdkEvent *) ev);
                                _mouse_state = AddDragging;
                                remove_ghost_note ();
@@ -629,7 +637,9 @@ MidiRegionView::motion (GdkEventMotion* ev)
                                return true;
                        } else if (m == MouseObject) {
                                editor.drags()->set (new MidiRubberbandSelectDrag (dynamic_cast<Editor *> (&editor), this), (GdkEvent *) ev);
-                               clear_selection ();
+                               if (!Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
+                                       clear_selection ();
+                               }
                                _mouse_state = SelectRectDragging;
                                return true;
                        } else if (m == MouseRange) {
@@ -652,9 +662,13 @@ MidiRegionView::motion (GdkEventMotion* ev)
 
        default:
                break;
+
        }
 
-       return false;
+       /* we may be dragging some non-note object (eg. patch-change, sysex) 
+        */
+
+       return editor.drags()->motion_handler ((GdkEvent *) ev, false);
 }
 
 
@@ -681,7 +695,11 @@ MidiRegionView::scroll (GdkEventScroll* ev)
                change_velocities (true, fine, false, together);
        } else if (ev->direction == GDK_SCROLL_DOWN) {
                change_velocities (false, fine, false, together);
+       } else {
+               /* left, right: we don't use them */
+               return false;
        }
+
        return true;
 }
 
@@ -710,11 +728,15 @@ MidiRegionView::key_press (GdkEventKey* ev)
                bool shorter = Keyboard::modifier_state_contains (ev->state, Keyboard::PrimaryModifier);
                bool fine = Keyboard::modifier_state_contains (ev->state, Keyboard::SecondaryModifier);
 
-               change_note_lengths (fine, shorter, 0.0, start, end);
+               change_note_lengths (fine, shorter, Evoral::MusicalTime(), start, end);
 
                return true;
 
-       } else if (ev->keyval == GDK_Delete && unmodified) {
+       } else if ((ev->keyval == GDK_BackSpace || ev->keyval == GDK_Delete) && unmodified) {
+
+               if (_selection.empty()) {
+                       return false;
+               }
 
                delete_selection();
                return true;
@@ -767,14 +789,16 @@ MidiRegionView::key_press (GdkEventKey* ev)
                }
                return true;
 
-       } else if (ev->keyval == GDK_Left && unmodified) {
+       } else if (ev->keyval == GDK_Left) {
 
-               nudge_notes (false);
+               bool fine = !Keyboard::modifier_state_contains (ev->state, Keyboard::SecondaryModifier);
+               nudge_notes (false, fine);
                return true;
 
-       } else if (ev->keyval == GDK_Right && unmodified) {
+       } else if (ev->keyval == GDK_Right) {
 
-               nudge_notes (true);
+               bool fine = !Keyboard::modifier_state_contains (ev->state, Keyboard::SecondaryModifier);
+               nudge_notes (true, fine);
                return true;
 
        } else if (ev->keyval == GDK_c && unmodified) {
@@ -887,15 +911,16 @@ MidiRegionView::show_list_editor ()
  * \param snap_t true to snap t to the grid, otherwise false.
  */
 void
-MidiRegionView::create_note_at (framepos_t t, double y, double length, bool snap_t)
+MidiRegionView::create_note_at (framepos_t t, double y, Evoral::MusicalTime length, bool snap_t)
 {
+       if (length < 2 * DBL_EPSILON) {
+               return;
+       }
+
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
        MidiStreamView* const view = mtv->midi_view();
 
-       double note = view->y_to_note(y);
-
-       assert(note >= 0.0);
-       assert(note <= 127.0);
+       const double note = view->y_to_note(y);
 
        // Start of note in frames relative to region start
        if (snap_t) {
@@ -903,13 +928,11 @@ MidiRegionView::create_note_at (framepos_t t, double y, double length, bool snap
                t = snap_frame_to_grid_underneath (t, grid_frames);
        }
 
-       assert (t >= 0);
-       assert (length != 0);
-
-       const boost::shared_ptr<NoteType> new_note (new NoteType (mtv->get_channel_for_add (),
-                                                                 region_frames_to_region_beats(t + _region->start()), 
-                                                                 length,
-                                                                 (uint8_t)note, 0x40));
+       const boost::shared_ptr<NoteType> new_note (
+               new NoteType (mtv->get_channel_for_add (),
+                             region_frames_to_region_beats(t + _region->start()), 
+                             length,
+                             (uint8_t)note, 0x40));
 
        if (_model->contains (new_note)) {
                return;
@@ -925,9 +948,9 @@ MidiRegionView::create_note_at (framepos_t t, double y, double length, bool snap
 }
 
 void
-MidiRegionView::clear_events()
+MidiRegionView::clear_events (bool with_selection_signal)
 {
-       clear_selection();
+       clear_selection (with_selection_signal);
 
        MidiGhostRegion* gr;
        for (std::vector<GhostRegion*>::iterator g = ghosts.begin(); g != ghosts.end(); ++g) {
@@ -984,7 +1007,7 @@ MidiRegionView::note_diff_add_note (const boost::shared_ptr<NoteType> note, bool
 }
 
 void
-MidiRegionView::note_diff_remove_note (ArdourCanvas::CanvasNoteEvent* ev)
+MidiRegionView::note_diff_remove_note (NoteBase* ev)
 {
        if (_note_diff_command && ev->note()) {
                _note_diff_command->remove(ev->note());
@@ -992,7 +1015,7 @@ MidiRegionView::note_diff_remove_note (ArdourCanvas::CanvasNoteEvent* ev)
 }
 
 void
-MidiRegionView::note_diff_add_change (ArdourCanvas::CanvasNoteEvent* ev,
+MidiRegionView::note_diff_add_change (NoteBase* ev,
                                       MidiModel::NoteDiffCommand::Property property,
                                       uint8_t val)
 {
@@ -1002,7 +1025,7 @@ MidiRegionView::note_diff_add_change (ArdourCanvas::CanvasNoteEvent* ev,
 }
 
 void
-MidiRegionView::note_diff_add_change (ArdourCanvas::CanvasNoteEvent* ev,
+MidiRegionView::note_diff_add_change (NoteBase* ev,
                                       MidiModel::NoteDiffCommand::Property property,
                                       Evoral::MusicalTime val)
 {
@@ -1051,7 +1074,7 @@ MidiRegionView::abort_command()
        clear_selection();
 }
 
-CanvasNoteEvent*
+NoteBase*
 MidiRegionView::find_canvas_note (boost::shared_ptr<NoteType> note)
 {
        if (_optimization_iterator != _events.end()) {
@@ -1078,7 +1101,7 @@ MidiRegionView::get_events (Events& e, Evoral::Sequence<Evoral::MusicalTime>::No
        _model->get_notes (notes, op, val, chan_mask);
 
        for (MidiModel::Notes::iterator n = notes.begin(); n != notes.end(); ++n) {
-               CanvasNoteEvent* cne = find_canvas_note (*n);
+               NoteBase* cne = find_canvas_note (*n);
                if (cne) {
                        e.push_back (cne);
                }
@@ -1106,24 +1129,26 @@ MidiRegionView::redisplay_model()
        MidiModel::Notes& notes (_model->notes());
        _optimization_iterator = _events.begin();
 
+       bool empty_when_starting = _events.empty();
+
        for (MidiModel::Notes::iterator n = notes.begin(); n != notes.end(); ++n) {
 
                boost::shared_ptr<NoteType> note (*n);
-               CanvasNoteEvent* cne;
+               NoteBase* cne;
                bool visible;
 
                if (note_in_region_range (note, visible)) {
-
-                       if ((cne = find_canvas_note (note)) != 0) {
+                       
+                       if (!empty_when_starting && (cne = find_canvas_note (note)) != 0) {
 
                                cne->validate ();
 
-                               CanvasNote* cn;
-                               CanvasHit* ch;
+                               Note* cn;
+                               Hit* ch;
 
-                               if ((cn = dynamic_cast<CanvasNote*>(cne)) != 0) {
+                               if ((cn = dynamic_cast<Note*>(cne)) != 0) {
                                        update_note (cn);
-                               } else if ((ch = dynamic_cast<CanvasHit*>(cne)) != 0) {
+                               } else if ((ch = dynamic_cast<Hit*>(cne)) != 0) {
                                        update_hit (ch);
                                }
 
@@ -1139,8 +1164,8 @@ MidiRegionView::redisplay_model()
                        }
 
                } else {
-
-                       if ((cne = find_canvas_note (note)) != 0) {
+                       
+                       if (!empty_when_starting && (cne = find_canvas_note (note)) != 0) {
                                cne->validate ();
                                cne->hide ();
                        }
@@ -1150,21 +1175,23 @@ MidiRegionView::redisplay_model()
 
        /* remove note items that are no longer valid */
 
-       for (Events::iterator i = _events.begin(); i != _events.end(); ) {
-               if (!(*i)->valid ()) {
-
-                       for (vector<GhostRegion*>::iterator j = ghosts.begin(); j != ghosts.end(); ++j) {
-                               MidiGhostRegion* gr = dynamic_cast<MidiGhostRegion*> (*j);
-                               if (gr) {
-                                       gr->remove_note (*i);
+       if (!empty_when_starting) {
+               for (Events::iterator i = _events.begin(); i != _events.end(); ) {
+                       if (!(*i)->valid ()) {
+                               
+                               for (vector<GhostRegion*>::iterator j = ghosts.begin(); j != ghosts.end(); ++j) {
+                                       MidiGhostRegion* gr = dynamic_cast<MidiGhostRegion*> (*j);
+                                       if (gr) {
+                                               gr->remove_note (*i);
+                                       }
                                }
+                               
+                               delete *i;
+                               i = _events.erase (i);
+                               
+                       } else {
+                               ++i;
                        }
-                       
-                       delete *i;
-                       i = _events.erase (i);
-                       
-               } else {
-                       ++i;
                }
        }
 
@@ -1189,7 +1216,7 @@ void
 MidiRegionView::display_patch_changes ()
 {
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
-       uint16_t chn_mask = mtv->channel_selector().get_selected_channels();
+       uint16_t chn_mask = mtv->midi_track()->get_playback_channel_mask();
 
        for (uint8_t i = 0; i < 16; ++i) {
                display_patch_changes_on_channel (i, chn_mask & (1 << i));
@@ -1208,7 +1235,7 @@ MidiRegionView::display_patch_changes_on_channel (uint8_t channel, bool active_c
                        continue;
                }
 
-               string patch_name = instrument_info().get_patch_name ((*i)->bank(), (*i)->program(), channel);
+               const string patch_name = instrument_info().get_patch_name ((*i)->bank(), (*i)->program(), channel);
                add_canvas_patch_change (*i, patch_name, active_channel);
        }
 }
@@ -1259,7 +1286,6 @@ MidiRegionView::display_sysexes()
                        boost::static_pointer_cast<const Evoral::MIDIEvent<Evoral::MusicalTime> > (*i);
 
                Evoral::MusicalTime time = (*i)->time();
-               assert (time >= 0);
 
                if (mev) {
                        if (mev->is_spp() || mev->is_mtc_quarter() || mev->is_mtc_full()) {
@@ -1279,12 +1305,15 @@ MidiRegionView::display_sysexes()
                }
                string text = str.str();
 
-               const double x = trackview.editor().frame_to_pixel(source_beats_to_absolute_frames(time));
+               const double x = trackview.editor().sample_to_pixel(source_beats_to_region_frames(time));
 
                double height = midi_stream_view()->contents_height();
 
-               boost::shared_ptr<CanvasSysEx> sysex = boost::shared_ptr<CanvasSysEx>(
-                       new CanvasSysEx(*this, *_note_group, text, height, x, 1.0));
+               // CAIROCANVAS: no longer passing *i (the sysex event) to the
+               // SysEx canvas object!!!
+
+               boost::shared_ptr<SysEx> sysex = boost::shared_ptr<SysEx>(
+                       new SysEx (*this, _note_group, text, height, x, 1.0));
 
                // Show unless message is beyond the region bounds
                if (time - _region->start() >= _region->length() || time < _region->start()) {
@@ -1316,7 +1345,7 @@ MidiRegionView::~MidiRegionView ()
        _selection_cleared_connection.disconnect ();
 
        _selection.clear();
-       clear_events();
+       clear_events (false);
 
        delete _note_group;
        delete _note_diff_command;
@@ -1330,23 +1359,36 @@ MidiRegionView::region_resized (const PropertyChange& what_changed)
        RegionView::region_resized(what_changed);
 
        if (what_changed.contains (ARDOUR::Properties::position)) {
+               _region_relative_time_converter.set_origin_b(_region->position());
                set_duration(_region->length(), 0);
                if (_enable_display) {
                        redisplay_model();
                }
        }
+
+       if (what_changed.contains (ARDOUR::Properties::start) ||
+           what_changed.contains (ARDOUR::Properties::position)) {
+               _source_relative_time_converter.set_origin_b (_region->position() - _region->start());
+       }
 }
 
 void
 MidiRegionView::reset_width_dependent_items (double pixel_width)
 {
        RegionView::reset_width_dependent_items(pixel_width);
-       assert(_pixel_width == pixel_width);
 
        if (_enable_display) {
                redisplay_model();
        }
 
+       for (PatchChanges::iterator x = _patch_changes.begin(); x != _patch_changes.end(); ++x) {
+               if ((*x)->canvas_item()->width() >= _pixel_width) {
+                       (*x)->hide();
+               } else {
+                       (*x)->show();
+               }
+       }
+
        move_step_edit_cursor (_step_edit_cursor_position);
        set_step_edit_cursor_width (_step_edit_cursor_width);
 }
@@ -1354,17 +1396,15 @@ MidiRegionView::reset_width_dependent_items (double pixel_width)
 void
 MidiRegionView::set_height (double height)
 {
-       static const double FUDGE = 2.0;
-       const double old_height = _height;
+       double old_height = _height;
        RegionView::set_height(height);
-       _height = height - FUDGE;
 
-       apply_note_range(midi_stream_view()->lowest_note(),
-                        midi_stream_view()->highest_note(),
-                        height != old_height + FUDGE);
+       apply_note_range (midi_stream_view()->lowest_note(),
+                         midi_stream_view()->highest_note(),
+                         height != old_height);
 
-       if (name_pixbuf) {
-               name_pixbuf->raise_to_top();
+       if (name_text) {
+               name_text->raise_to_top();
        }
 
        for (PatchChanges::iterator x = _patch_changes.begin(); x != _patch_changes.end(); ++x) {
@@ -1372,7 +1412,7 @@ MidiRegionView::set_height (double height)
        }
 
        if (_step_edit_cursor) {
-               _step_edit_cursor->property_y2() = midi_stream_view()->contents_height();
+               _step_edit_cursor->set_y1 (midi_stream_view()->contents_height());
        }
 }
 
@@ -1395,7 +1435,7 @@ MidiRegionView::apply_note_range (uint8_t min, uint8_t max, bool force)
        _current_range_max = max;
 
        for (Events::const_iterator i = _events.begin(); i != _events.end(); ++i) {
-               CanvasNoteEvent* event = *i;
+               NoteBase* event = *i;
                boost::shared_ptr<NoteType> note (event->note());
 
                if (note->note() < _current_range_min ||
@@ -1405,19 +1445,16 @@ MidiRegionView::apply_note_range (uint8_t min, uint8_t max, bool force)
                        event->show();
                }
 
-               if (CanvasNote* cnote = dynamic_cast<CanvasNote*>(event)) {
+               if (Note* cnote = dynamic_cast<Note*>(event)) {
 
-                       const double y1 = midi_stream_view()->note_to_y(note->note());
-                       const double y2 = y1 + floor(midi_stream_view()->note_height());
+                       const double y0 = 1. + floor (midi_stream_view()->note_to_y(note->note()));
+                       const double y1 = y0 + std::max(1., floor(midi_stream_view()->note_height()) - 1.);
 
-                       cnote->property_y1() = y1;
-                       cnote->property_y2() = y2;
+                       cnote->set_y0 (y0);
+                       cnote->set_y1 (y1);
 
-               } else if (CanvasHit* chit = dynamic_cast<CanvasHit*>(event)) {
-
-                       const double diamond_size = update_hit (chit);
-
-                       chit->set_height (diamond_size);
+               } else if (Hit* chit = dynamic_cast<Hit*>(event)) {
+                       update_hit (chit);
                }
        }
 }
@@ -1425,9 +1462,9 @@ MidiRegionView::apply_note_range (uint8_t min, uint8_t max, bool force)
 GhostRegion*
 MidiRegionView::add_ghost (TimeAxisView& tv)
 {
-       CanvasNote* note;
+       Note* note;
 
-       double unit_position = _region->position () / samples_per_unit;
+       double unit_position = _region->position () / samples_per_pixel;
        MidiTimeAxisView* mtv = dynamic_cast<MidiTimeAxisView*>(&tv);
        MidiGhostRegion* ghost;
 
@@ -1441,13 +1478,13 @@ MidiRegionView::add_ghost (TimeAxisView& tv)
        }
 
        for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
-               if ((note = dynamic_cast<CanvasNote*>(*i)) != 0) {
+               if ((note = dynamic_cast<Note*>(*i)) != 0) {
                        ghost->add_note(note);
                }
        }
 
        ghost->set_height ();
-       ghost->set_duration (_region->length() / samples_per_unit);
+       ghost->set_duration (_region->length() / samples_per_pixel);
        ghosts.push_back (ghost);
 
        GhostRegion::CatchDeletion.connect (*this, invalidator (*this), boost::bind (&RegionView::remove_ghost, this, _1), gui_context());
@@ -1461,9 +1498,11 @@ MidiRegionView::add_ghost (TimeAxisView& tv)
 void
 MidiRegionView::begin_write()
 {
-       assert(!_active_notes);
-       _active_notes = new CanvasNote*[128];
-       for (unsigned i=0; i < 128; ++i) {
+       if (_active_notes) {
+               delete[] _active_notes;
+       }
+       _active_notes = new Note*[128];
+       for (unsigned i = 0; i < 128; ++i) {
                _active_notes[i] = 0;
        }
 }
@@ -1484,7 +1523,7 @@ MidiRegionView::end_write()
 /** Resolve an active MIDI note (while recording).
  */
 void
-MidiRegionView::resolve_note(uint8_t note, double end_time)
+MidiRegionView::resolve_note(uint8_t note, Evoral::MusicalTime end_time)
 {
        if (midi_view()->note_mode() != Sustained) {
                return;
@@ -1498,9 +1537,10 @@ MidiRegionView::resolve_note(uint8_t note, double end_time)
                */
                const framepos_t end_time_frames = region_beats_to_region_frames(end_time);
 
-               _active_notes[note]->property_x2() = trackview.editor().frame_to_pixel(end_time_frames);
-               _active_notes[note]->property_outline_what() = (guint32) 0xF; // all edges
+               _active_notes[note]->set_x1 (trackview.editor().sample_to_pixel(end_time_frames));
+               _active_notes[note]->set_outline_all ();
                _active_notes[note] = 0;
+
        }
 }
 
@@ -1516,7 +1556,7 @@ MidiRegionView::extend_active_notes()
 
        for (unsigned i=0; i < 128; ++i) {
                if (_active_notes[i]) {
-                       _active_notes[i]->property_x2() = trackview.editor().frame_to_pixel(_region->length());
+                       _active_notes[i]->set_x1 (trackview.editor().sample_to_pixel(_region->length()));
                }
        }
 }
@@ -1602,46 +1642,48 @@ MidiRegionView::note_in_region_range (const boost::shared_ptr<NoteType> note, bo
  *  @param update_ghost_regions true to update the note in any ghost regions that we have, otherwise false.
  */
 void
-MidiRegionView::update_note (CanvasNote* ev, bool update_ghost_regions)
+MidiRegionView::update_note (Note* ev, bool update_ghost_regions)
 {
        boost::shared_ptr<NoteType> note = ev->note();
-       const double x = trackview.editor().frame_to_pixel (source_beats_to_region_frames (note->time()));
-       const double y1 = midi_stream_view()->note_to_y(note->note());
+       const double x = trackview.editor().sample_to_pixel (source_beats_to_region_frames (note->time()));
+       const double y0 = 1 + floor(midi_stream_view()->note_to_y(note->note()));
 
-       ev->property_x1() = x;
-       ev->property_y1() = y1;
+       ev->set_x0 (x);
+       ev->set_y0 (y0);
 
        /* trim note display to not overlap the end of its region */
 
        if (note->length() > 0) {
                const framepos_t note_end_frames = min (source_beats_to_region_frames (note->end_time()), _region->length());
-               ev->property_x2() = trackview.editor().frame_to_pixel (note_end_frames);
+               ev->set_x1 (trackview.editor().sample_to_pixel (note_end_frames));
        } else {
-               ev->property_x2() = trackview.editor().frame_to_pixel (_region->length());
+               ev->set_x1 (trackview.editor().sample_to_pixel (_region->length()));
        }
 
-       ev->property_y2() = y1 + floor(midi_stream_view()->note_height());
+       ev->set_y1 (y0 + std::max(1., floor(midi_stream_view()->note_height()) - 1));
 
-       if (note->length() == 0) {
-               if (_active_notes) {
-                       assert(note->note() < 128);
+       if (!note->length()) {
+               if (_active_notes && note->note() < 128) {
                        // If this note is already active there's a stuck note,
                        // finish the old note rectangle
                        if (_active_notes[note->note()]) {
-                               CanvasNote* const old_rect = _active_notes[note->note()];
+                               Note* const old_rect = _active_notes[note->note()];
                                boost::shared_ptr<NoteType> old_note = old_rect->note();
-                               old_rect->property_x2() = x;
-                               old_rect->property_outline_what() = (guint32) 0xF;
+                               old_rect->set_x1 (x);
+                               old_rect->set_outline_all ();
                        }
                        _active_notes[note->note()] = ev;
                }
                /* outline all but right edge */
-               ev->property_outline_what() = (guint32) (0x1 & 0x4 & 0x8);
+               ev->set_outline_what (ArdourCanvas::Rectangle::What (
+                                             ArdourCanvas::Rectangle::TOP|
+                                             ArdourCanvas::Rectangle::LEFT|
+                                             ArdourCanvas::Rectangle::BOTTOM));
        } else {
                /* outline all edges */
-               ev->property_outline_what() = (guint32) 0xF;
+               ev->set_outline_all ();
        }
-
+       
        if (update_ghost_regions) {
                for (std::vector<GhostRegion*>::iterator i = ghosts.begin(); i != ghosts.end(); ++i) {
                        MidiGhostRegion* gr = dynamic_cast<MidiGhostRegion*> (*i);
@@ -1652,19 +1694,18 @@ MidiRegionView::update_note (CanvasNote* ev, bool update_ghost_regions)
        }
 }
 
-double
-MidiRegionView::update_hit (CanvasHit* ev)
+void
+MidiRegionView::update_hit (Hit* ev)
 {
        boost::shared_ptr<NoteType> note = ev->note();
 
        const framepos_t note_start_frames = source_beats_to_region_frames(note->time());
-       const double x = trackview.editor().frame_to_pixel(note_start_frames);
-       const double diamond_size = midi_stream_view()->note_height() / 2.0;
-       const double y = midi_stream_view()->note_to_y(note->note()) + ((diamond_size-2) / 4.0);
+       const double x = trackview.editor().sample_to_pixel(note_start_frames);
+       const double diamond_size = std::max(1., floor(midi_stream_view()->note_height()) - 2.);
+       const double y = 1.5 + floor(midi_stream_view()->note_to_y(note->note())) + diamond_size * .5;
 
-       ev->move_to (x, y);
-
-       return diamond_size;
+       ev->set_position (ArdourCanvas::Duple (x, y));
+       ev->set_height (diamond_size);
 }
 
 /** Add a MIDI note to the view (with length).
@@ -1676,16 +1717,11 @@ MidiRegionView::update_hit (CanvasHit* ev)
 void
 MidiRegionView::add_note(const boost::shared_ptr<NoteType> note, bool visible)
 {
-       CanvasNoteEvent* event = 0;
-
-       assert(note->time() >= 0);
-       assert(midi_view()->note_mode() == Sustained || midi_view()->note_mode() == Percussive);
-
-       //ArdourCanvas::Group* const group = (ArdourCanvas::Group*) get_canvas_group();
+       NoteBase* event = 0;
 
        if (midi_view()->note_mode() == Sustained) {
 
-               CanvasNote* ev_rect = new CanvasNote(*this, *_note_group, note);
+               Note* ev_rect = new Note (*this, _note_group, note);
 
                update_note (ev_rect);
 
@@ -1701,9 +1737,9 @@ MidiRegionView::add_note(const boost::shared_ptr<NoteType> note, bool visible)
 
        } else if (midi_view()->note_mode() == Percussive) {
 
-               const double diamond_size = midi_stream_view()->note_height() / 2.0;
+               const double diamond_size = std::max(1., floor(midi_stream_view()->note_height()) - 2.);
 
-               CanvasHit* ev_diamond = new CanvasHit (*this, *_note_group, diamond_size, note);
+               Hit* ev_diamond = new Hit (*this, _note_group, diamond_size, note);
 
                update_hit (ev_diamond);
 
@@ -1722,7 +1758,7 @@ MidiRegionView::add_note(const boost::shared_ptr<NoteType> note, bool visible)
                        event->show_velocity();
                }
 
-               event->on_channel_selection_change(_last_channel_selection);
+               event->on_channel_selection_change (get_selected_channels());
                _events.push_back(event);
 
                if (visible) {
@@ -1780,30 +1816,35 @@ MidiRegionView::step_sustain (Evoral::MusicalTime beats)
  * @param active_channel true to display the flag as on an active channel, false to grey it out for an inactive channel.
  */
 void
-MidiRegionView::add_canvas_patch_change (MidiModel::PatchChangePtr patch, const string& displaytext, bool active_channel)
+MidiRegionView::add_canvas_patch_change (MidiModel::PatchChangePtr patch, const string& displaytext, bool /*active_channel*/)
 {
-       assert (patch->time() >= 0);
-
        framecnt_t region_frames = source_beats_to_region_frames (patch->time());
-       const double x = trackview.editor().frame_to_pixel (region_frames);
+       const double x = trackview.editor().sample_to_pixel (region_frames);
 
        double const height = midi_stream_view()->contents_height();
 
-       boost::shared_ptr<CanvasPatchChange> patch_change = boost::shared_ptr<CanvasPatchChange>(
-               new CanvasPatchChange(*this, *_note_group,
-                                     displaytext,
-                                     height,
-                                     x, 1.0,
-                                     instrument_info(),
-                                     patch,
-                                     active_channel)
-                         );
-
-       // Show unless patch change is beyond the region bounds
-       if (region_frames < 0 || region_frames >= _region->length()) {
-               patch_change->hide();
+       // CAIROCANVAS: active_channel info removed from PatcChange constructor
+       // so we need to do something more sophisticated to keep its color
+       // appearance (MidiPatchChangeFill/MidiPatchChangeInactiveChannelFill)
+       // up to date.
+
+       boost::shared_ptr<PatchChange> patch_change = boost::shared_ptr<PatchChange>(
+               new PatchChange(*this, group,
+                               displaytext,
+                               height,
+                               x, 1.0,
+                               instrument_info(),
+                               patch));
+
+       if (patch_change->item().width() < _pixel_width) {
+               // Show unless patch change is beyond the region bounds
+               if (region_frames < 0 || region_frames >= _region->length()) {
+                       patch_change->hide();
+               } else {
+                       patch_change->show();
+               }
        } else {
-               patch_change->show();
+               patch_change->hide ();
        }
 
        _patch_changes.push_back (patch_change);
@@ -1815,26 +1856,41 @@ MidiRegionView::patch_change_to_patch_key (MidiModel::PatchChangePtr p)
        return MIDI::Name::PatchPrimaryKey (p->program(), p->bank());
 }
 
+/// Return true iff @p pc applies to the given time on the given channel.
+static bool
+patch_applies (const ARDOUR::MidiModel::constPatchChangePtr pc, Evoral::MusicalTime time, uint8_t channel)
+{
+       return pc->time() <= time && pc->channel() == channel;
+}
+       
 void 
-MidiRegionView::get_patch_key_at (double time, uint8_t channel, MIDI::Name::PatchPrimaryKey& key)
+MidiRegionView::get_patch_key_at (Evoral::MusicalTime time, uint8_t channel, MIDI::Name::PatchPrimaryKey& key) const
 {
+       // The earliest event not before time
        MidiModel::PatchChanges::iterator i = _model->patch_change_lower_bound (time);
-       while (i != _model->patch_changes().end() && (*i)->channel() != channel) {
-               ++i;
+
+       // Go backwards until we find the latest PC for this channel, or the start
+       while (i != _model->patch_changes().begin() &&
+              (i == _model->patch_changes().end() ||
+               !patch_applies(*i, time, channel))) {
+               --i;
        }
 
-       if (i != _model->patch_changes().end()) {
-               key.bank_number = (*i)->bank();
+       if (i != _model->patch_changes().end() && patch_applies(*i, time, channel)) {
+               key.bank_number    = (*i)->bank();
                key.program_number = (*i)->program ();
        } else {
                key.bank_number = key.program_number = 0;
        }
 
-       assert (key.is_sane());
+       if (!key.is_sane()) {
+               error << string_compose(_("insane MIDI patch key %1:%2"),
+                                       key.bank_number, key.program_number) << endmsg;
+       }
 }
 
 void
-MidiRegionView::change_patch_change (CanvasPatchChange& pc, const MIDI::Name::PatchPrimaryKey& new_patch)
+MidiRegionView::change_patch_change (PatchChange& pc, const MIDI::Name::PatchPrimaryKey& new_patch)
 {
        MidiModel::PatchChangeDiffCommand* c = _model->new_patch_change_diff_command (_("alter patch change"));
 
@@ -1906,7 +1962,7 @@ MidiRegionView::add_patch_change (framecnt_t t, Evoral::PatchChange<Evoral::Musi
 }
 
 void
-MidiRegionView::move_patch_change (CanvasPatchChange& pc, Evoral::MusicalTime t)
+MidiRegionView::move_patch_change (PatchChange& pc, Evoral::MusicalTime t)
 {
        MidiModel::PatchChangeDiffCommand* c = _model->new_patch_change_diff_command (_("move patch change"));
        c->change_time (pc.patch (), t);
@@ -1917,7 +1973,7 @@ MidiRegionView::move_patch_change (CanvasPatchChange& pc, Evoral::MusicalTime t)
 }
 
 void
-MidiRegionView::delete_patch_change (CanvasPatchChange* pc)
+MidiRegionView::delete_patch_change (PatchChange* pc)
 {
        MidiModel::PatchChangeDiffCommand* c = _model->new_patch_change_diff_command (_("delete patch change"));
        c->remove (pc->patch ());
@@ -1928,7 +1984,7 @@ MidiRegionView::delete_patch_change (CanvasPatchChange* pc)
 }
 
 void
-MidiRegionView::previous_patch (CanvasPatchChange& patch)
+MidiRegionView::previous_patch (PatchChange& patch)
 {
        if (patch.patch()->program() < 127) {
                MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
@@ -1938,7 +1994,7 @@ MidiRegionView::previous_patch (CanvasPatchChange& patch)
 }
 
 void
-MidiRegionView::next_patch (CanvasPatchChange& patch)
+MidiRegionView::next_patch (PatchChange& patch)
 {
        if (patch.patch()->program() > 0) {
                MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
@@ -1948,7 +2004,7 @@ MidiRegionView::next_patch (CanvasPatchChange& patch)
 }
 
 void
-MidiRegionView::previous_bank (CanvasPatchChange& patch)
+MidiRegionView::next_bank (PatchChange& patch)
 {
        if (patch.patch()->program() < 127) {
                MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
@@ -1960,7 +2016,7 @@ MidiRegionView::previous_bank (CanvasPatchChange& patch)
 }
 
 void
-MidiRegionView::next_bank (CanvasPatchChange& patch)
+MidiRegionView::previous_bank (PatchChange& patch)
 {
        if (patch.patch()->program() > 0) {
                MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
@@ -1972,7 +2028,7 @@ MidiRegionView::next_bank (CanvasPatchChange& patch)
 }
 
 void
-MidiRegionView::maybe_remove_deleted_note_from_selection (CanvasNoteEvent* cne)
+MidiRegionView::maybe_remove_deleted_note_from_selection (NoteBase* cne)
 {
        if (_selection.empty()) {
                return;
@@ -2012,7 +2068,7 @@ MidiRegionView::delete_note (boost::shared_ptr<NoteType> n)
 }
 
 void
-MidiRegionView::clear_selection_except (ArdourCanvas::CanvasNoteEvent* ev, bool signal)
+MidiRegionView::clear_selection_except (NoteBase* ev, bool signal)
 {
        for (Selection::iterator i = _selection.begin(); i != _selection.end(); ) {
                if ((*i) != ev) {
@@ -2029,6 +2085,12 @@ MidiRegionView::clear_selection_except (ArdourCanvas::CanvasNoteEvent* ev, bool
                }
        }
 
+       if (!ev && _entered) {
+               // Clearing selection entirely, ungrab keyboard
+               Keyboard::magic_widget_drop_focus();
+               _grabbed_keyboard = false;
+       }
+
        /* this does not change the status of this regionview w.r.t the editor
           selection.
        */
@@ -2039,8 +2101,10 @@ MidiRegionView::clear_selection_except (ArdourCanvas::CanvasNoteEvent* ev, bool
 }
 
 void
-MidiRegionView::unique_select(ArdourCanvas::CanvasNoteEvent* ev)
+MidiRegionView::unique_select(NoteBase* ev)
 {
+       const bool selection_was_empty = _selection.empty();
+
        clear_selection_except (ev);
 
        /* don't bother with checking to see if we should remove this
@@ -2051,6 +2115,11 @@ MidiRegionView::unique_select(ArdourCanvas::CanvasNoteEvent* ev)
 
        if (!ev->selected()) {
                add_to_selection (ev);
+               if (selection_was_empty && _entered) {
+                       // Grab keyboard for moving notes with arrow keys
+                       Keyboard::magic_widget_grab_focus();
+                       _grabbed_keyboard = true;
+               }
        }
 }
 
@@ -2092,32 +2161,39 @@ MidiRegionView::invert_selection ()
 void
 MidiRegionView::select_matching_notes (uint8_t notenum, uint16_t channel_mask, bool add, bool extend)
 {
+       bool have_selection = !_selection.empty();
        uint8_t low_note = 127;
        uint8_t high_note = 0;
        MidiModel::Notes& notes (_model->notes());
        _optimization_iterator = _events.begin();
+       
+       if (extend && !have_selection) {
+               extend = false;
+       }
 
+       /* scan existing selection to get note range */
+       
+       for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
+               if ((*i)->note()->note() < low_note) {
+                       low_note = (*i)->note()->note();
+               }
+               if ((*i)->note()->note() > high_note) {
+                       high_note = (*i)->note()->note();
+               }
+       }
+       
        if (!add) {
                clear_selection ();
-       }
 
-       if (extend && _selection.empty()) {
-               extend = false;
+               if (!extend && (low_note == high_note) && (high_note == notenum)) {
+                       /* only note previously selected is the one we are
+                        * reselecting. treat this as cancelling the selection.
+                        */
+                       return;
+               }
        }
 
        if (extend) {
-
-               /* scan existing selection to get note range */
-
-               for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
-                       if ((*i)->note()->note() < low_note) {
-                               low_note = (*i)->note()->note();
-                       }
-                       if ((*i)->note()->note() > high_note) {
-                               high_note = (*i)->note()->note();
-                       }
-               }
-
                low_note = min (low_note, notenum);
                high_note = max (high_note, notenum);
        }
@@ -2127,7 +2203,7 @@ MidiRegionView::select_matching_notes (uint8_t notenum, uint16_t channel_mask, b
        for (MidiModel::Notes::iterator n = notes.begin(); n != notes.end(); ++n) {
 
                boost::shared_ptr<NoteType> note (*n);
-               CanvasNoteEvent* cne;
+               NoteBase* cne;
                bool select = false;
 
                if (((1 << note->channel()) & channel_mask) != 0) {
@@ -2164,7 +2240,7 @@ MidiRegionView::toggle_matching_notes (uint8_t notenum, uint16_t channel_mask)
        for (MidiModel::Notes::iterator n = notes.begin(); n != notes.end(); ++n) {
 
                boost::shared_ptr<NoteType> note (*n);
-               CanvasNoteEvent* cne;
+               NoteBase* cne;
 
                if (note->note() == notenum && (((0x0001 << note->channel()) & channel_mask) != 0)) {
                        if ((cne = find_canvas_note (note)) != 0) {
@@ -2179,7 +2255,7 @@ MidiRegionView::toggle_matching_notes (uint8_t notenum, uint16_t channel_mask)
 }
 
 void
-MidiRegionView::note_selected (ArdourCanvas::CanvasNoteEvent* ev, bool add, bool extend)
+MidiRegionView::note_selected (NoteBase* ev, bool add, bool extend)
 {
        if (!add) {
                clear_selection_except (ev);
@@ -2199,7 +2275,7 @@ MidiRegionView::note_selected (ArdourCanvas::CanvasNoteEvent* ev, bool add, bool
                /* find end of latest note selected, select all between that and the start of "ev" */
 
                Evoral::MusicalTime earliest = Evoral::MaxMusicalTime;
-               Evoral::MusicalTime latest = 0;
+               Evoral::MusicalTime latest   = Evoral::MusicalTime();
 
                for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
                        if ((*i)->note()->end_time() > latest) {
@@ -2232,54 +2308,57 @@ MidiRegionView::note_selected (ArdourCanvas::CanvasNoteEvent* ev, bool add, bool
 }
 
 void
-MidiRegionView::note_deselected(ArdourCanvas::CanvasNoteEvent* ev)
+MidiRegionView::note_deselected(NoteBase* ev)
 {
        remove_from_selection (ev);
 }
 
 void
-MidiRegionView::update_drag_selection(double x1, double x2, double y1, double y2, bool extend)
+MidiRegionView::update_drag_selection(framepos_t start, framepos_t end, double gy0, double gy1, bool extend)
 {
-       if (x1 > x2) {
-               swap (x1, x2);
-       }
+       PublicEditor& editor = trackview.editor();
 
-       if (y1 > y2) {
-               swap (y1, y2);
-       }
+       // Convert to local coordinates
+       const framepos_t p  = _region->position();
+       const double     y  = midi_view()->y_position();
+       const double     x0 = editor.sample_to_pixel(max((framepos_t)0, start - p));
+       const double     x1 = editor.sample_to_pixel(max((framepos_t)0, end - p));
+       const double     y0 = max(0.0, gy0 - y);
+       const double     y1 = max(0.0, gy1 - y);
 
        // TODO: Make this faster by storing the last updated selection rect, and only
        // adjusting things that are in the area that appears/disappeared.
        // We probably need a tree to be able to find events in O(log(n)) time.
 
        for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
-
-               /* check if any corner of the note is inside the rect
-
-                  Notes:
-                  1) this is computing "touched by", not "contained by" the rect.
-                  2) this does not require that events be sorted in time.
-               */
-
-               const double ix1 = (*i)->x1();
-               const double ix2 = (*i)->x2();
-               const double iy1 = (*i)->y1();
-               const double iy2 = (*i)->y2();
-
-               if ((ix1 >= x1 && ix1 <= x2 && iy1 >= y1 && iy1 <= y2) ||
-                   (ix1 >= x1 && ix1 <= x2 && iy2 >= y1 && iy2 <= y2) ||
-                   (ix2 >= x1 && ix2 <= x2 && iy1 >= y1 && iy1 <= y2) ||
-                   (ix2 >= x1 && ix2 <= x2 && iy2 >= y1 && iy2 <= y2)) {
-
-                       // Inside rectangle
+               if ((*i)->x0() < x1 && (*i)->x1() > x0 && (*i)->y0() < y1 && (*i)->y1() > y0) {
+                       // Rectangles intersect
                        if (!(*i)->selected()) {
                                add_to_selection (*i);
                        }
                } else if ((*i)->selected() && !extend) {
-                       // Not inside rectangle
+                       // Rectangles do not intersect
                        remove_from_selection (*i);
                }
        }
+
+       typedef RouteTimeAxisView::AutomationTracks ATracks;
+       typedef std::list<Selectable*>              Selectables;
+
+       /* Add control points to selection. */
+       const ATracks& atracks = midi_view()->automation_tracks();
+       Selectables    selectables;
+       editor.get_selection().clear_points();
+       for (ATracks::const_iterator a = atracks.begin(); a != atracks.end(); ++a) {
+               a->second->get_selectables(start, end, gy0, gy1, selectables);
+               for (Selectables::const_iterator s = selectables.begin(); s != selectables.end(); ++s) {
+                       ControlPoint* cp = dynamic_cast<ControlPoint*>(*s);
+                       if (cp) {
+                               editor.get_selection().add(cp);
+                       }
+               }
+               a->second->set_selected_points(editor.get_selection().points);
+       }
 }
 
 void
@@ -2294,33 +2373,29 @@ MidiRegionView::update_vertical_drag_selection (double y1, double y2, bool exten
        // We probably need a tree to be able to find events in O(log(n)) time.
 
        for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
-
-               /* check if any corner of the note is inside the rect
-
-                  Notes:
-                  1) this is computing "touched by", not "contained by" the rect.
-                  2) this does not require that events be sorted in time.
-               */
-
                if (((*i)->y1() >= y1 && (*i)->y1() <= y2)) {
                        // within y- (note-) range
                        if (!(*i)->selected()) {
                                add_to_selection (*i);
                        }
                } else if ((*i)->selected() && !extend) {
-                       // Not inside rectangle
                        remove_from_selection (*i);
                }
        }
 }
 
 void
-MidiRegionView::remove_from_selection (CanvasNoteEvent* ev)
+MidiRegionView::remove_from_selection (NoteBase* ev)
 {
        Selection::iterator i = _selection.find (ev);
 
        if (i != _selection.end()) {
                _selection.erase (i);
+               if (_selection.empty() && _grabbed_keyboard) {
+                       // Ungrab keyboard
+                       Keyboard::magic_widget_drop_focus();
+                       _grabbed_keyboard = false;
+               }
        }
 
        ev->set_selected (false);
@@ -2333,20 +2408,21 @@ MidiRegionView::remove_from_selection (CanvasNoteEvent* ev)
 }
 
 void
-MidiRegionView::add_to_selection (CanvasNoteEvent* ev)
+MidiRegionView::add_to_selection (NoteBase* ev)
 {
-       bool add_mrv_selection = false;
-
-       if (_selection.empty()) {
-               add_mrv_selection = true;
-       }
+       const bool selection_was_empty = _selection.empty();
 
        if (_selection.insert (ev).second) {
                ev->set_selected (true);
                start_playing_midi_note ((ev)->note());
+               if (selection_was_empty && _entered) {
+                       // Grab keyboard for moving notes with arrow keys
+                       Keyboard::magic_widget_grab_focus();
+                       _grabbed_keyboard = true;
+               }
        }
 
-       if (add_mrv_selection) {
+       if (selection_was_empty) {
                PublicEditor& editor (trackview.editor());
                editor.get_selection().add (this);
        }
@@ -2366,7 +2442,7 @@ MidiRegionView::move_selection(double dx, double dy, double cumulative_dy)
        }
 
        for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
-               if (Evoral::musical_time_equal ((*i)->note()->time(), earliest)) {
+               if ((*i)->note()->time() == earliest) {
                        to_play.push_back ((*i)->note());
                }
                (*i)->move_event(dx, dy);
@@ -2396,13 +2472,11 @@ MidiRegionView::move_selection(double dx, double dy, double cumulative_dy)
 }
 
 void
-MidiRegionView::note_dropped(CanvasNoteEvent *, frameoffset_t dt, int8_t dnote)
+MidiRegionView::note_dropped(NoteBase *, frameoffset_t dt, int8_t dnote)
 {
-       assert (!_selection.empty());
-
        uint8_t lowest_note_in_selection  = 127;
        uint8_t highest_note_in_selection = 0;
-       uint8_t highest_note_difference = 0;
+       uint8_t highest_note_difference   = 0;
 
        // find highest and lowest notes first
 
@@ -2465,10 +2539,10 @@ MidiRegionView::note_dropped(CanvasNoteEvent *, frameoffset_t dt, int8_t dnote)
  *  @return Snapped frame relative to the region position.
  */
 framepos_t
-MidiRegionView::snap_pixel_to_frame(double x)
+MidiRegionView::snap_pixel_to_sample(double x)
 {
        PublicEditor& editor (trackview.editor());
-       return snap_frame_to_frame (editor.pixel_to_frame (x));
+       return snap_frame_to_frame (editor.pixel_to_sample (x));
 }
 
 /** @param x Pixel relative to the region position.
@@ -2477,25 +2551,25 @@ MidiRegionView::snap_pixel_to_frame(double x)
 double
 MidiRegionView::snap_to_pixel(double x)
 {
-       return (double) trackview.editor().frame_to_pixel(snap_pixel_to_frame(x));
+       return (double) trackview.editor().sample_to_pixel(snap_pixel_to_sample(x));
 }
 
 double
 MidiRegionView::get_position_pixels()
 {
        framepos_t region_frame = get_position();
-       return trackview.editor().frame_to_pixel(region_frame);
+       return trackview.editor().sample_to_pixel(region_frame);
 }
 
 double
 MidiRegionView::get_end_position_pixels()
 {
        framepos_t frame = get_position() + get_duration ();
-       return trackview.editor().frame_to_pixel(frame);
+       return trackview.editor().sample_to_pixel(frame);
 }
 
 framepos_t
-MidiRegionView::source_beats_to_absolute_frames(double beats) const
+MidiRegionView::source_beats_to_absolute_frames(Evoral::MusicalTime beats) const
 {
        /* the time converter will return the frame corresponding to `beats'
           relative to the start of the source. The start of the source
@@ -2505,7 +2579,7 @@ MidiRegionView::source_beats_to_absolute_frames(double beats) const
        return  source_start +  _source_relative_time_converter.to (beats);
 }
 
-double
+Evoral::MusicalTime
 MidiRegionView::absolute_frames_to_source_beats(framepos_t frames) const
 {
        /* the `frames' argument needs to be converted into a frame count
@@ -2517,12 +2591,12 @@ MidiRegionView::absolute_frames_to_source_beats(framepos_t frames) const
 }
 
 framepos_t
-MidiRegionView::region_beats_to_region_frames(double beats) const
+MidiRegionView::region_beats_to_region_frames(Evoral::MusicalTime beats) const
 {
        return _region_relative_time_converter.to(beats);
 }
 
-double
+Evoral::MusicalTime
 MidiRegionView::region_frames_to_region_beats(framepos_t frames) const
 {
        return _region_relative_time_converter.from(frames);
@@ -2534,33 +2608,33 @@ MidiRegionView::begin_resizing (bool /*at_front*/)
        _resize_data.clear();
 
        for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
-               CanvasNote *note = dynamic_cast<CanvasNote *> (*i);
+               Note *note = dynamic_cast<Note*> (*i);
 
                // only insert CanvasNotes into the map
                if (note) {
                        NoteResizeData *resize_data = new NoteResizeData();
-                       resize_data->canvas_note = note;
+                       resize_data->note = note;
 
                        // create a new SimpleRect from the note which will be the resize preview
-                       SimpleRect *resize_rect = new SimpleRect(
-                               *_note_group, note->x1(), note->y1(), note->x2(), note->y2());
+                       ArdourCanvas::Rectangle *resize_rect = new ArdourCanvas::Rectangle (_note_group, 
+                                                                                           ArdourCanvas::Rect (note->x0(), note->y0(), note->x0(), note->y1()));
 
                        // calculate the colors: get the color settings
                        uint32_t fill_color = UINT_RGBA_CHANGE_A(
-                               ARDOUR_UI::config()->canvasvar_MidiNoteSelected.get(),
+                               ARDOUR_UI::config()->color ("midi note selected"),
                                128);
 
                        // make the resize preview notes more transparent and bright
                        fill_color = UINT_INTERPOLATE(fill_color, 0xFFFFFF40, 0.5);
 
                        // calculate color based on note velocity
-                       resize_rect->property_fill_color_rgba() = UINT_INTERPOLATE(
-                               CanvasNoteEvent::meter_style_fill_color(note->note()->velocity(), note->selected()),
+                       resize_rect->set_fill_color (UINT_INTERPOLATE(
+                               NoteBase::meter_style_fill_color(note->note()->velocity(), note->selected()),
                                fill_color,
-                               0.85);
+                               0.85));
 
-                       resize_rect->property_outline_color_rgba() = CanvasNoteEvent::calculate_outline(
-                               ARDOUR_UI::config()->canvasvar_MidiNoteSelected.get());
+                       resize_rect->set_outline_color (NoteBase::calculate_outline (
+                                                               ARDOUR_UI::config()->color ("midi note selected")));
 
                        resize_data->resize_rect = resize_rect;
                        _resize_data.push_back(resize_data);
@@ -2578,62 +2652,64 @@ MidiRegionView::begin_resizing (bool /*at_front*/)
  * as the \a primary note.
  */
 void
-MidiRegionView::update_resizing (ArdourCanvas::CanvasNoteEvent* primary, bool at_front, double delta_x, bool relative)
+MidiRegionView::update_resizing (NoteBase* primary, bool at_front, double delta_x, bool relative)
 {
        bool cursor_set = false;
 
        for (std::vector<NoteResizeData *>::iterator i = _resize_data.begin(); i != _resize_data.end(); ++i) {
-               SimpleRect* resize_rect = (*i)->resize_rect;
-               CanvasNote* canvas_note = (*i)->canvas_note;
+               ArdourCanvas::Rectangle* resize_rect = (*i)->resize_rect;
+               Note* canvas_note = (*i)->note;
                double current_x;
 
                if (at_front) {
                        if (relative) {
-                               current_x = canvas_note->x1() + delta_x;
+                               current_x = canvas_note->x0() + delta_x;
                        } else {
-                               current_x = primary->x1() + delta_x;
+                               current_x = primary->x0() + delta_x;
                        }
                } else {
                        if (relative) {
-                               current_x = canvas_note->x2() + delta_x;
+                               current_x = canvas_note->x1() + delta_x;
                        } else {
-                               current_x = primary->x2() + delta_x;
+                               current_x = primary->x1() + delta_x;
                        }
                }
 
+               if (current_x < 0) {
+                       // This works even with snapping because RegionView::snap_frame_to_frame()
+                       // snaps forward if the snapped sample is before the beginning of the region
+                       current_x = 0;
+               }
+               if (current_x > trackview.editor().sample_to_pixel(_region->length())) {
+                       current_x = trackview.editor().sample_to_pixel(_region->length());
+               }
+
                if (at_front) {
-                       resize_rect->property_x1() = snap_to_pixel(current_x);
-                       resize_rect->property_x2() = canvas_note->x2();
+                       resize_rect->set_x0 (snap_to_pixel(current_x));
+                       resize_rect->set_x1 (canvas_note->x1());
                } else {
-                       resize_rect->property_x2() = snap_to_pixel(current_x);
-                       resize_rect->property_x1() = canvas_note->x1();
+                       resize_rect->set_x1 (snap_to_pixel(current_x));
+                       resize_rect->set_x0 (canvas_note->x0());
                }
 
                if (!cursor_set) {
-                       double beats;
-
-                       beats = snap_pixel_to_frame (current_x);
-                       beats = region_frames_to_region_beats (beats);
-
-                       double len;
+                       const double        snapped_x = snap_pixel_to_sample (current_x);
+                       Evoral::MusicalTime beats     = region_frames_to_region_beats (snapped_x);
+                       Evoral::MusicalTime len       = Evoral::MusicalTime();
 
                        if (at_front) {
                                if (beats < canvas_note->note()->end_time()) {
                                        len = canvas_note->note()->time() - beats;
                                        len += canvas_note->note()->length();
-                               } else {
-                                       len = 0;
                                }
                        } else {
                                if (beats >= canvas_note->note()->time()) {
                                        len = beats - canvas_note->note()->time();
-                               } else {
-                                       len = 0;
                                }
                        }
 
                        char buf[16];
-                       snprintf (buf, sizeof (buf), "%.3g beats", len);
+                       snprintf (buf, sizeof (buf), "%.3g beats", len.to_double());
                        show_verbose_cursor (buf, 0, 0);
 
                        cursor_set = true;
@@ -2647,13 +2723,13 @@ MidiRegionView::update_resizing (ArdourCanvas::CanvasNoteEvent* primary, bool at
  *  Parameters the same as for \a update_resizing().
  */
 void
-MidiRegionView::commit_resizing (ArdourCanvas::CanvasNoteEvent* primary, bool at_front, double delta_x, bool relative)
+MidiRegionView::commit_resizing (NoteBase* primary, bool at_front, double delta_x, bool relative)
 {
        start_note_diff_command (_("resize notes"));
 
        for (std::vector<NoteResizeData *>::iterator i = _resize_data.begin(); i != _resize_data.end(); ++i) {
-               CanvasNote*  canvas_note = (*i)->canvas_note;
-               SimpleRect*  resize_rect = (*i)->resize_rect;
+               Note*  canvas_note = (*i)->note;
+               ArdourCanvas::Rectangle*  resize_rect = (*i)->resize_rect;
 
                /* Get the new x position for this resize, which is in pixels relative
                 * to the region position.
@@ -2663,40 +2739,46 @@ MidiRegionView::commit_resizing (ArdourCanvas::CanvasNoteEvent* primary, bool at
 
                if (at_front) {
                        if (relative) {
-                               current_x = canvas_note->x1() + delta_x;
+                               current_x = canvas_note->x0() + delta_x;
                        } else {
-                               current_x = primary->x1() + delta_x;
+                               current_x = primary->x0() + delta_x;
                        }
                } else {
                        if (relative) {
-                               current_x = canvas_note->x2() + delta_x;
+                               current_x = canvas_note->x1() + delta_x;
                        } else {
-                               current_x = primary->x2() + delta_x;
+                               current_x = primary->x1() + delta_x;
                        }
                }
 
+               if (current_x < 0) {
+                       current_x = 0;
+               }
+               if (current_x > trackview.editor().sample_to_pixel(_region->length())) {
+                       current_x = trackview.editor().sample_to_pixel(_region->length());
+               }
+
                /* Convert that to a frame within the source */
-               current_x = snap_pixel_to_frame (current_x) + _region->start ();
+               current_x = snap_pixel_to_sample (current_x) + _region->start ();
 
                /* and then to beats */
-               current_x = region_frames_to_region_beats (current_x);
+               const Evoral::MusicalTime x_beats = region_frames_to_region_beats (current_x);
 
-               if (at_front && current_x < canvas_note->note()->end_time()) {
-                       note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::StartTime, current_x);
+               if (at_front && x_beats < canvas_note->note()->end_time()) {
+                       note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::StartTime, x_beats);
 
-                       double len = canvas_note->note()->time() - current_x;
+                       Evoral::MusicalTime len = canvas_note->note()->time() - x_beats;
                        len += canvas_note->note()->length();
 
-                       if (len > 0) {
-                               /* XXX convert to beats */
+                       if (!!len) {
                                note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::Length, len);
                        }
                }
 
                if (!at_front) {
-                       double len = current_x - canvas_note->note()->time();
+                       const Evoral::MusicalTime len = x_beats - canvas_note->note()->time();
 
-                       if (len > 0) {
+                       if (!!len) {
                                /* XXX convert to beats */
                                note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::Length, len);
                        }
@@ -2722,7 +2804,7 @@ MidiRegionView::abort_resizing ()
 }
 
 void
-MidiRegionView::change_note_velocity(CanvasNoteEvent* event, int8_t velocity, bool relative)
+MidiRegionView::change_note_velocity(NoteBase* event, int8_t velocity, bool relative)
 {
        uint8_t new_velocity;
 
@@ -2739,7 +2821,7 @@ MidiRegionView::change_note_velocity(CanvasNoteEvent* event, int8_t velocity, bo
 }
 
 void
-MidiRegionView::change_note_note (CanvasNoteEvent* event, int8_t note, bool relative)
+MidiRegionView::change_note_note (NoteBase* event, int8_t note, bool relative)
 {
        uint8_t new_note;
 
@@ -2754,12 +2836,12 @@ MidiRegionView::change_note_note (CanvasNoteEvent* event, int8_t note, bool rela
 }
 
 void
-MidiRegionView::trim_note (CanvasNoteEvent* event, Evoral::MusicalTime front_delta, Evoral::MusicalTime end_delta)
+MidiRegionView::trim_note (NoteBase* event, Evoral::MusicalTime front_delta, Evoral::MusicalTime end_delta)
 {
        bool change_start = false;
        bool change_length = false;
-       Evoral::MusicalTime new_start = 0;
-       Evoral::MusicalTime new_length = 0;
+       Evoral::MusicalTime new_start;
+       Evoral::MusicalTime new_length;
 
        /* NOTE: the semantics of the two delta arguments are slightly subtle:
 
@@ -2770,11 +2852,11 @@ MidiRegionView::trim_note (CanvasNoteEvent* event, Evoral::MusicalTime front_del
           if negative - move the end of the note earlier in time (shortening it)
        */
 
-       if (front_delta) {
+       if (!!front_delta) {
                if (front_delta < 0) {
 
                        if (event->note()->time() < -front_delta) {
-                               new_start = 0;
+                               new_start = Evoral::MusicalTime();
                        } else {
                                new_start = event->note()->time() + front_delta; // moves earlier
                        }
@@ -2802,7 +2884,7 @@ MidiRegionView::trim_note (CanvasNoteEvent* event, Evoral::MusicalTime front_del
 
        }
 
-       if (end_delta) {
+       if (!!end_delta) {
                bool can_change = true;
                if (end_delta < 0) {
                        if (event->note()->length() < -end_delta) {
@@ -2826,7 +2908,7 @@ MidiRegionView::trim_note (CanvasNoteEvent* event, Evoral::MusicalTime front_del
 }
 
 void
-MidiRegionView::change_note_channel (CanvasNoteEvent* event, int8_t chn, bool relative)
+MidiRegionView::change_note_channel (NoteBase* event, int8_t chn, bool relative)
 {
        uint8_t new_channel;
 
@@ -2848,14 +2930,14 @@ MidiRegionView::change_note_channel (CanvasNoteEvent* event, int8_t chn, bool re
 }
 
 void
-MidiRegionView::change_note_time (CanvasNoteEvent* event, Evoral::MusicalTime delta, bool relative)
+MidiRegionView::change_note_time (NoteBase* event, Evoral::MusicalTime delta, bool relative)
 {
        Evoral::MusicalTime new_time;
 
        if (relative) {
                if (delta < 0.0) {
                        if (event->note()->time() < -delta) {
-                               new_time = 0;
+                               new_time = Evoral::MusicalTime();
                        } else {
                                new_time = event->note()->time() + delta;
                        }
@@ -2870,7 +2952,7 @@ MidiRegionView::change_note_time (CanvasNoteEvent* event, Evoral::MusicalTime de
 }
 
 void
-MidiRegionView::change_note_length (CanvasNoteEvent* event, Evoral::MusicalTime t)
+MidiRegionView::change_note_length (NoteBase* event, Evoral::MusicalTime t)
 {
        note_diff_add_change (event, MidiModel::NoteDiffCommand::Length, t);
 }
@@ -2879,7 +2961,7 @@ void
 MidiRegionView::change_velocities (bool up, bool fine, bool allow_smush, bool all_together)
 {
        int8_t delta;
-       int8_t value;
+       int8_t value = 0;
 
        if (_selection.empty()) {
                return;
@@ -2897,8 +2979,8 @@ MidiRegionView::change_velocities (bool up, bool fine, bool allow_smush, bool al
 
        if (!allow_smush) {
                for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
-                       if ((*i)->note()->velocity() + delta == 0 || (*i)->note()->velocity() + delta == 127) {
-                               return;
+                       if ((*i)->note()->velocity() < -delta || (*i)->note()->velocity() + delta > 127) {
+                               goto cursor_label;
                        }
                }
        }
@@ -2926,6 +3008,7 @@ MidiRegionView::change_velocities (bool up, bool fine, bool allow_smush, bool al
 
        apply_diff();
 
+  cursor_label:
        if (!_selection.empty()) {
                char buf[24];
                snprintf (buf, sizeof (buf), "Vel %d",
@@ -2983,18 +3066,12 @@ MidiRegionView::transpose (bool up, bool fine, bool allow_smush)
 void
 MidiRegionView::change_note_lengths (bool fine, bool shorter, Evoral::MusicalTime delta, bool start, bool end)
 {
-       if (delta == 0.0) {
+       if (!delta) {
                if (fine) {
-                       delta = 1.0/128.0;
+                       delta = Evoral::MusicalTime(1.0/128.0);
                } else {
                        /* grab the current grid distance */
-                       bool success;
-                       delta = trackview.editor().get_grid_type_as_beats (success, _region->position());
-                       if (!success) {
-                               /* XXX cannot get grid type as beats ... should always be possible ... FIX ME */
-                               error << string_compose (_("programming error: %1"), "Grid type not available as beats - TO BE FIXED") << endmsg;
-                               return;
-                       }
+                       delta = get_grid_beats(_region->position());
                }
        }
 
@@ -3010,7 +3087,9 @@ MidiRegionView::change_note_lengths (bool fine, bool shorter, Evoral::MusicalTim
 
                /* note the negation of the delta for start */
 
-               trim_note (*i, (start ? -delta : 0), (end ? delta : 0));
+               trim_note (*i,
+                          (start ? -delta : Evoral::MusicalTime()),
+                          (end   ? delta  : Evoral::MusicalTime()));
                i = next;
        }
 
@@ -3019,7 +3098,7 @@ MidiRegionView::change_note_lengths (bool fine, bool shorter, Evoral::MusicalTim
 }
 
 void
-MidiRegionView::nudge_notes (bool forward)
+MidiRegionView::nudge_notes (bool forward, bool fine)
 {
        if (_selection.empty()) {
                return;
@@ -3030,15 +3109,21 @@ MidiRegionView::nudge_notes (bool forward)
           into a vector and sort before using the first one.
        */
 
-       framepos_t ref_point = source_beats_to_absolute_frames ((*(_selection.begin()))->note()->time());
-       framepos_t unused;
-       framecnt_t distance;
+       const framepos_t    ref_point = source_beats_to_absolute_frames ((*(_selection.begin()))->note()->time());
+       Evoral::MusicalTime delta;
+
+       if (!fine) {
 
-       if (trackview.editor().snap_mode() == Editing::SnapOff) {
+               /* non-fine, move by 1 bar regardless of snap */
+               delta = Evoral::MusicalTime(trackview.session()->tempo_map().meter_at(ref_point).divisions_per_bar());
+
+       } else if (trackview.editor().snap_mode() == Editing::SnapOff) {
 
                /* grid is off - use nudge distance */
 
-               distance = trackview.editor().get_nudge_distance (ref_point, unused);
+               framepos_t       unused;
+               const framecnt_t distance = trackview.editor().get_nudge_distance (ref_point, unused);
+               delta = region_frames_to_region_beats (fabs ((double)distance));
 
        } else {
 
@@ -3057,16 +3142,15 @@ MidiRegionView::nudge_notes (bool forward)
                        next_pos -= 1;
                }
 
-               trackview.editor().snap_to (next_pos, (forward ? 1 : -1), false);
-               distance = ref_point - next_pos;
+               trackview.editor().snap_to (next_pos, (forward ? RoundUpAlways : RoundDownAlways), false);
+               const framecnt_t distance = ref_point - next_pos;
+               delta = region_frames_to_region_beats (fabs ((double)distance));
        }
 
-       if (distance == 0) {
+       if (!delta) {
                return;
        }
 
-       Evoral::MusicalTime delta = region_frames_to_region_beats (fabs (distance));
-
        if (!forward) {
                delta = -delta;
        }
@@ -3096,11 +3180,11 @@ MidiRegionView::change_channel(uint8_t channel)
 
 
 void
-MidiRegionView::note_entered(ArdourCanvas::CanvasNoteEvent* ev)
+MidiRegionView::note_entered(NoteBase* ev)
 {
        Editor* editor = dynamic_cast<Editor*>(&trackview.editor());
 
-       pre_enter_cursor = editor->get_canvas_cursor ();
+       pre_note_enter_cursor = editor->get_canvas_cursor ();
 
        if (_mouse_state == SelectTouchDragging) {
                note_selected (ev, true);
@@ -3110,7 +3194,7 @@ MidiRegionView::note_entered(ArdourCanvas::CanvasNoteEvent* ev)
 }
 
 void
-MidiRegionView::note_left (ArdourCanvas::CanvasNoteEvent*)
+MidiRegionView::note_left (NoteBase*)
 {
        Editor* editor = dynamic_cast<Editor*>(&trackview.editor());
 
@@ -3120,25 +3204,51 @@ MidiRegionView::note_left (ArdourCanvas::CanvasNoteEvent*)
 
        editor->verbose_cursor()->hide ();
 
-       if (pre_enter_cursor) {
-               editor->set_canvas_cursor (pre_enter_cursor);
-               pre_enter_cursor = 0;
+       if (pre_note_enter_cursor) {
+               editor->set_canvas_cursor (pre_note_enter_cursor);
+               pre_note_enter_cursor = 0;
        }
 }
 
 void
-MidiRegionView::patch_entered (ArdourCanvas::CanvasPatchChange* ev)
+MidiRegionView::patch_entered (PatchChange* p)
 {
        ostringstream s;
        /* XXX should get patch name if we can */
-       s << _("Bank:") << (ev->patch()->bank() + MIDI_BP_ZERO) << '\n' << _("Program:") << ((int) ev->patch()->program()) + MIDI_BP_ZERO << '\n' << _("Channel:") << ((int) ev->patch()->channel() + 1);
+       s << _("Bank ") << (p->patch()->bank() + MIDI_BP_ZERO) << '\n' 
+         << _("Program ") << ((int) p->patch()->program()) + MIDI_BP_ZERO << '\n' 
+         << _("Channel ") << ((int) p->patch()->channel() + 1);
        show_verbose_cursor (s.str(), 10, 20);
+       p->item().grab_focus();
 }
 
 void
-MidiRegionView::patch_left (ArdourCanvas::CanvasPatchChange *)
+MidiRegionView::patch_left (PatchChange *)
 {
        trackview.editor().verbose_cursor()->hide ();
+       /* focus will transfer back via the enter-notify event sent to this
+        * midi region view.
+        */
+}
+
+void
+MidiRegionView::sysex_entered (SysEx* p)
+{
+       ostringstream s;
+       // CAIROCANVAS
+       // need a way to extract text from p->_flag->_text
+       // s << p->text();
+       // show_verbose_cursor (s.str(), 10, 20);
+       p->item().grab_focus();
+}
+
+void
+MidiRegionView::sysex_left (SysEx *)
+{
+       trackview.editor().verbose_cursor()->hide ();
+       /* focus will transfer back via the enter-notify event sent to this
+        * midi region view.
+        */
 }
 
 void
@@ -3148,13 +3258,13 @@ MidiRegionView::note_mouse_position (float x_fraction, float /*y_fraction*/, boo
        Editing::MouseMode mm = editor->current_mouse_mode();
        bool trimmable = (mm == MouseObject || mm == MouseTimeFX || mm == MouseDraw);
 
-       if (trimmable && x_fraction > 0.0 && x_fraction < 0.2) {
-               editor->set_canvas_cursor (editor->cursors()->left_side_trim);
-       } else if (trimmable && x_fraction >= 0.8 && x_fraction < 1.0) {
-               editor->set_canvas_cursor (editor->cursors()->right_side_trim);
-       } else {
-               if (pre_enter_cursor && can_set_cursor) {
-                       editor->set_canvas_cursor (pre_enter_cursor);
+       if (can_set_cursor) {
+               if (trimmable && x_fraction > 0.0 && x_fraction < 0.2) {
+                       editor->set_canvas_cursor (editor->cursors()->left_side_trim);
+               } else if (trimmable && x_fraction >= 0.8 && x_fraction < 1.0) {
+                       editor->set_canvas_cursor (editor->cursors()->right_side_trim);
+               } else if (pre_note_enter_cursor) {
+                       editor->set_canvas_cursor (pre_note_enter_cursor);
                }
        }
 }
@@ -3171,34 +3281,36 @@ MidiRegionView::set_frame_color()
        }
 
        if (_selected) {
-               f = ARDOUR_UI::config()->canvasvar_SelectedFrameBase.get();
+               f = ARDOUR_UI::config()->color ("selected region base");
        } else if (high_enough_for_name) {
-               f= ARDOUR_UI::config()->canvasvar_MidiFrameBase.get();
+               f= ARDOUR_UI::config()->color ("midi frame base");
        } else {
                f = fill_color;
        }
 
        if (!rect_visible) {
-               f = UINT_RGBA_CHANGE_A (f, 0);
+               f = UINT_RGBA_CHANGE_A (f, 80);
        }
 
-       frame->property_fill_color_rgba() = f;
+       frame->set_fill_color (f);
 }
 
 void
-MidiRegionView::midi_channel_mode_changed(ChannelMode mode, uint16_t mask)
+MidiRegionView::midi_channel_mode_changed ()
 {
+       MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
+       uint16_t mask = mtv->midi_track()->get_playback_channel_mask();
+       ChannelMode mode = mtv->midi_track()->get_playback_channel_mode ();
+
        if (mode == ForceChannel) {
                mask = 0xFFFF; // Show all notes as active (below)
        }
 
        // Update notes for selection
        for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
-               (*i)->on_channel_selection_change(mask);
+               (*i)->on_channel_selection_change (mask);
        }
 
-       _last_channel_selection = mask;
-
        _patch_changes.clear ();
        display_patch_changes ();
 }
@@ -3255,7 +3367,7 @@ MidiRegionView::selection_as_cut_buffer () const
 {
        Notes notes;
 
-       for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
+       for (Selection::const_iterator i = _selection.begin(); i != _selection.end(); ++i) {
                NoteType* n = (*i)->note().get();
                notes.insert (boost::shared_ptr<NoteType> (new NoteType (*n)));
        }
@@ -3267,34 +3379,54 @@ MidiRegionView::selection_as_cut_buffer () const
 }
 
 /** This method handles undo */
-void
-MidiRegionView::paste (framepos_t pos, float times, const MidiCutBuffer& mcb)
+bool
+MidiRegionView::paste (framepos_t pos, const ::Selection& selection, PasteContext& ctx)
 {
-       if (mcb.empty()) {
-               return;
+       trackview.session()->begin_reversible_command (Operations::paste);
+
+       // Paste notes, if available
+       MidiNoteSelection::const_iterator m = selection.midi_notes.get_nth(ctx.counts.n_notes());
+       if (m != selection.midi_notes.end()) {
+               ctx.counts.increase_n_notes();
+               paste_internal(pos, ctx.count, ctx.times, **m);
        }
 
-       DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("MIDI paste @ %1 times %2\n", pos, times));
+       // Paste control points to automation children, if available
+       typedef RouteTimeAxisView::AutomationTracks ATracks;
+       const ATracks& atracks = midi_view()->automation_tracks();
+       for (ATracks::const_iterator a = atracks.begin(); a != atracks.end(); ++a) {
+               a->second->paste(pos, selection, ctx);
+       }
 
-       trackview.session()->begin_reversible_command (_("paste"));
+       trackview.session()->commit_reversible_command ();
 
-       start_note_diff_command (_("paste"));
+       return true;
+}
 
-       Evoral::MusicalTime beat_delta;
-       Evoral::MusicalTime paste_pos_beats;
-       Evoral::MusicalTime duration;
-       Evoral::MusicalTime end_point = 0;
+/** This method handles undo */
+void
+MidiRegionView::paste_internal (framepos_t pos, unsigned paste_count, float times, const MidiCutBuffer& mcb)
+{
+       if (mcb.empty()) {
+               return;
+       }
 
-       duration = (*mcb.notes().rbegin())->end_time() - (*mcb.notes().begin())->time();
-       paste_pos_beats = absolute_frames_to_source_beats (pos);
-       beat_delta = (*mcb.notes().begin())->time() - paste_pos_beats;
-       paste_pos_beats = 0;
+       start_note_diff_command (_("paste"));
 
-       DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("Paste data spans from %1 to %2 (%3) ; paste pos beats = %4 (based on %5 - %6 ; beat delta = %7\n",
-                                                      (*mcb.notes().begin())->time(),
-                                                      (*mcb.notes().rbegin())->end_time(),
+       const Evoral::MusicalTime snap_beats    = get_grid_beats(pos);
+       const Evoral::MusicalTime first_time    = (*mcb.notes().begin())->time();
+       const Evoral::MusicalTime last_time     = (*mcb.notes().rbegin())->end_time();
+       const Evoral::MusicalTime duration      = last_time - first_time;
+       const Evoral::MusicalTime snap_duration = duration.snap_to(snap_beats);
+       const Evoral::MusicalTime paste_offset  = snap_duration * paste_count;
+       const Evoral::MusicalTime pos_beats     = absolute_frames_to_source_beats(pos) + paste_offset;
+       Evoral::MusicalTime       end_point     = Evoral::MusicalTime();
+
+       DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("Paste data spans from %1 to %2 (%3) ; paste pos beats = %4 (based on %5 - %6)\n",
+                                                      first_time,
+                                                      last_time,
                                                       duration, pos, _region->position(),
-                                                      paste_pos_beats, beat_delta));
+                                                      pos_beats));
 
        clear_selection ();
 
@@ -3303,15 +3435,13 @@ MidiRegionView::paste (framepos_t pos, float times, const MidiCutBuffer& mcb)
                for (Notes::const_iterator i = mcb.notes().begin(); i != mcb.notes().end(); ++i) {
 
                        boost::shared_ptr<NoteType> copied_note (new NoteType (*((*i).get())));
-                       copied_note->set_time (paste_pos_beats + copied_note->time() - beat_delta);
+                       copied_note->set_time (pos_beats + copied_note->time() - first_time);
 
                        /* make all newly added notes selected */
 
                        note_diff_add_note (copied_note, true);
                        end_point = copied_note->end_time();
                }
-
-               paste_pos_beats += duration;
        }
 
        /* if we pasted past the current end of the region, extend the region */
@@ -3329,12 +3459,10 @@ MidiRegionView::paste (framepos_t pos, float times, const MidiCutBuffer& mcb)
        }
 
        apply_diff (true);
-
-       trackview.session()->commit_reversible_command ();
 }
 
 struct EventNoteTimeEarlyFirstComparator {
-       bool operator() (CanvasNoteEvent* a, CanvasNoteEvent* b) {
+       bool operator() (NoteBase* a, NoteBase* b) {
                return a->note()->time() < b->note()->time();
        }
 };
@@ -3364,7 +3492,7 @@ MidiRegionView::goto_next_note (bool add_to_selection)
        time_sort_events ();
 
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
-       uint16_t const channel_mask = mtv->channel_selector().get_selected_channels ();
+       uint16_t const channel_mask = mtv->midi_track()->get_playback_channel_mask();
 
        for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
                if ((*i)->selected()) {
@@ -3401,7 +3529,7 @@ MidiRegionView::goto_previous_note (bool add_to_selection)
        time_sort_events ();
 
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
-       uint16_t const channel_mask = mtv->channel_selector().get_selected_channels ();
+       uint16_t const channel_mask = mtv->midi_track()->get_playback_channel_mask ();
 
        for (Events::reverse_iterator i = _events.rbegin(); i != _events.rend(); ++i) {
                if ((*i)->selected()) {
@@ -3455,28 +3583,25 @@ MidiRegionView::update_ghost_note (double x, double y)
        _last_ghost_x = x;
        _last_ghost_y = y;
 
-       _note_group->w2i (x, y);
+       _note_group->canvas_to_item (x, y);
 
        PublicEditor& editor = trackview.editor ();
        
-       framepos_t const unsnapped_frame = editor.pixel_to_frame (x);
+       framepos_t const unsnapped_frame = editor.pixel_to_sample (x);
        framecnt_t grid_frames;
        framepos_t const f = snap_frame_to_grid_underneath (unsnapped_frame, grid_frames);
 
        /* use region_frames... because we are converting a delta within the region
        */
         
-       bool success;
-       double length = editor.get_grid_type_as_beats (success, unsnapped_frame);
-
-       if (!success) {
-               length = 1;
-       }
+       const Evoral::MusicalTime length = get_grid_beats(unsnapped_frame);
 
        /* note that this sets the time of the ghost note in beats relative to
           the start of the source; that is how all note times are stored.
        */
-       _ghost_note->note()->set_time (absolute_frames_to_source_beats (f + _region->position ()));
+       _ghost_note->note()->set_time (
+               std::max(Evoral::MusicalTime(),
+                        absolute_frames_to_source_beats (f + _region->position ())));
        _ghost_note->note()->set_length (length);
        _ghost_note->note()->set_note (midi_stream_view()->y_to_note (y));
        _ghost_note->note()->set_channel (mtv->get_channel_for_add ());
@@ -3493,8 +3618,10 @@ MidiRegionView::create_ghost_note (double x, double y)
        remove_ghost_note ();
 
        boost::shared_ptr<NoteType> g (new NoteType);
-       _ghost_note = new NoEventCanvasNote (*this, *_note_group, g);
-       _ghost_note->property_outline_color_rgba() = 0x000000aa;
+       _ghost_note = new Note (*this, _note_group, g);
+       _ghost_note->set_ignore_events (true);
+       _ghost_note->set_outline_color (0x000000aa);
+       if (x < 0) { x = 0; }
        update_ghost_note (x, y);
        _ghost_note->show ();
 
@@ -3504,6 +3631,13 @@ MidiRegionView::create_ghost_note (double x, double y)
        show_verbose_cursor (_ghost_note->note ());
 }
 
+void
+MidiRegionView::remove_ghost_note ()
+{
+       delete _ghost_note;
+       _ghost_note = 0;
+}
+
 void
 MidiRegionView::snap_changed ()
 {
@@ -3523,11 +3657,13 @@ MidiRegionView::drop_down_keys ()
 void
 MidiRegionView::maybe_select_by_position (GdkEventButton* ev, double /*x*/, double y)
 {
+       /* XXX: This is dead code.  What was it for? */
+
        double note = midi_stream_view()->y_to_note(y);
        Events e;
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
 
-       uint16_t chn_mask = mtv->channel_selector().get_selected_channels();
+       uint16_t chn_mask = mtv->midi_track()->get_playback_channel_mask();
 
        if (Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
                get_events (e, Evoral::Sequence<Evoral::MusicalTime>::PitchGreaterThanOrEqual, (uint8_t) floor (note), chn_mask);
@@ -3580,13 +3716,13 @@ void
 MidiRegionView::show_step_edit_cursor (Evoral::MusicalTime pos)
 {
        if (_step_edit_cursor == 0) {
-               ArdourCanvas::Group* const group = (ArdourCanvas::Group*)get_canvas_group();
+               ArdourCanvas::Item* const group = get_canvas_group();
 
-               _step_edit_cursor = new ArdourCanvas::SimpleRect (*group);
-               _step_edit_cursor->property_y1() = 0;
-               _step_edit_cursor->property_y2() = midi_stream_view()->contents_height();
-               _step_edit_cursor->property_fill_color_rgba() = RGBA_TO_UINT (45,0,0,90);
-               _step_edit_cursor->property_outline_color_rgba() = RGBA_TO_UINT (85,0,0,90);
+               _step_edit_cursor = new ArdourCanvas::Rectangle (group);
+               _step_edit_cursor->set_y0 (0);
+               _step_edit_cursor->set_y1 (midi_stream_view()->contents_height());
+               _step_edit_cursor->set_fill_color (RGBA_TO_UINT (45,0,0,90));
+               _step_edit_cursor->set_outline_color (RGBA_TO_UINT (85,0,0,90));
        }
 
        move_step_edit_cursor (pos);
@@ -3599,8 +3735,8 @@ MidiRegionView::move_step_edit_cursor (Evoral::MusicalTime pos)
        _step_edit_cursor_position = pos;
 
        if (_step_edit_cursor) {
-               double pixel = trackview.editor().frame_to_pixel (region_beats_to_region_frames (pos));
-               _step_edit_cursor->property_x1() = pixel;
+               double pixel = trackview.editor().sample_to_pixel (region_beats_to_region_frames (pos));
+               _step_edit_cursor->set_x0 (pixel);
                set_step_edit_cursor_width (_step_edit_cursor_width);
        }
 }
@@ -3619,7 +3755,7 @@ MidiRegionView::set_step_edit_cursor_width (Evoral::MusicalTime beats)
        _step_edit_cursor_width = beats;
 
        if (_step_edit_cursor) {
-               _step_edit_cursor->property_x2() = _step_edit_cursor->property_x1() + trackview.editor().frame_to_pixel (region_beats_to_region_frames (beats));
+               _step_edit_cursor->set_x1 (_step_edit_cursor->x0() + trackview.editor().sample_to_pixel (region_beats_to_region_frames (beats)));
        }
 }
 
@@ -3650,7 +3786,14 @@ MidiRegionView::data_recorded (boost::weak_ptr<MidiSource> w)
 
        for (MidiBuffer::iterator i = buf->begin(); i != buf->end(); ++i) {
                Evoral::MIDIEvent<MidiBuffer::TimeType> const ev (*i, false);
-               assert (ev.buffer ());
+
+               if (ev.is_channel_event()) {
+                       if (get_channel_mode() == FilterChannels) {
+                               if (((uint16_t(1) << ev.channel()) & get_selected_channels()) == 0) {
+                                       continue;
+                               }
+                       }
+               }
 
                /* ev.time() is in session frames, so (ev.time() - converter.origin_b()) is
                   frames from the start of the source, and so time_beats is in terms of the
@@ -3660,10 +3803,8 @@ MidiRegionView::data_recorded (boost::weak_ptr<MidiSource> w)
                Evoral::MusicalTime const time_beats = converter.from (ev.time () - converter.origin_b ());
 
                if (ev.type() == MIDI_CMD_NOTE_ON) {
-
                        boost::shared_ptr<NoteType> note (
-                               new NoteType (ev.channel(), time_beats, 0, ev.note(), ev.velocity())
-                                                         );
+                               new NoteType (ev.channel(), time_beats, Evoral::MusicalTime(), ev.note(), ev.velocity()));
 
                        add_note (note, true);
 
@@ -3690,15 +3831,15 @@ MidiRegionView::trim_front_starting ()
        /* Reparent the note group to the region view's parent, so that it doesn't change
           when the region view is trimmed.
        */
-       _temporary_note_group = new ArdourCanvas::Group (*group->property_parent ());
-       _temporary_note_group->move (group->property_x(), group->property_y());
-       _note_group->reparent (*_temporary_note_group);
+       _temporary_note_group = new ArdourCanvas::Container (group->parent ());
+       _temporary_note_group->move (group->position ());
+       _note_group->reparent (_temporary_note_group);
 }
 
 void
 MidiRegionView::trim_front_ending ()
 {
-       _note_group->reparent (*group);
+       _note_group->reparent (group);
        delete _temporary_note_group;
        _temporary_note_group = 0;
 
@@ -3709,51 +3850,75 @@ MidiRegionView::trim_front_ending ()
 }
 
 void
-MidiRegionView::edit_patch_change (ArdourCanvas::CanvasPatchChange* pc)
+MidiRegionView::edit_patch_change (PatchChange* pc)
 {
-       PatchChangeDialog d (&_source_relative_time_converter, trackview.session(), *pc->patch (), instrument_info(), Gtk::Stock::APPLY);
-       if (d.run () != Gtk::RESPONSE_ACCEPT) {
+       PatchChangeDialog d (&_source_relative_time_converter, trackview.session(), *pc->patch (), instrument_info(), Gtk::Stock::APPLY, true);
+
+       int response = d.run();
+
+       switch (response) {
+       case Gtk::RESPONSE_ACCEPT:
+               break;
+       case Gtk::RESPONSE_REJECT:
+               delete_patch_change (pc);
+               return;
+       default:
                return;
        }
 
        change_patch_change (pc->patch(), d.patch ());
 }
 
+void
+MidiRegionView::delete_sysex (SysEx* /*sysex*/)
+{
+       // CAIROCANVAS
+       // sysyex object doesn't have a pointer to a sysex event
+       // MidiModel::SysExDiffCommand* c = _model->new_sysex_diff_command (_("delete sysex"));
+       // c->remove (sysex->sysex());
+       // _model->apply_command (*trackview.session(), c);
+
+       //_sys_exes.clear ();
+       // display_sysexes();
+}
 
 void
 MidiRegionView::show_verbose_cursor (boost::shared_ptr<NoteType> n) const
 {
-       char buf[24];
-       snprintf (buf, sizeof (buf), "%s (%d) Chn %d\nVel %d",
-                 Evoral::midi_note_name (n->note()).c_str(),
+       using namespace MIDI::Name;
+
+       std::string name;
+
+       MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
+       if (mtv) {
+               boost::shared_ptr<MasterDeviceNames> device_names(mtv->get_device_names());
+               if (device_names) {
+                       MIDI::Name::PatchPrimaryKey patch_key;
+                       get_patch_key_at(n->time(), n->channel(), patch_key);
+                       name = device_names->note_name(mtv->gui_property(X_("midnam-custom-device-mode")),
+                                                      n->channel(),
+                                                      patch_key.bank_number,
+                                                      patch_key.program_number,
+                                                      n->note());
+               }
+       }
+
+       char buf[128];
+       snprintf (buf, sizeof (buf), "%d %s\nCh %d Vel %d",
                  (int) n->note (),
+                 name.empty() ? Evoral::midi_note_name (n->note()).c_str() : name.c_str(),
                  (int) n->channel() + 1,
                  (int) n->velocity());
 
-       show_verbose_cursor (buf, 10, 20);
+       show_verbose_cursor(buf, 10, 20);
 }
 
 void
 MidiRegionView::show_verbose_cursor (string const & text, double xoffset, double yoffset) const
 {
-       double wx, wy;
-
-       trackview.editor().get_pointer_position (wx, wy);
-
-       wx += xoffset;
-       wy += yoffset;
-
-       /* Flip the cursor above the mouse pointer if it would overlap the bottom of the canvas */
-
-       double x1, y1, x2, y2;
-       trackview.editor().verbose_cursor()->canvas_item()->get_bounds (x1, y1, x2, y2);
-
-       if ((wy + y2 - y1) > trackview.editor().canvas_height()) {
-               wy -= (y2 - y1) + 2 * yoffset;
-       }
-
-       trackview.editor().verbose_cursor()->set (text, wx, wy);
+       trackview.editor().verbose_cursor()->set (text);
        trackview.editor().verbose_cursor()->show ();
+       trackview.editor().verbose_cursor()->set_offset (ArdourCanvas::Duple (xoffset, yoffset));
 }
 
 /** @param p A session framepos.
@@ -3765,13 +3930,8 @@ MidiRegionView::snap_frame_to_grid_underneath (framepos_t p, framecnt_t& grid_fr
 {
        PublicEditor& editor = trackview.editor ();
        
-       bool success;
-       Evoral::MusicalTime grid_beats = editor.get_grid_type_as_beats (success, p);
+       const Evoral::MusicalTime grid_beats = get_grid_beats(p);
 
-       if (!success) {
-               grid_beats = 1;
-       }
-       
        grid_frames = region_beats_to_region_frames (grid_beats);
 
        /* Hack so that we always snap to the note that we are over, instead of snapping
@@ -3804,3 +3964,30 @@ MidiRegionView::note_button_release ()
        delete _note_player;
        _note_player = 0;
 }
+
+ChannelMode
+MidiRegionView::get_channel_mode () const
+{
+       RouteTimeAxisView* rtav = dynamic_cast<RouteTimeAxisView*> (&trackview);
+       return rtav->midi_track()->get_playback_channel_mode();
+}
+
+uint16_t
+MidiRegionView::get_selected_channels () const
+{
+       RouteTimeAxisView* rtav = dynamic_cast<RouteTimeAxisView*> (&trackview);
+       return rtav->midi_track()->get_playback_channel_mask();
+}
+
+
+Evoral::MusicalTime
+MidiRegionView::get_grid_beats(framepos_t pos) const
+{
+       PublicEditor&       editor  = trackview.editor();
+       bool                success = false;
+       Evoral::MusicalTime beats   = editor.get_grid_type_as_beats(success, pos);
+       if (!success) {
+               beats = Evoral::MusicalTime(1);
+       }
+       return beats;
+}