Fix gain inc/dec with multiple-selection spanning groups
[ardour.git] / gtk2_ardour / mixer_ui.cc
index b70ceef37db5e21be034c4e94717c9a6836c97a5..c775b9b2b9b4dc8b16d4bee92d6a9d276370ab92 100644 (file)
@@ -106,8 +106,8 @@ Mixer_UI::Mixer_UI ()
        , _plugin_selector (0)
        , _strip_width (UIConfiguration::instance().get_default_narrow_ms() ? Narrow : Wide)
        , ignore_reorder (false)
-        , _in_group_rebuild_or_clear (false)
-        , _route_deletion_in_progress (false)
+       , _in_group_rebuild_or_clear (false)
+       , _route_deletion_in_progress (false)
        , _maximised (false)
        , _show_mixer_list (true)
        , myactions (X_("mixer"))
@@ -280,33 +280,28 @@ Mixer_UI::Mixer_UI ()
        list_hpane.add (global_hpacker);
        list_hpane.set_child_minsize (list_vpacker, 1);
 
-
        XMLNode const * settings = ARDOUR_UI::instance()->mixer_settings();
        float fract;
 
-       {
-               LocaleGuard lg;
-
-               if (!settings || !settings->get_property ("mixer-rhs-pane1-pos", fract) || fract  > 1.0) {
-                       fract = 0.6f;
-               }
-               rhs_pane1.set_divider (0, fract);
+       if (!settings || !settings->get_property ("mixer-rhs-pane1-pos", fract) || fract > 1.0) {
+               fract = 0.6f;
+       }
+       rhs_pane1.set_divider (0, fract);
 
-               if (!settings || !settings->get_property ("mixer-rhs-pane2-pos", fract) || fract > 1.0) {
-                       fract = 0.7f;
-               }
-               rhs_pane2.set_divider (0, fract);
+       if (!settings || !settings->get_property ("mixer-rhs-pane2-pos", fract) || fract > 1.0) {
+               fract = 0.7f;
+       }
+       rhs_pane2.set_divider (0, fract);
 
-               if (!settings || !settings->get_property ("mixer-list-hpane-pos", fract) || fract > 1.0) {
-                       fract = 0.2f;
-               }
-               list_hpane.set_divider (0, fract);
+       if (!settings || !settings->get_property ("mixer-list-hpane-pos", fract) || fract > 1.0) {
+               fract = 0.2f;
+       }
+       list_hpane.set_divider (0, fract);
 
-               if (!settings || !settings->get_property ("mixer-inner-pane-pos", fract) || fract > 1.0) {
-                       fract = 0.8f;
-               }
-               inner_pane.set_divider (0, fract);
+       if (!settings || !settings->get_property ("mixer-inner-pane-pos", fract) || fract > 1.0) {
+               fract = 0.8f;
        }
+       inner_pane.set_divider (0, fract);
 
        rhs_pane1.set_drag_cursor (*PublicEditor::instance().cursors()->expand_up_down);
        rhs_pane2.set_drag_cursor (*PublicEditor::instance().cursors()->expand_up_down);
@@ -447,7 +442,7 @@ Mixer_UI::remove_master (VCAMasterStrip* vms)
 
        for (ri = rows.begin(); ri != rows.end(); ++ri) {
                if ((*ri)[stripable_columns.strip] == vms) {
-                        PBD::Unwinder<bool> uw (_route_deletion_in_progress, true);
+                       PBD::Unwinder<bool> uw (_route_deletion_in_progress, true);
                        track_model->erase (ri);
                        break;
                }
@@ -498,7 +493,7 @@ Mixer_UI::add_stripables (StripableList& slist)
        bool from_scratch = (track_model->children().size() == 0);
        uint32_t nroutes = 0;
 
-       slist.sort (StripablePresentationInfoSorter());
+       slist.sort (Stripable::Sorter());
 
        for (Gtk::TreeModel::Children::iterator it = track_model->children().begin(); it != track_model->children().end(); ++it) {
                boost::shared_ptr<Stripable> s = (*it)[stripable_columns.stripable];
@@ -509,6 +504,7 @@ Mixer_UI::add_stripables (StripableList& slist)
 
                nroutes++;
 
+               // XXX what does this special case do?
                if (s->presentation_info().order() == (slist.front()->presentation_info().order() + slist.size())) {
                        insert_iter = it;
                        break;
@@ -564,7 +560,11 @@ Mixer_UI::add_stripables (StripableList& slist)
                                        _monitor_section->tearoff().Detach.connect (sigc::mem_fun(*this, &Mixer_UI::monitor_section_detached));
                                        _monitor_section->tearoff().Attach.connect (sigc::mem_fun(*this, &Mixer_UI::monitor_section_attached));
 
-                                       monitor_section_attached ();
+                                       if (_monitor_section->tearoff().torn_off()) {
+                                               monitor_section_detached ();
+                                       } else {
+                                               monitor_section_attached ();
+                                       }
 
                                        route->DropReferences.connect (*this, invalidator(*this), boost::bind (&Mixer_UI::monitor_section_going_away, this), gui_context());
 
@@ -631,16 +631,6 @@ Mixer_UI::deselect_all_strip_processors ()
        }
 }
 
-void
-Mixer_UI::select_strip (MixerStrip& ms, bool add)
-{
-       if (add) {
-               _selection.add (&ms);
-       } else {
-               _selection.set (&ms);
-       }
-}
-
 void
 Mixer_UI::select_none ()
 {
@@ -673,9 +663,11 @@ Mixer_UI::remove_strip (MixerStrip* strip)
                strips.erase (i);
        }
 
+       PBD::Unwinder<bool> uwi (ignore_reorder, true);
+
        for (ri = rows.begin(); ri != rows.end(); ++ri) {
                if ((*ri)[stripable_columns.strip] == strip) {
-                        PBD::Unwinder<bool> uw (_route_deletion_in_progress, true);
+                       PBD::Unwinder<bool> uw (_route_deletion_in_progress, true);
                        track_model->erase (ri);
                        break;
                }
@@ -685,7 +677,9 @@ Mixer_UI::remove_strip (MixerStrip* strip)
 void
 Mixer_UI::presentation_info_changed (PropertyChange const & what_changed)
 {
-       _selection.presentation_info_changed (what_changed);
+       if (what_changed.contains (Properties::selected)) {
+               _selection.presentation_info_changed (what_changed);
+       }
 
        PropertyChange soh;
        soh.add (Properties::selected);
@@ -714,15 +708,9 @@ Mixer_UI::sync_presentation_info_from_treeview ()
 
        TreeModel::Children::iterator ri;
        bool change = false;
-       uint32_t order = 0;
 
-       OrderingKeys sorted;
-       const size_t cmp_max = rows.size ();
-
-       // special case master if it's got PI order 0 lets keep it there
-       if (_session->master_out() && (_session->master_out()->presentation_info().order() == 0)) {
-               order++;
-       }
+       PresentationInfo::order_t master_key = _session->master_order_key ();
+       PresentationInfo::order_t order = 0;
 
        PresentationInfo::ChangeSuspender cs;
 
@@ -730,65 +718,36 @@ Mixer_UI::sync_presentation_info_from_treeview ()
                bool visible = (*ri)[stripable_columns.visible];
                boost::shared_ptr<Stripable> stripable = (*ri)[stripable_columns.stripable];
 
+#ifndef NDEBUG // these should not exist in the mixer's treeview
                if (!stripable) {
+                       assert (0);
                        continue;
                }
-
-               /* Monitor and Auditioner do not get their presentation
-                * info reset here.
-                */
-
                if (stripable->is_monitor() || stripable->is_auditioner()) {
+                       assert (0);
                        continue;
                }
-
-               /* Master also doesn't get set here but since the editor allows
-                * it to be reordered, we need to preserve its ordering.
-                */
+               if (stripable->is_master()) {
+                       assert (0);
+                       continue;
+               }
+#endif
 
                stripable->presentation_info().set_hidden (!visible);
 
-               // master may not get set here, but if it is zero keep it there
-               if (stripable->is_master() && (stripable->presentation_info().order() == 0)) {
-                       continue;
+               // leave master where it is.
+               if (order == master_key) {
+                       ++order;
                }
 
                if (order != stripable->presentation_info().order()) {
                        stripable->set_presentation_order (order);
                        change = true;
                }
-
-               sorted.push_back (OrderKeys (order, stripable, cmp_max));
-
                ++order;
        }
 
-       if (!change) {
-               // VCA (and Mixbus) special cases according to SortByNewDisplayOrder
-               uint32_t n = 0;
-               SortByNewDisplayOrder cmp;
-               sort (sorted.begin(), sorted.end(), cmp);
-               for (OrderingKeys::iterator sr = sorted.begin(); sr != sorted.end(); ++sr, ++n) {
-                       if (_session->master_out() && (_session->master_out()->presentation_info().order() == n)) {
-                               ++n;
-                       }
-                       if (sr->old_display_order != n) {
-                               change = true;
-                               break;
-                       }
-               }
-               if (change) {
-                       n = 0;
-                       for (OrderingKeys::iterator sr = sorted.begin(); sr != sorted.end(); ++sr, ++n) {
-                               if (_session->master_out() && (_session->master_out()->presentation_info().order() == n)) {
-                                       ++n;
-                               }
-                               if (sr->stripable->presentation_info().order() != n) {
-                                       sr->stripable->set_presentation_order (n);
-                               }
-                       }
-               }
-       }
+       change |= _session->ensure_stripable_sort_order ();
 
        if (change) {
                DEBUG_TRACE (DEBUG::OrderKeys, "... notify PI change from mixer GUI\n");
@@ -819,22 +778,20 @@ Mixer_UI::sync_treeview_from_presentation_info (PropertyChange const & what_chan
                return;
        }
 
-       OrderingKeys sorted;
-       const size_t cmp_max = rows.size ();
-
+       TreeOrderKeys sorted;
        for (TreeModel::Children::iterator ri = rows.begin(); ri != rows.end(); ++ri, ++old_order) {
                boost::shared_ptr<Stripable> stripable = (*ri)[stripable_columns.stripable];
-               sorted.push_back (OrderKeys (old_order, stripable, cmp_max));
+               sorted.push_back (TreeOrderKey (old_order, stripable));
        }
 
-       SortByNewDisplayOrder cmp;
+       TreeOrderKeySorter cmp;
 
        sort (sorted.begin(), sorted.end(), cmp);
        neworder.assign (sorted.size(), 0);
 
        uint32_t n = 0;
 
-       for (OrderingKeys::iterator sr = sorted.begin(); sr != sorted.end(); ++sr, ++n) {
+       for (TreeOrderKeys::iterator sr = sorted.begin(); sr != sorted.end(); ++sr, ++n) {
 
                neworder[n] = sr->old_display_order;
 
@@ -918,6 +875,15 @@ Mixer_UI::axis_view_by_control (boost::shared_ptr<AutomationControl> c) const
        return 0;
 }
 
+struct MixerStripSorter {
+       bool operator() (const MixerStrip* ms_a, const MixerStrip* ms_b)
+       {
+               boost::shared_ptr<ARDOUR::Stripable> const& a = ms_a->stripable ();
+               boost::shared_ptr<ARDOUR::Stripable> const& b = ms_b->stripable ();
+               return ARDOUR::Stripable::Sorter(true)(a, b);
+       }
+};
+
 bool
 Mixer_UI::strip_button_release_event (GdkEventButton *ev, MixerStrip *strip)
 {
@@ -941,16 +907,10 @@ Mixer_UI::strip_button_release_event (GdkEventButton *ev, MixerStrip *strip)
                                bool accumulate = false;
                                bool found_another = false;
 
-                               OrderingKeys sorted;
-                               const size_t cmp_max = strips.size ();
-                               for (list<MixerStrip*>::iterator i = strips.begin(); i != strips.end(); ++i) {
-                                       sorted.push_back (OrderKeys (-1, (*i)->stripable(), cmp_max));
-                               }
-                               SortByNewDisplayOrder cmp;
-                               sort (sorted.begin(), sorted.end(), cmp);
+                               strips.sort (MixerStripSorter());
 
-                               for (OrderingKeys::iterator sr = sorted.begin(); sr != sorted.end(); ++sr) {
-                                       MixerStrip* ms = strip_by_stripable (sr->stripable);
+                               for (list<MixerStrip*>::iterator i = strips.begin(); i != strips.end(); ++i) {
+                                       MixerStrip* ms = *i;
                                        assert (ms);
 
                                        if (ms == strip) {
@@ -1172,15 +1132,15 @@ Mixer_UI::hide_strip (MixerStrip* ms)
 gint
 Mixer_UI::start_updating ()
 {
-    fast_screen_update_connection = Timers::super_rapid_connect (sigc::mem_fun(*this, &Mixer_UI::fast_update_strips));
-    return 0;
+       fast_screen_update_connection = Timers::super_rapid_connect (sigc::mem_fun(*this, &Mixer_UI::fast_update_strips));
+       return 0;
 }
 
 gint
 Mixer_UI::stop_updating ()
 {
-    fast_screen_update_connection.disconnect();
-    return 0;
+       fast_screen_update_connection.disconnect();
+       return 0;
 }
 
 void
@@ -1342,9 +1302,9 @@ Mixer_UI::track_list_delete (const Gtk::TreeModel::Path&)
        DEBUG_TRACE (DEBUG::OrderKeys, "mixer UI treeview row deleted\n");
        sync_presentation_info_from_treeview ();
 
-        if (_route_deletion_in_progress) {
-                redisplay_track_list ();
-        }
+       if (_route_deletion_in_progress) {
+               redisplay_track_list ();
+       }
 }
 
 void
@@ -1691,6 +1651,10 @@ Mixer_UI::stripable_property_changed (const PropertyChange& what_changed, boost:
                }
        }
 
+       if (s->is_master ()) {
+               return;
+       }
+
        error << _("track display list item for renamed strip not found!") << endmsg;
 }
 
@@ -2091,7 +2055,6 @@ private:
 int
 Mixer_UI::set_state (const XMLNode& node, int version)
 {
-       LocaleGuard lg;
        bool yn;
 
        Tabbable::set_state (node, version);
@@ -2126,6 +2089,14 @@ Mixer_UI::set_state (const XMLNode& node, int version)
                tact->set_active (yn);
        }
 
+       if (node.get_property ("monitor-section-visible", yn)) {
+               Glib::RefPtr<Action> act = ActionManager::get_action ("Common", "ToggleMonitorSection");
+               Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
+               /* do it twice to force the change */
+               tact->set_active (yn);
+               show_monitor_section (yn);
+       }
+
 
        XMLNode* plugin_order;
        if ((plugin_order = find_named_node (node, "PluginOrder")) != 0) {
@@ -2153,7 +2124,6 @@ XMLNode&
 Mixer_UI::get_state ()
 {
        XMLNode* node = new XMLNode (X_("Mixer"));
-       LocaleGuard lg;
 
        node->add_child_nocopy (Tabbable::get_state());
 
@@ -2167,6 +2137,11 @@ Mixer_UI::get_state ()
        node->set_property ("show-mixer-list", _show_mixer_list);
        node->set_property ("maximised", _maximised);
 
+       Glib::RefPtr<Action> act = ActionManager::get_action ("Common", "ToggleMonitorSection");
+       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
+       assert (tact);
+       node->set_property ("monitor-section-visible", tact->get_active ());
+
        store_current_favorite_order ();
        XMLNode* plugin_order = new XMLNode ("PluginOrder");
        uint32_t cnt = 0;
@@ -2276,10 +2251,6 @@ Mixer_UI::parameter_changed (string const & p)
                for (list<MixerStrip*>::iterator i = strips.begin(); i != strips.end(); ++i) {
                        (*i)->set_width_enum (s ? Narrow : Wide, this);
                }
-       } else if (p == "use-monitor-bus") {
-               if (_session && !_session->monitor_out()) {
-                       monitor_section_detached ();
-               }
        }
 }
 
@@ -2428,6 +2399,22 @@ void
 Mixer_UI::monitor_section_going_away ()
 {
        if (_monitor_section) {
+               XMLNode* ui_node = Config->extra_xml(X_("UI"));
+               /* immediate state save.
+                *
+                * Tearoff settings are otherwise only stored during
+                * save_ardour_state(). The mon-section may or may not
+                * exist at that point.
+                * */
+               if (ui_node) {
+                       XMLNode* tearoff_node = ui_node->child (X_("Tearoffs"));
+                       if (tearoff_node) {
+                               tearoff_node->remove_nodes_and_delete (X_("monitor-section"));
+                               XMLNode* t = new XMLNode (X_("monitor-section"));
+                               _monitor_section->tearoff().add_state (*t);
+                               tearoff_node->add_child_nocopy (*t);
+                       }
+               }
                monitor_section_detached ();
                out_packer.remove (_monitor_section->tearoff());
                _monitor_section->set_session (0);
@@ -2492,7 +2479,7 @@ Mixer_UI::monitor_section_attached ()
        Glib::RefPtr<Action> act = ActionManager::get_action ("Common", "ToggleMonitorSection");
        Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
        act->set_sensitive (true);
-       tact->set_active ();
+       show_monitor_section (tact->get_active ());
 }
 
 void
@@ -2996,29 +2983,44 @@ Mixer_UI::rec_enable_action ()
        control_action (&Stripable::rec_enable_control);
 }
 
-void
-Mixer_UI::step_gain_up_action ()
+AutomationControlSet
+Mixer_UI::selected_gaincontrols ()
 {
        set_axis_targets_for_operation ();
-
+       AutomationControlSet rv;
        BOOST_FOREACH(AxisView* r, _axis_targets) {
                MixerStrip* ms = dynamic_cast<MixerStrip*> (r);
                if (ms) {
-                       ms->step_gain_up ();
+                       boost::shared_ptr<GainControl> ac (ms->route()->gain_control());
+                       ControlList cl (ac->grouped_controls());
+                       for (ControlList::const_iterator c = cl.begin(); c != cl.end (); ++c) {
+                               rv.insert (*c);
+                       }
+                       rv.insert (ac);
                }
        }
+       return rv;
 }
 
 void
-Mixer_UI::step_gain_down_action ()
+Mixer_UI::step_gain_up_action ()
 {
-       set_axis_targets_for_operation ();
+       AutomationControlSet acs = selected_gaincontrols ();
+       for (AutomationControlSet::const_iterator i = acs.begin(); i != acs.end (); ++i) {
+               boost::shared_ptr<GainControl> ac = boost::dynamic_pointer_cast<GainControl> (*i);
+               assert (ac);
+               ac->set_value (dB_to_coefficient (accurate_coefficient_to_dB (ac->get_value()) + 0.1), Controllable::NoGroup);
+       }
+}
 
-       BOOST_FOREACH(AxisView* r, _axis_targets) {
-               MixerStrip* ms = dynamic_cast<MixerStrip*> (r);
-               if (ms) {
-                       ms->step_gain_down ();
-               }
+void
+Mixer_UI::step_gain_down_action ()
+{
+       AutomationControlSet acs = selected_gaincontrols ();
+       for (AutomationControlSet::const_iterator i = acs.begin(); i != acs.end (); ++i) {
+               boost::shared_ptr<GainControl> ac = boost::dynamic_pointer_cast<GainControl> (*i);
+               assert (ac);
+               ac->set_value (dB_to_coefficient (accurate_coefficient_to_dB (ac->get_value()) - 0.1), Controllable::NoGroup);
        }
 }