waf: fix concurrency issue with duplicate targets

[ardour.git] / gtk2_ardour / playlist_selector.cc

diff --git a/gtk2_ardour/playlist_selector.cc b/gtk2_ardour/playlist_selector.cc
index f81e199d625b69a7c60c588a67e7bcef845f1007..cdc144d1b7c7cde680a5acef4ad778da5d4c77ca 100644 (file)
--- a/gtk2_ardour/playlist_selector.cc
+++ b/gtk2_ardour/playlist_selector.cc
@@ -20,12 +20,10 @@
 
 #include <gtkmm/button.h>
 
-#include "ardour/session_playlist.h"
-#include "ardour/audio_diskstream.h"
-#include "ardour/playlist.h"
 #include "ardour/audio_track.h"
 #include "ardour/audioplaylist.h"
-#include "ardour/configuration.h"
+#include "ardour/playlist.h"
+#include "ardour/session_playlist.h"
 
 #include <gtkmm2ext/gtk_ui.h>
 
@@ -46,7 +44,6 @@ PlaylistSelector::PlaylistSelector ()
 {
        rui = 0;
 
-       set_position (WIN_POS_MOUSE);
        set_name ("PlaylistSelectorWindow");
        set_modal(true);
        add_events (Gdk::KEY_PRESS_MASK|Gdk::KEY_RELEASE_MASK);
@@ -64,7 +61,7 @@ PlaylistSelector::PlaylistSelector ()
 
        get_vbox()->pack_start (scroller);
 
-       Button* b = add_button (_("close"), RESPONSE_CANCEL);
+       Button* b = add_button (_("Close"), RESPONSE_CANCEL);
        b->signal_clicked().connect (sigc::mem_fun(*this, &PlaylistSelector::close_button_click));
 
 }
@@ -145,7 +142,8 @@ PlaylistSelector::show_for (RouteUI* ruix)
                }
 
                TreeModel::Row row;
-               TreeModel::Row* selected_row = 0;
+               TreeModel::Row selected_row;
+               bool have_selected = false;
                TreePath this_path;
 
                if (tr == this_track) {
@@ -173,12 +171,13 @@ PlaylistSelector::show_for (RouteUI* ruix)
                        child_row[columns.playlist] = *p;
 
                        if (*p == this_track->playlist()) {
-                               selected_row = &child_row;
+                               selected_row = child_row;
+                               have_selected = true;
                        }
                }
 
-               if (selected_row != 0) {
-                       tree.get_selection()->select (*selected_row);
+               if (have_selected) {
+                       tree.get_selection()->select (selected_row);
                }
        }
 
@@ -187,7 +186,8 @@ PlaylistSelector::show_for (RouteUI* ruix)
        _session->playlists->unassigned (unassigned);
 
        TreeModel::Row row;
-       TreeModel::Row* selected_row = 0;
+       TreeModel::Row selected_row;
+       bool have_selected = false;
        TreePath this_path;
 
        row = *(model->append (others.children()));
@@ -203,11 +203,12 @@ PlaylistSelector::show_for (RouteUI* ruix)
                child_row[columns.playlist] = *p;
 
                if (*p == this_track->playlist()) {
-                       selected_row = &child_row;
+                       selected_row = child_row;
+                       have_selected = true;
                }
 
-               if (selected_row != 0) {
-                       tree.get_selection()->select (*selected_row);
+               if (have_selected) {
+                       tree.get_selection()->select (selected_row);
                }
        }