Merge branch 'master' into windows
[ardour.git] / gtk2_ardour / tempo_lines.cc
index cab185026f997e177c2bb8c666daeca360893cbb..97aa662c38549779db1a67b9c38880c81a0469c8 100644 (file)
@@ -48,8 +48,9 @@ TempoLines::tempo_map_changed()
                ++next;
                i->second->property_x1() = - d;
                i->second->property_x2() = - d;
+               ArdourCanvas::SimpleLine* f = i->second;
                _lines.erase(i);
-               _lines.insert(make_pair(- d, i->second));
+               _lines.insert(make_pair(- d, f));
                i = next;
        }
 }
@@ -71,9 +72,11 @@ TempoLines::hide ()
 }
 
 void
-TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit)
+TempoLines::draw (const ARDOUR::TempoMap::BBTPointList::const_iterator& begin, 
+                 const ARDOUR::TempoMap::BBTPointList::const_iterator& end, 
+                 double frames_per_unit)
 {
-       ARDOUR::TempoMap::BBTPointList::iterator i;
+       ARDOUR::TempoMap::BBTPointList::const_iterator i;
        ArdourCanvas::SimpleLine *line = NULL;
        gdouble xpos;
        double who_cares;
@@ -83,16 +86,16 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
        uint32_t bars = 0;
        uint32_t color;
 
-       const size_t needed = points.size();
+       const size_t needed = distance (begin, end);
 
        _canvas.get_scroll_region (x1, y1, x2, who_cares);
 
        /* get the first bar spacing */
 
-       i = points.end();
+       i = end;
        i--;
-       bars = (*i).bar - (*points.begin()).bar;
-       beats = points.size() - bars;
+       bars = (*i).bar - (*begin).bar;
+       beats = distance (begin, end) - bars;
 
        beat_density = (beats * 10.0f) / _canvas.get_width ();
 
@@ -105,7 +108,7 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
        xpos = rint(((framepos_t)(*i).frame) / (double)frames_per_unit);
        const double needed_right = xpos;
 
-       i = points.begin();
+       i = begin;
 
        xpos = rint(((framepos_t)(*i).frame) / (double)frames_per_unit);
        const double needed_left = xpos;
@@ -120,18 +123,17 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
        // Tempo map hasn't changed and we're entirely within a clean
        // range, don't need to do anything.  Yay.
        if (needed_left >= _clean_left && needed_right <= _clean_right) {
-               //cout << endl << "*** LINE CACHE PERFECT HIT" << endl;
+               // cout << endl << "*** LINE CACHE PERFECT HIT" << endl;
                return;
        }
 
        //cout << endl << "*** LINE CACHE MISS" << endl;
 
-       bool inserted_last_time = true;
        bool invalidated = false;
 
-       for (i = points.begin(); i != points.end(); ++i) {
+       for (i = begin; i != end; ++i) {
 
-               if ((*i).type == ARDOUR::TempoMap::Bar) {
+               if ((*i).is_bar()) {
                        color = ARDOUR_UI::config()->canvasvar_MeasureLineBar.get();
                } else {
                        if (beat_density > 2.0) {
@@ -141,11 +143,9 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
                }
 
                xpos = rint(((framepos_t)(*i).frame) / (double)frames_per_unit);
-               
-               if (inserted_last_time && !_lines.empty()) {
-                       li = _lines.lower_bound(xpos); // first line >= xpos
-               }
-               
+
+               li = _lines.lower_bound(xpos); // first line >= xpos
+
                line = (li != _lines.end()) ? li->second : NULL;
                assert(!line || line->property_x1() == li->first);
                
@@ -154,15 +154,13 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
                        ++next;
                
                exhausted = (next == _lines.end());
-               
+
                // Hooray, line is perfect
                if (line && line->property_x1() == xpos) {
                        if (li != _lines.end())
                                ++li;
                        
                        line->property_color_rgba() = color;
-                       inserted_last_time = false; // don't search next time
-                       
                        // Use existing line, moving if necessary
                } else if (!exhausted) {
                        Lines::iterator steal = _lines.end();
@@ -171,18 +169,18 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
                        // Steal from the right
                        if (left->first > needed_left && li != steal && steal->first > needed_right) {
                                //cout << "*** STEALING FROM RIGHT" << endl;
+                               double const x = steal->first;
                                line = steal->second;
                                _lines.erase(steal);
                                line->property_x1() = xpos;
                                line->property_x2() = xpos;
                                line->property_color_rgba() = color;
                                _lines.insert(make_pair(xpos, line));
-                               inserted_last_time = true; // search next time
                                invalidated = true;
                                
                                // Shift clean range left
                                _clean_left = min(_clean_left, xpos);
-                               _clean_right = min(_clean_right, steal->first);
+                               _clean_right = min(_clean_right, x);
                                
                                // Move this line to where we need it
                        } else {
@@ -191,7 +189,6 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
                                        //cout << "*** EXISTING LINE" << endl;
                                        li = existing;
                                        li->second->property_color_rgba() = color;
-                                       inserted_last_time = false; // don't search next time
                                } else {
                                        //cout << "*** MOVING LINE" << endl;
                                        const double x1 = line->property_x1();
@@ -205,40 +202,41 @@ TempoLines::draw (ARDOUR::TempoMap::BBTPointList& points, double frames_per_unit
                                        line->property_x1() = xpos;
                                        line->property_x2() = xpos;
                                        _lines.insert(make_pair(xpos, line));
-                                       inserted_last_time = true; // search next time
                                }
                        }
                        
                        // Create a new line
                } else if (_lines.size() < needed || _lines.size() < MAX_CACHED_LINES) {
                        //cout << "*** CREATING LINE" << endl;
-                       assert(_lines.find(xpos) == _lines.end());
-                       line = new ArdourCanvas::SimpleLine (*_group);
-                       line->property_x1() = xpos;
-                       line->property_x2() = xpos;
-                       line->property_y1() = 0.0;
-                       line->property_y2() = _height;
-                       line->property_color_rgba() = color;
-                       _lines.insert(make_pair(xpos, line));
-                       inserted_last_time = true;
+                       /* if we already have a line there ... don't sweat it */
+                       if (_lines.find (xpos) == _lines.end()) {
+                               line = new ArdourCanvas::SimpleLine (*_group);
+                               line->property_x1() = xpos;
+                               line->property_x2() = xpos;
+                               line->property_y1() = 0.0;
+                               line->property_y2() = _height;
+                               line->property_color_rgba() = color;
+                               _lines.insert(make_pair(xpos, line));
+                       }
                        
                        // Steal from the left
                } else {
                        //cout << "*** STEALING FROM LEFT" << endl;
-                       assert(_lines.find(xpos) == _lines.end());
-                       Lines::iterator steal = _lines.begin();
-                       line = steal->second;
-                       _lines.erase(steal);
-                       line->property_color_rgba() = color;
-                       line->property_x1() = xpos;
-                       line->property_x2() = xpos;
-                       _lines.insert(make_pair(xpos, line));
-                       inserted_last_time = true; // search next time
-                       invalidated = true;
+                       if (_lines.find (xpos) == _lines.end()) {
+                               Lines::iterator steal = _lines.begin();
+                               double const x = steal->first;
+                               line = steal->second;
+                               _lines.erase(steal);
+                               line->property_color_rgba() = color;
+                               line->property_x1() = xpos;
+                               line->property_x2() = xpos;
+                               _lines.insert(make_pair(xpos, line));
+                               invalidated = true;
                        
-                       // Shift clean range right
-                       _clean_left = max(_clean_left, steal->first);
-                       _clean_right = max(_clean_right, xpos);
+                               // Shift clean range right
+                               _clean_left = max(_clean_left, x);
+                               _clean_right = max(_clean_right, xpos);
+                       }
                }
        }