possible fix for stack overflow when parsing video info
[ardour.git] / gtk2_ardour / transcode_ffmpeg.cc
index 0a622cb690c9f88f7963121c77be2b201b6633c9..94f8527cbbe48a16b2baa077ffdcc088d5ef40cc 100644 (file)
@@ -29,6 +29,7 @@
 
 #include "transcode_ffmpeg.h"
 #include "utils_videotl.h"
+#include "video_tool_paths.h"
 
 #include "i18n.h"
 
@@ -40,47 +41,31 @@ TranscodeFfmpeg::TranscodeFfmpeg (std::string f)
 {
        probeok = false;
        ffexecok = false;
-       ffmpeg_exe = "";
-       ffprobe_exe = "";
        m_duration = 0;
        m_avoffset = m_lead_in = m_lead_out = 0;
        m_width = m_height = 0;
        m_aspect = m_fps = 0;
+       m_sar = "";
 #if 1 /* tentative debug mode */
        debug_enable = false;
 #endif
 
-       std::string ff_file_path;
-       if (find_file_in_search_path (Searchpath(Glib::getenv("PATH")), X_("ffmpeg_harvid"), ff_file_path)) { ffmpeg_exe = ff_file_path; }
-       else if (Glib::file_test(X_("C:\\Program Files\\harvid\\ffmpeg.exe"), Glib::FILE_TEST_EXISTS)) {
-               ffmpeg_exe = X_("C:\\Program Files\\ffmpeg\\ffmpeg.exe");
-       }
-       else if (Glib::file_test(X_("C:\\Program Files\\ffmpeg\\ffmpeg.exe"), Glib::FILE_TEST_EXISTS)) {
-               ffmpeg_exe = X_("C:\\Program Files\\ffmpeg\\ffmpeg.exe");
-       }
-
-       if (find_file_in_search_path (Searchpath(Glib::getenv("PATH")), X_("ffprobe_harvid"), ff_file_path)) { ffprobe_exe = ff_file_path; }
-       else if (Glib::file_test(X_("C:\\Program Files\\harvid\\ffprobe.exe"), Glib::FILE_TEST_EXISTS)) {
-               ffprobe_exe = X_("C:\\Program Files\\ffmpeg\\ffprobe.exe");
-       }
-       else if (Glib::file_test(X_("C:\\Program Files\\ffmpeg\\ffprobe.exe"), Glib::FILE_TEST_EXISTS)) {
-               ffprobe_exe = X_("C:\\Program Files\\ffmpeg\\ffprobe.exe");
-       }
-
-       if (ffmpeg_exe.empty() || ffprobe_exe.empty()) {
+       if (!ArdourVideoToolPaths::transcoder_exe(ffmpeg_exe, ffprobe_exe)) {
                warning << string_compose(
                                _(
-                               "No ffprobe or ffmpeg executables could be found on this system.\n"
-                               "Video import and export is not possible until you install those tools.\n"
-                               "%1 requires ffmpeg and ffprobe from ffmpeg.org - version 1.1 or newer.\n"
-                               "\n"
-                               "The tools are included with the %1 releases from ardour.org "
-                               "and also available with the video-server at http://x42.github.com/harvid/\n"
-                               "\n"
-                               "Important: the files need to be installed in $PATH and named ffmpeg_harvid and ffprobe_harvid.\n"
-                               "If you already have a suitable ffmpeg installation on your system, we recommend creating "
-                               "symbolic links from ffmpeg to ffmpeg_harvid and from ffprobe to ffprobe_harvid.\n"
-                               ), PROGRAM_NAME) << endmsg;
+                                       "No ffprobe or ffmpeg executables could be found on this system.\n"
+                                       "Video import and export is not possible until you install those tools.\n"
+                                       "%1 requires ffmpeg and ffprobe from ffmpeg.org - version 1.1 or newer.\n"
+                                       "\n"
+                                       "The tools are included with the %1 releases from ardour.org "
+                                       "and also available with the video-server at http://x42.github.com/harvid/\n"
+                                       "\n"
+                                       "Important: the files need to be installed in $PATH and named ffmpeg_harvid and ffprobe_harvid.\n"
+                                       "If you already have a suitable ffmpeg installation on your system, we recommend creating "
+                                       "symbolic links from ffmpeg to ffmpeg_harvid and from ffprobe to ffprobe_harvid.\n"
+                                       "\n"
+                                       "see also http://manual.ardour.org/video-timeline/setup/"
+                                ), PROGRAM_NAME) << endmsg;
                return;
        }
        ffexecok = true;
@@ -109,7 +94,7 @@ TranscodeFfmpeg::probe ()
        argp[4] = strdup("-show_streams");
        argp[5] = strdup(infile.c_str());
        argp[6] = 0;
-       ffcmd = new SystemExec(ffprobe_exe, argp);
+       ffcmd = new ARDOUR::SystemExec(ffprobe_exe, argp);
        ffcmd->ReadStdout.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffprobeparse, this, _1 ,_2));
        ffcmd->Terminated.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffexit, this));
        if (ffcmd->start(1)) {
@@ -138,6 +123,7 @@ TranscodeFfmpeg::probe ()
        m_width = m_height = 0;
        m_fps = m_aspect = 0;
        m_duration = 0;
+       m_sar.clear();
        m_codec.clear();
        m_audio.clear();
 
@@ -186,8 +172,8 @@ TranscodeFfmpeg::probe ()
                                        } else if (key == X_("time_base")) {
                                                PARSE_FRACTIONAL_FPS(timebase)
                                        } else if (key == X_("timecode") && m_duration == 0) {
-                                               int h,m,s; char f[7];
-                                               if (sscanf(i->at(16).c_str(), "%d:%d:%d:%s",&h,&m,&s,f) == 4) {
+                                               int h,m,s; char f[32];
+                                               if (sscanf(i->at(16).c_str(), "%d:%d:%d:%32s",&h,&m,&s,f) == 4) {
                                                        m_duration = (ARDOUR::framecnt_t) floor(m_fps * (
                                                                        h * 3600.0
                                                                + m * 60.0
@@ -199,6 +185,13 @@ TranscodeFfmpeg::probe ()
                                                m_duration = atof(value) * m_fps * timebase;
                                        } else if (key == X_("duration") && m_fps != 0 && m_duration == 0) {
                                                m_duration = atof(value) * m_fps;
+                                       } else if (key == X_("sample_aspect_ratio")) {
+                                               std::string::size_type pos;
+                                               pos = value.find_first_of(':');
+                                               if (pos != std::string::npos && atof(value.substr(pos+1)) != 0) {
+                                                       m_sar = value;
+                                                       m_sar.replace(pos, 1, "/");
+                                               }
                                        } else if (key == X_("display_aspect_ratio")) {
                                                std::string::size_type pos;
                                                pos = value.find_first_of(':');
@@ -280,7 +273,7 @@ TranscodeFfmpeg::default_meta_data ()
 {
        TranscodeFfmpeg::FFSettings ffm;
        ffm.clear();
-       ffm["comment"] = "Created with ardour";
+       ffm["comment"] = "Created with " PROGRAM_NAME;
        return ffm;
 }
 
@@ -337,23 +330,37 @@ TranscodeFfmpeg::encode (std::string outfile, std::string inf_a, std::string inf
                argp[a++] = strdup("-metadata");
                argp[a++] = format_metadata(it->first.c_str(), it->second.c_str());
        }
+
+       if (m_fps > 0) {
+               m_lead_in  = rint (m_lead_in * m_fps) / m_fps;
+               m_lead_out = rint (m_lead_out * m_fps) / m_fps;
+       }
+
        if (m_lead_in != 0 && m_lead_out != 0) {
                std::ostringstream osstream;
                argp[a++] = strdup("-vf");
-               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_in << X_(" [pre]; ");
-               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_out << X_(" [post]; ");
+               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_in;
+               if (!m_sar.empty()) osstream << X_(":sar=") << m_sar;
+               osstream << X_(" [pre]; ");
+               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_out;
+               if (!m_sar.empty()) osstream << X_(":sar=") << m_sar;
+               osstream << X_(" [post]; ");
                osstream << X_("[pre] [in] [post] concat=n=3");
                argp[a++] = strdup(osstream.str().c_str());
        } else if (m_lead_in != 0) {
                std::ostringstream osstream;
                argp[a++] = strdup("-vf");
-               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_in << X_(" [pre]; ");
+               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_in;
+               if (!m_sar.empty()) osstream << X_(":sar=") << m_sar;
+               osstream << X_(" [pre]; ");
                osstream << X_("[pre] [in] concat=n=2");
                argp[a++] = strdup(osstream.str().c_str());
        } else if (m_lead_out != 0) {
                std::ostringstream osstream;
                argp[a++] = strdup("-vf");
-               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_out << X_(" [post]; ");
+               osstream << X_("color=c=black:s=") << m_width << X_("x") << m_height << X_(":d=") << m_lead_out;
+               if (!m_sar.empty()) osstream << X_(":sar=") << m_sar;
+               osstream << X_(" [post]; ");
                osstream << X_("[in] [post] concat=n=2");
                argp[a++] = strdup(osstream.str().c_str());
        }
@@ -382,7 +389,7 @@ TranscodeFfmpeg::encode (std::string outfile, std::string inf_a, std::string inf
        }
 #endif
 
-       ffcmd = new SystemExec(ffmpeg_exe, argp);
+       ffcmd = new ARDOUR::SystemExec(ffmpeg_exe, argp);
        ffcmd->ReadStdout.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffmpegparse_v, this, _1 ,_2));
        ffcmd->Terminated.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffexit, this));
        if (ffcmd->start(2)) {
@@ -430,7 +437,7 @@ TranscodeFfmpeg::extract_audio (std::string outfile, ARDOUR::framecnt_t /*sample
        }
 #endif
 
-       ffcmd = new SystemExec(ffmpeg_exe, argp);
+       ffcmd = new ARDOUR::SystemExec(ffmpeg_exe, argp);
        ffcmd->ReadStdout.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffmpegparse_a, this, _1 ,_2));
        ffcmd->Terminated.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffexit, this));
        if (ffcmd->start(2)) {
@@ -463,7 +470,7 @@ TranscodeFfmpeg::transcode (std::string outfile, const int outw, const int outh,
        if (bitrate < 10)  bitrate = 10;
        if (bitrate > 1000) bitrate = 1000;
 
-       argp=(char**) calloc(16,sizeof(char*));
+       argp=(char**) calloc(15,sizeof(char*));
        argp[0] = strdup(ffmpeg_exe.c_str());
        argp[1] = strdup("-i");
        argp[2] = strdup(infile.c_str());
@@ -473,24 +480,23 @@ TranscodeFfmpeg::transcode (std::string outfile, const int outw, const int outh,
        argp[6] = (char*) calloc(10,sizeof(char)); snprintf(argp[6], 10, "%ix%i", width, height);
        argp[7] = strdup("-y");
        argp[8] = strdup("-vcodec");
-       argp[9] = strdup("mjpeg");
+       argp[9] = strdup("mpeg4");
        argp[10] = strdup("-an");
-       argp[11] = strdup("-intra");
-       argp[12] = strdup("-g");
-       argp[13] = strdup("1");
-       argp[14] = strdup(outfile.c_str());
-       argp[15] = (char *)0;
+       argp[11] = strdup("-keyint_min");
+       argp[12] = strdup("10");
+       argp[13] = strdup(outfile.c_str());
+       argp[14] = (char *)0;
        /* Note: these are free()d in ~SystemExec */
 #if 1 /* DEBUG */
        if (debug_enable) { /* tentative debug mode */
        printf("TRANSCODE VIDEO:\n");
-       for (int i=0; i< 15; ++i) {
+       for (int i=0; i< 14; ++i) {
          printf("%s ", argp[i]);
        }
        printf("\n");
        }
 #endif
-       ffcmd = new SystemExec(ffmpeg_exe, argp);
+       ffcmd = new ARDOUR::SystemExec(ffmpeg_exe, argp);
        ffcmd->ReadStdout.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffmpegparse_v, this, _1 ,_2));
        ffcmd->Terminated.connect_same_thread (*this, boost::bind (&TranscodeFfmpeg::ffexit, this));
        if (ffcmd->start(2)) {