similar fix for punch recording as applied to 2.X, with additional tweak that when...
[ardour.git] / libs / ardour / audio_diskstream.cc
index f60d16391f3e6ced7fbf02f86f1c39d014c9a012..450bf5d7892c96a0206c32d3cf2d45f4965c1cbd 100644 (file)
@@ -35,7 +35,7 @@
 #include "pbd/xml++.h"
 #include "pbd/memento_command.h"
 #include "pbd/enumwriter.h"
-#include "pbd/stacktrace.h"
+#include "pbd/stateful_diff_command.h"
 
 #include "ardour/analyser.h"
 #include "ardour/ardour.h"
@@ -44,6 +44,7 @@
 #include "ardour/audio_port.h"
 #include "ardour/audioengine.h"
 #include "ardour/audiofilesource.h"
+
 #include "ardour/audioplaylist.h"
 #include "ardour/audioregion.h"
 #include "ardour/butler.h"
@@ -78,10 +79,7 @@ AudioDiskstream::AudioDiskstream (Session &sess, const string &name, Diskstream:
        /* prevent any write sources from being created */
 
        in_set_state = true;
-
-       init(flag);
        use_new_playlist ();
-
        in_set_state = false;
 }
 
@@ -91,7 +89,7 @@ AudioDiskstream::AudioDiskstream (Session& sess, const XMLNode& node)
        , channels (new ChannelList)
 {
        in_set_state = true;
-       init (Recordable);
+       init ();
 
        if (set_state (node, Stateful::loading_state_version)) {
                in_set_state = false;
@@ -106,10 +104,8 @@ AudioDiskstream::AudioDiskstream (Session& sess, const XMLNode& node)
 }
 
 void
-AudioDiskstream::init (Diskstream::Flag f)
+AudioDiskstream::init ()
 {
-       Diskstream::init(f);
-
        /* there are no channels at this point, so these
           two calls just get speed_buffer_size and wrap_buffer
           size setup without duplicating their code.
@@ -138,6 +134,8 @@ AudioDiskstream::~AudioDiskstream ()
        }
 
        channels.flush ();
+
+       delete deprecated_io_node;
 }
 
 void
@@ -343,7 +341,14 @@ AudioDiskstream::setup_destructive_playlist ()
 
        /* a single full-sized region */
 
-       boost::shared_ptr<Region> region (RegionFactory::create (srcs, 0, max_frames - srcs.front()->natural_position(), _name));
+       assert (!srcs.empty ());
+
+       PropertyList plist;
+       plist.add (Properties::name, _name.val());
+       plist.add (Properties::start, 0);
+       plist.add (Properties::length, max_frames - max_frames - srcs.front()->natural_position());
+
+       boost::shared_ptr<Region> region (RegionFactory::create (srcs, plist));
        _playlist->add_region (region, srcs.front()->natural_position());
 }
 
@@ -415,7 +420,7 @@ AudioDiskstream::prepare_record_status(nframes_t capture_start_frame)
 }
 
 int
-AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input)
+AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input, bool& need_butler)
 {
        uint32_t n;
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -427,22 +432,9 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
        bool re = record_enabled ();
        bool collect_playback = false;
 
-       /* if we've already processed the frames corresponding to this call,
-          just return. this allows multiple routes that are taking input
-          from this diskstream to call our ::process() method, but have
-          this stuff only happen once. more commonly, it allows both
-          the AudioTrack that is using this AudioDiskstream *and* the Session
-          to call process() without problems.
-       */
-
-       if (_processed) {
-               return 0;
-       }
-
-       commit_should_unlock = false;
+        playback_distance = 0;
 
        if (!_io || !_io->active()) {
-               _processed = true;
                return 0;
        }
 
@@ -451,20 +443,15 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
        nominally_recording = (can_record && re);
 
        if (nframes == 0) {
-               _processed = true;
                return 0;
        }
 
-       /* This lock is held until the end of AudioDiskstream::commit, so these two functions
-          must always be called as a pair. The only exception is if this function
-          returns a non-zero value, in which case, ::commit should not be called.
-       */
+        Glib::Mutex::Lock sm (state_lock, Glib::TRY_LOCK);
 
-       // If we can't take the state lock return.
-       if (!state_lock.trylock()) {
+        if (!sm.locked()) {
                return 1;
        }
-       commit_should_unlock = true;
+
        adjust_capture_position = 0;
 
        for (chan = c->begin(); chan != c->end(); ++chan) {
@@ -472,7 +459,16 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                (*chan)->current_playback_buffer = 0;
        }
 
-       if (nominally_recording || (_session.get_record_enabled() && _session.config.get_punch_in())) {
+        /* two conditions to test for here:
+           
+           A: this track is rec-enabled, and the session has confirmed that we can record
+           B: this track is rec-enabled, has been recording, and we are set up for auto-punch-in
+
+           The second test is necessary to capture the extra material that arrives AFTER the transport
+           frame has left the punch range (which will cause the "can_record" argument to be false).
+        */
+
+       if (nominally_recording || (re && was_recording && _session.get_record_enabled() && _session.config.get_punch_out())) {
                // Safeguard against situations where process() goes haywire when autopunching and last_recordable_frame < first_recordable_frame
                if (last_recordable_frame < first_recordable_frame) {
                        last_recordable_frame = max_frames;
@@ -480,7 +476,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
 
                OverlapType ot = coverage (first_recordable_frame, last_recordable_frame, transport_frame, transport_frame + nframes);
 
-               calculate_record_range(ot, transport_frame, nframes, rec_nframes, rec_offset);
+               calculate_record_range (ot, transport_frame, nframes, rec_nframes, rec_offset);
 
                if (rec_nframes && !was_recording) {
                        capture_captured = 0;
@@ -488,7 +484,6 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                }
        }
 
-
        if (can_record && !_last_capture_regions.empty()) {
                _last_capture_regions.clear ();
        }
@@ -521,7 +516,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                                AudioPort* const ap = _io->audio (n);
                                assert(ap);
                                assert(rec_nframes <= ap->get_audio_buffer(nframes).capacity());
-                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (rec_nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
+                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
 
 
                        } else {
@@ -656,23 +651,15 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
 
                _speed = _target_speed;
 
-       }
+       } 
 
        ret = 0;
 
-  out:
-       _processed = true;
-
-       if (ret) {
-
-               /* we're exiting with failure, so ::commit will not
-                  be called. unlock the state lock.
-               */
-
-               commit_should_unlock = false;
-               state_lock.unlock();
-       }
+        if (commit (nframes)) {
+                need_butler = true;
+        }
 
+  out:
        return ret;
 }
 
@@ -695,7 +682,7 @@ AudioDiskstream::process_varispeed_playback(nframes_t nframes, boost::shared_ptr
 }
 
 bool
-AudioDiskstream::commit (nframes_t /*nframes*/)
+AudioDiskstream::commit (nframes_t /* nframes */)
 {
        bool need_butler = false;
 
@@ -739,12 +726,6 @@ AudioDiskstream::commit (nframes_t /*nframes*/)
                }
        }
 
-       if (commit_should_unlock) {
-               state_lock.unlock();
-       }
-
-       _processed = false;
-
        return need_butler;
 }
 
@@ -899,7 +880,6 @@ AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
        bool reloop = false;
        nframes_t loop_end = 0;
        nframes_t loop_start = 0;
-       nframes_t loop_length = 0;
        nframes_t offset = 0;
        Location *loc = 0;
 
@@ -907,6 +887,8 @@ AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
 
        if (!reversed) {
 
+               nframes_t loop_length = 0;
+
                /* Make the use of a Location atomic for this read operation.
 
                   Note: Locations don't get deleted, so all we care about
@@ -1432,7 +1414,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                if (s) {
                        srcs.push_back (s);
                        s->update_header (capture_info.front()->start, when, twhen);
-                       s->set_captured_for (_name);
+                       s->set_captured_for (_name.val());
                        s->mark_immutable ();
                        if (Config->get_auto_analyse_audio()) {
                                Analyser::queue_source_for_analysis (s, true);
@@ -1450,7 +1432,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                   process. this problem is deferred to the UI.
                 */
 
-               _playlist->Modified();
+               _playlist->LayeringChanged(); // XXX this may not get the UI to do the right thing
 
        } else {
 
@@ -1464,10 +1446,15 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                */
 
                try {
-                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs,
-                                               c->front()->write_source->last_capture_start_frame(), total_capture,
-                                               whole_file_region_name, 0,
-                                               Region::Flag (Region::DefaultFlags|Region::Automatic|Region::WholeFile)));
+                       PropertyList plist;
+
+                       plist.add (Properties::start, c->front()->write_source->last_capture_start_frame());
+                       plist.add (Properties::length, total_capture);
+                       plist.add (Properties::name, whole_file_region_name);
+
+                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
+                       rx->set_automatic (true);
+                       rx->set_whole_file (true);
 
                        region = boost::dynamic_pointer_cast<AudioRegion> (rx);
                        region->special_set_position (capture_info.front()->start);
@@ -1483,19 +1470,26 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 
                // cerr << _name << ": there are " << capture_info.size() << " capture_info records\n";
 
-               XMLNode &before = _playlist->get_state();
+                _playlist->clear_history ();
                _playlist->freeze ();
 
                for (buffer_position = c->front()->write_source->last_capture_start_frame(), ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
 
                        string region_name;
 
-                       _session.region_name (region_name, whole_file_region_name, false);
+                       RegionFactory::region_name (region_name, whole_file_region_name, false);
 
                        // cerr << _name << ": based on ci of " << (*ci)->start << " for " << (*ci)->frames << " add region " << region_name << endl;
 
                        try {
-                               boost::shared_ptr<Region> rx (RegionFactory::create (srcs, buffer_position, (*ci)->frames, region_name));
+
+                               PropertyList plist;
+                               
+                               plist.add (Properties::start, buffer_position);
+                               plist.add (Properties::length, (*ci)->frames);
+                               plist.add (Properties::name, region_name);
+                               
+                               boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
                                region = boost::dynamic_pointer_cast<AudioRegion> (rx);
                        }
 
@@ -1504,7 +1498,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                                continue; /* XXX is this OK? */
                        }
 
-                       region->GoingAway.connect (*this, boost::bind (&Diskstream::remove_region_from_last_capture, this, boost::weak_ptr<Region>(region)));
+                       region->DropReferences.connect_same_thread (*this, boost::bind (&Diskstream::remove_region_from_last_capture, this, boost::weak_ptr<Region>(region)));
 
                        _last_capture_regions.push_back (region);
 
@@ -1516,8 +1510,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                }
 
                _playlist->thaw ();
-               XMLNode &after = _playlist->get_state();
-               _session.add_command (new MementoCommand<Playlist>(*_playlist, &before, &after));
+               _session.add_command (new StatefulDiffCommand (_playlist));
        }
 
        mark_write_completed = true;
@@ -1590,6 +1583,8 @@ void
 AudioDiskstream::finish_capture (bool /*rec_monitors_input*/, boost::shared_ptr<ChannelList> c)
 {
        was_recording = false;
+        first_recordable_frame = max_frames;
+        last_recordable_frame = max_frames;
 
        if (capture_captured == 0) {
                return;
@@ -1948,7 +1943,7 @@ AudioDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
                }
        }
 
-       if (destructive()) {
+       if (destructive() && !c->empty ()) {
 
                /* we now have all our write sources set up, so create the
                   playlist's single region.
@@ -1969,7 +1964,7 @@ AudioDiskstream::rename_write_sources ()
 
        for (chan = c->begin(), n = 0; chan != c->end(); ++chan, ++n) {
                if ((*chan)->write_source != 0) {
-                       (*chan)->write_source->set_source_name (_name, destructive());
+                       (*chan)->write_source->set_source_name (_name.val(), destructive());
                        /* XXX what to do if one of them fails ? */
                }
        }
@@ -2087,9 +2082,7 @@ int
 AudioDiskstream::remove_channel_from (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
        while (how_many-- && !c->empty()) {
-               // FIXME: crash (thread safe with RCU?)
-               // memory leak, when disabled.... :(
-               //delete c->back();
+               delete c->back();
                c->pop_back();
                interpolation.remove_channel_from ();
        }
@@ -2177,7 +2170,7 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
                                first_fs = fs;
                        }
 
-                       fs->set_captured_for (_name);
+                       fs->set_captured_for (_name.val());
                }
        }
 
@@ -2195,10 +2188,17 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
        boost::shared_ptr<AudioRegion> region;
 
        try {
-               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (
-                               pending_sources, 0, first_fs->length(first_fs->timeline_position()),
-                               region_name_from_path (first_fs->name(), true), 0,
-                               Region::Flag (Region::DefaultFlags|Region::Automatic|Region::WholeFile)));
+               
+               PropertyList plist;
+               
+               plist.add (Properties::start, 0);
+               plist.add (Properties::length, first_fs->length (first_fs->timeline_position()));
+               plist.add (Properties::name, region_name_from_path (first_fs->name(), true));
+
+               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (pending_sources, plist));
+
+               region->set_automatic (true);
+               region->set_whole_file (true);
                region->special_set_position (0);
        }
 
@@ -2210,20 +2210,6 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
                return -1;
        }
 
-       try {
-               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (
-                               pending_sources, 0, first_fs->length(first_fs->timeline_position()),
-                               region_name_from_path (first_fs->name(), true)));
-       }
-
-       catch (failed_constructor& err) {
-               error << string_compose (_("%1: cannot create region from pending capture sources"),
-                                 _name)
-                     << endmsg;
-
-               return -1;
-       }
-
        _playlist->add_region (region, position);
 
        return 0;
@@ -2247,11 +2233,10 @@ AudioDiskstream::set_non_layered (bool yn)
 int
 AudioDiskstream::set_destructive (bool yn)
 {
-       bool bounce_ignored;
-
        if (yn != destructive()) {
 
                if (yn) {
+                       bool bounce_ignored;
                        /* requestor should already have checked this and
                           bounced if necessary and desired
                        */
@@ -2285,7 +2270,10 @@ AudioDiskstream::can_become_destructive (bool& requires_bounce) const
        }
 
        boost::shared_ptr<Region> first = _playlist->find_next_region (_session.current_start_frame(), Start, 1);
-       assert (first);
+       if (!first) {
+               requires_bounce = false;
+               return true;
+       }
 
        /* do the source(s) for the region cover the session start position ? */
 
@@ -2340,9 +2328,7 @@ AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_si
 
 AudioDiskstream::ChannelInfo::~ChannelInfo ()
 {
-       if (write_source) {
-               write_source.reset ();
-       }
+        write_source.reset ();
 
        delete [] speed_buffer;
        speed_buffer = 0;