fix (no)use of offset in AudioEngine::get_sync_offset()
[ardour.git] / libs / ardour / audio_diskstream.cc
index b372c14b57d2b5927a877f003d8649dcefccd063..5c00f10f48fd4aee8c769c7fca071d5c8c712119 100644 (file)
 #include <sys/stat.h>
 #include <sys/mman.h>
 
-#include <pbd/error.h>
-#include <pbd/basename.h>
+#include "pbd/error.h"
 #include <glibmm/thread.h>
-#include <pbd/xml++.h>
-#include <pbd/memento_command.h>
-#include <pbd/enumwriter.h>
-#include <pbd/stacktrace.h>
-
-#include <ardour/ardour.h>
-#include <ardour/audioengine.h>
-#include <ardour/audio_diskstream.h>
-#include <ardour/utils.h>
-#include <ardour/configuration.h>
-#include <ardour/audiofilesource.h>
-#include <ardour/send.h>
-#include <ardour/region_factory.h>
-#include <ardour/audioplaylist.h>
-#include <ardour/playlist_factory.h>
-#include <ardour/cycle_timer.h>
-#include <ardour/audioregion.h>
-#include <ardour/source_factory.h>
+#include "pbd/xml++.h"
+#include "pbd/memento_command.h"
+#include "pbd/enumwriter.h"
+#include "pbd/stacktrace.h"
+
+#include "ardour/ardour.h"
+#include "ardour/audioengine.h"
+#include "ardour/analyser.h"
+#include "ardour/audio_diskstream.h"
+#include "ardour/utils.h"
+#include "ardour/configuration.h"
+#include "ardour/audiofilesource.h"
+#include "ardour/send.h"
+#include "ardour/region_factory.h"
+#include "ardour/audioplaylist.h"
+#include "ardour/playlist_factory.h"
+#include "ardour/cycle_timer.h"
+#include "ardour/audioregion.h"
+#include "ardour/audio_port.h"
+#include "ardour/source_factory.h"
+#include "ardour/audio_buffer.h"
+#include "ardour/session.h"
+#include "ardour/io.h"
 
 #include "i18n.h"
 #include <locale.h>
@@ -112,7 +116,7 @@ AudioDiskstream::init (Diskstream::Flag f)
        allocate_temporary_buffers ();
 
        add_channel (1);
-       assert(_n_channels == 1);
+       assert(_n_channels == ChanCount(DataType::AUDIO, 1));
 }
 
 AudioDiskstream::~AudioDiskstream ()
@@ -167,12 +171,12 @@ AudioDiskstream::non_realtime_input_change ()
                        RCUWriter<ChannelList> writer (channels);
                        boost::shared_ptr<ChannelList> c = writer.get_copy();
                        
-                       _n_channels = c->size();
+                       _n_channels.set(DataType::AUDIO, c->size());
                        
-                       if (_io->n_inputs() > _n_channels) {
-                               add_channel_to (c, _io->n_inputs() - _n_channels);
-                       } else if (_io->n_inputs() < _n_channels) {
-                               remove_channel_from (c, _n_channels - _io->n_inputs());
+                       if (_io->n_ports().n_audio() > _n_channels.n_audio()) {
+                               add_channel_to (c, _io->n_ports().n_audio() - _n_channels.n_audio());
+                       } else if (_io->n_ports().n_audio() < _n_channels.n_audio()) {
+                               remove_channel_from (c, _n_channels.n_audio() - _io->n_ports().n_audio());
                        }
                }
                
@@ -204,6 +208,18 @@ AudioDiskstream::non_realtime_input_change ()
        }
 }
 
+void
+AudioDiskstream::non_realtime_locate (nframes_t location)
+{
+       /* now refill channel buffers */
+
+       if (speed() != 1.0f || speed() != -1.0f) {
+               seek ((nframes_t) (location * (double) speed()));
+       } else {
+               seek (location);
+       }
+}
+
 void
 AudioDiskstream::get_input_sources ()
 {
@@ -211,14 +227,15 @@ AudioDiskstream::get_input_sources ()
 
        uint32_t n;
        ChannelList::iterator chan;
-       uint32_t ni = _io->n_inputs();
+       uint32_t ni = _io->n_ports().n_audio();
+       vector<string> connections;
 
        for (n = 0, chan = c->begin(); chan != c->end() && n < ni; ++chan, ++n) {
                
-               const char **connections = _io->input(n)->get_connections ();
+               connections.clear ();
+
+               if (_io->nth (n)->get_connections (connections) == 0) {
                
-               if (connections == 0 || connections[0] == 0) {
-                       
                        if ((*chan)->source) {
                                // _source->disable_metering ();
                        }
@@ -226,11 +243,7 @@ AudioDiskstream::get_input_sources ()
                        (*chan)->source = 0;
                        
                } else {
-                       (*chan)->source = _session.engine().get_port_by_name (connections[0]);
-               }
-               
-               if (connections) {
-                       free (connections);
+                       (*chan)->source = dynamic_cast<AudioPort*>(_session.engine().get_port_by_name (connections[0]) );
                }
        }
 }              
@@ -241,7 +254,7 @@ AudioDiskstream::find_and_use_playlist (const string& name)
        boost::shared_ptr<AudioPlaylist> playlist;
                
        if ((playlist = boost::dynamic_pointer_cast<AudioPlaylist> (_session.playlist_by_name (name))) == 0) {
-               playlist = boost::dynamic_pointer_cast<AudioPlaylist> (PlaylistFactory::create (_session, name));
+               playlist = boost::dynamic_pointer_cast<AudioPlaylist> (PlaylistFactory::create (DataType::AUDIO, _session, name));
        }
 
        if (!playlist) {
@@ -267,7 +280,7 @@ AudioDiskstream::use_new_playlist ()
 {
        string newname;
        boost::shared_ptr<AudioPlaylist> playlist;
-
+       
        if (!in_set_state && destructive()) {
                return 0;
        }
@@ -278,7 +291,7 @@ AudioDiskstream::use_new_playlist ()
                newname = Playlist::bump_name (_name, _session);
        }
 
-       if ((playlist = boost::dynamic_pointer_cast<AudioPlaylist> (PlaylistFactory::create (_session, newname, hidden()))) != 0) {
+       if ((playlist = boost::dynamic_pointer_cast<AudioPlaylist> (PlaylistFactory::create (DataType::AUDIO, _session, newname, hidden()))) != 0) {
                
                playlist->set_orig_diskstream_id (id());
                return use_playlist (playlist);
@@ -375,7 +388,7 @@ AudioDiskstream::use_destructive_playlist ()
 }
 
 void
-AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t nframes, bool can_record)
+AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t /*nframes*/, bool can_record)
 {
        int possibly_recording;
        int rolling;
@@ -400,7 +413,7 @@ AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t nfram
 
        /* if per-track or global rec-enable turned on while the other was already on, we've started recording */
 
-       if ((change & track_rec_enabled) && record_enabled() && (!(change & global_rec_enabled) && can_record) || 
+       if (((change & track_rec_enabled) && record_enabled() && (!(change & global_rec_enabled) && can_record)) || 
            ((change & global_rec_enabled) && can_record && (!(change & track_rec_enabled) && record_enabled()))) {
                
                /* starting to record: compute first+last frames */
@@ -425,7 +438,7 @@ AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t nfram
 
                        if (_alignment_style == ExistingMaterial) {
 
-                               if (!Config->get_punch_in()) {
+                               if (!_session.config.get_punch_in()) {
 
                                        /* manual punch in happens at the correct transport frame
                                           because the user hit a button. but to get alignment correct 
@@ -454,7 +467,7 @@ AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t nfram
 
                        } else {
 
-                               if (Config->get_punch_in()) {
+                               if (_session.config.get_punch_in()) {
                                        first_recordable_frame += _roll_delay;
                                } else {
                                        capture_start_frame -= _roll_delay;
@@ -463,7 +476,7 @@ AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t nfram
                        
                }
 
-               if (_flags & Recordable) {
+               if (recordable() && destructive()) {
                        boost::shared_ptr<ChannelList> c = channels.reader();
                        for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
                                
@@ -500,7 +513,7 @@ AudioDiskstream::check_record_status (nframes_t transport_frame, nframes_t nfram
 }
 
 int
-AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_t offset, bool can_record, bool rec_monitors_input)
+AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input)
 {
        uint32_t n;
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -526,6 +539,11 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
 
        commit_should_unlock = false;
 
+       if (!_io || !_io->active()) {
+               _processed = true;
+               return 0;
+       }
+
        check_record_status (transport_frame, nframes, can_record);
 
        nominally_recording = (can_record && re);
@@ -549,12 +567,17 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
 
        for (chan = c->begin(); chan != c->end(); ++chan) {
                (*chan)->current_capture_buffer = 0;
-               (*chan)->current_playback_buffer  = 0;
+               (*chan)->current_playback_buffer = 0;
        }
 
-       if (nominally_recording || (_session.get_record_enabled() && Config->get_punch_in())) {
+       if (nominally_recording || (_session.get_record_enabled() && _session.config.get_punch_in())) {
                OverlapType ot;
                
+               // Safeguard against situations where process() goes haywire when autopunching and last_recordable_frame < first_recordable_frame
+               if (last_recordable_frame < first_recordable_frame) {
+                       last_recordable_frame = max_frames; 
+               }
+
                ot = coverage (first_recordable_frame, last_recordable_frame, transport_frame, transport_frame + nframes);
 
                switch (ot) {
@@ -592,7 +615,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
                        /*    |--------|    recrange
                             --------------  transrange
                        */
-                       rec_nframes = last_recordable_frame - last_recordable_frame;
+                       rec_nframes = last_recordable_frame - first_recordable_frame;
                        rec_offset = first_recordable_frame - transport_frame;
                        break;
                }
@@ -610,7 +633,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
 
        if (nominally_recording || rec_nframes) {
 
-               uint32_t limit = _io->n_inputs ();
+               uint32_t limit = _io->n_ports ().n_audio();
 
                /* one or more ports could already have been removed from _io, but our
                   channel setup hasn't yet been updated. prevent us from trying to
@@ -629,11 +652,15 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
                                
                                chaninfo->current_capture_buffer = chaninfo->capture_vector.buf[0];
 
-                               /* note: grab the entire port buffer, but only copy what we were supposed to for recording, and use
-                                  rec_offset
+                               /* note: grab the entire port buffer, but only copy what we were supposed to
+                                  for recording, and use rec_offset
                                */
 
-                               memcpy (chaninfo->current_capture_buffer, _io->input(n)->get_buffer (rec_nframes) + offset + rec_offset, sizeof (Sample) * rec_nframes);
+                               AudioPort* const ap = _io->audio (n);
+                               assert(ap);
+                               assert(rec_nframes <= ap->get_audio_buffer(nframes).capacity());
+                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (rec_nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
+
 
                        } else {
 
@@ -644,7 +671,10 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
                                        goto out;
                                }
 
-                               Sample* buf = _io->input (n)->get_buffer (nframes) + offset;
+                               AudioPort* const ap = _io->audio (n);
+                               assert(ap);
+
+                               Sample* buf = ap->get_audio_buffer(nframes).data();
                                nframes_t first = chaninfo->capture_vector.len[0];
 
                                memcpy (chaninfo->capture_wrap_buffer, buf, sizeof (Sample) * first);
@@ -736,15 +766,19 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
                                nframes_t total = chaninfo->playback_vector.len[0] + chaninfo->playback_vector.len[1];
                                
                                if (necessary_samples > total) {
+                                       cerr << "underrun for " << _name << endl;
                                        DiskUnderrun ();
                                        goto out;
                                        
                                } else {
                                        
-                                       memcpy ((char *) chaninfo->playback_wrap_buffer, chaninfo->playback_vector.buf[0],
-                                               chaninfo->playback_vector.len[0] * sizeof (Sample));
-                                       memcpy (chaninfo->playback_wrap_buffer + chaninfo->playback_vector.len[0], chaninfo->playback_vector.buf[1], 
-                                               (necessary_samples - chaninfo->playback_vector.len[0]) * sizeof (Sample));
+                                       memcpy ((char *) chaninfo->playback_wrap_buffer,
+                                                       chaninfo->playback_vector.buf[0],
+                                                       chaninfo->playback_vector.len[0] * sizeof (Sample));
+                                       memcpy (chaninfo->playback_wrap_buffer + chaninfo->playback_vector.len[0],
+                                                       chaninfo->playback_vector.buf[1], 
+                                                       (necessary_samples - chaninfo->playback_vector.len[0])
+                                                                       * sizeof (Sample));
                                        
                                        chaninfo->current_playback_buffer = chaninfo->playback_wrap_buffer;
                                }
@@ -752,40 +786,13 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
                } 
 
                if (rec_nframes == 0 && _actual_speed != 1.0f && _actual_speed != -1.0f) {
-                       
-                       uint64_t phase = last_phase;
-                       nframes_t i = 0;
-
-                       // Linearly interpolate into the alt buffer
-                       // using 40.24 fixp maths (swh)
-
-                       for (chan = c->begin(); chan != c->end(); ++chan) {
-
-                               float fr;
-                               ChannelInfo* chaninfo (*chan);
-
-                               i = 0;
-                               phase = last_phase;
-
-                               for (nframes_t outsample = 0; outsample < nframes; ++outsample) {
-                                       i = phase >> 24;
-                                       fr = (phase & 0xFFFFFF) / 16777216.0f;
-                                       chaninfo->speed_buffer[outsample] = 
-                                               chaninfo->current_playback_buffer[i] * (1.0f - fr) +
-                                               chaninfo->current_playback_buffer[i+1] * fr;
-                                       phase += phi;
-                               }
-                               
-                               chaninfo->current_playback_buffer = chaninfo->speed_buffer;
-                       }
-
-                       playback_distance = i + 1;
-                       last_phase = (phase & 0xFFFFFF);
-
+                       process_varispeed_playback(nframes, c);
                } else {
                        playback_distance = nframes;
                }
 
+               _speed = _target_speed;
+
        }
 
        ret = 0;
@@ -806,11 +813,33 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, nframes_
        return ret;
 }
 
+void
+AudioDiskstream::process_varispeed_playback(nframes_t nframes, boost::shared_ptr<ChannelList> c)
+{
+         ChannelList::iterator chan;
+       
+               interpolation.set_speed (_target_speed);
+               
+               int channel = 0;
+               for (chan = c->begin(); chan != c->end(); ++chan, ++channel) {
+                       ChannelInfo* chaninfo (*chan);
+       
+                       playback_distance = interpolation.interpolate (
+                                       channel, nframes, chaninfo->current_playback_buffer, chaninfo->speed_buffer);
+                                       
+                       chaninfo->current_playback_buffer = chaninfo->speed_buffer;
+               }
+}
+
 bool
-AudioDiskstream::commit (nframes_t nframes)
+AudioDiskstream::commit (nframes_t /*nframes*/)
 {
        bool need_butler = false;
 
+       if (!_io || !_io->active()) {
+               return false;
+       }
+
        if (_actual_speed < 0.0) {
                playback_sample -= playback_distance;
        } else {
@@ -833,10 +862,18 @@ AudioDiskstream::commit (nframes_t nframes)
        }
        
        if (_slaved) {
-               need_butler = c->front()->playback_buf->write_space() >= c->front()->playback_buf->bufsize() / 2;
+               if (_io && _io->active()) {
+                       need_butler = c->front()->playback_buf->write_space() >= c->front()->playback_buf->bufsize() / 2;
+               } else {
+                       need_butler = false;
+               }
        } else {
-               need_butler = c->front()->playback_buf->write_space() >= disk_io_chunk_frames
-                       || c->front()->capture_buf->read_space() >= disk_io_chunk_frames;
+               if (_io && _io->active()) {
+                       need_butler = c->front()->playback_buf->write_space() >= disk_io_chunk_frames
+                               || c->front()->capture_buf->read_space() >= disk_io_chunk_frames;
+               } else {
+                       need_butler = c->front()->capture_buf->read_space() >= disk_io_chunk_frames;
+               }
        }
 
        if (commit_should_unlock) {
@@ -932,7 +969,7 @@ int
 AudioDiskstream::seek (nframes_t frame, bool complete_refill)
 {
        uint32_t n;
-       int ret;
+       int ret = -1;
        ChannelList::iterator chan;
        boost::shared_ptr<ChannelList> c = channels.reader();
 
@@ -993,7 +1030,7 @@ AudioDiskstream::internal_playback_seek (nframes_t distance)
 
 int
 AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer, nframes_t& start, nframes_t cnt, 
-                      ChannelInfo* channel_info, int channel, bool reversed)
+                      ChannelInfo* /*channel_info*/, int channel, bool reversed)
 {
        nframes_t this_read = 0;
        bool reloop = false;
@@ -1327,7 +1364,7 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer)
  * written at all unless @a force_flush is true.
  */
 int
-AudioDiskstream::do_flush (Session::RunContext context, bool force_flush)
+AudioDiskstream::do_flush (RunContext /*context*/, bool force_flush)
 {
        uint32_t to_write;
        int32_t ret = 0;
@@ -1479,7 +1516,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
        */
 
        while (more_work && !err) {
-               switch (do_flush (Session::TransportContext, true)) {
+               switch (do_flush (TransportContext, true)) {
                case 0:
                        more_work = false;
                        break;
@@ -1534,6 +1571,9 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                        s->update_header (capture_info.front()->start, when, twhen);
                        s->set_captured_for (_name);
                        s->mark_immutable ();
+                       if (Config->get_auto_analyse_audio()) {
+                               Analyser::queue_source_for_analysis (s, true);
+                       }
                }
        }
 
@@ -1561,9 +1601,10 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                */
                
                try {
-                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs, c->front()->write_source->last_capture_start_frame(), total_capture, 
-                                                                            whole_file_region_name,
-                                                                            0, AudioRegion::Flag (AudioRegion::DefaultFlags|AudioRegion::Automatic|AudioRegion::WholeFile)));
+                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs,
+                                               c->front()->write_source->last_capture_start_frame(), total_capture, 
+                                               whole_file_region_name, 0,
+                                               Region::Flag (Region::DefaultFlags|Region::Automatic|Region::WholeFile)));
 
                        region = boost::dynamic_pointer_cast<AudioRegion> (rx);
                        region->special_set_position (capture_info.front()->start);
@@ -1579,7 +1620,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 
                // cerr << _name << ": there are " << capture_info.size() << " capture_info records\n";
                
-                XMLNode &before = _playlist->get_state();
+               XMLNode &before = _playlist->get_state();
                _playlist->freeze ();
                
                for (buffer_position = c->front()->write_source->last_capture_start_frame(), ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
@@ -1605,14 +1646,14 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                        _last_capture_regions.push_back (region);
                        
                        i_am_the_modifier++;
-                       _playlist->add_region (region, (*ci)->start);
+                       _playlist->add_region (region, (*ci)->start, 1, non_layered());
                        i_am_the_modifier--;
                        
                        buffer_position += (*ci)->frames;
                }
 
                _playlist->thaw ();
-                XMLNode &after = _playlist->get_state();
+               XMLNode &after = _playlist->get_state();
                _session.add_command (new MementoCommand<Playlist>(*_playlist, &before, &after));
        }
 
@@ -1632,7 +1673,58 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 }
 
 void
-AudioDiskstream::finish_capture (bool rec_monitors_input, boost::shared_ptr<ChannelList> c)
+AudioDiskstream::transport_looped (nframes_t transport_frame)
+{
+       if (was_recording) {
+               // all we need to do is finish this capture, with modified capture length
+               boost::shared_ptr<ChannelList> c = channels.reader();
+
+               // adjust the capture length knowing that the data will be recorded to disk
+               // only necessary after the first loop where we're recording
+               if (capture_info.size() == 0) {
+                       capture_captured += _capture_offset;
+
+                       if (_alignment_style == ExistingMaterial) {
+                               capture_captured += _session.worst_output_latency();
+                       } else {
+                               capture_captured += _roll_delay;
+                       }
+               }
+
+               finish_capture (true, c);
+
+               // the next region will start recording via the normal mechanism
+               // we'll set the start position to the current transport pos
+               // no latency adjustment or capture offset needs to be made, as that already happened the first time
+               capture_start_frame = transport_frame;
+               first_recordable_frame = transport_frame; // mild lie
+               last_recordable_frame = max_frames;
+               was_recording = true;
+
+               if (recordable() && destructive()) {
+                       for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
+                               
+                               RingBufferNPT<CaptureTransition>::rw_vector transvec;
+                               (*chan)->capture_transition_buf->get_write_vector(&transvec);
+                               
+                               if (transvec.len[0] > 0) {
+                                       transvec.buf[0]->type = CaptureStart;
+                                       transvec.buf[0]->capture_val = capture_start_frame;
+                                       (*chan)->capture_transition_buf->increment_write_ptr(1);
+                               }
+                               else {
+                                       // bad!
+                                       fatal << X_("programming error: capture_transition_buf is full on rec loop!  inconceivable!") 
+                                             << endmsg;
+                               }
+                       }
+               }
+
+       }
+}
+
+void
+AudioDiskstream::finish_capture (bool /*rec_monitors_input*/, boost::shared_ptr<ChannelList> c)
 {
        was_recording = false;
        
@@ -1646,7 +1738,6 @@ AudioDiskstream::finish_capture (bool rec_monitors_input, boost::shared_ptr<Chan
                        RingBufferNPT<CaptureTransition>::rw_vector transvec;
                        (*chan)->capture_transition_buf->get_write_vector(&transvec);
                        
-                       
                        if (transvec.len[0] > 0) {
                                transvec.buf[0]->type = CaptureEnd;
                                transvec.buf[0]->capture_val = capture_captured;
@@ -1678,12 +1769,15 @@ AudioDiskstream::finish_capture (bool rec_monitors_input, boost::shared_ptr<Chan
 
        capture_info.push_back (ci);
        capture_captured = 0;
+
+       /* now we've finished a capture, reset first_recordable_frame for next time */
+       first_recordable_frame = max_frames;
 }
 
 void
 AudioDiskstream::set_record_enabled (bool yn)
 {
-       if (!recordable() || !_session.record_enabling_legal() || _io->n_inputs() == 0) {
+       if (!recordable() || !_session.record_enabling_legal() || _io->n_ports().n_audio() == 0) {
                return;
        }
 
@@ -1728,14 +1822,16 @@ AudioDiskstream::engage_record_enable ()
 
                for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
                        if ((*chan)->source) {
-                               (*chan)->source->ensure_monitor_input (!(Config->get_auto_input() && rolling));
+                               (*chan)->source->ensure_monitor_input (!(_session.config.get_auto_input() && rolling));
                        }
                        capturing_sources.push_back ((*chan)->write_source);
+                       (*chan)->write_source->mark_streaming_write_started ();
                }
                
        } else {
                for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
                        capturing_sources.push_back ((*chan)->write_source);
+                       (*chan)->write_source->mark_streaming_write_started ();
                }
        }
 
@@ -1747,8 +1843,8 @@ AudioDiskstream::disengage_record_enable ()
 {
        g_atomic_int_set (&_record_enabled, 0);
        boost::shared_ptr<ChannelList> c = channels.reader();
-       for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
-               if (Config->get_monitoring_model() == HardwareMonitoring) {
+       if (Config->get_monitoring_model() == HardwareMonitoring) {
+               for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
                        if ((*chan)->source) {
                                (*chan)->source->ensure_monitor_input (false);
                        }
@@ -1795,8 +1891,8 @@ AudioDiskstream::get_state ()
 
                Location* pi;
 
-               if (Config->get_punch_in() && ((pi = _session.locations()->auto_punch_location()) != 0)) {
-                       snprintf (buf, sizeof (buf), "%" PRIu32, pi->start());
+               if (_session.config.get_punch_in() && ((pi = _session.locations()->auto_punch_location()) != 0)) {
+                       snprintf (buf, sizeof (buf), "%" PRId64, pi->start());
                } else {
                        snprintf (buf, sizeof (buf), "%" PRIu32, _session.transport_frame());
                }
@@ -1863,15 +1959,16 @@ AudioDiskstream::set_state (const XMLNode& node)
        // create necessary extra channels
        // we are always constructed with one and we always need one
 
-       _n_channels = channels.reader()->size();
+       _n_channels.set(DataType::AUDIO, channels.reader()->size());
        
-       if (nchans > _n_channels) {
+       if (nchans > _n_channels.n_audio()) {
 
-               add_channel (nchans - _n_channels);
+               add_channel (nchans - _n_channels.n_audio());
+               IO::PortCountChanged(_n_channels);
 
-       } else if (nchans < _n_channels) {
+       } else if (nchans < _n_channels.n_audio()) {
 
-               remove_channel (_n_channels - nchans);
+               remove_channel (_n_channels.n_audio() - nchans);
        }
 
        if ((prop = node.property ("playlist")) == 0) {
@@ -1917,8 +2014,6 @@ AudioDiskstream::set_state (const XMLNode& node)
           up of the IO that owns this DS (::non_realtime_input_change())
        */
                
-       in_set_state = false;
-
        return 0;
 }
 
@@ -1964,7 +2059,7 @@ AudioDiskstream::use_new_write_source (uint32_t n)
 }
 
 void
-AudioDiskstream::reset_write_sources (bool mark_write_complete, bool force)
+AudioDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
 {
        ChannelList::iterator chan;
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -2016,7 +2111,7 @@ AudioDiskstream::rename_write_sources ()
 
        for (chan = c->begin(), n = 0; chan != c->end(); ++chan, ++n) {
                if ((*chan)->write_source != 0) {
-                       (*chan)->write_source->set_name (_name, destructive());
+                       (*chan)->write_source->set_source_name (_name, destructive());
                        /* XXX what to do if one of them fails ? */
                }
        }
@@ -2025,14 +2120,15 @@ AudioDiskstream::rename_write_sources ()
 }
 
 void
-AudioDiskstream::set_block_size (nframes_t nframes)
+AudioDiskstream::set_block_size (nframes_t /*nframes*/)
 {
        if (_session.get_block_size() > speed_buffer_size) {
                speed_buffer_size = _session.get_block_size();
                boost::shared_ptr<ChannelList> c = channels.reader();
 
                for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
-                       if ((*chan)->speed_buffer) delete [] (*chan)->speed_buffer;
+                       if ((*chan)->speed_buffer)
+                               delete [] (*chan)->speed_buffer;
                        (*chan)->speed_buffer = new Sample[speed_buffer_size];
                }
        }
@@ -2055,9 +2151,11 @@ AudioDiskstream::allocate_temporary_buffers ()
                boost::shared_ptr<ChannelList> c = channels.reader();
 
                for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
-                       if ((*chan)->playback_wrap_buffer) delete [] (*chan)->playback_wrap_buffer;
+                       if ((*chan)->playback_wrap_buffer)
+                               delete [] (*chan)->playback_wrap_buffer;
                        (*chan)->playback_wrap_buffer = new Sample[required_wrap_size]; 
-                       if ((*chan)->capture_wrap_buffer) delete [] (*chan)->capture_wrap_buffer;
+                       if ((*chan)->capture_wrap_buffer)
+                               delete [] (*chan)->capture_wrap_buffer;
                        (*chan)->capture_wrap_buffer = new Sample[required_wrap_size];  
                }
 
@@ -2108,12 +2206,14 @@ AudioDiskstream::set_align_style_from_io ()
 int
 AudioDiskstream::add_channel_to (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
+
        while (how_many--) {
-               c->push_back (new ChannelInfo(_session.diskstream_buffer_size(), speed_buffer_size, wrap_buffer_size));
+               c->push_back (new ChannelInfo(_session.audio_diskstream_buffer_size(), speed_buffer_size, wrap_buffer_size));
+               interpolation.add_channel_to (_session.audio_diskstream_buffer_size(), speed_buffer_size);
        }
 
-       _n_channels = c->size();
-
+       _n_channels.set(DataType::AUDIO, c->size());
+       
        return 0;
 }
 
@@ -2129,12 +2229,15 @@ AudioDiskstream::add_channel (uint32_t how_many)
 int
 AudioDiskstream::remove_channel_from (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
-       while (--how_many && !c->empty()) {
-               delete c->back();
+       while (how_many-- && !c->empty()) {
+               // FIXME: crash (thread safe with RCU?)
+               // memory leak, when disabled.... :(
+               //delete c->back(); 
                c->pop_back();
+               interpolation.remove_channel_from ();
        }
 
-       _n_channels = c->size();
+       _n_channels.set(DataType::AUDIO, c->size());
 
        return 0;
 }
@@ -2192,8 +2295,17 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
                                continue;
                        }
 
+                       // This protects sessions from errant CapturingSources in stored sessions
+                       struct stat sbuf;
+                       if (stat (prop->value().c_str(), &sbuf)) {
+                               continue;
+                       }
+
                        try {
-                               fs = boost::dynamic_pointer_cast<AudioFileSource> (SourceFactory::createWritable (_session, prop->value(), false, _session.frame_rate()));
+                               fs = boost::dynamic_pointer_cast<AudioFileSource> (
+                                               SourceFactory::createWritable (DataType::AUDIO, _session,
+                                                               prop->value(), true,
+                                                               false, _session.frame_rate()));
                        }
 
                        catch (failed_constructor& err) {
@@ -2218,7 +2330,7 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
                return 1;
        }
 
-       if (pending_sources.size() != _n_channels) {
+       if (pending_sources.size() != _n_channels.n_audio()) {
                error << string_compose (_("%1: incorrect number of pending sources listed - ignoring them all"), _name)
                      << endmsg;
                return -1;
@@ -2227,22 +2339,25 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
        boost::shared_ptr<AudioRegion> region;
        
        try {
-               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (pending_sources, 0, first_fs->length(),
-                                                                                         region_name_from_path (first_fs->name(), true), 
-                                                                                         0, AudioRegion::Flag (AudioRegion::DefaultFlags|AudioRegion::Automatic|AudioRegion::WholeFile)));
+               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (
+                               pending_sources, 0, first_fs->length(first_fs->timeline_position()),
+                               region_name_from_path (first_fs->name(), true), 0,
+                               Region::Flag (Region::DefaultFlags|Region::Automatic|Region::WholeFile)));
                region->special_set_position (0);
        }
 
        catch (failed_constructor& err) {
-               error << string_compose (_("%1: cannot create whole-file region from pending capture sources"),
-                                 _name)
-                     << endmsg;
+               error << string_compose (
+                               _("%1: cannot create whole-file region from pending capture sources"),
+                               _name) << endmsg;
                
                return -1;
        }
 
        try {
-               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (pending_sources, 0, first_fs->length(), region_name_from_path (first_fs->name(), true)));
+               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (
+                               pending_sources, 0, first_fs->length(first_fs->timeline_position()),
+                               region_name_from_path (first_fs->name(), true)));
        }
 
        catch (failed_constructor& err) {
@@ -2258,6 +2373,21 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
        return 0;
 }
 
+int
+AudioDiskstream::set_non_layered (bool yn)
+{
+       if (yn != non_layered()) {
+               
+               if (yn) {
+                       _flags = Flag (_flags | NonLayered);
+               } else {
+                       _flags = Flag (_flags & ~NonLayered);
+               }
+       }
+
+       return 0;
+}
+
 int
 AudioDiskstream::set_destructive (bool yn)
 {
@@ -2339,7 +2469,7 @@ AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_si
 
        playback_buf = new RingBufferNPT<Sample> (bufsize);
        capture_buf = new RingBufferNPT<Sample> (bufsize);
-       capture_transition_buf = new RingBufferNPT<CaptureTransition> (128);
+       capture_transition_buf = new RingBufferNPT<CaptureTransition> (256);
        
        /* touch the ringbuffer buffers, which will cause
           them to be mapped into locked physical RAM if
@@ -2358,33 +2488,21 @@ AudioDiskstream::ChannelInfo::~ChannelInfo ()
                write_source.reset ();
        }
                
-       if (speed_buffer) {
-               delete [] speed_buffer;
-               speed_buffer = 0;
-       }
+       delete [] speed_buffer;
+       speed_buffer = 0;
 
-       if (playback_wrap_buffer) {
-               delete [] playback_wrap_buffer;
-               playback_wrap_buffer = 0;
-       }
+       delete [] playback_wrap_buffer;
+       playback_wrap_buffer = 0;
 
-       if (capture_wrap_buffer) {
-               delete [] capture_wrap_buffer;
-               capture_wrap_buffer = 0;
-       }
+       delete [] capture_wrap_buffer;
+       capture_wrap_buffer = 0;
        
-       if (playback_buf) {
-               delete playback_buf;
-               playback_buf = 0;
-       }
+       delete playback_buf;
+       playback_buf = 0;
 
-       if (capture_buf) {
-               delete capture_buf;
-               capture_buf = 0;
-       }
+       delete capture_buf;
+       capture_buf = 0;
 
-       if (capture_transition_buf) {
-               delete capture_transition_buf;
-               capture_transition_buf = 0;
-       }
+       delete capture_transition_buf;
+       capture_transition_buf = 0;
 }