make note overlap resolution store side effects in a DiffCommand, and add its changes...
[ardour.git] / libs / ardour / audio_diskstream.cc
index f60d16391f3e6ced7fbf02f86f1c39d014c9a012..b3204c38b66d67a81c74964192b020ffa547f5fe 100644 (file)
@@ -35,7 +35,7 @@
 #include "pbd/xml++.h"
 #include "pbd/memento_command.h"
 #include "pbd/enumwriter.h"
-#include "pbd/stacktrace.h"
+#include "pbd/stateful_diff_command.h"
 
 #include "ardour/analyser.h"
 #include "ardour/ardour.h"
@@ -44,6 +44,7 @@
 #include "ardour/audio_port.h"
 #include "ardour/audioengine.h"
 #include "ardour/audiofilesource.h"
+
 #include "ardour/audioplaylist.h"
 #include "ardour/audioregion.h"
 #include "ardour/butler.h"
@@ -58,6 +59,7 @@
 #include "ardour/source_factory.h"
 #include "ardour/utils.h"
 #include "ardour/session_playlists.h"
+#include "ardour/route.h"
 
 #include "i18n.h"
 #include <locale.h>
@@ -78,10 +80,7 @@ AudioDiskstream::AudioDiskstream (Session &sess, const string &name, Diskstream:
        /* prevent any write sources from being created */
 
        in_set_state = true;
-
-       init(flag);
        use_new_playlist ();
-
        in_set_state = false;
 }
 
@@ -91,7 +90,7 @@ AudioDiskstream::AudioDiskstream (Session& sess, const XMLNode& node)
        , channels (new ChannelList)
 {
        in_set_state = true;
-       init (Recordable);
+       init ();
 
        if (set_state (node, Stateful::loading_state_version)) {
                in_set_state = false;
@@ -106,10 +105,8 @@ AudioDiskstream::AudioDiskstream (Session& sess, const XMLNode& node)
 }
 
 void
-AudioDiskstream::init (Diskstream::Flag f)
+AudioDiskstream::init ()
 {
-       Diskstream::init(f);
-
        /* there are no channels at this point, so these
           two calls just get speed_buffer_size and wrap_buffer
           size setup without duplicating their code.
@@ -138,6 +135,8 @@ AudioDiskstream::~AudioDiskstream ()
        }
 
        channels.flush ();
+
+       delete deprecated_io_node;
 }
 
 void
@@ -323,7 +322,7 @@ AudioDiskstream::use_copy_playlist ()
 
        newname = Playlist::bump_name (_playlist->name(), _session);
 
-       if ((playlist  = boost::dynamic_pointer_cast<AudioPlaylist>(PlaylistFactory::create (audio_playlist(), newname))) != 0) {
+       if ((playlist = boost::dynamic_pointer_cast<AudioPlaylist>(PlaylistFactory::create (audio_playlist(), newname))) != 0) {
                playlist->set_orig_diskstream_id (id());
                return use_playlist (playlist);
        } else {
@@ -343,7 +342,14 @@ AudioDiskstream::setup_destructive_playlist ()
 
        /* a single full-sized region */
 
-       boost::shared_ptr<Region> region (RegionFactory::create (srcs, 0, max_frames - srcs.front()->natural_position(), _name));
+       assert (!srcs.empty ());
+
+       PropertyList plist;
+       plist.add (Properties::name, _name.val());
+       plist.add (Properties::start, 0);
+       plist.add (Properties::length, max_frames - max_frames - srcs.front()->natural_position());
+
+       boost::shared_ptr<Region> region (RegionFactory::create (srcs, plist));
        _playlist->add_region (region, srcs.front()->natural_position());
 }
 
@@ -415,7 +421,7 @@ AudioDiskstream::prepare_record_status(nframes_t capture_start_frame)
 }
 
 int
-AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input)
+AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input, bool& need_butler)
 {
        uint32_t n;
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -423,48 +429,26 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
        int ret = -1;
        nframes_t rec_offset = 0;
        nframes_t rec_nframes = 0;
-       bool nominally_recording;
-       bool re = record_enabled ();
        bool collect_playback = false;
 
-       /* if we've already processed the frames corresponding to this call,
-          just return. this allows multiple routes that are taking input
-          from this diskstream to call our ::process() method, but have
-          this stuff only happen once. more commonly, it allows both
-          the AudioTrack that is using this AudioDiskstream *and* the Session
-          to call process() without problems.
-       */
-
-       if (_processed) {
-               return 0;
-       }
-
-       commit_should_unlock = false;
+        playback_distance = 0;
 
        if (!_io || !_io->active()) {
-               _processed = true;
                return 0;
        }
 
        check_record_status (transport_frame, nframes, can_record);
 
-       nominally_recording = (can_record && re);
-
        if (nframes == 0) {
-               _processed = true;
                return 0;
        }
 
-       /* This lock is held until the end of AudioDiskstream::commit, so these two functions
-          must always be called as a pair. The only exception is if this function
-          returns a non-zero value, in which case, ::commit should not be called.
-       */
+        Glib::Mutex::Lock sm (state_lock, Glib::TRY_LOCK);
 
-       // If we can't take the state lock return.
-       if (!state_lock.trylock()) {
+        if (!sm.locked()) {
                return 1;
        }
-       commit_should_unlock = true;
+
        adjust_capture_position = 0;
 
        for (chan = c->begin(); chan != c->end(); ++chan) {
@@ -472,28 +456,35 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                (*chan)->current_playback_buffer = 0;
        }
 
-       if (nominally_recording || (_session.get_record_enabled() && _session.config.get_punch_in())) {
-               // Safeguard against situations where process() goes haywire when autopunching and last_recordable_frame < first_recordable_frame
-               if (last_recordable_frame < first_recordable_frame) {
-                       last_recordable_frame = max_frames;
-               }
-
-               OverlapType ot = coverage (first_recordable_frame, last_recordable_frame, transport_frame, transport_frame + nframes);
+        /* two conditions to test for here:
+           
+           A: this track is rec-enabled, and the session has confirmed that we can record
+           B: this track is rec-enabled, has been recording, and we are set up for auto-punch-in
 
-               calculate_record_range(ot, transport_frame, nframes, rec_nframes, rec_offset);
+           The second test is necessary to capture the extra material that arrives AFTER the transport
+           frame has left the punch range (which will cause the "can_record" argument to be false).
+        */
 
-               if (rec_nframes && !was_recording) {
-                       capture_captured = 0;
-                       was_recording = true;
-               }
-       }
 
+        // Safeguard against situations where process() goes haywire when autopunching and last_recordable_frame < first_recordable_frame
+        if (last_recordable_frame < first_recordable_frame) {
+                last_recordable_frame = max_frames;
+        }
+        
+        OverlapType ot = coverage (first_recordable_frame, last_recordable_frame, transport_frame, transport_frame + nframes);
+        
+        calculate_record_range (ot, transport_frame, nframes, rec_nframes, rec_offset);
+        
+        if (rec_nframes && !was_recording) {
+                capture_captured = 0;
+                was_recording = true;
+        }
 
        if (can_record && !_last_capture_regions.empty()) {
                _last_capture_regions.clear ();
        }
 
-       if (nominally_recording || rec_nframes) {
+       if (rec_nframes) {
 
                uint32_t limit = _io->n_ports ().n_audio();
 
@@ -521,7 +512,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                                AudioPort* const ap = _io->audio (n);
                                assert(ap);
                                assert(rec_nframes <= ap->get_audio_buffer(nframes).capacity());
-                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (rec_nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
+                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
 
 
                        } else {
@@ -581,7 +572,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
 
                adjust_capture_position = rec_nframes;
 
-       } else if (nominally_recording) {
+       } else if (can_record && record_enabled()) {
 
                /* can't do actual capture yet - waiting for latency effects to finish before we start*/
 
@@ -656,23 +647,15 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
 
                _speed = _target_speed;
 
-       }
+       } 
 
        ret = 0;
 
-  out:
-       _processed = true;
-
-       if (ret) {
-
-               /* we're exiting with failure, so ::commit will not
-                  be called. unlock the state lock.
-               */
-
-               commit_should_unlock = false;
-               state_lock.unlock();
-       }
+        if (commit (nframes)) {
+                need_butler = true;
+        }
 
+  out:
        return ret;
 }
 
@@ -695,7 +678,7 @@ AudioDiskstream::process_varispeed_playback(nframes_t nframes, boost::shared_ptr
 }
 
 bool
-AudioDiskstream::commit (nframes_t /*nframes*/)
+AudioDiskstream::commit (nframes_t /* nframes */)
 {
        bool need_butler = false;
 
@@ -739,12 +722,6 @@ AudioDiskstream::commit (nframes_t /*nframes*/)
                }
        }
 
-       if (commit_should_unlock) {
-               state_lock.unlock();
-       }
-
-       _processed = false;
-
        return need_butler;
 }
 
@@ -753,7 +730,7 @@ AudioDiskstream::set_pending_overwrite (bool yn)
 {
        /* called from audio thread, so we can use the read ptr and playback sample as we wish */
 
-       pending_overwrite = yn;
+       _pending_overwrite = yn;
 
        overwrite_frame = playback_sample;
        overwrite_offset = channels.reader()->front()->playback_buf->get_read_ptr();
@@ -822,7 +799,7 @@ AudioDiskstream::overwrite_existing_buffers ()
        ret = 0;
 
   out:
-       pending_overwrite = false;
+       _pending_overwrite = false;
        delete [] gain_buffer;
        delete [] mixdown_buffer;
        return ret;
@@ -899,7 +876,6 @@ AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
        bool reloop = false;
        nframes_t loop_end = 0;
        nframes_t loop_start = 0;
-       nframes_t loop_length = 0;
        nframes_t offset = 0;
        Location *loc = 0;
 
@@ -907,6 +883,8 @@ AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
 
        if (!reversed) {
 
+               nframes_t loop_length = 0;
+
                /* Make the use of a Location atomic for this read operation.
 
                   Note: Locations don't get deleted, so all we care about
@@ -1357,7 +1335,7 @@ AudioDiskstream::do_flush (RunContext /*context*/, bool force_flush)
 }
 
 void
-AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_capture)
+AudioDiskstream::transport_stopped_wallclock (struct tm& when, time_t twhen, bool abort_capture)
 {
        uint32_t buffer_position;
        bool more_work = true;
@@ -1432,7 +1410,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                if (s) {
                        srcs.push_back (s);
                        s->update_header (capture_info.front()->start, when, twhen);
-                       s->set_captured_for (_name);
+                       s->set_captured_for (_name.val());
                        s->mark_immutable ();
                        if (Config->get_auto_analyse_audio()) {
                                Analyser::queue_source_for_analysis (s, true);
@@ -1450,7 +1428,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                   process. this problem is deferred to the UI.
                 */
 
-               _playlist->Modified();
+               _playlist->LayeringChanged(); // XXX this may not get the UI to do the right thing
 
        } else {
 
@@ -1464,10 +1442,15 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                */
 
                try {
-                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs,
-                                               c->front()->write_source->last_capture_start_frame(), total_capture,
-                                               whole_file_region_name, 0,
-                                               Region::Flag (Region::DefaultFlags|Region::Automatic|Region::WholeFile)));
+                       PropertyList plist;
+
+                       plist.add (Properties::start, c->front()->write_source->last_capture_start_frame());
+                       plist.add (Properties::length, total_capture);
+                       plist.add (Properties::name, whole_file_region_name);
+
+                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
+                       rx->set_automatic (true);
+                       rx->set_whole_file (true);
 
                        region = boost::dynamic_pointer_cast<AudioRegion> (rx);
                        region->special_set_position (capture_info.front()->start);
@@ -1483,19 +1466,26 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 
                // cerr << _name << ": there are " << capture_info.size() << " capture_info records\n";
 
-               XMLNode &before = _playlist->get_state();
+                _playlist->clear_history ();
                _playlist->freeze ();
 
                for (buffer_position = c->front()->write_source->last_capture_start_frame(), ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
 
                        string region_name;
 
-                       _session.region_name (region_name, whole_file_region_name, false);
+                       RegionFactory::region_name (region_name, whole_file_region_name, false);
 
                        // cerr << _name << ": based on ci of " << (*ci)->start << " for " << (*ci)->frames << " add region " << region_name << endl;
 
                        try {
-                               boost::shared_ptr<Region> rx (RegionFactory::create (srcs, buffer_position, (*ci)->frames, region_name));
+
+                               PropertyList plist;
+                               
+                               plist.add (Properties::start, buffer_position);
+                               plist.add (Properties::length, (*ci)->frames);
+                               plist.add (Properties::name, region_name);
+                               
+                               boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
                                region = boost::dynamic_pointer_cast<AudioRegion> (rx);
                        }
 
@@ -1504,7 +1494,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                                continue; /* XXX is this OK? */
                        }
 
-                       region->GoingAway.connect (*this, boost::bind (&Diskstream::remove_region_from_last_capture, this, boost::weak_ptr<Region>(region)));
+                       region->DropReferences.connect_same_thread (*this, boost::bind (&Diskstream::remove_region_from_last_capture, this, boost::weak_ptr<Region>(region)));
 
                        _last_capture_regions.push_back (region);
 
@@ -1516,8 +1506,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                }
 
                _playlist->thaw ();
-               XMLNode &after = _playlist->get_state();
-               _session.add_command (new MementoCommand<Playlist>(*_playlist, &before, &after));
+               _session.add_command (new StatefulDiffCommand (_playlist));
        }
 
        mark_write_completed = true;
@@ -1590,6 +1579,8 @@ void
 AudioDiskstream::finish_capture (bool /*rec_monitors_input*/, boost::shared_ptr<ChannelList> c)
 {
        was_recording = false;
+        first_recordable_frame = max_frames;
+        last_recordable_frame = max_frames;
 
        if (capture_captured == 0) {
                return;
@@ -1711,7 +1702,7 @@ AudioDiskstream::disengage_record_enable ()
 XMLNode&
 AudioDiskstream::get_state ()
 {
-       XMLNode* node = new XMLNode ("AudioDiskstream");
+       XMLNode* node = new XMLNode ("Diskstream");
        char buf[64] = "";
        LocaleGuard lg (X_("POSIX"));
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -1837,7 +1828,7 @@ AudioDiskstream::set_state (const XMLNode& node, int /*version*/)
                }
 
                if (!had_playlist) {
-                       _playlist->set_orig_diskstream_id (_id);
+                       _playlist->set_orig_diskstream_id (id());
                }
 
                if (!destructive() && capture_pending_node) {
@@ -1894,7 +1885,7 @@ AudioDiskstream::use_new_write_source (uint32_t n)
        }
 
        try {
-               if ((chan->write_source = _session.create_audio_source_for_session (*this, n, destructive())) == 0) {
+               if ((chan->write_source = _session.create_audio_source_for_session (n_channels().n_audio(), name(), n, destructive())) == 0) {
                        throw failed_constructor();
                }
        }
@@ -1948,7 +1939,7 @@ AudioDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
                }
        }
 
-       if (destructive()) {
+       if (destructive() && !c->empty ()) {
 
                /* we now have all our write sources set up, so create the
                   playlist's single region.
@@ -1969,7 +1960,7 @@ AudioDiskstream::rename_write_sources ()
 
        for (chan = c->begin(), n = 0; chan != c->end(); ++chan, ++n) {
                if ((*chan)->write_source != 0) {
-                       (*chan)->write_source->set_source_name (_name, destructive());
+                       (*chan)->write_source->set_source_name (_name.val(), destructive());
                        /* XXX what to do if one of them fails ? */
                }
        }
@@ -2001,7 +1992,7 @@ AudioDiskstream::allocate_temporary_buffers ()
           when slaving to MTC, Timecode etc.
        */
 
-       double sp = max (fabsf (_actual_speed), 1.2f);
+       double const sp = max (fabsf (_actual_speed), 1.2f);
        nframes_t required_wrap_size = (nframes_t) floor (_session.get_block_size() * sp) + 1;
 
        if (required_wrap_size > wrap_buffer_size) {
@@ -2065,8 +2056,10 @@ int
 AudioDiskstream::add_channel_to (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
        while (how_many--) {
-               c->push_back (new ChannelInfo(_session.butler()->audio_diskstream_buffer_size(), speed_buffer_size, wrap_buffer_size));
-               interpolation.add_channel_to (_session.butler()->audio_diskstream_buffer_size(), speed_buffer_size);
+               c->push_back (new ChannelInfo(_session.butler()->audio_diskstream_playback_buffer_size(), 
+                                              _session.butler()->audio_diskstream_capture_buffer_size(),
+                                              speed_buffer_size, wrap_buffer_size));
+               interpolation.add_channel_to (_session.butler()->audio_diskstream_playback_buffer_size(), speed_buffer_size);
        }
 
        _n_channels.set(DataType::AUDIO, c->size());
@@ -2087,9 +2080,7 @@ int
 AudioDiskstream::remove_channel_from (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
        while (how_many-- && !c->empty()) {
-               // FIXME: crash (thread safe with RCU?)
-               // memory leak, when disabled.... :(
-               //delete c->back();
+               delete c->back();
                c->pop_back();
                interpolation.remove_channel_from ();
        }
@@ -2177,7 +2168,7 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
                                first_fs = fs;
                        }
 
-                       fs->set_captured_for (_name);
+                       fs->set_captured_for (_name.val());
                }
        }
 
@@ -2195,10 +2186,17 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
        boost::shared_ptr<AudioRegion> region;
 
        try {
-               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (
-                               pending_sources, 0, first_fs->length(first_fs->timeline_position()),
-                               region_name_from_path (first_fs->name(), true), 0,
-                               Region::Flag (Region::DefaultFlags|Region::Automatic|Region::WholeFile)));
+               
+               PropertyList plist;
+               
+               plist.add (Properties::start, 0);
+               plist.add (Properties::length, first_fs->length (first_fs->timeline_position()));
+               plist.add (Properties::name, region_name_from_path (first_fs->name(), true));
+
+               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (pending_sources, plist));
+
+               region->set_automatic (true);
+               region->set_whole_file (true);
                region->special_set_position (0);
        }
 
@@ -2210,20 +2208,6 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
                return -1;
        }
 
-       try {
-               region = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (
-                               pending_sources, 0, first_fs->length(first_fs->timeline_position()),
-                               region_name_from_path (first_fs->name(), true)));
-       }
-
-       catch (failed_constructor& err) {
-               error << string_compose (_("%1: cannot create region from pending capture sources"),
-                                 _name)
-                     << endmsg;
-
-               return -1;
-       }
-
        _playlist->add_region (region, position);
 
        return 0;
@@ -2247,11 +2231,10 @@ AudioDiskstream::set_non_layered (bool yn)
 int
 AudioDiskstream::set_destructive (bool yn)
 {
-       bool bounce_ignored;
-
        if (yn != destructive()) {
 
                if (yn) {
+                       bool bounce_ignored;
                        /* requestor should already have checked this and
                           bounced if necessary and desired
                        */
@@ -2285,7 +2268,10 @@ AudioDiskstream::can_become_destructive (bool& requires_bounce) const
        }
 
        boost::shared_ptr<Region> first = _playlist->find_next_region (_session.current_start_frame(), Start, 1);
-       assert (first);
+       if (!first) {
+               requires_bounce = false;
+               return true;
+       }
 
        /* do the source(s) for the region cover the session start position ? */
 
@@ -2311,7 +2297,27 @@ AudioDiskstream::can_become_destructive (bool& requires_bounce) const
        return true;
 }
 
-AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_size, nframes_t wrap_size)
+void 
+AudioDiskstream::adjust_playback_buffering ()
+{
+       boost::shared_ptr<ChannelList> c = channels.reader();
+
+       for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
+                (*chan)->resize_playback (_session.butler()->audio_diskstream_playback_buffer_size());
+        }
+}
+
+void 
+AudioDiskstream::adjust_capture_buffering ()
+{
+       boost::shared_ptr<ChannelList> c = channels.reader();
+
+       for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
+                (*chan)->resize_capture (_session.butler()->audio_diskstream_capture_buffer_size());
+        }
+}
+
+AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t playback_bufsize, nframes_t capture_bufsize, nframes_t speed_size, nframes_t wrap_size)
 {
        peak_power = 0.0f;
        source = 0;
@@ -2323,8 +2329,8 @@ AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_si
        playback_wrap_buffer = new Sample[wrap_size];
        capture_wrap_buffer = new Sample[wrap_size];
 
-       playback_buf = new RingBufferNPT<Sample> (bufsize);
-       capture_buf = new RingBufferNPT<Sample> (bufsize);
+       playback_buf = new RingBufferNPT<Sample> (playback_bufsize);
+       capture_buf = new RingBufferNPT<Sample> (capture_bufsize);
        capture_transition_buf = new RingBufferNPT<CaptureTransition> (256);
 
        /* touch the ringbuffer buffers, which will cause
@@ -2338,11 +2344,25 @@ AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_si
        memset (capture_transition_buf->buffer(), 0, sizeof (CaptureTransition) * capture_transition_buf->bufsize());
 }
 
+void
+AudioDiskstream::ChannelInfo::resize_playback (nframes_t playback_bufsize)
+{
+        delete playback_buf;
+       playback_buf = new RingBufferNPT<Sample> (playback_bufsize);
+       memset (playback_buf->buffer(), 0, sizeof (Sample) * playback_buf->bufsize());
+}
+
+void
+AudioDiskstream::ChannelInfo::resize_capture (nframes_t capture_bufsize)
+{
+        delete capture_buf;
+       capture_buf = new RingBufferNPT<Sample> (capture_bufsize);
+       memset (capture_buf->buffer(), 0, sizeof (Sample) * capture_buf->bufsize());
+}
+
 AudioDiskstream::ChannelInfo::~ChannelInfo ()
 {
-       if (write_source) {
-               write_source.reset ();
-       }
+        write_source.reset ();
 
        delete [] speed_buffer;
        speed_buffer = 0;
@@ -2362,3 +2382,4 @@ AudioDiskstream::ChannelInfo::~ChannelInfo ()
        delete capture_transition_buf;
        capture_transition_buf = 0;
 }
+