Stop spurious regions being added to tracks when chasing MTC.
[ardour.git] / libs / ardour / audio_diskstream.cc
index f7a1240bddf7a69990ecb37db6eb668e1f703b96..b994c5e3e2ff52b1a92a3e67bdf709edad6105a0 100644 (file)
@@ -35,7 +35,7 @@
 #include "pbd/xml++.h"
 #include "pbd/memento_command.h"
 #include "pbd/enumwriter.h"
-#include "pbd/stacktrace.h"
+#include "pbd/stateful_diff_command.h"
 
 #include "ardour/analyser.h"
 #include "ardour/ardour.h"
@@ -59,6 +59,7 @@
 #include "ardour/source_factory.h"
 #include "ardour/utils.h"
 #include "ardour/session_playlists.h"
+#include "ardour/route.h"
 
 #include "i18n.h"
 #include <locale.h>
@@ -79,10 +80,7 @@ AudioDiskstream::AudioDiskstream (Session &sess, const string &name, Diskstream:
        /* prevent any write sources from being created */
 
        in_set_state = true;
-
-       init(flag);
        use_new_playlist ();
-
        in_set_state = false;
 }
 
@@ -92,7 +90,7 @@ AudioDiskstream::AudioDiskstream (Session& sess, const XMLNode& node)
        , channels (new ChannelList)
 {
        in_set_state = true;
-       init (Recordable);
+       init ();
 
        if (set_state (node, Stateful::loading_state_version)) {
                in_set_state = false;
@@ -107,10 +105,8 @@ AudioDiskstream::AudioDiskstream (Session& sess, const XMLNode& node)
 }
 
 void
-AudioDiskstream::init (Diskstream::Flag f)
+AudioDiskstream::init ()
 {
-       Diskstream::init(f);
-
        /* there are no channels at this point, so these
           two calls just get speed_buffer_size and wrap_buffer
           size setup without duplicating their code.
@@ -169,7 +165,7 @@ AudioDiskstream::non_realtime_input_change ()
        {
                Glib::Mutex::Lock lm (state_lock);
 
-               if (input_change_pending == NoChange) {
+               if (input_change_pending.type == IOChange::NoChange) {
                        return;
                }
 
@@ -196,7 +192,7 @@ AudioDiskstream::non_realtime_input_change ()
                        set_align_style_from_io ();
                }
 
-               input_change_pending = NoChange;
+               input_change_pending = IOChange::NoChange;
 
                /* implicit unlock */
        }
@@ -208,19 +204,19 @@ AudioDiskstream::non_realtime_input_change ()
        /* now refill channel buffers */
 
        if (speed() != 1.0f || speed() != -1.0f) {
-               seek ((nframes_t) (_session.transport_frame() * (double) speed()));
+               seek ((framepos_t) (_session.transport_frame() * (double) speed()));
        } else {
                seek (_session.transport_frame());
        }
 }
 
 void
-AudioDiskstream::non_realtime_locate (nframes_t location)
+AudioDiskstream::non_realtime_locate (framepos_t location)
 {
        /* now refill channel buffers */
 
        if (speed() != 1.0f || speed() != -1.0f) {
-               seek ((nframes_t) (location * (double) speed()));
+               seek ((framepos_t) (location * (double) speed()));
        } else {
                seek (location);
        }
@@ -326,7 +322,7 @@ AudioDiskstream::use_copy_playlist ()
 
        newname = Playlist::bump_name (_playlist->name(), _session);
 
-       if ((playlist  = boost::dynamic_pointer_cast<AudioPlaylist>(PlaylistFactory::create (audio_playlist(), newname))) != 0) {
+       if ((playlist = boost::dynamic_pointer_cast<AudioPlaylist>(PlaylistFactory::create (audio_playlist(), newname))) != 0) {
                playlist->set_orig_diskstream_id (id());
                return use_playlist (playlist);
        } else {
@@ -346,10 +342,12 @@ AudioDiskstream::setup_destructive_playlist ()
 
        /* a single full-sized region */
 
+       assert (!srcs.empty ());
+
        PropertyList plist;
        plist.add (Properties::name, _name.val());
        plist.add (Properties::start, 0);
-       plist.add (Properties::length, max_frames - max_frames - srcs.front()->natural_position());
+       plist.add (Properties::length, max_framepos - (max_framepos - srcs.front()->natural_position()));
 
        boost::shared_ptr<Region> region (RegionFactory::create (srcs, plist));
        _playlist->add_region (region, srcs.front()->natural_position());
@@ -379,7 +377,7 @@ AudioDiskstream::use_destructive_playlist ()
 
        /* be sure to stretch the region out to the maximum length */
 
-       region->set_length (max_frames - region->position(), this);
+       region->set_length (max_framepos - region->position(), this);
 
        uint32_t n;
        ChannelList::iterator chan;
@@ -399,7 +397,7 @@ AudioDiskstream::use_destructive_playlist ()
 }
 
 void
-AudioDiskstream::prepare_record_status(nframes_t capture_start_frame)
+AudioDiskstream::prepare_record_status(framepos_t capture_start_frame)
 {
        if (recordable() && destructive()) {
                boost::shared_ptr<ChannelList> c = channels.reader();
@@ -423,7 +421,7 @@ AudioDiskstream::prepare_record_status(nframes_t capture_start_frame)
 }
 
 int
-AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input)
+AudioDiskstream::process (framepos_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input, bool& need_butler)
 {
        uint32_t n;
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -431,48 +429,26 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
        int ret = -1;
        nframes_t rec_offset = 0;
        nframes_t rec_nframes = 0;
-       bool nominally_recording;
-       bool re = record_enabled ();
        bool collect_playback = false;
 
-       /* if we've already processed the frames corresponding to this call,
-          just return. this allows multiple routes that are taking input
-          from this diskstream to call our ::process() method, but have
-          this stuff only happen once. more commonly, it allows both
-          the AudioTrack that is using this AudioDiskstream *and* the Session
-          to call process() without problems.
-       */
-
-       if (_processed) {
-               return 0;
-       }
-
-       commit_should_unlock = false;
+        playback_distance = 0;
 
        if (!_io || !_io->active()) {
-               _processed = true;
                return 0;
        }
 
-       check_record_status (transport_frame, nframes, can_record);
-
-       nominally_recording = (can_record && re);
+       check_record_status (transport_frame, can_record);
 
        if (nframes == 0) {
-               _processed = true;
                return 0;
        }
 
-       /* This lock is held until the end of AudioDiskstream::commit, so these two functions
-          must always be called as a pair. The only exception is if this function
-          returns a non-zero value, in which case, ::commit should not be called.
-       */
+        Glib::Mutex::Lock sm (state_lock, Glib::TRY_LOCK);
 
-       // If we can't take the state lock return.
-       if (!state_lock.trylock()) {
+        if (!sm.locked()) {
                return 1;
        }
-       commit_should_unlock = true;
+
        adjust_capture_position = 0;
 
        for (chan = c->begin(); chan != c->end(); ++chan) {
@@ -480,28 +456,37 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                (*chan)->current_playback_buffer = 0;
        }
 
-       if (nominally_recording || (_session.get_record_enabled() && _session.config.get_punch_in())) {
-               // Safeguard against situations where process() goes haywire when autopunching and last_recordable_frame < first_recordable_frame
-               if (last_recordable_frame < first_recordable_frame) {
-                       last_recordable_frame = max_frames;
-               }
+        /* two conditions to test for here:
+           
+           A: this track is rec-enabled, and the session has confirmed that we can record
+           B: this track is rec-enabled, has been recording, and we are set up for auto-punch-in
 
-               OverlapType ot = coverage (first_recordable_frame, last_recordable_frame, transport_frame, transport_frame + nframes);
+           The second test is necessary to capture the extra material that arrives AFTER the transport
+           frame has left the punch range (which will cause the "can_record" argument to be false).
+        */
 
-               calculate_record_range(ot, transport_frame, nframes, rec_nframes, rec_offset);
 
-               if (rec_nframes && !was_recording) {
-                       capture_captured = 0;
-                       was_recording = true;
-               }
-       }
+        // Safeguard against situations where process() goes haywire when autopunching 
+        // and last_recordable_frame < first_recordable_frame
 
+        if (last_recordable_frame < first_recordable_frame) {
+                last_recordable_frame = max_framepos;
+        }
+        
+        OverlapType ot = coverage (first_recordable_frame, last_recordable_frame, transport_frame, transport_frame + nframes);
 
-       if (can_record && !_last_capture_regions.empty()) {
-               _last_capture_regions.clear ();
+        calculate_record_range (ot, transport_frame, nframes, rec_nframes, rec_offset);
+        
+        if (rec_nframes && !was_recording) {
+                capture_captured = 0;
+                was_recording = true;
+        }
+
+       if (can_record && !_last_capture_sources.empty()) {
+               _last_capture_sources.clear ();
        }
 
-       if (nominally_recording || rec_nframes) {
+       if (rec_nframes) {
 
                uint32_t limit = _io->n_ports ().n_audio();
 
@@ -529,7 +514,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
                                AudioPort* const ap = _io->audio (n);
                                assert(ap);
                                assert(rec_nframes <= ap->get_audio_buffer(nframes).capacity());
-                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (rec_nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
+                               memcpy (chaninfo->current_capture_buffer, ap->get_audio_buffer (nframes).data(rec_offset), sizeof (Sample) * rec_nframes);
 
 
                        } else {
@@ -589,7 +574,7 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
 
                adjust_capture_position = rec_nframes;
 
-       } else if (nominally_recording) {
+       } else if (can_record && record_enabled()) {
 
                /* can't do actual capture yet - waiting for latency effects to finish before we start*/
 
@@ -664,23 +649,15 @@ AudioDiskstream::process (nframes_t transport_frame, nframes_t nframes, bool can
 
                _speed = _target_speed;
 
-       }
+       } 
 
        ret = 0;
 
-  out:
-       _processed = true;
-
-       if (ret) {
-
-               /* we're exiting with failure, so ::commit will not
-                  be called. unlock the state lock.
-               */
-
-               commit_should_unlock = false;
-               state_lock.unlock();
-       }
+        if (commit (nframes)) {
+                need_butler = true;
+        }
 
+  out:
        return ret;
 }
 
@@ -703,7 +680,7 @@ AudioDiskstream::process_varispeed_playback(nframes_t nframes, boost::shared_ptr
 }
 
 bool
-AudioDiskstream::commit (nframes_t /*nframes*/)
+AudioDiskstream::commit (nframes_t /* nframes */)
 {
        bool need_butler = false;
 
@@ -747,12 +724,6 @@ AudioDiskstream::commit (nframes_t /*nframes*/)
                }
        }
 
-       if (commit_should_unlock) {
-               state_lock.unlock();
-       }
-
-       _processed = false;
-
        return need_butler;
 }
 
@@ -761,7 +732,7 @@ AudioDiskstream::set_pending_overwrite (bool yn)
 {
        /* called from audio thread, so we can use the read ptr and playback sample as we wish */
 
-       pending_overwrite = yn;
+       _pending_overwrite = yn;
 
        overwrite_frame = playback_sample;
        overwrite_offset = channels.reader()->front()->playback_buf->get_read_ptr();
@@ -788,7 +759,7 @@ AudioDiskstream::overwrite_existing_buffers ()
        size--;
 
        uint32_t n=0;
-       nframes_t start;
+       framepos_t start;
 
        for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan, ++n) {
 
@@ -830,14 +801,14 @@ AudioDiskstream::overwrite_existing_buffers ()
        ret = 0;
 
   out:
-       pending_overwrite = false;
+       _pending_overwrite = false;
        delete [] gain_buffer;
        delete [] mixdown_buffer;
        return ret;
 }
 
 int
-AudioDiskstream::seek (nframes_t frame, bool complete_refill)
+AudioDiskstream::seek (framepos_t frame, bool complete_refill)
 {
        uint32_t n;
        int ret = -1;
@@ -870,13 +841,13 @@ AudioDiskstream::seek (nframes_t frame, bool complete_refill)
 }
 
 int
-AudioDiskstream::can_internal_playback_seek (nframes_t distance)
+AudioDiskstream::can_internal_playback_seek (framecnt_t distance)
 {
        ChannelList::iterator chan;
        boost::shared_ptr<ChannelList> c = channels.reader();
 
        for (chan = c->begin(); chan != c->end(); ++chan) {
-               if ((*chan)->playback_buf->read_space() < distance) {
+               if ((*chan)->playback_buf->read_space() < (size_t) distance) {
                        return false;
                }
        }
@@ -884,7 +855,7 @@ AudioDiskstream::can_internal_playback_seek (nframes_t distance)
 }
 
 int
-AudioDiskstream::internal_playback_seek (nframes_t distance)
+AudioDiskstream::internal_playback_seek (framecnt_t distance)
 {
        ChannelList::iterator chan;
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -893,20 +864,23 @@ AudioDiskstream::internal_playback_seek (nframes_t distance)
                (*chan)->playback_buf->increment_read_ptr (distance);
        }
 
-       first_recordable_frame += distance;
+       if (first_recordable_frame < max_framepos) {
+               first_recordable_frame += distance;
+       }
        playback_sample += distance;
 
        return 0;
 }
 
 int
-AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer, nframes_t& start, nframes_t cnt,
+AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer, 
+                       framepos_t& start, nframes_t cnt,
                       ChannelInfo* /*channel_info*/, int channel, bool reversed)
 {
        nframes_t this_read = 0;
        bool reloop = false;
-       nframes_t loop_end = 0;
-       nframes_t loop_start = 0;
+       framepos_t loop_end = 0;
+       framepos_t loop_start = 0;
        nframes_t offset = 0;
        Location *loc = 0;
 
@@ -914,7 +888,7 @@ AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
 
        if (!reversed) {
 
-               nframes_t loop_length = 0;
+               framecnt_t loop_length = 0;
 
                /* Make the use of a Location atomic for this read operation.
 
@@ -1111,7 +1085,7 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer)
 
        } else {
 
-               if (file_frame == max_frames) {
+               if (file_frame == max_framepos) {
 
                        /* at end: nothing to do but fill with silence */
 
@@ -1128,19 +1102,19 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer)
                        return 0;
                }
 
-               if (file_frame > max_frames - total_space) {
+               if (file_frame > max_framepos - total_space) {
 
                        /* to close to the end: read what we can, and zero fill the rest */
 
-                       zero_fill = total_space - (max_frames - file_frame);
-                       total_space = max_frames - file_frame;
+                       zero_fill = total_space - (max_framepos - file_frame);
+                       total_space = max_framepos - file_frame;
 
                } else {
                        zero_fill = 0;
                }
        }
 
-       nframes_t file_frame_tmp = 0;
+       framepos_t file_frame_tmp = 0;
 
        for (chan_n = 0, i = c->begin(); i != c->end(); ++i, ++chan_n) {
 
@@ -1366,7 +1340,7 @@ AudioDiskstream::do_flush (RunContext /*context*/, bool force_flush)
 }
 
 void
-AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_capture)
+AudioDiskstream::transport_stopped_wallclock (struct tm& when, time_t twhen, bool abort_capture)
 {
        uint32_t buffer_position;
        bool more_work = true;
@@ -1419,6 +1393,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 
                                (*chan)->write_source->mark_for_remove ();
                                (*chan)->write_source->drop_references ();
+                                _session.remove_source ((*chan)->write_source);
                                (*chan)->write_source.reset ();
                        }
 
@@ -1440,9 +1415,13 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 
                if (s) {
                        srcs.push_back (s);
+                        if (s->unstubify ()) {
+                                error << string_compose (_("Could not move capture file from %1"), s->path()) << endmsg;
+                        }
                        s->update_header (capture_info.front()->start, when, twhen);
                        s->set_captured_for (_name.val());
                        s->mark_immutable ();
+
                        if (Config->get_auto_analyse_audio()) {
                                Analyser::queue_source_for_analysis (s, true);
                        }
@@ -1478,7 +1457,6 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                        plist.add (Properties::start, c->front()->write_source->last_capture_start_frame());
                        plist.add (Properties::length, total_capture);
                        plist.add (Properties::name, whole_file_region_name);
-
                        boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
                        rx->set_automatic (true);
                        rx->set_whole_file (true);
@@ -1493,18 +1471,18 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                        /* XXX what now? */
                }
 
-               _last_capture_regions.push_back (region);
+               _last_capture_sources.insert (_last_capture_sources.end(), srcs.begin(), srcs.end());
 
                // cerr << _name << ": there are " << capture_info.size() << " capture_info records\n";
 
-               XMLNode &before = _playlist->get_state();
+                _playlist->clear_changes ();
                _playlist->freeze ();
 
                for (buffer_position = c->front()->write_source->last_capture_start_frame(), ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
 
                        string region_name;
 
-                       _session.region_name (region_name, whole_file_region_name, false);
+                       RegionFactory::region_name (region_name, whole_file_region_name, false);
 
                        // cerr << _name << ": based on ci of " << (*ci)->start << " for " << (*ci)->frames << " add region " << region_name << endl;
 
@@ -1525,10 +1503,6 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                                continue; /* XXX is this OK? */
                        }
 
-                       region->DropReferences.connect_same_thread (*this, boost::bind (&Diskstream::remove_region_from_last_capture, this, boost::weak_ptr<Region>(region)));
-
-                       _last_capture_regions.push_back (region);
-
                        i_am_the_modifier++;
                        _playlist->add_region (region, (*ci)->start, 1, non_layered());
                        i_am_the_modifier--;
@@ -1537,8 +1511,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
                }
 
                _playlist->thaw ();
-               XMLNode &after = _playlist->get_state();
-               _session.add_command (new MementoCommand<Playlist>(*_playlist, &before, &after));
+               _session.add_command (new StatefulDiffCommand (_playlist));
        }
 
        mark_write_completed = true;
@@ -1557,7 +1530,7 @@ AudioDiskstream::transport_stopped (struct tm& when, time_t twhen, bool abort_ca
 }
 
 void
-AudioDiskstream::transport_looped (nframes_t transport_frame)
+AudioDiskstream::transport_looped (framepos_t transport_frame)
 {
        if (was_recording) {
                // all we need to do is finish this capture, with modified capture length
@@ -1582,7 +1555,7 @@ AudioDiskstream::transport_looped (nframes_t transport_frame)
                // no latency adjustment or capture offset needs to be made, as that already happened the first time
                capture_start_frame = transport_frame;
                first_recordable_frame = transport_frame; // mild lie
-               last_recordable_frame = max_frames;
+               last_recordable_frame = max_framepos;
                was_recording = true;
 
                if (recordable() && destructive()) {
@@ -1611,6 +1584,8 @@ void
 AudioDiskstream::finish_capture (bool /*rec_monitors_input*/, boost::shared_ptr<ChannelList> c)
 {
        was_recording = false;
+        first_recordable_frame = max_framepos;
+        last_recordable_frame = max_framepos;
 
        if (capture_captured == 0) {
                return;
@@ -1655,7 +1630,7 @@ AudioDiskstream::finish_capture (bool /*rec_monitors_input*/, boost::shared_ptr<
        capture_captured = 0;
 
        /* now we've finished a capture, reset first_recordable_frame for next time */
-       first_recordable_frame = max_frames;
+       first_recordable_frame = max_framepos;
 }
 
 void
@@ -1732,7 +1707,7 @@ AudioDiskstream::disengage_record_enable ()
 XMLNode&
 AudioDiskstream::get_state ()
 {
-       XMLNode* node = new XMLNode ("AudioDiskstream");
+       XMLNode* node = new XMLNode ("Diskstream");
        char buf[64] = "";
        LocaleGuard lg (X_("POSIX"));
        boost::shared_ptr<ChannelList> c = channels.reader();
@@ -1858,7 +1833,7 @@ AudioDiskstream::set_state (const XMLNode& node, int /*version*/)
                }
 
                if (!had_playlist) {
-                       _playlist->set_orig_diskstream_id (_id);
+                       _playlist->set_orig_diskstream_id (id());
                }
 
                if (!destructive() && capture_pending_node) {
@@ -1908,14 +1883,14 @@ AudioDiskstream::use_new_write_source (uint32_t n)
 
        ChannelInfo* chan = (*c)[n];
 
-       if (chan->write_source) {
-               chan->write_source->done_with_peakfile_writes ();
-               chan->write_source->set_allow_remove_if_empty (true);
-               chan->write_source.reset ();
-       }
-
        try {
-               if ((chan->write_source = _session.create_audio_source_for_session (*this, n, destructive())) == 0) {
+                /* file starts off as a stub file, it will be converted
+                   when we're done with a capture pass.
+                */
+
+               if ((chan->write_source = _session.create_audio_source_for_session (n_channels().n_audio(), 
+                                                                                    name(), n, destructive(), 
+                                                                                    true)) == 0) {
                        throw failed_constructor();
                }
        }
@@ -1930,13 +1905,17 @@ AudioDiskstream::use_new_write_source (uint32_t n)
 
        chan->write_source->set_allow_remove_if_empty (!destructive());
        
-       /* until we write, this file is considered removable */
-
-       chan->write_source->mark_for_remove ();
-
        return 0;
 }
 
+list<boost::shared_ptr<Source> > 
+AudioDiskstream::steal_write_sources()
+{
+        /* not possible to steal audio write sources */
+        list<boost::shared_ptr<Source> > ret;
+        return ret;
+}
+
 void
 AudioDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
 {
@@ -1951,11 +1930,25 @@ AudioDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
        capturing_sources.clear ();
 
        for (chan = c->begin(), n = 0; chan != c->end(); ++chan, ++n) {
+
                if (!destructive()) {
 
-                       if ((*chan)->write_source && mark_write_complete) {
-                               (*chan)->write_source->mark_streaming_write_completed ();
-                       }
+                       if ((*chan)->write_source) {
+
+                               if (mark_write_complete) {
+                                       (*chan)->write_source->mark_streaming_write_completed ();
+                                       (*chan)->write_source->done_with_peakfile_writes ();
+                               }
+
+                                if ((*chan)->write_source->removable()) {
+                                        (*chan)->write_source->mark_for_remove ();
+                                        (*chan)->write_source->drop_references ();
+                                        _session.remove_source ((*chan)->write_source);
+                                }
+                               
+                                (*chan)->write_source.reset ();
+                        }
+
                        use_new_write_source (n);
 
                        if (record_enabled()) {
@@ -1963,13 +1956,14 @@ AudioDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
                        }
 
                } else {
+
                        if ((*chan)->write_source == 0) {
                                use_new_write_source (n);
                        }
                }
        }
 
-       if (destructive()) {
+       if (destructive() && !c->empty ()) {
 
                /* we now have all our write sources set up, so create the
                   playlist's single region.
@@ -2022,7 +2016,7 @@ AudioDiskstream::allocate_temporary_buffers ()
           when slaving to MTC, Timecode etc.
        */
 
-       double sp = max (fabsf (_actual_speed), 1.2f);
+       double const sp = max (fabsf (_actual_speed), 1.2f);
        nframes_t required_wrap_size = (nframes_t) floor (_session.get_block_size() * sp) + 1;
 
        if (required_wrap_size > wrap_buffer_size) {
@@ -2086,8 +2080,10 @@ int
 AudioDiskstream::add_channel_to (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
        while (how_many--) {
-               c->push_back (new ChannelInfo(_session.butler()->audio_diskstream_buffer_size(), speed_buffer_size, wrap_buffer_size));
-               interpolation.add_channel_to (_session.butler()->audio_diskstream_buffer_size(), speed_buffer_size);
+               c->push_back (new ChannelInfo(_session.butler()->audio_diskstream_playback_buffer_size(), 
+                                              _session.butler()->audio_diskstream_capture_buffer_size(),
+                                              speed_buffer_size, wrap_buffer_size));
+               interpolation.add_channel_to (_session.butler()->audio_diskstream_playback_buffer_size(), speed_buffer_size);
        }
 
        _n_channels.set(DataType::AUDIO, c->size());
@@ -2108,9 +2104,7 @@ int
 AudioDiskstream::remove_channel_from (boost::shared_ptr<ChannelList> c, uint32_t how_many)
 {
        while (how_many-- && !c->empty()) {
-               // FIXME: crash (thread safe with RCU?)
-               // memory leak, when disabled.... :(
-               //delete c->back();
+               delete c->back();
                c->pop_back();
                interpolation.remove_channel_from ();
        }
@@ -2156,13 +2150,13 @@ AudioDiskstream::use_pending_capture_data (XMLNode& node)
        boost::shared_ptr<AudioFileSource> fs;
        boost::shared_ptr<AudioFileSource> first_fs;
        SourceList pending_sources;
-       nframes_t position;
+       framepos_t position;
 
        if ((prop = node.property (X_("at"))) == 0) {
                return -1;
        }
 
-       if (sscanf (prop->value().c_str(), "%" PRIu32, &position) != 1) {
+       if (sscanf (prop->value().c_str(), "%" PRIu64, &position) != 1) {
                return -1;
        }
 
@@ -2298,7 +2292,10 @@ AudioDiskstream::can_become_destructive (bool& requires_bounce) const
        }
 
        boost::shared_ptr<Region> first = _playlist->find_next_region (_session.current_start_frame(), Start, 1);
-       assert (first);
+       if (!first) {
+               requires_bounce = false;
+               return true;
+       }
 
        /* do the source(s) for the region cover the session start position ? */
 
@@ -2324,7 +2321,27 @@ AudioDiskstream::can_become_destructive (bool& requires_bounce) const
        return true;
 }
 
-AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_size, nframes_t wrap_size)
+void 
+AudioDiskstream::adjust_playback_buffering ()
+{
+       boost::shared_ptr<ChannelList> c = channels.reader();
+
+       for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
+                (*chan)->resize_playback (_session.butler()->audio_diskstream_playback_buffer_size());
+        }
+}
+
+void 
+AudioDiskstream::adjust_capture_buffering ()
+{
+       boost::shared_ptr<ChannelList> c = channels.reader();
+
+       for (ChannelList::iterator chan = c->begin(); chan != c->end(); ++chan) {
+                (*chan)->resize_capture (_session.butler()->audio_diskstream_capture_buffer_size());
+        }
+}
+
+AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t playback_bufsize, nframes_t capture_bufsize, nframes_t speed_size, nframes_t wrap_size)
 {
        peak_power = 0.0f;
        source = 0;
@@ -2336,8 +2353,8 @@ AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_si
        playback_wrap_buffer = new Sample[wrap_size];
        capture_wrap_buffer = new Sample[wrap_size];
 
-       playback_buf = new RingBufferNPT<Sample> (bufsize);
-       capture_buf = new RingBufferNPT<Sample> (bufsize);
+       playback_buf = new RingBufferNPT<Sample> (playback_bufsize);
+       capture_buf = new RingBufferNPT<Sample> (capture_bufsize);
        capture_transition_buf = new RingBufferNPT<CaptureTransition> (256);
 
        /* touch the ringbuffer buffers, which will cause
@@ -2351,11 +2368,26 @@ AudioDiskstream::ChannelInfo::ChannelInfo (nframes_t bufsize, nframes_t speed_si
        memset (capture_transition_buf->buffer(), 0, sizeof (CaptureTransition) * capture_transition_buf->bufsize());
 }
 
+void
+AudioDiskstream::ChannelInfo::resize_playback (nframes_t playback_bufsize)
+{
+        delete playback_buf;
+       playback_buf = new RingBufferNPT<Sample> (playback_bufsize);
+       memset (playback_buf->buffer(), 0, sizeof (Sample) * playback_buf->bufsize());
+}
+
+void
+AudioDiskstream::ChannelInfo::resize_capture (nframes_t capture_bufsize)
+{
+        delete capture_buf;
+
+       capture_buf = new RingBufferNPT<Sample> (capture_bufsize);
+       memset (capture_buf->buffer(), 0, sizeof (Sample) * capture_buf->bufsize());
+}
+
 AudioDiskstream::ChannelInfo::~ChannelInfo ()
 {
-       if (write_source) {
-               write_source.reset ();
-       }
+        write_source.reset ();
 
        delete [] speed_buffer;
        speed_buffer = 0;
@@ -2375,3 +2407,4 @@ AudioDiskstream::ChannelInfo::~ChannelInfo ()
        delete capture_transition_buf;
        capture_transition_buf = 0;
 }
+