remove unnecessary and unused changes from grygorii
[ardour.git] / libs / ardour / location.cc
index 2e9125126b4c69ea2e617abebdeb489a87a95e53..e8909112250b0e391f9eecfe8c78c2fc814b2dde 100644 (file)
@@ -72,6 +72,7 @@ Location::Location (Session& s, framepos_t sample_start, framepos_t sample_end,
        , _flags (bits)
        , _locked (false)
        , _position_lock_style (s.config.get_glue_new_markers_to_bars_and_beats() ? MusicTime : AudioTime)
+
 {
        recompute_bbt_from_frames ();
 
@@ -89,6 +90,7 @@ Location::Location (const Location& other)
        , _bbt_end (other._bbt_end)
        , _flags (other._flags)
        , _position_lock_style (other._position_lock_style)
+
 {
        /* copy is not locked even if original was */
 
@@ -166,10 +168,10 @@ Location::operator= (const Location& other)
 void
 Location::set_name (const std::string& str)
 { 
-        _name = str; 
+       _name = str; 
 
-        name_changed (this); /* EMIT SIGNAL */
-        NameChanged  (); /* EMIT SIGNAL */
+       name_changed (this); /* EMIT SIGNAL */
+       NameChanged  (); /* EMIT SIGNAL */
 }
 
 /** Set start position.
@@ -221,11 +223,11 @@ Location::set_start (framepos_t s, bool force, bool allow_bbt_recompute)
 
                return 0;
        } else if (!force) {
-                /* range locations must exceed a minimum duration */
-                if (_end - s < Config->get_range_location_minimum()) {
-                        return -1;
-                }
-        }
+               /* range locations must exceed a minimum duration */
+               if (_end - s < Config->get_range_location_minimum()) {
+                       return -1;
+               }
+       }
 
        if (s != _start) {
 
@@ -288,11 +290,11 @@ Location::set_end (framepos_t e, bool force, bool allow_bbt_recompute)
                assert (_end >= 0);
 
                return 0;
-        } else if (!force) {
-                /* range locations must exceed a minimum duration */
-                if (e - _start < Config->get_range_location_minimum()) {
-                        return -1;
-                }
+       } else if (!force) {
+               /* range locations must exceed a minimum duration */
+               if (e - _start < Config->get_range_location_minimum()) {
+                       return -1;
+               }
        }
 
        if (e != _end) {
@@ -329,8 +331,8 @@ Location::set (framepos_t s, framepos_t e, bool allow_bbt_recompute)
                return -1;
        }
 
-        bool start_change = false;
-        bool end_change = false;
+       bool start_change = false;
+       bool end_change = false;
 
        if (is_mark()) {
 
@@ -342,8 +344,8 @@ Location::set (framepos_t s, framepos_t e, bool allow_bbt_recompute)
                                recompute_bbt_from_frames ();
                        }
 
-                        start_change = true;
-                        end_change = true;
+                       start_change = true;
+                       end_change = true;
                }
 
                assert (_start >= 0);
@@ -351,64 +353,64 @@ Location::set (framepos_t s, framepos_t e, bool allow_bbt_recompute)
 
        } else {
 
-                /* range locations must exceed a minimum duration */
-                if (e - s < Config->get_range_location_minimum()) {
-                        return -1;
-                }
+               /* range locations must exceed a minimum duration */
+               if (e - s < Config->get_range_location_minimum()) {
+                       return -1;
+               }
                 
-                if (s != _start) {
+               if (s != _start) {
 
-                        framepos_t const old = _start;
-                        _start = s;
+                       framepos_t const old = _start;
+                       _start = s;
 
-                        if (allow_bbt_recompute) {
-                                recompute_bbt_from_frames ();
-                        }
+                       if (allow_bbt_recompute) {
+                               recompute_bbt_from_frames ();
+                       }
 
-                        start_change = true;
+                       start_change = true;
                         
-                        if (is_session_range ()) {
-                                Session::StartTimeChanged (old); /* EMIT SIGNAL */
-                                AudioFileSource::set_header_position_offset (s);
-                        }
-                }
+                       if (is_session_range ()) {
+                               Session::StartTimeChanged (old); /* EMIT SIGNAL */
+                               AudioFileSource::set_header_position_offset (s);
+                       }
+               }
                         
                  
-                if (e != _end) {
+               if (e != _end) {
                         
-                        framepos_t const old = _end;
-                        _end = e;
+                       framepos_t const old = _end;
+                       _end = e;
 
-                        if (allow_bbt_recompute) {
-                                recompute_bbt_from_frames ();
-                        }
+                       if (allow_bbt_recompute) {
+                               recompute_bbt_from_frames ();
+                       }
                         
-                        end_change = true;
+                       end_change = true;
 
-                        if (is_session_range()) {
-                                Session::EndTimeChanged (old); /* EMIT SIGNAL */
-                        }
-                }
+                       if (is_session_range()) {
+                               Session::EndTimeChanged (old); /* EMIT SIGNAL */
+                       }
+               }
 
-                assert (_end >= 0);
-        }
+               assert (_end >= 0);
+       }
 
-        if (start_change) {
-                start_changed(this); /* EMIT SIGNAL */
-                StartChanged(); /* EMIT SIGNAL */
-        }
+       if (start_change) {
+               start_changed(this); /* EMIT SIGNAL */
+               StartChanged(); /* EMIT SIGNAL */
+       }
 
-        if (end_change) {
-                end_changed(this); /* EMIT SIGNAL */
-                EndChanged(); /* EMIT SIGNAL */
-        }
+       if (end_change) {
+               end_changed(this); /* EMIT SIGNAL */
+               EndChanged(); /* EMIT SIGNAL */
+       }
 
-        if (start_change && end_change) {
-                changed (this);
-                Changed ();
-        }
+       if (start_change && end_change) {
+               changed (this);
+               Changed ();
+       }
 
-        return 0;
+       return 0;
 }
 
 int
@@ -441,8 +443,8 @@ void
 Location::set_hidden (bool yn, void*)
 {
        if (set_flag_internal (yn, IsHidden)) {
-                flags_changed (this); /* EMIT SIGNAL */
-                 FlagsChanged ();
+               flags_changed (this); /* EMIT SIGNAL */
+               FlagsChanged ();
        }
 }
 
@@ -458,40 +460,40 @@ Location::set_cd (bool yn, void*)
        }
 
        if (set_flag_internal (yn, IsCDMarker)) {
-                flags_changed (this); /* EMIT SIGNAL */
-                 FlagsChanged ();
+               flags_changed (this); /* EMIT SIGNAL */
+               FlagsChanged ();
        }
 }
 
 void
 Location::set_is_range_marker (bool yn, void*)
 {
-       if (set_flag_internal (yn, IsRangeMarker)) {
-               flags_changed (this);
-                FlagsChanged (); /* EMIT SIGNAL */
-       }
+       if (set_flag_internal (yn, IsRangeMarker)) {
+               flags_changed (this);
+               FlagsChanged (); /* EMIT SIGNAL */
+       }
 }
 
 void
 Location::set_skip (bool yn)
 {
-        if (is_range_marker() && length() > 0) {
-                if (set_flag_internal (yn, IsSkip)) {
-                        flags_changed (this);
-                        FlagsChanged ();
-                }
-        }
+       if (is_range_marker() && length() > 0) {
+               if (set_flag_internal (yn, IsSkip)) {
+                       flags_changed (this);
+                       FlagsChanged ();
+               }
+       }
 }
 
 void
 Location::set_skipping (bool yn)
 {
-        if (is_range_marker() && is_skip() && length() > 0) {
-                if (set_flag_internal (yn, IsSkipping)) {
-                        flags_changed (this);
-                        FlagsChanged ();
-                }
-        }
+       if (is_range_marker() && is_skip() && length() > 0) {
+               if (set_flag_internal (yn, IsSkipping)) {
+                       flags_changed (this);
+                       FlagsChanged ();
+               }
+       }
 }
 
 void
@@ -502,8 +504,8 @@ Location::set_auto_punch (bool yn, void*)
        }
 
        if (set_flag_internal (yn, IsAutoPunch)) {
-                flags_changed (this); /* EMIT SIGNAL */
-                FlagsChanged (); /* EMIT SIGNAL */
+               flags_changed (this); /* EMIT SIGNAL */
+               FlagsChanged (); /* EMIT SIGNAL */
        }
 }
 
@@ -515,8 +517,8 @@ Location::set_auto_loop (bool yn, void*)
        }
 
        if (set_flag_internal (yn, IsAutoLoop)) {
-                flags_changed (this); /* EMIT SIGNAL */
-                FlagsChanged (); /* EMIT SIGNAL */
+               flags_changed (this); /* EMIT SIGNAL */
+               FlagsChanged (); /* EMIT SIGNAL */
        }
 }
 
@@ -625,22 +627,22 @@ Location::set_state (const XMLNode& node, int version)
                return -1;
        }
 
-               /* can't use set_start() here, because _end
-                  may make the value of _start illegal.
-               */
+       /* can't use set_start() here, because _end
+          may make the value of _start illegal.
+       */
 
        sscanf (prop->value().c_str(), "%" PRId64, &_start);
 
        if ((prop = node.property ("end")) == 0) {
-                 error << _("XML node for Location has no end information") << endmsg;
-                 return -1;
+               error << _("XML node for Location has no end information") << endmsg;
+               return -1;
        }
 
        sscanf (prop->value().c_str(), "%" PRId64, &_end);
 
        if ((prop = node.property ("flags")) == 0) {
-                 error << _("XML node for Location has no flags information") << endmsg;
-                 return -1;
+               error << _("XML node for Location has no flags information") << endmsg;
+               return -1;
        }
 
        _flags = Flags (string_2_enum (prop->value(), _flags));
@@ -653,26 +655,26 @@ Location::set_state (const XMLNode& node, int version)
 
        for (cd_iter = cd_list.begin(); cd_iter != cd_list.end(); ++cd_iter) {
 
-                 cd_node = *cd_iter;
+               cd_node = *cd_iter;
 
-                 if (cd_node->name() != "CD-Info") {
-                         continue;
-                 }
+               if (cd_node->name() != "CD-Info") {
+                       continue;
+               }
 
-                 if ((prop = cd_node->property ("name")) != 0) {
-                         cd_name = prop->value();
-                 } else {
-                         throw failed_constructor ();
-                 }
+               if ((prop = cd_node->property ("name")) != 0) {
+                       cd_name = prop->value();
+               } else {
+                       throw failed_constructor ();
+               }
 
-                 if ((prop = cd_node->property ("value")) != 0) {
-                         cd_value = prop->value();
-                 } else {
-                         throw failed_constructor ();
-                 }
+               if ((prop = cd_node->property ("value")) != 0) {
+                       cd_value = prop->value();
+               } else {
+                       throw failed_constructor ();
+               }
 
 
-                 cd_info[cd_name] = cd_value;
+               cd_info[cd_name] = cd_value;
        }
 
        if ((prop = node.property ("position-lock-style")) != 0) {
@@ -788,7 +790,7 @@ Locations::set_current (Location *loc, bool want_lock)
        }
 
        if (ret == 0) {
-                current_changed (current_location); /* EMIT SIGNAL */
+               current_changed (current_location); /* EMIT SIGNAL */
        }
        return ret;
 }
@@ -800,51 +802,51 @@ Locations::next_available_name(string& result,string base)
        string::size_type l;
        int suffix;
        char buf[32];
-        std::map<uint32_t,bool> taken;
-        uint32_t n;
+       std::map<uint32_t,bool> taken;
+       uint32_t n;
 
        result = base;
-        l = base.length();
+       l = base.length();
 
-        if (!base.empty()) {
+       if (!base.empty()) {
                 
-                /* find all existing names that match "base", and store
-                   the numeric part of them (if any) in the map "taken"
-                */
+               /* find all existing names that match "base", and store
+                  the numeric part of them (if any) in the map "taken"
+               */
 
-                for (i = locations.begin(); i != locations.end(); ++i) {
+               for (i = locations.begin(); i != locations.end(); ++i) {
 
-                        const string& temp ((*i)->name());
+                       const string& temp ((*i)->name());
                         
-                        if (!temp.find (base,0)) {
-
-                                if ((suffix = atoi (temp.substr(l,3))) != 0) {
-                                        taken.insert (make_pair (suffix,true));
-                                }
-                        }
-                }
-        }
-
-        /* Now search for an un-used suffix to add to "base". This
-           will find "holes" in the numbering sequence when a location
-           was deleted.
-
-           This must start at 1, both for human-numbering reasons
-           and also because the call to atoi() above would return 
-           zero if there is no recognizable numeric suffix, causing
-           "base 0" not to be inserted into the "taken" map.
-        */
-
-        n = 1; 
-
-        while (n < UINT32_MAX) {
-                if (taken.find (n) == taken.end()) {
-                        snprintf (buf, sizeof(buf), "%d", n);
-                        result += buf;
-                        return 1;
-                }
-                ++n;
-        }
+                       if (!temp.find (base,0)) {
+
+                               if ((suffix = atoi (temp.substr(l,3))) != 0) {
+                                       taken.insert (make_pair (suffix,true));
+                               }
+                       }
+               }
+       }
+
+       /* Now search for an un-used suffix to add to "base". This
+          will find "holes" in the numbering sequence when a location
+          was deleted.
+
+          This must start at 1, both for human-numbering reasons
+          and also because the call to atoi() above would return 
+          zero if there is no recognizable numeric suffix, causing
+          "base 0" not to be inserted into the "taken" map.
+       */
+
+       n = 1; 
+
+       while (n < UINT32_MAX) {
+               if (taken.find (n) == taken.end()) {
+                       snprintf (buf, sizeof(buf), "%d", n);
+                       result += buf;
+                       return 1;
+               }
+               ++n;
+       }
                 
        return 0;
 }
@@ -945,7 +947,7 @@ Locations::clear_ranges ()
                current_location = 0;
        }
 
-        changed ();
+       changed ();
        current_changed (0); /* EMIT SIGNAL */
 }
 
@@ -966,7 +968,7 @@ Locations::add (Location *loc, bool make_current)
        added (loc); /* EMIT SIGNAL */
 
        if (make_current) {
-                current_changed (current_location); /* EMIT SIGNAL */
+               current_changed (current_location); /* EMIT SIGNAL */
        }
 
        if (loc->is_session_range()) {
@@ -1008,7 +1010,7 @@ Locations::remove (Location *loc)
                removed (loc); /* EMIT SIGNAL */
                 
                if (was_current) {
-                        current_changed (0); /* EMIT SIGNAL */
+                       current_changed (0); /* EMIT SIGNAL */
                }
        }
 }
@@ -1069,6 +1071,8 @@ Locations::set_state (const XMLNode& node, int version)
                                if (i != locations.end()) {
                                        /* we can re-use an old Location object */
                                        loc = *i;
+                    
+                                       // changed locations will be updated by Locations::changed signal
                                        loc->set_state (**niter, version);
                                } else {
                                        loc = new Location (_session, **niter);
@@ -1113,6 +1117,30 @@ Locations::set_state (const XMLNode& node, int version)
                        }
                }
 
+               /* We may have some unused locations in the old list. */
+               for (LocationList::iterator i = locations.begin(); i != locations.end(); ) {
+                       LocationList::iterator tmp = i;
+                       ++tmp;
+
+                       LocationList::iterator n = new_locations.begin();
+                       bool found = false;
+
+                       while (n != new_locations.end ()) {
+                               if ((*i)->id() == (*n)->id()) {
+                                       found = true;
+                                       break;
+                               }
+                               ++n;
+                       }
+
+                       if (!found) {
+                               delete *i;
+                               locations.erase (i);
+                       }
+
+                       i = tmp;
+               }
+
                locations = new_locations;
 
                if (locations.size()) {
@@ -1132,16 +1160,16 @@ typedef std::pair<framepos_t,Location*> LocationPair;
 
 struct LocationStartEarlierComparison
 {
-    bool operator() (LocationPair a, LocationPair b) {
-           return a.first < b.first;
-    }
+       bool operator() (LocationPair a, LocationPair b) {
+               return a.first < b.first;
+       }
 };
 
 struct LocationStartLaterComparison
 {
-    bool operator() (LocationPair a, LocationPair b) {
-           return a.first > b.first;
-    }
+       bool operator() (LocationPair a, LocationPair b) {
+               return a.first > b.first;
+       }
 };
 
 framepos_t
@@ -1350,7 +1378,7 @@ Locations::auto_punch_location () const
                        return const_cast<Location*> (*i);
                }
        }
-       return 0;
+       return 0;
 }
 
 uint32_t
@@ -1369,12 +1397,12 @@ Locations::num_range_markers () const
 Location *
 Locations::get_location_by_id(PBD::ID id)
 {
-    LocationList::iterator it;
-    for (it  = locations.begin(); it != locations.end(); ++it)
-        if (id == (*it)->id())
-            return *it;
+       LocationList::iterator it;
+       for (it  = locations.begin(); it != locations.end(); ++it)
+               if (id == (*it)->id())
+                       return *it;
 
-    return 0;
+       return 0;
 }
 
 void