Fix more broken whitespace.
[ardour.git] / libs / ardour / midi_diskstream.cc
index 52b93015c8278003ff86e7f3737f9605fe6f8494..3d2336da3abb7642722729d23f44d8577476c56a 100644 (file)
@@ -67,7 +67,7 @@ using namespace std;
 using namespace ARDOUR;
 using namespace PBD;
 
-nframes_t MidiDiskstream::midi_readahead = 4096;
+framecnt_t MidiDiskstream::midi_readahead = 4096;
 
 MidiDiskstream::MidiDiskstream (Session &sess, const string &name, Diskstream::Flag flag)
        : Diskstream(sess, name, flag)
@@ -85,7 +85,7 @@ MidiDiskstream::MidiDiskstream (Session &sess, const string &name, Diskstream::F
 
        init ();
        use_new_playlist ();
-        use_new_write_source (0);
+       use_new_write_source (0);
 
        in_set_state = false;
 
@@ -111,7 +111,7 @@ MidiDiskstream::MidiDiskstream (Session& sess, const XMLNode& node)
                throw failed_constructor();
        }
 
-        use_new_write_source (0);
+       use_new_write_source (0);
 
        in_set_state = false;
 }
@@ -128,8 +128,8 @@ MidiDiskstream::init ()
        allocate_temporary_buffers ();
 
        const size_t size = _session.butler()->midi_diskstream_buffer_size();
-       _playback_buf = new MidiRingBuffer<nframes_t>(size);
-       _capture_buf = new MidiRingBuffer<nframes_t>(size);
+       _playback_buf = new MidiRingBuffer<framepos_t>(size);
+       _capture_buf = new MidiRingBuffer<framepos_t>(size);
 
        _n_channels = ChanCount(DataType::MIDI, 1);
 
@@ -171,23 +171,17 @@ MidiDiskstream::non_realtime_input_change ()
 
                get_input_sources ();
                set_capture_offset ();
-
-               if (first_input_change) {
-                       set_align_style (_persistent_alignment_style);
-                       first_input_change = false;
-               } else {
-                       set_align_style_from_io ();
-               }
+               set_align_style_from_io ();
 
                input_change_pending.type = IOChange::NoChange;
 
                /* implicit unlock */
        }
 
-        /* unlike with audio, there is never any need to reset write sources
-           based on input configuration changes because ... a MIDI track 
-           has just 1 MIDI port as input, always. 
-        */
+       /* unlike with audio, there is never any need to reset write sources
+          based on input configuration changes because ... a MIDI track
+          has just 1 MIDI port as input, always.
+       */
 
        /* now refill channel buffers */
 
@@ -488,17 +482,17 @@ trace_midi (ostream& o, MIDI::byte *msg, size_t len)
 #endif
 
 int
-MidiDiskstream::process (framepos_t transport_frame, nframes_t nframes, bool can_record, bool rec_monitors_input, bool& need_butler)
+MidiDiskstream::process (framepos_t transport_frame, pframes_t nframes, bool can_record, bool rec_monitors_input, bool& need_butler)
 {
        int       ret = -1;
-       nframes_t rec_offset = 0;
-       nframes_t rec_nframes = 0;
+       framecnt_t rec_offset = 0;
+       framecnt_t rec_nframes = 0;
        bool      nominally_recording;
        bool      re = record_enabled ();
 
-        playback_distance = 0;
+       playback_distance = 0;
 
-       check_record_status (transport_frame, nframes, can_record);
+       check_record_status (transport_frame, can_record);
 
        nominally_recording = (can_record && re);
 
@@ -506,9 +500,9 @@ MidiDiskstream::process (framepos_t transport_frame, nframes_t nframes, bool can
                return 0;
        }
 
-        Glib::Mutex::Lock sm (state_lock, Glib::TRY_LOCK);
+       Glib::Mutex::Lock sm (state_lock, Glib::TRY_LOCK);
 
-        if (!sm.locked()) {
+       if (!sm.locked()) {
                return 1;
        }
 
@@ -520,6 +514,7 @@ MidiDiskstream::process (framepos_t transport_frame, nframes_t nframes, bool can
                calculate_record_range(ot, transport_frame, nframes, rec_nframes, rec_offset);
 
                if (rec_nframes && !was_recording) {
+                       _write_source->mark_write_starting_now ();
                        capture_captured = 0;
                        was_recording = true;
                }
@@ -540,6 +535,16 @@ MidiDiskstream::process (framepos_t transport_frame, nframes_t nframes, bool can
                        _capture_buf->write(ev.time() + transport_frame, ev.type(), ev.size(), ev.buffer());
                }
 
+               if (buf.size() != 0) {
+                       /* Make a copy of this data and emit it for the GUI to see */
+                       boost::shared_ptr<MidiBuffer> copy (new MidiBuffer (buf.capacity ()));
+                       for (MidiBuffer::iterator i = buf.begin(); i != buf.end(); ++i) {
+                               copy->push_back ((*i).time() + transport_frame, (*i).size(), (*i).buffer());
+                       }
+
+                       DataRecorded (copy, _write_source); /* EMIT SIGNAL */
+               }
+
        } else {
 
                if (was_recording) {
@@ -566,19 +571,25 @@ MidiDiskstream::process (framepos_t transport_frame, nframes_t nframes, bool can
 
                playback_distance = nframes;
 
+       } else {
+
+               /* XXX: should be doing varispeed stuff here, similar to the code in AudioDiskstream::process */
+
+               playback_distance = nframes;
+
        }
 
        ret = 0;
 
-        if (commit (nframes)) {
-                need_butler = true;
-        }
+       if (commit (nframes)) {
+               need_butler = true;
+       }
 
        return ret;
 }
 
 bool
-MidiDiskstream::commit (nframes_t nframes)
+MidiDiskstream::commit (framecnt_t nframes)
 {
        bool need_butler = false;
 
@@ -619,6 +630,12 @@ MidiDiskstream::set_pending_overwrite (bool yn)
 int
 MidiDiskstream::overwrite_existing_buffers ()
 {
+       /* This is safe as long as the butler thread is suspended, which it should be */
+       _playback_buf->reset ();
+
+       g_atomic_int_set (&_frames_read_from_ringbuffer, 0);
+       g_atomic_int_set (&_frames_written_to_ringbuffer, 0);
+
        read (overwrite_frame, disk_io_chunk_frames, false);
        overwrite_queued = false;
        _pending_overwrite = false;
@@ -668,9 +685,9 @@ MidiDiskstream::internal_playback_seek (framecnt_t distance)
 
 /** @a start is set to the new frame position (TIME) read up to */
 int
-MidiDiskstream::read (framepos_t& start, nframes_t dur, bool reversed)
+MidiDiskstream::read (framepos_t& start, framecnt_t dur, bool reversed)
 {
-       nframes_t this_read = 0;
+       framecnt_t this_read = 0;
        bool reloop = false;
        framepos_t loop_end = 0;
        framepos_t loop_start = 0;
@@ -798,16 +815,15 @@ MidiDiskstream::do_refill ()
        uint32_t frames_read = g_atomic_int_get(&_frames_read_from_ringbuffer);
        uint32_t frames_written = g_atomic_int_get(&_frames_written_to_ringbuffer);
        if ((frames_written - frames_read) >= midi_readahead) {
-               //cout << "MDS Nothing to do. all fine" << endl;
                return 0;
        }
 
-       nframes_t to_read = midi_readahead - (frames_written - frames_read);
+       framecnt_t to_read = midi_readahead - (frames_written - frames_read);
 
        //cout << "MDS read for midi_readahead " << to_read << "  rb_contains: "
        //      << frames_written - frames_read << endl;
 
-       to_read = (nframes_t) min ((framecnt_t) to_read, (framecnt_t) (max_framepos - file_frame));
+       to_read = (framecnt_t) min ((framecnt_t) to_read, (framecnt_t) (max_framepos - file_frame));
 
        if (read (file_frame, to_read, reversed)) {
                ret = -1;
@@ -831,14 +847,13 @@ MidiDiskstream::do_flush (RunContext /*context*/, bool force_flush)
 {
        uint32_t to_write;
        int32_t ret = 0;
-       nframes_t total;
+       framecnt_t total;
 
        _write_data_count = 0;
 
        total = _session.transport_frame() - _last_flush_frame;
 
-       if (_last_flush_frame > _session.transport_frame()
-                       || _last_flush_frame < capture_start_frame) {
+       if (_last_flush_frame > _session.transport_frame() || _last_flush_frame < capture_start_frame) {
                _last_flush_frame = _session.transport_frame();
        }
 
@@ -866,10 +881,10 @@ MidiDiskstream::do_flush (RunContext /*context*/, bool force_flush)
 
        assert(!destructive());
 
-       if (record_enabled() && 
-            ((_session.transport_frame() - _last_flush_frame > disk_io_chunk_frames) || 
-             force_flush)) {
-               if ((!_write_source) || _write_source->midi_write (*_capture_buf, capture_start_frame, to_write) != to_write) {
+       if (record_enabled() &&
+           ((_session.transport_frame() - _last_flush_frame > disk_io_chunk_frames) ||
+            force_flush)) {
+               if ((!_write_source) || _write_source->midi_write (*_capture_buf, get_capture_start_frame (0), to_write) != to_write) {
                        error << string_compose(_("MidiDiskstream %1: cannot write to disk"), _id) << endmsg;
                        return -1;
                } else {
@@ -900,14 +915,14 @@ MidiDiskstream::transport_stopped_wallclock (struct tm& /*when*/, time_t /*twhen
 
        while (more_work && !err) {
                switch (do_flush (TransportContext, true)) {
-                       case 0:
-                               more_work = false;
-                               break;
-                       case 1:
-                               break;
-                       case -1:
-                               error << string_compose(_("MidiDiskstream \"%1\": cannot flush captured data to disk!"), _name) << endmsg;
-                               err++;
+               case 0:
+                       more_work = false;
+                       break;
+               case 1:
+                       break;
+               case -1:
+                       error << string_compose(_("MidiDiskstream \"%1\": cannot flush captured data to disk!"), _name) << endmsg;
+                       err++;
                }
        }
 
@@ -921,8 +936,8 @@ MidiDiskstream::transport_stopped_wallclock (struct tm& /*when*/, time_t /*twhen
        if (abort_capture) {
 
                if (_write_source) {
-
                        _write_source->mark_for_remove ();
+                       _write_source->drop_references ();
                        _write_source.reset();
                }
 
@@ -932,118 +947,139 @@ MidiDiskstream::transport_stopped_wallclock (struct tm& /*when*/, time_t /*twhen
 
                assert(_write_source);
 
-               nframes_t total_capture = 0;
+               framecnt_t total_capture = 0;
                for (ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
                        total_capture += (*ci)->frames;
                }
 
-                if (_write_source->length (capture_info.front()->start) != 0) {
-                        
-                        /* phew, we have data */
-                        
-                        /* figure out the name for this take */
-                        
-                        srcs.push_back (_write_source);
+               if (_write_source->length (capture_info.front()->start) != 0) {
 
-                        _write_source->set_timeline_position (capture_info.front()->start);
-                        _write_source->set_captured_for (_name);
+                       /* phew, we have data */
 
-                        /* flush to disk: this step differs from the audio path, 
-                           where all the data is already on disk.
-                         */
+                       /* figure out the name for this take */
 
-                        _write_source->mark_streaming_write_completed ();
-                        
-                        /* make it not a stub anymore */
+                       srcs.push_back (_write_source);
 
-                        _write_source->unstubify ();
+                       _write_source->set_timeline_position (capture_info.front()->start);
+                       _write_source->set_captured_for (_name);
 
-                        /* we will want to be able to keep (over)writing the source
-                           but we don't want it to be removable. this also differs
-                           from the audio situation, where the source at this point
-                           must be considered immutable. luckily, we can rely on
-                           MidiSource::mark_streaming_write_completed() to have 
-                           already done the necessary work for that.
-                        */
+                       /* flush to disk: this step differs from the audio path,
+                          where all the data is already on disk.
+                       */
 
-                        string whole_file_region_name;
-                        whole_file_region_name = region_name_from_path (_write_source->name(), true);
-                        
-                        /* Register a new region with the Session that
-                           describes the entire source. Do this first
-                           so that any sub-regions will obviously be
-                           children of this one (later!)
-                        */
-                        
-                        try {
-                                PropertyList plist;
+                       _write_source->mark_streaming_write_completed ();
 
-                                plist.add (Properties::name, whole_file_region_name);
-                                plist.add (Properties::whole_file, true);
-                                plist.add (Properties::automatic, true);
-                                plist.add (Properties::start, 0);
-                                plist.add (Properties::length, total_capture);
-                                plist.add (Properties::layer, 0);
+                       /* set length in beats to entire capture length */
 
-                                boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
+                       BeatsFramesConverter converter (_session.tempo_map(), capture_info.front()->start);
+                       const double total_capture_beats = converter.from(total_capture);
+                       _write_source->set_length_beats(total_capture_beats);
 
-                                region = boost::dynamic_pointer_cast<MidiRegion> (rx);
-                                region->special_set_position (capture_info.front()->start);
-                        }
+                       /* we will want to be able to keep (over)writing the source
+                          but we don't want it to be removable. this also differs
+                          from the audio situation, where the source at this point
+                          must be considered immutable. luckily, we can rely on
+                          MidiSource::mark_streaming_write_completed() to have
+                          already done the necessary work for that.
+                       */
 
+                       string whole_file_region_name;
+                       whole_file_region_name = region_name_from_path (_write_source->name(), true);
 
-                        catch (failed_constructor& err) {
-                                error << string_compose(_("%1: could not create region for complete midi file"), _name) << endmsg;
-                                /* XXX what now? */
-                        }
+                       /* Register a new region with the Session that
+                          describes the entire source. Do this first
+                          so that any sub-regions will obviously be
+                          children of this one (later!)
+                       */
 
-                        _last_capture_sources.insert (_last_capture_sources.end(), srcs.begin(), srcs.end());
+                       try {
+                               PropertyList plist;
 
-                        _playlist->clear_changes ();
-                        _playlist->freeze ();
+                               plist.add (Properties::name, whole_file_region_name);
+                               plist.add (Properties::whole_file, true);
+                               plist.add (Properties::automatic, true);
+                               plist.add (Properties::start, 0);
+                               plist.add (Properties::length, total_capture);
+                               plist.add (Properties::layer, 0);
 
-                        uint32_t buffer_position = 0;
-                        for (buffer_position = 0, ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
+                               boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
 
-                                string region_name;
+                               region = boost::dynamic_pointer_cast<MidiRegion> (rx);
+                               region->special_set_position (capture_info.front()->start);
+                       }
+
+
+                       catch (failed_constructor& err) {
+                               error << string_compose(_("%1: could not create region for complete midi file"), _name) << endmsg;
+                               /* XXX what now? */
+                       }
+
+                       _last_capture_sources.insert (_last_capture_sources.end(), srcs.begin(), srcs.end());
 
-                                RegionFactory::region_name (region_name, _write_source->name(), false);
+                       _playlist->clear_changes ();
+                       _playlist->freeze ();
 
-                                // cerr << _name << ": based on ci of " << (*ci)->start << " for " << (*ci)->frames << " add a region\n";
+                       /* Session frame time of the initial capture in this pass, which is where the source starts */
+                       framepos_t initial_capture = 0;
+                       if (!capture_info.empty()) {
+                               initial_capture = capture_info.front()->start;
+                       }
 
-                                try {
-                                        PropertyList plist;
-                               
-                                        plist.add (Properties::start, buffer_position);
-                                        plist.add (Properties::length, (*ci)->frames);
-                                        plist.add (Properties::name, region_name);
-                               
-                                        boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
-                                        region = boost::dynamic_pointer_cast<MidiRegion> (rx);
-                                }
+                       for (ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
 
-                                catch (failed_constructor& err) {
-                                        error << _("MidiDiskstream: could not create region for captured midi!") << endmsg;
-                                        continue; /* XXX is this OK? */
-                                }
+                               string region_name;
 
-                                // cerr << "add new region, buffer position = " << buffer_position << " @ " << (*ci)->start << endl;
+                               RegionFactory::region_name (region_name, _write_source->name(), false);
 
-                                i_am_the_modifier++;
-                                _playlist->add_region (region, (*ci)->start);
-                                i_am_the_modifier--;
+                               // cerr << _name << ": based on ci of " << (*ci)->start << " for " << (*ci)->frames << " add a region\n";
 
-                                buffer_position += (*ci)->frames;
-                        }
+                               try {
+                                       PropertyList plist;
 
-                        _playlist->thaw ();
-                        _session.add_command (new StatefulDiffCommand(_playlist));
-                }
+                                       /* start of this region is the offset between the start of its capture and the start of the whole pass */
+                                       plist.add (Properties::start, (*ci)->start - initial_capture);
+                                       plist.add (Properties::length, (*ci)->frames);
+                                       plist.add (Properties::length_beats, converter.from((*ci)->frames));
+                                       plist.add (Properties::name, region_name);
+
+                                       boost::shared_ptr<Region> rx (RegionFactory::create (srcs, plist));
+                                       region = boost::dynamic_pointer_cast<MidiRegion> (rx);
+                               }
+
+                               catch (failed_constructor& err) {
+                                       error << _("MidiDiskstream: could not create region for captured midi!") << endmsg;
+                                       continue; /* XXX is this OK? */
+                               }
+
+                               // cerr << "add new region, buffer position = " << buffer_position << " @ " << (*ci)->start << endl;
+
+                               i_am_the_modifier++;
+                               _playlist->add_region (region, (*ci)->start);
+                               i_am_the_modifier--;
+                       }
 
-                mark_write_completed = true;
+                       _playlist->thaw ();
+                       _session.add_command (new StatefulDiffCommand(_playlist));
+
+               } else {
+
+                       /* No data was recorded, so this capture will
+                          effectively be aborted; do the same as we
+                          do for an explicit abort.
+                       */
+
+                       if (_write_source) {
+                               _write_source->mark_for_remove ();
+                               _write_source->drop_references ();
+                               _write_source.reset();
+                       }
+               }
+               
+
+               mark_write_completed = true;
        }
 
-        use_new_write_source (0);
+       use_new_write_source (0);
 
        for (ci = capture_info.begin(); ci != capture_info.end(); ++ci) {
                delete *ci;
@@ -1143,7 +1179,7 @@ MidiDiskstream::set_record_enabled (bool yn)
 void
 MidiDiskstream::engage_record_enable ()
 {
-    bool rolling = _session.transport_speed() != 0.0f;
+       bool const rolling = _session.transport_speed() != 0.0f;
 
        g_atomic_int_set (&_record_enabled, 1);
 
@@ -1151,8 +1187,6 @@ MidiDiskstream::engage_record_enable ()
                _source_port->request_monitor_input (!(_session.config.get_auto_input() && rolling));
        }
 
-       _write_source->mark_streaming_midi_write_started (_note_mode, _session.transport_frame());
-
        RecordEnableChanged (); /* EMIT SIGNAL */
 }
 
@@ -1160,38 +1194,19 @@ void
 MidiDiskstream::disengage_record_enable ()
 {
        g_atomic_int_set (&_record_enabled, 0);
-       if (_source_port && Config->get_monitoring_model() == HardwareMonitoring) {
-               if (_source_port) {
-                       _source_port->request_monitor_input (false);
-               }
-       }
-
        RecordEnableChanged (); /* EMIT SIGNAL */
 }
 
 XMLNode&
 MidiDiskstream::get_state ()
 {
-       XMLNode* node = new XMLNode ("Diskstream");
+       XMLNode& node (Diskstream::get_state());
        char buf[64];
        LocaleGuard lg (X_("POSIX"));
 
-       snprintf (buf, sizeof(buf), "0x%x", _flags);
-       node->add_property ("flags", buf);
-
-       node->add_property("channel-mode", enum_2_string(get_channel_mode()));
-
+       node.add_property("channel-mode", enum_2_string(get_channel_mode()));
        snprintf (buf, sizeof(buf), "0x%x", get_channel_mask());
-       node->add_property("channel-mask", buf);
-
-       node->add_property ("playlist", _playlist->name());
-
-       snprintf (buf, sizeof(buf), "%f", _visible_speed);
-       node->add_property ("speed", buf);
-
-       node->add_property("name", _name);
-       id().print(buf, sizeof(buf));
-       node->add_property("id", buf);
+       node.add_property("channel-mask", buf);
 
        if (_write_source && _session.get_record_enabled()) {
 
@@ -1213,18 +1228,14 @@ MidiDiskstream::get_state ()
                }
 
                cs_child->add_property (X_("at"), buf);
-               node->add_child_nocopy (*cs_child);
+               node.add_child_nocopy (*cs_child);
        }
 
-       if (_extra_xml) {
-               node->add_child_copy (*_extra_xml);
-       }
-
-       return* node;
+       return node;
 }
 
 int
-MidiDiskstream::set_state (const XMLNode& node, int /*version*/)
+MidiDiskstream::set_state (const XMLNode& node, int version)
 {
        const XMLProperty* prop;
        XMLNodeList nlist = node.children();
@@ -1232,12 +1243,11 @@ MidiDiskstream::set_state (const XMLNode& node, int /*version*/)
        XMLNode* capture_pending_node = 0;
        LocaleGuard lg (X_("POSIX"));
 
+       /* prevent write sources from being created */
+
        in_set_state = true;
 
        for (niter = nlist.begin(); niter != nlist.end(); ++niter) {
-               /*if ((*niter)->name() == IO::state_node_name) {
-                       deprecated_io_node = new XMLNode (**niter);
-               }*/
                assert ((*niter)->name() != IO::state_node_name);
 
                if ((*niter)->name() == X_("CapturingSources")) {
@@ -1245,20 +1255,8 @@ MidiDiskstream::set_state (const XMLNode& node, int /*version*/)
                }
        }
 
-       /* prevent write sources from being created */
-
-       in_set_state = true;
-
-       if ((prop = node.property ("name")) != 0) {
-               _name = prop->value();
-       }
-
-       if ((prop = node.property ("id")) != 0) {
-               _id = prop->value ();
-       }
-
-       if ((prop = node.property ("flags")) != 0) {
-               _flags = Flag (string_2_enum (prop->value(), _flags));
+       if (Diskstream::set_state (node, version)) {
+               return -1;
        }
 
        ChannelMode channel_mode = AllChannels;
@@ -1274,36 +1272,12 @@ MidiDiskstream::set_state (const XMLNode& node, int /*version*/)
                }
        }
 
-       set_channel_mode(channel_mode, channel_mask);
 
-       if ((prop = node.property ("playlist")) == 0) {
-               return -1;
+       if (capture_pending_node) {
+               use_pending_capture_data (*capture_pending_node);
        }
 
-       {
-               bool had_playlist = (_playlist != 0);
-
-               if (find_and_use_playlist (prop->value())) {
-                       return -1;
-               }
-
-               if (!had_playlist) {
-                       _playlist->set_orig_diskstream_id (id());
-               }
-
-               if (capture_pending_node) {
-                       use_pending_capture_data (*capture_pending_node);
-               }
-
-       }
-
-       if ((prop = node.property ("speed")) != 0) {
-               double sp = atof (prop->value().c_str());
-
-               if (realtime_set_speed (sp, false)) {
-                       non_realtime_set_speed ();
-               }
-       }
+       set_channel_mode (channel_mode, channel_mask);
 
        in_set_state = false;
 
@@ -1319,16 +1293,11 @@ MidiDiskstream::use_new_write_source (uint32_t n)
 
        assert(n == 0);
 
-        _write_source.reset();
+       _write_source.reset();
 
        try {
-                /* file starts off as a stub file, it will be converted
-                   when we're done with a capture pass, or when "stolen"
-                   by the GUI.
-                */
-
                _write_source = boost::dynamic_pointer_cast<SMFSource>(
-                        _session.create_midi_source_for_session (0, name (), true));
+                       _session.create_midi_source_for_session (0, name ()));
 
                if (!_write_source) {
                        throw failed_constructor();
@@ -1341,36 +1310,32 @@ MidiDiskstream::use_new_write_source (uint32_t n)
                return -1;
        }
 
-       _write_source->mark_streaming_midi_write_started (_note_mode, _session.transport_frame());
-
        return 0;
 }
 
-list<boost::shared_ptr<Source> > 
+list<boost::shared_ptr<Source> >
 MidiDiskstream::steal_write_sources()
 {
-        list<boost::shared_ptr<Source> > ret;
+       list<boost::shared_ptr<Source> > ret;
+
+       /* put some data on the disk, even if its just a header for an empty file.
+          XXX should we not have a more direct method for doing this? Maybe not
+          since we don't want to mess around with the model/disk relationship
+          that the Source has to pay attention to.
+       */
 
-        /* put some data on the disk, even if its just a header for an empty file.
-           XXX should we not have a more direct method for doing this? Maybe not
-           since we don't want to mess around with the model/disk relationship
-           that the Source has to pay attention to.
-         */
-        
-        boost::dynamic_pointer_cast<MidiSource>(_write_source)->session_saved ();
+       boost::dynamic_pointer_cast<MidiSource>(_write_source)->session_saved ();
 
-        /* make it visible/present */
-        _write_source->unstubify ();
-        /* never let it go away */
-        _write_source->mark_nonremovable ();
+       /* never let it go away */
+       _write_source->mark_nonremovable ();
 
-        ret.push_back (_write_source);
+       ret.push_back (_write_source);
 
-        /* get a new one */
+       /* get a new one */
 
-        use_new_write_source (0);
+       use_new_write_source (0);
 
-        return ret;
+       return ret;
 }
 
 void
@@ -1382,8 +1347,8 @@ MidiDiskstream::reset_write_sources (bool mark_write_complete, bool /*force*/)
 
        if (_write_source && mark_write_complete) {
                _write_source->mark_streaming_write_completed ();
-        }
-        use_new_write_source (0);
+       }
+       use_new_write_source (0);
 }
 
 int
@@ -1397,7 +1362,7 @@ MidiDiskstream::rename_write_sources ()
 }
 
 void
-MidiDiskstream::set_block_size (nframes_t /*nframes*/)
+MidiDiskstream::set_block_size (pframes_t /*nframes*/)
 {
 }
 
@@ -1418,6 +1383,10 @@ MidiDiskstream::set_align_style_from_io ()
 {
        bool have_physical = false;
 
+       if (_alignment_choice != Automatic) {
+               return;
+       }
+
        if (_io == 0) {
                return;
        }