correct delete/free mess
[ardour.git] / libs / ardour / midi_model.cc
index b23631da0e8ebbe4b009637c0ebc1bf0f2e98462..716d5117982a739627a6eef9b6b226a2f530aba4 100644 (file)
 
 */
 
-#include <set>
-#include <iostream>
 #include <algorithm>
+#include <iostream>
+#include <set>
 #include <stdexcept>
 #include <stdint.h>
-#include "pbd/error.h"
-#include "pbd/enumwriter.h"
+
 #include "pbd/compose.h"
+#include "pbd/enumwriter.h"
+#include "pbd/error.h"
+
+#include "evoral/Control.hpp"
+
 #include "midi++/events.h"
 
+#include "ardour/automation_control.h"
+#include "ardour/midi_automation_list_binder.h"
 #include "ardour/midi_model.h"
 #include "ardour/midi_source.h"
 #include "ardour/midi_state_tracker.h"
-#include "ardour/smf_source.h"
-#include "ardour/types.h"
 #include "ardour/session.h"
-#include "ardour/midi_automation_list_binder.h"
+#include "ardour/types.h"
 
 #include "i18n.h"
 
@@ -59,7 +63,7 @@ MidiModel::new_note_diff_command (const string name)
 {
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        return new NoteDiffCommand (ms->model(), name);
 }
 
@@ -69,7 +73,7 @@ MidiModel::new_sysex_diff_command (const string name)
 {
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        return new SysExDiffCommand (ms->model(), name);
 }
 
@@ -79,7 +83,7 @@ MidiModel::new_patch_change_diff_command (const string name)
 {
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        return new PatchChangeDiffCommand (ms->model(), name);
 }
 
@@ -165,7 +169,7 @@ MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop,
                                     uint8_t new_value)
 {
        assert (note);
-       
+
        NoteChange change;
 
        switch (prop) {
@@ -211,7 +215,7 @@ MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop,
                                     TimeType new_time)
 {
        assert (note);
-       
+
        NoteChange change;
 
        switch (prop) {
@@ -285,6 +289,15 @@ MidiModel::NoteDiffCommand::operator() ()
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        Property prop = i->property;
+
+                       if (!i->note) {
+                               /* note found during deserialization, so try
+                                  again now that the model state is different.
+                               */
+                               i->note = _model->find_note (i->note_id);
+                               assert (i->note);
+                       }
+
                        switch (prop) {
                        case NoteNumber:
                                if (temporary_removals.find (i->note) == temporary_removals.end()) {
@@ -337,7 +350,7 @@ MidiModel::NoteDiffCommand::operator() ()
                                _removed_notes.push_back (*i);
                        }
                }
-
+               
                if (!side_effect_removals.empty()) {
                        cerr << "SER: \n";
                        for (set<NotePtr>::iterator i = side_effect_removals.begin(); i != side_effect_removals.end(); ++i) {
@@ -369,33 +382,41 @@ MidiModel::NoteDiffCommand::undo ()
                /* notes we modify in a way that requires remove-then-add to maintain ordering */
                set<NotePtr> temporary_removals;
 
+
+               /* lazily discover any affected notes that were not discovered when
+                * loading the history because of deletions, etc.
+                */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->note) {
+                               i->note = _model->find_note (i->note_id);
+                               assert (i->note);
+                       }
+               }
+                               
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        Property prop = i->property;
+
                        switch (prop) {
-                               
                        case NoteNumber:
-                               if (
-                                       temporary_removals.find (i->note) == temporary_removals.end() &&
-                                       find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()
-                                       ) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
 
                                        /* We only need to mark this note for re-add if (a) we haven't
                                           already marked it and (b) it isn't on the _removed_notes
                                           list (which means that it has already been removed and it
                                           will be re-added anyway)
                                        */
-                                       
+
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
                                i->note->set_note (i->old_value);
                                break;
-                               
+
                        case StartTime:
-                               if (
-                                       temporary_removals.find (i->note) == temporary_removals.end() &&
-                                       find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()
-                                       ) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
 
                                        /* See above ... */
 
@@ -404,15 +425,13 @@ MidiModel::NoteDiffCommand::undo ()
                                }
                                i->note->set_time (i->old_time);
                                break;
-                               
+
                        case Channel:
-                               if (
-                                       temporary_removals.find (i->note) == temporary_removals.end() &&
-                                       find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()
-                                       ) {
+                               if (temporary_removals.find (i->note) == temporary_removals.end() &&
+                                   find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) {
 
                                        /* See above ... */
-                                       
+
                                        _model->remove_note_unlocked (i->note);
                                        temporary_removals.insert (i->note);
                                }
@@ -425,7 +444,7 @@ MidiModel::NoteDiffCommand::undo ()
                        case Velocity:
                                i->note->set_velocity (i->old_value);
                                break;
-                               
+
                        case Length:
                                i->note->set_length (i->old_time);
                                break;
@@ -449,7 +468,7 @@ MidiModel::NoteDiffCommand::undo ()
                        _model->add_note_unlocked (*i);
                }
        }
-
+       
        _model->ContentsChanged(); /* EMIT SIGNAL */
 }
 
@@ -503,8 +522,8 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note)
        unsigned int note;
        XMLProperty* prop;
        unsigned int channel;
-       unsigned int time;
-       unsigned int length;
+       MidiModel::TimeType time;
+       MidiModel::TimeType length;
        unsigned int velocity;
        gint id;
 
@@ -647,15 +666,13 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change)
        }
 
        /* we must point at the instance of the note that is actually in the model.
-          so go look for it ...
+          so go look for it ... it may not be there (it could have been
+          deleted in a later operation, so store the note id so that we can
+          look it up again later).
        */
 
        change.note = _model->find_note (note_id);
-
-       if (!change.note) {
-               warning << "MIDI note #" << note_id << " not found in model - programmers should investigate this" << endmsg;
-               return change;
-       }
+       change.note_id = note_id;
 
        return change;
 }
@@ -725,29 +742,29 @@ MidiModel::NoteDiffCommand::get_state ()
        diff_command->add_property("midi-source", _model->midi_source()->id().to_s());
 
        XMLNode* changes = diff_command->add_child(DIFF_NOTES_ELEMENT);
-       for_each(_changes.begin(), _changes.end(), 
+       for_each(_changes.begin(), _changes.end(),
                 boost::bind (
                         boost::bind (&XMLNode::add_child_nocopy, changes, _1),
                         boost::bind (&NoteDiffCommand::marshal_change, this, _1)));
 
        XMLNode* added_notes = diff_command->add_child(ADDED_NOTES_ELEMENT);
-       for_each(_added_notes.begin(), _added_notes.end(), 
+       for_each(_added_notes.begin(), _added_notes.end(),
                 boost::bind(
                         boost::bind (&XMLNode::add_child_nocopy, added_notes, _1),
                         boost::bind (&NoteDiffCommand::marshal_note, this, _1)));
 
        XMLNode* removed_notes = diff_command->add_child(REMOVED_NOTES_ELEMENT);
-       for_each(_removed_notes.begin(), _removed_notes.end(), 
+       for_each(_removed_notes.begin(), _removed_notes.end(),
                 boost::bind (
                         boost::bind (&XMLNode::add_child_nocopy, removed_notes, _1),
                         boost::bind (&NoteDiffCommand::marshal_note, this, _1)));
 
-       /* if this command had side-effects, store that state too 
+       /* if this command had side-effects, store that state too
         */
 
        if (!side_effect_removals.empty()) {
                XMLNode* side_effect_notes = diff_command->add_child(SIDE_EFFECT_REMOVALS_ELEMENT);
-               for_each(side_effect_removals.begin(), side_effect_removals.end(), 
+               for_each(side_effect_removals.begin(), side_effect_removals.end(),
                         boost::bind (
                                 boost::bind (&XMLNode::add_child_nocopy, side_effect_notes, _1),
                                 boost::bind (&NoteDiffCommand::marshal_note, this, _1)));
@@ -782,6 +799,19 @@ MidiModel::SysExDiffCommand::operator() ()
        {
                MidiModel::WriteLock lock (_model->edit_lock ());
 
+               for (list<SysExPtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
+                       _model->remove_sysex_unlocked (*i);
+               }
+
+               /* find any sysex events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->sysex) {
+                               i->sysex = _model->find_sysex (i->sysex_id);
+                               assert (i->sysex);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        switch (i->property) {
                        case Time:
@@ -799,6 +829,19 @@ MidiModel::SysExDiffCommand::undo ()
        {
                MidiModel::WriteLock lock (_model->edit_lock ());
 
+               for (list<SysExPtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
+                       _model->add_sysex_unlocked (*i);
+               }
+
+               /* find any sysex events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->sysex) {
+                               i->sysex = _model->find_sysex (i->sysex_id);
+                               assert (i->sysex);
+                       }
+               }
+
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
                        switch (i->property) {
                        case Time:
@@ -812,6 +855,12 @@ MidiModel::SysExDiffCommand::undo ()
        _model->ContentsChanged(); /* EMIT SIGNAL */
 }
 
+void
+MidiModel::SysExDiffCommand::remove (SysExPtr sysex)
+{
+       _removed.push_back(sysex);
+}
+
 XMLNode&
 MidiModel::SysExDiffCommand::marshal_change (const Change& change)
 {
@@ -881,11 +930,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change)
        */
 
        change.sysex = _model->find_sysex (sysex_id);
-
-       if (!change.sysex) {
-               warning << "Sys-ex #" << sysex_id << " not found in model - programmers should investigate this" << endmsg;
-               return change;
-       }
+       change.sysex_id = sysex_id;
 
        return change;
 }
@@ -920,7 +965,7 @@ MidiModel::SysExDiffCommand::get_state ()
        diff_command->add_property ("midi-source", _model->midi_source()->id().to_s());
 
        XMLNode* changes = diff_command->add_child(DIFF_SYSEXES_ELEMENT);
-       for_each (_changes.begin(), _changes.end(), 
+       for_each (_changes.begin(), _changes.end(),
                  boost::bind (
                          boost::bind (&XMLNode::add_child_nocopy, changes, _1),
                          boost::bind (&SysExDiffCommand::marshal_change, this, _1)));
@@ -973,6 +1018,7 @@ MidiModel::PatchChangeDiffCommand::change_channel (PatchChangePtr patch, uint8_t
        c.patch = patch;
        c.old_channel = patch->channel ();
        c.new_channel = channel;
+       c.patch_id = patch->id();
 
        _changes.push_back (c);
 }
@@ -985,6 +1031,7 @@ MidiModel::PatchChangeDiffCommand::change_program (PatchChangePtr patch, uint8_t
        c.patch = patch;
        c.old_program = patch->program ();
        c.new_program = program;
+       c.patch_id = patch->id();
 
        _changes.push_back (c);
 }
@@ -997,7 +1044,7 @@ MidiModel::PatchChangeDiffCommand::change_bank (PatchChangePtr patch, int bank)
        c.patch = patch;
        c.old_bank = patch->bank ();
        c.new_bank = bank;
-       
+
        _changes.push_back (c);
 }
 
@@ -1006,7 +1053,7 @@ MidiModel::PatchChangeDiffCommand::operator() ()
 {
        {
                MidiModel::WriteLock lock (_model->edit_lock ());
-               
+
                for (list<PatchChangePtr>::iterator i = _added.begin(); i != _added.end(); ++i) {
                        _model->add_patch_change_unlocked (*i);
                }
@@ -1014,7 +1061,16 @@ MidiModel::PatchChangeDiffCommand::operator() ()
                for (list<PatchChangePtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
                        _model->remove_patch_change_unlocked (*i);
                }
-               
+
+               /* find any patch change events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->patch) {
+                               i->patch = _model->find_patch_change (i->patch_id);
+                               assert (i->patch);
+                       }
+               }
+
                set<PatchChangePtr> temporary_removals;
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
@@ -1062,7 +1118,16 @@ MidiModel::PatchChangeDiffCommand::undo ()
                for (list<PatchChangePtr>::iterator i = _removed.begin(); i != _removed.end(); ++i) {
                        _model->add_patch_change_unlocked (*i);
                }
-               
+
+               /* find any patch change events that were missing when unmarshalling */
+
+               for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
+                       if (!i->patch) {
+                               i->patch = _model->find_patch_change (i->patch_id);
+                               assert (i->patch);
+                       }
+               }
+
                set<PatchChangePtr> temporary_removals;
 
                for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) {
@@ -1092,7 +1157,7 @@ MidiModel::PatchChangeDiffCommand::undo ()
                for (set<PatchChangePtr>::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) {
                        _model->add_patch_change_unlocked (*i);
                }
-               
+
        }
 
        _model->ContentsChanged (); /* EMIT SIGNAL */
@@ -1179,7 +1244,7 @@ MidiModel::PatchChangeDiffCommand::marshal_change (const Change& c)
                s << c.patch->id ();
                n->add_property ("id", s.str ());
        }
-       
+
        return *n;
 }
 
@@ -1189,15 +1254,15 @@ MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n)
        XMLProperty* prop;
        Evoral::event_id_t id;
        Evoral::MusicalTime time = 0;
-       uint8_t channel = 0;
-       uint8_t program = 0;
+       int channel = 0;
+       int program = 0;
        int bank = 0;
-
+       
        if ((prop = n->property ("id")) != 0) {
                istringstream s (prop->value());
                s >> id;
        }
-       
+
        if ((prop = n->property ("time")) != 0) {
                istringstream s (prop->value ());
                s >> time;
@@ -1228,6 +1293,7 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
 {
        XMLProperty* prop;
        Change c;
+       int an_int;
 
        prop = n->property ("property");
        assert (prop);
@@ -1236,7 +1302,11 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
        prop = n->property ("id");
        assert (prop);
        Evoral::event_id_t const id = atoi (prop->value().c_str());
-       
+
+       /* we need to load via an int intermediate for all properties that are 
+          actually uint8_t (char/byte).
+       */
+
        prop = n->property ("old");
        assert (prop);
        {
@@ -1244,11 +1314,14 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
                if (c.property == Time) {
                        s >> c.old_time;
                } else if (c.property == Channel) {
-                       s >> c.old_channel;
+                       s >> an_int;
+                       c.old_channel = an_int;
                } else if (c.property == Program) {
-                       s >> c.old_program;
+                       s >> an_int;
+                       c.old_program = an_int;
                } else if (c.property == Bank) {
-                       s >> c.old_bank;
+                       s >> an_int;
+                       c.old_bank = an_int;
                }
        }
 
@@ -1256,19 +1329,23 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n)
        assert (prop);
        {
                istringstream s (prop->value ());
+
                if (c.property == Time) {
                        s >> c.new_time;
                } else if (c.property == Channel) {
-                       s >> c.new_channel;
+                       s >> an_int;
+                       c.new_channel = an_int;
                } else if (c.property == Program) {
-                       s >> c.new_program;
+                       s >> an_int;
+                       c.new_program = an_int;
                } else if (c.property == Bank) {
-                       s >> c.new_bank;
+                       s >> an_int;
+                       c.new_bank = an_int;
                }
        }
 
        c.patch = _model->find_patch_change (id);
-       assert (c.patch);
+       c.patch_id = id;
 
        return c;
 }
@@ -1311,7 +1388,7 @@ MidiModel::PatchChangeDiffCommand::get_state ()
        diff_command->add_property("midi-source", _model->midi_source()->id().to_s());
 
        XMLNode* added = diff_command->add_child (ADDED_PATCH_CHANGES_ELEMENT);
-       for_each (_added.begin(), _added.end(), 
+       for_each (_added.begin(), _added.end(),
                  boost::bind (
                          boost::bind (&XMLNode::add_child_nocopy, added, _1),
                          boost::bind (&PatchChangeDiffCommand::marshal_patch_change, this, _1)
@@ -1319,13 +1396,13 @@ MidiModel::PatchChangeDiffCommand::get_state ()
                );
 
        XMLNode* removed = diff_command->add_child (REMOVED_PATCH_CHANGES_ELEMENT);
-       for_each (_removed.begin(), _removed.end(), 
+       for_each (_removed.begin(), _removed.end(),
                  boost::bind (
                          boost::bind (&XMLNode::add_child_nocopy, removed, _1),
                          boost::bind (&PatchChangeDiffCommand::marshal_patch_change, this, _1)
                          )
                );
-       
+
        XMLNode* changes = diff_command->add_child (DIFF_PATCH_CHANGES_ELEMENT);
        for_each (_changes.begin(), _changes.end(),
                  boost::bind (
@@ -1357,7 +1434,7 @@ MidiModel::write_to (boost::shared_ptr<MidiSource> source)
 
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        source->drop_model();
        source->mark_streaming_midi_write_started (note_mode());
 
@@ -1388,7 +1465,7 @@ MidiModel::sync_to_source ()
 
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        ms->mark_streaming_midi_write_started (note_mode());
 
        for (Evoral::Sequence<TimeType>::const_iterator i = begin(0, true); i != end(); ++i) {
@@ -1415,14 +1492,13 @@ MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::Music
 {
        ReadLock lock(read_lock());
        MidiStateTracker mst;
-       Evoral::MusicalTime extra_note_on_time = end_time;
 
        const bool old_percussive = percussive();
        set_percussive(false);
 
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
-       
+
        source->drop_model();
        source->mark_streaming_midi_write_started (note_mode());
 
@@ -1431,7 +1507,7 @@ MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::Music
 
                if (ev.time() >= begin_time && ev.time() < end_time) {
 
-                       const Evoral::MIDIEvent<Evoral::MusicalTime>* mev = 
+                       const Evoral::MIDIEvent<Evoral::MusicalTime>* mev =
                                static_cast<const Evoral::MIDIEvent<Evoral::MusicalTime>* > (&ev);
 
                        if (!mev) {
@@ -1442,36 +1518,20 @@ MidiModel::write_section_to (boost::shared_ptr<MidiSource> source, Evoral::Music
                        if (mev->is_note_off()) {
 
                                if (!mst.active (mev->note(), mev->channel())) {
-
-                                       /* add a note-on at the start of the range we're writing
-                                          to the file. velocity is just an arbitary reasonable value.
+                                       /* the matching note-on was outside the
+                                          time range we were given, so just
+                                          ignore this note-off.
                                        */
-
-                                       Evoral::MIDIEvent<Evoral::MusicalTime> on (mev->event_type(), extra_note_on_time, 3, 0, true);
-                                       on.set_type (mev->type());
-                                       on.set_note (mev->note());
-                                       on.set_channel (mev->channel());
-                                       on.set_velocity (mev->velocity());
-
-                                       cerr << "Add note on for odd note off, note = " << (int) on.note() << endl;
-                                       source->append_event_unlocked_beats (on);
-                                       mst.add (on.note(), on.channel());
-                                       mst.dump (cerr);
-                                       extra_note_on_time += 1.0/128.0;
+                                       continue;
                                }
 
-                               cerr << "MIDI Note off (note = " << (int) mev->note() << endl;
                                source->append_event_unlocked_beats (*i);
                                mst.remove (mev->note(), mev->channel());
-                               mst.dump (cerr);
 
                        } else if (mev->is_note_on()) {
-                               cerr << "MIDI Note on (note = " << (int) mev->note() << endl;
                                mst.add (mev->note(), mev->channel());
                                source->append_event_unlocked_beats(*i);
-                               mst.dump (cerr);
                        } else {
-                               cerr << "MIDI other event type\n";
                                source->append_event_unlocked_beats(*i);
                        }
                }
@@ -1568,7 +1628,7 @@ MidiModel::edit_lock()
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
        assert (ms);
 
-       Glib::Mutex::Lock* source_lock = new Glib::Mutex::Lock (ms->mutex());
+       Glib::Threads::Mutex::Lock* source_lock = new Glib::Threads::Mutex::Lock (ms->mutex());
        ms->invalidate(); // Release cached iterator's read lock on model
        return WriteLock(new WriteLockImpl(source_lock, _lock, _control_lock));
 }
@@ -1583,7 +1643,7 @@ MidiModel::write_lock()
        assert (ms);
 
        assert (!ms->mutex().trylock ());
-       return WriteLock(new WriteLockImpl(NULL, _lock, _control_lock));
+       return WriteLock(new WriteLockImpl(0, _lock, _control_lock));
 }
 
 int
@@ -1609,8 +1669,8 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
        TimeType note_length = note->length();
 
        DEBUG_TRACE (DEBUG::Sequence, string_compose ("%1 checking overlaps for note %2 @ %3\n", this, (int)note->note(), note->time()));
-       
-       for (Pitches::const_iterator i = p.lower_bound (search_note); 
+
+       for (Pitches::const_iterator i = p.lower_bound (search_note);
             i != p.end() && (*i)->note() == note->note(); ++i) {
 
                TimeType sb = (*i)->time();
@@ -1662,7 +1722,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
                        case InsertMergeExtend:
                                if (cmd) {
                                        cmd->change ((*i), NoteDiffCommand::Length, note->end_time() - (*i)->time());
-                               } 
+                               }
                                (*i)->set_length (note->end_time() - (*i)->time());
                                return -1; /* do not add the new note */
                                break;
@@ -1764,14 +1824,14 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
        if (set_note_time) {
                if (cmd) {
                        cmd->change (note, NoteDiffCommand::StartTime, note_time);
-               } 
+               }
                note->set_time (note_time);
        }
 
        if (set_note_length) {
                if (cmd) {
                        cmd->change (note, NoteDiffCommand::Length, note_length);
-               } 
+               }
                note->set_length (note_length);
        }
 
@@ -1779,7 +1839,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg)
 }
 
 InsertMergePolicy
-MidiModel::insert_merge_policy () const 
+MidiModel::insert_merge_policy () const
 {
        /* XXX ultimately this should be a per-track or even per-model policy */
        boost::shared_ptr<MidiSource> ms = _midi_source.lock ();
@@ -1792,7 +1852,7 @@ void
 MidiModel::set_midi_source (boost::shared_ptr<MidiSource> s)
 {
        boost::shared_ptr<MidiSource> old = _midi_source.lock ();
-       
+
        if (old) {
                old->invalidate ();
        }
@@ -1820,7 +1880,7 @@ MidiModel::set_midi_source (boost::shared_ptr<MidiSource> s)
 void
 MidiModel::source_interpolation_changed (Evoral::Parameter p, Evoral::ControlList::InterpolationStyle s)
 {
-       Glib::Mutex::Lock lm (_control_lock);
+       Glib::Threads::Mutex::Lock lm (_control_lock);
        control(p)->list()->set_interpolation (s);
 }
 
@@ -1839,7 +1899,7 @@ MidiModel::control_list_interpolation_changed (Evoral::Parameter p, Evoral::Cont
 void
 MidiModel::source_automation_state_changed (Evoral::Parameter p, AutoState s)
 {
-       Glib::Mutex::Lock lm (_control_lock);
+       Glib::Threads::Mutex::Lock lm (_control_lock);
        boost::shared_ptr<AutomationList> al = boost::dynamic_pointer_cast<AutomationList> (control(p)->list ());
        al->set_automation_state (s);
 }
@@ -1880,7 +1940,7 @@ MidiModel::midi_source ()
        return _midi_source.lock ();
 }
 
-/** Moves notes, controllers and sys-ex to insert silence at the start of the model.
+/** Moves notes, patch changes, controllers and sys-ex to insert silence at the start of the model.
  *  Adds commands to the session's current undo stack to reflect the movements.
  */
 void
@@ -1888,16 +1948,28 @@ MidiModel::insert_silence_at_start (TimeType t)
 {
        boost::shared_ptr<MidiSource> s = _midi_source.lock ();
        assert (s);
-       
+
        /* Notes */
 
        if (!notes().empty ()) {
                NoteDiffCommand* c = new_note_diff_command ("insert silence");
-               
+
                for (Notes::const_iterator i = notes().begin(); i != notes().end(); ++i) {
                        c->change (*i, NoteDiffCommand::StartTime, (*i)->time() + t);
                }
-               
+
+               apply_command_as_subcommand (s->session(), c);
+       }
+
+       /* Patch changes */
+
+       if (!patch_changes().empty ()) {
+               PatchChangeDiffCommand* c = new_patch_change_diff_command ("insert silence");
+
+               for (PatchChanges::const_iterator i = patch_changes().begin(); i != patch_changes().end(); ++i) {
+                       c->change_time (*i, (*i)->time() + t);
+               }
+
                apply_command_as_subcommand (s->session(), c);
        }
 
@@ -1936,20 +2008,20 @@ void
 MidiModel::transpose (TimeType from, TimeType to, int semitones)
 {
        boost::shared_ptr<const MidiSource> s = midi_source ();
-       
+
        NoteDiffCommand* c = new_note_diff_command (_("transpose"));
-       
+
        for (Notes::iterator i = notes().begin(); i != notes().end(); ++i) {
 
                if ((*i)->time() >= to) {
-                       
+
                        /* finished */
                        break;
-                       
+
                } else if ((*i)->time() >= from) {
 
                        int new_note = (*i)->note() + semitones;
-                       
+
                        if (new_note < 0) {
                                new_note = 0;
                        } else if (new_note > 127) {
@@ -1957,9 +2029,17 @@ MidiModel::transpose (TimeType from, TimeType to, int semitones)
                        }
 
                        c->change (*i, NoteDiffCommand::NoteNumber, (uint8_t) new_note);
-                       
+
                }
        }
 
        apply_command (s->session (), c);
 }
+
+void
+MidiModel::control_list_marked_dirty ()
+{
+       AutomatableSequence<Evoral::MusicalTime>::control_list_marked_dirty ();
+       
+       ContentsChanged (); /* EMIT SIGNAL */
+}