fix other potential crashes with non-existing plugins and presets caused by indiscrim...

[ardour.git] / libs / ardour / midi_ui.cc

diff --git a/libs/ardour/midi_ui.cc b/libs/ardour/midi_ui.cc
index 5d9407d5796dd7b9d312cfd925d8697263f88419..78da32e4273472449e6b023f889c24e3e5854c4b 100644 (file)
--- a/libs/ardour/midi_ui.cc
+++ b/libs/ardour/midi_ui.cc
@@ -45,8 +45,8 @@ MidiControlUI* MidiControlUI::_instance = 0;
 #include "pbd/abstract_ui.cc"  /* instantiate the template */
 
 MidiControlUI::MidiControlUI (Session& s)
-       : AbstractUI<MidiUIRequest> (_("midiui"))
-       , _session (s) 
+       : AbstractUI<MidiUIRequest> (X_("midiui"))
+       , _session (s)
 {
        MIDI::Manager::instance()->PortsChanged.connect_same_thread (rebind_connection, boost::bind (&MidiControlUI::change_midi_ports, this));
        _instance = this;
@@ -107,7 +107,7 @@ MidiControlUI::midi_input_handler (IOCondition ioc, MIDI::Port* port)
                CrossThreadChannel::drain (port->selectable());
 
                DEBUG_TRACE (DEBUG::MidiIO, string_compose ("data available on %1\n", port->name()));
-               nframes64_t now = _session.engine().frame_time();
+               framepos_t now = _session.engine().frame_time();
                port->parse (now);
        }
 
@@ -130,9 +130,14 @@ MidiControlUI::reset_ports ()
 {
        clear_ports ();
 
-       MIDI::Manager::PortList plist = MIDI::Manager::instance()->get_midi_ports ();
+       boost::shared_ptr<const MIDI::Manager::PortList> plist = MIDI::Manager::instance()->get_midi_ports ();
+
+       for (MIDI::Manager::PortList::const_iterator i = plist->begin(); i != plist->end(); ++i) {
+
+               if (!(*i)->centrally_parsed()) {
+                       continue;
+               }
 
-       for (MIDI::Manager::PortList::iterator i = plist.begin(); i != plist.end(); ++i) {
                int fd;
 
                if ((fd = (*i)->selectable ()) >= 0) {
@@ -145,20 +150,16 @@ MidiControlUI::reset_ports ()
 
                        port_sources.push_back (psrc->gobj());
                        g_source_ref (psrc->gobj());
-               } 
+               }
        }
 }
 
 void
 MidiControlUI::thread_init ()
-{      
+{
        struct sched_param rtparam;
 
-       char* c = new char[7];
-       strcpy (c, X_("midiUI"));
-       pthread_set_name (c);
-
-       cerr << "MIDI UI running\n";
+       pthread_set_name (X_("midiUI"));
 
        PBD::notify_gui_about_thread_creation (X_("gui"), pthread_self(), X_("MIDI"), 2048);
        SessionEvent::create_per_thread_pool (X_("MIDI I/O"), 128);