Add dialog to allow removal of plugin presets. Should fix #2662.

[ardour.git] / libs / ardour / port.cc

diff --git a/libs/ardour/port.cc b/libs/ardour/port.cc
index 6ae0c5d92bdae344fa9fa31c17053a44d3c97a28..fe234c593f10283ddd465218f275bade17ec74e6 100644 (file)
--- a/libs/ardour/port.cc
+++ b/libs/ardour/port.cc
@@ -34,8 +34,7 @@ using namespace std;
 using namespace ARDOUR;
 
 AudioEngine* Port::_engine = 0;
-nframes_t Port::_port_offset = 0;
-nframes_t Port::_buffer_size = 0;
+pframes_t Port::_buffer_size = 0;
 bool Port::_connecting_blocked = false;
 
 /** @param n Port short name */
@@ -52,7 +51,12 @@ Port::Port (std::string const & n, DataType t, Flags f)
 
        assert (_name.find_first_of (':') == std::string::npos);
 
+       if (!_engine->connected()) {
+               throw failed_constructor ();
+       }
+
        if ((_jack_port = jack_port_register (_engine->jack (), _name.c_str (), t.to_jack_type (), _flags, 0)) == 0) {
+                cerr << "Failed to register JACK port, reason is unknown from here\n";
                throw failed_constructor ();
        }
 }
@@ -60,7 +64,9 @@ Port::Port (std::string const & n, DataType t, Flags f)
 /** Port destructor */
 Port::~Port ()
 {
-       jack_port_unregister (_engine->jack (), _jack_port);
+       if (_engine->jack ()) {
+               jack_port_unregister (_engine->jack (), _jack_port);
+       }
 }
 
 /** @return true if this port is connected to anything */
@@ -110,15 +116,14 @@ Port::get_connections (std::vector<std::string> & c) const
 int
 Port::connect (std::string const & other)
 {
-       /* caller must hold process lock */
-
        std::string const other_shrt = _engine->make_port_name_non_relative (other);
        std::string const this_shrt = _engine->make_port_name_non_relative (_name);
 
        int r = 0;
 
-       if (_connecting_blocked)
+       if (_connecting_blocked) {
                return r;
+       }
 
        if (sends_output ()) {
                r = jack_connect (_engine->jack (), this_shrt.c_str (), other_shrt.c_str ());
@@ -136,8 +141,6 @@ Port::connect (std::string const & other)
 int
 Port::disconnect (std::string const & other)
 {
-       /* caller must hold process lock */
-
        std::string const other_shrt = _engine->make_port_name_non_relative (other);
        std::string const this_shrt = _engine->make_port_name_non_relative (_name);
 
@@ -217,7 +220,7 @@ Port::recompute_total_latency () const
 #endif
 }
 
-nframes_t
+framecnt_t
 Port::total_latency () const
 {
        jack_client_t* jack = _engine->jack();
@@ -290,7 +293,7 @@ Port::request_monitor_input (bool yn)
 }
 
 void
-Port::set_latency (nframes_t n)
+Port::set_latency (framecnt_t n)
 {
        jack_port_set_latency (_jack_port, n);
 }
@@ -316,3 +319,4 @@ Port::physically_connected () const
 
         return false;
 }
+