handle sidechain input changes

[ardour.git] / libs / ardour / route_group.cc

diff --git a/libs/ardour/route_group.cc b/libs/ardour/route_group.cc
index 032c85f6cea105540259f46f7a06375a30dc8836..9ad5aa91e6cfc16fd7caa47b0ad91446707b42c7 100644 (file)
--- a/libs/ardour/route_group.cc
+++ b/libs/ardour/route_group.cc
@@ -24,6 +24,7 @@
 #include "pbd/error.h"
 #include "pbd/enumwriter.h"
 #include "pbd/strsplit.h"
+#include "pbd/debug.h"
 
 #include "ardour/amp.h"
 #include "ardour/audio_track.h"
@@ -178,7 +179,7 @@ gain_t
 RouteGroup::get_min_factor (gain_t factor)
 {
        for (RouteList::iterator i = routes->begin(); i != routes->end(); ++i) {
-               gain_t const g = (*i)->amp()->gain();
+               gain_t const g = (*i)->gain_control()->get_value();
 
                if ((g + g * factor) >= 0.0f) {
                        continue;
@@ -198,7 +199,7 @@ gain_t
 RouteGroup::get_max_factor (gain_t factor)
 {
        for (RouteList::iterator i = routes->begin(); i != routes->end(); i++) {
-               gain_t const g = (*i)->amp()->gain();
+               gain_t const g = (*i)->gain_control()->get_value();
 
                // if the current factor woulnd't raise this route above maximum
                if ((g + g * factor) <= 1.99526231f) {
@@ -456,18 +457,26 @@ RouteGroup::make_subgroup (bool aux, Placement placement)
 
        for (RouteList::iterator i = routes->begin(); i != routes->end(); ++i) {
                if ((*i)->output()->n_ports().n_midi() != 0) {
-                       PBD::info << _("You cannot subgroup MIDI tracks at this time") << endmsg;
+                       PBD::warning << _("You cannot subgroup MIDI tracks at this time") << endmsg;
                        return;
                }
        }
 
        for (RouteList::iterator i = routes->begin(); i != routes->end(); ++i) {
+               if (!aux && nin != 0 && nin != (*i)->output()->n_ports().n_audio()) {
+                       PBD::warning << _("You cannot subgroup tracks with different number of outputs at this time.") << endmsg;
+                       return;
+               }
                nin = max (nin, (*i)->output()->n_ports().n_audio());
        }
 
        try {
-               /* use master bus etc. to determine default nouts */
-               rl = _session.new_audio_route (nin, 2, 0, 1);
+               /* use master bus etc. to determine default nouts.
+                *
+                * (since tracks can't have fewer outs than ins,
+                * "nin" currently defines the number of outpus if nin > 2)
+                */
+               rl = _session.new_audio_route (nin, 2 /*XXX*/, 0, 1);
        } catch (...) {
                return;
        }