Optimize automation-event process splitting

[ardour.git] / libs / ardour / session_rtevents.cc

diff --git a/libs/ardour/session_rtevents.cc b/libs/ardour/session_rtevents.cc
index 5572cdce708bbe5b9643b7458e472a843357d415..9e84d86a2392a5e52cc2e821351d3f0d43814b91 100644 (file)
--- a/libs/ardour/session_rtevents.cc
+++ b/libs/ardour/session_rtevents.cc
@@ -41,11 +41,9 @@ Session::set_controls (boost::shared_ptr<ControlList> cl, double val, Controllab
                return;
        }
 
-       std::cerr << "Session::set_controls called on " << cl->size() << " controls, group = " << enum_2_string (gcd) << std::endl;
-
        for (ControlList::iterator ci = cl->begin(); ci != cl->end(); ++ci) {
                /* as of july 2017 this is a no-op for everything except record enable */
-               (*ci)->do_pre_realtime_queue_stuff (val);
+               (*ci)->pre_realtime_queue_stuff (val, gcd);
        }
 
        queue_event (get_rt_event (cl, val, gcd));
@@ -66,9 +64,28 @@ Session::set_control (boost::shared_ptr<AutomationControl> ac, double val, Contr
 void
 Session::rt_set_controls (boost::shared_ptr<ControlList> cl, double val, Controllable::GroupControlDisposition gcd)
 {
+       /* Note that we require that all controls in the ControlList are of the
+          same type.
+       */
+       if (cl->empty()) {
+               return;
+       }
+
        for (ControlList::iterator c = cl->begin(); c != cl->end(); ++c) {
                (*c)->set_value (val, gcd);
        }
+
+       /* some controls need global work to take place after they are set. Do
+        * that here.
+        */
+
+       switch (cl->front()->parameter().type()) {
+       case SoloAutomation:
+               update_route_solo_state ();
+               break;
+       default:
+               break;
+       }
 }
 
 void
@@ -89,7 +106,7 @@ Session::rt_clear_all_solo_state (boost::shared_ptr<RouteList> rl, bool /* yn */
 
        _vca_manager->clear_all_solo_state ();
 
-       set_dirty();
+       update_route_solo_state ();
 }
 
 void