fix a bunch of memory leaks
[ardour.git] / libs / ardour / tempo.cc
index c08eaeabdccfec85839743991fb3d57a3f4d1b6e..621d1e2c747d0d30bfe4322184cee1db044b8b54 100644 (file)
 
 #include <algorithm>
 #include <stdexcept>
+#include <cmath>
 
 #include <unistd.h>
 
-#include <cmath>
-
-#include <glibmm/thread.h>
+#include <glibmm/threads.h>
 #include "pbd/xml++.h"
 #include "evoral/types.hpp"
 #include "ardour/debug.h"
 #include "ardour/tempo.h"
-#include "ardour/utils.h"
 
 #include "i18n.h"
 #include <locale.h>
@@ -45,24 +43,25 @@ using Timecode::BBT_Time;
 Meter    TempoMap::_default_meter (4.0, 4.0);
 Tempo    TempoMap::_default_tempo (120.0);
 
-double 
-Tempo::frames_per_beat (framecnt_t sr) const
-{
-       return  (60.0 * sr) / _beats_per_minute;
-}
-
 /***********************************************************************/
 
 double 
-Meter::frames_per_division (const Tempo& tempo, framecnt_t sr) const
+Meter::frames_per_grid (const Tempo& tempo, framecnt_t sr) const
 {
+       /* This is tempo- and meter-sensitive. The number it returns
+          is based on the interval between any two lines in the 
+          grid that is constructed from tempo and meter sections.
+
+          The return value IS NOT interpretable in terms of "beats".
+       */
+
        return (60.0 * sr) / (tempo.beats_per_minute() * (_note_type/tempo.note_type()));
 }
 
 double
 Meter::frames_per_bar (const Tempo& tempo, framecnt_t sr) const
 {
-       return frames_per_division (tempo, sr) * _divisions_per_bar;
+       return frames_per_grid (tempo, sr) * _divisions_per_bar;
 }
 
 /***********************************************************************/
@@ -156,8 +155,8 @@ void
 
 TempoSection::update_bar_offset_from_bbt (const Meter& m)
 {
-       _bar_offset = ((start().beats - 1) * BBT_Time::ticks_per_bar_division + start().ticks) / 
-               (m.divisions_per_bar() * BBT_Time::ticks_per_bar_division);
+       _bar_offset = ((start().beats - 1) * BBT_Time::ticks_per_beat + start().ticks) / 
+               (m.divisions_per_bar() * BBT_Time::ticks_per_beat);
 
        DEBUG_TRACE (DEBUG::TempoMath, string_compose ("Tempo set bar offset to %1 from %2 w/%3\n", _bar_offset, start(), m.divisions_per_bar()));
 }
@@ -174,9 +173,9 @@ TempoSection::update_bbt_time_from_bar_offset (const Meter& meter)
 
        new_start.bars = start().bars;
        
-       double ticks = BBT_Time::ticks_per_bar_division * meter.divisions_per_bar() * _bar_offset;
-       new_start.beats = (uint32_t) floor(ticks/BBT_Time::ticks_per_bar_division);
-       new_start.ticks = (uint32_t) fmod (ticks, BBT_Time::ticks_per_bar_division);
+       double ticks = BBT_Time::ticks_per_beat * meter.divisions_per_bar() * _bar_offset;
+       new_start.beats = (uint32_t) floor (ticks/BBT_Time::ticks_per_beat);
+       new_start.ticks = 0; /* (uint32_t) fmod (ticks, BBT_Time::ticks_per_beat); */
 
        /* remember the 1-based counting properties of beats */
        new_start.beats += 1;
@@ -277,9 +276,7 @@ struct MetricSectionSorter {
 
 TempoMap::TempoMap (framecnt_t fr)
 {
-       metrics = new Metrics;
        _frame_rate = fr;
-       last_bbt_valid = false;
        BBT_Time start;
 
        start.bars = 1;
@@ -294,8 +291,8 @@ TempoMap::TempoMap (framecnt_t fr)
 
        /* note: frame time is correct (zero) for both of these */
 
-       metrics->push_back (t);
-       metrics->push_back (m);
+       metrics.push_back (t);
+       metrics.push_back (m);
 }
 
 TempoMap::~TempoMap ()
@@ -308,14 +305,14 @@ TempoMap::remove_tempo (const TempoSection& tempo, bool complete_operation)
        bool removed = false;
 
        {
-               Glib::RWLock::WriterLock lm (lock);
+               Glib::Threads::RWLock::WriterLock lm (lock);
                Metrics::iterator i;
 
-               for (i = metrics->begin(); i != metrics->end(); ++i) {
+               for (i = metrics.begin(); i != metrics.end(); ++i) {
                        if (dynamic_cast<TempoSection*> (*i) != 0) {
                                if (tempo.frame() == (*i)->frame()) {
                                        if ((*i)->movable()) {
-                                               metrics->erase (i);
+                                               metrics.erase (i);
                                                removed = true;
                                                break;
                                        }
@@ -339,26 +336,24 @@ TempoMap::remove_meter (const MeterSection& tempo, bool complete_operation)
        bool removed = false;
 
        {
-               Glib::RWLock::WriterLock lm (lock);
+               Glib::Threads::RWLock::WriterLock lm (lock);
                Metrics::iterator i;
 
-               for (i = metrics->begin(); i != metrics->end(); ++i) {
+               for (i = metrics.begin(); i != metrics.end(); ++i) {
                        if (dynamic_cast<MeterSection*> (*i) != 0) {
                                if (tempo.frame() == (*i)->frame()) {
                                        if ((*i)->movable()) {
-                                               metrics->erase (i);
+                                               metrics.erase (i);
                                                removed = true;
                                                break;
                                        }
                                }
                        }
                }
-               
+
                if (removed && complete_operation) {
                        recompute_map (true);
                }
-
-
        }
 
        if (removed && complete_operation) {
@@ -369,9 +364,7 @@ TempoMap::remove_meter (const MeterSection& tempo, bool complete_operation)
 void
 TempoMap::do_insert (MetricSection* section)
 {
-       /* CALLER MUST HOLD WRITE LOCK */
-
-       bool reassign_tempo_bbt = false;
+       bool need_add = true;
 
        assert (section->start().ticks == 0);
 
@@ -385,8 +378,6 @@ TempoMap::do_insert (MetricSection* section)
                   sections based on this new meter.
                */
                
-               reassign_tempo_bbt = true;
-
                if ((section->start().beats != 1) || (section->start().ticks != 0)) {
                        
                        BBT_Time corrected = section->start();
@@ -400,59 +391,85 @@ TempoMap::do_insert (MetricSection* section)
                }
        }
 
-       Metrics::iterator i;
+       
 
        /* Look for any existing MetricSection that is of the same type and
-          at the same time as the new one, and remove it before adding
-          the new one.
+          in the same bar as the new one, and remove it before adding
+          the new one. Note that this means that if we find a matching,
+          existing section, we can break out of the loop since we're
+          guaranteed that there is only one such match.
        */
 
-       Metrics::iterator to_remove = metrics->end ();
+       for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
 
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
+               bool const iter_is_tempo = dynamic_cast<TempoSection*> (*i) != 0;
+               bool const insert_is_tempo = dynamic_cast<TempoSection*> (section) != 0;
 
-               int const c = (*i)->compare (*section);
+               if (iter_is_tempo && insert_is_tempo) {
 
-               if (c < 0) {
-                       /* this section is before the one to be added; go back round */
-                       continue;
-               } else if (c > 0) {
-                       /* this section is after the one to be added; there can't be any at the same time */
-                       break;
-               }
+                       /* Tempo sections */
 
-               /* hacky comparison of type */
-               bool const a = dynamic_cast<TempoSection*> (*i) != 0;
-               bool const b = dynamic_cast<TempoSection*> (section) != 0;
+                       if ((*i)->start().bars == section->start().bars &&
+                           (*i)->start().beats == section->start().beats) {
 
-               if (a == b) {
-                       to_remove = i;
-                       break;
-               }
-       }
+                               if (!(*i)->movable()) {
+                                       
+                                       /* can't (re)move this section, so overwrite
+                                        * its data content (but not its properties as
+                                        * a section).
+                                        */
+                                       
+                                       *(dynamic_cast<Tempo*>(*i)) = *(dynamic_cast<Tempo*>(section));
+                                       need_add = false;
+                               } else {
+                                       metrics.erase (i);
+                               }
+                               break;
+                       } 
 
-       if (to_remove != metrics->end()) {
-               /* remove the MetricSection at the same time as the one we are about to add */
-               metrics->erase (to_remove);
-       }
+               } else if (!iter_is_tempo && !insert_is_tempo) {
 
-       /* Add the given MetricSection */
+                       /* Meter Sections */
 
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
+                       if ((*i)->start().bars == section->start().bars) {
 
-               if ((*i)->compare (*section) < 0) {
-                       continue;
-               }
+                               if (!(*i)->movable()) {
+                                       
+                                       /* can't (re)move this section, so overwrite
+                                        * its data content (but not its properties as
+                                        * a section
+                                        */
+                                       
+                                       *(dynamic_cast<Meter*>(*i)) = *(dynamic_cast<Meter*>(section));
+                                       need_add = false;
+                               } else {
+                                       metrics.erase (i);
+                                       
+                               }
 
-               metrics->insert (i, section);
-               break;
+                               break;
+                       }
+               } else {
+                       /* non-matching types, so we don't care */
+               }
        }
 
-       if (i == metrics->end()) {
-               metrics->insert (metrics->end(), section);
+       /* Add the given MetricSection, if we didn't just reset an existing
+        * one above
+        */
+
+       if (need_add) {
+
+               Metrics::iterator i;
+
+               for (i = metrics.begin(); i != metrics.end(); ++i) {
+                       if ((*i)->start() > section->start()) {
+                               break;
+                       }
+               }
+               
+               metrics.insert (i, section);
        }
-       
-       recompute_map (reassign_tempo_bbt);
 }
 
 void
@@ -460,14 +477,16 @@ TempoMap::replace_tempo (const TempoSection& ts, const Tempo& tempo, const BBT_T
 {
        const TempoSection& first (first_tempo());
 
-       if (ts != first) {
+       if (ts.start() != first.start()) {
                remove_tempo (ts, false);
                add_tempo (tempo, where);
        } else {
-               Glib::RWLock::WriterLock lm (lock);
-               /* cannot move the first tempo section */
-               *((Tempo*)&first) = tempo;
-               recompute_map (false);
+               {
+                       Glib::Threads::RWLock::WriterLock lm (lock);
+                       /* cannot move the first tempo section */
+                       *((Tempo*)&first) = tempo;
+                       recompute_map (false);
+               }
        }
 
        PropertyChanged (PropertyChange ());
@@ -477,7 +496,7 @@ void
 TempoMap::add_tempo (const Tempo& tempo, BBT_Time where)
 {
        {
-               Glib::RWLock::WriterLock lm (lock);
+               Glib::Threads::RWLock::WriterLock lm (lock);
 
                /* new tempos always start on a beat */
                where.ticks = 0;
@@ -497,7 +516,7 @@ TempoMap::add_tempo (const Tempo& tempo, BBT_Time where)
                   now see if we can find better candidates.
                */
                
-               for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+               for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
                        
                        const MeterSection* m;
                        
@@ -513,10 +532,13 @@ TempoMap::add_tempo (const Tempo& tempo, BBT_Time where)
                ts->update_bar_offset_from_bbt (*meter);
 
                /* and insert it */
-
+               
                do_insert (ts);
+
+               recompute_map (false);
        }
 
+
        PropertyChanged (PropertyChange ());
 }
 
@@ -525,14 +547,16 @@ TempoMap::replace_meter (const MeterSection& ms, const Meter& meter, const BBT_T
 {
        const MeterSection& first (first_meter());
 
-       if (ms != first) {
+       if (ms.start() != first.start()) {
                remove_meter (ms, false);
                add_meter (meter, where);
        } else {
-               Glib::RWLock::WriterLock lm (lock);
-               /* cannot move the first meter section */
-               *((Meter*)&first) = meter;
-               recompute_map (true);
+               {
+                       Glib::Threads::RWLock::WriterLock lm (lock);
+                       /* cannot move the first meter section */
+                       *((Meter*)&first) = meter;
+                       recompute_map (true);
+               }
        }
 
        PropertyChanged (PropertyChange ());
@@ -542,7 +566,7 @@ void
 TempoMap::add_meter (const Meter& meter, BBT_Time where)
 {
        {
-               Glib::RWLock::WriterLock lm (lock);
+               Glib::Threads::RWLock::WriterLock lm (lock);
 
                /* a new meter always starts a new bar on the first beat. so
                   round the start time appropriately. remember that
@@ -558,10 +582,12 @@ TempoMap::add_meter (const Meter& meter, BBT_Time where)
 
                /* new meters *always* start on a beat. */
                where.ticks = 0;
-
+               
                do_insert (new MeterSection (where, meter.divisions_per_bar(), meter.note_divisor()));
+               recompute_map (true);
        }
 
+       
 #ifndef NDEBUG
        if (DEBUG_ENABLED(DEBUG::TempoMap)) {
                dump (std::cerr);
@@ -577,10 +603,10 @@ TempoMap::change_initial_tempo (double beats_per_minute, double note_type)
        Tempo newtempo (beats_per_minute, note_type);
        TempoSection* t;
 
-       for (Metrics::iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
                if ((t = dynamic_cast<TempoSection*> (*i)) != 0) {
-                       {
-                               Glib::RWLock::WriterLock lm (lock);
+                       { 
+                               Glib::Threads::RWLock::WriterLock lm (lock);
                                *((Tempo*) t) = newtempo;
                                recompute_map (false);
                        }
@@ -602,7 +628,7 @@ TempoMap::change_existing_tempo_at (framepos_t where, double beats_per_minute, d
        /* find the TempoSection immediately preceding "where"
         */
 
-       for (first = 0, i = metrics->begin(), prev = 0; i != metrics->end(); ++i) {
+       for (first = 0, i = metrics.begin(), prev = 0; i != metrics.end(); ++i) {
 
                if ((*i)->frame() > where) {
                        break;
@@ -630,7 +656,7 @@ TempoMap::change_existing_tempo_at (framepos_t where, double beats_per_minute, d
        /* reset */
 
        {
-               Glib::RWLock::WriterLock lm (lock);
+               Glib::Threads::RWLock::WriterLock lm (lock);
                /* cannot move the first tempo section */
                *((Tempo*)prev) = newtempo;
                recompute_map (false);
@@ -644,7 +670,7 @@ TempoMap::first_meter () const
 {
        const MeterSection *m = 0;
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
                if ((m = dynamic_cast<const MeterSection *> (*i)) != 0) {
                        return *m;
                }
@@ -660,7 +686,7 @@ TempoMap::first_tempo () const
 {
        const TempoSection *t = 0;
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
                if ((t = dynamic_cast<const TempoSection *> (*i)) != 0) {
                        return *t;
                }
@@ -671,137 +697,77 @@ TempoMap::first_tempo () const
        return *t;
 }
 
-void
-TempoMap::timestamp_metrics_from_audio_time ()
-{
-       Metrics::iterator i;
-       const MeterSection* meter;
-       const TempoSection* tempo;
-       MeterSection *m;
-       TempoSection *t;
-
-       meter = &first_meter ();
-       tempo = &first_tempo ();
-
-       BBT_Time start;
-       BBT_Time end;
-       
-       // cerr << "\n###################### TIMESTAMP via AUDIO ##############\n" << endl;
-
-       bool first = true;
-       MetricSection* prev = 0;
-
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
-
-               BBT_Time bbt;
-               TempoMetric metric (*meter, *tempo);
-
-               if (prev) {
-                       metric.set_start (prev->start());
-                       metric.set_frame (prev->frame());
-               } else {
-                       // metric will be at frames=0 bbt=1|1|0 by default
-                       // which is correct for our purpose
-               }
-
-               bbt_time_unlocked ((*i)->frame(), bbt);
-               
-               // cerr << "timestamp @ " << (*i)->frame() << " with " << bbt.bars << "|" << bbt.beats << "|" << bbt.ticks << " => ";
-
-               if (first) {
-                       first = false;
-               } else {
-
-                       if (bbt.ticks > BBT_Time::ticks_per_bar_division/2) {
-                               /* round up to next beat */
-                               bbt.beats += 1;
-                       }
-
-                       bbt.ticks = 0;
-
-                       if (bbt.beats != 1) {
-                               /* round up to next bar */
-                               bbt.bars += 1;
-                               bbt.beats = 1;
-                       }
-               }
-
-               // cerr << bbt << endl;
-
-               (*i)->set_start (bbt);
-                       
-               if ((t = dynamic_cast<TempoSection*>(*i)) != 0) {
-                       tempo = t;
-                       // cerr << "NEW TEMPO, frame = " << (*i)->frame() << " start = " << (*i)->start() <<endl;
-               } else if ((m = dynamic_cast<MeterSection*>(*i)) != 0) {
-                       meter = m;
-                       // cerr << "NEW METER, frame = " << (*i)->frame() << " start = " << (*i)->start() <<endl;
-               } else {
-                       fatal << _("programming error: unhandled MetricSection type") << endmsg;
-                       /*NOTREACHED*/
-               }
-
-               prev = (*i);
-       }
-
-#ifndef NDEBUG
-       if (DEBUG_ENABLED(DEBUG::TempoMap)) {
-               dump (cerr);
-       }
-#endif
-
-}
-
 void
 TempoMap::require_map_to (framepos_t pos)
 {
+       Glib::Threads::RWLock::WriterLock lm (lock);
+
        if (_map.empty() || _map.back().frame < pos) {
-               recompute_map (false, pos);
+               extend_map (pos);
        }
 }
 
 void
 TempoMap::require_map_to (const BBT_Time& bbt)
 {
-       if (_map.empty() || _map.back().bbt() < bbt) {
-               recompute_map (false, 99);
+       Glib::Threads::RWLock::WriterLock lm (lock);
+
+       /* since we have no idea where BBT is if its off the map, see the last
+        * point in the map is past BBT, and if not add an arbitrary amount of
+        * time until it is.
+        */
+
+       int additional_minutes = 1;
+       
+       while (1) {
+               if (!_map.empty() && _map.back().bar >= (bbt.bars + 1)) {
+                       break;
+               }
+               /* add some more distance, using bigger steps each time */
+               extend_map (_map.back().frame + (_frame_rate * 60 * additional_minutes));
+               additional_minutes *= 2;
        }
 }
 
 void
 TempoMap::recompute_map (bool reassign_tempo_bbt, framepos_t end)
 {
-       MeterSection* meter;
-       TempoSection* tempo;
-       TempoSection* ts;
-       MeterSection* ms;
-       double divisions_per_bar;
-       double beat_frames;
+       /* CALLER MUST HOLD WRITE LOCK */
+
+       MeterSection* meter = 0;
+       TempoSection* tempo = 0;
        double current_frame;
        BBT_Time current;
        Metrics::iterator next_metric;
 
        if (end < 0) {
-               if (_map.empty()) {
-                       /* compute 1 mins worth */
-                       end = _frame_rate * 60;
-               } else {
-                       end = _map.back().frame;
+
+               /* we will actually stop once we hit
+                  the last metric.
+               */
+               end = max_framepos;
+
+       } else {
+               if (!_map.empty ()) {
+                       /* never allow the map to be shortened */
+                       end = max (end, _map.back().frame);
                }
        }
 
        DEBUG_TRACE (DEBUG::TempoMath, string_compose ("recomputing tempo map, zero to %1\n", end));
-       
-       _map.clear ();
 
-       for (Metrics::iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
+               MeterSection* ms;
+
                if ((ms = dynamic_cast<MeterSection *> (*i)) != 0) {
                        meter = ms;
                        break;
                }
        }
 
-       for (Metrics::iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
+               TempoSection* ts;
+
                if ((ts = dynamic_cast<TempoSection *> (*i)) != 0) {
                        tempo = ts;
                        break;
@@ -818,17 +784,17 @@ TempoMap::recompute_map (bool reassign_tempo_bbt, framepos_t end)
        current.beats = 1;
        current.ticks = 0;
 
-       divisions_per_bar = meter->divisions_per_bar ();
-       beat_frames = meter->frames_per_division (*tempo,_frame_rate);
-       
        if (reassign_tempo_bbt) {
 
                MeterSection* rmeter = meter;
 
                DEBUG_TRACE (DEBUG::TempoMath, "\tUpdating tempo marks BBT time from bar offset\n");
 
-               for (Metrics::iterator i = metrics->begin(); i != metrics->end(); ++i) {
-                       
+               for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
+
+                       TempoSection* ts;
+                       MeterSection* ms;
+       
                        if ((ts = dynamic_cast<TempoSection*>(*i)) != 0) {
 
                                /* reassign the BBT time of this tempo section
@@ -846,35 +812,112 @@ TempoMap::recompute_map (bool reassign_tempo_bbt, framepos_t end)
                }
        }
 
-       DEBUG_TRACE (DEBUG::TempoMath, string_compose ("start with meter = %1 tempo = %2 dpb %3 fpb %4\n", 
-                                                      *((Meter*)meter), *((Tempo*)tempo), divisions_per_bar, beat_frames));
+       DEBUG_TRACE (DEBUG::TempoMath, string_compose ("start with meter = %1 tempo = %2\n", *((Meter*)meter), *((Tempo*)tempo)));
 
-       next_metric = metrics->begin();
+       next_metric = metrics.begin();
        ++next_metric; // skip meter (or tempo)
        ++next_metric; // skip tempo (or meter)
 
+       _map.clear ();
+
        DEBUG_TRACE (DEBUG::TempoMath, string_compose ("Add first bar at 1|1 @ %2\n", current.bars, current_frame));
-       _map.push_back (BBTPoint (*meter, *tempo,(framepos_t) llrint(current_frame), Bar, 1, 1));
+       _map.push_back (BBTPoint (*meter, *tempo,(framepos_t) llrint(current_frame), 1, 1));
+
+       if (end == 0) {
+               /* silly call from Session::process() during startup
+                */
+               return;
+       }
+
+       _extend_map (tempo, meter, next_metric, current, current_frame, end);
+}
+
+void
+TempoMap::extend_map (framepos_t end)
+{
+       /* CALLER MUST HOLD WRITE LOCK */
+
+       if (_map.empty()) {
+               recompute_map (false, end);
+               return;
+       }
+
+       BBTPointList::const_iterator i = _map.end();    
+       Metrics::iterator next_metric;
+
+       --i;
+
+       BBT_Time last_metric_start;
+
+       if ((*i).tempo->frame() > (*i).meter->frame()) {
+               last_metric_start = (*i).tempo->start();
+       } else {
+               last_metric_start = (*i).meter->start();
+       }
+
+       /* find the metric immediately after the tempo + meter sections for the
+        * last point in the map 
+        */
+
+       for (next_metric = metrics.begin(); next_metric != metrics.end(); ++next_metric) {
+               if ((*next_metric)->start() > last_metric_start) {
+                       break;
+               }
+       }
+
+       /* we cast away const here because this is the one place where we need
+        * to actually modify the frame time of each metric section. 
+        */
+
+       _extend_map (const_cast<TempoSection*> ((*i).tempo), 
+                    const_cast<MeterSection*> ((*i).meter),
+                    next_metric, BBT_Time ((*i).bar, (*i).beat, 0), (*i).frame, end);
+}
+
+void
+TempoMap::_extend_map (TempoSection* tempo, MeterSection* meter, 
+                      Metrics::iterator next_metric,
+                      BBT_Time current, framepos_t current_frame, framepos_t end)
+{
+       /* CALLER MUST HOLD WRITE LOCK */
+
+       TempoSection* ts;
+       MeterSection* ms;
+       double beat_frames;
+       double current_frame_exact;
+       framepos_t bar_start_frame;
+
+       DEBUG_TRACE (DEBUG::TempoMath, string_compose ("Extend map to %1 from %2 = %3\n", end, current, current_frame));
+
+       if (current.beats == 1) {
+               bar_start_frame = current_frame;
+       } else {
+               bar_start_frame = 0;
+       }
+
+       beat_frames = meter->frames_per_grid (*tempo,_frame_rate);
+       current_frame_exact = current_frame;
 
        while (current_frame < end) {
-               
+
                current.beats++;
-               current_frame += beat_frames;
+               current_frame_exact += beat_frames;
+               current_frame = llrint(current_frame_exact);
 
                if (current.beats > meter->divisions_per_bar()) {
                        current.bars++;
                        current.beats = 1;
                }
 
-               if (next_metric != metrics->end()) {
+               if (next_metric != metrics.end()) {
 
                        /* no operator >= so invert operator < */
 
                        DEBUG_TRACE (DEBUG::TempoMath, string_compose ("now at %1 next metric @ %2\n", current, (*next_metric)->start()));
 
                        if (!(current < (*next_metric)->start())) {
-                               
 
+               set_metrics:
                                if (((ts = dynamic_cast<TempoSection*> (*next_metric)) != 0)) {
 
                                        tempo = ts;
@@ -896,22 +939,47 @@ TempoMap::recompute_map (bool reassign_tempo_bbt, framepos_t end)
 
                                        if (tempo->start().ticks != 0) {
                                                
-                                               double next_beat_frames = meter->frames_per_division (*tempo,_frame_rate);                                      
+                                               double next_beat_frames = tempo->frames_per_beat (_frame_rate);                                 
                                                
                                                DEBUG_TRACE (DEBUG::TempoMath, string_compose ("bumped into non-beat-aligned tempo metric at %1 = %2, adjust next beat using %3\n",
-                                                                                              tempo->start(), current_frame, tempo->bar_offset()));
+                                                                                              tempo->start(), current_frame, tempo->bar_offset()));
                                                
                                                /* back up to previous beat */
-                                               current_frame -= beat_frames;
-                                               /* set tempo section location based on offset from last beat */
-                                               tempo->set_frame (current_frame + (ts->bar_offset() * beat_frames));
-                                               /* advance to the location of the new (adjusted) beat */
-                                               current_frame += (ts->bar_offset() * beat_frames) + ((1.0 - ts->bar_offset()) * next_beat_frames);
+                                               current_frame_exact -= beat_frames;
+                                               current_frame = llrint(current_frame_exact);
+
+                                               /* set tempo section location
+                                                * based on offset from last
+                                                * bar start 
+                                                */
+                                               tempo->set_frame (bar_start_frame + 
+                                                                 llrint ((ts->bar_offset() * meter->divisions_per_bar() * beat_frames)));
+                                               
+                                               /* advance to the location of
+                                                * the new (adjusted) beat. do
+                                                * this by figuring out the
+                                                * offset within the beat that
+                                                * would have been there
+                                                * without the tempo
+                                                * change. then stretch the
+                                                * beat accordingly.
+                                                */
+
+                                               double offset_within_old_beat = (tempo->frame() - current_frame) / beat_frames;
+
+                                               current_frame_exact += (offset_within_old_beat * beat_frames) + ((1.0 - offset_within_old_beat) * next_beat_frames);
+                                               current_frame = llrint(current_frame_exact);
+
+                                               /* next metric doesn't have to
+                                                * match this precisely to
+                                                * merit a reloop ...
+                                                */
                                                DEBUG_TRACE (DEBUG::TempoMath, string_compose ("Adjusted last beat to %1\n", current_frame));
+                                               
                                        } else {
                                                
                                                DEBUG_TRACE (DEBUG::TempoMath, string_compose ("bumped into beat-aligned tempo metric at %1 = %2\n",
-                                                                                              tempo->start(), current_frame));
+                                                                                              tempo->start(), current_frame));
                                                tempo->set_frame (current_frame);
                                        }
 
@@ -923,41 +991,55 @@ TempoMap::recompute_map (bool reassign_tempo_bbt, framepos_t end)
                                         * start of a bar.
                                         */
                                        
-                                       DEBUG_TRACE (DEBUG::TempoMath, string_compose ("bumped into meter section at %1 (%2)\n",
-                                                                                      meter->start(), current_frame));
+                                       DEBUG_TRACE (DEBUG::TempoMath, string_compose ("bumped into meter section at %1 vs %2 (%3)\n",
+                                                                                      meter->start(), current, current_frame));
                                        
                                        assert (current.beats == 1);
 
                                        meter->set_frame (current_frame);
                                }
                                
-                               divisions_per_bar = meter->divisions_per_bar ();
-                               beat_frames = meter->frames_per_division (*tempo, _frame_rate);
+                               beat_frames = meter->frames_per_grid (*tempo, _frame_rate);
                                
                                DEBUG_TRACE (DEBUG::TempoMath, string_compose ("New metric with beat frames = %1 dpb %2 meter %3 tempo %4\n", 
-                                                                              beat_frames, divisions_per_bar, *((Meter*)meter), *((Tempo*)tempo)));
+                                                                              beat_frames, meter->divisions_per_bar(), *((Meter*)meter), *((Tempo*)tempo)));
                        
                                ++next_metric;
+
+                               if (next_metric != metrics.end() && ((*next_metric)->start() == current)) {
+                                       /* same position so go back and set this one up before advancing
+                                        */
+                                       goto set_metrics;
+                               }
+
                        }
-               }
+               } 
 
                if (current.beats == 1) {
                        DEBUG_TRACE (DEBUG::TempoMath, string_compose ("Add Bar at %1|1 @ %2\n", current.bars, current_frame));
-                       _map.push_back (BBTPoint (*meter, *tempo,(framepos_t) llrint(current_frame), Bar, current.bars, 1));
+                       _map.push_back (BBTPoint (*meter, *tempo, current_frame, current.bars, 1));
+                       bar_start_frame = current_frame;
                } else {
                        DEBUG_TRACE (DEBUG::TempoMath, string_compose ("Add Beat at %1|%2 @ %3\n", current.bars, current.beats, current_frame));
-                       _map.push_back (BBTPoint (*meter, *tempo, (framepos_t) llrint(current_frame), Beat, current.bars, current.beats));
+                       _map.push_back (BBTPoint (*meter, *tempo, current_frame, current.bars, current.beats));
+               }
+
+               if (next_metric == metrics.end()) {
+                       /* no more metrics - we've timestamped them all, stop here */
+                       if (end == max_framepos) {
+                               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("stop extending map now that we've reach the end @ %1|%2 = %3\n",
+                                                                              current.bars, current.beats, current_frame));
+                               break;
+                       }
                }
        }
 }
 
 TempoMetric
-TempoMap::metric_at (framepos_t frame) const
+TempoMap::metric_at (framepos_t frame, Metrics::const_iterator* last) const
 {
-       Glib::RWLock::ReaderLock lm (lock);
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        TempoMetric m (first_meter(), first_tempo());
-       const Meter* meter;
-       const Tempo* tempo;
 
        /* at this point, we are *guaranteed* to have m.meter and m.tempo pointing
           at something, because we insert the default tempo and meter during
@@ -966,35 +1048,27 @@ TempoMap::metric_at (framepos_t frame) const
           now see if we can find better candidates.
        */
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
-
-               // cerr << "Looking at a metric section " << **i << endl;
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
 
                if ((*i)->frame() > frame) {
                        break;
                }
 
-               if ((tempo = dynamic_cast<const TempoSection*>(*i)) != 0) {
-                       m.set_tempo (*tempo);
-               } else if ((meter = dynamic_cast<const MeterSection*>(*i)) != 0) {
-                       m.set_meter (*meter);
-               }
+               m.set_metric(*i);
 
-               m.set_frame ((*i)->frame ());
-               m.set_start ((*i)->start ());
+               if (last) {
+                       *last = i;
+               }
        }
        
-       // cerr << "for framepos " << frame << " returning " << m.meter() << " @ " << m.tempo() << " location " << m.frame() << " = " << m.start() << endl;
        return m;
 }
 
 TempoMetric
 TempoMap::metric_at (BBT_Time bbt) const
 {
-       Glib::RWLock::ReaderLock lm (lock);
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        TempoMetric m (first_meter(), first_tempo());
-       const Meter* meter;
-       const Tempo* tempo;
 
        /* at this point, we are *guaranteed* to have m.meter and m.tempo pointing
           at something, because we insert the default tempo and meter during
@@ -1003,7 +1077,7 @@ TempoMap::metric_at (BBT_Time bbt) const
           now see if we can find better candidates.
        */
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
 
                BBT_Time section_start ((*i)->start());
 
@@ -1011,14 +1085,7 @@ TempoMap::metric_at (BBT_Time bbt) const
                        break;
                }
 
-               if ((tempo = dynamic_cast<const TempoSection*>(*i)) != 0) {
-                       m.set_tempo (*tempo);
-               } else if ((meter = dynamic_cast<const MeterSection*>(*i)) != 0) {
-                       m.set_meter (*meter);
-               }
-
-               m.set_frame ((*i)->frame ());
-               m.set_start (section_start);
+               m.set_metric (*i);
        }
 
        return m;
@@ -1027,39 +1094,75 @@ TempoMap::metric_at (BBT_Time bbt) const
 void
 TempoMap::bbt_time (framepos_t frame, BBT_Time& bbt)
 {
-       {
-               Glib::RWLock::ReaderLock lm (lock);
-               bbt_time_unlocked (frame, bbt);
+       require_map_to (frame);
+
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+
+       if (frame < 0) {
+               bbt.bars = 1;
+               bbt.beats = 1;
+               bbt.ticks = 0;
+               warning << string_compose (_("tempo map asked for BBT time at frame %1\n"), frame) << endmsg;
+               return;
        }
+
+       return bbt_time (frame, bbt, bbt_before_or_at (frame));
 }
 
 void
-TempoMap::bbt_time_unlocked (framepos_t frame, BBT_Time& bbt)
+TempoMap::bbt_time_rt (framepos_t frame, BBT_Time& bbt)
 {
-       BBTPointList::const_iterator i = bbt_before_or_at (frame);
+       Glib::Threads::RWLock::ReaderLock lm (lock, Glib::Threads::TRY_LOCK);
+
+       if (!lm.locked()) {
+               throw std::logic_error ("TempoMap::bbt_time_rt() could not lock tempo map");
+       }
        
+       if (_map.empty() || _map.back().frame < frame) {
+               throw std::logic_error (string_compose ("map not long enough to reach %1", frame));
+       }
+
+       return bbt_time (frame, bbt, bbt_before_or_at (frame));
+}
+
+void
+TempoMap::bbt_time (framepos_t frame, BBT_Time& bbt, const BBTPointList::const_iterator& i)
+{
+       /* CALLER MUST HOLD READ LOCK */
+
        bbt.bars = (*i).bar;
        bbt.beats = (*i).beat;
 
        if ((*i).frame == frame) {
                bbt.ticks = 0;
        } else {
-               bbt.ticks = llrint (((frame - (*i).frame) / (*i).meter->frames_per_division(*((*i).tempo), _frame_rate)) /
-                                   BBT_Time::ticks_per_bar_division);
+               bbt.ticks = llrint (((frame - (*i).frame) / (*i).tempo->frames_per_beat(_frame_rate)) *
+                                   BBT_Time::ticks_per_beat);
        }
 }
 
 framepos_t
 TempoMap::frame_time (const BBT_Time& bbt)
 {
-       Glib::RWLock::ReaderLock lm (lock);
+       if (bbt.bars < 1) {
+               warning << string_compose (_("tempo map asked for frame time at bar < 1  (%1)\n"), bbt) << endmsg;
+               return 0;
+       }
+       
+       if (bbt.beats < 1) {
+               throw std::logic_error ("beats are counted from one");
+       }
 
-       BBTPointList::const_iterator s = bbt_point_for (BBT_Time (1, 1, 0));
-       BBTPointList::const_iterator e = bbt_point_for (BBT_Time (bbt.bars, bbt.beats, 0));
+       require_map_to (bbt);
+
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+
+       BBTPointList::const_iterator s = bbt_before_or_at (BBT_Time (1, 1, 0));
+       BBTPointList::const_iterator e = bbt_before_or_at (BBT_Time (bbt.bars, bbt.beats, 0));
 
        if (bbt.ticks != 0) {
                return ((*e).frame - (*s).frame) + 
-                       llrint ((*e).meter->frames_per_division (*(*e).tempo, _frame_rate) * (bbt.ticks/BBT_Time::ticks_per_bar_division));
+                       llrint ((*e).tempo->frames_per_beat (_frame_rate) * (bbt.ticks/BBT_Time::ticks_per_beat));
        } else {
                return ((*e).frame - (*s).frame);
        }
@@ -1068,42 +1171,32 @@ TempoMap::frame_time (const BBT_Time& bbt)
 framecnt_t
 TempoMap::bbt_duration_at (framepos_t pos, const BBT_Time& bbt, int dir)
 {
-       Glib::RWLock::ReaderLock lm (lock);
-       framecnt_t frames = 0;
        BBT_Time when;
-
        bbt_time (pos, when);
-       frames = bbt_duration_at_unlocked (when, bbt,dir);
-
-       return frames;
+       
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       return bbt_duration_at_unlocked (when, bbt, dir);
 }
 
 framecnt_t
-TempoMap::bbt_duration_at_unlocked (const BBT_Time& when, const BBT_Time& bbt, int dir
+TempoMap::bbt_duration_at_unlocked (const BBT_Time& when, const BBT_Time& bbt, int /*dir*/
 {
        if (bbt.bars == 0 && bbt.beats == 0 && bbt.ticks == 0) {
                return 0;
        }
 
        /* round back to the previous precise beat */
-       BBTPointList::const_iterator wi = bbt_point_for (BBT_Time (when.bars, when.beats, 0));
+       BBTPointList::const_iterator wi = bbt_before_or_at (BBT_Time (when.bars, when.beats, 0));
        BBTPointList::const_iterator start (wi);
-       double tick_frames = 0;
 
        assert (wi != _map.end());
 
-       /* compute how much rounding we did because of non-zero ticks */
-
-       if (when.ticks != 0) {
-               tick_frames = (*wi).meter->frames_per_division (*(*wi).tempo, _frame_rate) * (when.ticks/BBT_Time::ticks_per_bar_division);
-       }
-       
        uint32_t bars = 0;
        uint32_t beats = 0;
 
        while (wi != _map.end() && bars < bbt.bars) {
                ++wi;
-               if ((*wi).type == Bar) {
+               if ((*wi).is_bar()) {
                        ++bars;
                }
        }
@@ -1118,64 +1211,70 @@ TempoMap::bbt_duration_at_unlocked (const BBT_Time& when, const BBT_Time& bbt, i
        /* add any additional frames related to ticks in the added value */
 
        if (bbt.ticks != 0) {
-               tick_frames += (*wi).meter->frames_per_division (*(*wi).tempo, _frame_rate) * (bbt.ticks/BBT_Time::ticks_per_bar_division);
+               return ((*wi).frame - (*start).frame) + 
+                       (*wi).tempo->frames_per_beat (_frame_rate) * (bbt.ticks/BBT_Time::ticks_per_beat);
+       } else {
+               return ((*wi).frame - (*start).frame);
        }
-
-       return ((*wi).frame - (*start).frame) + llrint (tick_frames);
 }
 
 framepos_t
 TempoMap::round_to_bar (framepos_t fr, int dir)
 {
-       {
-               Glib::RWLock::ReaderLock lm (lock);
-               return round_to_type (fr, dir, Bar);
-       }
+       return round_to_type (fr, dir, Bar);
 }
 
 framepos_t
 TempoMap::round_to_beat (framepos_t fr, int dir)
 {
-       {
-               Glib::RWLock::ReaderLock lm (lock);
-               return round_to_type (fr, dir, Beat);
-       }
+       return round_to_type (fr, dir, Beat);
 }
 
 framepos_t
 TempoMap::round_to_beat_subdivision (framepos_t fr, int sub_num, int dir)
 {
+       require_map_to (fr);
+
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       BBTPointList::const_iterator i = bbt_before_or_at (fr);
        BBT_Time the_beat;
-       uint32_t ticks_one_half_subdivisions_worth;
        uint32_t ticks_one_subdivisions_worth;
        uint32_t difference;
 
-       bbt_time(fr, the_beat);
+       bbt_time (fr, the_beat, i);
+
+       DEBUG_TRACE (DEBUG::SnapBBT, string_compose ("round %1 to nearest 1/%2 beat, before-or-at = %3 @ %4|%5 precise = %6\n",
+                                                    fr, sub_num, (*i).frame, (*i).bar, (*i).beat, the_beat));
 
-       ticks_one_subdivisions_worth = (uint32_t)BBT_Time::ticks_per_bar_division / sub_num;
-       ticks_one_half_subdivisions_worth = ticks_one_subdivisions_worth / 2;
+       ticks_one_subdivisions_worth = (uint32_t)BBT_Time::ticks_per_beat / sub_num;
 
        if (dir > 0) {
 
-               /* round to next */
+               /* round to next (even if we're on a subdivision */
 
                uint32_t mod = the_beat.ticks % ticks_one_subdivisions_worth;
 
                if (mod == 0) {
                        /* right on the subdivision, so the difference is just the subdivision ticks */
-                       difference = ticks_one_subdivisions_worth;
+                       the_beat.ticks += ticks_one_subdivisions_worth;
 
                } else {
                        /* not on subdivision, compute distance to next subdivision */
 
-                       difference = ticks_one_subdivisions_worth - mod;
+                       the_beat.ticks += ticks_one_subdivisions_worth - mod;
                }
 
-               the_beat = bbt_add (the_beat, BBT_Time (0, 0, difference));
+               if (the_beat.ticks > BBT_Time::ticks_per_beat) {
+                       assert (i != _map.end());
+                       ++i;
+                       assert (i != _map.end());
+                       the_beat.ticks -= BBT_Time::ticks_per_beat;
+               } 
+
 
        } else if (dir < 0) {
 
-               /* round to previous */
+               /* round to previous (even if we're on a subdivision) */
 
                uint32_t mod = the_beat.ticks % ticks_one_subdivisions_worth;
 
@@ -1190,31 +1289,72 @@ TempoMap::round_to_beat_subdivision (framepos_t fr, int sub_num, int dir)
                        difference = mod;
                }
 
-               try {
-                       the_beat = bbt_subtract (the_beat, BBT_Time (0, 0, difference));
-               } catch (...) {
-                       /* can't go backwards from wherever pos is, so just return it */
-                       return fr;
+               if (the_beat.ticks < difference) {
+                       if (i == _map.begin()) {
+                               /* can't go backwards from wherever pos is, so just return it */
+                               return fr;
+                       }
+                       --i;
+                       the_beat.ticks = BBT_Time::ticks_per_beat - the_beat.ticks;
+               } else {
+                       the_beat.ticks -= difference;
                }
 
        } else {
                /* round to nearest */
 
-               if (the_beat.ticks % ticks_one_subdivisions_worth > ticks_one_half_subdivisions_worth) {
-                       difference = ticks_one_subdivisions_worth - (the_beat.ticks % ticks_one_subdivisions_worth);
-                       the_beat = bbt_add (the_beat, BBT_Time (0, 0, difference));
-               } else {
-                       // difference = ticks_one_subdivisions_worth - (the_beat.ticks % ticks_one_subdivisions_worth);
-                       the_beat.ticks -= the_beat.ticks % ticks_one_subdivisions_worth;
-               }
-       }
+               double rem;
 
-       return frame_time (the_beat);
-}
+               /* compute the distance to the previous and next subdivision */
+               
+               if ((rem = fmod ((double) the_beat.ticks, (double) ticks_one_subdivisions_worth)) > ticks_one_subdivisions_worth/2.0) {
+                       
+                       /* closer to the next subdivision, so shift forward */
 
-framepos_t
-TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
-{
+                       the_beat.ticks = lrint (the_beat.ticks + (ticks_one_subdivisions_worth - rem));
+
+                       DEBUG_TRACE (DEBUG::SnapBBT, string_compose ("moved forward to %1\n", the_beat.ticks));
+
+                       if (the_beat.ticks > BBT_Time::ticks_per_beat) {
+                               assert (i != _map.end());
+                               ++i;
+                               assert (i != _map.end());
+                               the_beat.ticks -= BBT_Time::ticks_per_beat;
+                               DEBUG_TRACE (DEBUG::SnapBBT, string_compose ("fold beat to %1\n", the_beat));
+                       } 
+
+               } else if (rem > 0) {
+                       
+                       /* closer to previous subdivision, so shift backward */
+
+                       if (rem > the_beat.ticks) {
+                               if (i == _map.begin()) {
+                                       /* can't go backwards past zero, so ... */
+                                       return 0;
+                               }
+                               /* step back to previous beat */
+                               --i;
+                               the_beat.ticks = lrint (BBT_Time::ticks_per_beat - rem);
+                               DEBUG_TRACE (DEBUG::SnapBBT, string_compose ("step back beat to %1\n", the_beat));
+                       } else {
+                               the_beat.ticks = lrint (the_beat.ticks - rem);
+                               DEBUG_TRACE (DEBUG::SnapBBT, string_compose ("moved backward to %1\n", the_beat.ticks));
+                       }
+               } else {
+                       /* on the subdivision, do nothing */
+               }
+       }
+
+       return (*i).frame + (the_beat.ticks/BBT_Time::ticks_per_beat) * 
+               (*i).tempo->frames_per_beat (_frame_rate);
+}
+
+framepos_t
+TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
+{
+       require_map_to (frame);
+
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        BBTPointList::const_iterator fi;
 
        if (dir > 0) {
@@ -1225,18 +1365,23 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
 
        assert (fi != _map.end());
 
-       DEBUG_TRACE(DEBUG::SnapBBT, string_compose ("round from %1 (%3|%4 @ %5) to bars in direction %2\n", frame, dir, (*fi).bar, (*fi).beat, (*fi).frame));
+       DEBUG_TRACE (DEBUG::SnapBBT, string_compose ("round from %1 (%3|%4 @ %5) to %6 in direction %2\n", frame, dir, (*fi).bar, (*fi).beat, (*fi).frame,
+                                                    (type == Bar ? "bar" : "beat")));
                
        switch (type) {
        case Bar:
                if (dir < 0) {
                        /* find bar previous to 'frame' */
 
-                       if ((*fi).beat == 1 && (*fi).frame == frame) {
+                       if (fi == _map.begin()) {
+                               return 0;
+                       }
+
+                       if ((*fi).is_bar() && (*fi).frame == frame) {
                                --fi;
                        }
 
-                       while ((*fi).beat > 1) {
+                       while (!(*fi).is_bar()) {
                                if (fi == _map.begin()) {
                                        break;
                                }
@@ -1250,11 +1395,11 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
 
                        /* find bar following 'frame' */
 
-                       if ((*fi).beat == 1 && (*fi).frame == frame) {
+                       if ((*fi).is_bar() && (*fi).frame == frame) {
                                ++fi;
                        }
 
-                       while ((*fi).beat != 1) {
+                       while (!(*fi).is_bar()) {
                                fi++;
                                if (fi == _map.end()) {
                                        --fi;
@@ -1273,6 +1418,10 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
                        BBTPointList::const_iterator prev = fi;
                        BBTPointList::const_iterator next = fi;
 
+                       if ((*fi).frame == frame) {
+                               return frame;
+                       }
+
                        while ((*prev).beat != 1) {
                                if (prev == _map.begin()) {
                                        break;
@@ -1280,15 +1429,11 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
                                prev--;
                        }
 
-                       while ((*next).beat != 1) {
+                       while ((next != _map.end()) && (*next).beat != 1) {
                                next++;
-                               if (next == _map.end()) {
-                                       --next;
-                                       break;
-                               }
                        }
 
-                       if ((frame - (*prev).frame) < ((*next).frame - frame)) {
+                       if ((next == _map.end()) || (frame - (*prev).frame) < ((*next).frame - frame)) {
                                return (*prev).frame;
                        } else {
                                return (*next).frame;
@@ -1300,6 +1445,11 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
 
        case Beat:
                if (dir < 0) {
+
+                       if (fi == _map.begin()) {
+                               return 0;
+                       }
+
                        if ((*fi).frame >= frame) {
                                DEBUG_TRACE (DEBUG::SnapBBT, "requested frame is on beat, step back\n");
                                --fi;
@@ -1323,10 +1473,14 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
 
                        BBTPointList::const_iterator prev = fi;
                        BBTPointList::const_iterator next = fi;
-                       --prev;
+
+                       /* fi is already the beat before_or_at frame, and
+                          we've just established that its not at frame, so its
+                          the beat before frame.
+                       */
                        ++next;
                        
-                       if ((frame - (*prev).frame) < ((*next).frame - frame)) {
+                       if ((next == _map.end()) || (frame - (*prev).frame) < ((*next).frame - frame)) {
                                return (*prev).frame;
                        } else {
                                return (*next).frame;
@@ -1341,31 +1495,29 @@ TempoMap::round_to_type (framepos_t frame, int dir, BBTPointType type)
 }
 
 void
-TempoMap::map (TempoMap::BBTPointList& points, framepos_t lower, framepos_t upper) 
+TempoMap::get_grid (TempoMap::BBTPointList::const_iterator& begin, 
+                   TempoMap::BBTPointList::const_iterator& end, 
+                   framepos_t lower, framepos_t upper) 
 {
-       if (_map.empty() || upper >= _map.back().frame) {
-               recompute_map (false, upper);
-       }
-
-       for (BBTPointList::const_iterator i = _map.begin(); i != _map.end(); ++i) {
-               if ((*i).frame < lower) {
-                       continue;
-               }
-               if ((*i).frame >= upper) {
-                       break;
+       { 
+               Glib::Threads::RWLock::WriterLock lm (lock);
+               if (_map.empty() || (_map.back().frame < upper)) {
+                       recompute_map (false, upper);
                }
-               points.push_back (*i);
        }
+
+       begin = lower_bound (_map.begin(), _map.end(), lower);
+       end = upper_bound (_map.begin(), _map.end(), upper);
 }
 
 const TempoSection&
 TempoMap::tempo_section_at (framepos_t frame) const
 {
-       Glib::RWLock::ReaderLock lm (lock);
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        Metrics::const_iterator i;
        TempoSection* prev = 0;
 
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
+       for (i = metrics.begin(); i != metrics.end(); ++i) {
                TempoSection* t;
 
                if ((t = dynamic_cast<TempoSection*> (*i)) != 0) {
@@ -1407,8 +1559,8 @@ TempoMap::get_state ()
        XMLNode *root = new XMLNode ("TempoMap");
 
        {
-               Glib::RWLock::ReaderLock lm (lock);
-               for (i = metrics->begin(); i != metrics->end(); ++i) {
+               Glib::Threads::RWLock::ReaderLock lm (lock);
+               for (i = metrics.begin(); i != metrics.end(); ++i) {
                        root->add_child_nocopy ((*i)->get_state());
                }
        }
@@ -1420,14 +1572,13 @@ int
 TempoMap::set_state (const XMLNode& node, int /*version*/)
 {
        {
-               Glib::RWLock::WriterLock lm (lock);
+               Glib::Threads::RWLock::WriterLock lm (lock);
 
                XMLNodeList nlist;
                XMLNodeConstIterator niter;
-               Metrics old_metrics (*metrics);
+               Metrics old_metrics (metrics);
                MeterSection* last_meter = 0;
-
-               metrics->clear();
+               metrics.clear();
 
                nlist = node.children();
                
@@ -1438,7 +1589,7 @@ TempoMap::set_state (const XMLNode& node, int /*version*/)
 
                                try {
                                        TempoSection* ts = new TempoSection (*child);
-                                       metrics->push_back (ts);
+                                       metrics.push_back (ts);
 
                                        if (ts->bar_offset() < 0.0) {
                                                if (last_meter) {
@@ -1449,7 +1600,7 @@ TempoMap::set_state (const XMLNode& node, int /*version*/)
 
                                catch (failed_constructor& err){
                                        error << _("Tempo map: could not set new state, restoring old one.") << endmsg;
-                                       *metrics = old_metrics;
+                                       metrics = old_metrics;
                                        break;
                                }
 
@@ -1457,24 +1608,46 @@ TempoMap::set_state (const XMLNode& node, int /*version*/)
 
                                try {
                                        MeterSection* ms = new MeterSection (*child);
-                                       metrics->push_back (ms);
+                                       metrics.push_back (ms);
                                        last_meter = ms;
                                }
 
                                catch (failed_constructor& err) {
                                        error << _("Tempo map: could not set new state, restoring old one.") << endmsg;
-                                       *metrics = old_metrics;
+                                       metrics = old_metrics;
                                        break;
                                }
                        }
                }
 
                if (niter == nlist.end()) {
-
                        MetricSectionSorter cmp;
-                       metrics->sort (cmp);
-                       recompute_map (true);
+                       metrics.sort (cmp);
+               }
+
+               /* check for multiple tempo/meters at the same location, which
+                  ardour2 somehow allowed.
+               */
+
+               Metrics::iterator prev = metrics.end();
+               for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
+                       if (prev != metrics.end()) {
+                               if (dynamic_cast<MeterSection*>(*prev) && dynamic_cast<MeterSection*>(*i)) {
+                                       if ((*prev)->start() == (*i)->start()) {
+                                               error << string_compose (_("Multiple meter definitions found at %1"), (*prev)->start()) << endmsg;
+                                               return -1;
+                                       }
+                               } else if (dynamic_cast<TempoSection*>(*prev) && dynamic_cast<TempoSection*>(*i)) {
+                                       if ((*prev)->start() == (*i)->start()) {
+                                               error << string_compose (_("Multiple tempo definitions found at %1"), (*prev)->start()) << endmsg;
+                                               return -1;
+                                       }
+                               }
+                       }
+                       prev = i;
                }
+
+               recompute_map (true, -1);
        }
 
        PropertyChanged (PropertyChange ());
@@ -1485,10 +1658,11 @@ TempoMap::set_state (const XMLNode& node, int /*version*/)
 void
 TempoMap::dump (std::ostream& o) const
 {
+       Glib::Threads::RWLock::ReaderLock lm (lock, Glib::Threads::TRY_LOCK);
        const MeterSection* m;
        const TempoSection* t;
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
 
                if ((t = dynamic_cast<const TempoSection*>(*i)) != 0) {
                        o << "Tempo @ " << *i << " (Bar-offset: " << t->bar_offset() << ") " << t->beats_per_minute() << " BPM (pulse = 1/" << t->note_type() << ") at " << t->start() << " frame= " << t->frame() << " (movable? "
@@ -1503,10 +1677,10 @@ TempoMap::dump (std::ostream& o) const
 int
 TempoMap::n_tempos() const
 {
-       Glib::RWLock::ReaderLock lm (lock);
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        int cnt = 0;
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
                if (dynamic_cast<const TempoSection*>(*i) != 0) {
                        cnt++;
                }
@@ -1518,10 +1692,10 @@ TempoMap::n_tempos() const
 int
 TempoMap::n_meters() const
 {
-       Glib::RWLock::ReaderLock lm (lock);
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        int cnt = 0;
 
-       for (Metrics::const_iterator i = metrics->begin(); i != metrics->end(); ++i) {
+       for (Metrics::const_iterator i = metrics.begin(); i != metrics.end(); ++i) {
                if (dynamic_cast<const MeterSection*>(*i) != 0) {
                        cnt++;
                }
@@ -1533,383 +1707,294 @@ TempoMap::n_meters() const
 void
 TempoMap::insert_time (framepos_t where, framecnt_t amount)
 {
-       for (Metrics::iterator i = metrics->begin(); i != metrics->end(); ++i) {
-               if ((*i)->frame() >= where && (*i)->movable ()) {
-                       (*i)->set_frame ((*i)->frame() + amount);
-               }
-       }
-
-       timestamp_metrics_from_audio_time ();
-
-       PropertyChanged (PropertyChange ());
-}
-
-BBT_Time
-TempoMap::bbt_add (const BBT_Time& start, const BBT_Time& other) const
-{
-       TempoMetric metric =  metric_at (start);
-       return bbt_add (start, other, metric);
-}
-
-/**
- * add the BBT interval @param increment to  @param start and return the result
- */
-BBT_Time
-TempoMap::bbt_add (const BBT_Time& start, const BBT_Time& increment, const TempoMetric& /*metric*/) const
-{
-       BBT_Time result = start;
-       BBT_Time op = increment; /* argument is const, but we need to modify it */
-       uint32_t ticks = result.ticks + op.ticks;
-
-       if (ticks >= BBT_Time::ticks_per_bar_division) {
-               op.beats++;
-               result.ticks = ticks % (uint32_t) BBT_Time::ticks_per_bar_division;
-       } else {
-               result.ticks += op.ticks;
-       }
-
-       /* now comes the complicated part. we have to add one beat a time,
-          checking for a new metric on every beat.
-       */
-
-       /* grab all meter sections */
-
-       list<const MeterSection*> meter_sections;
-
-       for (Metrics::const_iterator x = metrics->begin(); x != metrics->end(); ++x) {
-               const MeterSection* ms;
-               if ((ms = dynamic_cast<const MeterSection*>(*x)) != 0) {
-                       meter_sections.push_back (ms);
-               }
-       }
-
-       assert (!meter_sections.empty());
-
-       list<const MeterSection*>::const_iterator next_meter;
-       const Meter* meter = 0;
-
-       /* go forwards through the meter sections till we get to the one
-          covering the current value of result. this positions i to point to
-          the next meter section too, or the end.
-       */
-
-       for (next_meter = meter_sections.begin(); next_meter != meter_sections.end(); ++next_meter) {
-
-               if (result < (*next_meter)->start()) {
-                       /* this metric is past the result time. stop looking, we have what we need */
-                       break;
-               }
-
-               if (result == (*next_meter)->start()) {
-                       /* this meter section starts at result, push i beyond it so that it points
-                          to the NEXT section, opwise we will get stuck later, and use this meter section.
-                       */
-                       meter = *next_meter;
-                       ++next_meter;
-                       break;
-               }
-
-               meter = *next_meter;
-       }
-
-       assert (meter != 0);
-
-       /* OK, now have the meter for the bar start we are on, and i is an iterator
-          that points to the metric after the one we are currently dealing with
-          (or to metrics->end(), of course)
-       */
-
-       while (op.beats) {
-
-               /* given the current meter, have we gone past the end of the bar ? */
-
-               if (result.beats >= meter->divisions_per_bar()) {
-                       /* move to next bar, first beat */
-                       result.bars++;
-                       result.beats = 1;
-               } else {
-                       result.beats++;
-               }
-
-               /* one down ... */
-
-               op.beats--;
-
-               /* check if we need to use a new meter section: has adding beats to result taken us
-                  to or after the start of the next meter section? in which case, use it.
-               */
-
-               if (next_meter != meter_sections.end() && (((*next_meter)->start () < result) || (result == (*next_meter)->start()))) {
-                       meter = *next_meter;
-                       ++next_meter;
-               }
-       }
-
-       /* finally, add bars */
-
-       result.bars += op.bars++;
-
-       return result;
-}
-
-/**
- * subtract the BBT interval @param decrement from @param start and return the result
- */
-BBT_Time
-TempoMap::bbt_subtract (const BBT_Time& start, const BBT_Time& decrement) const
-{
-       BBT_Time result = start;
-       BBT_Time op = decrement; /* argument is const, but we need to modify it */
-
-       if (op.ticks > result.ticks) {
-               /* subtract an extra beat later; meanwhile set ticks to the right "carry" value */
-               op.beats++;
-               result.ticks = BBT_Time::ticks_per_bar_division - (op.ticks - result.ticks);
-       } else {
-               result.ticks -= op.ticks;
-       }
-
-
-       /* now comes the complicated part. we have to subtract one beat a time,
-          checking for a new metric on every beat.
-       */
-
-       /* grab all meter sections */
-
-       list<const MeterSection*> meter_sections;
-
-       for (Metrics::const_iterator x = metrics->begin(); x != metrics->end(); ++x) {
-               const MeterSection* ms;
-               if ((ms = dynamic_cast<const MeterSection*>(*x)) != 0) {
-                       meter_sections.push_back (ms);
-               }
-               }
-
-       assert (!meter_sections.empty());
-
-       /* go backwards through the meter sections till we get to the one
-          covering the current value of result. this positions i to point to
-          the next (previous) meter section too, or the end.
-       */
-
-       const MeterSection* meter = 0;
-       list<const MeterSection*>::reverse_iterator next_meter; // older versions of GCC don't
-                                                               // support const_reverse_iterator::operator!=()
-
-       for (next_meter = meter_sections.rbegin(); next_meter != meter_sections.rend(); ++next_meter) {
-
-               /* when we find the first meter section that is before or at result, use it,
-                  and set next_meter to the previous one
-               */
-
-               if ((*next_meter)->start() < result || (*next_meter)->start() == result) {
-                       meter = *next_meter;
-                       ++next_meter;
-                       break;
-               }
-       }
-
-       assert (meter != 0);
-
-       /* OK, now have the meter for the bar start we are on, and i is an iterator
-          that points to the metric after the one we are currently dealing with
-          (or to metrics->end(), of course)
-       */
-
-       while (op.beats) {
-
-               /* have we reached the start of the bar? if so, move to the last beat of the previous
-                  bar. opwise, just step back 1 beat.
-               */
-
-               if (result.beats == 1) {
-
-                       /* move to previous bar, last beat */
-
-                       if (result.bars <= 1) {
-                               /* i'm sorry dave, i can't do that */
-                               throw std::out_of_range ("illegal BBT subtraction");
+       {
+               Glib::Threads::RWLock::WriterLock lm (lock);
+               for (Metrics::iterator i = metrics.begin(); i != metrics.end(); ++i) {
+                       if ((*i)->frame() >= where && (*i)->movable ()) {
+                               (*i)->set_frame ((*i)->frame() + amount);
                        }
-
-                       result.bars--;
-                       result.beats = meter->divisions_per_bar();
-               } else {
-
-                       /* back one beat */
-
-                       result.beats--;
                }
 
-               /* one down ... */
-               op.beats--;
-
-               /* check if we need to use a new meter section: has subtracting beats to result taken us
-                  to before the start of the current meter section? in which case, use the prior one.
-               */
+               /* now reset the BBT time of all metrics, based on their new
+                * audio time. This is the only place where we do this reverse
+                * timestamp.
+                */
 
-               if (result < meter->start() && next_meter != meter_sections.rend()) {
-                       meter = *next_meter;
-                       ++next_meter;
+               Metrics::iterator i;
+               const MeterSection* meter;
+               const TempoSection* tempo;
+               MeterSection *m;
+               TempoSection *t;
+               
+               meter = &first_meter ();
+               tempo = &first_tempo ();
+               
+               BBT_Time start;
+               BBT_Time end;
+               
+               // cerr << "\n###################### TIMESTAMP via AUDIO ##############\n" << endl;
+               
+               bool first = true;
+               MetricSection* prev = 0;
+               
+               for (i = metrics.begin(); i != metrics.end(); ++i) {
+                       
+                       BBT_Time bbt;
+                       TempoMetric metric (*meter, *tempo);
+                       
+                       if (prev) {
+                               metric.set_start (prev->start());
+                               metric.set_frame (prev->frame());
+                       } else {
+                               // metric will be at frames=0 bbt=1|1|0 by default
+                               // which is correct for our purpose
+                       }
+                       
+                       BBTPointList::const_iterator bi = bbt_before_or_at ((*i)->frame());
+                       bbt_time ((*i)->frame(), bbt, bi);
+                       
+                       // cerr << "timestamp @ " << (*i)->frame() << " with " << bbt.bars << "|" << bbt.beats << "|" << bbt.ticks << " => ";
+                       
+                       if (first) {
+                               first = false;
+                       } else {
+                               
+                               if (bbt.ticks > BBT_Time::ticks_per_beat/2) {
+                                       /* round up to next beat */
+                                       bbt.beats += 1;
+                               }
+                               
+                               bbt.ticks = 0;
+                               
+                               if (bbt.beats != 1) {
+                                       /* round up to next bar */
+                                       bbt.bars += 1;
+                                       bbt.beats = 1;
+                               }
+                       }
+                       
+                       // cerr << bbt << endl;
+                       
+                       (*i)->set_start (bbt);
+                       
+                       if ((t = dynamic_cast<TempoSection*>(*i)) != 0) {
+                               tempo = t;
+                               // cerr << "NEW TEMPO, frame = " << (*i)->frame() << " start = " << (*i)->start() <<endl;
+                       } else if ((m = dynamic_cast<MeterSection*>(*i)) != 0) {
+                               meter = m;
+                               // cerr << "NEW METER, frame = " << (*i)->frame() << " start = " << (*i)->start() <<endl;
+                       } else {
+                               fatal << _("programming error: unhandled MetricSection type") << endmsg;
+                               /*NOTREACHED*/
+                       }
+                       
+                       prev = (*i);
                }
+               
+               recompute_map (true);
        }
 
-       /* finally, subtract bars */
-
-       if (op.bars >= result.bars) {
-               /* i'm sorry dave, i can't do that */
-               throw std::out_of_range ("illegal BBT subtraction");
-       }
 
-       result.bars -= op.bars;
-       return result;
+       PropertyChanged (PropertyChange ());
 }
 
 /** Add some (fractional) beats to a session frame position, and return the result in frames.
  *  pos can be -ve, if required.
  */
 framepos_t
-TempoMap::framepos_plus_beats (framepos_t pos, Evoral::MusicalTime beats)
+TempoMap::framepos_plus_beats (framepos_t pos, Evoral::MusicalTime beats) const
 {
-       Metrics::const_iterator i;
-       const TempoSection* tempo;
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       Metrics::const_iterator next_tempo;
+       const TempoSection* tempo = 0;
 
-       /* Find the starting tempo */
+       /* Find the starting tempo metric */
 
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
+       for (next_tempo = metrics.begin(); next_tempo != metrics.end(); ++next_tempo) {
 
-               /* This is a bit of a hack, but pos could be -ve, and if it is,
-                  we consider the initial metric changes (at time 0) to actually
-                  be in effect at pos.
-               */
-               framepos_t f = (*i)->frame ();
-               if (pos < 0 && f == 0) {
-                       f = pos;
-               }
+               const TempoSection* t;
 
-               if (f > pos) {
-                       break;
-               }
+               if ((t = dynamic_cast<const TempoSection*>(*next_tempo)) != 0) {
 
-               const TempoSection* t;
+                       /* This is a bit of a hack, but pos could be -ve, and if it is,
+                          we consider the initial metric changes (at time 0) to actually
+                          be in effect at pos.
+                       */
 
-               if ((t = dynamic_cast<const TempoSection*>(*i)) != 0) {
+                       framepos_t f = (*next_tempo)->frame ();
+
+                       if (pos < 0 && f == 0) {
+                               f = pos;
+                       }
+                       
+                       if (f > pos) {
+                               break;
+                       }
+                       
                        tempo = t;
                }
        }
 
        /* We now have:
 
-          tempo -> the Tempo for "pos"
-          i     -> for first new metric after "pos", possibly metrics->end()
+          tempo       -> the Tempo for "pos"
+          next_tempo  -> first tempo after "pos", possibly metrics.end()
        */
 
+       DEBUG_TRACE (DEBUG::TempoMath,
+                    string_compose ("frame %1 plus %2 beats, start with tempo = %3 @ %4\n",
+                                    pos, beats, *((const Tempo*)tempo), tempo->frame()));
+
        while (beats) {
 
                /* Distance to the end of this section in frames */
-               framecnt_t distance_frames = i == metrics->end() ? max_framepos : ((*i)->frame() - pos);
+               framecnt_t distance_frames = (next_tempo == metrics.end() ? max_framepos : ((*next_tempo)->frame() - pos));
 
                /* Distance to the end in beats */
                Evoral::MusicalTime distance_beats = distance_frames / tempo->frames_per_beat (_frame_rate);
 
                /* Amount to subtract this time */
-               double const sub = min (distance_beats, beats);
+               double const delta = min (distance_beats, beats);
+
+               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("\tdistance to %1 = %2 (%3 beats)\n",
+                                                              (next_tempo == metrics.end() ? max_framepos : (*next_tempo)->frame()),
+                                                              distance_frames, distance_beats));
 
                /* Update */
-               beats -= sub;
-               pos += sub * tempo->frames_per_beat (_frame_rate);
+               beats -= delta;
+               pos += delta * tempo->frames_per_beat (_frame_rate);
 
-               /* Move on if there's anything to move to */
-               if (i != metrics->end ()) {
-                       const TempoSection* t;
-                       
-                       if ((t = dynamic_cast<const TempoSection*>(*i)) != 0) {
-                               tempo = t;
-                       }
+               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("\tnow at %1, %2 beats left\n", pos, beats));
 
-                       ++i;
+               /* step forwards to next tempo section */
+
+               if (next_tempo != metrics.end()) {
+
+                       tempo = dynamic_cast<const TempoSection*>(*next_tempo);
+
+                       DEBUG_TRACE (DEBUG::TempoMath, string_compose ("\tnew tempo = %1 @ %2 fpb = %3\n",
+                                                                      *((const Tempo*)tempo), tempo->frame(),
+                                                                      tempo->frames_per_beat (_frame_rate)));
+
+                       while (next_tempo != metrics.end ()) {
+
+                               ++next_tempo;
+                               
+                               if (next_tempo != metrics.end() && dynamic_cast<const TempoSection*>(*next_tempo)) {
+                                       break;
+                               }
+                       }
                }
        }
 
        return pos;
 }
 
-/** Subtract some (fractional) beats to a frame position, and return the result in frames */
+/** Subtract some (fractional) beats from a frame position, and return the result in frames */
 framepos_t
-TempoMap::framepos_minus_beats (framepos_t pos, Evoral::MusicalTime beats)
+TempoMap::framepos_minus_beats (framepos_t pos, Evoral::MusicalTime beats) const
 {
-       Metrics::const_iterator i;
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       Metrics::const_reverse_iterator prev_tempo;
        const TempoSection* tempo = 0;
-       const TempoSection* t;
-       
-       /* Find the starting tempo */
 
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
+       /* Find the starting tempo metric */
 
-               /* This is a bit of a hack, but pos could be -ve, and if it is,
-                  we consider the initial metric changes (at time 0) to actually
-                  be in effect at pos.
-               */
-               framepos_t f = (*i)->frame ();
-               if (pos < 0 && f == 0) {
-                       f = pos;
-               }
+       for (prev_tempo = metrics.rbegin(); prev_tempo != metrics.rend(); ++prev_tempo) {
 
-               if ((*i)->frame() > pos) {
-                       break;
-               }
+               const TempoSection* t;
 
-               if ((t = dynamic_cast<const TempoSection*>(*i)) != 0) {
-                       tempo = t;
-               }
-       }
+               if ((t = dynamic_cast<const TempoSection*>(*prev_tempo)) != 0) {
 
-       bool no_more_tempos = false;
+                       /* This is a bit of a hack, but pos could be -ve, and if it is,
+                          we consider the initial metric changes (at time 0) to actually
+                          be in effect at pos.
+                       */
 
-       /* Move i back to the tempo before "pos" */
-       if (i != metrics->begin ()) {
-               while (i != metrics->begin ()) {
-                       --i;
-                       t = dynamic_cast<TempoSection*> (*i);
-                       if (t) {
-                               break;
+                       framepos_t f = (*prev_tempo)->frame ();
+
+                       if (pos < 0 && f == 0) {
+                               f = pos;
+                       }
+
+                       /* this is slightly more complex than the forward case
+                          because we reach the tempo in effect at pos after
+                          passing through pos (rather before, as in the
+                          forward case). having done that, we then need to
+                          keep going to get the previous tempo (or
+                          metrics.rend())
+                       */
+                       
+                       if (f <= pos) {
+                               if (tempo == 0) {
+                                       /* first tempo with position at or
+                                          before pos
+                                       */
+                                       tempo = t;
+                               } else if (f < pos) {
+                                       /* some other tempo section that
+                                          is even earlier than 'tempo'
+                                       */
+                                       break;
+                               }
                        }
                }
-       } else {
-               no_more_tempos = true;
        }
 
+       DEBUG_TRACE (DEBUG::TempoMath,
+                    string_compose ("frame %1 minus %2 beats, start with tempo = %3 @ %4 prev at beg? %5\n",
+                                    pos, beats, *((const Tempo*)tempo), tempo->frame(),
+                                    prev_tempo == metrics.rend()));
+
        /* We now have:
 
-          tempo -> the Tempo for "pos"
-          i     -> the first metric before "pos", unless no_more_tempos is true
+          tempo       -> the Tempo for "pos"
+          prev_tempo  -> the first metric before "pos", possibly metrics.rend()
        */
 
        while (beats) {
+               
+               /* Distance to the start of this section in frames */
+               framecnt_t distance_frames = (pos - tempo->frame());
 
-               /* Distance to the end of this section in frames */
-               framecnt_t distance_frames = no_more_tempos ? max_framepos : (pos - (*i)->frame());
-
-               /* Distance to the end in beats */
+               /* Distance to the start in beats */
                Evoral::MusicalTime distance_beats = distance_frames / tempo->frames_per_beat (_frame_rate);
 
                /* Amount to subtract this time */
                double const sub = min (distance_beats, beats);
 
+               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("\tdistance to %1 = %2 (%3 beats)\n",
+                                                              tempo->frame(), distance_frames, distance_beats));
                /* Update */
+
                beats -= sub;
                pos -= sub * tempo->frames_per_beat (_frame_rate);
 
-               /* Move i and tempo back, if there's anything to move to */
-               if (i != metrics->begin ()) {
-                       while (i != metrics->begin ()) {
-                               --i;
-                               if ((t = dynamic_cast<const TempoSection*>(*i)) != 0) {
-                                       tempo = t;
+               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("\tnow at %1, %2 beats left, prev at end ? %3\n", pos, beats,
+                                                              (prev_tempo == metrics.rend())));
+
+               /* step backwards to prior TempoSection */
+
+               if (prev_tempo != metrics.rend()) {
+
+                       tempo = dynamic_cast<const TempoSection*>(*prev_tempo);
+
+                       DEBUG_TRACE (DEBUG::TempoMath,
+                                    string_compose ("\tnew tempo = %1 @ %2 fpb = %3\n",
+                                                    *((const Tempo*)tempo), tempo->frame(),
+                                                    tempo->frames_per_beat (_frame_rate)));
+
+                       while (prev_tempo != metrics.rend ()) {
+
+                               ++prev_tempo;
+
+                               if (prev_tempo != metrics.rend() && dynamic_cast<const TempoSection*>(*prev_tempo) != 0) {
                                        break;
                                }
                        }
                } else {
-                       no_more_tempos = true;
+                       pos -= llrint (beats * tempo->frames_per_beat (_frame_rate));
+                       beats = 0;
                }
        }
 
@@ -1918,14 +2003,16 @@ TempoMap::framepos_minus_beats (framepos_t pos, Evoral::MusicalTime beats)
 
 /** Add the BBT interval op to pos and return the result */
 framepos_t
-TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
+TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op) const
 {
+       Glib::Threads::RWLock::ReaderLock lm (lock);
        Metrics::const_iterator i;
        const MeterSection* meter;
        const MeterSection* m;
        const TempoSection* tempo;
        const TempoSection* t;
        double frames_per_beat;
+       framepos_t effective_pos = max (pos, (framepos_t) 0);
 
        meter = &first_meter ();
        tempo = &first_tempo ();
@@ -1935,9 +2022,9 @@ TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
 
        /* find the starting metrics for tempo & meter */
 
-       for (i = metrics->begin(); i != metrics->end(); ++i) {
+       for (i = metrics.begin(); i != metrics.end(); ++i) {
 
-               if ((*i)->frame() > pos) {
+               if ((*i)->frame() > effective_pos) {
                        break;
                }
 
@@ -1952,7 +2039,7 @@ TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
 
           meter -> the Meter for "pos"
           tempo -> the Tempo for "pos"
-          i     -> for first new metric after "pos", possibly metrics->end()
+          i     -> for first new metric after "pos", possibly metrics.end()
        */
 
        /* now comes the complicated part. we have to add one beat a time,
@@ -1972,7 +2059,7 @@ TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
                   to or after the start of the next metric section? in which case, use it.
                */
 
-               if (i != metrics->end()) {
+               if (i != metrics.end()) {
                        if ((*i)->frame() <= pos) {
 
                                /* about to change tempo or meter, so add the
@@ -2012,7 +2099,7 @@ TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
                   to or after the start of the next metric section? in which case, use it.
                */
 
-               if (i != metrics->end()) {
+               if (i != metrics.end()) {
                        if ((*i)->frame() <= pos) {
 
                                /* about to change tempo or meter, so add the
@@ -2038,12 +2125,12 @@ TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
        pos += llrint (beats * frames_per_beat);
 
        if (op.ticks) {
-               if (op.ticks >= BBT_Time::ticks_per_bar_division) {
+               if (op.ticks >= BBT_Time::ticks_per_beat) {
                        pos += llrint (frames_per_beat + /* extra beat */
-                                      (frames_per_beat * ((op.ticks % (uint32_t) BBT_Time::ticks_per_bar_division) / 
-                                                          (double) BBT_Time::ticks_per_bar_division)));
+                                      (frames_per_beat * ((op.ticks % (uint32_t) BBT_Time::ticks_per_beat) / 
+                                                          (double) BBT_Time::ticks_per_beat)));
                } else {
-                       pos += llrint (frames_per_beat * (op.ticks / (double) BBT_Time::ticks_per_bar_division));
+                       pos += llrint (frames_per_beat * (op.ticks / (double) BBT_Time::ticks_per_beat));
                }
        }
 
@@ -2054,34 +2141,103 @@ TempoMap::framepos_plus_bbt (framepos_t pos, BBT_Time op)
     starting at pos.
 */
 Evoral::MusicalTime
-TempoMap::framewalk_to_beats (framepos_t pos, framecnt_t distance)
+TempoMap::framewalk_to_beats (framepos_t pos, framecnt_t distance) const
 {
-       BBTPointList::const_iterator i = bbt_after_or_at (pos);
-       Evoral::MusicalTime beats = 0;
-       framepos_t end = pos + distance;
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       Metrics::const_iterator next_tempo;
+       const TempoSection* tempo = 0;
+       framepos_t effective_pos = max (pos, (framepos_t) 0);
 
-       require_map_to (end);
+       /* Find the relevant initial tempo metric  */
 
-       /* if our starting BBTPoint is after pos, add a fractional beat
-          to represent that distance.
-       */
+       for (next_tempo = metrics.begin(); next_tempo != metrics.end(); ++next_tempo) {
 
-       if ((*i).frame != pos) {
-               beats += ((*i).frame - pos) / (*i).meter->frames_per_division (*(*i).tempo, _frame_rate);
-       }
+               const TempoSection* t;
 
-       while (i != _map.end() && (*i).frame < end) {
-               ++i;
-               beats++;
+               if ((t = dynamic_cast<const TempoSection*>(*next_tempo)) != 0) {
+
+                       if ((*next_tempo)->frame() > effective_pos) {
+                               break;
+                       }
+
+                       tempo = t;
+               }
        }
-       assert (i != _map.end());
-       
-       /* if our ending BBTPoint is after the end, subtract a fractional beat
-          to represent that distance.
+
+       /* We now have:
+
+          tempo -> the Tempo for "pos"
+          next_tempo -> the next tempo after "pos", possibly metrics.end()
        */
 
-       if ((*i).frame > end) {
-               beats -= ((*i).frame - end) / (*i).meter->frames_per_division (*(*i).tempo, _frame_rate);
+       assert (tempo);
+
+       DEBUG_TRACE (DEBUG::TempoMath,
+                    string_compose ("frame %1 walk by %2 frames, start with tempo = %3 @ %4\n",
+                                    pos, distance, *((const Tempo*)tempo), tempo->frame()));
+       
+       Evoral::MusicalTime beats = 0;
+
+       while (distance) {
+
+               /* End of this section */
+               framepos_t end;
+               /* Distance to `end' in frames */
+               framepos_t distance_to_end;
+
+               if (next_tempo == metrics.end ()) {
+                       /* We can't do (end - pos) if end is max_framepos, as it will overflow if pos is -ve */
+                       end = max_framepos;
+                       distance_to_end = max_framepos;
+               } else {
+                       end = (*next_tempo)->frame ();
+                       distance_to_end = end - pos;
+               }
+
+               /* Amount to subtract this time */
+               double const sub = min (distance, distance_to_end);
+
+               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("to reach end at %1 (end ? %2), distance= %3 sub=%4\n", end, (next_tempo == metrics.end()),
+                                                              distance_to_end, sub));
+
+               /* Update */
+               pos += sub;
+               distance -= sub;
+               assert (tempo);
+               beats += sub / tempo->frames_per_beat (_frame_rate);
+
+               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("now at %1, beats = %2 distance left %3\n",
+                                                              pos, beats, distance));
+
+               /* Move on if there's anything to move to */
+
+               if (next_tempo != metrics.end()) {
+
+                       tempo = dynamic_cast<const TempoSection*>(*next_tempo);
+
+                       DEBUG_TRACE (DEBUG::TempoMath,
+                                    string_compose ("\tnew tempo = %1 @ %2 fpb = %3\n",
+                                                    *((const Tempo*)tempo), tempo->frame(),
+                                                    tempo->frames_per_beat (_frame_rate)));
+
+                       while (next_tempo != metrics.end ()) {
+
+                               ++next_tempo;
+                               
+                               if (next_tempo != metrics.end() && dynamic_cast<const TempoSection*>(*next_tempo)) {
+                                       break;
+                               }
+                       }
+
+                       if (next_tempo == metrics.end()) {
+                               DEBUG_TRACE (DEBUG::TempoMath, "no more tempo sections\n");
+                       } else {
+                               DEBUG_TRACE (DEBUG::TempoMath, string_compose ("next tempo section is %1 @ %2\n",
+                                                                              **next_tempo, (*next_tempo)->frame()));
+                       }
+
+               }
+               assert (tempo);
        }
 
        return beats;
@@ -2090,18 +2246,23 @@ TempoMap::framewalk_to_beats (framepos_t pos, framecnt_t distance)
 TempoMap::BBTPointList::const_iterator
 TempoMap::bbt_before_or_at (framepos_t pos)
 {
-       require_map_to (pos);
-       BBTPointList::const_iterator i = lower_bound (_map.begin(), _map.end(), pos);
-       assert (i != _map.end());
-       return i;
-}
+       /* CALLER MUST HOLD READ LOCK */
 
-TempoMap::BBTPointList::const_iterator
-TempoMap::bbt_after_or_at (framepos_t pos)
-{
-       require_map_to (pos);
-       BBTPointList::const_iterator i = upper_bound (_map.begin(), _map.end(), pos);
+       BBTPointList::const_iterator i;
+
+       if (pos < 0) {
+               /* not really correct, but we should catch pos < 0 at a higher
+                  level 
+               */
+               return _map.begin();
+       }
+
+       i = lower_bound (_map.begin(), _map.end(), pos);
        assert (i != _map.end());
+       if ((*i).frame > pos) {
+               assert (i != _map.begin());
+               --i;
+       }
        return i;
 }
 
@@ -2112,53 +2273,37 @@ struct bbtcmp {
 };
 
 TempoMap::BBTPointList::const_iterator
-TempoMap::bbt_point_for (const BBT_Time& bbt)
+TempoMap::bbt_before_or_at (const BBT_Time& bbt)
 {
+       BBTPointList::const_iterator i;
        bbtcmp cmp;
-       int additional_minutes = 1;
 
-       while (_map.empty() || _map.back().bar < (bbt.bars + 1)) {
-               /* add some more distance, using bigger steps each time */
-               require_map_to (_map.back().frame + (_frame_rate * 60 * additional_minutes));
-               additional_minutes *= 2;
-       }
-
-       BBTPointList::const_iterator i = lower_bound (_map.begin(), _map.end(), bbt, cmp);
+       i = lower_bound (_map.begin(), _map.end(), bbt, cmp);
        assert (i != _map.end());
+       if ((*i).bar > bbt.bars || (*i).beat > bbt.beats) {
+               assert (i != _map.begin());
+               --i;
+       }
        return i;
 }
 
-
-/** Compare the time of this with that of another MetricSection.
- *  @param with_bbt True to compare using start(), false to use frame().
- *  @return -1 for less than, 0 for equal, 1 for greater than.
- */
-
-int
-MetricSection::compare (const MetricSection& other) const
+TempoMap::BBTPointList::const_iterator
+TempoMap::bbt_after_or_at (framepos_t pos) 
 {
-       if (start() == other.start()) {
-               return 0;
-       } else if (start() < other.start()) {
-               return -1;
-       } else {
-               return 1;
-       }
+       /* CALLER MUST HOLD READ LOCK */
 
-       /* NOTREACHED */
-       return 0;
-}
+       BBTPointList::const_iterator i;
 
-bool
-MetricSection::operator== (const MetricSection& other) const
-{
-       return compare (other) == 0;
-}
+       if (_map.back().frame == pos) {
+               i = _map.end();
+               assert (i != _map.begin());
+               --i;
+               return i;
+       }
 
-bool
-MetricSection::operator!= (const MetricSection& other) const
-{
-       return compare (other) != 0;
+       i = upper_bound (_map.begin(), _map.end(), pos);
+       assert (i != _map.end());
+       return i;
 }
 
 std::ostream& 
@@ -2180,9 +2325,9 @@ operator<< (std::ostream& o, const MetricSection& section) {
        const MeterSection* ms;
 
        if ((ts = dynamic_cast<const TempoSection*> (&section)) != 0) {
-               o << *((Tempo*) ts);
+               o << *((const Tempo*) ts);
        } else if ((ms = dynamic_cast<const MeterSection*> (&section)) != 0) {
-               o << *((Meter*) ms);
+               o << *((const Meter*) ms);
        }
 
        return o;