Tempo ramps - more click fixing.
[ardour.git] / libs / ardour / tempo.cc
index 4dbcbeb27757236de0f90a5f4832c15d9a326264..8a481c9567e1d67c7883a8b3b8bfb2fe9e7ba6a3 100644 (file)
@@ -624,13 +624,11 @@ TempoMap::TempoMap (framecnt_t fr)
        _frame_rate = fr;
        BBT_Time start (1, 1, 0);
 
-       TempoSection *t = new TempoSection (0.0, _default_tempo.beats_per_minute(), _default_tempo.note_type(), TempoSection::Constant);
-       MeterSection *m = new MeterSection (0.0, 0.0, start, _default_meter.divisions_per_bar(), _default_meter.note_divisor());
+       TempoSection *t = new TempoSection ((framepos_t) 0, _default_tempo.beats_per_minute(), _default_tempo.note_type(), TempoSection::Constant);
+       MeterSection *m = new MeterSection ((framepos_t) 0, 0.0, start, _default_meter.divisions_per_bar(), _default_meter.note_divisor());
 
        t->set_movable (false);
        m->set_movable (false);
-       t->set_position_lock_style (AudioTime);
-       m->set_position_lock_style (AudioTime);
 
        /* note: frame time is correct (zero) for both of these */
 
@@ -1290,10 +1288,16 @@ TempoMap::recompute_meters (Metrics& metrics)
                                if (meter->movable()) {
                                        const double beats = ((pulse_at_frame_locked (metrics, meter->frame()) - prev_m->pulse()) * prev_m->note_divisor());
                                        const double floor_beats = beats - fmod (beats, prev_m->divisions_per_bar());
-                                       b_bbt = make_pair (floor_beats + prev_m->beat(), BBT_Time ((floor_beats / prev_m->divisions_per_bar()) + prev_m->bbt().bars, 1, 0));
-                                       const double true_pulse = prev_m->pulse() + (floor_beats / prev_m->note_divisor());
-                                       const double pulse_off = true_pulse - (beats / prev_m->note_divisor()) - prev_m->pulse();
-                                       pulse = true_pulse - pulse_off;
+                                       if (floor_beats + prev_m->beat() < meter->beat()) {
+                                               /* tempo change caused a change in beat (bar). */
+                                               b_bbt = make_pair (floor_beats + prev_m->beat(), BBT_Time ((floor_beats / prev_m->divisions_per_bar()) + prev_m->bbt().bars, 1, 0));
+                                               const double true_pulse = prev_m->pulse() + (floor_beats / prev_m->note_divisor());
+                                               const double pulse_off = true_pulse - (beats / prev_m->note_divisor()) - prev_m->pulse();
+                                               pulse = true_pulse - pulse_off;
+                                       } else {
+                                               b_bbt = make_pair (meter->beat(), meter->bbt());
+                                               pulse = pulse_at_frame_locked (metrics, meter->frame());
+                                       }
                                } else {
                                        b_bbt = make_pair (0.0, BBT_Time (1, 1, 0));
                                }
@@ -1442,7 +1446,9 @@ TempoMap::beat_at_pulse_locked (const Metrics& metrics, const double& pulse) con
                MeterSection* m;
                if ((m = dynamic_cast<MeterSection*> (*i)) != 0) {
                        if (prev_m && m->pulse() > pulse) {
-                               break;
+                               if ((pulse - prev_m->pulse()) * prev_m->note_divisor() < m->beat()) {
+                                       break;
+                               }
                        }
                        prev_m = m;
                }
@@ -1487,6 +1493,13 @@ TempoMap::pulse_at_frame_locked (const Metrics& metrics, const framecnt_t& frame
        return pulses_in_section + prev_t->pulse();
 }
 
+double
+TempoMap::pulse_at_frame (const framecnt_t& frame) const
+{
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       return pulse_at_frame_locked (_metrics, frame);
+}
+
 framecnt_t
 TempoMap::frame_at_pulse_locked (const Metrics& metrics, const double& pulse) const
 {
@@ -1517,11 +1530,22 @@ TempoMap::frame_at_pulse_locked (const Metrics& metrics, const double& pulse) co
        return ret;
 }
 
+framecnt_t
+TempoMap::frame_at_pulse (const double& pulse) const
+{
+       Glib::Threads::RWLock::ReaderLock lm (lock);
+       return frame_at_pulse_locked (_metrics, pulse);
+}
+
 double
 TempoMap::beat_at_frame_locked (const Metrics& metrics, const framecnt_t& frame) const
 {
-       const double pulse = pulse_at_frame_locked (metrics, frame);
-       return beat_at_pulse_locked (metrics, pulse);
+       const MeterSection& prev_m = meter_section_at_locked (metrics, frame);
+       const TempoSection& ts = tempo_section_at_locked (metrics, frame);
+       if (frame < prev_m.frame()) {
+               return 0.0;
+       }
+       return prev_m.beat() + (ts.pulse_at_frame (frame, _frame_rate) - prev_m.pulse()) * prev_m.note_divisor();
 }
 
 double
@@ -1986,6 +2010,11 @@ TempoMap::solve_map (Metrics& imaginary, TempoSection* section, const double& pu
 void
 TempoMap::solve_map (Metrics& imaginary, MeterSection* section, const framepos_t& frame)
 {
+       /* disallow moving first meter past any subsequent one, and any movable meter before the first one */
+       const MeterSection* other =  &meter_section_at_locked (imaginary, frame);
+       if ((!section->movable() && other->movable()) || (!other->movable() && section->movable() && other->frame() >= frame)) {
+               return;
+       }
        MeterSection* prev_m = 0;
 
        if (!section->movable()) {
@@ -2011,8 +2040,6 @@ TempoMap::solve_map (Metrics& imaginary, MeterSection* section, const framepos_t
                }
        }
 
-       section->set_frame (frame);
-
        for (Metrics::iterator i = imaginary.begin(); i != imaginary.end(); ++i) {
                MeterSection* m;
                if ((m = dynamic_cast<MeterSection*> (*i)) != 0) {
@@ -2020,7 +2047,7 @@ TempoMap::solve_map (Metrics& imaginary, MeterSection* section, const framepos_t
                                /*
                                  here we set the beat for this frame.
                                  we set it 'incorrectly' to the next bar's first beat
-                                 and use the delat to find the meter's pulse.
+                                 and use the delta to find the meter's pulse.
                                */
                                double new_pulse = 0.0;
                                pair<double, BBT_Time> b_bbt;
@@ -2028,14 +2055,20 @@ TempoMap::solve_map (Metrics& imaginary, MeterSection* section, const framepos_t
                                if (section->movable()) {
                                        const double beats = ((pulse_at_frame_locked (imaginary, frame) - prev_m->pulse()) * prev_m->note_divisor());
                                        const double floor_beats = beats - fmod (beats,  prev_m->divisions_per_bar());
-                                       b_bbt = make_pair (floor_beats + prev_m->beat(), BBT_Time ((floor_beats / prev_m->divisions_per_bar()) + prev_m->bbt().bars, 1, 0));
-                                       const double true_pulse = prev_m->pulse() + (floor_beats / prev_m->note_divisor());
-                                       const double pulse_off = true_pulse - (beats / prev_m->note_divisor()) - prev_m->pulse();
-                                       new_pulse = true_pulse - pulse_off;
+                                       if (floor_beats + prev_m->beat() < section->beat()) {
+                                               /* disallow position change if it will alter out beat
+                                                  we allow tempo changes to do this in recompute_meters().
+                                                  blocking this is an option, but i'm not convinced that
+                                                  this is what the user would actually want.
+                                               */
+                                               return;
+                                       }
+                                       b_bbt = make_pair (section->beat(), section->bbt());
+                                       new_pulse = pulse_at_frame_locked (imaginary, frame);
                                } else {
                                        b_bbt = make_pair (0.0, BBT_Time (1, 1, 0));
                                }
-
+                               section->set_frame (frame);
                                section->set_beat (b_bbt);
                                section->set_pulse (new_pulse);
                                prev_m = m;
@@ -2608,18 +2641,19 @@ TempoMap::get_grid (vector<TempoMap::BBTPoint>& points,
                    framepos_t lower, framepos_t upper)
 {
        Glib::Threads::RWLock::ReaderLock lm (lock);
-       const int32_t upper_beat = (int32_t) ceil (beat_at_frame_locked (_metrics, upper));
-       int32_t cnt = floor (beat_at_frame_locked (_metrics, lower));
+       const int32_t upper_beat = (int32_t) floor (beat_at_frame_locked (_metrics, upper));
+       int32_t cnt = ceil (beat_at_frame_locked (_metrics, lower));
+       framecnt_t pos = 0;
        /* although the map handles negative beats, bbt doesn't. */
        if (cnt < 0.0) {
                cnt = 0.0;
        }
-       while (cnt <= upper_beat) {
-               framecnt_t pos = frame_at_beat_locked (_metrics, cnt);
-               const TempoSection tempo = tempo_section_at_locked (pos);
-               const MeterSection meter = meter_section_at_locked (pos);
+       while (cnt <= upper_beat && pos < upper) {
+               pos = frame_at_beat_locked (_metrics, cnt);
+               const TempoSection tempo = tempo_section_at_locked (_metrics, pos);
+               const MeterSection meter = meter_section_at_locked (_metrics, pos);
                const BBT_Time bbt = beats_to_bbt (cnt);
-               points.push_back (BBTPoint (meter, tempo_at_locked (pos), pos, bbt.bars, bbt.beats, tempo.c_func()));
+               points.push_back (BBTPoint (meter, tempo_at_locked (_metrics, pos), pos, bbt.bars, bbt.beats, tempo.c_func()));
                ++cnt;
        }
 }
@@ -2628,23 +2662,23 @@ const TempoSection&
 TempoMap::tempo_section_at (framepos_t frame) const
 {
        Glib::Threads::RWLock::ReaderLock lm (lock);
-       return tempo_section_at_locked (frame);
+       return tempo_section_at_locked (_metrics, frame);
 }
 
 const TempoSection&
-TempoMap::tempo_section_at_locked (framepos_t frame) const
+TempoMap::tempo_section_at_locked (const Metrics& metrics, framepos_t frame) const
 {
        Metrics::const_iterator i;
        TempoSection* prev = 0;
 
-       for (i = _metrics.begin(); i != _metrics.end(); ++i) {
+       for (i = metrics.begin(); i != metrics.end(); ++i) {
                TempoSection* t;
 
                if ((t = dynamic_cast<TempoSection*> (*i)) != 0) {
                        if (!t->active()) {
                                continue;
                        }
-                       if (t->frame() > frame) {
+                       if (prev && t->frame() > frame) {
                                break;
                        }
 
@@ -2669,7 +2703,7 @@ TempoMap::frames_per_beat_at (const framepos_t& frame, const framecnt_t& sr) con
 {
        Glib::Threads::RWLock::ReaderLock lm (lock);
 
-       const TempoSection* ts_at = &tempo_section_at_locked (frame);
+       const TempoSection* ts_at = &tempo_section_at_locked (_metrics, frame);
        const TempoSection* ts_after = 0;
        Metrics::const_iterator i;
 
@@ -2698,11 +2732,11 @@ const Tempo
 TempoMap::tempo_at (const framepos_t& frame) const
 {
        Glib::Threads::RWLock::ReaderLock lm (lock);
-       return tempo_at_locked (frame);
+       return tempo_at_locked (_metrics, frame);
 }
 
 const Tempo
-TempoMap::tempo_at_locked (const framepos_t& frame) const
+TempoMap::tempo_at_locked (const Metrics& metrics, const framepos_t& frame) const
 {
        TempoSection* prev_t = 0;
 
@@ -2734,16 +2768,16 @@ const MeterSection&
 TempoMap::meter_section_at (framepos_t frame) const
 {
        Glib::Threads::RWLock::ReaderLock lm (lock);
-       return meter_section_at_locked (frame);
+       return meter_section_at_locked (_metrics, frame);
 }
 
 const MeterSection&
-TempoMap::meter_section_at_locked (framepos_t frame) const
+TempoMap::meter_section_at_locked (const Metrics& metrics, framepos_t frame) const
 {
        Metrics::const_iterator i;
        MeterSection* prev = 0;
 
-       for (i = _metrics.begin(); i != _metrics.end(); ++i) {
+       for (i = metrics.begin(); i != metrics.end(); ++i) {
                MeterSection* m;
 
                if ((m = dynamic_cast<MeterSection*> (*i)) != 0) {