* with this.
*/
+ /* x-axis limits of the curve, in window space coordinates */
+
+ Duple w1 = item_to_window (Duple (_points.front().x, 0.0));
+ Duple w2 = item_to_window (Duple (_points.back().x, 0.0));
+
+ /* clamp actual draw to area bound by points, rather than our bounding box which is slightly different */
+
+ context->save ();
+ context->rectangle (draw.x0, draw.y0, draw.width(), draw.height());
+ context->clip ();
+
+ /* expand drawing area by several pixels on each side to avoid cairo stroking effects at the boundary.
+ they will still occur, but cairo's clipping will hide them.
+ */
+
+ draw = draw.expand (4.0);
+
+ /* now clip it to the actual points in the curve */
+
+ if (draw.x0 < w1.x) {
+ draw.x0 = w1.x;
+ }
+
+ if (draw.x1 >= w2.x) {
+ draw.x1 = w2.x;
+ }
setup_outline_context (context);
window_space = item_to_window (*it);
context->move_to (window_space.x, window_space.y);
++it;
- window_space = item_to_window (*it);
+ window_space = item_to_window (*it, false);
context->line_to (window_space.x, window_space.y);
- window_space = item_to_window (_points.back());
+ window_space = item_to_window (_points.back(), false);
context->line_to (window_space.x, window_space.y);
switch (curve_fill) {
context->stroke_preserve ();
window_space = item_to_window (Duple(_points.back().x, draw.height()));
context->line_to (window_space.x, window_space.y);
- window_space = item_to_window (Duple(_points.back().x, draw.height()));
+ window_space = item_to_window (Duple(_points.front().x, draw.height()));
context->line_to (window_space.x, window_space.y);
context->close_path();
setup_fill_context(context);
context->fill ();
break;
}
-
} else {
/* curve of at least 3 points */
- /* x-axis limits of the curve, in window space coordinates */
-
- Duple w1 = item_to_window (Duple (_points.front().x, 0.0));
- Duple w2 = item_to_window (Duple (_points.back().x, 0.0));
-
- /* clamp actual draw to area bound by points, rather than our bounding box which is slightly different */
-
- context->save ();
- context->rectangle (draw.x0, draw.y0, draw.width(), draw.height());
- context->clip ();
-
- /* expand drawing area by several pixels on each side to avoid cairo stroking effects at the boundary.
- they will still occur, but cairo's clipping will hide them.
- */
-
- draw = draw.expand (4.0);
-
- /* now clip it to the actual points in the curve */
-
- if (draw.x0 < w1.x) {
- draw.x0 = w1.x;
- }
-
- if (draw.x1 >= w2.x) {
- draw.x1 = w2.x;
- }
-
/* find left and right-most sample */
Duple window_space;
Points::size_type left = 0;
- Points::size_type right = n_samples;
+ Points::size_type right = n_samples - 1;
for (Points::size_type idx = 0; idx < n_samples - 1; ++idx) {
window_space = item_to_window (Duple (samples[idx].x, 0.0));
- if (window_space.x >= draw.x0) break;
+ if (window_space.x >= draw.x0) {
+ break;
+ }
left = idx;
}
- for (Points::size_type idx = n_samples; idx > left + 1; --idx) {
+ for (Points::size_type idx = left; idx < n_samples - 1; ++idx) {
window_space = item_to_window (Duple (samples[idx].x, 0.0));
- if (window_space.x <= draw.x1) break;
- right = idx;
+ if (window_space.x > draw.x1) {
+ right = idx;
+ break;
+ }
}
- window_space = item_to_window (*_points.begin());
+ const Duple first_sample = Duple (samples[left].x, samples[left].y);
+
+ /* move to the first sample's x and the draw height */
+ window_space = item_to_window (Duple (first_sample.x, draw.height()));
context->move_to (window_space.x, window_space.y);
- /* draw line between samples */
- window_space = item_to_window (Duple (samples[left].x, samples[left].y));
- context->line_to (window_space.x, window_space.y);
- for (uint32_t idx = left; idx < right; ++idx) {
+ /* draw line to first sample and then between samples */
+ for (uint32_t idx = left; idx <= right; ++idx) {
window_space = item_to_window (Duple (samples[idx].x, samples[idx].y), false);
context->line_to (window_space.x, window_space.y);
}
+ /* a redraw may have been requested between the last sample and the last point.
+ if so, draw a line to the last _point.
+ */
+ Duple last_sample = Duple (samples[right].x, samples[right].y);
+
+ if (draw.x1 > last_sample.x) {
+ last_sample = Duple (_points.back().x, _points.back().y);
+ window_space = item_to_window (last_sample, false);
+ context->line_to (window_space.x, window_space.y);
+ }
+
switch (curve_fill) {
case None:
context->stroke();
break;
case Inside:
context->stroke_preserve ();
- window_space = item_to_window (Duple (samples[right-1].x, draw.height()));
+ /* close the frame, possibly using the last _point's x rather than samples[right].x */
+ window_space = item_to_window (Duple (last_sample.x, draw.height()));
context->line_to (window_space.x, window_space.y);
- window_space = item_to_window (Duple (samples[left].x, draw.height()));
+ window_space = item_to_window (Duple (first_sample.x, draw.height()));
context->line_to (window_space.x, window_space.y);
context->close_path();
setup_fill_context(context);
break;
case Outside:
context->stroke_preserve ();
- window_space = item_to_window (Duple (samples[right-1].x, 0.0));
+ window_space = item_to_window (Duple (last_sample.x, 0.0));
context->line_to (window_space.x, window_space.y);
- window_space = item_to_window (Duple (samples[left].x, 0.0));
+ window_space = item_to_window (Duple (first_sample.x, 0.0));
context->line_to (window_space.x, window_space.y);
context->close_path();
setup_fill_context(context);
context->fill ();
break;
}
- context->restore ();
}
+ context->restore ();
#if 0
/* add points */
projects / ardour.git / blobdiff