Fix some workflow problems wrt automation.
[ardour.git] / libs / evoral / src / ControlList.cpp
index 8176850428aa7de4b6ec1349d0f80dd5e0e8f7d5..2f1d8f424386fe60288d368f78485ccc4cb343cf 100644 (file)
@@ -176,7 +176,7 @@ void
 ControlList::copy_events (const ControlList& other)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                _events.clear ();
                for (const_iterator i = other.begin(); i != other.end(); ++i) {
                        _events.push_back (new ControlEvent ((*i)->when, (*i)->value));
@@ -214,7 +214,7 @@ void
 ControlList::clear ()
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                _events.clear ();
                unlocked_invalidate_insert_iterator ();
                mark_dirty ();
@@ -226,14 +226,14 @@ ControlList::clear ()
 void
 ControlList::x_scale (double factor)
 {
-       Glib::Threads::Mutex::Lock lm (_lock);
+       Glib::Threads::RWLock::WriterLock lm (_lock);
        _x_scale (factor);
 }
 
 bool
 ControlList::extend_to (double when)
 {
-       Glib::Threads::Mutex::Lock lm (_lock);
+       Glib::Threads::RWLock::WriterLock lm (_lock);
        if (_events.empty() || _events.back()->when == when) {
                return false;
        }
@@ -268,7 +268,7 @@ ControlList::thin (double thinning_factor)
        bool changed = false;
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                
                ControlEvent* prevprev = 0;
                ControlEvent* cur = 0;
@@ -328,7 +328,7 @@ ControlList::thin (double thinning_factor)
 void
 ControlList::fast_simple_add (double when, double value)
 {
-       Glib::Threads::Mutex::Lock lm (_lock);
+       Glib::Threads::RWLock::WriterLock lm (_lock);
        /* to be used only for loading pre-sorted data from saved state */
        _events.insert (_events.end(), new ControlEvent (when, value));
 
@@ -338,7 +338,7 @@ ControlList::fast_simple_add (double when, double value)
 void
 ControlList::invalidate_insert_iterator ()
 {
-       Glib::Threads::Mutex::Lock lm (_lock);
+       Glib::Threads::RWLock::WriterLock lm (_lock);
        unlocked_invalidate_insert_iterator ();
 }
 
@@ -351,7 +351,7 @@ ControlList::unlocked_invalidate_insert_iterator ()
 void
 ControlList::start_write_pass (double when)
 {
-       Glib::Threads::Mutex::Lock lm (_lock);
+       Glib::Threads::RWLock::WriterLock lm (_lock);
 
        DEBUG_TRACE (DEBUG::ControlList, string_compose ("%1: setup write pass @ %2\n", this, when));
 
@@ -399,7 +399,7 @@ ControlList::add_guard_point (double when)
        most_recent_insert_iterator = lower_bound (_events.begin(), _events.end(), &cp, time_comparator);
 
        double eval_value = unlocked_eval (insert_position);
-       
+
        if (most_recent_insert_iterator == _events.end()) {
                
                DEBUG_TRACE (DEBUG::ControlList, string_compose ("@%1 insert iterator at end, adding eval-value there %2\n", this, eval_value));
@@ -407,7 +407,7 @@ ControlList::add_guard_point (double when)
                /* leave insert iterator at the end */
                
        } else if ((*most_recent_insert_iterator)->when == when) {
-               
+
                DEBUG_TRACE (DEBUG::ControlList, string_compose ("@%1 insert iterator at existing point, setting eval-value there %2\n", this, eval_value));
                
                /* most_recent_insert_iterator points to a control event
@@ -415,15 +415,15 @@ ControlList::add_guard_point (double when)
                   nothing to do.
                   
                   ... except ... 
-                  
+
                   advance most_recent_insert_iterator so that the "real"
                   insert occurs in the right place, since it 
                   points to the control event just inserted.
                */
-               
+
                ++most_recent_insert_iterator;
        } else {
-               
+
                /* insert a new control event at the right spot
                 */
                
@@ -431,7 +431,7 @@ ControlList::add_guard_point (double when)
                                                                 this, eval_value, (*most_recent_insert_iterator)->when));
                
                most_recent_insert_iterator = _events.insert (most_recent_insert_iterator, new ControlEvent (when, eval_value));
-               
+
                /* advance most_recent_insert_iterator so that the "real"
                 * insert occurs in the right place, since it 
                 * points to the control event just inserted.
@@ -546,7 +546,7 @@ ControlList::erase_from_iterator_to (iterator iter, double when)
 }
 
 void
-ControlList::add (double when, double value, bool with_guards, bool with_default)
+ControlList::add (double when, double value, bool with_guards, bool with_initial)
 {
        /* this is for making changes from some kind of user interface or
           control surface (GUI, MIDI, OSC etc)
@@ -557,16 +557,16 @@ ControlList::add (double when, double value, bool with_guards, bool with_default
                                     this, value, when, with_guards, _in_write_pass, new_write_pass,
                                     (most_recent_insert_iterator == _events.end())));
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                ControlEvent cp (when, 0.0f);
                iterator insertion_point;
 
-               if (_events.empty() && with_default) {
+               if (_events.empty() && with_initial) {
                        
                        /* empty: add an "anchor" point if the point we're adding past time 0 */
 
                        if (when >= 1) {
-                               _events.insert (_events.end(), new ControlEvent (0, _default_value));
+                               _events.insert (_events.end(), new ControlEvent (0, value));
                                DEBUG_TRACE (DEBUG::ControlList, string_compose ("@%1 added default value %2 at zero\n", this, _default_value));
                        }
                }
@@ -628,10 +628,19 @@ ControlList::add (double when, double value, bool with_guards, bool with_default
                        if ((*most_recent_insert_iterator)->value != value) {
                                DEBUG_TRACE (DEBUG::ControlList, string_compose ("@%1 reset existing point to new value %2\n", this, value));
 
-                               /* only one point allowed per time point, so just
-                                * reset the value here.
+                               /* only one point allowed per time point, so add a guard point
+                                * before it if needed then reset the value of the point.
                                 */
-                               
+
+                               if ((when > 0) && most_recent_insert_iterator != _events.begin ()) {
+                                       --most_recent_insert_iterator;
+                                       double last_when =  (*most_recent_insert_iterator)->when;
+                                       ++most_recent_insert_iterator;
+                                       if (when - last_when > 64) {
+                                               add_guard_point (when - 64);
+                                       }
+                               }
+
                                (*most_recent_insert_iterator)->value = value;
 
                                /* if we modified the final value, then its as
@@ -672,7 +681,7 @@ void
 ControlList::erase (iterator i)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                if (most_recent_insert_iterator == i) {
                        unlocked_invalidate_insert_iterator ();
                }
@@ -686,7 +695,7 @@ void
 ControlList::erase (iterator start, iterator end)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                _events.erase (start, end);
                unlocked_invalidate_insert_iterator ();
                mark_dirty ();
@@ -699,7 +708,7 @@ void
 ControlList::erase (double when, double value)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                iterator i = begin ();
                while (i != end() && ((*i)->when != when || (*i)->value != value)) {
@@ -725,7 +734,7 @@ ControlList::erase_range (double start, double endt)
        bool erased = false;
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                erased = erase_range_internal (start, endt, _events);
 
                if (erased) {
@@ -764,7 +773,7 @@ void
 ControlList::slide (iterator before, double distance)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                if (before == _events.end()) {
                        return;
@@ -785,7 +794,7 @@ void
 ControlList::shift (double pos, double frames)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                for (iterator i = _events.begin(); i != _events.end(); ++i) {
                        if ((*i)->when >= pos) {
@@ -808,7 +817,7 @@ ControlList::modify (iterator iter, double when, double val)
        */
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                (*iter)->when = when;
                (*iter)->value = val;
@@ -832,7 +841,7 @@ ControlList::modify (iterator iter, double when, double val)
 std::pair<ControlList::iterator,ControlList::iterator>
 ControlList::control_points_adjacent (double xval)
 {
-       Glib::Threads::Mutex::Lock lm (_lock);
+       Glib::Threads::RWLock::ReaderLock lm (_lock);
        iterator i;
        ControlEvent cp (xval, 0.0f);
        std::pair<iterator,iterator> ret;
@@ -878,7 +887,7 @@ ControlList::thaw ()
        }
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                if (_sort_pending) {
                        _events.sort (event_time_less_than);
@@ -908,7 +917,7 @@ void
 ControlList::truncate_end (double last_coordinate)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                ControlEvent cp (last_coordinate, 0);
                ControlList::reverse_iterator i;
                double last_val;
@@ -1011,7 +1020,7 @@ void
 ControlList::truncate_start (double overall_length)
 {
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                iterator i;
                double first_legal_value;
                double first_legal_coordinate;
@@ -1276,7 +1285,7 @@ bool
 ControlList::rt_safe_earliest_event (double start, double& x, double& y, bool inclusive) const
 {
        // FIXME: It would be nice if this was unnecessary..
-       Glib::Threads::Mutex::Lock lm(_lock, Glib::Threads::TRY_LOCK);
+       Glib::Threads::RWLock::ReaderLock lm(_lock, Glib::Threads::TRY_LOCK);
        if (!lm.locked()) {
                return false;
        }
@@ -1480,7 +1489,7 @@ ControlList::cut_copy_clear (double start, double end, int op)
        ControlEvent cp (start, 0.0);
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                /* first, determine s & e, two iterators that define the range of points
                   affected by this operation
@@ -1596,7 +1605,7 @@ ControlList::paste (const ControlList& alist, double pos, float /*times*/)
        }
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
                iterator where;
                iterator prev;
                double end = 0;
@@ -1653,7 +1662,7 @@ ControlList::move_ranges (const list< RangeMove<double> >& movements)
        typedef list< RangeMove<double> > RangeMoveList;
 
        {
-               Glib::Threads::Mutex::Lock lm (_lock);
+               Glib::Threads::RWLock::WriterLock lm (_lock);
 
                /* a copy of the events list before we started moving stuff around */
                EventList old_events = _events;