Use PBD::find_files_matching_pattern instead of other variations

[ardour.git] / libs / midi++2 / mtc.cc

diff --git a/libs/midi++2/mtc.cc b/libs/midi++2/mtc.cc
index a49f469d2bd90ee7e8dc0fd806a31c002c3f6dfd..1a477c3b8caaf9f1aaacfabf86d2c4aa2431ec84 100644 (file)
--- a/libs/midi++2/mtc.cc
+++ b/libs/midi++2/mtc.cc
@@ -33,8 +33,10 @@ using namespace std;
 using namespace sigc;
 using namespace MIDI;
 
+#undef DEBUG_MTC
+
 bool
-Parser::possible_mtc (byte *sysex_buf, size_t msglen)
+Parser::possible_mtc (MIDI::byte *sysex_buf, size_t msglen)
 {
        byte fake_mtc_time[5];
 
@@ -62,6 +64,9 @@ Parser::possible_mtc (byte *sysex_buf, size_t msglen)
 
        mtc (*this, &sysex_buf[1], msglen - 1);
        mtc_time (fake_mtc_time, true, _timestamp);
+#ifdef DEBUG_MTC
+       cerr << "New full-MTC message marks state stopped" << endl;
+#endif
        mtc_status (MTC_Stopped);
 
        return true;
@@ -70,6 +75,11 @@ Parser::possible_mtc (byte *sysex_buf, size_t msglen)
 void
 Parser::reset_mtc_state ()
 {
+#ifdef DEBUG_MTC
+       cerr << "MTC state reset" << endl;
+#endif
+       /* MUST REMAIN RT-SAFE */
+
        _mtc_forward = false;
        _mtc_running = MTC_Stopped;
        _mtc_locked = false;
@@ -81,7 +91,7 @@ Parser::reset_mtc_state ()
 }
 
 void
-Parser::process_mtc_quarter_frame (byte *msg)
+Parser::process_mtc_quarter_frame (MIDI::byte *msg)
 {
        int which_quarter_frame = (msg[1] & 0xf0) >> 4;
 
@@ -119,14 +129,17 @@ Parser::process_mtc_quarter_frame (byte *msg)
 
                        /* third quarter frame */
                        
-                       // cerr << "second seen qframe = " << (int) which_quarter_frame << endl;
-
+#ifdef DEBUG_MTC
+                       cerr << "second seen qframe = " << (int) which_quarter_frame << endl;
+#endif
                        if (last_qtr_frame < which_quarter_frame) {
                                _mtc_running = MTC_Forward;
                        } else if (last_qtr_frame > which_quarter_frame) {
                                _mtc_running = MTC_Backward;
                        }
-                       
+#ifdef DEBUG_MTC
+                       cerr << "Send MTC status as " << _mtc_running << endl;
+#endif
                        mtc_status (_mtc_running);
                } 
 
@@ -172,7 +185,9 @@ Parser::process_mtc_quarter_frame (byte *msg)
                           true, just ignore this in terms of it being an error.
                        */
 
-                       if (1) { /* mtc_skipped () */
+                       boost::optional<bool> res = mtc_skipped ();
+                       
+                       if (res.get_value_or (false)) {
 
                                /* no error, reset next expected frame */
 
@@ -204,13 +219,12 @@ Parser::process_mtc_quarter_frame (byte *msg)
                                return;
                        }
 
-                       /* go back to waiting for the first frame */
+                       /* skip counts as an error ... go back to waiting for the first frame */
 
-                       expected_mtc_quarter_frame_code = 0;
-                       memset (_qtr_mtc_time, 0, sizeof (_qtr_mtc_time));
-
-                       _mtc_running = MTC_Stopped;
-                       _mtc_locked = false;
+#ifdef DEBUG_MTC
+                       cerr << "Skipped MTC qtr frame, return to stopped state" << endl;
+#endif
+                       reset_mtc_state ();
                        mtc_status (MTC_Stopped);
                        
                        return;
@@ -226,7 +240,7 @@ Parser::process_mtc_quarter_frame (byte *msg)
        /* time code is looking good */
 
 #ifdef DEBUG_MTC
-       // cerr << "for quarter frame " << which_quarter_frame << " byte = " << hex << (int) msg[1] << dec << endl;
+       cerr << "for quarter frame " << which_quarter_frame << " byte = " << hex << (int) msg[1] << dec << endl;
 #endif
 
        switch (which_quarter_frame) {
@@ -286,7 +300,7 @@ Parser::process_mtc_quarter_frame (byte *msg)
 
        switch (_mtc_running) {
        case MTC_Forward:
-               if ((which_quarter_frame == 7)) {
+               if (which_quarter_frame == 7) {
                        
                        /* we've reached the final of 8 quarter frame messages.
                           store the time, reset the pending time holder,