remove cruft

[ardour.git] / libs / surfaces / mackie / interface.cc

diff --git a/libs/surfaces/mackie/interface.cc b/libs/surfaces/mackie/interface.cc
index 500854fe7193befa2d8f54641fd36ec24f6c613a..3b0477066083f8efa3b037f4836f2084419b7dd3 100644 (file)
--- a/libs/surfaces/mackie/interface.cc
+++ b/libs/surfaces/mackie/interface.cc
@@ -15,62 +15,87 @@
        along with this program; if not, write to the Free Software
        Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
-#include <control_protocol/control_protocol.h>
-#include "mackie_control_protocol.h"
 
 #include <stdexcept>
 
+#include "pbd/error.h"
+
+#include "ardour/rc_configuration.h"
+
+#include "control_protocol/control_protocol.h"
+#include "mackie_control_protocol.h"
+
 using namespace ARDOUR;
+using namespace PBD;
 using namespace std;
+using namespace ArdourSurface;
+using namespace Mackie;
 
-ControlProtocol*
-new_mackie_protocol (ControlProtocolDescriptor* descriptor, Session* s)
+static ControlProtocol*
+new_mackie_protocol (ControlProtocolDescriptor*, Session* s)
 {
-       MackieControlProtocol * mcp = 0;
-       try
-       {
+       MackieControlProtocol* mcp = 0;
+
+       try {
                mcp = new MackieControlProtocol (*s);
-               mcp->set_active( true );
+               /* do not set active here - wait for set_state() */
        }
-       catch( exception & e )
-       {
-               cout << "Error instantiating MackieControlProtocol: " << e.what() << endl;
+       catch (exception & e) {
+               error << "Error instantiating MackieControlProtocol: " << e.what() << endmsg;
                delete mcp;
                mcp = 0;
        }
+
        return mcp;
 }
 
-void
-delete_mackie_protocol (ControlProtocolDescriptor* descriptor, ControlProtocol* cp)
+static void
+delete_mackie_protocol (ControlProtocolDescriptor*, ControlProtocol* cp)
 {
-       delete cp;
+       try
+       {
+               delete cp;
+       }
+       catch ( exception & e )
+       {
+               cout << "Exception caught trying to destroy MackieControlProtocol: " << e.what() << endl;
+       }
 }
 
-bool
-probe_mackie_protocol (ControlProtocolDescriptor* descriptor)
+/**
+       This is called on startup to check whether the lib should be loaded.
+
+       So anything that can be changed in the UI should not be used here to
+       prevent loading of the lib.
+*/
+static bool
+probe_mackie_protocol (ControlProtocolDescriptor*)
 {
        return MackieControlProtocol::probe();
 }
 
+static void*
+mackie_request_buffer_factory (uint32_t num_requests)
+{
+       return MackieControlProtocol::request_factory (num_requests);
+}
+
+// Field names commented out by JE - 06-01-2010
 static ControlProtocolDescriptor mackie_descriptor = {
-       name : "Mackie",
-       id : "uri://ardour.org/surfaces/mackie:0",
-       ptr : 0,
-       module : 0,
-       mandatory : 0,
-       supports_feedback : true,
-       probe : probe_mackie_protocol,
-       initialize : new_mackie_protocol,
-       destroy : delete_mackie_protocol
+       /*name :              */   "Mackie",
+       /*id :                */   "uri://ardour.org/surfaces/mackie:0",
+       /*ptr :               */   0,
+       /*module :            */   0,
+       /*mandatory :         */   0,
+       // actually, the surface does support feedback, but all this
+       // flag does is show a submenu on the UI, which is useless for the mackie
+       // because feedback is always on. In any case, who'd want to use the
+       // mcu without the motorised sliders doing their thing?
+       /*supports_feedback : */   false,
+       /*probe :             */   probe_mackie_protocol,
+       /*initialize :        */   new_mackie_protocol,
+       /*destroy :           */   delete_mackie_protocol,
+       /*request_buffer_factory */ mackie_request_buffer_factory
 };
-       
-
-extern "C" {
 
-ControlProtocolDescriptor* 
-protocol_descriptor () {
-       return &mackie_descriptor;
-}
-
-}
+extern "C" ARDOURSURFACE_API ControlProtocolDescriptor* protocol_descriptor () { return &mackie_descriptor; }