Setup fixed ports for MIDI control data; hence remove configuration of those ports...

[ardour.git] / libs / surfaces / mackie / interface.cc

diff --git a/libs/surfaces/mackie/interface.cc b/libs/surfaces/mackie/interface.cc
index eda485b5d65a4a90b395f63df3d088fa29141872..d3625cac51c9207df98b8b034a3aebf2b9d37135 100644 (file)
--- a/libs/surfaces/mackie/interface.cc
+++ b/libs/surfaces/mackie/interface.cc
@@ -15,10 +15,12 @@
        along with this program; if not, write to the Free Software
        Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
-#include <control_protocol/control_protocol.h>
+#include "control_protocol/control_protocol.h"
 #include "mackie_control_protocol.h"
 
-#include <pbd/error.h>
+#include "ardour/rc_configuration.h"
+
+#include "pbd/error.h"
 
 #include <stdexcept>
 
@@ -27,48 +29,44 @@ using namespace PBD;
 using namespace std;
 
 ControlProtocol*
-new_mackie_protocol (ControlProtocolDescriptor* descriptor, Session* s)
+new_mackie_protocol (ControlProtocolDescriptor*, Session* s)
 {
-       if ( Config->get_mmc_port_name().substr(0,3) == "mcu" )
-       {
-               error << "mcu already used as mmc port" << endmsg;
+       MackieControlProtocol* mcp = 0;
+       
+       try {
+               mcp = new MackieControlProtocol (*s);
+               mcp->set_active (true);
        }
-       else if ( Config->get_mtc_port_name().substr(0,3) == "mcu" )
-       {
-               error << "mcu already used as mtc port" << endmsg;
+       catch (exception & e) {
+               error << "Error instantiating MackieControlProtocol: " << e.what() << endmsg;
+               delete mcp;
+               mcp = 0;
        }
-       else if ( Config->get_midi_port_name().substr(0,3) == "mcu" )
+       
+       return mcp;
+}
+
+void
+delete_mackie_protocol (ControlProtocolDescriptor*, ControlProtocol* cp)
+{
+       try
        {
-               error << "mcu already used as midi port" << endmsg;
+               delete cp;
        }
-       else
+       catch ( exception & e )
        {
-               // no one else is using the port, so try instantiate the object
-               MackieControlProtocol * mcp = 0;
-               try
-               {
-                       mcp = new MackieControlProtocol (*s);
-                       mcp->set_active( true );
-               }
-               catch( exception & e )
-               {
-                       error << "Error instantiating MackieControlProtocol: " << e.what() << endmsg;
-                       delete mcp;
-                       mcp = 0;
-               }
-               return mcp;
+               cout << "Exception caught trying to destroy MackieControlProtocol: " << e.what() << endl;
        }
-       return 0;
 }
 
-void
-delete_mackie_protocol (ControlProtocolDescriptor* descriptor, ControlProtocol* cp)
-{
-       delete cp;
-}
+/**
+       This is called on startup to check whether the lib should be loaded.
 
+       So anything that can be changed in the UI should not be used here to
+       prevent loading of the lib.
+*/
 bool
-probe_mackie_protocol (ControlProtocolDescriptor* descriptor)
+probe_mackie_protocol (ControlProtocolDescriptor*)
 {
        return MackieControlProtocol::probe();
 }
@@ -79,7 +77,11 @@ static ControlProtocolDescriptor mackie_descriptor = {
        ptr : 0,
        module : 0,
        mandatory : 0,
-       supports_feedback : true,
+       // actually, the surface does support feedback, but all this
+       // flag does is show a submenu on the UI, which is useless for the mackie
+       // because feedback is always on. In any case, who'd want to use the
+       // mcu without the motorised sliders doing their thing?
+       supports_feedback : false,
        probe : probe_mackie_protocol,
        initialize : new_mackie_protocol,
        destroy : delete_mackie_protocol