remove PBD::Connection (replace use with PBD::ScopedConnection); remove limitation...

[ardour.git] / libs / surfaces / mackie / surface_port.cc

diff --git a/libs/surfaces/mackie/surface_port.cc b/libs/surfaces/mackie/surface_port.cc
index 24aa2296d85ce556ef6e552068a641fd8403ace6..8aaea1d5ba9ac1a7db3d5ffac04b70694cdf5fda 100644 (file)
--- a/libs/surfaces/mackie/surface_port.cc
+++ b/libs/surfaces/mackie/surface_port.cc
@@ -29,23 +29,65 @@
 
 #include <sstream>
 
+#include <cstring>
+#include <cerrno>
+
 using namespace std;
 using namespace Mackie;
 
+SurfacePort::SurfacePort()
+: _port( 0 ), _number( 0 ), _active( false )
+{
+}
+
 SurfacePort::SurfacePort( MIDI::Port & port, int number )
-: _port( port ), _number( number ), _active( false )
+: _port( &port ), _number( number ), _active( false )
 {
 }
 
+SurfacePort::~SurfacePort()
+{
+#ifdef PORT_DEBUG
+       cout << "~SurfacePort::SurfacePort()" << endl;
+#endif
+       // make sure another thread isn't reading or writing as we close the port
+       Glib::RecMutex::Lock lock( _rwlock );
+       _active = false;
+#ifdef PORT_DEBUG
+       cout << "~SurfacePort::SurfacePort() finished" << endl;
+#endif
+}
+
+// wrapper for one day when strerror_r is working properly
+string fetch_errmsg( int error_number )
+{
+       char * msg = strerror( error_number );
+       return msg;
+}
+       
 MidiByteArray SurfacePort::read()
 {
        const int max_buf_size = 512;
        MIDI::byte buf[max_buf_size];
        MidiByteArray retval;
 
+       // check active. Mainly so that the destructor
+       // doesn't destroy the mutex while it's still locked
+       if ( !active() ) return retval;
+       
        // return nothing read if the lock isn't acquired
+#if 0
        Glib::RecMutex::Lock lock( _rwlock, Glib::TRY_LOCK );
-       if ( !lock.locked() ) return retval;
+               
+       if ( !lock.locked() )
+       {
+               cout << "SurfacePort::read not locked" << endl;
+               return retval;
+       }
+       
+       // check active again - destructor sequence
+       if ( !active() ) return retval;
+#endif
        
        // read port and copy to return value
        int nread = port().read( buf, sizeof (buf) );
@@ -54,34 +96,64 @@ MidiByteArray SurfacePort::read()
                retval.copy( nread, buf );
                if ((size_t) nread == sizeof (buf))
                {
+#ifdef PORT_DEBUG
+                       cout << "SurfacePort::read recursive" << endl;
+#endif
                        retval << read();
                }
        }
        else
        {
-               ostringstream os;
-               os << "error reading from port: " << port().name() << " nread: " << nread;
-               cout << os.str() << endl;
-               //inactive_event();
-               //throw MackieControlException( os.str() );
+               if ( errno != EAGAIN )
+               {
+                       ostringstream os;
+                       os << "Surface: error reading from port: " << port().name();
+                       os << ": " << errno << fetch_errmsg( errno );
+
+                       cout << os.str() << endl;
+                       inactive_event();
+                       throw MackieControlException( os.str() );
+               }
        }
+#ifdef PORT_DEBUG
+       cout << "SurfacePort::read: " << retval << endl;
+#endif
        return retval;
 }
 
 void SurfacePort::write( const MidiByteArray & mba )
 {
-       //if ( mba[0] == 0xf0 ) cout << "SurfacePort::write: " << mba << endl;
-       //cout << "SurfacePort::write: " << mba << endl;
+#ifdef PORT_DEBUG
+       cout << "SurfacePort::write: " << mba << endl;
+#endif
+       
+       // check active before and after lock - to make sure
+       // that the destructor doesn't destroy the mutex while
+       // it's still in use
+       if ( !active() ) return;
        Glib::RecMutex::Lock lock( _rwlock );
-       int count = port().write( mba.bytes().get(), mba.size() );
+       if ( !active() ) return;
+
+       int count = port().write( mba.bytes().get(), mba.size(), 0);
        if ( count != (int)mba.size() )
        {
-               inactive_event();
-               ostringstream os;
-               os << _("Surface: couldn't write to port ") << port().name();
-               throw MackieControlException( os.str() );
+               if ( errno == 0 )
+               {
+                       cout << "port overflow on " << port().name() << ". Did not write all of " << mba << endl;
+               }
+               else if ( errno != EAGAIN )
+               {
+                       ostringstream os;
+                       os << "Surface: couldn't write to port " << port().name();
+                       os << ", error: " << fetch_errmsg( errno ) << "(" << errno << ")";
+                       
+                       cout << os.str() << endl;
+                       inactive_event();
+               }
        }
-       //if ( mba[0] == 0xf0 ) cout << "SurfacePort::write " << count << endl;
+#ifdef PORT_DEBUG
+       cout << "SurfacePort::wrote " << count << endl;
+#endif
 }
 
 void SurfacePort::write_sysex( const MidiByteArray & mba )
@@ -98,24 +170,6 @@ void SurfacePort::write_sysex( MIDI::byte msg )
        write( buf );
 }
 
-// This should be moved to midi++ at some point
-ostream & operator << ( ostream & os, const MIDI::Port & port )
-{
-       os << "device: " << port.device();
-       os << "; ";
-       os << "name: " << port.name();
-       os << "; ";
-       os << "type: " << port.type();
-       os << "; ";
-       os << "mode: " << port.mode();
-       os << "; ";
-       os << "ok: " << port.ok();
-       os << "; ";
-       os << "number: " << port.number();
-       os << "; ";
-       return os;
-}
-
 ostream & Mackie::operator << ( ostream & os, const SurfacePort & port )
 {
        os << "{ ";
@@ -123,7 +177,6 @@ ostream & Mackie::operator << ( ostream & os, const SurfacePort & port )
        os << "; ";
        os << "name: " << port.port().name();
        os << "; ";
-       os << "number: " << port.number();
        os << " }";
        return os;
 }