Don't print usage to stdout for invalid parameters

[ardour.git] / session_utils / export.cc

diff --git a/session_utils/export.cc b/session_utils/export.cc
index 2f63d14ac5d3e23f7c142bbdce6cf03f82b3dca9..15b9991fcec40fad0ea8d35b2111133ce77cceab 100644 (file)
--- a/session_utils/export.cc
+++ b/session_utils/export.cc
@@ -1,3 +1,21 @@
+/*
+ * Copyright (C) 2015-2019 Robin Gareus <robin@gareus.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
 #include <iostream>
 #include <cstdlib>
 #include <getopt.h>
@@ -189,7 +207,7 @@ static int export_session (Session *session,
        return 0;
 }
 
-static void usage (int status) {
+static void usage () {
        // help2man compatible format (standard GNU help-text)
        printf (UTILNAME " - export an ardour session from the commandline.\n\n");
        printf ("Usage: " UTILNAME " [ OPTIONS ] <session-dir> <session/snapshot-name>\n\n");
@@ -213,7 +231,7 @@ Note: the tool expects a session-name without .ardour file-name extension.\n\
 
        printf ("Report bugs to <http://tracker.ardour.org/>\n"
                "Website: <http://ardour.org/>\n");
-       ::exit (status);
+       ::exit (EXIT_SUCCESS);
 }
 
 int main (int argc, char* argv[])
@@ -291,17 +309,19 @@ int main (int argc, char* argv[])
                                break;
 
                        case 'h':
-                               usage (EXIT_SUCCESS);
+                               usage ();
                                break;
 
                        default:
-                                       usage (EXIT_FAILURE);
-                                       break;
+                               cerr << "Error: unrecognized option. See --help for usage information.\n";
+                               ::exit (EXIT_FAILURE);
+                               break;
                }
        }
 
        if (optind + 2 > argc) {
-               usage (EXIT_FAILURE);
+               cerr << "Error: Missing parameter. See --help for usage information.\n";
+               ::exit (EXIT_FAILURE);
        }
 
        SessionUtils::init(false);