X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;ds=sidebyside;f=test%2Fdcp_test.cc;h=5456092c9838ae1844adebb1c85a84230a15037e;hb=5d3d4fbd355d8d422a4ac17f93d57ab8ef0a22ee;hp=0c246ad4b6f44fbbd3c34897d7ff343e2e6e6d72;hpb=a9e6681c3b383cadbd05de188670f7f51f05a2cd;p=libdcp.git diff --git a/test/dcp_test.cc b/test/dcp_test.cc index 0c246ad4..5456092c 100644 --- a/test/dcp_test.cc +++ b/test/dcp_test.cc @@ -31,32 +31,36 @@ files in the program, then also delete it here. */ + +#include "atmos_asset.h" +#include "compose.hpp" +#include "cpl.h" #include "dcp.h" +#include "equality_options.h" #include "metadata.h" -#include "cpl.h" #include "mono_picture_asset.h" -#include "stereo_picture_asset.h" #include "picture_asset_writer.h" -#include "reel_picture_asset.h" -#include "sound_asset_writer.h" -#include "sound_asset.h" -#include "atmos_asset.h" #include "reel.h" -#include "test.h" -#include "reel_mono_picture_asset.h" -#include "reel_stereo_picture_asset.h" -#include "reel_sound_asset.h" #include "reel_atmos_asset.h" #include "reel_markers_asset.h" +#include "reel_mono_picture_asset.h" +#include "reel_picture_asset.h" +#include "reel_sound_asset.h" +#include "reel_stereo_picture_asset.h" +#include "sound_asset.h" +#include "sound_asset_writer.h" +#include "stereo_picture_asset.h" +#include "test.h" #include #include #include -using std::string; -using std::vector; + using std::dynamic_pointer_cast; -using std::shared_ptr; using std::make_shared; +using std::shared_ptr; +using std::string; +using std::vector; #if BOOST_VERSION >= 106100 using namespace boost::placeholders; #endif @@ -67,9 +71,12 @@ BOOST_AUTO_TEST_CASE (dcp_test1) { RNGFixer fixer; - make_simple("build/test/DCP/dcp_test1")->write_xml( - "OpenDCP 0.0.25", "OpenDCP 0.0.25", "2012-07-17T04:45:18+00:00", "A Test DCP" - ); + auto dcp = make_simple("build/test/DCP/dcp_test1"); + dcp->set_issuer("OpenDCP 0.0.25"); + dcp->set_creator("OpenDCP 0.0.25"); + dcp->set_issue_date("2012-07-17T04:45:18+00:00"); + dcp->set_annotation_text("A Test DCP"); + dcp->write_xml(); /* build/test/DCP/dcp_test1 is checked against test/ref/DCP/dcp_test1 by run/tests */ } @@ -100,7 +107,7 @@ BOOST_AUTO_TEST_CASE (dcp_test2) auto mp = make_shared(dcp::Fraction (24, 1), dcp::Standard::SMPTE); mp->set_metadata (mxf_meta); - auto picture_writer = mp->start_write ("build/test/DCP/dcp_test2/video.mxf", false); + auto picture_writer = mp->start_write("build/test/DCP/dcp_test2/video.mxf", dcp::PictureAsset::Behaviour::MAKE_NEW); dcp::ArrayData j2c ("test/data/flat_red.j2c"); for (int i = 0; i < 24; ++i) { /* Left */ @@ -112,7 +119,7 @@ BOOST_AUTO_TEST_CASE (dcp_test2) auto ms = make_shared(dcp::Fraction(24, 1), 48000, 1, dcp::LanguageTag("en-GB"), dcp::Standard::SMPTE); ms->set_metadata (mxf_meta); - auto sound_writer = ms->start_write ("build/test/DCP/dcp_test2/audio.mxf"); + auto sound_writer = ms->start_write("build/test/DCP/dcp_test2/audio.mxf", {}, dcp::SoundAsset::AtmosSync::DISABLED, dcp::SoundAsset::MCASubDescriptors::ENABLED); SF_INFO info; info.format = 0; @@ -123,7 +130,7 @@ BOOST_AUTO_TEST_CASE (dcp_test2) channels[0] = buffer; while (true) { auto N = sf_readf_float (sndfile, buffer, 4096); - sound_writer->write (channels, N); + sound_writer->write(channels, 1, N); if (N < 4096) { break; } @@ -138,7 +145,11 @@ BOOST_AUTO_TEST_CASE (dcp_test2) d.add (cpl); - d.write_xml ("OpenDCP 0.0.25", "OpenDCP 0.0.25", "2012-07-17T04:45:18+00:00", "Created by libdcp"); + d.set_issuer("OpenDCP 0.0.25"); + d.set_creator("OpenDCP 0.0.25"); + d.set_issue_date("2012-07-17T04:45:18+00:00"); + d.set_annotation_text("Created by libdcp"); + d.write_xml(); /* build/test/DCP/dcp_test2 is checked against test/ref/DCP/dcp_test2 by run/tests */ } @@ -199,7 +210,7 @@ test_rewriting_sound(string name, bool modify) auto reader = A_sound->asset()->start_read(); auto sound = make_shared(A_sound->asset()->edit_rate(), A_sound->asset()->sampling_rate(), A_sound->asset()->channels(), dcp::LanguageTag("en-US"), dcp::Standard::SMPTE); - auto writer = sound->start_write(path("build") / "test" / name / "pcm_8246f87f-e1df-4c42-a290-f3b3069ff021.mxf", {}); + auto writer = sound->start_write(path("build") / "test" / name / "pcm_8246f87f-e1df-4c42-a290-f3b3069ff021.mxf", {}, dcp::SoundAsset::AtmosSync::DISABLED, dcp::SoundAsset::MCASubDescriptors::ENABLED); bool need_to_modify = modify; for (int i = 0; i < A_sound->asset()->intrinsic_duration(); ++i) { @@ -217,7 +228,7 @@ test_rewriting_sound(string name, bool modify) } } } - writer->write (out, sf->samples()); + writer->write(out, sf->channels(), sf->samples()); for (int j = 0; j < sf->channels(); ++j) { delete[] out[j]; } @@ -281,7 +292,7 @@ BOOST_AUTO_TEST_CASE (dcp_test5) auto mp = make_shared(dcp::Fraction (24, 1), dcp::Standard::SMPTE); mp->set_metadata (mxf_meta); - shared_ptr picture_writer = mp->start_write ("build/test/DCP/dcp_test5/video.mxf", false); + auto picture_writer = mp->start_write("build/test/DCP/dcp_test5/video.mxf", dcp::PictureAsset::Behaviour::MAKE_NEW); dcp::ArrayData j2c ("test/data/flat_red.j2c"); for (int i = 0; i < 24; ++i) { picture_writer->write (j2c.data (), j2c.size ()); @@ -290,7 +301,7 @@ BOOST_AUTO_TEST_CASE (dcp_test5) auto ms = make_shared(dcp::Fraction(24, 1), 48000, 1, dcp::LanguageTag("en-GB"), dcp::Standard::SMPTE); ms->set_metadata (mxf_meta); - auto sound_writer = ms->start_write ("build/test/DCP/dcp_test5/audio.mxf"); + auto sound_writer = ms->start_write("build/test/DCP/dcp_test5/audio.mxf", {}, dcp::SoundAsset::AtmosSync::DISABLED, dcp::SoundAsset::MCASubDescriptors::ENABLED); SF_INFO info; info.format = 0; @@ -301,7 +312,7 @@ BOOST_AUTO_TEST_CASE (dcp_test5) channels[0] = buffer; while (true) { sf_count_t N = sf_readf_float (sndfile, buffer, 4096); - sound_writer->write (channels, N); + sound_writer->write(channels, 1, N); if (N < 4096) { break; } @@ -321,7 +332,11 @@ BOOST_AUTO_TEST_CASE (dcp_test5) d.add (cpl); - d.write_xml ("OpenDCP 0.0.25", "OpenDCP 0.0.25", "2012-07-17T04:45:18+00:00", "Created by libdcp"); + d.set_issuer("OpenDCP 0.0.25"); + d.set_creator("OpenDCP 0.0.25"); + d.set_issue_date("2012-07-17T04:45:18+00:00"); + d.set_annotation_text("Created by libdcp"); + d.write_xml(); /* build/test/DCP/dcp_test5 is checked against test/ref/DCP/dcp_test5 by run/tests */ } @@ -345,9 +360,12 @@ BOOST_AUTO_TEST_CASE (dcp_test7) { RNGFixer fix; - make_simple("build/test/DCP/dcp_test7", 1, 24, dcp::Standard::INTEROP)->write_xml( - "OpenDCP 0.0.25", "OpenDCP 0.0.25", "2012-07-17T04:45:18+00:00", "Created by libdcp" - ); + auto dcp = make_simple("build/test/DCP/dcp_test7", 1, 24, dcp::Standard::INTEROP); + dcp->set_issuer("OpenDCP 0.0.25"); + dcp->set_creator("OpenDCP 0.0.25"); + dcp->set_issue_date("2012-07-17T04:45:18+00:00"); + dcp->set_annotation_text("Created by libdcp"); + dcp->write_xml(); /* build/test/DCP/dcp_test7 is checked against test/ref/DCP/dcp_test7 by run/tests */ } @@ -483,3 +501,46 @@ BOOST_AUTO_TEST_CASE (dcp_add_kdm_test) BOOST_CHECK_EQUAL (reels[2]->_kdms[0].keys()[1].id(), kdm_2_uuid_2); } + +BOOST_AUTO_TEST_CASE(hashes_preserved_when_loading_corrupted_dcp) +{ + boost::filesystem::path const dir = "build/test/hashes_preserved_when_loading_corrupted_dcp"; + boost::filesystem::remove_all(dir); + + auto dcp = make_simple(dir / "1"); + dcp->write_xml(); + + auto asset_1_id = dcp::MonoPictureAsset(dir / "1" / "video.mxf").id(); + auto asset_1_hash = dcp::MonoPictureAsset(dir / "1" / "video.mxf").hash(); + + /* Replace the hash in the CPL (the one that corresponds to the actual file) + * with an incorrect one new_hash. + */ + string new_hash; + { + Editor editor(find_file(dir / "1", "cpl_")); + auto const after = "24"; + editor.delete_lines_after(after, 1); + + if (asset_1_hash[0] == 'A') { + new_hash = 'B' + asset_1_hash.substr(1); + } else { + new_hash = 'A' + asset_1_hash.substr(1); + } + + editor.insert(after, dcp::String::compose(" %1", new_hash)); + } + + dcp::DCP read_back(dir / "1"); + read_back.read(); + + BOOST_REQUIRE_EQUAL(read_back.cpls().size(), 1U); + auto cpl = read_back.cpls()[0]; + BOOST_REQUIRE_EQUAL(cpl->reels().size(), 1U); + auto reel = cpl->reels()[0]; + BOOST_REQUIRE(reel->main_picture()); + /* Now the asset should think it has the wrong hash written to the PKL file; it shouldn't have + * checked the file again. + */ + BOOST_CHECK_EQUAL(reel->main_picture()->asset_ref()->hash(), new_hash); +}