X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Fautomation_line.cc;h=a422bf972331c5e284510b31a8200b481684ff60;hb=b64dcac17ec6ab503198d933ef893760fb02ae22;hp=1cfd7eeb48d4a7c657d27d0142d7b35bb9a53bf6;hpb=23e7cf10191270d70357ccf0ed9294f020c7b7ab;p=ardour.git diff --git a/gtk2_ardour/automation_line.cc b/gtk2_ardour/automation_line.cc index 1cfd7eeb48..a422bf9723 100644 --- a/gtk2_ardour/automation_line.cc +++ b/gtk2_ardour/automation_line.cc @@ -17,17 +17,19 @@ */ +#include + #ifdef COMPILER_MSVC #include -/* isinf() & isnan() are C99 standards, which older MSVC doesn't provide */ -#define isinf(val) !((bool)_finite((double)val)) -#define isnan(val) (bool)_isnan((double)val) + +// 'std::isnan()' is not available in MSVC. +#define isnan_local(val) (bool)_isnan((double)val) +#else +#define isnan_local std::isnan #endif -#include #include #include -#include #include "boost/shared_ptr.hpp" @@ -39,6 +41,7 @@ #include "ardour/automation_list.h" #include "ardour/dB.h" #include "ardour/debug.h" +#include "ardour/parameter_types.h" #include "ardour/tempo.h" #include "evoral/Curve.hpp" @@ -49,17 +52,18 @@ #include "control_point.h" #include "gui_thread.h" #include "rgb_macros.h" -#include "ardour_ui.h" #include "public_editor.h" #include "selection.h" #include "time_axis_view.h" #include "point_selection.h" #include "automation_time_axis.h" +#include "ui_config.h" #include "ardour/event_type_map.h" #include "ardour/session.h" +#include "ardour/value_as_string.h" -#include "i18n.h" +#include "pbd/i18n.h" using namespace std; using namespace ARDOUR; @@ -69,8 +73,11 @@ using namespace Editing; /** @param converter A TimeConverter whose origin_b is the start time of the AutomationList in session frames. * This will not be deleted by AutomationLine. */ -AutomationLine::AutomationLine (const string& name, TimeAxisView& tv, ArdourCanvas::Item& parent, - boost::shared_ptr al, +AutomationLine::AutomationLine (const string& name, + TimeAxisView& tv, + ArdourCanvas::Item& parent, + boost::shared_ptr al, + const ParameterDescriptor& desc, Evoral::TimeConverter* converter) : trackview (tv) , _name (name) @@ -79,15 +86,15 @@ AutomationLine::AutomationLine (const string& name, TimeAxisView& tv, ArdourCanv , _parent_group (parent) , _offset (0) , _maximum_time (max_framepos) + , _fill (false) + , _desc (desc) { if (converter) { - _time_converter = converter; _our_time_converter = false; } else { - _time_converter = new Evoral::IdentityConverter; _our_time_converter = true; } - + _visible = Line; update_pending = false; @@ -98,7 +105,7 @@ AutomationLine::AutomationLine (const string& name, TimeAxisView& tv, ArdourCanv terminal_points_can_slide = true; _height = 0; - group = new ArdourCanvas::Container (&parent); + group = new ArdourCanvas::Container (&parent, ArdourCanvas::Duple(0, 1.5)); CANVAS_DEBUG_NAME (group, "region gain envelope group"); line = new ArdourCanvas::PolyLine (group); @@ -112,6 +119,7 @@ AutomationLine::AutomationLine (const string& name, TimeAxisView& tv, ArdourCanv trackview.session()->register_with_memento_command_factory(alist->id(), this); if (alist->parameter().type() == GainAutomation || + alist->parameter().type() == TrimAutomation || alist->parameter().type() == EnvelopeAutomation) { set_uses_gain_mapping (true); } @@ -137,15 +145,22 @@ AutomationLine::event_handler (GdkEvent* event) return PublicEditor::instance().canvas_line_event (event, line, this); } +bool +AutomationLine::is_stepped() const +{ + return (_desc.toggled || + (alist && alist->interpolation() == AutomationList::Discrete)); +} + void AutomationLine::update_visibility () { if (_visible & Line) { - /* Only show the line there are some points, otherwise we may show an out-of-date line + /* Only show the line when there are some points, otherwise we may show an out-of-date line when automation points have been removed (the line will still follow the shape of the old points). */ - if (alist->interpolation() != AutomationList::Discrete && control_points.size() >= 2) { + if (control_points.size() >= 2) { line->show(); } else { line->hide (); @@ -157,7 +172,7 @@ AutomationLine::update_visibility () } } else if (_visible & SelectedControlPoints) { for (vector::iterator i = control_points.begin(); i != control_points.end(); ++i) { - if ((*i)->get_selected()) { + if ((*i)->selected()) { (*i)->show (); } else { (*i)->hide (); @@ -172,7 +187,11 @@ AutomationLine::update_visibility () } else { line->hide (); for (vector::iterator i = control_points.begin(); i != control_points.end(); ++i) { - (*i)->hide (); + if (_visible & ControlPoints) { + (*i)->show (); + } else { + (*i)->hide (); + } } } @@ -182,20 +201,15 @@ void AutomationLine::hide () { /* leave control points setting unchanged, we are just hiding the - overall line + overall line */ - + set_visibility (AutomationLine::VisibleAspects (_visible & ~Line)); } double AutomationLine::control_point_box_size () { - if (alist->interpolation() == AutomationList::Discrete) { - return max((_height*4.0) / (double)(alist->parameter().max() - alist->parameter().min()), - 4.0); - } - if (_height > TimeAxisView::preset_height (HeightLarger)) { return 8.0; } else if (_height > (guint32) TimeAxisView::preset_height (HeightNormal)) { @@ -216,6 +230,11 @@ AutomationLine::set_height (guint32 h) (*i)->set_size (bsz); } + if (_fill) { + line->set_fill_y1 (_height); + } else { + line->set_fill_y1 (0); + } reset (); } } @@ -225,6 +244,7 @@ AutomationLine::set_line_color (uint32_t color) { _line_color = color; line->set_outline_color (color); + line->set_fill_color ((color & 0xffff00) + 80); // XXX TODO configurable transparency } void @@ -269,28 +289,28 @@ AutomationLine::modify_point_y (ControlPoint& cp, double y) double const x = trackview.editor().sample_to_pixel_unrounded (_time_converter->to((*cp.model())->when) - _offset); - trackview.editor().session()->begin_reversible_command (_("automation event move")); + trackview.editor().begin_reversible_command (_("automation event move")); trackview.editor().session()->add_command ( new MementoCommand (memento_command_binder(), &get_state(), 0)); cp.move_to (x, y, ControlPoint::Full); + alist->freeze (); + sync_model_with_view_point (cp); + alist->thaw (); + reset_line_coords (cp); if (line_points.size() > 1) { - line->set (line_points); + line->set_steps (line_points, is_stepped()); } - alist->freeze (); - sync_model_with_view_point (cp); - alist->thaw (); - update_pending = false; trackview.editor().session()->add_command ( new MementoCommand (memento_command_binder(), 0, &alist->get_state())); - trackview.editor().session()->commit_reversible_command (); + trackview.editor().commit_reversible_command (); trackview.editor().session()->set_dirty (); } @@ -303,14 +323,17 @@ AutomationLine::reset_line_coords (ControlPoint& cp) } } -void +bool AutomationLine::sync_model_with_view_points (list cp) { update_pending = true; + bool moved = false; for (list::iterator i = cp.begin(); i != cp.end(); ++i) { - sync_model_with_view_point (**i); + moved = sync_model_with_view_point (**i) || moved; } + + return moved; } string @@ -356,24 +379,26 @@ AutomationLine::get_verbose_cursor_relative_string (double original, double frac string AutomationLine::fraction_to_string (double fraction) const { - char buf[32]; - if (_uses_gain_mapping) { - if (fraction == 0.0) { - snprintf (buf, sizeof (buf), "-inf"); + char buf[32]; + if (_desc.type == GainAutomation || _desc.type == EnvelopeAutomation || _desc.lower == 0) { + if (fraction == 0.0) { + snprintf (buf, sizeof (buf), "-inf"); + } else { + snprintf (buf, sizeof (buf), "%.1f", accurate_coefficient_to_dB (slider_position_to_gain_with_max (fraction, _desc.upper))); + } } else { - snprintf (buf, sizeof (buf), "%.1f", accurate_coefficient_to_dB (slider_position_to_gain_with_max (fraction, Config->get_max_gain()))); + const double lower_db = accurate_coefficient_to_dB (_desc.lower); + const double range_db = accurate_coefficient_to_dB (_desc.upper) - lower_db; + snprintf (buf, sizeof (buf), "%.1f", lower_db + fraction * range_db); } + return buf; } else { view_to_model_coord_y (fraction); - if (EventTypeMap::instance().is_integer (alist->parameter())) { - snprintf (buf, sizeof (buf), "%d", (int)fraction); - } else { - snprintf (buf, sizeof (buf), "%.2f", fraction); - } + return ARDOUR::value_as_string (_desc, fraction); } - return buf; + return ""; /*NOTREACHED*/ } /** @@ -406,11 +431,7 @@ AutomationLine::fraction_to_relative_string (double original, double fraction) c } else { view_to_model_coord_y (original); view_to_model_coord_y (fraction); - if (EventTypeMap::instance().is_integer (alist->parameter())) { - snprintf (buf, sizeof (buf), "%d", (int)fraction - (int)original); - } else { - snprintf (buf, sizeof (buf), "%.2f", fraction - original); - } + return ARDOUR::value_as_string (_desc, fraction - original); } return buf; @@ -450,16 +471,15 @@ AutomationLine::string_to_fraction (string const & s) const void AutomationLine::start_drag_single (ControlPoint* cp, double x, float fraction) { - trackview.editor().session()->begin_reversible_command (_("automation event move")); trackview.editor().session()->add_command ( new MementoCommand (memento_command_binder(), &get_state(), 0)); _drag_points.clear (); _drag_points.push_back (cp); - if (cp->get_selected ()) { + if (cp->selected ()) { for (vector::iterator i = control_points.begin(); i != control_points.end(); ++i) { - if (*i != cp && (*i)->get_selected()) { + if (*i != cp && (*i)->selected()) { _drag_points.push_back (*i); } } @@ -476,7 +496,6 @@ AutomationLine::start_drag_single (ControlPoint* cp, double x, float fraction) void AutomationLine::start_drag_line (uint32_t i1, uint32_t i2, float fraction) { - trackview.editor().session()->begin_reversible_command (_("automation range move")); trackview.editor().session()->add_command ( new MementoCommand (memento_command_binder (), &get_state(), 0)); @@ -496,7 +515,6 @@ AutomationLine::start_drag_line (uint32_t i1, uint32_t i2, float fraction) void AutomationLine::start_drag_multiple (list cp, float fraction, XMLNode* state) { - trackview.editor().session()->begin_reversible_command (_("automation range move")); trackview.editor().session()->add_command ( new MementoCommand (memento_command_binder(), state, 0)); @@ -509,13 +527,13 @@ struct ControlPointSorter bool operator() (ControlPoint const * a, ControlPoint const * b) const { if (floateq (a->get_x(), b->get_x(), 1)) { return a->view_index() < b->view_index(); - } + } return a->get_x() < b->get_x(); } }; AutomationLine::ContiguousControlPoints::ContiguousControlPoints (AutomationLine& al) - : line (al), before_x (0), after_x (DBL_MAX) + : line (al), before_x (0), after_x (DBL_MAX) { } @@ -527,7 +545,7 @@ AutomationLine::ContiguousControlPoints::compute_x_bounds (PublicEditor& e) if (sz > 0 && sz < line.npoints()) { const TempoMap& map (e.session()->tempo_map()); - /* determine the limits on x-axis motion for this + /* determine the limits on x-axis motion for this contiguous range of control points */ @@ -535,8 +553,8 @@ AutomationLine::ContiguousControlPoints::compute_x_bounds (PublicEditor& e) before_x = line.nth (front()->view_index() - 1)->get_x(); const framepos_t pos = e.pixel_to_sample(before_x); - const Meter& meter = map.meter_at (pos); - const framecnt_t len = ceil (meter.frames_per_bar (map.tempo_at (pos), e.session()->frame_rate()) + const Meter& meter = map.meter_at_frame (pos); + const framecnt_t len = ceil (meter.frames_per_bar (map.tempo_at_frame (pos), e.session()->frame_rate()) / (Timecode::BBT_Time::ticks_per_beat * meter.divisions_per_bar()) ); const double one_tick_in_pixels = e.sample_to_pixel_unrounded (len); @@ -551,8 +569,8 @@ AutomationLine::ContiguousControlPoints::compute_x_bounds (PublicEditor& e) after_x = line.nth (back()->view_index() + 1)->get_x(); const framepos_t pos = e.pixel_to_sample(after_x); - const Meter& meter = map.meter_at (pos); - const framecnt_t len = ceil (meter.frames_per_bar (map.tempo_at (pos), e.session()->frame_rate()) + const Meter& meter = map.meter_at_frame (pos); + const framecnt_t len = ceil (meter.frames_per_bar (map.tempo_at_frame (pos), e.session()->frame_rate()) / (Timecode::BBT_Time::ticks_per_beat * meter.divisions_per_bar())); const double one_tick_in_pixels = e.sample_to_pixel_unrounded (len); @@ -561,8 +579,8 @@ AutomationLine::ContiguousControlPoints::compute_x_bounds (PublicEditor& e) } } -double -AutomationLine::ContiguousControlPoints::clamp_dx (double dx) +double +AutomationLine::ContiguousControlPoints::clamp_dx (double dx) { if (empty()) { return dx; @@ -570,10 +588,10 @@ AutomationLine::ContiguousControlPoints::clamp_dx (double dx) /* get the maximum distance we can move any of these points along the x-axis */ - + double tx; /* possible position a point would move to, given dx */ ControlPoint* cp; - + if (dx > 0) { /* check the last point, since we're moving later in time */ cp = back(); @@ -582,14 +600,14 @@ AutomationLine::ContiguousControlPoints::clamp_dx (double dx) cp = front(); } - tx = cp->get_x() + dx; // new possible position if we just add the motion + tx = cp->get_x() + dx; // new possible position if we just add the motion tx = max (tx, before_x); // can't move later than following point tx = min (tx, after_x); // can't move earlier than preceeding point - return tx - cp->get_x (); + return tx - cp->get_x (); } -void -AutomationLine::ContiguousControlPoints::move (double dx, double dy) +void +AutomationLine::ContiguousControlPoints::move (double dx, double dy) { for (std::list::iterator i = begin(); i != end(); ++i) { (*i)->move_to ((*i)->get_x() + dx, (*i)->get_y() - line.height() * dy, ControlPoint::Full); @@ -633,19 +651,19 @@ AutomationLine::drag_motion (double const x, float fraction, bool ignore_x, bool if (!_drag_had_movement) { - /* "first move" ... do some stuff that we don't want to do if + /* "first move" ... do some stuff that we don't want to do if no motion ever took place, but need to do before we handle motion. */ - + /* partition the points we are dragging into (potentially several) * set(s) of contiguous points. this will not happen with a normal * drag, but if the user does a discontiguous selection, it can. */ - + uint32_t expected_view_index = 0; CCP contig; - + for (list::iterator i = _drag_points.begin(); i != _drag_points.end(); ++i) { if (i == _drag_points.begin() || (*i)->view_index() != expected_view_index) { contig.reset (new ContiguousControlPoints (*this)); @@ -662,13 +680,14 @@ AutomationLine::drag_motion (double const x, float fraction, bool ignore_x, bool for (vector::iterator ccp = contiguous_points.begin(); ccp != contiguous_points.end(); ++ccp) { (*ccp)->compute_x_bounds (trackview.editor()); } - } + _drag_had_movement = true; + } /* OK, now on to the stuff related to *this* motion event. First, for * each contiguous range, figure out the maximum x-axis motion we are * allowed (because of neighbouring points that are not moving. - * - * if we are moving forwards with push, we don't need to do this, + * + * if we are moving forwards with push, we don't need to do this, * since all later points will move too. */ @@ -682,7 +701,6 @@ AutomationLine::drag_motion (double const x, float fraction, bool ignore_x, bool } /* clamp y */ - for (list::iterator i = _drag_points.begin(); i != _drag_points.end(); ++i) { double const y = ((_height - (*i)->get_y()) / _height) + dy; if (y < 0) { @@ -696,7 +714,7 @@ AutomationLine::drag_motion (double const x, float fraction, bool ignore_x, bool if (dx || dy) { /* and now move each section */ - + for (vector::iterator ccp = contiguous_points.begin(); ccp != contiguous_points.end(); ++ccp) { (*ccp)->move (dx, dy); } @@ -715,17 +733,16 @@ AutomationLine::drag_motion (double const x, float fraction, bool ignore_x, bool */ if (line_points.size() > 1) { - line->set (line_points); + line->set_steps (line_points, is_stepped()); } } - + double const result_frac = _last_drag_fraction + dy; _drag_distance += dx; _drag_x += dx; - _last_drag_fraction = fraction; - _drag_had_movement = true; + _last_drag_fraction = result_frac; did_push = with_push; - return pair (_drag_x + dx, _last_drag_fraction + dy); + return pair (_drag_x + dx, result_frac); } /** Should be called to indicate the end of a drag */ @@ -737,13 +754,13 @@ AutomationLine::end_drag (bool with_push, uint32_t final_index) } alist->freeze (); - sync_model_with_view_points (_drag_points); + bool moved = sync_model_with_view_points (_drag_points); if (with_push) { ControlPoint* p; uint32_t i = final_index; while ((p = nth (i)) != 0 && p->can_slide()) { - sync_model_with_view_point (*p); + moved = sync_model_with_view_point (*p) || moved; ++i; } } @@ -752,6 +769,12 @@ AutomationLine::end_drag (bool with_push, uint32_t final_index) update_pending = false; + if (moved) { + /* A point has moved as a result of sync (clamped to integer or boolean + value), update line accordingly. */ + line->set_steps (line_points, is_stepped()); + } + trackview.editor().session()->add_command ( new MementoCommand(memento_command_binder (), 0, &alist->get_state())); @@ -761,7 +784,7 @@ AutomationLine::end_drag (bool with_push, uint32_t final_index) contiguous_points.clear (); } -void +bool AutomationLine::sync_model_with_view_point (ControlPoint& cp) { /* find out where the visual control point is. @@ -786,6 +809,17 @@ AutomationLine::sync_model_with_view_point (ControlPoint& cp) view_to_model_coord_y (view_y); alist->modify (cp.model(), view_x, view_y); + + /* convert back from model to view y for clamping position (for integer/boolean/etc) */ + model_to_view_coord_y (view_y); + const double point_y = _height - (view_y * _height); + if (point_y != cp.get_y()) { + cp.move_to (cp.get_x(), point_y, ControlPoint::Full); + reset_line_coords (cp); + return true; + } + + return false; } bool @@ -851,15 +885,16 @@ AutomationLine::is_first_point (ControlPoint& cp) void AutomationLine::remove_point (ControlPoint& cp) { - trackview.editor().session()->begin_reversible_command (_("remove control point")); + trackview.editor().begin_reversible_command (_("remove control point")); XMLNode &before = alist->get_state(); + trackview.editor ().get_selection ().clear_points (); alist->erase (cp.model()); - + trackview.editor().session()->add_command( new MementoCommand (memento_command_binder (), &before, &alist->get_state())); - trackview.editor().session()->commit_reversible_command (); + trackview.editor().commit_reversible_command (); trackview.editor().session()->set_dirty (); } @@ -883,7 +918,7 @@ AutomationLine::get_selectables (framepos_t start, framepos_t end, double botfra /* model_when is relative to the start of the source, so we just need to add on the origin_b here (as it is the session frame position of the start of the source) */ - + framepos_t const session_frames_when = _time_converter->to (model_when) + _time_converter->origin_b (); if (session_frames_when >= start && session_frames_when <= end && (*i)->get_y() >= bot_track && (*i)->get_y() <= top_track) { @@ -909,12 +944,19 @@ AutomationLine::set_selected_points (PointSelection const & points) (*i)->set_selected (true); } + if (points.empty()) { + remove_visibility (SelectedControlPoints); + } else { + add_visibility (SelectedControlPoints); + } + set_colors (); } -void AutomationLine::set_colors () +void +AutomationLine::set_colors () { - set_line_color (ARDOUR_UI::config()->get_canvasvar_AutomationLine()); + set_line_color (UIConfiguration::instance().color ("automation line")); for (vector::iterator i = control_points.begin(); i != control_points.end(); ++i) { (*i)->set_color (); } @@ -957,7 +999,7 @@ AutomationLine::reset_callback (const Evoral::ControlList& events) np = events.size(); Evoral::ControlList& e = const_cast (events); - + for (AutomationList::iterator ai = e.begin(); ai != e.end(); ++ai, ++pi) { double tx = (*ai)->when; @@ -967,22 +1009,22 @@ AutomationLine::reset_callback (const Evoral::ControlList& events) model_to_view_coord (tx, ty); - if (isnan (tx) || isnan (ty)) { + if (isnan_local (tx) || isnan_local (ty)) { warning << string_compose (_("Ignoring illegal points on AutomationLine \"%1\""), _name) << endmsg; continue; } - + if (tx >= max_framepos || tx < 0 || tx >= _maximum_time) { continue; } - + /* convert x-coordinate to a canvas unit coordinate (this takes * zoom and scroll into account). */ - + tx = trackview.editor().sample_to_pixel_unrounded (tx); - + /* convert from canonical view height (0..1.0) to actual * height coordinates (using X11's top-left rooted system) */ @@ -1022,7 +1064,7 @@ AutomationLine::reset_callback (const Evoral::ControlList& events) line_points[n].y = control_points[n]->get_y(); } - line->set (line_points); + line->set_steps (line_points, is_stepped()); update_visibility (); } @@ -1076,11 +1118,6 @@ AutomationLine::clear () new MementoCommand (memento_command_binder (), &before, &alist->get_state())); } -void -AutomationLine::change_model (AutomationList::iterator /*i*/, double /*x*/, double /*y*/) -{ -} - void AutomationLine::set_list (boost::shared_ptr list) { @@ -1125,17 +1162,13 @@ AutomationLine::remove_visibility (VisibleAspects va) void AutomationLine::track_entered() { - if (alist->interpolation() != AutomationList::Discrete) { - add_visibility (ControlPoints); - } + add_visibility (ControlPoints); } void AutomationLine::track_exited() { - if (alist->interpolation() != AutomationList::Discrete) { - remove_visibility (ControlPoints); - } + remove_visibility (ControlPoints); } XMLNode & @@ -1162,42 +1195,64 @@ AutomationLine::view_to_model_coord (double& x, double& y) const void AutomationLine::view_to_model_coord_y (double& y) const { - /* TODO: This should be more generic ... */ - if (alist->parameter().type() == GainAutomation || - alist->parameter().type() == EnvelopeAutomation) { - y = slider_position_to_gain_with_max (y, Config->get_max_gain()); + /* TODO: This should be more generic (use ParameterDescriptor) + * or better yet: Controllable -> set_interface(); + */ + if ( alist->parameter().type() == GainAutomation + || alist->parameter().type() == EnvelopeAutomation + || (_desc.logarithmic && _desc.lower == 0. && _desc.upper > _desc.lower)) { + y = slider_position_to_gain_with_max (y, _desc.upper); + y = max ((double)_desc.lower, y); + y = min ((double)_desc.upper, y); + } else if (alist->parameter().type() == TrimAutomation + || (_desc.logarithmic && _desc.lower * _desc.upper > 0 && _desc.upper > _desc.lower)) { + const double lower_db = accurate_coefficient_to_dB (_desc.lower); + const double range_db = accurate_coefficient_to_dB (_desc.upper) - lower_db; y = max (0.0, y); - y = min (2.0, y); + y = min (1.0, y); + y = dB_to_coefficient (lower_db + y * range_db); } else if (alist->parameter().type() == PanAzimuthAutomation || alist->parameter().type() == PanElevationAutomation) { y = 1.0 - y; } else if (alist->parameter().type() == PanWidthAutomation) { y = 2.0 * y - 1.0; - } else if (alist->parameter().type() == PluginAutomation) { - y = y * (double)(alist->get_max_y()- alist->get_min_y()) + alist->get_min_y(); } else { - y = rint (y * alist->parameter().max()); + y = y * (double)(alist->get_max_y() - alist->get_min_y()) + alist->get_min_y(); + if (_desc.integer_step) { + y = round(y); + } else if (_desc.toggled) { + y = (y > 0.5) ? 1.0 : 0.0; + } } } void -AutomationLine::model_to_view_coord (double& x, double& y) const -{ - /* TODO: This should be more generic ... */ - if (alist->parameter().type() == GainAutomation || - alist->parameter().type() == EnvelopeAutomation) { - y = gain_to_slider_position_with_max (y, Config->get_max_gain()); +AutomationLine::model_to_view_coord_y (double& y) const +{ + /* TODO: This should be more generic (use ParameterDescriptor) */ + if ( alist->parameter().type() == GainAutomation + || alist->parameter().type() == EnvelopeAutomation + || (_desc.logarithmic && _desc.lower == 0. && _desc.upper > _desc.lower)) { + y = gain_to_slider_position_with_max (y, _desc.upper); + } else if (alist->parameter().type() == TrimAutomation + || (_desc.logarithmic && _desc.lower * _desc.upper > 0 && _desc.upper > _desc.lower)) { + const double lower_db = accurate_coefficient_to_dB (_desc.lower); + const double range_db = accurate_coefficient_to_dB (_desc.upper) - lower_db; + y = (accurate_coefficient_to_dB (y) - lower_db) / range_db; } else if (alist->parameter().type() == PanAzimuthAutomation || alist->parameter().type() == PanElevationAutomation) { y = 1.0 - y; } else if (alist->parameter().type() == PanWidthAutomation) { y = .5 + y * .5; - } else if (alist->parameter().type() == PluginAutomation) { - y = (y - alist->get_min_y()) / (double)(alist->get_max_y()- alist->get_min_y()); } else { - y = y / (double)alist->parameter().max(); /* ... like this */ + y = (y - alist->get_min_y()) / (double)(alist->get_max_y() - alist->get_min_y()); } +} +void +AutomationLine::model_to_view_coord (double& x, double& y) const +{ + model_to_view_coord_y (y); x = _time_converter->to (x) - _offset; } @@ -1205,16 +1260,13 @@ AutomationLine::model_to_view_coord (double& x, double& y) const void AutomationLine::interpolation_changed (AutomationList::InterpolationStyle style) { - if (style == AutomationList::Discrete) { - set_visibility (ControlPoints); - line->hide(); - } else { - set_visibility (Line); + if (line_points.size() > 1) { + line->set_steps(line_points, is_stepped()); } } void -AutomationLine::add_visible_control_point (uint32_t view_index, uint32_t pi, double tx, double ty, +AutomationLine::add_visible_control_point (uint32_t view_index, uint32_t pi, double tx, double ty, AutomationList::iterator model, uint32_t npoints) { ControlPoint::ShapeType shape;