X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Feditor_markers.cc;h=a0342327a1c15530c2e5b53c647f0e4962c787da;hb=ff80d660889b33c117ee7af24c28c1bc085778b2;hp=6dee565287967b0912cbe4ac7bc4237e34bb0993;hpb=d135c4dc3a307d0be606f3afbbc8fd8c3ec56438;p=ardour.git diff --git a/gtk2_ardour/editor_markers.cc b/gtk2_ardour/editor_markers.cc index 6dee565287..a0342327a1 100644 --- a/gtk2_ardour/editor_markers.cc +++ b/gtk2_ardour/editor_markers.cc @@ -20,7 +20,6 @@ #include #include -#include #include #include "ardour/session.h" @@ -28,12 +27,15 @@ #include "ardour/profile.h" #include "pbd/memento_command.h" +#include "canvas/canvas.h" +#include "canvas/item.h" +#include "canvas/rectangle.h" + #include "editor.h" #include "marker.h" #include "selection.h" #include "editing.h" #include "gui_thread.h" -#include "simplerect.h" #include "actions.h" #include "prompter.h" #include "editor_drag.h" @@ -62,24 +64,32 @@ Editor::add_new_location (Location *location) { ENSURE_GUI_THREAD (*this, &Editor::add_new_location, location); - ArdourCanvas::Group* group = add_new_location_internal (location); + ArdourCanvas::Container* group = add_new_location_internal (location); /* Do a full update of the markers in this group */ update_marker_labels (group); + + if (location->is_auto_punch()) { + update_punch_range_view (); + } + + if (location->is_auto_loop()) { + update_loop_range_view (); + } } /** Add a new location, without a time-consuming update of all marker labels; * the caller must call update_marker_labels () after calling this. * @return canvas group that the location's marker was added to. */ -ArdourCanvas::Group* +ArdourCanvas::Container* Editor::add_new_location_internal (Location* location) { LocationMarkers *lam = new LocationMarkers; uint32_t color; /* make a note here of which group this marker ends up in */ - ArdourCanvas::Group* group = 0; + ArdourCanvas::Container* group = 0; if (location->is_cd_marker()) { color = location_cd_marker_color; @@ -96,10 +106,10 @@ Editor::add_new_location_internal (Location* location) if (location->is_mark()) { if (location->is_cd_marker() && ruler_cd_marker_action->get_active()) { - lam->start = new Marker (*this, *cd_marker_group, color, location->name(), Marker::Mark, location->start()); + lam->start = new ArdourMarker (*this, *cd_marker_group, color, location->name(), ArdourMarker::Mark, location->start()); group = cd_marker_group; } else { - lam->start = new Marker (*this, *marker_group, color, location->name(), Marker::Mark, location->start()); + lam->start = new ArdourMarker (*this, *marker_group, color, location->name(), ArdourMarker::Mark, location->start()); group = marker_group; } @@ -108,41 +118,41 @@ Editor::add_new_location_internal (Location* location) } else if (location->is_auto_loop()) { // transport marker - lam->start = new Marker (*this, *transport_marker_group, color, - location->name(), Marker::LoopStart, location->start()); - lam->end = new Marker (*this, *transport_marker_group, color, - location->name(), Marker::LoopEnd, location->end()); + lam->start = new ArdourMarker (*this, *transport_marker_group, color, + location->name(), ArdourMarker::LoopStart, location->start()); + lam->end = new ArdourMarker (*this, *transport_marker_group, color, + location->name(), ArdourMarker::LoopEnd, location->end()); group = transport_marker_group; } else if (location->is_auto_punch()) { // transport marker - lam->start = new Marker (*this, *transport_marker_group, color, - location->name(), Marker::PunchIn, location->start()); - lam->end = new Marker (*this, *transport_marker_group, color, - location->name(), Marker::PunchOut, location->end()); + lam->start = new ArdourMarker (*this, *transport_marker_group, color, + location->name(), ArdourMarker::PunchIn, location->start()); + lam->end = new ArdourMarker (*this, *transport_marker_group, color, + location->name(), ArdourMarker::PunchOut, location->end()); group = transport_marker_group; } else if (location->is_session_range()) { // session range - lam->start = new Marker (*this, *marker_group, color, _("start"), Marker::SessionStart, location->start()); - lam->end = new Marker (*this, *marker_group, color, _("end"), Marker::SessionEnd, location->end()); + lam->start = new ArdourMarker (*this, *marker_group, color, _("start"), ArdourMarker::SessionStart, location->start()); + lam->end = new ArdourMarker (*this, *marker_group, color, _("end"), ArdourMarker::SessionEnd, location->end()); group = marker_group; } else { // range marker if (location->is_cd_marker() && ruler_cd_marker_action->get_active()) { - lam->start = new Marker (*this, *cd_marker_group, color, - location->name(), Marker::RangeStart, location->start()); - lam->end = new Marker (*this, *cd_marker_group, color, - location->name(), Marker::RangeEnd, location->end()); + lam->start = new ArdourMarker (*this, *cd_marker_group, color, + location->name(), ArdourMarker::RangeStart, location->start()); + lam->end = new ArdourMarker (*this, *cd_marker_group, color, + location->name(), ArdourMarker::RangeEnd, location->end()); group = cd_marker_group; } else { - lam->start = new Marker (*this, *range_marker_group, color, - location->name(), Marker::RangeStart, location->start()); - lam->end = new Marker (*this, *range_marker_group, color, - location->name(), Marker::RangeEnd, location->end()); + lam->start = new ArdourMarker (*this, *range_marker_group, color, + location->name(), ArdourMarker::RangeStart, location->start()); + lam->end = new ArdourMarker (*this, *range_marker_group, color, + location->name(), ArdourMarker::RangeEnd, location->end()); group = range_marker_group; } } @@ -153,11 +163,8 @@ Editor::add_new_location_internal (Location* location) lam->show (); } - location->start_changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context()); - location->end_changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context()); - location->changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context()); location->name_changed.connect (*this, invalidator (*this), boost::bind (&Editor::location_changed, this, _1), gui_context()); - location->FlagsChanged.connect (*this, invalidator (*this), boost::bind (&Editor::location_flags_changed, this, _1, _2), gui_context()); + location->FlagsChanged.connect (*this, invalidator (*this), boost::bind (&Editor::location_flags_changed, this, location), gui_context()); pair newpair; @@ -171,7 +178,7 @@ Editor::add_new_location_internal (Location* location) select_new_marker = false; } - lam->canvas_height_set (_canvas_height); + lam->canvas_height_set (_visible_canvas_height); lam->set_show_lines (_show_marker_lines); /* Add these markers to the appropriate sorted marker lists, which will render @@ -217,15 +224,15 @@ Editor::location_changed (Location *location) * lengthened) */ void -Editor::check_marker_label (Marker* m) +Editor::check_marker_label (ArdourMarker* m) { /* Get a time-ordered list of markers from the last time anything changed */ - std::list& sorted = _sorted_marker_lists[m->get_parent()]; + std::list& sorted = _sorted_marker_lists[m->get_parent()]; - list::iterator i = find (sorted.begin(), sorted.end(), m); + list::iterator i = find (sorted.begin(), sorted.end(), m); - list::iterator prev = sorted.end (); - list::iterator next = i; + list::iterator prev = sorted.end (); + list::iterator next = i; ++next; /* Look to see if the previous marker is still behind `m' in time */ @@ -256,7 +263,7 @@ Editor::check_marker_label (Marker* m) /* Update just the available space between the previous marker and this one */ - double const p = frame_to_pixel (m->position() - (*prev)->position()); + double const p = sample_to_pixel (m->position() - (*prev)->position()); if (m->label_on_left()) { (*prev)->set_right_label_limit (p / 2); @@ -275,7 +282,7 @@ Editor::check_marker_label (Marker* m) /* Update just the available space between this marker and the next */ - double const p = frame_to_pixel ((*next)->position() - m->position()); + double const p = sample_to_pixel ((*next)->position() - m->position()); if ((*next)->label_on_left()) { m->set_right_label_limit (p / 2); @@ -292,7 +299,7 @@ Editor::check_marker_label (Marker* m) } struct MarkerComparator { - bool operator() (Marker const * a, Marker const * b) { + bool operator() (ArdourMarker const * a, ArdourMarker const * b) { return a->position() < b->position(); } }; @@ -301,16 +308,16 @@ struct MarkerComparator { void Editor::update_marker_labels () { - for (std::map >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) { + for (std::map >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) { update_marker_labels (i->first); } } /** Look at all markers in a group and update label widths */ void -Editor::update_marker_labels (ArdourCanvas::Group* group) +Editor::update_marker_labels (ArdourCanvas::Container* group) { - list& sorted = _sorted_marker_lists[group]; + list& sorted = _sorted_marker_lists[group]; if (sorted.empty()) { return; @@ -320,16 +327,19 @@ Editor::update_marker_labels (ArdourCanvas::Group* group) sorted.sort (MarkerComparator ()); - list::iterator i = sorted.begin (); + list::iterator i = sorted.begin (); - list::iterator prev = sorted.end (); - list::iterator next = i; - ++next; + list::iterator prev = sorted.end (); + list::iterator next = i; + + if (next != sorted.end()) { + ++next; + } while (i != sorted.end()) { if (prev != sorted.end()) { - double const p = frame_to_pixel ((*i)->position() - (*prev)->position()); + double const p = sample_to_pixel ((*i)->position() - (*prev)->position()); if ((*prev)->label_on_left()) { (*i)->set_left_label_limit (p); @@ -340,23 +350,24 @@ Editor::update_marker_labels (ArdourCanvas::Group* group) } if (next != sorted.end()) { - double const p = frame_to_pixel ((*next)->position() - (*i)->position()); + double const p = sample_to_pixel ((*next)->position() - (*i)->position()); if ((*next)->label_on_left()) { (*i)->set_right_label_limit (p / 2); } else { (*i)->set_right_label_limit (p); } + + ++next; } prev = i; ++i; - ++next; } } void -Editor::location_flags_changed (Location *location, void*) +Editor::location_flags_changed (Location *location) { ENSURE_GUI_THREAD (*this, &Editor::location_flags_changed, location, src) @@ -456,7 +467,7 @@ Editor::find_location_markers (Location *location) const } Location * -Editor::find_location_from_marker (Marker *marker, bool& is_start) const +Editor::find_location_from_marker (ArdourMarker *marker, bool& is_start) const { LocationMarkerMap::const_iterator i; @@ -475,7 +486,7 @@ Editor::find_location_from_marker (Marker *marker, bool& is_start) const } void -Editor::refresh_location_display_internal (Locations::LocationList& locations) +Editor::refresh_location_display_internal (const Locations::LocationList& locations) { /* invalidate all */ @@ -485,7 +496,7 @@ Editor::refresh_location_display_internal (Locations::LocationList& locations) /* add new ones */ - for (Locations::LocationList::iterator i = locations.begin(); i != locations.end(); ++i) { + for (Locations::LocationList::const_iterator i = locations.begin(); i != locations.end(); ++i) { LocationMarkerMap::iterator x; @@ -521,8 +532,8 @@ Editor::refresh_location_display_internal (Locations::LocationList& locations) i = tmp; } - update_punch_range_view (false); - update_loop_range_view (false); + update_punch_range_view (); + update_loop_range_view (); } void @@ -569,11 +580,11 @@ Editor::LocationMarkers::set_name (const string& str) { /* XXX: hack: don't change names of session start/end markers */ - if (start->type() != Marker::SessionStart) { + if (start->type() != ArdourMarker::SessionStart) { start->set_name (str); } - if (end && end->type() != Marker::SessionEnd) { + if (end && end->type() != ArdourMarker::SessionEnd) { end->set_name (str); } } @@ -625,30 +636,23 @@ Editor::LocationMarkers::setup_lines () } void -Editor::mouse_add_new_marker (framepos_t where, bool is_cd, bool is_xrun) +Editor::mouse_add_new_marker (framepos_t where, bool is_cd) { - string markername, markerprefix; + string markername; int flags = (is_cd ? Location::IsCDMarker|Location::IsMark : Location::IsMark); - if (is_xrun) { - markerprefix = "xrun"; - flags = Location::IsMark; - } else { - markerprefix = "mark"; - } - if (_session) { - _session->locations()->next_available_name(markername, markerprefix); - if (!is_xrun && !choose_new_marker_name(markername)) { + _session->locations()->next_available_name(markername, _("mark")); + if (!choose_new_marker_name(markername)) { return; } Location *location = new Location (*_session, where, where, markername, (Location::Flags) flags); - _session->begin_reversible_command (_("add marker")); + begin_reversible_command (_("add marker")); + XMLNode &before = _session->locations()->get_state(); _session->locations()->add (location, true); XMLNode &after = _session->locations()->get_state(); _session->add_command (new MementoCommand(*(_session->locations()), &before, &after)); - _session->commit_reversible_command (); /* find the marker we just added */ @@ -657,9 +661,43 @@ Editor::mouse_add_new_marker (framepos_t where, bool is_cd, bool is_xrun) /* make it the selected marker */ selection->set (lam->start); } + + commit_reversible_command (); } } +void +Editor::mouse_add_new_loop (framepos_t where) +{ + if (!_session) { + return; + } + + /* Make this marker 1/8th of the visible area of the session so that + it's reasonably easy to manipulate after creation. + */ + + framepos_t const end = where + current_page_samples() / 8; + + set_loop_range (where, end, _("set loop range")); +} + +void +Editor::mouse_add_new_punch (framepos_t where) +{ + if (!_session) { + return; + } + + /* Make this marker 1/8th of the visible area of the session so that + it's reasonably easy to manipulate after creation. + */ + + framepos_t const end = where + current_page_samples() / 8; + + set_punch_range (where, end, _("set punch range")); +} + void Editor::mouse_add_new_range (framepos_t where) { @@ -671,7 +709,7 @@ Editor::mouse_add_new_range (framepos_t where) it's reasonably easy to manipulate after creation. */ - framepos_t const end = where + current_page_frames() / 8; + framepos_t const end = where + current_page_samples() / 8; string name; _session->locations()->next_available_name (name, _("range")); @@ -688,12 +726,12 @@ Editor::mouse_add_new_range (framepos_t where) void Editor::remove_marker (ArdourCanvas::Item& item, GdkEvent*) { - Marker* marker; + ArdourMarker* marker; bool is_start; - if ((marker = static_cast (item.get_data ("marker"))) == 0) { + if ((marker = static_cast (item.get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } if (entered_marker == marker) { @@ -710,12 +748,12 @@ Editor::remove_marker (ArdourCanvas::Item& item, GdkEvent*) gint Editor::really_remove_marker (Location* loc) { - _session->begin_reversible_command (_("remove marker")); + begin_reversible_command (_("remove marker")); XMLNode &before = _session->locations()->get_state(); _session->locations()->remove (loc); XMLNode &after = _session->locations()->get_state(); _session->add_command (new MementoCommand(*(_session->locations()), &before, &after)); - _session->commit_reversible_command (); + commit_reversible_command (); return FALSE; } @@ -727,11 +765,11 @@ Editor::location_gone (Location *location) LocationMarkerMap::iterator i; if (location == transport_loop_location()) { - update_loop_range_view (true); + update_loop_range_view (); } if (location == transport_punch_location()) { - update_punch_range_view (true); + update_punch_range_view (); } for (i = location_markers.begin(); i != location_markers.end(); ++i) { @@ -777,10 +815,10 @@ Editor::tempo_or_meter_marker_context_menu (GdkEventButton* ev, ArdourCanvas::It void Editor::marker_context_menu (GdkEventButton* ev, ArdourCanvas::Item* item) { - Marker * marker; - if ((marker = reinterpret_cast (item->get_data("marker"))) == 0) { + ArdourMarker * marker; + if ((marker = reinterpret_cast (item->get_data("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } bool is_start; @@ -961,11 +999,11 @@ Editor::build_new_transport_marker_menu () void Editor::marker_menu_hide () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -979,11 +1017,11 @@ Editor::marker_menu_hide () void Editor::marker_menu_select_using_range () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -997,11 +1035,11 @@ Editor::marker_menu_select_using_range () void Editor::marker_menu_select_all_selectables_using_range () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1016,11 +1054,11 @@ Editor::marker_menu_select_all_selectables_using_range () void Editor::marker_menu_separate_regions_using_location () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1035,11 +1073,11 @@ Editor::marker_menu_separate_regions_using_location () void Editor::marker_menu_play_from () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1065,11 +1103,11 @@ Editor::marker_menu_play_from () void Editor::marker_menu_set_playhead () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1093,14 +1131,14 @@ Editor::marker_menu_set_playhead () void Editor::marker_menu_range_to_next () { - Marker* marker; + ArdourMarker* marker; if (!_session) { return; } - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1126,11 +1164,11 @@ Editor::marker_menu_range_to_next () void Editor::marker_menu_set_from_playhead () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1154,11 +1192,11 @@ Editor::marker_menu_set_from_playhead () void Editor::marker_menu_set_from_selection (bool /*force_regions*/) { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1185,11 +1223,11 @@ Editor::marker_menu_set_from_selection (bool /*force_regions*/) void Editor::marker_menu_play_range () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1210,11 +1248,11 @@ Editor::marker_menu_play_range () void Editor::marker_menu_loop_range () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* l; @@ -1226,8 +1264,8 @@ Editor::marker_menu_loop_range () l2->set (l->start(), l->end()); // enable looping, reposition and start rolling - _session->request_play_loop(true); _session->request_locate (l2->start(), true); + _session->request_play_loop(true); } } } @@ -1236,7 +1274,7 @@ Editor::marker_menu_loop_range () void Editor::marker_menu_zoom_to_range () { - Marker* marker = reinterpret_cast (marker_menu_item->get_data ("marker")); + ArdourMarker* marker = reinterpret_cast (marker_menu_item->get_data ("marker")); assert (marker); bool is_start; @@ -1262,10 +1300,10 @@ Editor::marker_menu_zoom_to_range () void Editor::dynamic_cast_marker_object (void* p, MeterMarker** m, TempoMarker** t) const { - Marker* marker = reinterpret_cast (p); + ArdourMarker* marker = reinterpret_cast (p); if (!marker) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } *m = dynamic_cast (marker); @@ -1305,11 +1343,11 @@ Editor::marker_menu_remove () void Editor::toggle_marker_menu_lock () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* loc; @@ -1331,19 +1369,30 @@ Editor::toggle_marker_menu_lock () void Editor::marker_menu_rename () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } + + rename_marker (marker); +} + +void +Editor::rename_marker(ArdourMarker *marker) +{ Location* loc; bool is_start; loc = find_location_from_marker (marker, is_start); - if (!loc) return; + if (!loc) + return; + + if (loc == transport_loop_location() || loc == transport_punch_location() || loc->is_session_range()) + return; ArdourPrompter dialog (true); string txt; @@ -1378,6 +1427,7 @@ Editor::marker_menu_rename () dialog.get_result(txt); loc->set_name (txt); + _session->set_dirty (); XMLNode &after = _session->locations()->get_state(); _session->add_command (new MementoCommand(*(_session->locations()), &before, &after)); @@ -1406,7 +1456,7 @@ Editor::new_transport_marker_menu_set_punch () } void -Editor::update_loop_range_view (bool visibility) +Editor::update_loop_range_view () { if (_session == 0) { return; @@ -1416,23 +1466,21 @@ Editor::update_loop_range_view (bool visibility) if (_session->get_play_loop() && ((tll = transport_loop_location()) != 0)) { - double x1 = frame_to_pixel (tll->start()); - double x2 = frame_to_pixel (tll->end()); - - transport_loop_range_rect->property_x1() = x1; - transport_loop_range_rect->property_x2() = x2; + double x1 = sample_to_pixel (tll->start()); + double x2 = sample_to_pixel (tll->end()); - if (visibility) { - transport_loop_range_rect->show(); - } + transport_loop_range_rect->set_x0 (x1); + transport_loop_range_rect->set_x1 (x2); - } else if (visibility) { + transport_loop_range_rect->show(); + + } else { transport_loop_range_rect->hide(); } } void -Editor::update_punch_range_view (bool visibility) +Editor::update_punch_range_view () { if (_session == 0) { return; @@ -1441,20 +1489,27 @@ Editor::update_punch_range_view (bool visibility) Location* tpl; if ((_session->config.get_punch_in() || _session->config.get_punch_out()) && ((tpl = transport_punch_location()) != 0)) { - guint track_canvas_width,track_canvas_height; - track_canvas->get_size(track_canvas_width,track_canvas_height); + + double pixel_start; + double pixel_end; + if (_session->config.get_punch_in()) { - transport_punch_range_rect->property_x1() = frame_to_pixel (tpl->start()); - transport_punch_range_rect->property_x2() = (_session->config.get_punch_out() ? frame_to_pixel (tpl->end()) : frame_to_pixel (JACK_MAX_FRAMES)); + pixel_start = sample_to_pixel (tpl->start()); } else { - transport_punch_range_rect->property_x1() = 0; - transport_punch_range_rect->property_x2() = (_session->config.get_punch_out() ? frame_to_pixel (tpl->end()) : track_canvas_width); + pixel_start = 0; } - - if (visibility) { - transport_punch_range_rect->show(); + if (_session->config.get_punch_out()) { + pixel_end = sample_to_pixel (tpl->end()); + } else { + pixel_end = sample_to_pixel (max_framepos); } - } else if (visibility) { + + transport_punch_range_rect->set_x0 (pixel_start); + transport_punch_range_rect->set_x1 (pixel_end); + transport_punch_range_rect->show(); + + } else { + transport_punch_range_rect->hide(); } } @@ -1508,11 +1563,11 @@ Editor::goto_nth_marker (int n) void Editor::toggle_marker_menu_glue () { - Marker* marker; + ArdourMarker* marker; - if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { + if ((marker = reinterpret_cast (marker_menu_item->get_data ("marker"))) == 0) { fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } Location* loc; @@ -1543,14 +1598,14 @@ Editor::toggle_marker_lines () } void -Editor::remove_sorted_marker (Marker* m) +Editor::remove_sorted_marker (ArdourMarker* m) { - for (std::map >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) { + for (std::map >::iterator i = _sorted_marker_lists.begin(); i != _sorted_marker_lists.end(); ++i) { i->second.remove (m); } } -Marker * +ArdourMarker * Editor::find_marker_from_location_id (PBD::ID const & id, bool is_start) const { for (LocationMarkerMap::const_iterator i = location_markers.begin(); i != location_markers.end(); ++i) {