X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Fgroup_tabs.cc;h=63d8d5925691cdf4ad4c4d599790b72b948c47f3;hb=8bc2bf0155740b6f77bbe917285cd13610bdcb81;hp=99a21668c14933256a4cf213f2f2905a1e32cd5e;hpb=91fac4c96dc6210dcc056da70dc608700d7eb570;p=ardour.git diff --git a/gtk2_ardour/group_tabs.cc b/gtk2_ardour/group_tabs.cc index 99a21668c1..63d8d59256 100644 --- a/gtk2_ardour/group_tabs.cc +++ b/gtk2_ardour/group_tabs.cc @@ -18,18 +18,23 @@ */ #include + #include "ardour/session.h" #include "ardour/route_group.h" #include "ardour/route.h" +#include "ardour/vca_manager.h" +#include "ardour/vca.h" + +#include "gtkmm2ext/doi.h" #include "gui_thread.h" #include "route_group_dialog.h" -#include "global_signals.h" #include "group_tabs.h" #include "keyboard.h" -#include "i18n.h" +#include "pbd/i18n.h" #include "ardour_ui.h" #include "rgb_macros.h" +#include "ui_config.h" #include "utils.h" using namespace std; @@ -46,7 +51,7 @@ GroupTabs::GroupTabs () , _dragging_new_tab (0) { add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK|Gdk::POINTER_MOTION_MASK); - ColorsChanged.connect (sigc::mem_fun (*this, &GroupTabs::queue_draw)); + UIConfiguration::instance().ColorsChanged.connect (sigc::mem_fun (*this, &GroupTabs::queue_draw)); } GroupTabs::~GroupTabs () @@ -69,8 +74,8 @@ GroupTabs::set_session (Session* s) _session->RouteRemovedFromRouteGroup.connect ( _session_connections, invalidator (*this), boost::bind (&GroupTabs::route_removed_from_route_group, this, _1, _2), gui_context() ); - - _session->route_group_removed.connect (_session_connections, invalidator (*this), boost::bind (&GroupTabs::set_dirty, this), gui_context()); + + _session->route_group_removed.connect (_session_connections, invalidator (*this), boost::bind (&GroupTabs::set_dirty, this, (cairo_rectangle_t*)0), gui_context()); } } @@ -81,9 +86,8 @@ GroupTabs::set_session (Session* s) void GroupTabs::on_size_request (Gtk::Requisition *req) { - /* Use a dummy, small width and the actual height that we want */ - req->width = 16; - req->height = 16; + req->width = std::max (16.f, rintf (16.f * UIConfiguration::instance().get_ui_scale())); + req->height = std::max (16.f, rintf (16.f * UIConfiguration::instance().get_ui_scale())); } bool @@ -138,13 +142,13 @@ GroupTabs::on_button_press_event (GdkEventButton* ev) } else if (ev->button == 3) { RouteGroup* g = t ? t->group : 0; - - if (Keyboard::modifier_state_equals (ev->state, Keyboard::PrimaryModifier) && g) { - /* edit */ - RouteGroupDialog d (g, false); - d.do_run (); + + if (Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier) && g) { + remove_group (g); + } else if (Keyboard::modifier_state_equals (ev->state, Keyboard::PrimaryModifier) && g) { + edit_group (g); } else { - Menu* m = get_menu (g); + Menu* m = get_menu (g, true); if (m) { m->popup (ev->button, ev->time); } @@ -191,36 +195,31 @@ GroupTabs::on_button_release_event (GdkEventButton*) if (_dragging == 0) { return false; } - + if (!_drag_moved) { - + if (_dragging->group) { /* toggle active state */ _dragging->group->set_active (!_dragging->group->is_active (), this); } - + } else { /* finish drag */ RouteList routes = routes_for_tab (_dragging); - + if (!routes.empty()) { if (_dragging_new_tab) { - RouteGroup* g = create_and_add_group (); - if (g) { - for (RouteList::iterator i = routes.begin(); i != routes.end(); ++i) { - g->add (*i); - } - } + run_new_group_dialog (&routes, false); } else { boost::shared_ptr r = _session->get_routes (); for (RouteList::iterator i = r->begin(); i != r->end(); ++i) { - + bool const was_in_tab = find ( _initial_dragging_routes.begin(), _initial_dragging_routes.end(), *i ) != _initial_dragging_routes.end (); - + bool const now_in_tab = find (routes.begin(), routes.end(), *i) != routes.end(); - + if (was_in_tab && !now_in_tab) { _dragging->group->remove (*i); } else if (!was_in_tab && now_in_tab) { @@ -229,11 +228,11 @@ GroupTabs::on_button_release_event (GdkEventButton*) } } } - + set_dirty (); queue_draw (); } - + _dragging = 0; _initial_dragging_routes.clear (); @@ -241,8 +240,9 @@ GroupTabs::on_button_release_event (GdkEventButton*) } void -GroupTabs::render (cairo_t* cr, cairo_rectangle_t*) +GroupTabs::render (Cairo::RefPtr const& ctx, cairo_rectangle_t*) { + cairo_t* cr = ctx->cobj(); if (_dragging == 0) { _tabs = compute_tabs (); } @@ -254,7 +254,7 @@ GroupTabs::render (cairo_t* cr, cairo_rectangle_t*) cairo_set_source_rgb (cr, c.get_red_p(), c.get_green_p(), c.get_blue_p()); cairo_rectangle (cr, 0, 0, get_width(), get_height()); cairo_fill (cr); - + /* tabs */ for (list::const_iterator i = _tabs.begin(); i != _tabs.end(); ++i) { @@ -300,31 +300,76 @@ GroupTabs::click_to_tab (double c, list::iterator* prev, list::iterato return under; } +void +GroupTabs::add_new_from_items (Menu_Helpers::MenuList& items) +{ + using namespace Menu_Helpers; + Menu *new_from; + + new_from = manage (new Menu); + { + MenuList& f = new_from->items (); + f.push_back (MenuElem (_("Selection..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_from_selection), false))); + f.push_back (MenuElem (_("Record Enabled..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_from_rec_enabled), false))); + f.push_back (MenuElem (_("Soloed..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_from_soloed), false))); + } + items.push_back (MenuElem (_("Create New Group From..."), *new_from)); + + new_from = manage (new Menu); + { + MenuList& f = new_from->items (); + f.push_back (MenuElem (_("Selection..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_from_selection), true))); + f.push_back (MenuElem (_("Record Enabled..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_from_rec_enabled), true))); + f.push_back (MenuElem (_("Soloed..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_from_soloed), true))); + } + items.push_back (MenuElem (_("Create New Group with Master From..."), *new_from)); +} + Gtk::Menu* -GroupTabs::get_menu (RouteGroup* g) +GroupTabs::get_menu (RouteGroup* g, bool in_tab_area) { using namespace Menu_Helpers; delete _menu; - Menu* new_from = new Menu; - MenuList& f = new_from->items (); - f.push_back (MenuElem (_("Selection..."), sigc::mem_fun (*this, &GroupTabs::new_from_selection))); - f.push_back (MenuElem (_("Record Enabled..."), sigc::mem_fun (*this, &GroupTabs::new_from_rec_enabled))); - f.push_back (MenuElem (_("Soloed..."), sigc::mem_fun (*this, &GroupTabs::new_from_soloed))); - _menu = new Menu; _menu->set_name ("ArdourContextMenu"); + MenuList& items = _menu->items(); + Menu* vca_menu; - items.push_back (MenuElem (_("Create New Group ..."), hide_return (sigc::mem_fun(*this, &GroupTabs::create_and_add_group)))); - items.push_back (MenuElem (_("Create New Group From"), *new_from)); + const VCAList vcas = _session->vca_manager().vcas (); + + if (!in_tab_area) { + /* context menu is not for a group tab, show the "create new + from" items here + */ + add_new_from_items (items); + } if (g) { + items.push_back (SeparatorElem()); items.push_back (MenuElem (_("Edit Group..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::edit_group), g))); items.push_back (MenuElem (_("Collect Group"), sigc::bind (sigc::mem_fun (*this, &GroupTabs::collect), g))); items.push_back (MenuElem (_("Remove Group"), sigc::bind (sigc::mem_fun (*this, &GroupTabs::remove_group), g))); + + items.push_back (SeparatorElem()); + + if (g->has_control_master()) { + items.push_back (MenuElem (_("Drop Group from VCA..."), sigc::bind (sigc::mem_fun (*this, &GroupTabs::unassign_group_to_master), g->group_master_number(), g))); + } else { + vca_menu = manage (new Menu); + MenuList& f (vca_menu->items()); + f.push_back (MenuElem ("New", sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_group_to_master), 0, g, true))); + + for (VCAList::const_iterator v = vcas.begin(); v != vcas.end(); ++v) { + f.push_back (MenuElem ((*v)->name().empty() ? string_compose ("VCA %1", (*v)->number()) : (*v)->name(), sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_group_to_master), (*v)->number(), g, true))); + } + items.push_back (MenuElem (_("Assign Group to VCA..."), *vca_menu)); + } + items.push_back (SeparatorElem()); + if (g->has_subgroup()) { items.push_back (MenuElem (_("Remove Subgroup Bus"), sigc::bind (sigc::mem_fun (*this, &GroupTabs::un_subgroup), g))); } else { @@ -332,51 +377,185 @@ GroupTabs::get_menu (RouteGroup* g) } items.push_back (MenuElem (_("Add New Aux Bus (pre-fader)"), sigc::bind (sigc::mem_fun (*this, &GroupTabs::subgroup), g, true, PreFader))); items.push_back (MenuElem (_("Add New Aux Bus (post-fader)"), sigc::bind (sigc::mem_fun (*this, &GroupTabs::subgroup), g, true, PostFader))); + items.push_back (SeparatorElem()); + } add_menu_items (_menu, g); + if (in_tab_area) { + /* context menu is for a group tab, show the "create new + from" items here + */ + add_new_from_items (items); + } + + items.push_back (SeparatorElem()); + + vca_menu = manage (new Menu); + { + MenuList& f (vca_menu->items()); + f.push_back (MenuElem ("New", sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_selection_to_master), 0))); + for (VCAList::const_iterator v = vcas.begin(); v != vcas.end(); ++v) { + f.push_back (MenuElem ((*v)->name().empty() ? string_compose ("VCA %1", (*v)->number()) : (*v)->name(), sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_selection_to_master), (*v)->number()))); + } + } + + items.push_back (MenuElem (_("Assign Selection to VCA..."), *vca_menu)); + + vca_menu = manage (new Menu); + { + MenuList& f (vca_menu->items()); + f.push_back (MenuElem ("New", sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_recenabled_to_master), 0))); + for (VCAList::const_iterator v = vcas.begin(); v != vcas.end(); ++v) { + f.push_back (MenuElem ((*v)->name().empty() ? string_compose ("VCA %1", (*v)->number()) : (*v)->name(), sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_recenabled_to_master), (*v)->number()))); + } + + } + items.push_back (MenuElem (_("Assign Record Enabled to VCA..."), *vca_menu)); + + vca_menu = manage (new Menu); + { + MenuList& f (vca_menu->items()); + f.push_back (MenuElem ("New", sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_soloed_to_master), 0))); + for (VCAList::const_iterator v = vcas.begin(); v != vcas.end(); ++v) { + f.push_back (MenuElem ((*v)->name().empty() ? string_compose ("VCA %1", (*v)->number()) : (*v)->name(), sigc::bind (sigc::mem_fun (*this, &GroupTabs::assign_soloed_to_master), (*v)->number()))); + } + + } + items.push_back (MenuElem (_("Assign Soloed to VCA..."), *vca_menu)); + items.push_back (SeparatorElem()); items.push_back (MenuElem (_("Enable All Groups"), sigc::mem_fun(*this, &GroupTabs::activate_all))); items.push_back (MenuElem (_("Disable All Groups"), sigc::mem_fun(*this, &GroupTabs::disable_all))); return _menu; +} + +void +GroupTabs::assign_group_to_master (uint32_t which, RouteGroup* group, bool rename_master) const +{ + if (!_session || !group) { + return; + } + + boost::shared_ptr master; + + if (which == 0) { + if (_session->vca_manager().create_vca (1)) { + /* error */ + return; + } + + /* Get most recently created VCA... */ + which = _session->vca_manager().vcas().back()->number(); + } + + master = _session->vca_manager().vca_by_number (which); + if (!master) { + /* should never happen; if it does, basically something deeply + odd happened, no reason to tell user because there's no + sensible explanation. + */ + return; + } + + group->assign_master (master); + + if (rename_master){ + master->set_name (group->name()); + } } void -GroupTabs::new_from_selection () +GroupTabs::unassign_group_to_master (uint32_t which, RouteGroup* group) const { - RouteList rl = selected_routes (); - if (rl.empty()) { + if (!_session || !group) { return; } - run_new_group_dialog (rl); + boost::shared_ptr master = _session->vca_manager().vca_by_number (which); + + if (!master) { + /* should never happen; if it does, basically something deeply + odd happened, no reason to tell user because there's no + sensible explanation. + */ + return; + } + + group->unassign_master (master); } void -GroupTabs::new_from_rec_enabled () +GroupTabs::assign_some_to_master (uint32_t which, RouteList rl, std::string vcaname) { - boost::shared_ptr rl = _session->get_routes (); + if (!_session) { + return; + } - RouteList rec_enabled; + boost::shared_ptr master; + bool set_name = false; - for (RouteList::iterator i = rl->begin(); i != rl->end(); ++i) { - if ((*i)->record_enabled()) { - rec_enabled.push_back (*i); + if (which == 0) { + if (_session->vca_manager().create_vca (1)) { + /* error */ + return; } + set_name = true; + + /* Get most recently created VCA... */ + which = _session->vca_manager().vcas().back()->number(); } - if (rec_enabled.empty()) { + master = _session->vca_manager().vca_by_number (which); + + if (!master) { + /* should never happen; if it does, basically something deeply + odd happened, no reason to tell user because there's no + sensible explanation. + */ return; } - run_new_group_dialog (rec_enabled); + + if (rl.empty()) { + return; + } + + for (RouteList::iterator r = rl.begin(); r != rl.end(); ++r) { + (*r)->assign (master); + } + if (set_name && !vcaname.empty()) { + master->set_name (vcaname); + } } -void -GroupTabs::new_from_soloed () +RouteList +GroupTabs::get_rec_enabled () +{ + RouteList rec_enabled; + + if (!_session) { + return rec_enabled; + } + + boost::shared_ptr rl = _session->get_routes (); + + for (RouteList::iterator i = rl->begin(); i != rl->end(); ++i) { + boost::shared_ptr trk (boost::dynamic_pointer_cast (*i)); + if (trk && trk->rec_enable_control()->get_value()) { + rec_enabled.push_back (*i); + } + } + + return rec_enabled; +} + + +RouteList +GroupTabs::get_soloed () { boost::shared_ptr rl = _session->get_routes (); @@ -388,74 +567,102 @@ GroupTabs::new_from_soloed () } } - if (soloed.empty()) { - return; - } + return soloed; +} - run_new_group_dialog (soloed); +void +GroupTabs::assign_selection_to_master (uint32_t which) +{ + assign_some_to_master (which, selected_routes (), _("Selection")); } -PBD::PropertyList -GroupTabs::default_properties () const +void +GroupTabs::assign_recenabled_to_master (uint32_t which) { - PBD::PropertyList plist; + assign_some_to_master (which, get_rec_enabled()); +} - plist.add (Properties::route_active, true); - plist.add (Properties::active, true); - plist.add (Properties::gain, true); - plist.add (Properties::relative, true); - plist.add (Properties::color, true); - plist.add (Properties::monitoring, true); - plist.add (Properties::select, true); - plist.add (Properties::mute, true); - plist.add (Properties::solo, true); - plist.add (Properties::gain, true); - plist.add (Properties::recenable, true); +void +GroupTabs::assign_soloed_to_master (uint32_t which) +{ + assign_some_to_master (which, get_soloed()); +} - return plist; +void +GroupTabs::new_from_selection (bool with_master) +{ + RouteList rl (selected_routes()); + run_new_group_dialog (&rl, with_master); } void -GroupTabs::run_new_group_dialog (RouteList const & rl) +GroupTabs::new_from_rec_enabled (bool with_master) { - RouteGroup* g = new RouteGroup (*_session, ""); - g->apply_changes (default_properties ()); + RouteList rl (get_rec_enabled()); + run_new_group_dialog (&rl, with_master); +} - RouteGroupDialog d (g, true); +void +GroupTabs::new_from_soloed (bool with_master) +{ + RouteList rl (get_soloed()); + run_new_group_dialog (&rl, with_master); +} - if (d.do_run ()) { - delete g; - } else { - _session->add_route_group (g); - for (RouteList::const_iterator i = rl.begin(); i != rl.end(); ++i) { - g->add (*i); - } +void +GroupTabs::run_new_group_dialog (RouteList const * rl, bool with_master) +{ + if (rl && rl->empty()) { + return; } + + RouteGroup* g = new RouteGroup (*_session, ""); + RouteGroupDialog* d = new RouteGroupDialog (g, true); + + d->signal_response().connect (sigc::bind (sigc::mem_fun (*this, &GroupTabs::new_group_dialog_finished), d, rl ? new RouteList (*rl): 0, with_master)); + d->present (); } -RouteGroup * -GroupTabs::create_and_add_group () const +void +GroupTabs::new_group_dialog_finished (int r, RouteGroupDialog* d, RouteList const * rl, bool with_master) const { - RouteGroup* g = new RouteGroup (*_session, ""); + if (r == RESPONSE_OK) { - g->apply_changes (default_properties ()); + if (!d->name_check()) { + return; + } - RouteGroupDialog d (g, true); + _session->add_route_group (d->group()); - if (d.do_run ()) { - delete g; - return 0; + if (rl) { + for (RouteList::const_iterator i = rl->begin(); i != rl->end(); ++i) { + d->group()->add (*i); + } + + if (with_master) { + assign_group_to_master (0, d->group(), true); /* zero => new master */ + } + } + } else { + delete d->group (); } - _session->add_route_group (g); - return g; + delete rl; + delete_when_idle (d); } void GroupTabs::edit_group (RouteGroup* g) { - RouteGroupDialog d (g, false); - d.do_run (); + RouteGroupDialog* d = new RouteGroupDialog (g, false); + d->signal_response().connect (sigc::bind (sigc::mem_fun (*this, &GroupTabs::edit_group_dialog_finished), d)); + d->present (); +} + +void +GroupTabs::edit_group_dialog_finished (int r, RouteGroupDialog* d) const +{ + delete_when_idle (d); } void @@ -470,18 +677,6 @@ GroupTabs::un_subgroup (RouteGroup* g) g->destroy_subgroup (); } -struct CollectSorter { - bool operator () (boost::shared_ptr a, boost::shared_ptr b) { - return a->order_key () < b->order_key (); - } -}; - -struct OrderSorter { - bool operator() (boost::shared_ptr a, boost::shared_ptr b) { - return a->order_key () < b->order_key (); - } -}; - /** Collect all members of a RouteGroup so that they are together in the Editor or Mixer. * @param g Group to collect. */ @@ -489,19 +684,22 @@ void GroupTabs::collect (RouteGroup* g) { boost::shared_ptr group_routes = g->route_list (); - group_routes->sort (CollectSorter ()); + group_routes->sort (Stripable::Sorter()); int const N = group_routes->size (); RouteList::iterator i = group_routes->begin (); boost::shared_ptr routes = _session->get_routes (); - routes->sort (OrderSorter ()); + routes->sort (Stripable::Sorter()); RouteList::const_iterator j = routes->begin (); int diff = 0; int coll = -1; + + PresentationInfo::ChangeSuspender cs; + while (i != group_routes->end() && j != routes->end()) { - int const k = (*j)->order_key (); + PresentationInfo::order_t const k = (*j)->presentation_info ().order(); if (*i == *j) { @@ -512,21 +710,19 @@ GroupTabs::collect (RouteGroup* g) --diff; } - (*j)->set_order_key (coll); + (*j)->set_presentation_order (coll); ++coll; ++i; } else { - (*j)->set_order_key (k + diff); + (*j)->set_presentation_order (k + diff); } ++j; } - - sync_order_keys (); } void @@ -554,7 +750,10 @@ GroupTabs::set_activation (RouteGroup* g, bool a) void GroupTabs::remove_group (RouteGroup* g) { + boost::shared_ptr rl (g->route_list ()); _session->remove_route_group (*g); + + emit_gui_changed_for_members (rl); } /** Set the color of the tab of a route group */ @@ -562,41 +761,8 @@ void GroupTabs::set_group_color (RouteGroup* group, uint32_t color) { assert (group); - uint32_t r, g, b, a; - - UINT_TO_RGBA (color, &r, &g, &b, &a); - - /* Hack to disallow black route groups; force a dark grey instead */ - - if (r == 0 && g == 0 && b == 0) { - r = 25; - g = 25; - b = 25; - } - - GUIObjectState& gui_state = *ARDOUR_UI::instance()->gui_object_state; - - char buf[64]; - - /* for historical reasons the colors must be stored as 16 bit color - * values. Ugh. - */ - - snprintf (buf, sizeof (buf), "%d:%d:%d", (r<<8), (g<<8), (b<<8)); - gui_state.set_property (group_gui_id (group), "color", buf); - - /* the group color change notification */ - - PBD::PropertyChange change; - change.add (Properties::color); - group->PropertyChanged (change); - - /* This is a bit of a hack, but this might change - our route's effective color, so emit gui_changed - for our routes. - */ - - emit_gui_changed_for_members (group); + PresentationInfo::ChangeSuspender cs; + group->set_rgba (color); } /** @return the ID string to use for the GUI state of a route group */ @@ -616,7 +782,15 @@ uint32_t GroupTabs::group_color (RouteGroup* group) { assert (group); - + + /* prefer libardour color, if set */ + uint32_t rgba = group->rgba (); + if (rgba != 0) { + return rgba; + } + + /* backwards compatibility, load old color */ + GUIObjectState& gui_state = *ARDOUR_UI::instance()->gui_object_state; string const gui_id = group_gui_id (group); bool empty; @@ -631,8 +805,7 @@ GroupTabs::group_color (RouteGroup* group) int r, g, b; - /* for historical reasons, colors are stored as 16 bit values. - */ + /* for historical reasons, colors are stored as 16 bit values. */ sscanf (color.c_str(), "%d:%d:%d", &r, &g, &b); @@ -640,6 +813,9 @@ GroupTabs::group_color (RouteGroup* group) g /= 256; b /= 256; + group->migrate_rgba (RGBA_TO_UINT (r, g, b, 255)); + gui_state.remove_node (gui_id); + return RGBA_TO_UINT (r, g, b, 255); } @@ -651,8 +827,8 @@ GroupTabs::route_group_property_changed (RouteGroup* rg) for our routes. */ - emit_gui_changed_for_members (rg); - + emit_gui_changed_for_members (rg->route_list ()); + set_dirty (); } @@ -666,7 +842,7 @@ GroupTabs::route_added_to_route_group (RouteGroup*, boost::weak_ptr w) return; } - r->gui_changed (X_("color"), 0); + r->presentation_info().PropertyChanged (Properties::color); set_dirty (); } @@ -681,15 +857,17 @@ GroupTabs::route_removed_from_route_group (RouteGroup*, boost::weak_ptr w return; } - r->gui_changed (X_("color"), 0); + r->presentation_info().PropertyChanged (Properties::color); set_dirty (); } void -GroupTabs::emit_gui_changed_for_members (RouteGroup* rg) +GroupTabs::emit_gui_changed_for_members (boost::shared_ptr rl) { - for (RouteList::iterator i = rg->route_list()->begin(); i != rg->route_list()->end(); ++i) { - (*i)->gui_changed (X_("color"), 0); + PresentationInfo::ChangeSuspender cs; + + for (RouteList::iterator i = rl->begin(); i != rl->end(); ++i) { + (*i)->presentation_info().PropertyChanged (Properties::color); } }